puppet 6.0.7-universal-darwin → 6.0.8-universal-darwin

Sign up to get free protection for your applications and to get access to all the features.

Potentially problematic release.


This version of puppet might be problematic. Click here for more details.

Files changed (632) hide show
  1. checksums.yaml +4 -4
  2. data/Gemfile +0 -1
  3. data/Gemfile.lock +4 -8
  4. data/lib/puppet/application/device.rb +99 -83
  5. data/lib/puppet/application/filebucket.rb +4 -0
  6. data/lib/puppet/configurer.rb +5 -4
  7. data/lib/puppet/defaults.rb +31 -11
  8. data/lib/puppet/indirector/request.rb +26 -15
  9. data/lib/puppet/network/http/connection.rb +15 -7
  10. data/lib/puppet/transaction/event_manager.rb +1 -5
  11. data/lib/puppet/type/file/source.rb +0 -1
  12. data/lib/puppet/util/connection.rb +15 -6
  13. data/lib/puppet/util/http_proxy.rb +3 -2
  14. data/lib/puppet/version.rb +1 -1
  15. data/locales/puppet.pot +99 -40
  16. data/man/man5/puppet.conf.5 +8 -8
  17. data/man/man8/puppet-agent.8 +1 -1
  18. data/man/man8/puppet-apply.8 +1 -1
  19. data/man/man8/puppet-catalog.8 +1 -1
  20. data/man/man8/puppet-config.8 +1 -1
  21. data/man/man8/puppet-describe.8 +1 -1
  22. data/man/man8/puppet-device.8 +1 -1
  23. data/man/man8/puppet-doc.8 +1 -1
  24. data/man/man8/puppet-epp.8 +1 -1
  25. data/man/man8/puppet-facts.8 +1 -1
  26. data/man/man8/puppet-filebucket.8 +1 -1
  27. data/man/man8/puppet-generate.8 +1 -1
  28. data/man/man8/puppet-help.8 +1 -1
  29. data/man/man8/puppet-key.8 +1 -1
  30. data/man/man8/puppet-lookup.8 +1 -1
  31. data/man/man8/puppet-man.8 +1 -1
  32. data/man/man8/puppet-module.8 +1 -1
  33. data/man/man8/puppet-node.8 +1 -1
  34. data/man/man8/puppet-parser.8 +1 -1
  35. data/man/man8/puppet-plugin.8 +1 -1
  36. data/man/man8/puppet-report.8 +1 -1
  37. data/man/man8/puppet-resource.8 +1 -1
  38. data/man/man8/puppet-script.8 +1 -1
  39. data/man/man8/puppet-ssl.8 +1 -1
  40. data/man/man8/puppet-status.8 +1 -1
  41. data/man/man8/puppet.8 +2 -2
  42. data/spec/integration/agent/logging_spec.rb +5 -7
  43. data/spec/integration/application/apply_spec.rb +18 -16
  44. data/spec/integration/application/doc_spec.rb +1 -2
  45. data/spec/integration/application/lookup_spec.rb +5 -5
  46. data/spec/integration/configurer_spec.rb +5 -6
  47. data/spec/integration/defaults_spec.rb +5 -6
  48. data/spec/integration/directory_environments_spec.rb +1 -1
  49. data/spec/integration/faces/config_spec.rb +3 -4
  50. data/spec/integration/faces/documentation_spec.rb +0 -1
  51. data/spec/integration/faces/plugin_spec.rb +1 -1
  52. data/spec/integration/file_bucket/file_spec.rb +2 -4
  53. data/spec/integration/file_serving/content_spec.rb +0 -1
  54. data/spec/integration/file_serving/fileset_spec.rb +0 -1
  55. data/spec/integration/file_serving/metadata_spec.rb +0 -1
  56. data/spec/integration/file_serving/terminus_helper_spec.rb +0 -1
  57. data/spec/integration/indirector/catalog/compiler_spec.rb +10 -11
  58. data/spec/integration/indirector/direct_file_server_spec.rb +1 -1
  59. data/spec/integration/indirector/facts/facter_spec.rb +4 -5
  60. data/spec/integration/indirector/file_content/file_server_spec.rb +7 -8
  61. data/spec/integration/indirector/file_metadata/file_server_spec.rb +7 -8
  62. data/spec/integration/network/authconfig_spec.rb +23 -24
  63. data/spec/integration/network/formats_spec.rb +0 -1
  64. data/spec/integration/node/environment_spec.rb +0 -1
  65. data/spec/integration/node/facts_spec.rb +9 -10
  66. data/spec/integration/node_spec.rb +6 -7
  67. data/spec/integration/parser/catalog_spec.rb +1 -5
  68. data/spec/integration/parser/collection_spec.rb +1 -2
  69. data/spec/integration/parser/compiler_spec.rb +6 -6
  70. data/spec/integration/parser/scope_spec.rb +1 -1
  71. data/spec/integration/parser/undef_param_spec.rb +1 -1
  72. data/spec/integration/provider/service/init_spec.rb +4 -5
  73. data/spec/integration/provider/service/systemd_spec.rb +0 -2
  74. data/spec/integration/provider/service/windows_spec.rb +1 -2
  75. data/spec/integration/reference/providers_spec.rb +1 -2
  76. data/spec/integration/reports_spec.rb +1 -2
  77. data/spec/integration/resource/catalog_spec.rb +14 -17
  78. data/spec/integration/resource/type_collection_spec.rb +4 -5
  79. data/spec/integration/ssl/certificate_request_spec.rb +0 -1
  80. data/spec/integration/ssl/host_spec.rb +1 -2
  81. data/spec/integration/ssl/key_spec.rb +0 -1
  82. data/spec/integration/test/test_helper_spec.rb +0 -1
  83. data/spec/integration/transaction/report_spec.rb +6 -11
  84. data/spec/integration/transaction_spec.rb +18 -19
  85. data/spec/integration/type/exec_spec.rb +0 -1
  86. data/spec/integration/type/file_spec.rb +13 -14
  87. data/spec/integration/type/package_spec.rb +19 -23
  88. data/spec/integration/type/tidy_spec.rb +1 -2
  89. data/spec/integration/type_spec.rb +0 -1
  90. data/spec/integration/util/autoload_spec.rb +1 -2
  91. data/spec/integration/util/rdoc/parser_spec.rb +0 -1
  92. data/spec/integration/util/settings_spec.rb +0 -1
  93. data/spec/integration/util/windows/adsi_spec.rb +3 -5
  94. data/spec/integration/util/windows/principal_spec.rb +0 -1
  95. data/spec/integration/util/windows/process_spec.rb +4 -6
  96. data/spec/integration/util/windows/registry_spec.rb +41 -51
  97. data/spec/integration/util/windows/security_spec.rb +2 -4
  98. data/spec/integration/util/windows/user_spec.rb +18 -20
  99. data/spec/integration/util_spec.rb +4 -7
  100. data/spec/lib/puppet_spec/compiler.rb +1 -1
  101. data/spec/lib/puppet_spec/files.rb +0 -1
  102. data/spec/lib/puppet_spec/module_tool/shared_functions.rb +1 -1
  103. data/spec/lib/puppet_spec/scope.rb +1 -2
  104. data/spec/shared_behaviours/all_parsedfile_providers.rb +1 -1
  105. data/spec/shared_behaviours/file_server_terminus.rb +8 -9
  106. data/spec/shared_behaviours/file_serving.rb +6 -8
  107. data/spec/shared_behaviours/file_serving_model.rb +3 -5
  108. data/spec/shared_behaviours/hiera_indirections.rb +3 -4
  109. data/spec/shared_behaviours/iterative_functions.rb +0 -1
  110. data/spec/shared_behaviours/memory_terminus.rb +2 -2
  111. data/spec/shared_examples/rhel_package_provider.rb +112 -70
  112. data/spec/spec_helper.rb +10 -1
  113. data/spec/unit/agent/disabler_spec.rb +4 -5
  114. data/spec/unit/agent/locker_spec.rb +12 -13
  115. data/spec/unit/agent_spec.rb +80 -85
  116. data/spec/unit/application/agent_spec.rb +88 -93
  117. data/spec/unit/application/apply_spec.rb +82 -83
  118. data/spec/unit/application/config_spec.rb +0 -1
  119. data/spec/unit/application/describe_spec.rb +6 -7
  120. data/spec/unit/application/device_spec.rb +395 -419
  121. data/spec/unit/application/doc_spec.rb +44 -46
  122. data/spec/unit/application/face_base_spec.rb +61 -62
  123. data/spec/unit/application/facts_spec.rb +3 -4
  124. data/spec/unit/application/filebucket_spec.rb +66 -74
  125. data/spec/unit/application/indirection_base_spec.rb +8 -6
  126. data/spec/unit/application/lookup_spec.rb +26 -26
  127. data/spec/unit/application/resource_spec.rb +42 -48
  128. data/spec/unit/application/ssl_spec.rb +3 -3
  129. data/spec/unit/application_spec.rb +82 -92
  130. data/spec/unit/capability_spec.rb +6 -6
  131. data/spec/unit/certificate_factory_spec.rb +3 -5
  132. data/spec/unit/configurer/downloader_spec.rb +20 -21
  133. data/spec/unit/configurer/fact_handler_spec.rb +2 -3
  134. data/spec/unit/configurer/plugin_handler_spec.rb +41 -8
  135. data/spec/unit/configurer_spec.rb +189 -192
  136. data/spec/unit/confine/exists_spec.rb +17 -15
  137. data/spec/unit/confine/false_spec.rb +5 -6
  138. data/spec/unit/confine/feature_spec.rb +7 -5
  139. data/spec/unit/confine/true_spec.rb +5 -6
  140. data/spec/unit/confine/variable_spec.rb +14 -15
  141. data/spec/unit/confine_collection_spec.rb +28 -29
  142. data/spec/unit/confine_spec.rb +13 -14
  143. data/spec/unit/confiner_spec.rb +10 -11
  144. data/spec/unit/context/trusted_information_spec.rb +1 -1
  145. data/spec/unit/daemon_spec.rb +35 -36
  146. data/spec/unit/data_providers/function_data_provider_spec.rb +0 -1
  147. data/spec/unit/data_providers/hiera_data_provider_spec.rb +0 -1
  148. data/spec/unit/datatypes_spec.rb +3 -4
  149. data/spec/unit/defaults_spec.rb +18 -13
  150. data/spec/unit/environments_spec.rb +7 -7
  151. data/spec/unit/etc_spec.rb +30 -32
  152. data/spec/unit/external/pson_spec.rb +0 -1
  153. data/spec/unit/face/catalog_spec.rb +0 -1
  154. data/spec/unit/face/config_spec.rb +31 -35
  155. data/spec/unit/face/epp_face_spec.rb +3 -4
  156. data/spec/unit/face/facts_spec.rb +5 -6
  157. data/spec/unit/face/generate_spec.rb +4 -5
  158. data/spec/unit/face/help_spec.rb +7 -8
  159. data/spec/unit/face/key_spec.rb +0 -1
  160. data/spec/unit/face/man_spec.rb +1 -2
  161. data/spec/unit/face/module/install_spec.rb +3 -5
  162. data/spec/unit/face/module/list_spec.rb +2 -12
  163. data/spec/unit/face/module/search_spec.rb +11 -9
  164. data/spec/unit/face/module/uninstall_spec.rb +4 -8
  165. data/spec/unit/face/node_spec.rb +23 -24
  166. data/spec/unit/face/parser_spec.rb +3 -3
  167. data/spec/unit/face/plugin_spec.rb +36 -9
  168. data/spec/unit/face/status_spec.rb +0 -1
  169. data/spec/unit/file_bucket/dipper_spec.rb +24 -20
  170. data/spec/unit/file_bucket/file_spec.rb +0 -2
  171. data/spec/unit/file_serving/base_spec.rb +14 -15
  172. data/spec/unit/file_serving/configuration/parser_spec.rb +27 -28
  173. data/spec/unit/file_serving/configuration_spec.rb +63 -66
  174. data/spec/unit/file_serving/content_spec.rb +10 -11
  175. data/spec/unit/file_serving/fileset_spec.rb +63 -58
  176. data/spec/unit/file_serving/http_metadata_spec.rb +8 -7
  177. data/spec/unit/file_serving/metadata_spec.rb +36 -36
  178. data/spec/unit/file_serving/mount/file_spec.rb +31 -32
  179. data/spec/unit/file_serving/mount/locales_spec.rb +23 -24
  180. data/spec/unit/file_serving/mount/modules_spec.rb +14 -15
  181. data/spec/unit/file_serving/mount/pluginfacts_spec.rb +23 -24
  182. data/spec/unit/file_serving/mount/plugins_spec.rb +23 -24
  183. data/spec/unit/file_serving/mount/tasks_spec.rb +14 -15
  184. data/spec/unit/file_serving/mount_spec.rb +0 -1
  185. data/spec/unit/file_serving/terminus_helper_spec.rb +37 -42
  186. data/spec/unit/file_serving/terminus_selector_spec.rb +12 -13
  187. data/spec/unit/file_system/uniquefile_spec.rb +4 -4
  188. data/spec/unit/file_system_spec.rb +2 -2
  189. data/spec/unit/forge/errors_spec.rb +1 -1
  190. data/spec/unit/forge/forge_spec.rb +13 -14
  191. data/spec/unit/forge/module_release_spec.rb +18 -18
  192. data/spec/unit/forge/repository_spec.rb +29 -30
  193. data/spec/unit/forge_spec.rb +15 -11
  194. data/spec/unit/functions/binary_file_spec.rb +3 -3
  195. data/spec/unit/functions/contain_spec.rb +0 -2
  196. data/spec/unit/functions/defined_spec.rb +0 -1
  197. data/spec/unit/functions/epp_spec.rb +2 -2
  198. data/spec/unit/functions/find_file_spec.rb +7 -7
  199. data/spec/unit/functions/include_spec.rb +0 -4
  200. data/spec/unit/functions/lookup_fixture_spec.rb +0 -1
  201. data/spec/unit/functions/lookup_spec.rb +1 -2
  202. data/spec/unit/functions/module_directory_spec.rb +12 -12
  203. data/spec/unit/functions/require_spec.rb +0 -3
  204. data/spec/unit/functions/shared.rb +5 -8
  205. data/spec/unit/functions/versioncmp_spec.rb +1 -2
  206. data/spec/unit/functions4_spec.rb +9 -10
  207. data/spec/unit/gettext/config_spec.rb +4 -4
  208. data/spec/unit/gettext/module_loading_spec.rb +7 -7
  209. data/spec/unit/graph/rb_tree_map_spec.rb +0 -2
  210. data/spec/unit/graph/relationship_graph_spec.rb +1 -2
  211. data/spec/unit/graph/simple_graph_spec.rb +9 -10
  212. data/spec/unit/hiera_puppet_spec.rb +20 -20
  213. data/spec/unit/indirector/catalog/compiler_spec.rb +147 -149
  214. data/spec/unit/indirector/catalog/json_spec.rb +1 -2
  215. data/spec/unit/indirector/catalog/msgpack_spec.rb +0 -1
  216. data/spec/unit/indirector/catalog/rest_spec.rb +0 -1
  217. data/spec/unit/indirector/catalog/store_configs_spec.rb +0 -1
  218. data/spec/unit/indirector/catalog/yaml_spec.rb +0 -1
  219. data/spec/unit/indirector/certificate/file_spec.rb +0 -1
  220. data/spec/unit/indirector/certificate/rest_spec.rb +8 -10
  221. data/spec/unit/indirector/certificate_request/file_spec.rb +0 -1
  222. data/spec/unit/indirector/certificate_request/rest_spec.rb +0 -1
  223. data/spec/unit/indirector/direct_file_server_spec.rb +17 -18
  224. data/spec/unit/indirector/envelope_spec.rb +1 -2
  225. data/spec/unit/indirector/exec_spec.rb +4 -5
  226. data/spec/unit/indirector/face_spec.rb +9 -9
  227. data/spec/unit/indirector/facts/facter_spec.rb +37 -43
  228. data/spec/unit/indirector/facts/network_device_spec.rb +8 -9
  229. data/spec/unit/indirector/facts/rest_spec.rb +7 -8
  230. data/spec/unit/indirector/facts/store_configs_spec.rb +0 -1
  231. data/spec/unit/indirector/facts/yaml_spec.rb +0 -1
  232. data/spec/unit/indirector/file_bucket_file/file_spec.rb +3 -4
  233. data/spec/unit/indirector/file_bucket_file/rest_spec.rb +0 -1
  234. data/spec/unit/indirector/file_bucket_file/selector_spec.rb +4 -5
  235. data/spec/unit/indirector/file_content/file_server_spec.rb +0 -1
  236. data/spec/unit/indirector/file_content/file_spec.rb +0 -1
  237. data/spec/unit/indirector/file_content/rest_spec.rb +0 -1
  238. data/spec/unit/indirector/file_content/selector_spec.rb +0 -1
  239. data/spec/unit/indirector/file_metadata/file_server_spec.rb +0 -1
  240. data/spec/unit/indirector/file_metadata/file_spec.rb +12 -13
  241. data/spec/unit/indirector/file_metadata/rest_spec.rb +0 -1
  242. data/spec/unit/indirector/file_metadata/selector_spec.rb +0 -1
  243. data/spec/unit/indirector/file_server_spec.rb +87 -87
  244. data/spec/unit/indirector/indirection_spec.rb +242 -226
  245. data/spec/unit/indirector/json_spec.rb +7 -9
  246. data/spec/unit/indirector/key/file_spec.rb +21 -22
  247. data/spec/unit/indirector/memory_spec.rb +6 -7
  248. data/spec/unit/indirector/msgpack_spec.rb +7 -9
  249. data/spec/unit/indirector/node/exec_spec.rb +2 -3
  250. data/spec/unit/indirector/node/memory_spec.rb +2 -4
  251. data/spec/unit/indirector/node/msgpack_spec.rb +0 -1
  252. data/spec/unit/indirector/node/plain_spec.rb +2 -4
  253. data/spec/unit/indirector/node/rest_spec.rb +0 -1
  254. data/spec/unit/indirector/node/store_configs_spec.rb +0 -1
  255. data/spec/unit/indirector/node/yaml_spec.rb +0 -1
  256. data/spec/unit/indirector/none_spec.rb +5 -5
  257. data/spec/unit/indirector/plain_spec.rb +7 -8
  258. data/spec/unit/indirector/report/msgpack_spec.rb +0 -1
  259. data/spec/unit/indirector/report/processor_spec.rb +21 -22
  260. data/spec/unit/indirector/report/rest_spec.rb +11 -12
  261. data/spec/unit/indirector/report/yaml_spec.rb +0 -1
  262. data/spec/unit/indirector/request_spec.rb +11 -12
  263. data/spec/unit/indirector/resource/ral_spec.rb +46 -54
  264. data/spec/unit/indirector/resource/store_configs_spec.rb +0 -1
  265. data/spec/unit/indirector/rest_spec.rb +113 -110
  266. data/spec/unit/indirector/ssl_file_spec.rb +64 -65
  267. data/spec/unit/indirector/status/local_spec.rb +0 -1
  268. data/spec/unit/indirector/status/rest_spec.rb +0 -1
  269. data/spec/unit/indirector/store_configs_spec.rb +0 -1
  270. data/spec/unit/indirector/terminus_spec.rb +27 -27
  271. data/spec/unit/indirector/yaml_spec.rb +5 -6
  272. data/spec/unit/indirector_spec.rb +1 -2
  273. data/spec/unit/info_service_spec.rb +1 -1
  274. data/spec/unit/interface/action_builder_spec.rb +0 -1
  275. data/spec/unit/interface/action_manager_spec.rb +0 -1
  276. data/spec/unit/interface/action_spec.rb +2 -3
  277. data/spec/unit/interface/documentation_spec.rb +0 -1
  278. data/spec/unit/interface/face_collection_spec.rb +19 -12
  279. data/spec/unit/interface_spec.rb +3 -3
  280. data/spec/unit/man_spec.rb +3 -4
  281. data/spec/unit/module_spec.rb +46 -51
  282. data/spec/unit/module_tool/applications/installer_spec.rb +10 -11
  283. data/spec/unit/module_tool/applications/searcher_spec.rb +3 -3
  284. data/spec/unit/module_tool/applications/uninstaller_spec.rb +1 -2
  285. data/spec/unit/module_tool/applications/unpacker_spec.rb +13 -13
  286. data/spec/unit/module_tool/applications/upgrader_spec.rb +5 -5
  287. data/spec/unit/module_tool/install_directory_spec.rb +8 -8
  288. data/spec/unit/module_tool/installed_modules_spec.rb +3 -3
  289. data/spec/unit/module_tool/tar/gnu_spec.rb +6 -6
  290. data/spec/unit/module_tool/tar/mini_spec.rb +12 -12
  291. data/spec/unit/module_tool/tar_spec.rb +12 -13
  292. data/spec/unit/module_tool_spec.rb +7 -12
  293. data/spec/unit/network/auth_config_parser_spec.rb +11 -13
  294. data/spec/unit/network/authconfig_spec.rb +17 -18
  295. data/spec/unit/network/authorization_spec.rb +4 -5
  296. data/spec/unit/network/authstore_spec.rb +0 -1
  297. data/spec/unit/network/format_handler_spec.rb +0 -1
  298. data/spec/unit/network/format_spec.rb +9 -10
  299. data/spec/unit/network/format_support_spec.rb +28 -29
  300. data/spec/unit/network/formats_spec.rb +4 -5
  301. data/spec/unit/network/http/api/indirected_routes_spec.rb +24 -29
  302. data/spec/unit/network/http/api/master/v3/authorization_spec.rb +2 -2
  303. data/spec/unit/network/http/api/master/v3/environment_spec.rb +1 -1
  304. data/spec/unit/network/http/api/master/v3/environments_spec.rb +6 -7
  305. data/spec/unit/network/http/api_spec.rb +0 -2
  306. data/spec/unit/network/http/compression_spec.rb +21 -22
  307. data/spec/unit/network/http/connection_spec.rb +41 -36
  308. data/spec/unit/network/http/factory_spec.rb +5 -6
  309. data/spec/unit/network/http/handler_spec.rb +9 -18
  310. data/spec/unit/network/http/nocache_pool_spec.rb +6 -7
  311. data/spec/unit/network/http/pool_spec.rb +28 -29
  312. data/spec/unit/network/http/request_spec.rb +0 -2
  313. data/spec/unit/network/http/response_spec.rb +11 -13
  314. data/spec/unit/network/http/route_spec.rb +0 -1
  315. data/spec/unit/network/http/session_spec.rb +1 -2
  316. data/spec/unit/network/http/site_spec.rb +0 -1
  317. data/spec/unit/network/http_pool_spec.rb +18 -9
  318. data/spec/unit/network/http_spec.rb +0 -1
  319. data/spec/unit/network/resolver_spec.rb +25 -26
  320. data/spec/unit/network/rights_spec.rb +52 -53
  321. data/spec/unit/node/environment_spec.rb +14 -15
  322. data/spec/unit/node/facts_spec.rb +5 -7
  323. data/spec/unit/node_spec.rb +4 -10
  324. data/spec/unit/other/selinux_spec.rb +0 -1
  325. data/spec/unit/parameter/boolean_spec.rb +1 -2
  326. data/spec/unit/parameter/package_options_spec.rb +1 -2
  327. data/spec/unit/parameter/path_spec.rb +0 -1
  328. data/spec/unit/parameter/value_collection_spec.rb +0 -1
  329. data/spec/unit/parameter/value_spec.rb +0 -1
  330. data/spec/unit/parameter_spec.rb +9 -9
  331. data/spec/unit/parser/ast/block_expression_spec.rb +6 -8
  332. data/spec/unit/parser/ast/leaf_spec.rb +20 -21
  333. data/spec/unit/parser/compiler_spec.rb +84 -96
  334. data/spec/unit/parser/environment_compiler_spec.rb +7 -8
  335. data/spec/unit/parser/files_spec.rb +0 -1
  336. data/spec/unit/parser/functions/create_resources_spec.rb +1 -1
  337. data/spec/unit/parser/functions/digest_spec.rb +0 -1
  338. data/spec/unit/parser/functions/fail_spec.rb +1 -2
  339. data/spec/unit/parser/functions/file_spec.rb +13 -14
  340. data/spec/unit/parser/functions/fqdn_rand_spec.rb +5 -6
  341. data/spec/unit/parser/functions/generate_spec.rb +7 -8
  342. data/spec/unit/parser/functions/inline_template_spec.rb +0 -1
  343. data/spec/unit/parser/functions/regsubst_spec.rb +0 -1
  344. data/spec/unit/parser/functions/scanf_spec.rb +0 -1
  345. data/spec/unit/parser/functions/shellquote_spec.rb +0 -1
  346. data/spec/unit/parser/functions/split_spec.rb +0 -1
  347. data/spec/unit/parser/functions/sprintf_spec.rb +0 -1
  348. data/spec/unit/parser/functions/tag_spec.rb +1 -2
  349. data/spec/unit/parser/functions/tagged_spec.rb +2 -3
  350. data/spec/unit/parser/functions/template_spec.rb +13 -13
  351. data/spec/unit/parser/functions/versioncmp_spec.rb +1 -2
  352. data/spec/unit/parser/functions_spec.rb +6 -7
  353. data/spec/unit/parser/relationship_spec.rb +0 -1
  354. data/spec/unit/parser/resource_spec.rb +42 -42
  355. data/spec/unit/parser/scope_spec.rb +39 -35
  356. data/spec/unit/parser/templatewrapper_spec.rb +11 -12
  357. data/spec/unit/parser/type_loader_spec.rb +17 -19
  358. data/spec/unit/pops/adaptable_spec.rb +0 -1
  359. data/spec/unit/pops/benchmark_spec.rb +0 -1
  360. data/spec/unit/pops/evaluator/access_ops_spec.rb +0 -1
  361. data/spec/unit/pops/evaluator/arithmetic_ops_spec.rb +0 -1
  362. data/spec/unit/pops/evaluator/basic_expressions_spec.rb +0 -1
  363. data/spec/unit/pops/evaluator/collections_ops_spec.rb +0 -1
  364. data/spec/unit/pops/evaluator/comparison_ops_spec.rb +0 -1
  365. data/spec/unit/pops/evaluator/conditionals_spec.rb +0 -1
  366. data/spec/unit/pops/evaluator/evaluating_parser_spec.rb +10 -11
  367. data/spec/unit/pops/evaluator/logical_ops_spec.rb +0 -1
  368. data/spec/unit/pops/evaluator/runtime3_converter_spec.rb +0 -1
  369. data/spec/unit/pops/evaluator/string_interpolation_spec.rb +0 -1
  370. data/spec/unit/pops/evaluator/variables_spec.rb +0 -1
  371. data/spec/unit/pops/factory_spec.rb +3 -4
  372. data/spec/unit/pops/issues_spec.rb +19 -20
  373. data/spec/unit/pops/loaders/loader_spec.rb +8 -4
  374. data/spec/unit/pops/loaders/loaders_spec.rb +31 -28
  375. data/spec/unit/pops/lookup/context_spec.rb +0 -1
  376. data/spec/unit/pops/lookup/interpolation_spec.rb +2 -3
  377. data/spec/unit/pops/merge_strategy_spec.rb +0 -1
  378. data/spec/unit/pops/migration_spec.rb +3 -5
  379. data/spec/unit/pops/model/model_spec.rb +0 -1
  380. data/spec/unit/pops/model/pn_transformer_spec.rb +0 -1
  381. data/spec/unit/pops/parser/locator_spec.rb +3 -6
  382. data/spec/unit/pops/parser/parse_application_spec.rb +0 -1
  383. data/spec/unit/pops/parser/parse_basic_expressions_spec.rb +0 -1
  384. data/spec/unit/pops/parser/parse_calls_spec.rb +0 -1
  385. data/spec/unit/pops/parser/parse_capabilities_spec.rb +0 -1
  386. data/spec/unit/pops/parser/parse_conditionals_spec.rb +0 -1
  387. data/spec/unit/pops/parser/parse_containers_spec.rb +0 -1
  388. data/spec/unit/pops/parser/parse_plan_spec.rb +0 -1
  389. data/spec/unit/pops/parser/parse_resource_spec.rb +0 -1
  390. data/spec/unit/pops/parser/parse_site_spec.rb +0 -1
  391. data/spec/unit/pops/parser/pn_parser_spec.rb +0 -1
  392. data/spec/unit/pops/pn_spec.rb +0 -1
  393. data/spec/unit/pops/resource/resource_type_impl_spec.rb +0 -1
  394. data/spec/unit/pops/serialization/serialization_spec.rb +1 -1
  395. data/spec/unit/pops/serialization/to_from_hr_spec.rb +1 -1
  396. data/spec/unit/pops/types/recursion_guard_spec.rb +10 -10
  397. data/spec/unit/pops/types/ruby_generator_spec.rb +2 -2
  398. data/spec/unit/pops/types/type_asserter_spec.rb +2 -2
  399. data/spec/unit/pops/types/type_calculator_spec.rb +30 -30
  400. data/spec/unit/pops/types/type_parser_spec.rb +13 -13
  401. data/spec/unit/pops/validator/validator_spec.rb +1 -2
  402. data/spec/unit/pops/visitor_spec.rb +0 -1
  403. data/spec/unit/property/boolean_spec.rb +1 -1
  404. data/spec/unit/property/ensure_spec.rb +0 -1
  405. data/spec/unit/property/keyvalue_spec.rb +32 -34
  406. data/spec/unit/property/list_spec.rb +26 -27
  407. data/spec/unit/property/ordered_list_spec.rb +10 -14
  408. data/spec/unit/property_spec.rb +42 -43
  409. data/spec/unit/provider/aix_object_spec.rb +47 -45
  410. data/spec/unit/provider/command_spec.rb +9 -9
  411. data/spec/unit/provider/exec/posix_spec.rb +6 -7
  412. data/spec/unit/provider/exec/shell_spec.rb +0 -1
  413. data/spec/unit/provider/exec/windows_spec.rb +2 -4
  414. data/spec/unit/provider/exec_spec.rb +0 -1
  415. data/spec/unit/provider/file/posix_spec.rb +22 -24
  416. data/spec/unit/provider/file/windows_spec.rb +15 -17
  417. data/spec/unit/provider/group/aix_spec.rb +3 -2
  418. data/spec/unit/provider/group/groupadd_spec.rb +30 -26
  419. data/spec/unit/provider/group/ldap_spec.rb +18 -18
  420. data/spec/unit/provider/group/pw_spec.rb +11 -11
  421. data/spec/unit/provider/group/windows_adsi_spec.rb +54 -54
  422. data/spec/unit/provider/ldap_spec.rb +61 -62
  423. data/spec/unit/provider/nameservice/directoryservice_spec.rb +35 -36
  424. data/spec/unit/provider/nameservice_spec.rb +38 -40
  425. data/spec/unit/provider/package/aix_spec.rb +15 -15
  426. data/spec/unit/provider/package/appdmg_spec.rb +13 -13
  427. data/spec/unit/provider/package/apt_spec.rb +44 -27
  428. data/spec/unit/provider/package/aptitude_spec.rb +6 -7
  429. data/spec/unit/provider/package/aptrpm_spec.rb +7 -12
  430. data/spec/unit/provider/package/base_spec.rb +4 -4
  431. data/spec/unit/provider/package/dnf_spec.rb +18 -20
  432. data/spec/unit/provider/package/dpkg_spec.rb +52 -52
  433. data/spec/unit/provider/package/freebsd_spec.rb +11 -11
  434. data/spec/unit/provider/package/gem_spec.rb +51 -43
  435. data/spec/unit/provider/package/hpux_spec.rb +8 -8
  436. data/spec/unit/provider/package/macports_spec.rb +46 -42
  437. data/spec/unit/provider/package/nim_spec.rb +30 -39
  438. data/spec/unit/provider/package/openbsd_spec.rb +36 -39
  439. data/spec/unit/provider/package/opkg_spec.rb +23 -26
  440. data/spec/unit/provider/package/pacman_spec.rb +97 -118
  441. data/spec/unit/provider/package/pip_spec.rb +71 -72
  442. data/spec/unit/provider/package/pkg_spec.rb +109 -109
  443. data/spec/unit/provider/package/pkgdmg_spec.rb +65 -63
  444. data/spec/unit/provider/package/pkgin_spec.rb +10 -8
  445. data/spec/unit/provider/package/pkgng_spec.rb +17 -18
  446. data/spec/unit/provider/package/pkgutil_spec.rb +45 -49
  447. data/spec/unit/provider/package/portage_spec.rb +70 -74
  448. data/spec/unit/provider/package/puppet_gem_spec.rb +28 -8
  449. data/spec/unit/provider/package/rpm_spec.rb +53 -64
  450. data/spec/unit/provider/package/sun_spec.rb +16 -18
  451. data/spec/unit/provider/package/tdnf_spec.rb +2 -2
  452. data/spec/unit/provider/package/up2date_spec.rb +2 -4
  453. data/spec/unit/provider/package/urpmi_spec.rb +15 -17
  454. data/spec/unit/provider/package/windows/exe_package_spec.rb +12 -15
  455. data/spec/unit/provider/package/windows/msi_package_spec.rb +19 -22
  456. data/spec/unit/provider/package/windows/package_spec.rb +37 -42
  457. data/spec/unit/provider/package/windows_spec.rb +36 -32
  458. data/spec/unit/provider/package/yum_spec.rb +7 -7
  459. data/spec/unit/provider/package/zypper_spec.rb +87 -87
  460. data/spec/unit/provider/parsedfile_spec.rb +44 -45
  461. data/spec/unit/provider/service/base_spec.rb +4 -5
  462. data/spec/unit/provider/service/bsd_spec.rb +27 -29
  463. data/spec/unit/provider/service/daemontools_spec.rb +35 -35
  464. data/spec/unit/provider/service/debian_spec.rb +38 -38
  465. data/spec/unit/provider/service/freebsd_spec.rb +18 -18
  466. data/spec/unit/provider/service/gentoo_spec.rb +50 -55
  467. data/spec/unit/provider/service/init_spec.rb +53 -52
  468. data/spec/unit/provider/service/launchd_spec.rb +138 -116
  469. data/spec/unit/provider/service/openbsd_spec.rb +50 -50
  470. data/spec/unit/provider/service/openrc_spec.rb +43 -45
  471. data/spec/unit/provider/service/openwrt_spec.rb +26 -31
  472. data/spec/unit/provider/service/rcng_spec.rb +14 -14
  473. data/spec/unit/provider/service/redhat_spec.rb +45 -43
  474. data/spec/unit/provider/service/runit_spec.rb +29 -27
  475. data/spec/unit/provider/service/smf_spec.rb +74 -66
  476. data/spec/unit/provider/service/src_spec.rb +46 -47
  477. data/spec/unit/provider/service/systemd_spec.rb +104 -113
  478. data/spec/unit/provider/service/upstart_spec.rb +74 -71
  479. data/spec/unit/provider/service/windows_spec.rb +33 -41
  480. data/spec/unit/provider/user/aix_spec.rb +31 -31
  481. data/spec/unit/provider/user/directoryservice_spec.rb +109 -114
  482. data/spec/unit/provider/user/hpux_spec.rb +16 -16
  483. data/spec/unit/provider/user/ldap_spec.rb +57 -57
  484. data/spec/unit/provider/user/openbsd_spec.rb +10 -12
  485. data/spec/unit/provider/user/pw_spec.rb +37 -35
  486. data/spec/unit/provider/user/user_role_add_spec.rb +93 -93
  487. data/spec/unit/provider/user/useradd_spec.rb +93 -92
  488. data/spec/unit/provider/user/windows_adsi_spec.rb +59 -60
  489. data/spec/unit/provider_spec.rb +35 -35
  490. data/spec/unit/puppet_pal_2pec.rb +4 -5
  491. data/spec/unit/puppet_pal_spec.rb +0 -1
  492. data/spec/unit/puppet_spec.rb +6 -7
  493. data/spec/unit/relationship_spec.rb +0 -1
  494. data/spec/unit/reports/http_spec.rb +21 -23
  495. data/spec/unit/reports/store_spec.rb +3 -4
  496. data/spec/unit/reports_spec.rb +12 -14
  497. data/spec/unit/resource/capability_finder_spec.rb +15 -17
  498. data/spec/unit/resource/catalog_spec.rb +72 -68
  499. data/spec/unit/resource/status_spec.rb +6 -8
  500. data/spec/unit/resource/type_collection_spec.rb +17 -18
  501. data/spec/unit/resource/type_spec.rb +34 -35
  502. data/spec/unit/resource_spec.rb +36 -32
  503. data/spec/unit/rest/client_spec.rb +58 -27
  504. data/spec/unit/rest/route_spec.rb +5 -5
  505. data/spec/unit/scheduler/job_spec.rb +0 -1
  506. data/spec/unit/scheduler/scheduler_spec.rb +0 -1
  507. data/spec/unit/scheduler/splay_job_spec.rb +1 -2
  508. data/spec/unit/settings/array_setting_spec.rb +1 -1
  509. data/spec/unit/settings/autosign_setting_spec.rb +9 -9
  510. data/spec/unit/settings/certificate_revocation_setting_spec.rb +1 -1
  511. data/spec/unit/settings/config_file_spec.rb +0 -1
  512. data/spec/unit/settings/directory_setting_spec.rb +2 -7
  513. data/spec/unit/settings/duration_setting_spec.rb +1 -2
  514. data/spec/unit/settings/enum_setting_spec.rb +1 -1
  515. data/spec/unit/settings/environment_conf_spec.rb +4 -6
  516. data/spec/unit/settings/file_setting_spec.rb +44 -46
  517. data/spec/unit/settings/path_setting_spec.rb +1 -2
  518. data/spec/unit/settings/priority_setting_spec.rb +1 -2
  519. data/spec/unit/settings/string_setting_spec.rb +14 -15
  520. data/spec/unit/settings/terminus_setting_spec.rb +1 -2
  521. data/spec/unit/settings/value_translator_spec.rb +0 -1
  522. data/spec/unit/settings_spec.rb +228 -235
  523. data/spec/unit/ssl/base_spec.rb +14 -15
  524. data/spec/unit/ssl/certificate_request_spec.rb +62 -58
  525. data/spec/unit/ssl/certificate_spec.rb +23 -25
  526. data/spec/unit/ssl/digest_spec.rb +0 -1
  527. data/spec/unit/ssl/host_spec.rb +166 -149
  528. data/spec/unit/ssl/key_spec.rb +30 -31
  529. data/spec/unit/ssl/validator_spec.rb +38 -39
  530. data/spec/unit/task_spec.rb +44 -45
  531. data/spec/unit/transaction/additional_resource_generator_spec.rb +3 -5
  532. data/spec/unit/transaction/event_manager_spec.rb +87 -88
  533. data/spec/unit/transaction/event_spec.rb +16 -15
  534. data/spec/unit/transaction/persistence_spec.rb +16 -17
  535. data/spec/unit/transaction/report_spec.rb +11 -12
  536. data/spec/unit/transaction/resource_harness_spec.rb +28 -33
  537. data/spec/unit/transaction_spec.rb +100 -101
  538. data/spec/unit/type/component_spec.rb +0 -1
  539. data/spec/unit/type/exec_spec.rb +60 -56
  540. data/spec/unit/type/file/checksum_spec.rb +9 -10
  541. data/spec/unit/type/file/checksum_value_spec.rb +31 -32
  542. data/spec/unit/type/file/content_spec.rb +58 -61
  543. data/spec/unit/type/file/ctime_spec.rb +0 -1
  544. data/spec/unit/type/file/ensure_spec.rb +12 -13
  545. data/spec/unit/type/file/group_spec.rb +5 -7
  546. data/spec/unit/type/file/mode_spec.rb +4 -6
  547. data/spec/unit/type/file/mtime_spec.rb +0 -1
  548. data/spec/unit/type/file/owner_spec.rb +6 -8
  549. data/spec/unit/type/file/selinux_spec.rb +17 -19
  550. data/spec/unit/type/file/source_spec.rb +104 -101
  551. data/spec/unit/type/file/type_spec.rb +0 -1
  552. data/spec/unit/type/file_spec.rb +195 -185
  553. data/spec/unit/type/filebucket_spec.rb +4 -5
  554. data/spec/unit/type/group_spec.rb +6 -8
  555. data/spec/unit/type/noop_metaparam_spec.rb +1 -2
  556. data/spec/unit/type/package/package_settings_spec.rb +44 -23
  557. data/spec/unit/type/package_spec.rb +56 -57
  558. data/spec/unit/type/resources_spec.rb +72 -74
  559. data/spec/unit/type/schedule_spec.rb +24 -26
  560. data/spec/unit/type/service_spec.rb +48 -48
  561. data/spec/unit/type/stage_spec.rb +0 -1
  562. data/spec/unit/type/tidy_spec.rb +61 -62
  563. data/spec/unit/type/user_spec.rb +24 -25
  564. data/spec/unit/type/whit_spec.rb +0 -1
  565. data/spec/unit/type_spec.rb +55 -54
  566. data/spec/unit/util/at_fork_spec.rb +18 -19
  567. data/spec/unit/util/autoload_spec.rb +55 -56
  568. data/spec/unit/util/backups_spec.rb +34 -35
  569. data/spec/unit/util/character_encoding_spec.rb +5 -5
  570. data/spec/unit/util/checksums_spec.rb +38 -39
  571. data/spec/unit/util/colors_spec.rb +1 -2
  572. data/spec/unit/util/command_line_spec.rb +24 -25
  573. data/spec/unit/util/constant_inflector_spec.rb +0 -1
  574. data/spec/unit/util/diff_spec.rb +7 -8
  575. data/spec/unit/util/errors_spec.rb +0 -1
  576. data/spec/unit/util/execution_spec.rb +185 -161
  577. data/spec/unit/util/execution_stub_spec.rb +0 -1
  578. data/spec/unit/util/feature_spec.rb +21 -14
  579. data/spec/unit/util/filetype_spec.rb +49 -49
  580. data/spec/unit/util/http_proxy_spec.rb +12 -12
  581. data/spec/unit/util/inifile_spec.rb +26 -31
  582. data/spec/unit/util/json_lockfile_spec.rb +3 -5
  583. data/spec/unit/util/ldap/connection_spec.rb +26 -25
  584. data/spec/unit/util/ldap/generator_spec.rb +0 -1
  585. data/spec/unit/util/ldap/manager_spec.rb +102 -101
  586. data/spec/unit/util/lockfile_spec.rb +0 -1
  587. data/spec/unit/util/log/destinations_spec.rb +30 -33
  588. data/spec/unit/util/log_spec.rb +35 -36
  589. data/spec/unit/util/logging_spec.rb +58 -72
  590. data/spec/unit/util/metric_spec.rb +0 -1
  591. data/spec/unit/util/monkey_patches_spec.rb +7 -9
  592. data/spec/unit/util/multi_match_spec.rb +0 -1
  593. data/spec/unit/util/network_device/config_spec.rb +0 -1
  594. data/spec/unit/util/network_device/transport/base_spec.rb +5 -6
  595. data/spec/unit/util/network_device_spec.rb +7 -9
  596. data/spec/unit/util/package_spec.rb +0 -1
  597. data/spec/unit/util/pidlock_spec.rb +21 -22
  598. data/spec/unit/util/plist_spec.rb +40 -33
  599. data/spec/unit/util/posix_spec.rb +54 -51
  600. data/spec/unit/util/rdoc_spec.rb +9 -10
  601. data/spec/unit/util/reference_spec.rb +0 -1
  602. data/spec/unit/util/resource_template_spec.rb +20 -20
  603. data/spec/unit/util/retry_action_spec.rb +7 -8
  604. data/spec/unit/util/rubygems_spec.rb +7 -8
  605. data/spec/unit/util/run_mode_spec.rb +3 -4
  606. data/spec/unit/util/selinux_spec.rb +79 -72
  607. data/spec/unit/util/splayer_spec.rb +8 -9
  608. data/spec/unit/util/ssl_spec.rb +0 -1
  609. data/spec/unit/util/storage_spec.rb +3 -4
  610. data/spec/unit/util/suidmanager_spec.rb +45 -54
  611. data/spec/unit/util/symbolic_file_mode_spec.rb +0 -1
  612. data/spec/unit/util/tag_set_spec.rb +0 -1
  613. data/spec/unit/util/tagging_spec.rb +0 -1
  614. data/spec/unit/util/terminal_spec.rb +9 -10
  615. data/spec/unit/util/user_attr_spec.rb +1 -2
  616. data/spec/unit/util/warnings_spec.rb +3 -4
  617. data/spec/unit/util/watcher/periodic_watcher_spec.rb +2 -2
  618. data/spec/unit/util/watcher_spec.rb +51 -21
  619. data/spec/unit/util/windows/access_control_entry_spec.rb +0 -1
  620. data/spec/unit/util/windows/access_control_list_spec.rb +0 -1
  621. data/spec/unit/util/windows/adsi_spec.rb +136 -138
  622. data/spec/unit/util/windows/api_types_spec.rb +0 -1
  623. data/spec/unit/util/windows/eventlog_spec.rb +9 -12
  624. data/spec/unit/util/windows/file_spec.rb +0 -1
  625. data/spec/unit/util/windows/root_certs_spec.rb +0 -1
  626. data/spec/unit/util/windows/security_descriptor_spec.rb +0 -2
  627. data/spec/unit/util/windows/service_spec.rb +66 -68
  628. data/spec/unit/util/windows/sid_spec.rb +11 -13
  629. data/spec/unit/util/windows/string_spec.rb +0 -1
  630. data/spec/unit/util_spec.rb +55 -57
  631. data/spec/unit/version_spec.rb +6 -6
  632. metadata +2 -2
@@ -1,5 +1,3 @@
1
- #! /usr/bin/env ruby
2
-
3
1
  require 'spec_helper'
4
2
  require 'puppet/node/facts'
5
3
  require 'matchers/json'
@@ -97,14 +95,14 @@ describe Puppet::Node::Facts, "when indirecting" do
97
95
 
98
96
  describe "when indirecting" do
99
97
  before do
100
- @indirection = stub 'indirection', :request => mock('request'), :name => :facts
98
+ @indirection = double('indirection', :request => double('request'), :name => :facts)
101
99
 
102
100
  @facts = Puppet::Node::Facts.new("me", "one" => "two")
103
101
  end
104
102
 
105
103
  it "should redirect to the specified fact store for storage" do
106
- Puppet::Node::Facts.stubs(:indirection).returns(@indirection)
107
- @indirection.expects(:save)
104
+ allow(Puppet::Node::Facts).to receive(:indirection).and_return(@indirection)
105
+ expect(@indirection).to receive(:save)
108
106
  Puppet::Node::Facts.indirection.save(@facts)
109
107
  end
110
108
 
@@ -190,7 +188,7 @@ describe Puppet::Node::Facts, "when indirecting" do
190
188
  end
191
189
 
192
190
  it "should generate properly formatted json" do
193
- Time.stubs(:now).returns(@timestamp)
191
+ allow(Time).to receive(:now).and_return(@timestamp)
194
192
  facts = Puppet::Node::Facts.new("foo", {'a' => 1, 'b' => 2, 'c' => 3})
195
193
  facts.expiration = @expiration
196
194
  result = JSON.parse(facts.to_json)
@@ -201,7 +199,7 @@ describe Puppet::Node::Facts, "when indirecting" do
201
199
  end
202
200
 
203
201
  it "should generate valid facts data against the facts schema" do
204
- Time.stubs(:now).returns(@timestamp)
202
+ allow(Time).to receive(:now).and_return(@timestamp)
205
203
  facts = Puppet::Node::Facts.new("foo", {'a' => 1, 'b' => 2, 'c' => 3})
206
204
  facts.expiration = @expiration
207
205
 
@@ -1,4 +1,3 @@
1
- #! /usr/bin/env ruby
2
1
  require 'spec_helper'
3
2
  require 'matchers/json'
4
3
  require 'puppet_spec/files'
@@ -11,7 +10,6 @@ describe Puppet::Node do
11
10
  let(:env_loader) { Puppet::Environments::Static.new(environment) }
12
11
 
13
12
  describe "when managing its environment" do
14
-
15
13
  it "provides an environment instance" do
16
14
  expect(Puppet::Node.new("foo", :environment => environment).environment.name).to eq(:bar)
17
15
  end
@@ -135,7 +133,6 @@ describe Puppet::Node do
135
133
  it "errors if name is nil" do
136
134
  expect { Puppet::Node.from_data_hash({ })}.to raise_error(ArgumentError, /No name provided in serialized data/)
137
135
  end
138
-
139
136
  end
140
137
 
141
138
  describe "when converting to json" do
@@ -274,18 +271,18 @@ describe Puppet::Node, "when merging facts" do
274
271
  let(:facts) { Puppet::Node::Facts.new(@node.name, "foo" => "bar") }
275
272
 
276
273
  it "accepts facts to merge with the node" do
277
- @node.expects(:merge).with({ 'foo' => 'bar' })
274
+ expect(@node).to receive(:merge).with({ 'foo' => 'bar' })
278
275
  @node.fact_merge(facts)
279
276
  end
280
277
 
281
278
  it "will not query the facts indirection if facts are supplied" do
282
- Puppet::Node::Facts.indirection.expects(:find).never
279
+ expect(Puppet::Node::Facts.indirection).not_to receive(:find)
283
280
  @node.fact_merge(facts)
284
281
  end
285
282
  end
286
283
 
287
284
  it "recovers with a Puppet::Error if something is thrown from the facts indirection" do
288
- Puppet::Node::Facts.indirection.expects(:find).raises "something bad happened in the indirector"
285
+ expect(Puppet::Node::Facts.indirection).to receive(:find).and_raise("something bad happened in the indirector")
289
286
  expect { @node.fact_merge }.to raise_error(Puppet::Error, /Could not retrieve facts for testnode: something bad happened in the indirector/)
290
287
  end
291
288
 
@@ -303,7 +300,7 @@ describe Puppet::Node, "when merging facts" do
303
300
 
304
301
  it "warns when a parameter value is not updated" do
305
302
  @node = Puppet::Node.new("testnode", :parameters => {"one" => "a"})
306
- Puppet.expects(:warning).with('The node parameter \'one\' for node \'testnode\' was already set to \'a\'. It could not be set to \'b\'')
303
+ expect(Puppet).to receive(:warning).with('The node parameter \'one\' for node \'testnode\' was already set to \'a\'. It could not be set to \'b\'')
307
304
  @node.merge "one" => "b"
308
305
  end
309
306
 
@@ -377,9 +374,7 @@ describe Puppet::Node, "when merging facts" do
377
374
  end
378
375
 
379
376
  context "when a node is initialized from new" do
380
-
381
377
  context "when a node is initialzed with an environment" do
382
-
383
378
  it "adds the environment to the list of parameters" do
384
379
  Puppet[:environment] = "one"
385
380
  @node = Puppet::Node.new("testnode", :environment => "one")
@@ -401,7 +396,6 @@ describe Puppet::Node, "when merging facts" do
401
396
  end
402
397
 
403
398
  context "when a node is initialized without an environment" do
404
-
405
399
  it "it perfers an environment name to an environment fact" do
406
400
  @node = Puppet::Node.new("testnode")
407
401
  @node.environment_name = "one"
@@ -1,4 +1,3 @@
1
- #! /usr/bin/env ruby
2
1
  require 'spec_helper'
3
2
 
4
3
  describe Puppet::Type.type(:file), " when manipulating file contexts" do
@@ -1,10 +1,9 @@
1
- #! /usr/bin/env ruby
2
1
  require 'spec_helper'
3
2
  require 'puppet'
4
3
  require 'puppet/parameter/boolean'
5
4
 
6
5
  describe Puppet::Parameter::Boolean do
7
- let (:resource) { mock('resource') }
6
+ let (:resource) { double('resource') }
8
7
  describe "after initvars" do
9
8
  before { described_class.initvars }
10
9
  it "should have the correct value_collection" do
@@ -1,10 +1,9 @@
1
- #! /usr/bin/env ruby
2
1
  require 'spec_helper'
3
2
 
4
3
  require 'puppet/parameter/package_options'
5
4
 
6
5
  describe Puppet::Parameter::PackageOptions do
7
- let (:resource) { mock('resource') }
6
+ let (:resource) { double('resource') }
8
7
  let (:param) { described_class.new(:resource => resource) }
9
8
  let (:arg) { '/S' }
10
9
  let (:key) { 'INSTALLDIR' }
@@ -1,4 +1,3 @@
1
- #! /usr/bin/env ruby
2
1
  require 'spec_helper'
3
2
 
4
3
  require 'puppet/parameter/path'
@@ -1,4 +1,3 @@
1
- #! /usr/bin/env ruby
2
1
  require 'spec_helper'
3
2
 
4
3
  require 'puppet/parameter'
@@ -1,4 +1,3 @@
1
- #! /usr/bin/env ruby
2
1
  require 'spec_helper'
3
2
 
4
3
  require 'puppet/parameter'
@@ -1,4 +1,3 @@
1
- #! /usr/bin/env ruby
2
1
  require 'spec_helper'
3
2
 
4
3
  require 'puppet/parameter'
@@ -9,8 +8,9 @@ describe Puppet::Parameter do
9
8
  @name = :foo
10
9
  end
11
10
  @class.initvars
12
- @resource = mock 'resource'
13
- @resource.stub_everything
11
+ @resource = double('resource')
12
+ allow(@resource).to receive(:expects)
13
+ allow(@resource).to receive(:pathbuilder)
14
14
  @parameter = @class.new :resource => @resource
15
15
  end
16
16
 
@@ -27,13 +27,13 @@ describe Puppet::Parameter do
27
27
 
28
28
  [:line, :file, :version].each do |data|
29
29
  it "should return its resource's #{data} as its #{data}" do
30
- @resource.expects(data).returns "foo"
30
+ expect(@resource).to receive(data).and_return("foo")
31
31
  expect(@parameter.send(data)).to eq("foo")
32
32
  end
33
33
  end
34
34
 
35
35
  it "should return the resource's tags plus its name as its tags" do
36
- @resource.expects(:tags).returns %w{one two}
36
+ expect(@resource).to receive(:tags).and_return(%w{one two})
37
37
  expect(@parameter.tags).to eq(%w{one two foo})
38
38
  end
39
39
 
@@ -47,12 +47,12 @@ describe Puppet::Parameter do
47
47
  end
48
48
 
49
49
  it "should validate the value" do
50
- @parameter.expects(:validate).with("foo")
50
+ expect(@parameter).to receive(:validate).with("foo")
51
51
  @parameter.value = "foo"
52
52
  end
53
53
 
54
54
  it "should munge the value and use any result as the actual value" do
55
- @parameter.expects(:munge).with("foo").returns "bar"
55
+ expect(@parameter).to receive(:munge).with("foo").and_return("bar")
56
56
  @parameter.value = "foo"
57
57
  expect(@parameter.value).to eq("bar")
58
58
  end
@@ -149,8 +149,8 @@ describe Puppet::Parameter do
149
149
 
150
150
  describe "when logging" do
151
151
  it "should use its resource's log level and the provided message" do
152
- @resource.expects(:[]).with(:loglevel).returns :notice
153
- @parameter.expects(:send_log).with(:notice, "mymessage")
152
+ expect(@resource).to receive(:[]).with(:loglevel).and_return(:notice)
153
+ expect(@parameter).to receive(:send_log).with(:notice, "mymessage")
154
154
  @parameter.log "mymessage"
155
155
  end
156
156
  end
@@ -1,4 +1,3 @@
1
- #! /usr/bin/env ruby
2
1
  require 'spec_helper'
3
2
  require 'puppet/parser/ast/block_expression'
4
3
 
@@ -16,9 +15,9 @@ describe 'Puppet::Parser::AST::BlockExpression' do
16
15
  StackDepthAST.new({})
17
16
  end
18
17
 
19
- def sequence_probe(name, sequence)
20
- probe = mock("Sequence Probe #{name}")
21
- probe.expects(:safeevaluate).in_sequence(sequence)
18
+ def sequence_probe(name)
19
+ probe = double("Sequence Probe #{name}")
20
+ expect(probe).to receive(:safeevaluate).ordered
22
21
  probe
23
22
  end
24
23
 
@@ -57,10 +56,9 @@ describe 'Puppet::Parser::AST::BlockExpression' do
57
56
  end
58
57
 
59
58
  it "evaluates sequenced children in order" do
60
- evaluation_order = sequence("Child evaluation order")
61
- expr1 = block_of([sequence_probe("Step 1", evaluation_order)])
62
- expr2 = block_of([sequence_probe("Step 2", evaluation_order)])
63
- expr3 = block_of([sequence_probe("Step 3", evaluation_order)])
59
+ expr1 = block_of([sequence_probe("Step 1")])
60
+ expr2 = block_of([sequence_probe("Step 2")])
61
+ expr3 = block_of([sequence_probe("Step 3")])
64
62
 
65
63
  expr1.sequence_with(expr2).sequence_with(expr3).evaluate(NO_SCOPE)
66
64
  end
@@ -1,4 +1,3 @@
1
- #! /usr/bin/env ruby
2
1
  require 'spec_helper'
3
2
 
4
3
  describe Puppet::Parser::AST::Leaf do
@@ -6,14 +5,14 @@ describe Puppet::Parser::AST::Leaf do
6
5
  node = Puppet::Node.new('localhost')
7
6
  compiler = Puppet::Parser::Compiler.new(node)
8
7
  @scope = Puppet::Parser::Scope.new(compiler)
9
- @value = stub 'value'
8
+ @value = double('value')
10
9
  @leaf = Puppet::Parser::AST::Leaf.new(:value => @value)
11
10
  end
12
11
 
13
12
  describe "when converting to string" do
14
13
  it "should transform its value to string" do
15
- value = stub 'value', :is_a? => true
16
- value.expects(:to_s)
14
+ value = double('value', :is_a? => true)
15
+ expect(value).to receive(:to_s)
17
16
  Puppet::Parser::AST::Leaf.new( :value => value ).to_s
18
17
  end
19
18
  end
@@ -23,7 +22,7 @@ describe Puppet::Parser::AST::Leaf do
23
22
  end
24
23
 
25
24
  it "should delegate match to ==" do
26
- @value.expects(:==).with("value")
25
+ expect(@value).to receive(:==).with("value")
27
26
 
28
27
  @leaf.match("value")
29
28
  end
@@ -39,14 +38,14 @@ describe Puppet::Parser::AST::Regex do
39
38
 
40
39
  describe "when initializing" do
41
40
  it "should create a Regexp with its content when value is not a Regexp" do
42
- Regexp.expects(:new).with("/ab/")
41
+ expect(Regexp).to receive(:new).with("/ab/")
43
42
 
44
43
  Puppet::Parser::AST::Regex.new :value => "/ab/"
45
44
  end
46
45
 
47
46
  it "should not create a Regexp with its content when value is a Regexp" do
48
47
  value = Regexp.new("/ab/")
49
- Regexp.expects(:new).with("/ab/").never
48
+ expect(Regexp).not_to receive(:new).with("/ab/")
50
49
 
51
50
  Puppet::Parser::AST::Regex.new :value => value
52
51
  end
@@ -61,11 +60,11 @@ describe Puppet::Parser::AST::Regex do
61
60
  end
62
61
 
63
62
  it 'should return the PRegexpType#regexp_to_s_with_delimiters with to_s' do
64
- regex = stub 'regex'
65
- Regexp.stubs(:new).returns(regex)
63
+ regex = double('regex')
64
+ allow(Regexp).to receive(:new).and_return(regex)
66
65
 
67
66
  val = Puppet::Parser::AST::Regex.new :value => '/ab/'
68
- Puppet::Pops::Types::PRegexpType.expects(:regexp_to_s_with_delimiters)
67
+ expect(Puppet::Pops::Types::PRegexpType).to receive(:regexp_to_s_with_delimiters)
69
68
 
70
69
  val.to_s
71
70
  end
@@ -74,7 +73,7 @@ describe Puppet::Parser::AST::Regex do
74
73
  regex = Regexp.new("/ab/")
75
74
  val = Puppet::Parser::AST::Regex.new :value => regex
76
75
 
77
- regex.expects(:match).with("value")
76
+ expect(regex).to receive(:match).with("value")
78
77
 
79
78
  val.match("value")
80
79
  end
@@ -86,8 +85,8 @@ describe Puppet::Parser::AST::HostName do
86
85
  compiler = Puppet::Parser::Compiler.new(node)
87
86
  @scope = Puppet::Parser::Scope.new(compiler)
88
87
  @value = 'value'
89
- @value.stubs(:to_s).returns(@value)
90
- @value.stubs(:downcase).returns(@value)
88
+ allow(@value).to receive(:to_s).and_return(@value)
89
+ allow(@value).to receive(:downcase).and_return(@value)
91
90
  @host = Puppet::Parser::AST::HostName.new(:value => @value)
92
91
  end
93
92
 
@@ -100,16 +99,16 @@ describe Puppet::Parser::AST::HostName do
100
99
  end
101
100
 
102
101
  it "should stringify the value" do
103
- value = stub 'value', :=~ => false
102
+ value = double('value', :=~ => false)
104
103
 
105
- value.expects(:to_s).returns("test")
104
+ expect(value).to receive(:to_s).and_return("test")
106
105
 
107
106
  Puppet::Parser::AST::HostName.new(:value => value)
108
107
  end
109
108
 
110
109
  it "should downcase the value" do
111
- value = stub 'value', :=~ => false
112
- value.stubs(:to_s).returns("UPCASED")
110
+ value = double('value', :=~ => false)
111
+ allow(value).to receive(:to_s).and_return("UPCASED")
113
112
  host = Puppet::Parser::AST::HostName.new(:value => value)
114
113
 
115
114
  host.value == "upcased"
@@ -120,18 +119,18 @@ describe Puppet::Parser::AST::HostName do
120
119
  end
121
120
 
122
121
  it "should delegate eql? to the underlying value if it is an HostName" do
123
- @value.expects(:eql?).with("value")
122
+ expect(@value).to receive(:eql?).with("value")
124
123
  @host.eql?("value")
125
124
  end
126
125
 
127
126
  it "should delegate eql? to the underlying value if it is not an HostName" do
128
- value = stub 'compared', :is_a? => true, :value => "value"
129
- @value.expects(:eql?).with("value")
127
+ value = double('compared', :is_a? => true, :value => "value")
128
+ expect(@value).to receive(:eql?).with("value")
130
129
  @host.eql?(value)
131
130
  end
132
131
 
133
132
  it "should delegate hash to the underlying value" do
134
- @value.expects(:hash)
133
+ expect(@value).to receive(:hash)
135
134
  @host.hash
136
135
  end
137
136
  end
@@ -71,20 +71,20 @@ describe Puppet::Parser::Compiler do
71
71
  # hidden away in the implementation and we keep losing the race.)
72
72
  # --daniel 2011-04-21
73
73
  now = Time.now
74
- Time.stubs(:now).returns(now)
74
+ allow(Time).to receive(:now).and_return(now)
75
75
 
76
76
  @node = Puppet::Node.new("testnode",
77
77
  :facts => Puppet::Node::Facts.new("facts", {}),
78
78
  :environment => environment)
79
79
  @known_resource_types = environment.known_resource_types
80
80
  @compiler = Puppet::Parser::Compiler.new(@node)
81
- @scope = Puppet::Parser::Scope.new(@compiler, :source => stub('source'))
81
+ @scope = Puppet::Parser::Scope.new(@compiler, :source => double('source'))
82
82
  @scope_resource = Puppet::Parser::Resource.new(:file, "/my/file", :scope => @scope)
83
83
  @scope.resource = @scope_resource
84
84
  end
85
85
 
86
86
  it "should fail intelligently when a class-level compile fails" do
87
- Puppet::Parser::Compiler.expects(:new).raises ArgumentError
87
+ expect(Puppet::Parser::Compiler).to receive(:new).and_raise(ArgumentError)
88
88
  expect { Puppet::Parser::Compiler.compile(@node) }.to raise_error(Puppet::Error)
89
89
  end
90
90
 
@@ -94,7 +94,7 @@ describe Puppet::Parser::Compiler do
94
94
 
95
95
  it "fails if the node's environment has validation errors" do
96
96
  conflicted_environment = Puppet::Node::Environment.create(:testing, [], '/some/environment.conf/manifest.pp')
97
- conflicted_environment.stubs(:validation_errors).returns(['bad environment'])
97
+ allow(conflicted_environment).to receive(:validation_errors).and_return(['bad environment'])
98
98
  @node.environment = conflicted_environment
99
99
  expect { Puppet::Parser::Compiler.compile(@node) }.to raise_error(Puppet::Error, /Compilation has been halted because.*bad environment/)
100
100
  end
@@ -108,7 +108,6 @@ describe Puppet::Parser::Compiler do
108
108
  end
109
109
 
110
110
  describe "when initializing" do
111
-
112
111
  it 'should not create the settings class more than once' do
113
112
  logs = []
114
113
  Puppet::Util::Log.with_destination(Puppet::Test::LogCollector.new(logs)) do
@@ -218,7 +217,6 @@ describe Puppet::Parser::Compiler do
218
217
  end
219
218
 
220
219
  describe "when managing scopes" do
221
-
222
220
  it "should create a top scope" do
223
221
  expect(@compiler.topscope).to be_instance_of(Puppet::Parser::Scope)
224
222
  end
@@ -228,7 +226,7 @@ describe Puppet::Parser::Compiler do
228
226
  end
229
227
 
230
228
  it "should set the parent scope of the new scope to be the passed-in parent" do
231
- scope = mock 'scope'
229
+ scope = double('scope')
232
230
  newscope = @compiler.newscope(scope)
233
231
 
234
232
  expect(newscope.parent).to equal(scope)
@@ -242,7 +240,6 @@ describe Puppet::Parser::Compiler do
242
240
  end
243
241
 
244
242
  describe "when compiling" do
245
-
246
243
  def compile_methods
247
244
  [:set_node_parameters, :evaluate_main, :evaluate_ast_node, :evaluate_node_classes, :evaluate_generators, :fail_on_unevaluated,
248
245
  :finish, :store, :extract, :evaluate_relationships]
@@ -250,12 +247,12 @@ describe Puppet::Parser::Compiler do
250
247
 
251
248
  # Stub all of the main compile methods except the ones we're specifically interested in.
252
249
  def compile_stub(*except)
253
- (compile_methods - except).each { |m| @compiler.stubs(m) }
250
+ (compile_methods - except).each { |m| allow(@compiler).to receive(m) }
254
251
  end
255
252
 
256
253
  it "should set node parameters as variables in the top scope" do
257
254
  params = {"a" => "b", "c" => "d"}
258
- @node.stubs(:parameters).returns(params)
255
+ allow(@node).to receive(:parameters).and_return(params)
259
256
  compile_stub(:set_node_parameters)
260
257
  @compiler.compile
261
258
  expect(@compiler.topscope['a']).to eq("b")
@@ -264,7 +261,7 @@ describe Puppet::Parser::Compiler do
264
261
 
265
262
  it "should set node parameters that are of Symbol type as String variables in the top scope" do
266
263
  params = {"a" => :b}
267
- @node.stubs(:parameters).returns(params)
264
+ allow(@node).to receive(:parameters).and_return(params)
268
265
  compile_stub(:set_node_parameters)
269
266
  @compiler.compile
270
267
  expect(@compiler.topscope['a']).to eq("b")
@@ -288,7 +285,7 @@ describe Puppet::Parser::Compiler do
288
285
 
289
286
  it "should set the client and server versions on the catalog" do
290
287
  params = {"clientversion" => "2", "serverversion" => "3"}
291
- @node.stubs(:parameters).returns(params)
288
+ allow(@node).to receive(:parameters).and_return(params)
292
289
  compile_stub(:set_node_parameters)
293
290
  @compiler.compile
294
291
  expect(@compiler.catalog.client_version).to eq("2")
@@ -298,8 +295,8 @@ describe Puppet::Parser::Compiler do
298
295
  it "should evaluate the main class if it exists" do
299
296
  compile_stub(:evaluate_main)
300
297
  main_class = @known_resource_types.add Puppet::Resource::Type.new(:hostclass, "")
301
- main_class.expects(:evaluate_code).with { |r| r.is_a?(Puppet::Parser::Resource) }
302
- @compiler.topscope.expects(:source=).with(main_class)
298
+ expect(main_class).to receive(:evaluate_code).with(be_a(Puppet::Parser::Resource))
299
+ expect(@compiler.topscope).to receive(:source=).with(main_class)
303
300
 
304
301
  @compiler.compile
305
302
  end
@@ -321,9 +318,9 @@ describe Puppet::Parser::Compiler do
321
318
  it "should evaluate all added collections" do
322
319
  colls = []
323
320
  # And when the collections fail to evaluate.
324
- colls << mock("coll1-false")
325
- colls << mock("coll2-false")
326
- colls.each { |c| c.expects(:evaluate).returns(false) }
321
+ colls << double("coll1-false")
322
+ colls << double("coll2-false")
323
+ colls.each { |c| expect(c).to receive(:evaluate).and_return(false) }
327
324
 
328
325
  @compiler.add_collection(colls[0])
329
326
  @compiler.add_collection(colls[1])
@@ -336,7 +333,7 @@ describe Puppet::Parser::Compiler do
336
333
  resource = resource(:file, "testing")
337
334
 
338
335
  @compiler.add_resource(@scope, resource)
339
- resource.expects(:evaluate).never
336
+ expect(resource).not_to receive(:evaluate)
340
337
 
341
338
  @compiler.compile
342
339
  end
@@ -347,17 +344,17 @@ describe Puppet::Parser::Compiler do
347
344
  @compiler.add_resource(@scope, resource)
348
345
 
349
346
  # We have to now mark the resource as evaluated
350
- resource.expects(:evaluate).with { |*whatever| resource.evaluated = true }
347
+ expect(resource).to receive(:evaluate) { resource.evaluated = true }
351
348
 
352
349
  @compiler.compile
353
350
  end
354
351
 
355
352
  it "should not evaluate already-evaluated resources" do
356
353
  resource = resource(:file, "testing")
357
- resource.stubs(:evaluated?).returns true
354
+ allow(resource).to receive(:evaluated?).and_return(true)
358
355
 
359
356
  @compiler.add_resource(@scope, resource)
360
- resource.expects(:evaluate).never
357
+ expect(resource).not_to receive(:evaluate)
361
358
 
362
359
  @compiler.compile
363
360
  end
@@ -369,9 +366,8 @@ describe Puppet::Parser::Compiler do
369
366
  resource2 = CompilerTestResource.new(:file, "other")
370
367
 
371
368
  # We have to now mark the resource as evaluated
372
- resource.expects(:evaluate).with { |*whatever| resource.evaluated = true; @compiler.add_resource(@scope, resource2) }
373
- resource2.expects(:evaluate).with { |*whatever| resource2.evaluated = true }
374
-
369
+ expect(resource).to receive(:evaluate) { resource.evaluated = true; @compiler.add_resource(@scope, resource2) }
370
+ expect(resource2).to receive(:evaluate) { resource2.evaluated = true }
375
371
 
376
372
  @compiler.compile
377
373
  end
@@ -392,12 +388,12 @@ describe Puppet::Parser::Compiler do
392
388
  it "should call finish() on all resources" do
393
389
  # Add a resource that does respond to :finish
394
390
  resource = Puppet::Parser::Resource.new "file", "finish", :scope => @scope
395
- resource.expects(:finish)
391
+ expect(resource).to receive(:finish)
396
392
 
397
393
  @compiler.add_resource(@scope, resource)
398
394
 
399
395
  # And one that does not
400
- dnf_resource = stub_everything "dnf", :ref => "File[dnf]", :type => "file"
396
+ dnf_resource = double("dnf", :ref => "File[dnf]", :type => "file", :resource_type => nil, :[] => nil, :class? => nil, :stage? => nil)
401
397
 
402
398
  @compiler.add_resource(@scope, dnf_resource)
403
399
 
@@ -405,13 +401,11 @@ describe Puppet::Parser::Compiler do
405
401
  end
406
402
 
407
403
  it "should call finish() in add_resource order" do
408
- resources = sequence('resources')
409
-
410
404
  resource1 = add_resource("finish1")
411
- resource1.expects(:finish).in_sequence(resources)
405
+ expect(resource1).to receive(:finish).ordered
412
406
 
413
407
  resource2 = add_resource("finish2")
414
- resource2.expects(:finish).in_sequence(resources)
408
+ expect(resource2).to receive(:finish).ordered
415
409
 
416
410
  @compiler.send(:finish)
417
411
  end
@@ -552,22 +546,21 @@ describe Puppet::Parser::Compiler do
552
546
  resource.virtual = true
553
547
  @compiler.add_resource(@scope, resource)
554
548
 
555
- resource.expects(:evaluate).never
549
+ expect(resource).not_to receive(:evaluate)
556
550
 
557
551
  @compiler.compile
558
552
  end
559
553
  end
560
554
 
561
555
  describe "when evaluating collections" do
562
-
563
556
  it "should evaluate each collection" do
564
557
  2.times { |i|
565
- coll = mock 'coll%s' % i
558
+ coll = double('coll%s' % i)
566
559
  @compiler.add_collection(coll)
567
560
 
568
561
  # This is the hard part -- we have to emulate the fact that
569
562
  # collections delete themselves if they are done evaluating.
570
- coll.expects(:evaluate).with do
563
+ expect(coll).to receive(:evaluate) do
571
564
  @compiler.delete_collection(coll)
572
565
  end
573
566
  }
@@ -576,8 +569,8 @@ describe Puppet::Parser::Compiler do
576
569
  end
577
570
 
578
571
  it "should not fail when there are unevaluated resource collections that do not refer to specific resources" do
579
- coll = stub 'coll', :evaluate => false
580
- coll.expects(:unresolved_resources).returns(nil)
572
+ coll = double('coll', :evaluate => false)
573
+ expect(coll).to receive(:unresolved_resources).and_return(nil)
581
574
 
582
575
  @compiler.add_collection(coll)
583
576
 
@@ -585,8 +578,8 @@ describe Puppet::Parser::Compiler do
585
578
  end
586
579
 
587
580
  it "should fail when there are unevaluated resource collections that refer to a specific resource" do
588
- coll = stub 'coll', :evaluate => false
589
- coll.expects(:unresolved_resources).returns(:something)
581
+ coll = double('coll', :evaluate => false)
582
+ expect(coll).to receive(:unresolved_resources).and_return(:something)
590
583
 
591
584
  @compiler.add_collection(coll)
592
585
 
@@ -594,8 +587,8 @@ describe Puppet::Parser::Compiler do
594
587
  end
595
588
 
596
589
  it "should fail when there are unevaluated resource collections that refer to multiple specific resources" do
597
- coll = stub 'coll', :evaluate => false
598
- coll.expects(:unresolved_resources).returns([:one, :two])
590
+ coll = double('coll', :evaluate => false)
591
+ expect(coll).to receive(:unresolved_resources).and_return([:one, :two])
599
592
 
600
593
  @compiler.add_collection(coll)
601
594
 
@@ -605,22 +598,21 @@ describe Puppet::Parser::Compiler do
605
598
 
606
599
  describe "when evaluating relationships" do
607
600
  it "should evaluate each relationship with its catalog" do
608
- dep = stub 'dep'
609
- dep.expects(:evaluate).with(@compiler.catalog)
601
+ dep = double('dep')
602
+ expect(dep).to receive(:evaluate).with(@compiler.catalog)
610
603
  @compiler.add_relationship dep
611
604
  @compiler.evaluate_relationships
612
605
  end
613
606
  end
614
607
 
615
608
  describe "when told to evaluate missing classes" do
616
-
617
609
  it "should fail if there's no source listed for the scope" do
618
- scope = stub 'scope', :source => nil
610
+ scope = double('scope', :source => nil)
619
611
  expect { @compiler.evaluate_classes(%w{one two}, scope) }.to raise_error(Puppet::DevError)
620
612
  end
621
613
 
622
614
  it "should raise an error if a class is not found" do
623
- @scope.environment.known_resource_types.expects(:find_hostclass).with("notfound").returns(nil)
615
+ expect(@scope.environment.known_resource_types).to receive(:find_hostclass).with("notfound").and_return(nil)
624
616
  expect{ @compiler.evaluate_classes(%w{notfound}, @scope) }.to raise_error(Puppet::Error, /Could not find class/)
625
617
  end
626
618
 
@@ -632,11 +624,10 @@ describe Puppet::Parser::Compiler do
632
624
  end
633
625
 
634
626
  describe "when evaluating found classes" do
635
-
636
627
  before do
637
628
  Puppet.settings[:data_binding_terminus] = "none"
638
629
  @class = @known_resource_types.add Puppet::Resource::Type.new(:hostclass, "myclass")
639
- @resource = stub 'resource', :ref => "Class[myclass]", :type => "file"
630
+ @resource = double('resource', :ref => "Class[myclass]", :type => "file")
640
631
  end
641
632
 
642
633
  around do |example|
@@ -649,10 +640,10 @@ describe Puppet::Parser::Compiler do
649
640
  end
650
641
 
651
642
  it "should evaluate each class" do
652
- @compiler.catalog.stubs(:tag)
643
+ allow(@compiler.catalog).to receive(:tag)
653
644
 
654
- @class.expects(:ensure_in_catalog).with(@scope)
655
- @scope.stubs(:class_scope).with(@class)
645
+ expect(@class).to receive(:ensure_in_catalog).with(@scope)
646
+ allow(@scope).to receive(:class_scope).with(@class)
656
647
 
657
648
  @compiler.evaluate_classes(%w{myclass}, @scope)
658
649
  end
@@ -740,73 +731,71 @@ describe Puppet::Parser::Compiler do
740
731
  end
741
732
 
742
733
  it "should not evaluate the resources created for found classes unless asked" do
743
- @compiler.catalog.stubs(:tag)
734
+ allow(@compiler.catalog).to receive(:tag)
744
735
 
745
- @resource.expects(:evaluate).never
736
+ expect(@resource).not_to receive(:evaluate)
746
737
 
747
- @class.expects(:ensure_in_catalog).returns(@resource)
748
- @scope.stubs(:class_scope).with(@class)
738
+ expect(@class).to receive(:ensure_in_catalog).and_return(@resource)
739
+ allow(@scope).to receive(:class_scope).with(@class)
749
740
 
750
741
  @compiler.evaluate_classes(%w{myclass}, @scope)
751
742
  end
752
743
 
753
744
  it "should immediately evaluate the resources created for found classes when asked" do
754
- @compiler.catalog.stubs(:tag)
745
+ allow(@compiler.catalog).to receive(:tag)
755
746
 
756
- @resource.expects(:evaluate)
757
- @class.expects(:ensure_in_catalog).returns(@resource)
758
- @scope.stubs(:class_scope).with(@class)
747
+ expect(@resource).to receive(:evaluate)
748
+ expect(@class).to receive(:ensure_in_catalog).and_return(@resource)
749
+ allow(@scope).to receive(:class_scope).with(@class)
759
750
 
760
751
  @compiler.evaluate_classes(%w{myclass}, @scope, false)
761
752
  end
762
753
 
763
754
  it "should skip classes that have already been evaluated" do
764
- @compiler.catalog.stubs(:tag)
755
+ allow(@compiler.catalog).to receive(:tag)
765
756
 
766
- @scope.stubs(:class_scope).with(@class).returns(@scope)
757
+ allow(@scope).to receive(:class_scope).with(@class).and_return(@scope)
767
758
 
768
- @compiler.expects(:add_resource).never
759
+ expect(@compiler).not_to receive(:add_resource)
769
760
 
770
- @resource.expects(:evaluate).never
761
+ expect(@resource).not_to receive(:evaluate)
771
762
 
772
- Puppet::Parser::Resource.expects(:new).never
763
+ expect(Puppet::Parser::Resource).not_to receive(:new)
773
764
  @compiler.evaluate_classes(%w{myclass}, @scope, false)
774
765
  end
775
766
 
776
767
  it "should skip classes previously evaluated with different capitalization" do
777
- @compiler.catalog.stubs(:tag)
778
- @scope.environment.known_resource_types.stubs(:find_hostclass).with("MyClass").returns(@class)
779
- @scope.stubs(:class_scope).with(@class).returns(@scope)
780
- @compiler.expects(:add_resource).never
781
- @resource.expects(:evaluate).never
782
- Puppet::Parser::Resource.expects(:new).never
768
+ allow(@compiler.catalog).to receive(:tag)
769
+ allow(@scope.environment.known_resource_types).to receive(:find_hostclass).with("MyClass").and_return(@class)
770
+ allow(@scope).to receive(:class_scope).with(@class).and_return(@scope)
771
+ expect(@compiler).not_to receive(:add_resource)
772
+ expect(@resource).not_to receive(:evaluate)
773
+ expect(Puppet::Parser::Resource).not_to receive(:new)
783
774
  @compiler.evaluate_classes(%w{MyClass}, @scope, false)
784
775
  end
785
776
  end
786
777
 
787
778
  describe "when evaluating AST nodes with no AST nodes present" do
788
-
789
779
  it "should do nothing" do
790
- @compiler.environment.known_resource_types.stubs(:nodes).returns(false)
791
- Puppet::Parser::Resource.expects(:new).never
780
+ allow(@compiler.environment.known_resource_types).to receive(:nodes).and_return(false)
781
+ expect(Puppet::Parser::Resource).not_to receive(:new)
792
782
 
793
783
  @compiler.send(:evaluate_ast_node)
794
784
  end
795
785
  end
796
786
 
797
787
  describe "when evaluating AST nodes with AST nodes present" do
798
-
799
788
  before do
800
- @compiler.environment.known_resource_types.stubs(:nodes?).returns true
789
+ allow(@compiler.environment.known_resource_types).to receive(:nodes?).and_return(true)
801
790
 
802
791
  # Set some names for our test
803
- @node.stubs(:names).returns(%w{a b c})
804
- @compiler.environment.known_resource_types.stubs(:node).with("a").returns(nil)
805
- @compiler.environment.known_resource_types.stubs(:node).with("b").returns(nil)
806
- @compiler.environment.known_resource_types.stubs(:node).with("c").returns(nil)
792
+ allow(@node).to receive(:names).and_return(%w{a b c})
793
+ allow(@compiler.environment.known_resource_types).to receive(:node).with("a").and_return(nil)
794
+ allow(@compiler.environment.known_resource_types).to receive(:node).with("b").and_return(nil)
795
+ allow(@compiler.environment.known_resource_types).to receive(:node).with("c").and_return(nil)
807
796
 
808
797
  # It should check this last, of course.
809
- @compiler.environment.known_resource_types.stubs(:node).with("default").returns(nil)
798
+ allow(@compiler.environment.known_resource_types).to receive(:node).with("default").and_return(nil)
810
799
  end
811
800
 
812
801
  it "should fail if the named node cannot be found" do
@@ -814,33 +803,33 @@ describe Puppet::Parser::Compiler do
814
803
  end
815
804
 
816
805
  it "should evaluate the first node class matching the node name" do
817
- node_class = stub 'node', :name => "c", :evaluate_code => nil
818
- @compiler.environment.known_resource_types.stubs(:node).with("c").returns(node_class)
806
+ node_class = double('node', :name => "c", :evaluate_code => nil)
807
+ allow(@compiler.environment.known_resource_types).to receive(:node).with("c").and_return(node_class)
819
808
 
820
- node_resource = stub 'node resource', :ref => "Node[c]", :evaluate => nil, :type => "node"
821
- node_class.expects(:ensure_in_catalog).returns(node_resource)
809
+ node_resource = double('node resource', :ref => "Node[c]", :evaluate => nil, :type => "node")
810
+ expect(node_class).to receive(:ensure_in_catalog).and_return(node_resource)
822
811
 
823
812
  @compiler.compile
824
813
  end
825
814
 
826
815
  it "should match the default node if no matching node can be found" do
827
- node_class = stub 'node', :name => "default", :evaluate_code => nil
828
- @compiler.environment.known_resource_types.stubs(:node).with("default").returns(node_class)
816
+ node_class = double('node', :name => "default", :evaluate_code => nil)
817
+ allow(@compiler.environment.known_resource_types).to receive(:node).with("default").and_return(node_class)
829
818
 
830
- node_resource = stub 'node resource', :ref => "Node[default]", :evaluate => nil, :type => "node"
831
- node_class.expects(:ensure_in_catalog).returns(node_resource)
819
+ node_resource = double('node resource', :ref => "Node[default]", :evaluate => nil, :type => "node")
820
+ expect(node_class).to receive(:ensure_in_catalog).and_return(node_resource)
832
821
 
833
822
  @compiler.compile
834
823
  end
835
824
 
836
825
  it "should evaluate the node resource immediately rather than using lazy evaluation" do
837
- node_class = stub 'node', :name => "c"
838
- @compiler.environment.known_resource_types.stubs(:node).with("c").returns(node_class)
826
+ node_class = double('node', :name => "c")
827
+ allow(@compiler.environment.known_resource_types).to receive(:node).with("c").and_return(node_class)
839
828
 
840
- node_resource = stub 'node resource', :ref => "Node[c]", :type => "node"
841
- node_class.expects(:ensure_in_catalog).returns(node_resource)
829
+ node_resource = double('node resource', :ref => "Node[c]", :type => "node")
830
+ expect(node_class).to receive(:ensure_in_catalog).and_return(node_resource)
842
831
 
843
- node_resource.expects(:evaluate)
832
+ expect(node_resource).to receive(:evaluate)
844
833
 
845
834
  @compiler.send(:evaluate_ast_node)
846
835
  end
@@ -978,9 +967,8 @@ describe Puppet::Parser::Compiler do
978
967
  end
979
968
 
980
969
  describe "when managing resource overrides" do
981
-
982
970
  before do
983
- @override = stub 'override', :ref => "File[/foo]", :type => "my"
971
+ @override = double('override', :ref => "File[/foo]", :type => "my")
984
972
  @resource = resource(:file, "/foo")
985
973
  end
986
974
 
@@ -990,7 +978,7 @@ describe Puppet::Parser::Compiler do
990
978
 
991
979
  it "should apply overrides to the appropriate resources" do
992
980
  @compiler.add_resource(@scope, @resource)
993
- @resource.expects(:merge).with(@override)
981
+ expect(@resource).to receive(:merge).with(@override)
994
982
 
995
983
  @compiler.add_override(@override)
996
984
 
@@ -998,7 +986,7 @@ describe Puppet::Parser::Compiler do
998
986
  end
999
987
 
1000
988
  it "should accept overrides before the related resource has been created" do
1001
- @resource.expects(:merge).with(@override)
989
+ expect(@resource).to receive(:merge).with(@override)
1002
990
 
1003
991
  # First store the override
1004
992
  @compiler.add_override(@override)