puppet 6.0.7-universal-darwin → 6.0.8-universal-darwin

Sign up to get free protection for your applications and to get access to all the features.

Potentially problematic release.


This version of puppet might be problematic. Click here for more details.

Files changed (632) hide show
  1. checksums.yaml +4 -4
  2. data/Gemfile +0 -1
  3. data/Gemfile.lock +4 -8
  4. data/lib/puppet/application/device.rb +99 -83
  5. data/lib/puppet/application/filebucket.rb +4 -0
  6. data/lib/puppet/configurer.rb +5 -4
  7. data/lib/puppet/defaults.rb +31 -11
  8. data/lib/puppet/indirector/request.rb +26 -15
  9. data/lib/puppet/network/http/connection.rb +15 -7
  10. data/lib/puppet/transaction/event_manager.rb +1 -5
  11. data/lib/puppet/type/file/source.rb +0 -1
  12. data/lib/puppet/util/connection.rb +15 -6
  13. data/lib/puppet/util/http_proxy.rb +3 -2
  14. data/lib/puppet/version.rb +1 -1
  15. data/locales/puppet.pot +99 -40
  16. data/man/man5/puppet.conf.5 +8 -8
  17. data/man/man8/puppet-agent.8 +1 -1
  18. data/man/man8/puppet-apply.8 +1 -1
  19. data/man/man8/puppet-catalog.8 +1 -1
  20. data/man/man8/puppet-config.8 +1 -1
  21. data/man/man8/puppet-describe.8 +1 -1
  22. data/man/man8/puppet-device.8 +1 -1
  23. data/man/man8/puppet-doc.8 +1 -1
  24. data/man/man8/puppet-epp.8 +1 -1
  25. data/man/man8/puppet-facts.8 +1 -1
  26. data/man/man8/puppet-filebucket.8 +1 -1
  27. data/man/man8/puppet-generate.8 +1 -1
  28. data/man/man8/puppet-help.8 +1 -1
  29. data/man/man8/puppet-key.8 +1 -1
  30. data/man/man8/puppet-lookup.8 +1 -1
  31. data/man/man8/puppet-man.8 +1 -1
  32. data/man/man8/puppet-module.8 +1 -1
  33. data/man/man8/puppet-node.8 +1 -1
  34. data/man/man8/puppet-parser.8 +1 -1
  35. data/man/man8/puppet-plugin.8 +1 -1
  36. data/man/man8/puppet-report.8 +1 -1
  37. data/man/man8/puppet-resource.8 +1 -1
  38. data/man/man8/puppet-script.8 +1 -1
  39. data/man/man8/puppet-ssl.8 +1 -1
  40. data/man/man8/puppet-status.8 +1 -1
  41. data/man/man8/puppet.8 +2 -2
  42. data/spec/integration/agent/logging_spec.rb +5 -7
  43. data/spec/integration/application/apply_spec.rb +18 -16
  44. data/spec/integration/application/doc_spec.rb +1 -2
  45. data/spec/integration/application/lookup_spec.rb +5 -5
  46. data/spec/integration/configurer_spec.rb +5 -6
  47. data/spec/integration/defaults_spec.rb +5 -6
  48. data/spec/integration/directory_environments_spec.rb +1 -1
  49. data/spec/integration/faces/config_spec.rb +3 -4
  50. data/spec/integration/faces/documentation_spec.rb +0 -1
  51. data/spec/integration/faces/plugin_spec.rb +1 -1
  52. data/spec/integration/file_bucket/file_spec.rb +2 -4
  53. data/spec/integration/file_serving/content_spec.rb +0 -1
  54. data/spec/integration/file_serving/fileset_spec.rb +0 -1
  55. data/spec/integration/file_serving/metadata_spec.rb +0 -1
  56. data/spec/integration/file_serving/terminus_helper_spec.rb +0 -1
  57. data/spec/integration/indirector/catalog/compiler_spec.rb +10 -11
  58. data/spec/integration/indirector/direct_file_server_spec.rb +1 -1
  59. data/spec/integration/indirector/facts/facter_spec.rb +4 -5
  60. data/spec/integration/indirector/file_content/file_server_spec.rb +7 -8
  61. data/spec/integration/indirector/file_metadata/file_server_spec.rb +7 -8
  62. data/spec/integration/network/authconfig_spec.rb +23 -24
  63. data/spec/integration/network/formats_spec.rb +0 -1
  64. data/spec/integration/node/environment_spec.rb +0 -1
  65. data/spec/integration/node/facts_spec.rb +9 -10
  66. data/spec/integration/node_spec.rb +6 -7
  67. data/spec/integration/parser/catalog_spec.rb +1 -5
  68. data/spec/integration/parser/collection_spec.rb +1 -2
  69. data/spec/integration/parser/compiler_spec.rb +6 -6
  70. data/spec/integration/parser/scope_spec.rb +1 -1
  71. data/spec/integration/parser/undef_param_spec.rb +1 -1
  72. data/spec/integration/provider/service/init_spec.rb +4 -5
  73. data/spec/integration/provider/service/systemd_spec.rb +0 -2
  74. data/spec/integration/provider/service/windows_spec.rb +1 -2
  75. data/spec/integration/reference/providers_spec.rb +1 -2
  76. data/spec/integration/reports_spec.rb +1 -2
  77. data/spec/integration/resource/catalog_spec.rb +14 -17
  78. data/spec/integration/resource/type_collection_spec.rb +4 -5
  79. data/spec/integration/ssl/certificate_request_spec.rb +0 -1
  80. data/spec/integration/ssl/host_spec.rb +1 -2
  81. data/spec/integration/ssl/key_spec.rb +0 -1
  82. data/spec/integration/test/test_helper_spec.rb +0 -1
  83. data/spec/integration/transaction/report_spec.rb +6 -11
  84. data/spec/integration/transaction_spec.rb +18 -19
  85. data/spec/integration/type/exec_spec.rb +0 -1
  86. data/spec/integration/type/file_spec.rb +13 -14
  87. data/spec/integration/type/package_spec.rb +19 -23
  88. data/spec/integration/type/tidy_spec.rb +1 -2
  89. data/spec/integration/type_spec.rb +0 -1
  90. data/spec/integration/util/autoload_spec.rb +1 -2
  91. data/spec/integration/util/rdoc/parser_spec.rb +0 -1
  92. data/spec/integration/util/settings_spec.rb +0 -1
  93. data/spec/integration/util/windows/adsi_spec.rb +3 -5
  94. data/spec/integration/util/windows/principal_spec.rb +0 -1
  95. data/spec/integration/util/windows/process_spec.rb +4 -6
  96. data/spec/integration/util/windows/registry_spec.rb +41 -51
  97. data/spec/integration/util/windows/security_spec.rb +2 -4
  98. data/spec/integration/util/windows/user_spec.rb +18 -20
  99. data/spec/integration/util_spec.rb +4 -7
  100. data/spec/lib/puppet_spec/compiler.rb +1 -1
  101. data/spec/lib/puppet_spec/files.rb +0 -1
  102. data/spec/lib/puppet_spec/module_tool/shared_functions.rb +1 -1
  103. data/spec/lib/puppet_spec/scope.rb +1 -2
  104. data/spec/shared_behaviours/all_parsedfile_providers.rb +1 -1
  105. data/spec/shared_behaviours/file_server_terminus.rb +8 -9
  106. data/spec/shared_behaviours/file_serving.rb +6 -8
  107. data/spec/shared_behaviours/file_serving_model.rb +3 -5
  108. data/spec/shared_behaviours/hiera_indirections.rb +3 -4
  109. data/spec/shared_behaviours/iterative_functions.rb +0 -1
  110. data/spec/shared_behaviours/memory_terminus.rb +2 -2
  111. data/spec/shared_examples/rhel_package_provider.rb +112 -70
  112. data/spec/spec_helper.rb +10 -1
  113. data/spec/unit/agent/disabler_spec.rb +4 -5
  114. data/spec/unit/agent/locker_spec.rb +12 -13
  115. data/spec/unit/agent_spec.rb +80 -85
  116. data/spec/unit/application/agent_spec.rb +88 -93
  117. data/spec/unit/application/apply_spec.rb +82 -83
  118. data/spec/unit/application/config_spec.rb +0 -1
  119. data/spec/unit/application/describe_spec.rb +6 -7
  120. data/spec/unit/application/device_spec.rb +395 -419
  121. data/spec/unit/application/doc_spec.rb +44 -46
  122. data/spec/unit/application/face_base_spec.rb +61 -62
  123. data/spec/unit/application/facts_spec.rb +3 -4
  124. data/spec/unit/application/filebucket_spec.rb +66 -74
  125. data/spec/unit/application/indirection_base_spec.rb +8 -6
  126. data/spec/unit/application/lookup_spec.rb +26 -26
  127. data/spec/unit/application/resource_spec.rb +42 -48
  128. data/spec/unit/application/ssl_spec.rb +3 -3
  129. data/spec/unit/application_spec.rb +82 -92
  130. data/spec/unit/capability_spec.rb +6 -6
  131. data/spec/unit/certificate_factory_spec.rb +3 -5
  132. data/spec/unit/configurer/downloader_spec.rb +20 -21
  133. data/spec/unit/configurer/fact_handler_spec.rb +2 -3
  134. data/spec/unit/configurer/plugin_handler_spec.rb +41 -8
  135. data/spec/unit/configurer_spec.rb +189 -192
  136. data/spec/unit/confine/exists_spec.rb +17 -15
  137. data/spec/unit/confine/false_spec.rb +5 -6
  138. data/spec/unit/confine/feature_spec.rb +7 -5
  139. data/spec/unit/confine/true_spec.rb +5 -6
  140. data/spec/unit/confine/variable_spec.rb +14 -15
  141. data/spec/unit/confine_collection_spec.rb +28 -29
  142. data/spec/unit/confine_spec.rb +13 -14
  143. data/spec/unit/confiner_spec.rb +10 -11
  144. data/spec/unit/context/trusted_information_spec.rb +1 -1
  145. data/spec/unit/daemon_spec.rb +35 -36
  146. data/spec/unit/data_providers/function_data_provider_spec.rb +0 -1
  147. data/spec/unit/data_providers/hiera_data_provider_spec.rb +0 -1
  148. data/spec/unit/datatypes_spec.rb +3 -4
  149. data/spec/unit/defaults_spec.rb +18 -13
  150. data/spec/unit/environments_spec.rb +7 -7
  151. data/spec/unit/etc_spec.rb +30 -32
  152. data/spec/unit/external/pson_spec.rb +0 -1
  153. data/spec/unit/face/catalog_spec.rb +0 -1
  154. data/spec/unit/face/config_spec.rb +31 -35
  155. data/spec/unit/face/epp_face_spec.rb +3 -4
  156. data/spec/unit/face/facts_spec.rb +5 -6
  157. data/spec/unit/face/generate_spec.rb +4 -5
  158. data/spec/unit/face/help_spec.rb +7 -8
  159. data/spec/unit/face/key_spec.rb +0 -1
  160. data/spec/unit/face/man_spec.rb +1 -2
  161. data/spec/unit/face/module/install_spec.rb +3 -5
  162. data/spec/unit/face/module/list_spec.rb +2 -12
  163. data/spec/unit/face/module/search_spec.rb +11 -9
  164. data/spec/unit/face/module/uninstall_spec.rb +4 -8
  165. data/spec/unit/face/node_spec.rb +23 -24
  166. data/spec/unit/face/parser_spec.rb +3 -3
  167. data/spec/unit/face/plugin_spec.rb +36 -9
  168. data/spec/unit/face/status_spec.rb +0 -1
  169. data/spec/unit/file_bucket/dipper_spec.rb +24 -20
  170. data/spec/unit/file_bucket/file_spec.rb +0 -2
  171. data/spec/unit/file_serving/base_spec.rb +14 -15
  172. data/spec/unit/file_serving/configuration/parser_spec.rb +27 -28
  173. data/spec/unit/file_serving/configuration_spec.rb +63 -66
  174. data/spec/unit/file_serving/content_spec.rb +10 -11
  175. data/spec/unit/file_serving/fileset_spec.rb +63 -58
  176. data/spec/unit/file_serving/http_metadata_spec.rb +8 -7
  177. data/spec/unit/file_serving/metadata_spec.rb +36 -36
  178. data/spec/unit/file_serving/mount/file_spec.rb +31 -32
  179. data/spec/unit/file_serving/mount/locales_spec.rb +23 -24
  180. data/spec/unit/file_serving/mount/modules_spec.rb +14 -15
  181. data/spec/unit/file_serving/mount/pluginfacts_spec.rb +23 -24
  182. data/spec/unit/file_serving/mount/plugins_spec.rb +23 -24
  183. data/spec/unit/file_serving/mount/tasks_spec.rb +14 -15
  184. data/spec/unit/file_serving/mount_spec.rb +0 -1
  185. data/spec/unit/file_serving/terminus_helper_spec.rb +37 -42
  186. data/spec/unit/file_serving/terminus_selector_spec.rb +12 -13
  187. data/spec/unit/file_system/uniquefile_spec.rb +4 -4
  188. data/spec/unit/file_system_spec.rb +2 -2
  189. data/spec/unit/forge/errors_spec.rb +1 -1
  190. data/spec/unit/forge/forge_spec.rb +13 -14
  191. data/spec/unit/forge/module_release_spec.rb +18 -18
  192. data/spec/unit/forge/repository_spec.rb +29 -30
  193. data/spec/unit/forge_spec.rb +15 -11
  194. data/spec/unit/functions/binary_file_spec.rb +3 -3
  195. data/spec/unit/functions/contain_spec.rb +0 -2
  196. data/spec/unit/functions/defined_spec.rb +0 -1
  197. data/spec/unit/functions/epp_spec.rb +2 -2
  198. data/spec/unit/functions/find_file_spec.rb +7 -7
  199. data/spec/unit/functions/include_spec.rb +0 -4
  200. data/spec/unit/functions/lookup_fixture_spec.rb +0 -1
  201. data/spec/unit/functions/lookup_spec.rb +1 -2
  202. data/spec/unit/functions/module_directory_spec.rb +12 -12
  203. data/spec/unit/functions/require_spec.rb +0 -3
  204. data/spec/unit/functions/shared.rb +5 -8
  205. data/spec/unit/functions/versioncmp_spec.rb +1 -2
  206. data/spec/unit/functions4_spec.rb +9 -10
  207. data/spec/unit/gettext/config_spec.rb +4 -4
  208. data/spec/unit/gettext/module_loading_spec.rb +7 -7
  209. data/spec/unit/graph/rb_tree_map_spec.rb +0 -2
  210. data/spec/unit/graph/relationship_graph_spec.rb +1 -2
  211. data/spec/unit/graph/simple_graph_spec.rb +9 -10
  212. data/spec/unit/hiera_puppet_spec.rb +20 -20
  213. data/spec/unit/indirector/catalog/compiler_spec.rb +147 -149
  214. data/spec/unit/indirector/catalog/json_spec.rb +1 -2
  215. data/spec/unit/indirector/catalog/msgpack_spec.rb +0 -1
  216. data/spec/unit/indirector/catalog/rest_spec.rb +0 -1
  217. data/spec/unit/indirector/catalog/store_configs_spec.rb +0 -1
  218. data/spec/unit/indirector/catalog/yaml_spec.rb +0 -1
  219. data/spec/unit/indirector/certificate/file_spec.rb +0 -1
  220. data/spec/unit/indirector/certificate/rest_spec.rb +8 -10
  221. data/spec/unit/indirector/certificate_request/file_spec.rb +0 -1
  222. data/spec/unit/indirector/certificate_request/rest_spec.rb +0 -1
  223. data/spec/unit/indirector/direct_file_server_spec.rb +17 -18
  224. data/spec/unit/indirector/envelope_spec.rb +1 -2
  225. data/spec/unit/indirector/exec_spec.rb +4 -5
  226. data/spec/unit/indirector/face_spec.rb +9 -9
  227. data/spec/unit/indirector/facts/facter_spec.rb +37 -43
  228. data/spec/unit/indirector/facts/network_device_spec.rb +8 -9
  229. data/spec/unit/indirector/facts/rest_spec.rb +7 -8
  230. data/spec/unit/indirector/facts/store_configs_spec.rb +0 -1
  231. data/spec/unit/indirector/facts/yaml_spec.rb +0 -1
  232. data/spec/unit/indirector/file_bucket_file/file_spec.rb +3 -4
  233. data/spec/unit/indirector/file_bucket_file/rest_spec.rb +0 -1
  234. data/spec/unit/indirector/file_bucket_file/selector_spec.rb +4 -5
  235. data/spec/unit/indirector/file_content/file_server_spec.rb +0 -1
  236. data/spec/unit/indirector/file_content/file_spec.rb +0 -1
  237. data/spec/unit/indirector/file_content/rest_spec.rb +0 -1
  238. data/spec/unit/indirector/file_content/selector_spec.rb +0 -1
  239. data/spec/unit/indirector/file_metadata/file_server_spec.rb +0 -1
  240. data/spec/unit/indirector/file_metadata/file_spec.rb +12 -13
  241. data/spec/unit/indirector/file_metadata/rest_spec.rb +0 -1
  242. data/spec/unit/indirector/file_metadata/selector_spec.rb +0 -1
  243. data/spec/unit/indirector/file_server_spec.rb +87 -87
  244. data/spec/unit/indirector/indirection_spec.rb +242 -226
  245. data/spec/unit/indirector/json_spec.rb +7 -9
  246. data/spec/unit/indirector/key/file_spec.rb +21 -22
  247. data/spec/unit/indirector/memory_spec.rb +6 -7
  248. data/spec/unit/indirector/msgpack_spec.rb +7 -9
  249. data/spec/unit/indirector/node/exec_spec.rb +2 -3
  250. data/spec/unit/indirector/node/memory_spec.rb +2 -4
  251. data/spec/unit/indirector/node/msgpack_spec.rb +0 -1
  252. data/spec/unit/indirector/node/plain_spec.rb +2 -4
  253. data/spec/unit/indirector/node/rest_spec.rb +0 -1
  254. data/spec/unit/indirector/node/store_configs_spec.rb +0 -1
  255. data/spec/unit/indirector/node/yaml_spec.rb +0 -1
  256. data/spec/unit/indirector/none_spec.rb +5 -5
  257. data/spec/unit/indirector/plain_spec.rb +7 -8
  258. data/spec/unit/indirector/report/msgpack_spec.rb +0 -1
  259. data/spec/unit/indirector/report/processor_spec.rb +21 -22
  260. data/spec/unit/indirector/report/rest_spec.rb +11 -12
  261. data/spec/unit/indirector/report/yaml_spec.rb +0 -1
  262. data/spec/unit/indirector/request_spec.rb +11 -12
  263. data/spec/unit/indirector/resource/ral_spec.rb +46 -54
  264. data/spec/unit/indirector/resource/store_configs_spec.rb +0 -1
  265. data/spec/unit/indirector/rest_spec.rb +113 -110
  266. data/spec/unit/indirector/ssl_file_spec.rb +64 -65
  267. data/spec/unit/indirector/status/local_spec.rb +0 -1
  268. data/spec/unit/indirector/status/rest_spec.rb +0 -1
  269. data/spec/unit/indirector/store_configs_spec.rb +0 -1
  270. data/spec/unit/indirector/terminus_spec.rb +27 -27
  271. data/spec/unit/indirector/yaml_spec.rb +5 -6
  272. data/spec/unit/indirector_spec.rb +1 -2
  273. data/spec/unit/info_service_spec.rb +1 -1
  274. data/spec/unit/interface/action_builder_spec.rb +0 -1
  275. data/spec/unit/interface/action_manager_spec.rb +0 -1
  276. data/spec/unit/interface/action_spec.rb +2 -3
  277. data/spec/unit/interface/documentation_spec.rb +0 -1
  278. data/spec/unit/interface/face_collection_spec.rb +19 -12
  279. data/spec/unit/interface_spec.rb +3 -3
  280. data/spec/unit/man_spec.rb +3 -4
  281. data/spec/unit/module_spec.rb +46 -51
  282. data/spec/unit/module_tool/applications/installer_spec.rb +10 -11
  283. data/spec/unit/module_tool/applications/searcher_spec.rb +3 -3
  284. data/spec/unit/module_tool/applications/uninstaller_spec.rb +1 -2
  285. data/spec/unit/module_tool/applications/unpacker_spec.rb +13 -13
  286. data/spec/unit/module_tool/applications/upgrader_spec.rb +5 -5
  287. data/spec/unit/module_tool/install_directory_spec.rb +8 -8
  288. data/spec/unit/module_tool/installed_modules_spec.rb +3 -3
  289. data/spec/unit/module_tool/tar/gnu_spec.rb +6 -6
  290. data/spec/unit/module_tool/tar/mini_spec.rb +12 -12
  291. data/spec/unit/module_tool/tar_spec.rb +12 -13
  292. data/spec/unit/module_tool_spec.rb +7 -12
  293. data/spec/unit/network/auth_config_parser_spec.rb +11 -13
  294. data/spec/unit/network/authconfig_spec.rb +17 -18
  295. data/spec/unit/network/authorization_spec.rb +4 -5
  296. data/spec/unit/network/authstore_spec.rb +0 -1
  297. data/spec/unit/network/format_handler_spec.rb +0 -1
  298. data/spec/unit/network/format_spec.rb +9 -10
  299. data/spec/unit/network/format_support_spec.rb +28 -29
  300. data/spec/unit/network/formats_spec.rb +4 -5
  301. data/spec/unit/network/http/api/indirected_routes_spec.rb +24 -29
  302. data/spec/unit/network/http/api/master/v3/authorization_spec.rb +2 -2
  303. data/spec/unit/network/http/api/master/v3/environment_spec.rb +1 -1
  304. data/spec/unit/network/http/api/master/v3/environments_spec.rb +6 -7
  305. data/spec/unit/network/http/api_spec.rb +0 -2
  306. data/spec/unit/network/http/compression_spec.rb +21 -22
  307. data/spec/unit/network/http/connection_spec.rb +41 -36
  308. data/spec/unit/network/http/factory_spec.rb +5 -6
  309. data/spec/unit/network/http/handler_spec.rb +9 -18
  310. data/spec/unit/network/http/nocache_pool_spec.rb +6 -7
  311. data/spec/unit/network/http/pool_spec.rb +28 -29
  312. data/spec/unit/network/http/request_spec.rb +0 -2
  313. data/spec/unit/network/http/response_spec.rb +11 -13
  314. data/spec/unit/network/http/route_spec.rb +0 -1
  315. data/spec/unit/network/http/session_spec.rb +1 -2
  316. data/spec/unit/network/http/site_spec.rb +0 -1
  317. data/spec/unit/network/http_pool_spec.rb +18 -9
  318. data/spec/unit/network/http_spec.rb +0 -1
  319. data/spec/unit/network/resolver_spec.rb +25 -26
  320. data/spec/unit/network/rights_spec.rb +52 -53
  321. data/spec/unit/node/environment_spec.rb +14 -15
  322. data/spec/unit/node/facts_spec.rb +5 -7
  323. data/spec/unit/node_spec.rb +4 -10
  324. data/spec/unit/other/selinux_spec.rb +0 -1
  325. data/spec/unit/parameter/boolean_spec.rb +1 -2
  326. data/spec/unit/parameter/package_options_spec.rb +1 -2
  327. data/spec/unit/parameter/path_spec.rb +0 -1
  328. data/spec/unit/parameter/value_collection_spec.rb +0 -1
  329. data/spec/unit/parameter/value_spec.rb +0 -1
  330. data/spec/unit/parameter_spec.rb +9 -9
  331. data/spec/unit/parser/ast/block_expression_spec.rb +6 -8
  332. data/spec/unit/parser/ast/leaf_spec.rb +20 -21
  333. data/spec/unit/parser/compiler_spec.rb +84 -96
  334. data/spec/unit/parser/environment_compiler_spec.rb +7 -8
  335. data/spec/unit/parser/files_spec.rb +0 -1
  336. data/spec/unit/parser/functions/create_resources_spec.rb +1 -1
  337. data/spec/unit/parser/functions/digest_spec.rb +0 -1
  338. data/spec/unit/parser/functions/fail_spec.rb +1 -2
  339. data/spec/unit/parser/functions/file_spec.rb +13 -14
  340. data/spec/unit/parser/functions/fqdn_rand_spec.rb +5 -6
  341. data/spec/unit/parser/functions/generate_spec.rb +7 -8
  342. data/spec/unit/parser/functions/inline_template_spec.rb +0 -1
  343. data/spec/unit/parser/functions/regsubst_spec.rb +0 -1
  344. data/spec/unit/parser/functions/scanf_spec.rb +0 -1
  345. data/spec/unit/parser/functions/shellquote_spec.rb +0 -1
  346. data/spec/unit/parser/functions/split_spec.rb +0 -1
  347. data/spec/unit/parser/functions/sprintf_spec.rb +0 -1
  348. data/spec/unit/parser/functions/tag_spec.rb +1 -2
  349. data/spec/unit/parser/functions/tagged_spec.rb +2 -3
  350. data/spec/unit/parser/functions/template_spec.rb +13 -13
  351. data/spec/unit/parser/functions/versioncmp_spec.rb +1 -2
  352. data/spec/unit/parser/functions_spec.rb +6 -7
  353. data/spec/unit/parser/relationship_spec.rb +0 -1
  354. data/spec/unit/parser/resource_spec.rb +42 -42
  355. data/spec/unit/parser/scope_spec.rb +39 -35
  356. data/spec/unit/parser/templatewrapper_spec.rb +11 -12
  357. data/spec/unit/parser/type_loader_spec.rb +17 -19
  358. data/spec/unit/pops/adaptable_spec.rb +0 -1
  359. data/spec/unit/pops/benchmark_spec.rb +0 -1
  360. data/spec/unit/pops/evaluator/access_ops_spec.rb +0 -1
  361. data/spec/unit/pops/evaluator/arithmetic_ops_spec.rb +0 -1
  362. data/spec/unit/pops/evaluator/basic_expressions_spec.rb +0 -1
  363. data/spec/unit/pops/evaluator/collections_ops_spec.rb +0 -1
  364. data/spec/unit/pops/evaluator/comparison_ops_spec.rb +0 -1
  365. data/spec/unit/pops/evaluator/conditionals_spec.rb +0 -1
  366. data/spec/unit/pops/evaluator/evaluating_parser_spec.rb +10 -11
  367. data/spec/unit/pops/evaluator/logical_ops_spec.rb +0 -1
  368. data/spec/unit/pops/evaluator/runtime3_converter_spec.rb +0 -1
  369. data/spec/unit/pops/evaluator/string_interpolation_spec.rb +0 -1
  370. data/spec/unit/pops/evaluator/variables_spec.rb +0 -1
  371. data/spec/unit/pops/factory_spec.rb +3 -4
  372. data/spec/unit/pops/issues_spec.rb +19 -20
  373. data/spec/unit/pops/loaders/loader_spec.rb +8 -4
  374. data/spec/unit/pops/loaders/loaders_spec.rb +31 -28
  375. data/spec/unit/pops/lookup/context_spec.rb +0 -1
  376. data/spec/unit/pops/lookup/interpolation_spec.rb +2 -3
  377. data/spec/unit/pops/merge_strategy_spec.rb +0 -1
  378. data/spec/unit/pops/migration_spec.rb +3 -5
  379. data/spec/unit/pops/model/model_spec.rb +0 -1
  380. data/spec/unit/pops/model/pn_transformer_spec.rb +0 -1
  381. data/spec/unit/pops/parser/locator_spec.rb +3 -6
  382. data/spec/unit/pops/parser/parse_application_spec.rb +0 -1
  383. data/spec/unit/pops/parser/parse_basic_expressions_spec.rb +0 -1
  384. data/spec/unit/pops/parser/parse_calls_spec.rb +0 -1
  385. data/spec/unit/pops/parser/parse_capabilities_spec.rb +0 -1
  386. data/spec/unit/pops/parser/parse_conditionals_spec.rb +0 -1
  387. data/spec/unit/pops/parser/parse_containers_spec.rb +0 -1
  388. data/spec/unit/pops/parser/parse_plan_spec.rb +0 -1
  389. data/spec/unit/pops/parser/parse_resource_spec.rb +0 -1
  390. data/spec/unit/pops/parser/parse_site_spec.rb +0 -1
  391. data/spec/unit/pops/parser/pn_parser_spec.rb +0 -1
  392. data/spec/unit/pops/pn_spec.rb +0 -1
  393. data/spec/unit/pops/resource/resource_type_impl_spec.rb +0 -1
  394. data/spec/unit/pops/serialization/serialization_spec.rb +1 -1
  395. data/spec/unit/pops/serialization/to_from_hr_spec.rb +1 -1
  396. data/spec/unit/pops/types/recursion_guard_spec.rb +10 -10
  397. data/spec/unit/pops/types/ruby_generator_spec.rb +2 -2
  398. data/spec/unit/pops/types/type_asserter_spec.rb +2 -2
  399. data/spec/unit/pops/types/type_calculator_spec.rb +30 -30
  400. data/spec/unit/pops/types/type_parser_spec.rb +13 -13
  401. data/spec/unit/pops/validator/validator_spec.rb +1 -2
  402. data/spec/unit/pops/visitor_spec.rb +0 -1
  403. data/spec/unit/property/boolean_spec.rb +1 -1
  404. data/spec/unit/property/ensure_spec.rb +0 -1
  405. data/spec/unit/property/keyvalue_spec.rb +32 -34
  406. data/spec/unit/property/list_spec.rb +26 -27
  407. data/spec/unit/property/ordered_list_spec.rb +10 -14
  408. data/spec/unit/property_spec.rb +42 -43
  409. data/spec/unit/provider/aix_object_spec.rb +47 -45
  410. data/spec/unit/provider/command_spec.rb +9 -9
  411. data/spec/unit/provider/exec/posix_spec.rb +6 -7
  412. data/spec/unit/provider/exec/shell_spec.rb +0 -1
  413. data/spec/unit/provider/exec/windows_spec.rb +2 -4
  414. data/spec/unit/provider/exec_spec.rb +0 -1
  415. data/spec/unit/provider/file/posix_spec.rb +22 -24
  416. data/spec/unit/provider/file/windows_spec.rb +15 -17
  417. data/spec/unit/provider/group/aix_spec.rb +3 -2
  418. data/spec/unit/provider/group/groupadd_spec.rb +30 -26
  419. data/spec/unit/provider/group/ldap_spec.rb +18 -18
  420. data/spec/unit/provider/group/pw_spec.rb +11 -11
  421. data/spec/unit/provider/group/windows_adsi_spec.rb +54 -54
  422. data/spec/unit/provider/ldap_spec.rb +61 -62
  423. data/spec/unit/provider/nameservice/directoryservice_spec.rb +35 -36
  424. data/spec/unit/provider/nameservice_spec.rb +38 -40
  425. data/spec/unit/provider/package/aix_spec.rb +15 -15
  426. data/spec/unit/provider/package/appdmg_spec.rb +13 -13
  427. data/spec/unit/provider/package/apt_spec.rb +44 -27
  428. data/spec/unit/provider/package/aptitude_spec.rb +6 -7
  429. data/spec/unit/provider/package/aptrpm_spec.rb +7 -12
  430. data/spec/unit/provider/package/base_spec.rb +4 -4
  431. data/spec/unit/provider/package/dnf_spec.rb +18 -20
  432. data/spec/unit/provider/package/dpkg_spec.rb +52 -52
  433. data/spec/unit/provider/package/freebsd_spec.rb +11 -11
  434. data/spec/unit/provider/package/gem_spec.rb +51 -43
  435. data/spec/unit/provider/package/hpux_spec.rb +8 -8
  436. data/spec/unit/provider/package/macports_spec.rb +46 -42
  437. data/spec/unit/provider/package/nim_spec.rb +30 -39
  438. data/spec/unit/provider/package/openbsd_spec.rb +36 -39
  439. data/spec/unit/provider/package/opkg_spec.rb +23 -26
  440. data/spec/unit/provider/package/pacman_spec.rb +97 -118
  441. data/spec/unit/provider/package/pip_spec.rb +71 -72
  442. data/spec/unit/provider/package/pkg_spec.rb +109 -109
  443. data/spec/unit/provider/package/pkgdmg_spec.rb +65 -63
  444. data/spec/unit/provider/package/pkgin_spec.rb +10 -8
  445. data/spec/unit/provider/package/pkgng_spec.rb +17 -18
  446. data/spec/unit/provider/package/pkgutil_spec.rb +45 -49
  447. data/spec/unit/provider/package/portage_spec.rb +70 -74
  448. data/spec/unit/provider/package/puppet_gem_spec.rb +28 -8
  449. data/spec/unit/provider/package/rpm_spec.rb +53 -64
  450. data/spec/unit/provider/package/sun_spec.rb +16 -18
  451. data/spec/unit/provider/package/tdnf_spec.rb +2 -2
  452. data/spec/unit/provider/package/up2date_spec.rb +2 -4
  453. data/spec/unit/provider/package/urpmi_spec.rb +15 -17
  454. data/spec/unit/provider/package/windows/exe_package_spec.rb +12 -15
  455. data/spec/unit/provider/package/windows/msi_package_spec.rb +19 -22
  456. data/spec/unit/provider/package/windows/package_spec.rb +37 -42
  457. data/spec/unit/provider/package/windows_spec.rb +36 -32
  458. data/spec/unit/provider/package/yum_spec.rb +7 -7
  459. data/spec/unit/provider/package/zypper_spec.rb +87 -87
  460. data/spec/unit/provider/parsedfile_spec.rb +44 -45
  461. data/spec/unit/provider/service/base_spec.rb +4 -5
  462. data/spec/unit/provider/service/bsd_spec.rb +27 -29
  463. data/spec/unit/provider/service/daemontools_spec.rb +35 -35
  464. data/spec/unit/provider/service/debian_spec.rb +38 -38
  465. data/spec/unit/provider/service/freebsd_spec.rb +18 -18
  466. data/spec/unit/provider/service/gentoo_spec.rb +50 -55
  467. data/spec/unit/provider/service/init_spec.rb +53 -52
  468. data/spec/unit/provider/service/launchd_spec.rb +138 -116
  469. data/spec/unit/provider/service/openbsd_spec.rb +50 -50
  470. data/spec/unit/provider/service/openrc_spec.rb +43 -45
  471. data/spec/unit/provider/service/openwrt_spec.rb +26 -31
  472. data/spec/unit/provider/service/rcng_spec.rb +14 -14
  473. data/spec/unit/provider/service/redhat_spec.rb +45 -43
  474. data/spec/unit/provider/service/runit_spec.rb +29 -27
  475. data/spec/unit/provider/service/smf_spec.rb +74 -66
  476. data/spec/unit/provider/service/src_spec.rb +46 -47
  477. data/spec/unit/provider/service/systemd_spec.rb +104 -113
  478. data/spec/unit/provider/service/upstart_spec.rb +74 -71
  479. data/spec/unit/provider/service/windows_spec.rb +33 -41
  480. data/spec/unit/provider/user/aix_spec.rb +31 -31
  481. data/spec/unit/provider/user/directoryservice_spec.rb +109 -114
  482. data/spec/unit/provider/user/hpux_spec.rb +16 -16
  483. data/spec/unit/provider/user/ldap_spec.rb +57 -57
  484. data/spec/unit/provider/user/openbsd_spec.rb +10 -12
  485. data/spec/unit/provider/user/pw_spec.rb +37 -35
  486. data/spec/unit/provider/user/user_role_add_spec.rb +93 -93
  487. data/spec/unit/provider/user/useradd_spec.rb +93 -92
  488. data/spec/unit/provider/user/windows_adsi_spec.rb +59 -60
  489. data/spec/unit/provider_spec.rb +35 -35
  490. data/spec/unit/puppet_pal_2pec.rb +4 -5
  491. data/spec/unit/puppet_pal_spec.rb +0 -1
  492. data/spec/unit/puppet_spec.rb +6 -7
  493. data/spec/unit/relationship_spec.rb +0 -1
  494. data/spec/unit/reports/http_spec.rb +21 -23
  495. data/spec/unit/reports/store_spec.rb +3 -4
  496. data/spec/unit/reports_spec.rb +12 -14
  497. data/spec/unit/resource/capability_finder_spec.rb +15 -17
  498. data/spec/unit/resource/catalog_spec.rb +72 -68
  499. data/spec/unit/resource/status_spec.rb +6 -8
  500. data/spec/unit/resource/type_collection_spec.rb +17 -18
  501. data/spec/unit/resource/type_spec.rb +34 -35
  502. data/spec/unit/resource_spec.rb +36 -32
  503. data/spec/unit/rest/client_spec.rb +58 -27
  504. data/spec/unit/rest/route_spec.rb +5 -5
  505. data/spec/unit/scheduler/job_spec.rb +0 -1
  506. data/spec/unit/scheduler/scheduler_spec.rb +0 -1
  507. data/spec/unit/scheduler/splay_job_spec.rb +1 -2
  508. data/spec/unit/settings/array_setting_spec.rb +1 -1
  509. data/spec/unit/settings/autosign_setting_spec.rb +9 -9
  510. data/spec/unit/settings/certificate_revocation_setting_spec.rb +1 -1
  511. data/spec/unit/settings/config_file_spec.rb +0 -1
  512. data/spec/unit/settings/directory_setting_spec.rb +2 -7
  513. data/spec/unit/settings/duration_setting_spec.rb +1 -2
  514. data/spec/unit/settings/enum_setting_spec.rb +1 -1
  515. data/spec/unit/settings/environment_conf_spec.rb +4 -6
  516. data/spec/unit/settings/file_setting_spec.rb +44 -46
  517. data/spec/unit/settings/path_setting_spec.rb +1 -2
  518. data/spec/unit/settings/priority_setting_spec.rb +1 -2
  519. data/spec/unit/settings/string_setting_spec.rb +14 -15
  520. data/spec/unit/settings/terminus_setting_spec.rb +1 -2
  521. data/spec/unit/settings/value_translator_spec.rb +0 -1
  522. data/spec/unit/settings_spec.rb +228 -235
  523. data/spec/unit/ssl/base_spec.rb +14 -15
  524. data/spec/unit/ssl/certificate_request_spec.rb +62 -58
  525. data/spec/unit/ssl/certificate_spec.rb +23 -25
  526. data/spec/unit/ssl/digest_spec.rb +0 -1
  527. data/spec/unit/ssl/host_spec.rb +166 -149
  528. data/spec/unit/ssl/key_spec.rb +30 -31
  529. data/spec/unit/ssl/validator_spec.rb +38 -39
  530. data/spec/unit/task_spec.rb +44 -45
  531. data/spec/unit/transaction/additional_resource_generator_spec.rb +3 -5
  532. data/spec/unit/transaction/event_manager_spec.rb +87 -88
  533. data/spec/unit/transaction/event_spec.rb +16 -15
  534. data/spec/unit/transaction/persistence_spec.rb +16 -17
  535. data/spec/unit/transaction/report_spec.rb +11 -12
  536. data/spec/unit/transaction/resource_harness_spec.rb +28 -33
  537. data/spec/unit/transaction_spec.rb +100 -101
  538. data/spec/unit/type/component_spec.rb +0 -1
  539. data/spec/unit/type/exec_spec.rb +60 -56
  540. data/spec/unit/type/file/checksum_spec.rb +9 -10
  541. data/spec/unit/type/file/checksum_value_spec.rb +31 -32
  542. data/spec/unit/type/file/content_spec.rb +58 -61
  543. data/spec/unit/type/file/ctime_spec.rb +0 -1
  544. data/spec/unit/type/file/ensure_spec.rb +12 -13
  545. data/spec/unit/type/file/group_spec.rb +5 -7
  546. data/spec/unit/type/file/mode_spec.rb +4 -6
  547. data/spec/unit/type/file/mtime_spec.rb +0 -1
  548. data/spec/unit/type/file/owner_spec.rb +6 -8
  549. data/spec/unit/type/file/selinux_spec.rb +17 -19
  550. data/spec/unit/type/file/source_spec.rb +104 -101
  551. data/spec/unit/type/file/type_spec.rb +0 -1
  552. data/spec/unit/type/file_spec.rb +195 -185
  553. data/spec/unit/type/filebucket_spec.rb +4 -5
  554. data/spec/unit/type/group_spec.rb +6 -8
  555. data/spec/unit/type/noop_metaparam_spec.rb +1 -2
  556. data/spec/unit/type/package/package_settings_spec.rb +44 -23
  557. data/spec/unit/type/package_spec.rb +56 -57
  558. data/spec/unit/type/resources_spec.rb +72 -74
  559. data/spec/unit/type/schedule_spec.rb +24 -26
  560. data/spec/unit/type/service_spec.rb +48 -48
  561. data/spec/unit/type/stage_spec.rb +0 -1
  562. data/spec/unit/type/tidy_spec.rb +61 -62
  563. data/spec/unit/type/user_spec.rb +24 -25
  564. data/spec/unit/type/whit_spec.rb +0 -1
  565. data/spec/unit/type_spec.rb +55 -54
  566. data/spec/unit/util/at_fork_spec.rb +18 -19
  567. data/spec/unit/util/autoload_spec.rb +55 -56
  568. data/spec/unit/util/backups_spec.rb +34 -35
  569. data/spec/unit/util/character_encoding_spec.rb +5 -5
  570. data/spec/unit/util/checksums_spec.rb +38 -39
  571. data/spec/unit/util/colors_spec.rb +1 -2
  572. data/spec/unit/util/command_line_spec.rb +24 -25
  573. data/spec/unit/util/constant_inflector_spec.rb +0 -1
  574. data/spec/unit/util/diff_spec.rb +7 -8
  575. data/spec/unit/util/errors_spec.rb +0 -1
  576. data/spec/unit/util/execution_spec.rb +185 -161
  577. data/spec/unit/util/execution_stub_spec.rb +0 -1
  578. data/spec/unit/util/feature_spec.rb +21 -14
  579. data/spec/unit/util/filetype_spec.rb +49 -49
  580. data/spec/unit/util/http_proxy_spec.rb +12 -12
  581. data/spec/unit/util/inifile_spec.rb +26 -31
  582. data/spec/unit/util/json_lockfile_spec.rb +3 -5
  583. data/spec/unit/util/ldap/connection_spec.rb +26 -25
  584. data/spec/unit/util/ldap/generator_spec.rb +0 -1
  585. data/spec/unit/util/ldap/manager_spec.rb +102 -101
  586. data/spec/unit/util/lockfile_spec.rb +0 -1
  587. data/spec/unit/util/log/destinations_spec.rb +30 -33
  588. data/spec/unit/util/log_spec.rb +35 -36
  589. data/spec/unit/util/logging_spec.rb +58 -72
  590. data/spec/unit/util/metric_spec.rb +0 -1
  591. data/spec/unit/util/monkey_patches_spec.rb +7 -9
  592. data/spec/unit/util/multi_match_spec.rb +0 -1
  593. data/spec/unit/util/network_device/config_spec.rb +0 -1
  594. data/spec/unit/util/network_device/transport/base_spec.rb +5 -6
  595. data/spec/unit/util/network_device_spec.rb +7 -9
  596. data/spec/unit/util/package_spec.rb +0 -1
  597. data/spec/unit/util/pidlock_spec.rb +21 -22
  598. data/spec/unit/util/plist_spec.rb +40 -33
  599. data/spec/unit/util/posix_spec.rb +54 -51
  600. data/spec/unit/util/rdoc_spec.rb +9 -10
  601. data/spec/unit/util/reference_spec.rb +0 -1
  602. data/spec/unit/util/resource_template_spec.rb +20 -20
  603. data/spec/unit/util/retry_action_spec.rb +7 -8
  604. data/spec/unit/util/rubygems_spec.rb +7 -8
  605. data/spec/unit/util/run_mode_spec.rb +3 -4
  606. data/spec/unit/util/selinux_spec.rb +79 -72
  607. data/spec/unit/util/splayer_spec.rb +8 -9
  608. data/spec/unit/util/ssl_spec.rb +0 -1
  609. data/spec/unit/util/storage_spec.rb +3 -4
  610. data/spec/unit/util/suidmanager_spec.rb +45 -54
  611. data/spec/unit/util/symbolic_file_mode_spec.rb +0 -1
  612. data/spec/unit/util/tag_set_spec.rb +0 -1
  613. data/spec/unit/util/tagging_spec.rb +0 -1
  614. data/spec/unit/util/terminal_spec.rb +9 -10
  615. data/spec/unit/util/user_attr_spec.rb +1 -2
  616. data/spec/unit/util/warnings_spec.rb +3 -4
  617. data/spec/unit/util/watcher/periodic_watcher_spec.rb +2 -2
  618. data/spec/unit/util/watcher_spec.rb +51 -21
  619. data/spec/unit/util/windows/access_control_entry_spec.rb +0 -1
  620. data/spec/unit/util/windows/access_control_list_spec.rb +0 -1
  621. data/spec/unit/util/windows/adsi_spec.rb +136 -138
  622. data/spec/unit/util/windows/api_types_spec.rb +0 -1
  623. data/spec/unit/util/windows/eventlog_spec.rb +9 -12
  624. data/spec/unit/util/windows/file_spec.rb +0 -1
  625. data/spec/unit/util/windows/root_certs_spec.rb +0 -1
  626. data/spec/unit/util/windows/security_descriptor_spec.rb +0 -2
  627. data/spec/unit/util/windows/service_spec.rb +66 -68
  628. data/spec/unit/util/windows/sid_spec.rb +11 -13
  629. data/spec/unit/util/windows/string_spec.rb +0 -1
  630. data/spec/unit/util_spec.rb +55 -57
  631. data/spec/unit/version_spec.rb +6 -6
  632. metadata +2 -2
@@ -1,22 +1,18 @@
1
- #! /usr/bin/env ruby
2
1
  require 'spec_helper'
3
2
 
4
3
  require 'puppet/property/ordered_list'
5
4
 
6
- ordered_list_class = Puppet::Property::OrderedList
7
-
8
- describe ordered_list_class do
9
-
5
+ describe Puppet::Property::OrderedList do
10
6
  it "should be a subclass of List" do
11
- expect(ordered_list_class.superclass).to eq(Puppet::Property::List)
7
+ expect(described_class.superclass).to eq(Puppet::Property::List)
12
8
  end
13
9
 
14
10
  describe "as an instance" do
15
11
  before do
16
12
  # Wow that's a messy interface to the resource.
17
- ordered_list_class.initvars
18
- @resource = stub 'resource', :[]= => nil, :property => nil
19
- @property = ordered_list_class.new(:resource => @resource)
13
+ described_class.initvars
14
+ @resource = double('resource', :[]= => nil, :property => nil)
15
+ @property = described_class.new(:resource => @resource)
20
16
  end
21
17
 
22
18
  describe "when adding should to current" do
@@ -40,22 +36,22 @@ describe ordered_list_class do
40
36
 
41
37
  it "should return the values of @should (without sorting) as a string if inclusive" do
42
38
  @property.should = ["foo", "bar"]
43
- @property.expects(:inclusive?).returns(true)
39
+ expect(@property).to receive(:inclusive?).and_return(true)
44
40
  expect(@property.should).to eq("foo,bar")
45
41
  end
46
42
 
47
43
  it "should return the uniq values of @should + retrieve as a string if !inclusive with the @ values leading" do
48
44
  @property.should = ["foo", "bar"]
49
- @property.expects(:inclusive?).returns(false)
50
- @property.expects(:retrieve).returns(["foo","baz"])
45
+ expect(@property).to receive(:inclusive?).and_return(false)
46
+ expect(@property).to receive(:retrieve).and_return(["foo","baz"])
51
47
  expect(@property.should).to eq("foo,bar,baz")
52
48
  end
53
49
  end
54
50
 
55
51
  describe "when calling dearrayify" do
56
52
  it "should join the array with the delimiter" do
57
- array = mock "array"
58
- array.expects(:join).with(@property.delimiter)
53
+ array = double("array")
54
+ expect(array).to receive(:join).with(@property.delimiter)
59
55
  @property.dearrayify(array)
60
56
  end
61
57
  end
@@ -1,4 +1,3 @@
1
- #! /usr/bin/env ruby
2
1
  require 'spec_helper'
3
2
  require 'puppet/property'
4
3
 
@@ -60,73 +59,73 @@ describe Puppet::Property do
60
59
 
61
60
  describe "when returning the default event name" do
62
61
  it "should use the current 'should' value to pick the event name" do
63
- property.expects(:should).returns "myvalue"
64
- subclass.expects(:value_option).with('myvalue', :event).returns :event_name
62
+ expect(property).to receive(:should).and_return("myvalue")
63
+ expect(subclass).to receive(:value_option).with('myvalue', :event).and_return(:event_name)
65
64
 
66
65
  property.event_name
67
66
  end
68
67
 
69
68
  it "should return any event defined with the specified value" do
70
- property.expects(:should).returns :myval
71
- subclass.expects(:value_option).with(:myval, :event).returns :event_name
69
+ expect(property).to receive(:should).and_return(:myval)
70
+ expect(subclass).to receive(:value_option).with(:myval, :event).and_return(:event_name)
72
71
 
73
72
  expect(property.event_name).to eq(:event_name)
74
73
  end
75
74
 
76
75
  describe "and the property is 'ensure'" do
77
76
  before :each do
78
- property.stubs(:name).returns :ensure
79
- resource.expects(:type).returns :mytype
77
+ allow(property).to receive(:name).and_return(:ensure)
78
+ expect(resource).to receive(:type).and_return(:mytype)
80
79
  end
81
80
 
82
81
  it "should use <type>_created if the 'should' value is 'present'" do
83
- property.expects(:should).returns :present
82
+ expect(property).to receive(:should).and_return(:present)
84
83
  expect(property.event_name).to eq(:mytype_created)
85
84
  end
86
85
 
87
86
  it "should use <type>_removed if the 'should' value is 'absent'" do
88
- property.expects(:should).returns :absent
87
+ expect(property).to receive(:should).and_return(:absent)
89
88
  expect(property.event_name).to eq(:mytype_removed)
90
89
  end
91
90
 
92
91
  it "should use <type>_changed if the 'should' value is not 'absent' or 'present'" do
93
- property.expects(:should).returns :foo
92
+ expect(property).to receive(:should).and_return(:foo)
94
93
  expect(property.event_name).to eq(:mytype_changed)
95
94
  end
96
95
 
97
96
  it "should use <type>_changed if the 'should value is nil" do
98
- property.expects(:should).returns nil
97
+ expect(property).to receive(:should).and_return(nil)
99
98
  expect(property.event_name).to eq(:mytype_changed)
100
99
  end
101
100
  end
102
101
 
103
102
  it "should use <property>_changed if the property is not 'ensure'" do
104
- property.stubs(:name).returns :myparam
105
- property.expects(:should).returns :foo
103
+ allow(property).to receive(:name).and_return(:myparam)
104
+ expect(property).to receive(:should).and_return(:foo)
106
105
  expect(property.event_name).to eq(:myparam_changed)
107
106
  end
108
107
 
109
108
  it "should use <property>_changed if no 'should' value is set" do
110
- property.stubs(:name).returns :myparam
111
- property.expects(:should).returns nil
109
+ allow(property).to receive(:name).and_return(:myparam)
110
+ expect(property).to receive(:should).and_return(nil)
112
111
  expect(property.event_name).to eq(:myparam_changed)
113
112
  end
114
113
  end
115
114
 
116
115
  describe "when creating an event" do
117
116
  before :each do
118
- property.stubs(:should).returns "myval"
117
+ allow(property).to receive(:should).and_return("myval")
119
118
  end
120
119
 
121
120
  it "should use an event from the resource as the base event" do
122
121
  event = Puppet::Transaction::Event.new
123
- resource.expects(:event).returns event
122
+ expect(resource).to receive(:event).and_return(event)
124
123
 
125
124
  expect(property.event).to equal(event)
126
125
  end
127
126
 
128
127
  it "should have the default event name" do
129
- property.expects(:event_name).returns :my_event
128
+ expect(property).to receive(:event_name).and_return(:my_event)
130
129
  expect(property.event.name).to eq(:my_event)
131
130
  end
132
131
 
@@ -135,23 +134,23 @@ describe Puppet::Property do
135
134
  end
136
135
 
137
136
  it "should have the 'should' value set" do
138
- property.stubs(:should).returns "foo"
137
+ allow(property).to receive(:should).and_return("foo")
139
138
  expect(property.event.desired_value).to eq("foo")
140
139
  end
141
140
 
142
141
  it "should provide its path as the source description" do
143
- property.stubs(:path).returns "/my/param"
142
+ allow(property).to receive(:path).and_return("/my/param")
144
143
  expect(property.event.source_description).to eq("/my/param")
145
144
  end
146
145
 
147
146
  it "should have the 'invalidate_refreshes' value set if set on a value" do
148
- property.stubs(:event_name).returns :my_event
149
- property.stubs(:should).returns "foo"
150
- foo = mock()
151
- foo.expects(:invalidate_refreshes).returns(true)
152
- collection = mock()
153
- collection.expects(:match?).with("foo").returns(foo)
154
- property.class.stubs(:value_collection).returns(collection)
147
+ allow(property).to receive(:event_name).and_return(:my_event)
148
+ allow(property).to receive(:should).and_return("foo")
149
+ foo = double()
150
+ expect(foo).to receive(:invalidate_refreshes).and_return(true)
151
+ collection = double()
152
+ expect(collection).to receive(:match?).with("foo").and_return(foo)
153
+ allow(property.class).to receive(:value_collection).and_return(collection)
155
154
  expect(property.event.invalidate_refreshes).to be_truthy
156
155
  end
157
156
 
@@ -175,15 +174,15 @@ describe Puppet::Property do
175
174
  end
176
175
 
177
176
  it "should validate each value separately" do
178
- property.expects(:validate).with("one")
179
- property.expects(:validate).with("two")
177
+ expect(property).to receive(:validate).with("one")
178
+ expect(property).to receive(:validate).with("two")
180
179
 
181
180
  property.value = %w{one two}
182
181
  end
183
182
 
184
183
  it "should munge each value separately and use any result as the actual value" do
185
- property.expects(:munge).with("one").returns :one
186
- property.expects(:munge).with("two").returns :two
184
+ expect(property).to receive(:munge).with("one").and_return(:one)
185
+ expect(property).to receive(:munge).with("two").and_return(:two)
187
186
 
188
187
  # Do this so we get the whole array back.
189
188
  subclass.array_matching = :all
@@ -280,7 +279,7 @@ describe Puppet::Property do
280
279
  it "should validate that all required features are present" do
281
280
  subclass.newvalue(:foo, :required_features => [:a, :b])
282
281
 
283
- resource.provider.expects(:satisfies?).with([:a, :b]).returns true
282
+ expect(resource.provider).to receive(:satisfies?).with([:a, :b]).and_return(true)
284
283
 
285
284
  property.should = :foo
286
285
  end
@@ -288,7 +287,7 @@ describe Puppet::Property do
288
287
  it "should fail if required features are missing" do
289
288
  subclass.newvalue(:foo, :required_features => [:a, :b])
290
289
 
291
- resource.provider.expects(:satisfies?).with([:a, :b]).returns false
290
+ expect(resource.provider).to receive(:satisfies?).with([:a, :b]).and_return(false)
292
291
 
293
292
  expect { property.should = :foo }.to raise_error(Puppet::Error)
294
293
  end
@@ -296,7 +295,7 @@ describe Puppet::Property do
296
295
  it "should internally raise an ArgumentError if required features are missing" do
297
296
  subclass.newvalue(:foo, :required_features => [:a, :b])
298
297
 
299
- resource.provider.expects(:satisfies?).with([:a, :b]).returns false
298
+ expect(resource.provider).to receive(:satisfies?).with([:a, :b]).and_return(false)
300
299
 
301
300
  expect { property.validate_features_per_value :foo }.to raise_error(ArgumentError)
302
301
  end
@@ -304,7 +303,7 @@ describe Puppet::Property do
304
303
  it "should validate that all required features are present for regexes" do
305
304
  subclass.newvalue(/./, :required_features => [:a, :b])
306
305
 
307
- resource.provider.expects(:satisfies?).with([:a, :b]).returns true
306
+ expect(resource.provider).to receive(:satisfies?).with([:a, :b]).and_return(true)
308
307
 
309
308
  property.should = "foo"
310
309
  end
@@ -312,7 +311,7 @@ describe Puppet::Property do
312
311
  it "should support specifying an individual required feature" do
313
312
  subclass.newvalue(/./, :required_features => :a)
314
313
 
315
- resource.provider.expects(:satisfies?).returns true
314
+ expect(resource.provider).to receive(:satisfies?).and_return(true)
316
315
 
317
316
  property.should = "foo"
318
317
  end
@@ -349,7 +348,7 @@ describe Puppet::Property do
349
348
  it "should set the value" do
350
349
  subclass.newvalue(:foo)
351
350
  property.should = :foo
352
- property.expects(:set).with(:foo)
351
+ expect(property).to receive(:set).with(:foo)
353
352
  property.sync
354
353
  end
355
354
  end
@@ -378,13 +377,13 @@ describe Puppet::Property do
378
377
  describe "that was defined without a block" do
379
378
  it "should call the settor on the provider" do
380
379
  subclass.newvalue(:bar)
381
- resource.provider.expects(:foo=).with :bar
380
+ expect(resource.provider).to receive(:foo=).with(:bar)
382
381
  property.set(:bar)
383
382
  end
384
383
 
385
384
  it "should generate setter named from :method argument and propagate call to the provider" do
386
385
  subclass.newvalue(:bar, :method => 'set_vv')
387
- resource.provider.expects(:foo=).with :bar
386
+ expect(resource.provider).to receive(:foo=).with(:bar)
388
387
  property.set_vv(:bar)
389
388
  end
390
389
  end
@@ -392,14 +391,14 @@ describe Puppet::Property do
392
391
  describe "that was defined with a block" do
393
392
  it "should call the method created for the value if the value is not a regex" do
394
393
  subclass.newvalue(:bar) {}
395
- property.expects(:set_bar)
394
+ expect(property).to receive(:set_bar)
396
395
  property.set(:bar)
397
396
  end
398
397
 
399
398
  it "should call the provided block if the value is a regex" do
400
- thing = mock
399
+ thing = double
401
400
  subclass.newvalue(/./) { thing.test }
402
- thing.expects(:test)
401
+ expect(thing).to receive(:test)
403
402
  property.set("foo")
404
403
  end
405
404
  end
@@ -556,7 +555,7 @@ describe Puppet::Property do
556
555
 
557
556
  describe "#insync_values?" do
558
557
  it "should log an exception when insync? throws one" do
559
- property.expects(:insync?).raises ArgumentError
558
+ expect(property).to receive(:insync?).and_raise(ArgumentError)
560
559
  expect(property.insync_values?("foo","bar")).to be nil
561
560
  end
562
561
  end
@@ -156,7 +156,7 @@ describe 'Puppet::Provider::AixObject' do
156
156
  provider.instance_variable_set(:@object_info, { :foo => 'foo', :baz => 'baz' })
157
157
 
158
158
  (provider.class.mappings[:aix_attribute].keys + [:attributes]).each do |property|
159
- provider.expects(:get).with(property).returns('value')
159
+ expect(provider).to receive(:get).with(property).and_return('value')
160
160
 
161
161
  expect(provider.send(property)).to eql('value')
162
162
  end
@@ -167,7 +167,7 @@ describe 'Puppet::Provider::AixObject' do
167
167
 
168
168
  value = '15'
169
169
  provider.class.mappings[:aix_attribute].keys.each do |property|
170
- provider.expects(:set).with(property, value)
170
+ expect(provider).to receive(:set).with(property, value)
171
171
 
172
172
  provider.send("#{property}=".to_sym, value)
173
173
  end
@@ -295,8 +295,8 @@ bin:2
295
295
 
296
296
  it 'lists all of the objects' do
297
297
  lscmd = 'lsgroups'
298
- provider.class.stubs(:command).with(:list).returns(lscmd)
299
- provider.class.stubs(:execute).with([lscmd, '-c', '-a', 'id', 'ALL']).returns(output)
298
+ allow(provider.class).to receive(:command).with(:list).and_return(lscmd)
299
+ allow(provider.class).to receive(:execute).with([lscmd, '-c', '-a', 'id', 'ALL']).and_return(output)
300
300
 
301
301
  expected_objects = [
302
302
  { :name => 'system', :id => '0' },
@@ -316,7 +316,7 @@ bin:2
316
316
  end
317
317
 
318
318
  it 'returns all of the available instances' do
319
- provider.class.stubs(:list_all).returns(objects)
319
+ allow(provider.class).to receive(:list_all).and_return(objects)
320
320
 
321
321
  expect(provider.class.instances.map(&:name)).to eql(['group1', 'group2'])
322
322
  end
@@ -419,20 +419,20 @@ bin:2
419
419
 
420
420
  describe '#ia_module_args' do
421
421
  it 'returns no arguments if the ia_load_module parameter is not specified' do
422
- provider.resource.stubs(:[]).with(:ia_load_module).returns(nil)
422
+ allow(provider.resource).to receive(:[]).with(:ia_load_module).and_return(nil)
423
423
  expect(provider.ia_module_args).to eql([])
424
424
  end
425
425
 
426
426
  it 'returns the ia_load_module as a CLI argument' do
427
- provider.resource.stubs(:[]).with(:ia_load_module).returns('module')
427
+ allow(provider.resource).to receive(:[]).with(:ia_load_module).and_return('module')
428
428
  expect(provider.ia_module_args).to eql(['-R', 'module'])
429
429
  end
430
430
  end
431
431
 
432
432
  describe '#lscmd' do
433
433
  it 'returns the lscmd' do
434
- provider.class.stubs(:command).with(:list).returns('list')
435
- provider.stubs(:ia_module_args).returns(['ia_module_args'])
434
+ allow(provider.class).to receive(:command).with(:list).and_return('list')
435
+ allow(provider).to receive(:ia_module_args).and_return(['ia_module_args'])
436
436
 
437
437
  expect(provider.lscmd).to eql(
438
438
  ['list', '-c', 'ia_module_args', provider.resource.name]
@@ -449,8 +449,8 @@ bin:2
449
449
  end
450
450
 
451
451
  it 'returns the addcmd passing in the attributes as CLI arguments' do
452
- provider.class.stubs(:command).with(:add).returns('add')
453
- provider.stubs(:ia_module_args).returns(['ia_module_args'])
452
+ allow(provider.class).to receive(:command).with(:add).and_return('add')
453
+ allow(provider).to receive(:ia_module_args).and_return(['ia_module_args'])
454
454
 
455
455
  expect(provider.addcmd(attributes)).to eql(
456
456
  ['add', 'ia_module_args', 'attribute1=value1', 'attribute2=value2', provider.resource.name]
@@ -460,8 +460,8 @@ bin:2
460
460
 
461
461
  describe '#deletecmd' do
462
462
  it 'returns the lscmd' do
463
- provider.class.stubs(:command).with(:delete).returns('delete')
464
- provider.stubs(:ia_module_args).returns(['ia_module_args'])
463
+ allow(provider.class).to receive(:command).with(:delete).and_return('delete')
464
+ allow(provider).to receive(:ia_module_args).and_return(['ia_module_args'])
465
465
 
466
466
  expect(provider.deletecmd).to eql(
467
467
  ['delete', 'ia_module_args', provider.resource.name]
@@ -478,8 +478,8 @@ bin:2
478
478
  end
479
479
 
480
480
  it 'returns the addcmd passing in the attributes as CLI arguments' do
481
- provider.class.stubs(:command).with(:modify).returns('modify')
482
- provider.stubs(:ia_module_args).returns(['ia_module_args'])
481
+ allow(provider.class).to receive(:command).with(:modify).and_return('modify')
482
+ allow(provider).to receive(:ia_module_args).and_return(['ia_module_args'])
483
483
 
484
484
  expect(provider.modifycmd(attributes)).to eql(
485
485
  ['modify', 'ia_module_args', 'attribute1=value1', 'attribute2=value2', provider.resource.name]
@@ -496,9 +496,9 @@ bin:2
496
496
  end
497
497
 
498
498
  it 'modifies the AIX object with the new attributes' do
499
- provider.stubs(:modifycmd).with(new_attributes).returns('modify_cmd')
500
- provider.expects(:execute).with('modify_cmd')
501
- provider.expects(:object_info).with(true)
499
+ allow(provider).to receive(:modifycmd).with(new_attributes).and_return('modify_cmd')
500
+ expect(provider).to receive(:execute).with('modify_cmd')
501
+ expect(provider).to receive(:object_info).with(true)
502
502
 
503
503
  provider.modify_object(new_attributes)
504
504
  end
@@ -516,20 +516,20 @@ bin:2
516
516
  end
517
517
 
518
518
  it 'returns :absent if the AIX object does not exist' do
519
- provider.stubs(:exists?).returns(false)
519
+ allow(provider).to receive(:exists?).and_return(false)
520
520
  object_info[property] = 15
521
521
 
522
522
  expect(provider.get(property)).to eql(:absent)
523
523
  end
524
524
 
525
525
  it 'returns :absent if the property is not present on the system' do
526
- provider.stubs(:exists?).returns(true)
526
+ allow(provider).to receive(:exists?).and_return(true)
527
527
 
528
528
  expect(provider.get(property)).to eql(:absent)
529
529
  end
530
530
 
531
531
  it "returns the property's value" do
532
- provider.stubs(:exists?).returns(true)
532
+ allow(provider).to receive(:exists?).and_return(true)
533
533
  object_info[property] = 15
534
534
 
535
535
  expect(provider.get(property)).to eql(15)
@@ -557,9 +557,9 @@ bin:2
557
557
  end
558
558
 
559
559
  it "raises a Puppet::Error if it fails to set the property's value" do
560
- provider.stubs(:modify_object)
560
+ allow(provider).to receive(:modify_object)
561
561
  .with({ :id => value.to_s })
562
- .raises(Puppet::ExecutionFailure, 'failed to modify the AIX object!')
562
+ .and_raise(Puppet::ExecutionFailure, 'failed to modify the AIX object!')
563
563
 
564
564
  expect { provider.set(property, value) }.to raise_error do |error|
565
565
  expect(error).to be_a(Puppet::Error)
@@ -567,7 +567,7 @@ bin:2
567
567
  end
568
568
 
569
569
  it "sets the given property's value to the passed-in value" do
570
- provider.expects(:modify_object).with({ :id => value.to_s })
570
+ expect(provider).to receive(:modify_object).with({ :id => value.to_s })
571
571
 
572
572
  provider.set(property, value)
573
573
  end
@@ -618,9 +618,9 @@ bin:2
618
618
  end
619
619
 
620
620
  it 'raises a Puppet::Error if it fails to set the new AIX attributes' do
621
- provider.stubs(:modify_object)
621
+ allow(provider).to receive(:modify_object)
622
622
  .with(new_attributes)
623
- .raises(Puppet::ExecutionFailure, 'failed to modify the AIX object!')
623
+ .and_raise(Puppet::ExecutionFailure, 'failed to modify the AIX object!')
624
624
 
625
625
  expect { provider.attributes = new_attributes }.to raise_error do |error|
626
626
  expect(error).to be_a(Puppet::Error)
@@ -630,7 +630,7 @@ bin:2
630
630
  end
631
631
 
632
632
  it 'sets the new AIX attributes' do
633
- provider.expects(:modify_object).with(new_attributes)
633
+ expect(provider).to receive(:modify_object).with(new_attributes)
634
634
 
635
635
  provider.attributes = new_attributes
636
636
  end
@@ -650,7 +650,7 @@ bin:2
650
650
  )
651
651
 
652
652
  # Mock out our lscmd
653
- provider.stubs(:lscmd).returns("lsuser #{resource[:name]}")
653
+ allow(provider).to receive(:lscmd).and_return("lsuser #{resource[:name]}")
654
654
  end
655
655
 
656
656
  it 'memoizes the result' do
@@ -659,7 +659,7 @@ bin:2
659
659
  end
660
660
 
661
661
  it 'returns nil if the AIX object does not exist' do
662
- provider.stubs(:execute).with(provider.lscmd).raises(
662
+ allow(provider).to receive(:execute).with(provider.lscmd).and_raise(
663
663
  Puppet::ExecutionFailure, 'lscmd failed!'
664
664
  )
665
665
 
@@ -668,7 +668,7 @@ bin:2
668
668
 
669
669
  it 'collects the Puppet properties' do
670
670
  output = 'mock_output'
671
- provider.stubs(:execute).with(provider.lscmd).returns(output)
671
+ allow(provider).to receive(:execute).with(provider.lscmd).and_return(output)
672
672
 
673
673
  # Mock the AIX attributes on the system
674
674
  mock_attributes = {
@@ -677,9 +677,9 @@ bin:2
677
677
  :attribute1 => 'value1',
678
678
  :attribute2 => 'value2'
679
679
  }
680
- provider.class.stubs(:parse_aix_objects)
680
+ allow(provider.class).to receive(:parse_aix_objects)
681
681
  .with(output)
682
- .returns([{ :name => resource.name, :attributes => mock_attributes }])
682
+ .and_return([{ :name => resource.name, :attributes => mock_attributes }])
683
683
 
684
684
  expected_property_values = {
685
685
  :uid => 1,
@@ -696,12 +696,12 @@ bin:2
696
696
 
697
697
  describe '#exists?' do
698
698
  it 'should return true if the AIX object exists' do
699
- provider.stubs(:object_info).returns({})
699
+ allow(provider).to receive(:object_info).and_return({})
700
700
  expect(provider.exists?).to be(true)
701
701
  end
702
702
 
703
703
  it 'should return false if the AIX object does not exist' do
704
- provider.stubs(:object_info).returns(nil)
704
+ allow(provider).to receive(:object_info).and_return(nil)
705
705
  expect(provider.exists?).to be(false)
706
706
  end
707
707
  end
@@ -710,9 +710,11 @@ bin:2
710
710
  let(:property_attributes) do
711
711
  {}
712
712
  end
713
+
713
714
  def stub_attributes_property(attributes)
714
- provider.resource.stubs(:should).with(:attributes).returns(attributes)
715
+ allow(provider.resource).to receive(:should).with(:attributes).and_return(attributes)
715
716
  end
717
+
716
718
  def set_property(puppet_property, aix_attribute, property_to_attribute, should_value = nil)
717
719
  property_to_attribute ||= lambda { |x| x }
718
720
 
@@ -721,7 +723,7 @@ bin:2
721
723
  aix_attribute: aix_attribute,
722
724
  property_to_attribute: property_to_attribute
723
725
  )
724
- provider.resource.stubs(:should).with(puppet_property).returns(should_value)
726
+ allow(provider.resource).to receive(:should).with(puppet_property).and_return(should_value)
725
727
 
726
728
  if should_value
727
729
  property_attributes[aix_attribute] = property_to_attribute.call(should_value)
@@ -753,8 +755,8 @@ bin:2
753
755
  end
754
756
 
755
757
  it "raises a Puppet::Error if it fails to create the AIX object" do
756
- provider.stubs(:addcmd)
757
- provider.stubs(:execute).raises(
758
+ allow(provider).to receive(:addcmd)
759
+ allow(provider).to receive(:execute).and_raise(
758
760
  Puppet::ExecutionFailure, "addcmd failed!"
759
761
  )
760
762
 
@@ -769,10 +771,10 @@ bin:2
769
771
  attributes = { :fsize => 1000 }
770
772
  stub_attributes_property(attributes)
771
773
 
772
- provider.expects(:addcmd)
774
+ expect(provider).to receive(:addcmd)
773
775
  .with(attributes.merge(property_attributes))
774
- .returns('addcmd')
775
- provider.expects(:execute).with('addcmd')
776
+ .and_return('addcmd')
777
+ expect(provider).to receive(:execute).with('addcmd')
776
778
 
777
779
  provider.create
778
780
  end
@@ -780,11 +782,11 @@ bin:2
780
782
 
781
783
  describe "#delete" do
782
784
  before(:each) do
783
- provider.stubs(:deletecmd).returns('deletecmd')
785
+ allow(provider).to receive(:deletecmd).and_return('deletecmd')
784
786
  end
785
787
 
786
788
  it "raises a Puppet::Error if it fails to delete the AIX object" do
787
- provider.stubs(:execute).with(provider.deletecmd).raises(
789
+ allow(provider).to receive(:execute).with(provider.deletecmd).and_raise(
788
790
  Puppet::ExecutionFailure, "deletecmd failed!"
789
791
  )
790
792
 
@@ -796,8 +798,8 @@ bin:2
796
798
  end
797
799
 
798
800
  it "deletes the AIX object" do
799
- provider.expects(:execute).with(provider.deletecmd)
800
- provider.expects(:object_info).with(true)
801
+ expect(provider).to receive(:execute).with(provider.deletecmd)
802
+ expect(provider).to receive(:object_info).with(true)
801
803
 
802
804
  provider.delete
803
805
  end