puppet-lint 0.2.0 → 0.2.1

data/spec/puppet-lint/plugins/check_classes_spec.rb

@@ -1,390 +0,0 @@
-require 'spec_helper'
-
-describe PuppetLint::Plugins::CheckClasses do
-  subject do
-    klass = described_class.new
-    fileinfo = {}
-    fileinfo[:fullpath] = defined?(fullpath).nil? ? '' : fullpath
-    klass.run(fileinfo, code)
-    klass
-  end
-
-  describe 'chain 2 resources left to right' do
-    let(:code) { "Class[foo] -> Class[bar]" }
-
-    its(:problems) { should be_empty }
-  end
-
-  describe 'chain 2 resources right to left' do
-    let(:code) { "Class[foo] <- Class[bar]" }
-
-    its(:problems) {
-      should have_problem({
-        :kind       => :warning,
-        :message    => "right-to-left (<-) relationship",
-        :linenumber => 1,
-        :column     => 12,
-      })
-      should_not have_problem :kind => :error
-    }
-  end
-
-  describe 'class on its own' do
-    let(:code) { "class foo { }" }
-
-    its(:problems) { should be_empty }
-  end
-
-  describe 'class inside a class' do
-    let(:code) { "
-      class foo {
-        class bar {
-        }
-      }"
-    }
-
-    its(:problems) {
-      should have_problem({
-        :kind       => :warning,
-        :message    => "class defined inside a class",
-        :linenumber => 3,
-        :column     => 9,
-      })
-      should_not have_problem :kind => :error
-    }
-  end
-
-  describe 'define inside a class' do
-    let(:code) { "
-      class foo {
-        define bar() {
-        }
-      }"
-    }
-
-  its(:problems) {
-      should have_problem({
-        :kind       => :warning,
-        :message    => "define defined inside a class",
-        :linenumber => 3,
-        :column     => 9,
-      })
-      should_not have_problem :kind => :error
-    }
-  end
-
-  describe 'class inheriting from its namespace' do
-    let(:code) { "class foo::bar inherits foo { }" }
-
-    its(:problems) { should be_empty }
-  end
-
-  describe 'class inheriting from another namespace' do
-    let(:code) { "class foo::bar inherits baz { }" }
-
-    its(:problems) {
-      should have_problem({
-        :kind       => :warning,
-        :message    => "class inherits across namespaces",
-        :linenumber => 1,
-        :column     => 25,
-      })
-      should_not have_problem :kind => :error
-    }
-  end
-
-  describe 'parameterised class with a default value' do
-    let(:code) { "class foo($bar, $baz='gronk') { }" }
-
-    its(:problems) {
-      should only_have_problem({
-        :kind => :warning,
-        :message => 'parameterised class parameter without a default value',
-        :linenumber => 1,
-        :column     => 11,
-      })
-    }
-  end
-
-  describe 'parameterised class that inherits from a params class' do
-    let(:code) { "class foo($bar = $name) inherits foo::params { }" }
-
-    its(:problems) {
-      should have_problem({
-        :kind       => :warning,
-        :message    => "class inheriting from params class",
-        :linenumber => 1,
-        :column     => 34,
-      })
-      should_not have_problem :kind => :error
-    }
-  end
-
-  describe 'define with attrs in order' do
-    let(:code) { "define foo($bar, $baz='gronk') { }" }
-
-    its(:problems) { should be_empty }
-  end
-
-  describe 'define with parameter that calls a function' do
-    let(:code) { "define foo($bar=extlookup($name)) {}" }
-
-    its(:problems) { should == [] }
-  end
-
-  describe 'define with attrs out of order' do
-    let(:code) { "define foo($bar='baz', $gronk) { }" }
-
-    its(:problems) {
-      should have_problem({
-        :kind       => :warning,
-        :message    => "optional parameter listed before required parameter",
-        :linenumber => 1,
-        :column     => 24,
-      })
-      should_not have_problem :kind => :error
-    }
-  end
-
-  describe 'class with no variables declared accessing top scope' do
-    let(:code) { "
-      class foo {
-        $bar = $baz
-      }"
-    }
-
-    its(:problems) {
-      should have_problem({
-        :kind       => :warning,
-        :message    => "top-scope variable being used without an explicit namespace",
-        :linenumber => 3,
-        :column     => 16,
-      })
-      should_not have_problem :kind => :error
-    }
-  end
-
-  describe 'class with no variables declared accessing top scope explicitly' do
-    let(:code) { "
-      class foo {
-        $bar = $::baz
-      }"
-    }
-
-    its(:problems) { should be_empty }
-  end
-
-  describe 'class with variables declared accessing local scope' do
-    let(:code) { "
-      class foo {
-        $bar = 1
-        $baz = $bar
-      }"
-    }
-
-    its(:problems) { should be_empty }
-  end
-
-  describe 'class with parameters accessing local scope' do
-    let(:code) { "
-      class foo($bar='UNSET') {
-        $baz = $bar
-      }"
-    }
-
-    its(:problems) { should be_empty }
-  end
-
-  describe 'defined type with no variables declared accessing top scope' do
-    let(:code) { "
-      define foo() {
-        $bar = $fqdn
-      }"
-    }
-
-    its(:problems) {
-      should have_problem({
-        :kind       => :warning,
-        :message    => "top-scope variable being used without an explicit namespace",
-        :linenumber => 3,
-        :column     => 16,
-      })
-      should_not have_problem :kind => :error
-    }
-  end
-
-  describe 'defined type with no variables declared accessing top scope explicitly' do
-    let(:code) { "
-      define foo() {
-        $bar = $::fqdn
-      }"
-    }
-
-    its(:problems) { should be_empty }
-  end
-
-  describe '$name should be auto defined' do
-    let(:code) { "
-      define foo() {
-        $bar = $name
-        $baz = $title
-        $gronk = $module_name
-        $meep = $1
-      }"
-    }
-
-    its(:problems) { should be_empty }
-  end
-
-  describe 'instantiating a parametised class inside a class' do
-    let(:code) { "
-      class bar {
-        class { 'foo':
-          bar => 'foobar'
-        }
-      }"
-    }
-
-    its(:problems) { should be_empty }
-  end
-
-  describe 'instantiating a parametised class inside a define' do
-    let(:code) { "
-      define bar() {
-        class { 'foo':
-          bar => 'foobar'
-        }
-      }"
-    }
-
-    its(:problems) { should be_empty }
-  end
-
-  describe 'class/define parameter set to another variable' do
-    let(:code) { "
-      define foo($bar, $baz = $name, $gronk=$::fqdn) {
-      }"
-    }
-
-    its(:problems) { should be_empty }
-  end
-
-  describe 'class/define parameter set to another variable with incorrect order' do
-    let(:code) { "
-      define foo($baz = $name, $bar, $gronk=$::fqdn) {
-      }"
-    }
-
-    its(:problems) {
-      should have_problem({
-        :kind       => :warning,
-        :message    => "optional parameter listed before required parameter",
-        :linenumber => 2,
-        :column     => 32,
-      })
-      should_not have_problem :kind => :error
-    }
-  end
-
-  describe 'foo::bar in foo/manifests/bar.pp' do
-    let(:code) { "class foo::bar { }" }
-    let(:fullpath) { '/etc/puppet/modules/foo/manifests/bar.pp' }
-
-    its(:problems) { should be_empty }
-  end
-
-  describe 'foo::bar::baz in foo/manifests/bar/baz.pp' do
-    let(:code) { 'define foo::bar::baz() { }' }
-    let(:fullpath) { '/etc/puppet/modules/foo/manifests/bar/baz.pp' }
-
-    its(:problems) { should be_empty }
-  end
-
-  describe 'foo in foo/manifests/init.pp' do
-    let(:code) { 'class foo { }' }
-    let(:fullpath) { '/etc/puppet/modules/foo/manifests/init.pp' }
-
-    its(:problems) { should be_empty }
-  end
-
-  describe 'foo::bar in foo/manifests/init.pp' do
-    let(:code) { 'class foo::bar { }' }
-    let(:fullpath) { '/etc/puppet/modules/foo/manifests/init.pp' }
-
-    its(:problems) {
-      should only_have_problem({
-        :kind       => :error,
-        :message    => "foo::bar not in autoload module layout",
-        :linenumber => 1,
-        :column     => 7,
-      })
-    }
-  end
-
-  describe 'foo included in bar/manifests/init.pp' do
-    let(:code) { "
-      class bar {
-        class {'foo':
-          someparam => 'somevalue',
-        }
-      }
-      "
-    }
-    let(:fullpath) { '/etc/puppet/modules/bar/manifests/init.pp' }
-    its(:problems) { should be_empty }
-  end
-
-  describe 'issue-101' do
-    let(:code) { "
-      define b (
-        $foo,
-        $bar='',
-        $baz={}
-      ) { }
-    " }
-
-    its(:problems) { should == [] }
-  end
-
-  describe 'module named foo-bar' do
-    let(:code) { 'class foo-bar { }' }
-    let(:fullpath) { '/etc/puppet/modules/foo-bar/manifests/init.pp' }
-
-    its(:problems) do
-      should only_have_problem({
-        :kind       => :warning,
-        :message    => 'class name containing a dash',
-        :linenumber => 1,
-        :column     => 7,
-      })
-    end
-  end
-
-  describe 'define named foo-bar' do
-    let(:code) { 'define foo::foo-bar { }' }
-    let(:fullpath) { '/etc/puppet/modules/foo/manifests/foo-bar.pp' }
-
-    its(:problems) do
-      should only_have_problem({
-        :kind       => :warning,
-        :message    => 'defined type name containing a dash',
-        :linenumber => 1,
-        :column     => 8,
-      })
-    end
-  end
-
-  describe 'class named bar-foo' do
-    let(:code) { 'class foo::bar-foo { }' }
-    let(:fullpath) { '/etc/puppet/modules/foo/manifests/bar-foo.pp' }
-
-    its(:problems) do
-      should only_have_problem({
-        :kind       => :warning,
-        :message    => 'class name containing a dash',
-        :linenumber => 1,
-        :column     => 7,
-      })
-    end
-  end
-end

data/spec/puppet-lint/plugins/check_comments_spec.rb

@@ -1,40 +0,0 @@
-require 'spec_helper'
-
-describe PuppetLint::Plugins::CheckComments do
-  subject do
-    klass = described_class.new
-    fileinfo = {}
-    fileinfo[:fullpath] = defined?(fullpath).nil? ? '' : fullpath
-    klass.run(fileinfo, code)
-    klass
-  end
-
-  describe 'slash comments' do
-    let(:code) { "// foo" }
-
-    its(:problems) do
-      should only_have_problem({
-        :kind       => :warning,
-        :message    => '// comment found',
-        :linenumber => 1,
-        :column     => 1,
-      })
-    end
-  end
-
-  describe 'slash asterisk comment' do
-    let(:code) { "
-      /* foo
-      */
-    "}
-
-    its(:problems) do
-      should only_have_problem({
-        :kind       => :warning,
-        :message    => '/* */ comment found',
-        :linenumber => 2,
-        :column     => 7,
-      })
-    end
-  end
-end

data/spec/puppet-lint/plugins/check_resources_spec.rb

@@ -1,249 +0,0 @@
-require 'spec_helper'
-
-describe PuppetLint::Plugins::CheckResources do
-  subject do
-    klass = described_class.new
-    klass.run(defined?(fullpath).nil? ? {:fullpath => ''} : {:fullpath => fullpath}, code)
-    klass
-  end
-
-  describe '3 digit file mode' do
-    let(:code) { "file { 'foo': mode => '777' }" }
-
-    its(:problems) {
-      should only_have_problem :kind => :warning, :message => "mode should be represented as a 4 digit octal value or symbolic mode", :linenumber => 1
-    }
-  end
-
-  describe '4 digit file mode' do
-    let(:code) { "file { 'foo': mode => '0777' }" }
-
-    its(:problems) { should be_empty }
-  end
-
-  describe '4 digit unquoted file mode' do
-    let(:code) { "file { 'foo': mode => 0777 }" }
-
-    its(:problems) {
-      should only_have_problem :kind => :warning, :message => "unquoted file mode"
-    }
-  end
-
-  describe 'file mode as a variable' do
-    let(:code) { "file { 'foo': mode => $file_mode }" }
-
-    its(:problems) { should be_empty }
-  end
-
-  describe 'symbolic file mode' do
-    let(:code) { "file { 'foo': mode => 'u=rw,og=r' }" }
-
-    its(:problems) { should be_empty }
-  end
-
-  describe 'file mode undef unquoted' do
-    let(:code) { "file { 'foo': mode => undef }" }
-
-    its(:problems) { should be_empty }
-  end
-
-  describe 'file mode undef quoted' do
-    let(:code) { "file { 'foo': mode => 'undef' }" }
-
-    its(:problems) {
-      should only_have_problem :kind => :warning, :message => "mode should be represented as a 4 digit octal value or symbolic mode", :linenumber => 1
-    }
-  end
-
-  describe 'ensure as only attr in a single line resource' do
-    let(:code) { "file { 'foo': ensure => present }" }
-
-    its(:problems) { should be_empty }
-  end
-
-  describe 'ensure as only attr in a multi line resource' do
-    let(:code) { "
-      file { 'foo':
-        ensure => present,
-      }"
-    }
-
-    its(:problems) { should be_empty }
-  end
-
-  describe 'ensure as second attr in a multi line resource' do
-    let(:code) { "
-      file { 'foo':
-        mode   => '0000',
-        ensure => present,
-      }"
-    }
-
-    its(:problems) {
-      should only_have_problem :kind => :warning, :message => "ensure found on line but it's not the first attribute", :linenumber => 4
-    }
-  end
-
-  describe 'ensure as first attr in a multi line resource' do
-    let(:code) { "
-      file { 'foo':
-        ensure => present,
-        mode   => '0000',
-      }"
-    }
-
-    its(:problems) { should be_empty }
-  end
-
-  describe 'quoted resource title on single line resource' do
-    let(:code) { "file { 'foo': }" }
-
-    its(:problems) { should be_empty }
-  end
-
-  describe 'unquoted resource title on single line resource' do
-    let(:code) { "file { foo: }" }
-
-    its(:problems) {
-      should only_have_problem :kind => :warning, :message => "unquoted resource title", :linenumber => 1
-    }
-  end
-
-  describe 'quoted resource title on multi line resource' do
-    let(:code) { "
-      file { 'foo':
-      }"
-    }
-
-    its(:problems) { should be_empty }
-  end
-
-  describe 'unquoted resource title on multi line resource' do
-    let(:code) { "
-      file { foo:
-      }"
-    }
-
-    its(:problems) {
-      should only_have_problem :kind => :warning, :message => "unquoted resource title", :linenumber => 2
-    }
-  end
-
-  describe 'condensed resources with quoted titles' do
-    let(:code) { "
-      file {
-        'foo': ;
-        'bar': ;
-      }"
-    }
-
-    its(:problems) { should be_empty }
-  end
-
-  describe 'condensed resources with an unquoted title' do
-    let(:code) { "
-      file {
-        'foo': ;
-        bar: ;
-      }"
-    }
-
-    its(:problems) {
-      should only_have_problem :kind => :warning, :message => "unquoted resource title", :linenumber => 4
-    }
-  end
-
-  describe 'single line resource with an array of titles (all quoted)' do
-    let(:code) { "file { ['foo', 'bar']: }" }
-
-    its(:problems) { should be_empty }
-  end
-
-  describe 'resource inside a case statement' do
-    let(:code) { "
-      case $ensure {
-        'absent': {
-          file { \"some_file_${name}\":
-            ensure => absent,
-          }
-        }
-      }"
-    }
-
-    its(:problems) { should == [] }
-  end
-
-  describe 'file resource creating a symlink with seperate target attr' do
-    let(:code) { "
-      file { 'foo':
-        ensure => link,
-        target => '/foo/bar',
-      }"
-    }
-
-    its(:problems) { should be_empty }
-  end
-
-  describe 'file resource creating a symlink with target specified in ensure' do
-    let(:code) { "
-      file { 'foo':
-        ensure => '/foo/bar',
-      }"
-    }
-
-    its(:problems) {
-      should only_have_problem :kind => :warning, :message => "symlink target specified in ensure attr", :linenumber => 3
-    }
-  end
-
-  # This should really be a lexer test, but I haven't had time to write that
-  # test suite yet.
-  describe 'issue #116' do
-    let(:code) { "
-      $config_file_init = $::operatingsystem ? {
-        /(?i:Debian|Ubuntu|Mint)/ => '/etc/default/foo',
-        default                   => '/etc/sysconfig/foo',
-      }"
-    }
-
-    its(:problems) { should == [] }
-  end
-
-  describe 'resource with duplicate parameters' do
-    let(:code) { "
-      file { '/tmp/foo':
-        ensure => present,
-        foo => bar,
-        baz => gronk,
-        foo => meh,
-      }"
-    }
-
-    its(:problems) {
-      should only_have_problem({
-        :kind       => :error,
-        :message    => 'duplicate parameter found in resource',
-        :linenumber => 6,
-        :column     => 9,
-      })
-    }
-  end
-
-  describe 'case statement' do
-    let(:code) { %{
-      case $operatingsystem {
-        centos: {
-          $version = '1.2.3'
-        }
-        solaris: {
-          $version = '3.2.1'
-        }
-        default: {
-          fail("Module ${module_name} is not supported on ${operatingsystem}")
-        }
-      }}
-    }
-
-    its(:problems) { should == [] }
-  end
-end