puppet-lint 0.2.0 → 0.2.1

data/spec/puppet-lint/plugins/check_classes/names_containing_dash_spec.rb

@@ -0,0 +1,45 @@
+require 'spec_helper'
+
+describe 'names_containing_dash' do
+  describe 'module named foo-bar' do
+    let(:code) { 'class foo-bar { }' }
+    let(:fullpath) { '/etc/puppet/modules/foo-bar/manifests/init.pp' }
+
+    its(:problems) do
+      should only_have_problem({
+        :kind       => :warning,
+        :message    => 'class name containing a dash',
+        :linenumber => 1,
+        :column     => 7,
+      })
+    end
+  end
+
+  describe 'define named foo-bar' do
+    let(:code) { 'define foo::foo-bar { }' }
+    let(:fullpath) { '/etc/puppet/modules/foo/manifests/foo-bar.pp' }
+
+    its(:problems) do
+      should only_have_problem({
+        :kind       => :warning,
+        :message    => 'defined type name containing a dash',
+        :linenumber => 1,
+        :column     => 8,
+      })
+    end
+  end
+
+  describe 'class named bar-foo' do
+    let(:code) { 'class foo::bar-foo { }' }
+    let(:fullpath) { '/etc/puppet/modules/foo/manifests/bar-foo.pp' }
+
+    its(:problems) do
+      should only_have_problem({
+        :kind       => :warning,
+        :message    => 'class name containing a dash',
+        :linenumber => 1,
+        :column     => 7,
+      })
+    end
+  end
+end

data/spec/puppet-lint/plugins/check_classes/nested_classes_or_defines_spec.rb

@@ -0,0 +1,71 @@
+require 'spec_helper'
+
+describe 'nested_classes_or_defines' do
+  describe 'class on its own' do
+    let(:code) { "class foo { }" }
+
+    its(:problems) { should be_empty }
+  end
+
+  describe 'class inside a class' do
+    let(:code) { "
+      class foo {
+        class bar {
+        }
+      }"
+    }
+
+    its(:problems) {
+      should have_problem({
+        :kind       => :warning,
+        :message    => "class defined inside a class",
+        :linenumber => 3,
+        :column     => 9,
+      })
+      should_not have_problem :kind => :error
+    }
+  end
+
+  describe 'instantiating a parametised class inside a class' do
+    let(:code) { "
+      class bar {
+        class { 'foo':
+          bar => 'foobar'
+        }
+      }"
+    }
+
+    its(:problems) { should be_empty }
+  end
+
+  describe 'instantiating a parametised class inside a define' do
+    let(:code) { "
+      define bar() {
+        class { 'foo':
+          bar => 'foobar'
+        }
+      }"
+    }
+
+    its(:problems) { should be_empty }
+  end
+
+  describe 'define inside a class' do
+    let(:code) { "
+      class foo {
+        define bar() {
+        }
+      }"
+    }
+
+  its(:problems) {
+      should have_problem({
+        :kind       => :warning,
+        :message    => "define defined inside a class",
+        :linenumber => 3,
+        :column     => 9,
+      })
+      should_not have_problem :kind => :error
+    }
+  end
+end

data/spec/puppet-lint/plugins/check_classes/parameter_order_spec.rb

@@ -0,0 +1,67 @@
+require 'spec_helper'
+
+describe 'parameter_order' do
+  describe 'define with attrs in order' do
+    let(:code) { "define foo($bar, $baz='gronk') { }" }
+
+    its(:problems) { should be_empty }
+  end
+
+  describe 'define with parameter that calls a function' do
+    let(:code) { "define foo($bar=extlookup($name)) {}" }
+
+    its(:problems) { should == [] }
+  end
+
+  describe 'define with attrs out of order' do
+    let(:code) { "define foo($bar='baz', $gronk) { }" }
+
+    its(:problems) {
+      should have_problem({
+        :kind       => :warning,
+        :message    => "optional parameter listed before required parameter",
+        :linenumber => 1,
+        :column     => 24,
+      })
+      should_not have_problem :kind => :error
+    }
+  end
+
+  describe 'class/define parameter set to another variable' do
+    let(:code) { "
+      define foo($bar, $baz = $name, $gronk=$::fqdn) {
+      }"
+    }
+
+    its(:problems) { should be_empty }
+  end
+
+  describe 'class/define parameter set to another variable with incorrect order' do
+    let(:code) { "
+      define foo($baz = $name, $bar, $gronk=$::fqdn) {
+      }"
+    }
+
+    its(:problems) {
+      should have_problem({
+        :kind       => :warning,
+        :message    => "optional parameter listed before required parameter",
+        :linenumber => 2,
+        :column     => 32,
+      })
+      should_not have_problem :kind => :error
+    }
+  end
+
+  describe 'issue-101' do
+    let(:code) { "
+      define b (
+        $foo,
+        $bar='',
+        $baz={}
+      ) { }
+    " }
+
+    its(:problems) { should == [] }
+  end
+end

data/spec/puppet-lint/plugins/check_classes/parameterised_classes_spec.rb

@@ -0,0 +1,43 @@
+require 'spec_helper'
+
+describe 'parameterised_classes' do
+  describe 'parameterised class with a default value' do
+    let(:code) { "class foo($bar, $baz='gronk') { }" }
+
+    its(:problems) {
+      should only_have_problem({
+        :kind => :warning,
+        :message => 'parameterised class parameter without a default value',
+        :linenumber => 1,
+        :column     => 11,
+      })
+    }
+  end
+
+  describe 'parameterised class that inherits from a params class' do
+    let(:code) { "class foo($bar = $name) inherits foo::params { }" }
+
+    its(:problems) {
+      should have_problem({
+        :kind       => :warning,
+        :message    => "class inheriting from params class",
+        :linenumber => 1,
+        :column     => 34,
+      })
+      should_not have_problem :kind => :error
+    }
+  end
+
+  describe 'class without parameters' do
+    let(:code) {"
+      class myclass {
+
+        if ( $::lsbdistcodename == 'squeeze' ) {
+          #TODO
+        }
+      }
+    "}
+
+    its(:problems) { should == [] }
+  end
+end

data/spec/puppet-lint/plugins/check_classes/right_to_left_relationship_spec.rb

@@ -0,0 +1,23 @@
+require 'spec_helper'
+
+describe 'right_to_left_relationship' do
+  describe 'chain 2 resources left to right' do
+    let(:code) { "Class[foo] -> Class[bar]" }
+
+    its(:problems) { should be_empty }
+  end
+
+  describe 'chain 2 resources right to left' do
+    let(:code) { "Class[foo] <- Class[bar]" }
+
+    its(:problems) {
+      should have_problem({
+        :kind       => :warning,
+        :message    => "right-to-left (<-) relationship",
+        :linenumber => 1,
+        :column     => 12,
+      })
+      should_not have_problem :kind => :error
+    }
+  end
+end

data/spec/puppet-lint/plugins/check_classes/variable_scope_spec.rb

@@ -0,0 +1,93 @@
+require 'spec_helper'
+
+describe 'variable_scope' do
+  describe 'class with no variables declared accessing top scope' do
+    let(:code) { "
+      class foo {
+        $bar = $baz
+      }"
+    }
+
+    its(:problems) {
+      should have_problem({
+        :kind       => :warning,
+        :message    => "top-scope variable being used without an explicit namespace",
+        :linenumber => 3,
+        :column     => 16,
+      })
+      should_not have_problem :kind => :error
+    }
+  end
+
+  describe 'class with no variables declared accessing top scope explicitly' do
+    let(:code) { "
+      class foo {
+        $bar = $::baz
+      }"
+    }
+
+    its(:problems) { should be_empty }
+  end
+
+  describe 'class with variables declared accessing local scope' do
+    let(:code) { "
+      class foo {
+        $bar = 1
+        $baz = $bar
+      }"
+    }
+
+    its(:problems) { should be_empty }
+  end
+
+  describe 'class with parameters accessing local scope' do
+    let(:code) { "
+      class foo($bar='UNSET') {
+        $baz = $bar
+      }"
+    }
+
+    its(:problems) { should be_empty }
+  end
+
+  describe 'defined type with no variables declared accessing top scope' do
+    let(:code) { "
+      define foo() {
+        $bar = $fqdn
+      }"
+    }
+
+    its(:problems) {
+      should have_problem({
+        :kind       => :warning,
+        :message    => "top-scope variable being used without an explicit namespace",
+        :linenumber => 3,
+        :column     => 16,
+      })
+      should_not have_problem :kind => :error
+    }
+  end
+
+  describe 'defined type with no variables declared accessing top scope explicitly' do
+    let(:code) { "
+      define foo() {
+        $bar = $::fqdn
+      }"
+    }
+
+    its(:problems) { should be_empty }
+  end
+
+  describe '$name should be auto defined' do
+    let(:code) { "
+      define foo() {
+        $bar = $name
+        $baz = $title
+        $gronk = $module_name
+        $meep = $1
+      }"
+    }
+
+    its(:problems) { should be_empty }
+  end
+end

data/spec/puppet-lint/plugins/check_comments/slash_comments_spec.rb

@@ -0,0 +1,16 @@
+require 'spec_helper'
+
+describe 'slash_comments' do
+  describe 'slash comments' do
+    let(:code) { "// foo" }
+
+    its(:problems) do
+      should only_have_problem({
+        :kind       => :warning,
+        :message    => '// comment found',
+        :linenumber => 1,
+        :column     => 1,
+      })
+    end
+  end
+end

data/spec/puppet-lint/plugins/check_comments/star_comments_spec.rb

@@ -0,0 +1,19 @@
+require 'spec_helper'
+
+describe 'star_comments' do
+  describe 'slash asterisk comment' do
+    let(:code) { "
+      /* foo
+      */
+    "}
+
+    its(:problems) do
+      should only_have_problem({
+        :kind       => :warning,
+        :message    => '/* */ comment found',
+        :linenumber => 2,
+        :column     => 7,
+      })
+    end
+  end
+end

data/spec/puppet-lint/plugins/{check_conditionals_spec.rb → check_conditionals/case_without_default_spec.rb}

@@ -1,44 +1,6 @@
 require 'spec_helper'
 
-describe PuppetLint::Plugins::CheckConditionals do
-  subject do
-    klass = described_class.new
-    fileinfo = {}
-    fileinfo[:fullpath] = defined?(fullpath).nil? ? '' : fullpath
-    klass.run(fileinfo, code)
-    klass
-  end
-
-  describe 'resource with a selector' do
-    let(:code) { "
-      file { 'foo':
-        ensure => $bar ? {
-          true    => present,
-          default => absent,
-        },
-      }"
-    }
-
-    its(:problems) do
-      should only_have_problem({
-        :kind       => :warning,
-        :message    => 'selector inside resource block',
-        :linenumber => 3,
-        :column     => 16,
-      })
-    end
-  end
-
-  describe 'resource with a variable as a attr value' do
-    let(:code) { "
-      file { 'foo',
-        ensure => $bar,
-      }"
-    }
-
-    its(:problems) { should be_empty }
-  end
-
+describe 'case_without_default' do
   describe 'case statement with a default case' do
     let(:code) { "
       case $foo {

data/spec/puppet-lint/plugins/check_conditionals/selector_inside_resource_spec.rb

@@ -0,0 +1,33 @@
+require 'spec_helper'
+
+describe 'selector_inside_resource' do
+  describe 'resource with a selector' do
+    let(:code) { "
+      file { 'foo':
+        ensure => $bar ? {
+          true    => present,
+          default => absent,
+        },
+      }"
+    }
+
+    its(:problems) do
+      should only_have_problem({
+        :kind       => :warning,
+        :message    => 'selector inside resource block',
+        :linenumber => 3,
+        :column     => 16,
+      })
+    end
+  end
+
+  describe 'resource with a variable as a attr value' do
+    let(:code) { "
+      file { 'foo',
+        ensure => $bar,
+      }"
+    }
+
+    its(:problems) { should be_empty }
+  end
+end