puppet-lint 0.2.0 → 0.2.1

data/spec/puppet-lint/plugins/check_strings/variables_not_enclosed_spec.rb

@@ -0,0 +1,29 @@
+require 'spec_helper'
+
+describe 'variables_not_enclosed' do
+  describe 'variable not enclosed in {}' do
+    let(:code) { '" $gronk"' }
+
+    its(:problems) {
+      should only_have_problem({
+        :kind       => :warning,
+        :message    => 'variable not enclosed in {}',
+        :linenumber => 1,
+        :column     => 3,
+      })
+    }
+  end
+
+  describe 'variable not enclosed in {} after many tokens' do
+    let(:code) { ("'groovy'\n" * 20) + '" $gronk"' }
+
+    its(:problems) {
+      should only_have_problem({
+        :kind       => :warning,
+        :message    => 'variable not enclosed in {}',
+        :linenumber => 21,
+        :column     => 3,
+      })
+    }
+  end
+end

data/spec/puppet-lint/plugins/{check_variables_spec.rb → check_variables/variable_contains_dash_spec.rb}

@@ -1,14 +1,6 @@
 require 'spec_helper'
 
-describe PuppetLint::Plugins::CheckVariables do
-  subject do
-    klass = described_class.new
-    fileinfo = {}
-    fileinfo[:fullpath] = defined?(fullpath).nil? ? '' : fullpath
-    klass.run(fileinfo, code)
-    klass
-  end
-
+describe 'variable_contains_dash' do
   describe 'a variable containing a dash' do
     let(:code) { '$foo-bar' }
 

data/spec/puppet-lint/plugins/check_whitespace/2sp_soft_tabs_spec.rb

@@ -0,0 +1,20 @@
+require 'spec_helper'
+
+describe '2sp_soft_tabs' do
+  describe 'line indented by 3 spaces' do
+    let(:code) { "
+      file { 'foo':
+         foo => bar,
+      }"
+    }
+
+    its(:problems) {
+      should have_problem({
+        :kind       => :error,
+        :message    => 'two-space soft tabs not used',
+        :linenumber => 3,
+        :column     => 1,
+      })
+    }
+  end
+end

data/spec/puppet-lint/plugins/check_whitespace/80chars_spec.rb

@@ -0,0 +1,38 @@
+# encoding: utf-8
+require 'spec_helper'
+
+describe '80chars' do
+  describe 'file resource with a source line > 80c' do
+    let(:code) { "
+      file {
+        source  => 'puppet:///modules/certificates/etc/ssl/private/wildcard.example.com.crt',
+      }"
+    }
+
+    its(:problems) { should be_empty }
+  end
+
+  describe 'length of lines with UTF-8 characters' do
+    let(:code) { "
+      # ┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┓
+      # ┃          Configuration           ┃
+      # ┗━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┛"
+    }
+    its(:problems) {
+      should be_empty
+    }
+  end
+
+  describe '81 character line' do
+    let(:code) { 'a' * 81 }
+
+    its(:problems) {
+      should have_problem({
+        :kind       => :warning,
+        :message    => 'line has more than 80 characters',
+        :linenumber => 1,
+        :column     => 80,
+      })
+    }
+  end
+end

data/spec/puppet-lint/plugins/{check_whitespace_spec.rb → check_whitespace/arrow_alignment_spec.rb}

@@ -1,13 +1,6 @@
-# encoding: utf-8
 require 'spec_helper'
 
-describe PuppetLint::Plugins::CheckWhitespace do
-  subject do
-    klass = described_class.new
-    klass.run(defined?(fullpath).nil? ? {:fullpath => ''} : {:fullpath => fullpath}, code)
-    klass
-  end
-
+describe 'arrow_alignment' do
   describe 'selectors inside a resource' do
     let(:code) { "
       file { 'foo':
@@ -37,16 +30,6 @@ describe PuppetLint::Plugins::CheckWhitespace do
     its(:problems) { should be_empty }
   end
 
-  describe 'file resource with a source line > 80c' do
-    let(:code) { "
-      file {
-        source  => 'puppet:///modules/certificates/etc/ssl/private/wildcard.example.com.crt',
-      }"
-    }
-
-    its(:problems) { should be_empty }
-  end
-
   describe 'selector inside a resource' do
     let(:code) { "
     ensure => $ensure ? {
@@ -76,18 +59,6 @@ describe PuppetLint::Plugins::CheckWhitespace do
     its(:problems) { should be_empty }
   end
 
-
-  describe 'length of lines with UTF-8 characters' do
-    let(:code) { "
-      # ┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┓
-      # ┃          Configuration           ┃
-      # ┗━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┛"
-    }
-    its(:problems) {
-      should be_empty
-    }
-  end
-
   describe 'issue #37' do
     let(:code) { "
       class { 'lvs::base':
@@ -223,62 +194,6 @@ describe PuppetLint::Plugins::CheckWhitespace do
     its(:problems) { should be_empty }
   end
 
-  describe 'hard tabs indents' do
-    let(:code) { "\tfoo => bar," }
-
-    its(:problems) {
-      should have_problem({
-        :kind       => :error,
-        :message    => 'tab character found',
-        :linenumber => 1,
-        :column     => 1,
-      })
-    }
-  end
-
-  describe 'line with trailing whitespace' do
-    let(:code) { "foo " }
-
-    its(:problems) {
-      should have_problem({
-        :kind       => :error,
-        :message    => 'trailing whitespace found',
-        :linenumber => 1,
-        :column     => 4,
-      })
-    }
-  end
-
-  describe '81 character line' do
-    let(:code) { 'a' * 81 }
-
-    its(:problems) {
-      should have_problem({
-        :kind       => :warning,
-        :message    => 'line has more than 80 characters',
-        :linenumber => 1,
-        :column     => 80,
-      })
-    }
-  end
-
-  describe 'line indented by 3 spaces' do
-    let(:code) { "
-      file { 'foo':
-         foo => bar,
-      }"
-    }
-
-    its(:problems) {
-      should have_problem({
-        :kind       => :error,
-        :message    => 'two-space soft tabs not used',
-        :linenumber => 3,
-        :column     => 1,
-      })
-    }
-  end
-
   describe 'single line resource spread out on multiple lines' do
     let(:code) {"
       file {

data/spec/puppet-lint/plugins/check_whitespace/hard_tabs_spec.rb

@@ -0,0 +1,16 @@
+require 'spec_helper'
+
+describe 'hard_tabs' do
+  describe 'hard tabs indents' do
+    let(:code) { "\tfoo => bar," }
+
+    its(:problems) {
+      should have_problem({
+        :kind       => :error,
+        :message    => 'tab character found',
+        :linenumber => 1,
+        :column     => 1,
+      })
+    }
+  end
+end

data/spec/puppet-lint/plugins/check_whitespace/trailing_whitespace_spec.rb

@@ -0,0 +1,16 @@
+require 'spec_helper'
+
+describe 'trailing_whitespace' do
+  describe 'line with trailing whitespace' do
+    let(:code) { "foo " }
+
+    its(:problems) {
+      should have_problem({
+        :kind       => :error,
+        :message    => 'trailing whitespace found',
+        :linenumber => 1,
+        :column     => 4,
+      })
+    }
+  end
+end

data/spec/spec_helper.rb

@@ -1,8 +1,24 @@
 require 'rspec/autorun'
 require 'puppet-lint'
 
+module RSpec
+  module LintExampleGroup
+    def subject
+      klass = PuppetLint::Checks.new
+      fileinfo = {}
+      fileinfo[:fullpath] = self.respond_to?(:fullpath) ? fullpath : ''
+      klass.load_data(fileinfo, code)
+      klass.send("lint_check_#{self.class.top_level_description}")
+      klass
+    end
+  end
+end
+
 RSpec.configure do |c|
   c.mock_framework = :rspec
+  c.include RSpec::LintExampleGroup, :type => :lint, :example_group => {
+    :file_path => Regexp.compile(%w{spec puppet-lint plugins}.join('[\\\/]'))
+  }
 end
 
 #class PuppetLint::Warning < Exception; end
@@ -117,3 +133,4 @@ RSpec::Matchers.define :only_have_problem do |filter|
   end
 
 end
+

metadata

@@ -1,76 +1,72 @@
---- !ruby/object:Gem::Specification 
+--- !ruby/object:Gem::Specification
 name: puppet-lint
-version: !ruby/object:Gem::Version 
-  hash: 23
+version: !ruby/object:Gem::Version
+  version: 0.2.1
   prerelease: 
-  segments: 
-  - 0
-  - 2
-  - 0
-  version: 0.2.0
 platform: ruby
-authors: 
+authors:
 - Tim Sharpe
 autorequire: 
 bindir: bin
 cert_chain: []
-
-date: 2012-08-23 00:00:00 -07:00
-default_executable: 
-dependencies: 
-- !ruby/object:Gem::Dependency 
+date: 2012-08-27 00:00:00.000000000 Z
+dependencies:
+- !ruby/object:Gem::Dependency
   name: rspec
-  prerelease: false
-  requirement: &id001 !ruby/object:Gem::Requirement 
+  requirement: !ruby/object:Gem::Requirement
     none: false
-    requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
-        hash: 3
-        segments: 
-        - 0
-        version: "0"
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
   type: :development
-  version_requirements: *id001
-- !ruby/object:Gem::Dependency 
-  name: rdoc
   prerelease: false
-  requirement: &id002 !ruby/object:Gem::Requirement 
+  version_requirements: !ruby/object:Gem::Requirement
     none: false
-    requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
-        hash: 3
-        segments: 
-        - 0
-        version: "0"
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: rdoc
+  requirement: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
   type: :development
-  version_requirements: *id002
-- !ruby/object:Gem::Dependency 
-  name: rcov
   prerelease: false
-  requirement: &id003 !ruby/object:Gem::Requirement 
+  version_requirements: !ruby/object:Gem::Requirement
     none: false
-    requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
-        hash: 3
-        segments: 
-        - 0
-        version: "0"
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: rcov
+  requirement: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
   type: :development
-  version_requirements: *id003
-description: |-
-  Checks your Puppet manifests against the Puppetlabs
-    style guide and alerts you to any discrepancies.
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+description: ! "Checks your Puppet manifests against the Puppetlabs\n  style guide
+  and alerts you to any discrepancies."
 email: tim@sharpe.id.au
-executables: 
+executables:
 - puppet-lint
 extensions: []
-
 extra_rdoc_files: []
-
-files: 
+files:
 - .gitignore
 - .travis.yml
 - Gemfile
@@ -103,51 +99,63 @@ files:
 - spec/puppet-lint/configuration_spec.rb
 - spec/puppet-lint/lexer/token_spec.rb
 - spec/puppet-lint/lexer_spec.rb
-- spec/puppet-lint/plugins/check_classes_spec.rb
-- spec/puppet-lint/plugins/check_comments_spec.rb
-- spec/puppet-lint/plugins/check_conditionals_spec.rb
-- spec/puppet-lint/plugins/check_documentation_spec.rb
-- spec/puppet-lint/plugins/check_resources_spec.rb
-- spec/puppet-lint/plugins/check_strings_spec.rb
-- spec/puppet-lint/plugins/check_variables_spec.rb
-- spec/puppet-lint/plugins/check_whitespace_spec.rb
+- spec/puppet-lint/plugins/check_classes/autoloader_layout_spec.rb
+- spec/puppet-lint/plugins/check_classes/inherits_across_namespaces_spec.rb
+- spec/puppet-lint/plugins/check_classes/names_containing_dash_spec.rb
+- spec/puppet-lint/plugins/check_classes/nested_classes_or_defines_spec.rb
+- spec/puppet-lint/plugins/check_classes/parameter_order_spec.rb
+- spec/puppet-lint/plugins/check_classes/parameterised_classes_spec.rb
+- spec/puppet-lint/plugins/check_classes/right_to_left_relationship_spec.rb
+- spec/puppet-lint/plugins/check_classes/variable_scope_spec.rb
+- spec/puppet-lint/plugins/check_comments/slash_comments_spec.rb
+- spec/puppet-lint/plugins/check_comments/star_comments_spec.rb
+- spec/puppet-lint/plugins/check_conditionals/case_without_default_spec.rb
+- spec/puppet-lint/plugins/check_conditionals/selector_inside_resource_spec.rb
+- spec/puppet-lint/plugins/check_documentation/documentation_spec.rb
+- spec/puppet-lint/plugins/check_resources/duplicate_params_spec.rb
+- spec/puppet-lint/plugins/check_resources/ensure_first_param_spec.rb
+- spec/puppet-lint/plugins/check_resources/ensure_not_symlink_target_spec.rb
+- spec/puppet-lint/plugins/check_resources/file_mode_spec.rb
+- spec/puppet-lint/plugins/check_resources/unquoted_file_mode_spec.rb
+- spec/puppet-lint/plugins/check_resources/unquoted_resource_title_spec.rb
+- spec/puppet-lint/plugins/check_strings/double_quoted_strings_spec.rb
+- spec/puppet-lint/plugins/check_strings/only_variable_string_spec.rb
+- spec/puppet-lint/plugins/check_strings/quoted_booleans_spec.rb
+- spec/puppet-lint/plugins/check_strings/single_quote_string_with_variables_spec.rb
+- spec/puppet-lint/plugins/check_strings/variables_not_enclosed_spec.rb
+- spec/puppet-lint/plugins/check_variables/variable_contains_dash_spec.rb
+- spec/puppet-lint/plugins/check_whitespace/2sp_soft_tabs_spec.rb
+- spec/puppet-lint/plugins/check_whitespace/80chars_spec.rb
+- spec/puppet-lint/plugins/check_whitespace/arrow_alignment_spec.rb
+- spec/puppet-lint/plugins/check_whitespace/hard_tabs_spec.rb
+- spec/puppet-lint/plugins/check_whitespace/trailing_whitespace_spec.rb
 - spec/puppet-lint_spec.rb
 - spec/spec_helper.rb
-has_rdoc: true
 homepage: https://github.com/rodjek/puppet-lint/
 licenses: []
-
 post_install_message: 
 rdoc_options: []
-
-require_paths: 
+require_paths:
 - lib
-required_ruby_version: !ruby/object:Gem::Requirement 
+required_ruby_version: !ruby/object:Gem::Requirement
   none: false
-  requirements: 
-  - - ">="
-    - !ruby/object:Gem::Version 
-      hash: 3
-      segments: 
-      - 0
-      version: "0"
-required_rubygems_version: !ruby/object:Gem::Requirement 
+  requirements:
+  - - ! '>='
+    - !ruby/object:Gem::Version
+      version: '0'
+required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
-  requirements: 
-  - - ">="
-    - !ruby/object:Gem::Version 
-      hash: 3
-      segments: 
-      - 0
-      version: "0"
+  requirements:
+  - - ! '>='
+    - !ruby/object:Gem::Version
+      version: '0'
 requirements: []
-
 rubyforge_project: 
-rubygems_version: 1.6.2
+rubygems_version: 1.8.23
 signing_key: 
 specification_version: 3
 summary: Ensure your Puppet manifests conform with the Puppetlabs style guide
-test_files: 
+test_files:
 - spec/fixtures/test/manifests/fail.pp
 - spec/fixtures/test/manifests/init.pp
 - spec/fixtures/test/manifests/warning.pp
@@ -155,13 +163,35 @@ test_files:
 - spec/puppet-lint/configuration_spec.rb
 - spec/puppet-lint/lexer/token_spec.rb
 - spec/puppet-lint/lexer_spec.rb
-- spec/puppet-lint/plugins/check_classes_spec.rb
-- spec/puppet-lint/plugins/check_comments_spec.rb
-- spec/puppet-lint/plugins/check_conditionals_spec.rb
-- spec/puppet-lint/plugins/check_documentation_spec.rb
-- spec/puppet-lint/plugins/check_resources_spec.rb
-- spec/puppet-lint/plugins/check_strings_spec.rb
-- spec/puppet-lint/plugins/check_variables_spec.rb
-- spec/puppet-lint/plugins/check_whitespace_spec.rb
+- spec/puppet-lint/plugins/check_classes/autoloader_layout_spec.rb
+- spec/puppet-lint/plugins/check_classes/inherits_across_namespaces_spec.rb
+- spec/puppet-lint/plugins/check_classes/names_containing_dash_spec.rb
+- spec/puppet-lint/plugins/check_classes/nested_classes_or_defines_spec.rb
+- spec/puppet-lint/plugins/check_classes/parameter_order_spec.rb
+- spec/puppet-lint/plugins/check_classes/parameterised_classes_spec.rb
+- spec/puppet-lint/plugins/check_classes/right_to_left_relationship_spec.rb
+- spec/puppet-lint/plugins/check_classes/variable_scope_spec.rb
+- spec/puppet-lint/plugins/check_comments/slash_comments_spec.rb
+- spec/puppet-lint/plugins/check_comments/star_comments_spec.rb
+- spec/puppet-lint/plugins/check_conditionals/case_without_default_spec.rb
+- spec/puppet-lint/plugins/check_conditionals/selector_inside_resource_spec.rb
+- spec/puppet-lint/plugins/check_documentation/documentation_spec.rb
+- spec/puppet-lint/plugins/check_resources/duplicate_params_spec.rb
+- spec/puppet-lint/plugins/check_resources/ensure_first_param_spec.rb
+- spec/puppet-lint/plugins/check_resources/ensure_not_symlink_target_spec.rb
+- spec/puppet-lint/plugins/check_resources/file_mode_spec.rb
+- spec/puppet-lint/plugins/check_resources/unquoted_file_mode_spec.rb
+- spec/puppet-lint/plugins/check_resources/unquoted_resource_title_spec.rb
+- spec/puppet-lint/plugins/check_strings/double_quoted_strings_spec.rb
+- spec/puppet-lint/plugins/check_strings/only_variable_string_spec.rb
+- spec/puppet-lint/plugins/check_strings/quoted_booleans_spec.rb
+- spec/puppet-lint/plugins/check_strings/single_quote_string_with_variables_spec.rb
+- spec/puppet-lint/plugins/check_strings/variables_not_enclosed_spec.rb
+- spec/puppet-lint/plugins/check_variables/variable_contains_dash_spec.rb
+- spec/puppet-lint/plugins/check_whitespace/2sp_soft_tabs_spec.rb
+- spec/puppet-lint/plugins/check_whitespace/80chars_spec.rb
+- spec/puppet-lint/plugins/check_whitespace/arrow_alignment_spec.rb
+- spec/puppet-lint/plugins/check_whitespace/hard_tabs_spec.rb
+- spec/puppet-lint/plugins/check_whitespace/trailing_whitespace_spec.rb
 - spec/puppet-lint_spec.rb
 - spec/spec_helper.rb