puppet-lint 0.2.0 → 0.2.1

data/spec/puppet-lint/plugins/{check_documentation_spec.rb → check_documentation/documentation_spec.rb}

@@ -1,14 +1,6 @@
 require 'spec_helper'
 
-describe PuppetLint::Plugins::CheckDocumentation do
-  subject do
-    klass = described_class.new
-    fileinfo = {}
-    fileinfo[:fullpath] = defined?(fullpath).nil? ? '' : fullpath
-    klass.run(fileinfo, code)
-    klass
-  end
-
+describe 'documentation' do
   describe 'undocumented class' do
     let(:code) { "class test {}" }
 

data/spec/puppet-lint/plugins/check_resources/duplicate_params_spec.rb

@@ -0,0 +1,23 @@
+require 'spec_helper'
+
+describe 'duplicate_params' do
+  describe 'resource with duplicate parameters' do
+    let(:code) { "
+      file { '/tmp/foo':
+        ensure => present,
+        foo => bar,
+        baz => gronk,
+        foo => meh,
+      }"
+    }
+
+    its(:problems) {
+      should only_have_problem({
+        :kind       => :error,
+        :message    => 'duplicate parameter found in resource',
+        :linenumber => 6,
+        :column     => 9,
+      })
+    }
+  end
+end

data/spec/puppet-lint/plugins/check_resources/ensure_first_param_spec.rb

@@ -0,0 +1,43 @@
+require 'spec_helper'
+
+describe 'ensure_first_param' do
+  describe 'ensure as only attr in a single line resource' do
+    let(:code) { "file { 'foo': ensure => present }" }
+
+    its(:problems) { should be_empty }
+  end
+
+  describe 'ensure as only attr in a multi line resource' do
+    let(:code) { "
+      file { 'foo':
+        ensure => present,
+      }"
+    }
+
+    its(:problems) { should be_empty }
+  end
+
+  describe 'ensure as second attr in a multi line resource' do
+    let(:code) { "
+      file { 'foo':
+        mode   => '0000',
+        ensure => present,
+      }"
+    }
+
+    its(:problems) {
+      should only_have_problem :kind => :warning, :message => "ensure found on line but it's not the first attribute", :linenumber => 4
+    }
+  end
+
+  describe 'ensure as first attr in a multi line resource' do
+    let(:code) { "
+      file { 'foo':
+        ensure => present,
+        mode   => '0000',
+      }"
+    }
+
+    its(:problems) { should be_empty }
+  end
+end

data/spec/puppet-lint/plugins/check_resources/ensure_not_symlink_target_spec.rb

@@ -0,0 +1,26 @@
+require 'spec_helper'
+
+describe 'ensure_not_symlink_target' do
+  describe 'file resource creating a symlink with seperate target attr' do
+    let(:code) { "
+      file { 'foo':
+        ensure => link,
+        target => '/foo/bar',
+      }"
+    }
+
+    its(:problems) { should be_empty }
+  end
+
+  describe 'file resource creating a symlink with target specified in ensure' do
+    let(:code) { "
+      file { 'foo':
+        ensure => '/foo/bar',
+      }"
+    }
+
+    its(:problems) {
+      should only_have_problem :kind => :warning, :message => "symlink target specified in ensure attr", :linenumber => 3
+    }
+  end
+end

data/spec/puppet-lint/plugins/check_resources/file_mode_spec.rb

@@ -0,0 +1,43 @@
+require 'spec_helper'
+
+describe 'file_mode' do
+  describe '3 digit file mode' do
+    let(:code) { "file { 'foo': mode => '777' }" }
+
+    its(:problems) {
+      should only_have_problem :kind => :warning, :message => "mode should be represented as a 4 digit octal value or symbolic mode", :linenumber => 1
+    }
+  end
+
+  describe '4 digit file mode' do
+    let(:code) { "file { 'foo': mode => '0777' }" }
+
+    its(:problems) { should be_empty }
+  end
+
+  describe 'file mode as a variable' do
+    let(:code) { "file { 'foo': mode => $file_mode }" }
+
+    its(:problems) { should be_empty }
+  end
+
+  describe 'symbolic file mode' do
+    let(:code) { "file { 'foo': mode => 'u=rw,og=r' }" }
+
+    its(:problems) { should be_empty }
+  end
+
+  describe 'file mode undef unquoted' do
+    let(:code) { "file { 'foo': mode => undef }" }
+
+    its(:problems) { should be_empty }
+  end
+
+  describe 'file mode undef quoted' do
+    let(:code) { "file { 'foo': mode => 'undef' }" }
+
+    its(:problems) {
+      should only_have_problem :kind => :warning, :message => "mode should be represented as a 4 digit octal value or symbolic mode", :linenumber => 1
+    }
+  end
+end

data/spec/puppet-lint/plugins/check_resources/unquoted_file_mode_spec.rb

@@ -0,0 +1,11 @@
+require 'spec_helper'
+
+describe 'unquoted_file_mode' do
+  describe '4 digit unquoted file mode' do
+    let(:code) { "file { 'foo': mode => 0777 }" }
+
+    its(:problems) {
+      should only_have_problem :kind => :warning, :message => "unquoted file mode"
+    }
+  end
+end

data/spec/puppet-lint/plugins/check_resources/unquoted_resource_title_spec.rb

@@ -0,0 +1,110 @@
+require 'spec_helper'
+
+describe 'unquoted_resource_title' do
+  describe 'quoted resource title on single line resource' do
+    let(:code) { "file { 'foo': }" }
+
+    its(:problems) { should be_empty }
+  end
+
+  describe 'unquoted resource title on single line resource' do
+    let(:code) { "file { foo: }" }
+
+    its(:problems) {
+      should only_have_problem :kind => :warning, :message => "unquoted resource title", :linenumber => 1
+    }
+  end
+
+  describe 'quoted resource title on multi line resource' do
+    let(:code) { "
+      file { 'foo':
+      }"
+    }
+
+    its(:problems) { should be_empty }
+  end
+
+  describe 'unquoted resource title on multi line resource' do
+    let(:code) { "
+      file { foo:
+      }"
+    }
+
+    its(:problems) {
+      should only_have_problem :kind => :warning, :message => "unquoted resource title", :linenumber => 2
+    }
+  end
+
+  describe 'condensed resources with quoted titles' do
+    let(:code) { "
+      file {
+        'foo': ;
+        'bar': ;
+      }"
+    }
+
+    its(:problems) { should be_empty }
+  end
+
+  describe 'condensed resources with an unquoted title' do
+    let(:code) { "
+      file {
+        'foo': ;
+        bar: ;
+      }"
+    }
+
+    its(:problems) {
+      should only_have_problem :kind => :warning, :message => "unquoted resource title", :linenumber => 4
+    }
+  end
+
+  describe 'single line resource with an array of titles (all quoted)' do
+    let(:code) { "file { ['foo', 'bar']: }" }
+
+    its(:problems) { should be_empty }
+  end
+
+  describe 'resource inside a case statement' do
+    let(:code) { "
+      case $ensure {
+        'absent': {
+          file { \"some_file_${name}\":
+            ensure => absent,
+          }
+        }
+      }"
+    }
+
+    its(:problems) { should == [] }
+  end
+
+  describe 'issue #116' do
+    let(:code) { "
+      $config_file_init = $::operatingsystem ? {
+        /(?i:Debian|Ubuntu|Mint)/ => '/etc/default/foo',
+        default                   => '/etc/sysconfig/foo',
+      }"
+    }
+
+    its(:problems) { should == [] }
+  end
+
+  describe 'case statement' do
+    let(:code) { %{
+      case $operatingsystem {
+        centos: {
+          $version = '1.2.3'
+        }
+        solaris: {
+          $version = '3.2.1'
+        }
+        default: {
+          fail("Module ${module_name} is not supported on ${operatingsystem}")
+        }
+      }}
+    }
+
+    its(:problems) { should == [] }
+  end
+end

data/spec/puppet-lint/plugins/check_strings/double_quoted_strings_spec.rb

@@ -0,0 +1,83 @@
+require 'spec_helper'
+
+describe 'double_quoted_strings' do
+  describe 'double quoted string containing a variable inside single quotes' do
+    let(:code) { "exec { \"/usr/bin/wget -O - '${source}' | /usr/bin/apt-key add -\": }" }
+
+    its(:problems) { should be_empty }
+  end
+
+  describe 'multiple strings in a line' do
+    let(:code) { "\"aoeu\" '${foo}'" }
+
+    its(:problems) {
+      should have_problem({
+        :kind       => :warning,
+        :message    => 'double quoted string containing no variables',
+        :linenumber => 1,
+        :column     => 1,
+      })
+    }
+  end
+
+  describe 'double quoted string nested in a single quoted string' do
+    let(:code) { "'grep \"status=sent\" /var/log/mail.log'" }
+
+    its(:problems) { should be_empty }
+  end
+
+  describe 'double quoted string after a comment' do
+    let(:code) { "service { 'foo': } # \"bar\"" }
+
+    its(:problems) { should be_empty }
+  end
+
+  describe 'double quoted string containing newline but no variables' do
+    let(:code) { %{"foo\n"} }
+
+    its(:problems) { should be_empty }
+  end
+
+  describe 'double quoted string with backslash for continuation' do
+    let(:code) { %{
+      class puppet::master::maintenance (
+      ) {
+        cron { 'puppet_master_reports_cleanup':
+          command     => "/usr/bin/find /var/lib/puppet/reports -type f -mtime +15 \
+                         -delete && /usr/bin/find /var/lib/puppet/reports -mindepth 1 \
+                         -empty -type d -delete",
+          minute      => '15',
+          hour        => '5',
+        }
+      }
+    } }
+
+    its(:problems) { should == [] }
+  end
+
+  describe 'double quoted true' do
+    let(:code) { "class { 'foo': boolFlag => \"true\" }" }
+
+    its(:problems) {
+      should have_problem({
+        :kind       => :warning,
+        :message    => 'double quoted string containing no variables',
+        :linenumber => 1,
+        :column     => 28,
+      })
+    }
+  end
+
+  describe 'double quoted false' do
+    let(:code) { "class { 'foo': boolFlag => \"false\" }" }
+
+    its(:problems) {
+      should have_problem({
+        :kind       => :warning,
+        :message    => 'double quoted string containing no variables',
+        :linenumber => 1,
+        :column     => 28,
+      })
+    }
+  end
+end

data/spec/puppet-lint/plugins/check_strings/only_variable_string_spec.rb

@@ -0,0 +1,16 @@
+require 'spec_helper'
+
+describe 'only_variable_string' do
+  describe 'string containing only a variable' do
+    let(:code) { '"${foo}"' }
+
+    its(:problems) {
+      should only_have_problem({
+        :kind       => :warning,
+        :message    => 'string containing only a variable',
+        :linenumber => 1,
+        :column     => 3,
+      })
+    }
+  end
+end

data/spec/puppet-lint/plugins/check_strings/quoted_booleans_spec.rb

@@ -0,0 +1,55 @@
+require 'spec_helper'
+
+describe 'quoted_booleans' do
+  describe 'quoted false' do
+    let(:code) { "class { 'foo': boolFlag => 'false' }" }
+
+    its(:problems) {
+      should only_have_problem({
+        :kind       => :warning,
+        :message    => 'quoted boolean value found',
+        :linenumber => 1,
+        :column     => 28,
+      })
+    }
+  end
+
+  describe 'quoted true' do
+    let(:code) { "class { 'foo': boolFlag => 'true' }" }
+
+    its(:problems) {
+      should only_have_problem({
+        :kind       => :warning,
+        :message    => 'quoted boolean value found',
+        :linenumber => 1,
+        :column     => 28,
+      })
+    }
+  end
+
+  describe 'double quoted true' do
+    let(:code) { "class { 'foo': boolFlag => \"true\" }" }
+
+    its(:problems) {
+      should have_problem({
+        :kind       => :warning,
+        :message    => 'quoted boolean value found',
+        :linenumber => 1,
+        :column     => 28,
+      })
+    }
+  end
+
+  describe 'double quoted false' do
+    let(:code) { "class { 'foo': boolFlag => \"false\" }" }
+
+    its(:problems) {
+      should have_problem({
+        :kind       => :warning,
+        :message    => 'quoted boolean value found',
+        :linenumber => 1,
+        :column     => 28,
+      })
+    }
+  end
+end

data/spec/puppet-lint/plugins/check_strings/single_quote_string_with_variables_spec.rb

@@ -0,0 +1,16 @@
+require 'spec_helper'
+
+describe 'single_quote_string_with_variables' do
+  describe 'multiple strings in a line' do
+    let(:code) { "\"aoeu\" '${foo}'" }
+
+    its(:problems) {
+      should have_problem({
+        :kind       => :error,
+        :message    => 'single quoted string containing a variable found',
+        :linenumber => 1,
+        :column     => 8,
+      })
+    }
+  end
+end