polisher 0.10.2 → 0.11.1

data/spec/rpm/spec/comparison_spec.rb

@@ -0,0 +1,55 @@
+#
+# Licensed under the MIT license
+# Copyright (C) 2014 Red Hat, Inc.
+
+require 'polisher/rpm/spec'
+
+module Polisher::RPM
+  describe Spec do
+    describe "#compare" do
+      it "returns requirements in spec but not in gem" do
+        req  = Requirement.parse 'rubygem(rails) > 3.0.0'
+        spec = described_class.new :requires => [req]
+        gem  = Polisher::Gem.new
+
+        spec.compare(gem).should ==
+          {:same => {}, :diff => {'rails' =>
+                  {:spec => '> 3.0.0', :upstream => nil}}}
+      end
+
+      it "returns requirements in gem but not in spec" do
+        req = ::Gem::Dependency.new('rails', '> 3.0.0')
+        spec = described_class.new
+        gem  = Polisher::Gem.new :deps => [req]
+
+        spec.compare(gem).should ==
+          {:same => {}, :diff => {'rails' =>
+                  {:spec => nil, :upstream => '> 3.0.0'}}}
+      end
+
+      it "returns shared requirements with different specifiers" do
+        greq = ::Gem::Dependency.new('rails', '< 5.0.0')
+        gem  = Polisher::Gem.new :deps => [greq]
+
+        sreq = Requirement.parse 'rubygem(rails) > 3.0.0'
+        spec = described_class.new :requires => [sreq]
+
+        spec.compare(gem).should ==
+          {:same => {}, :diff => {'rails' =>
+                  {:spec => '> 3.0.0', :upstream => '< 5.0.0'}}}
+      end
+
+      it "returns shared requirements" do
+        greq = ::Gem::Dependency.new('rails', '< 3.0.0')
+        gem  = Polisher::Gem.new :deps => [greq]
+
+        sreq = Requirement.parse 'rubygem(rails) < 3.0.0'
+        spec = described_class.new :requires => [sreq]
+
+        spec.compare(gem).should ==
+          {:diff => {}, :same => {'rails' =>
+                  {:spec => '< 3.0.0', :upstream => '< 3.0.0'}}}
+      end
+    end
+  end # describe Spec
+end # module Polisher::RPM

data/spec/rpm/spec/files_spec.rb

@@ -0,0 +1,17 @@
+#
+# Licensed under the MIT license
+# Copyright (C) 2014 Red Hat, Inc.
+
+require 'polisher/rpm/spec'
+
+module Polisher::RPM
+  describe Spec do
+    describe "#files" do
+      it "returns flattened files in all packages" do
+        spec = described_class.new :pkg_files => {'foo' => ['file1'],
+                                                  'doc' => ['docfile']}
+        spec.files.should == %w(file1 docfile)
+      end
+    end
+  end # describe Spec
+end # module Polisher::RPM

data/spec/rpm/spec/gem_files_spec.rb

@@ -0,0 +1,112 @@
+#
+# Licensed under the MIT license
+# Copyright (C) 2014 Red Hat, Inc.
+
+require 'polisher/rpm/spec'
+
+module Polisher::RPM
+  describe Spec do
+    describe "::file_satisfies?" do
+      context "spec file is same as gemfile" do
+        it "returns true" do
+          described_class.file_satisfies?('file1', 'file1').should be_true
+        end
+      end
+
+      context "spec file is dir containing gemfile" do
+        it "returns true" do
+          described_class.file_satisfies?('dir', 'dir/file1').should be_true
+        end
+      end
+
+      context "spec file and gem file are not related" do
+        it "returns false" do
+          described_class.file_satisfies?('foo', 'bar').should be_false
+        end
+      end
+    end
+
+    describe "#missing_gem_file?" do
+      context "no spec files satisfies specified gem file" do
+        it "returns true" do
+          spec = described_class.new
+          spec.should_receive(:files).and_return(['file1'])
+          described_class.should_receive(:file_satisfies?)
+                         .with('file1', 'gem_file')
+                         .and_return(false)
+          spec.missing_gem_file?('gem_file').should be_true
+        end
+      end
+
+      context "at least one spec file satisfying specified gem file" do
+        it "returns false" do
+          spec = described_class.new
+          spec.should_receive(:files).and_return(%w(file1 file2))
+          described_class.should_receive(:file_satisfies?)
+                         .with('file1', 'gem_file')
+                         .and_return(false)
+          described_class.should_receive(:file_satisfies?)
+                         .with('file2', 'gem_file')
+                         .and_return(true)
+          spec.missing_gem_file?('gem_file').should be_false
+        end
+      end
+    end
+
+    describe "#missing_files_for" do
+      it "returns gem files for which there are no satisfying spec files" do
+        gem = Polisher::Gem.new
+        gem.should_receive(:file_paths).and_return(%w(file1 file2))
+
+        spec = described_class.new
+        spec.should_receive(:missing_gem_file?)
+            .with('file1').and_return(false)
+        spec.should_receive(:missing_gem_file?)
+            .with('file2').and_return(true)
+        spec.missing_files_for(gem).should == ['file2']
+      end
+    end
+
+    describe "#excluded files" do
+      it "returns files excluded from upstream gem" do
+        gem = Polisher::Gem.new
+        spec = described_class.new
+        spec.should_receive(:upstream_gem).and_return(gem)
+        spec.should_receive(:missing_files_for)
+            .with(gem).and_return(['file1'])
+        spec.excluded_files.should == ['file1']
+      end
+    end
+
+    describe "#excludes_file?" do
+      context "file on excluded files list" do
+        it "returns true" do
+          spec = described_class.new
+          spec.should_receive(:excluded_files).and_return(%w(file1 file2))
+          spec.excludes_file?('file1').should be_true
+        end
+      end
+
+      context "file not on excluded files list" do
+        it "returns false" do
+          spec = described_class.new
+          spec.should_receive(:excluded_files).and_return(%w(file1 file2))
+          spec.excludes_file?('foobar').should be_false
+        end
+      end
+    end
+
+    describe "#extra_gem_files" do
+      it "returns pkg files not in specified gem" do
+        gem = Polisher::Gem.new
+        gem.should_receive(:has_file_satisfied_by?).with('foo').and_return(true)
+        gem.should_receive(:has_file_satisfied_by?).with('var').and_return(false)
+        gem.should_receive(:has_file_satisfied_by?).with('bar').and_return(false)
+
+        spec = described_class.new :name => 'rubygem-rails'
+        spec.should_receive(:pkg_files).and_return({:rails => ['var'], :doc => ['foo', 'bar']})
+        spec.extra_gem_files(gem).should == {:rails => ['var'], :doc => ['bar']}
+      end
+    end
+  end # describe Spec
+end # module Polisher::RPM

data/spec/rpm/spec/gem_reference_spec.rb

@@ -0,0 +1,99 @@
+#
+# Licensed under the MIT license
+# Copyright (C) 2014 Red Hat, Inc.
+
+require 'polisher/rpm/spec'
+require 'polisher/gem'
+
+module Polisher::RPM
+  describe Spec do
+    let(:spec) { described_class.new }
+    let(:gem)  { Polisher::Gem.new   }
+
+    describe "#upstream_gem" do
+      it "sets & returns upstream gem" do
+        gem_name = 'polisher'
+        version  = 5.0
+        Polisher::Gem.should_receive(:from_rubygems)
+                     .with(gem_name, version).and_return(gem)
+        spec = described_class.new :gem_name => gem_name, :version => version
+        spec.upstream_gem.should == gem
+        spec.upstream_gem.object_id.should == spec.upstream_gem.object_id
+      end
+    end
+
+    describe "#missing_deps_for" do
+      it "returns gem deps without corresponding requirements" do
+        gem.deps = local_gem.deps
+        spec.should_receive(:requirements_for_gem)
+            .with(gem.deps.first.name).and_return([])
+        spec.should_receive(:requirements_for_gem)
+            .exactly(gem.deps.length-1).times.and_return(['req'])
+        spec.missing_deps_for(gem).should == [gem.deps.first]
+      end
+    end
+
+    describe "#missing_dev_deps_for" do
+      it "returns gem dev deps without corresponding build requirements" do
+        gem.dev_deps = local_gem.deps
+        spec.should_receive(:build_requirements_for_gem)
+            .with(gem.dev_deps.first.name).and_return([])
+        spec.should_receive(:build_requirements_for_gem)
+            .exactly(gem.dev_deps.length-1).times.and_return(['req'])
+        spec.missing_dev_deps_for(gem).should == [gem.dev_deps.first]
+      end
+    end
+
+    describe "#excluded_deps" do
+      it "returns missing deps for upstream gem" do
+        expected = ['deps']
+        spec.gem = gem
+        spec.should_receive(:missing_deps_for).with(gem).and_return(expected)
+        spec.excluded_deps.should == expected
+      end
+    end
+
+    describe "#excludes_dep?" do
+      context "upstream gem excludes specified gem" do
+        it "returns true" do
+          deps = [::Gem::Dependency.new('rails')]
+          spec.should_receive(:excluded_deps).and_return(deps)
+          spec.excludes_dep?('rails').should be_true
+        end
+      end
+
+      context "upstream gem does not exclude specified gem" do
+        it "returns false" do
+          spec.should_receive(:excluded_deps).and_return([])
+          spec.excludes_dep?('rails').should be_false
+        end
+      end
+    end
+
+    describe "#excluded_dev_deps" do
+      it "returns missing dev deps for upstream gem" do
+        expected = ['deps']
+        spec.gem = gem
+        spec.should_receive(:missing_dev_deps_for).with(gem).and_return(expected)
+        spec.excluded_dev_deps.should == expected
+      end
+    end
+
+    describe "#excludes_dev_dep?" do
+      context "upstream gem excludes specified gem from dev deps" do
+        it "returns true" do
+          deps = [::Gem::Dependency.new('rails')]
+          spec.should_receive(:excluded_dev_deps).and_return(deps)
+          spec.excludes_dev_dep?('rails').should be_true
+        end
+      end
+
+      context "upstream gem does not exclude specified gem from dev deps" do
+        it "returns false" do
+          spec.should_receive(:excluded_dev_deps).and_return([])
+          spec.excludes_dev_dep?('rails').should be_false
+        end
+      end
+    end
+  end # describe Spec
+end # module Polisher::RPM

data/spec/rpm/spec/gem_requirement_spec.rb

@@ -0,0 +1,38 @@
+#
+# Licensed under the MIT license
+# Copyright (C) 2014 Red Hat, Inc.
+
+require 'polisher/rpm/spec'
+
+module Polisher::RPM
+  describe Spec do
+    describe "#requirements_for_gem" do
+      it "returns requirements for specified gem name" do
+        spec = described_class.new :requires =>
+          [Requirement.new(:name => 'rubygem(rake)')]
+        spec.requirements_for_gem('rake').should == [spec.requires.first]
+      end
+
+      context "spec has no requirement with specified name" do
+        it "returns empty array" do
+          spec = described_class.new
+          spec.requirements_for_gem('rake').should be_empty
+        end
+      end
+    end
+
+    describe "#build_requirements_for_gem" do
+      it "returns build requirements for specified gem name" do
+        spec = described_class.new :build_requires => [Requirement.new(:name => 'rubygem(rake)')]
+        spec.build_requirements_for_gem('rake').should == [spec.build_requires.first]
+      end
+
+      context "spec has no requirement with specified name" do
+        it "returns empty array" do
+          spec = described_class.new
+          spec.build_requirements_for_gem('rake').should be_empty
+        end
+      end
+    end
+  end # describe Spec
+end # module Polisher::RPM

data/spec/rpm/spec/parser_spec.rb

@@ -0,0 +1,64 @@
+#
+# Licensed under the MIT license
+# Copyright (C) 2014 Red Hat, Inc.
+
+require 'polisher/rpm/spec'
+
+module Polisher::RPM
+  describe Spec do
+    describe "#parse" do
+      it "returns new rpmspec instance" do
+        pspec = described_class.parse rpm_spec[:contents]
+        pspec.should be_an_instance_of(described_class)
+      end
+
+      it "parses contents from spec" do
+        pspec = described_class.parse rpm_spec[:contents]
+        pspec.contents.should == rpm_spec[:contents]
+      end
+
+      it "parses name from spec" do
+        pspec = described_class.parse rpm_spec[:contents]
+        pspec.gem_name.should == rpm_spec[:name]
+      end
+
+      it "parses version from spec" do
+        pspec = described_class.parse rpm_spec[:contents]
+        pspec.version.should == rpm_spec[:version]
+      end
+
+      it "parses release from spec" do
+        pspec = described_class.parse rpm_spec[:contents]
+        pspec.release.should == rpm_spec[:release]
+      end
+
+      it "parses requires from spec" do
+        pspec = described_class.parse rpm_spec[:contents]
+        pspec.requires.should == rpm_spec[:requires]
+      end
+
+      it "parses build requires from spec" do
+        pspec = described_class.parse rpm_spec[:contents]
+        pspec.build_requires.should == rpm_spec[:build_requires]
+      end
+
+      it "parses changelog from spec" do
+        pspec = described_class.parse rpm_spec[:contents]
+        pspec.changelog.should == rpm_spec.changelog
+      end
+
+      it "parses unrpmized files from spec" do
+        pspec = described_class.parse rpm_spec[:contents]
+        pspec.pkg_files.should == rpm_spec[:files]
+      end
+
+      it "parses %check from spec" do
+        pspec = described_class.parse rpm_spec[:contents]
+        pspec.has_check?.should be_true
+
+        pspec = described_class.parse ""
+        pspec.has_check?.should be_false
+      end
+    end
+  end # describe Spec
+end # module Polisher::RPM

data/spec/rpm/spec/requirements_spec.rb

@@ -0,0 +1,10 @@
+#
+# Licensed under the MIT license
+# Copyright (C) 2014 Red Hat, Inc.
+
+require 'polisher/rpm/spec'
+
+module Polisher::RPM
+  describe Spec do
+  end # describe Spec
+end # module Polisher::RPM

data/spec/rpm/spec/subpackages_spec.rb

@@ -0,0 +1,38 @@
+#
+# Licensed under the MIT license
+# Copyright (C) 2014 Red Hat, Inc.
+
+require 'polisher/rpm/spec'
+
+module Polisher::RPM
+  describe Spec do
+    describe "#subpkg_containing" do
+      it "returns subpackage containing specified file" do
+        spec = described_class.new :pkg_files => {'foo' => ['file1']}
+        spec.subpkg_containing('file1').should == 'foo'
+      end
+
+      context "no subpackage contains specified file" do
+        it "returns nil" do
+          spec = described_class.new :pkg_files => {}
+          spec.subpkg_containing('anything').should be_nil
+        end
+      end
+    end
+
+    describe "#has_doc_subpkg?" do
+      context "spec has doc subpackage" do
+        it "returns true" do
+          spec = described_class.new :contents => "foo\n%package doc\nbar"
+          spec.has_doc_subpkg?.should be_true
+        end
+      end
+
+      context "spec does not have doc subpackage" do
+        it "returns false" do
+          described_class.new.has_doc_subpkg?.should be_false
+        end
+      end
+    end
+  end # describe Spec
+end # module Polisher::RPM

data/spec/rpm/spec/updater_spec.rb

@@ -0,0 +1,486 @@
+#
+# Licensed under the MIT license
+# Copyright (C) 2014 Red Hat, Inc.
+
+require 'polisher/rpm/spec'
+require 'polisher/rpm/requirement'
+require 'polisher/gem'
+
+module Polisher::RPM
+  describe Spec do
+    let(:gem) do
+      Polisher::Gem.new :path => local_gem.gem_path
+    end
+
+    let(:spec) do
+      spec = described_class.new 
+      spec.gem = gem
+      spec
+    end
+
+    describe "#update_to" do
+      it "updates dependencies" do
+        spec.should_receive(:update_deps_from).with(gem)
+        spec.update_to(gem)
+      end
+
+      it "updates files" do
+        spec.should_receive(:update_files_from).with(gem)
+        spec.update_to(gem)
+      end
+
+      it "updates metadata" do
+        spec.should_receive(:update_metadata_from).with(gem)
+        spec.update_to(gem)
+      end
+
+      it "updates contents" do
+        spec.should_receive(:update_contents)
+        spec.update_to(gem)
+      end
+    end
+
+    describe "#updated_requires_for" do
+      it "returns array of updated requires" do
+        spec.updated_requires_for(gem).should be_an_instance_of(Array)
+      end
+
+      it "returns non gem requirements" do
+        expected = ['non', 'gem', 'reqs']
+        spec.should_receive(:non_gem_requirements).and_return(expected)
+        result = spec.updated_requires_for(gem)
+        expected.each { |req| result.should include(req) }
+      end
+
+      it "returns extra gem requirements" do
+        expected = ['extra', 'gem', 'reqs']
+        spec.should_receive(:extra_gem_requirements)
+            .with(gem).and_return(expected)
+        result = spec.updated_requires_for(gem)
+        expected.each { |req| result.should include(req) }
+      end
+
+      it "returns new source dependencies" do
+        gem.deps = gem_json.deps
+        spec.should_receive(:excludes_dep?)
+            .exactly(gem.deps.length).times.and_return(false)
+        expected = gem.deps.collect { |d| Requirement.from_gem_dep(d) }.flatten
+        result = spec.updated_requires_for(gem)
+        expected.each { |req| result.should include(req) }
+      end
+
+      context "spec excludes new source dep" do
+        it "does not return it" do
+          gem.deps = gem_json.deps
+          spec.should_receive(:excludes_dep?)
+              .with(gem.deps.first.name).and_return(true)
+          spec.should_receive(:excludes_dep?)
+              .exactly(gem.deps.length-1).times.and_return(false)
+          result = spec.updated_requires_for(gem)
+          result.any? { |req| req.matches?(gem.deps.first) }.should be_false
+        end
+      end
+    end
+
+    describe "#updated_build_requires_for" do
+      it "returns array of updated build requires" do
+        spec.updated_build_requires_for(gem).should be_an_instance_of(Array)
+      end
+
+      it "returns non gem build requirements" do
+        expected = ['non', 'gem', 'reqs']
+        spec.should_receive(:non_gem_build_requirements).and_return(expected)
+        result = spec.updated_build_requires_for(gem)
+        expected.each { |req| result.should include(req) }
+      end
+
+      it "returns extra gem build requirements" do
+        expected = ['extra', 'gem', 'reqs']
+        spec.should_receive(:extra_gem_build_requirements)
+            .with(gem).and_return(expected)
+        result = spec.updated_build_requires_for(gem)
+        expected.each { |req| result.should include(req) }
+      end
+
+      it "returns new source dev dependencies" do
+        gem.dev_deps = gem_json.deps
+        spec.should_receive(:excludes_dev_dep?)
+            .exactly(gem.dev_deps.length).times.and_return(false)
+        expected = gem.dev_deps.collect { |d| Requirement.from_gem_dep(d, true) }.flatten
+        result = spec.updated_build_requires_for(gem)
+        expected.each { |req| result.should include(req) }
+      end
+
+      context "spec excludes new source dev dep" do
+        it "does not return it" do
+          gem.dev_deps = gem_json.deps
+          spec.should_receive(:excludes_dev_dep?)
+              .with(gem.dev_deps.first.name).and_return(true)
+          spec.should_receive(:excludes_dev_dep?)
+              .exactly(gem.dev_deps.length-1).times.and_return(false)
+          result = spec.updated_build_requires_for(gem)
+          result.any? { |req| req.matches?(gem.dev_deps.first) }.should be_false
+        end
+      end
+    end
+
+    describe "#changelog_index" do
+      it "returns position of the changelog in spec" do
+        spec.contents = "blah\nblah\n%changelog\nmore" 
+        spec.changelog_index.should == 10
+      end
+    end
+
+    describe "#changelog_end_index" do
+      it "returns position of the end of the changelog in spec" do
+        spec.contents = "blah\nblah\n%changelog\nmore"
+        spec.changelog_end_index.should == 21
+      end
+
+      context "no changelog in spec" do
+        it "returns the last position in the spec" do
+          contents = "blah\nblah"
+          spec.contents = contents
+          spec.changelog_end_index.should == contents.length - 1
+        end
+      end
+    end
+
+    describe "#requires_contents" do
+      it "returns generated spec Requires from metadata" do
+        spec.requires = rpm_spec.requires
+        expected = spec.requires.collect { |r| "Requires: #{r.str}" }.join("\n")
+        spec.requires_contents.should == expected
+      end
+    end
+
+    describe "#build_requires_contents" do
+      it "returns generated spec BuildRequires from metadata" do
+        spec.build_requires = rpm_spec.build_requires
+        expected = spec.build_requires.collect { |r| "BuildRequires: #{r.str}" }.join("\n")
+        spec.build_requires_contents.should == expected
+      end
+    end
+
+    describe "#first_requires_index" do
+      it "returns the position of the first requires in the spec" do
+        spec.contents = "blah\nRequires: foo\nRequires: bar\nother" 
+        spec.first_requires_index.should == 5
+
+        spec.contents = ""
+        spec.first_requires_index.should be_nil
+      end
+    end
+
+    describe "#first_build_requires_index" do
+      it "returns the position of the first build requires in the spec" do
+        spec.contents = "blah\nRequires: foo\nBuildRequires: bar\nBuildRequires: baz\nother"
+        spec.first_build_requires_index.should == 19
+
+        spec.contents = ""
+        spec.first_build_requires_index.should be_nil
+      end
+    end
+
+    describe "#requirement_section_index" do
+      context "no Requires" do
+        it "returns index of first build requires" do
+          spec.contents = "blah\nBuildRequires: bar\nBuildRequires: baz\nother"
+          spec.requirement_section_index.should == 5
+
+          spec.contents = ""
+          spec.requirement_section_index.should be_nil
+        end
+      end
+
+      context "first Requires is before first BuildRequires" do
+        it "returns index of first requires" do
+          spec.contents = "blah\nRequires: bar\nBuildRequires: baz\nother"
+          spec.requirement_section_index.should == 5
+        end
+      end
+
+      context "first BuildRequires is before first Requires" do
+        it "returns index of first BuildRequires" do
+          spec.contents = "blah\nBuildRequires: bar\nRequires: baz\nother" 
+          spec.requirement_section_index.should == 5
+        end
+      end
+    end
+
+    describe "#last_main_package_index" do
+      context "spec has description section" do
+        it "returns position of description section" do
+          spec.contents = "blah\nmore\n%description\ninfo\nmore" 
+          spec.last_main_package_index.should == 10
+        end
+      end
+
+      context "spec has at least one subpkg" do
+        it "returns position of first subpackage" do
+          spec.contents = "blah\nmore\n%package foo\ninfo\nmore"
+          spec.last_main_package_index.should == 10
+        end
+      end
+      
+      context "spec has a prep section" do
+        it "returns position of prep section" do
+          spec.contents = "metadata\nmore\n%prep\ncmd\nantoher"
+          spec.last_main_package_index.should == 14
+        end
+      end
+
+      context "no description, subpackages, prep sections" do
+        it "returns -1" do
+          spec.contents = ""
+          spec.last_main_package_index.should == -1
+        end
+      end
+    end
+
+    describe "#description_index" do
+      it "returns position of description section" do
+        spec.contents = "meta\ndata\n%description\ndescript\n"
+        spec.description_index.should == 10
+      end
+    end
+
+    describe "#prep_index" do
+      it "returns position of prep section" do
+        spec.contents = "foo\n%prep\nbar"
+        spec.prep_index.should == 4
+      end
+    end
+
+    describe "#subpkg_index" do
+      it "returns position of the first subpackage" do
+        spec.contents = "foo\n%package bar\nstuff\n%package baz\nmore stuff"
+        spec.subpkg_index.should == 4
+      end
+    end
+
+    describe "#last_requires_index" do
+      it "returns the position of the last Requires in the spec" do
+        spec.contents = "foo\nRequires: abc\nRequires: def\nBuildRequires: 123\nok"
+        spec.last_requires_index.should == 18
+      end
+
+      context "no Requires in the spec" do
+        it "returns -1" do
+          spec.contents = ""
+          spec.last_requires_index.should == -1
+        end
+      end
+    end
+
+    describe "#last_build_requires_index" do
+      it "returns the position of the last BuildRequires in the spec" do
+        spec.contents = "foo\nRequires: abc\nBuildRequires: def\nBuildRequires: 123\nok"
+        spec.last_build_requires_index.should == 37
+      end
+
+      context "no BuildRequires in the spec" do
+        it "returns -1" do
+          spec.contents = ""
+          spec.last_build_requires_index.should == -1
+        end
+      end
+    end
+
+    describe "#last_requirement_index" do
+      context "last Requires is after last BuildRequires" do
+        it "returns last_requires_index" do
+          spec.contents = "info\nBuildRequires: br\nRequires: r\nmore stuff"
+          spec.last_requirement_index.should == 23
+        end
+      end
+
+      context "last BuildRequires is after last Requires" do
+        it "returns last_build_requires_index" do
+          spec.contents = "info\nRequires: br\nBuildRequires: r\nmore stuff"
+          spec.last_requirement_index.should == 18
+        end
+      end
+    end
+
+    describe "#requirement_section_end_index" do
+      it "returns the position of the newline following the last_requires_index" do
+        spec.contents = "info\nRequires: br\nBuildRequires: r\nmore stuff"
+        spec.requirement_section_end_index.should == 34
+      end
+    end
+
+    describe "#new_files_contents_for" do
+      it "returns generated files section for main package" do
+        files = ["file1", "foobar"]
+        expected = "%files\n" + files.join("\n") + "\n"
+        spec.metadata[:new_files] = {spec.gem_name => files}
+        spec.new_files_contents_for(spec.gem_name).should == expected
+      end
+
+      it "returns generated files section for specified subpkg" do
+        files = ["file1", "foobar"]
+        expected = "%files doc\n" + files.join("\n") + "\n"
+        spec.metadata[:new_files] = {'doc' => files}
+        spec.new_files_contents_for('doc').should == expected
+      end
+    end
+
+    describe "#excludes_contents" do
+      context "excludes are specified" do
+        it "returns generated excluded files contents" do
+          files = ['file1', 'foobar']
+          expected = files.collect{ |e| "%exclude #{e}" }.join("\n") + "\n\n"
+          spec.metadata[:pkg_excludes] = {spec.gem_name => files}
+          spec.excludes_contents.should == expected
+        end
+      end
+
+      context "excludes are not specified" do
+        it "returns blank string" do
+          spec.excludes_contents.should == ""
+        end
+      end
+    end
+
+    describe "#files_index" do
+      it "returns position of files section in spec" do
+        spec.contents = "lot\nof\metadata\n%files\nlist\nfile1\nfiles2"
+        spec.files_index.should == 15
+      end
+    end
+
+    describe "#files_end_index" do
+      it "returns position of changelog section in spec" do
+        spec.contents = "lot\nof\metadata\n%files\nlist\n%changelog\nentry1"
+        spec.files_end_index.should == 27
+      end
+    end
+
+
+    describe "#update_requires" do
+      it "updates requirements section" do
+        spec.should_receive(:requires_contents).and_return('requires_contents')
+        spec.should_receive(:build_requires_contents).and_return('build_requires_contents')
+        spec.contents = "foo\nRequires: bar\nBuildRequires: baz\nRequires: biz\n"
+        expected = "foo\nrequires_contents\nbuild_requires_contents\n"
+        spec.send(:update_requires)
+        spec.contents.should == expected
+      end
+    end
+
+    describe "#update_files" do
+      it "tbd"
+    end
+
+    describe "#update_deps_from" do
+      it "updates requires from new source" do
+        spec.should_receive(:update_requires_from).with(gem)
+        spec.send(:update_deps_from, gem)
+      end
+
+      it "updates build requires from new source" do
+        spec.should_receive(:update_build_requires_from).with(gem)
+        spec.send(:update_deps_from, gem)
+      end
+    end
+
+    describe "#update_requires_from" do
+      it "sets Requires from updated requires" do
+        expected = ['req', 'uires']
+        spec.should_receive(:updated_requires_for)
+            .with(gem)
+            .and_return(expected)
+        spec.send(:update_requires_from, gem)
+        spec.requires.should == expected
+      end
+    end
+
+    describe "#update_build_requires_from" do
+      it "sets BuildRequires from updated build requires" do
+        expected = ['req', 'uires']
+        spec.should_receive(:updated_build_requires_for)
+            .with(gem)
+            .and_return(expected)
+        spec.send(:update_build_requires_from, gem)
+        spec.build_requires.should == expected
+      end
+    end
+
+    describe "#update_files_from" do
+      it "tbd"
+    end
+
+    describe "#update_metadata_from" do
+      it "updates version" do
+        gem.version = '1.2.3'
+        spec.send(:update_metadata_from, gem)
+        spec.version.should == '1.2.3'
+      end
+
+      it "resets release" do
+        spec.release = '1000000'
+        spec.send(:update_metadata_from, gem)
+        spec.release.should == '1%{?dist}'
+      end
+
+      it "invalidates local gem" do
+        spec.instance_variable_set(:@update_gem, false)
+        spec.send(:update_metadata_from, gem)
+        spec.instance_variable_get(:@update_gem).should be_true
+      end
+
+      it "adds changelog entry" do
+        spec.send(:update_metadata_from, gem)
+        spec.changelog_entries.length.should == 1
+      end
+
+      it "generates valid changelog entry"
+    end
+
+    describe "#update_metadata_contents" do
+      it "updates spec version and release" do
+        before = "Name: foo\nVersion: 0.1\nRelease: 2?%{dist}\n%package"
+        after  = "Name: foo\nVersion: 1.0\nRelease: 1?%{dist}\n%package"
+
+        spec.metadata[:contents] = before
+        spec.version             = 1.0
+        spec.release             = '1?%{dist}'
+        spec.send(:update_metadata_contents)
+        spec.contents.should == after
+      end
+    end
+
+    describe "#update_changelog" do
+      it "updates the changelog in the spec" do
+        spec.metadata[:changelog_entries] = ['*entry0', '*entry01']
+        spec.contents = "foo\n%changelog\n*entry1\n*entry2"
+        expected = "foo\n%changelog\n*entry0\n\n*entry01"
+        spec.send(:update_changelog)
+        spec.contents.should == expected
+      end
+    end
+
+    describe "#update_contents" do
+      it "updates metadata contents" do
+        spec.should_receive(:update_metadata_contents)
+        spec.send(:update_contents)
+      end
+
+      it "updates changelog" do
+        spec.should_receive(:update_changelog)
+        spec.send(:update_contents)
+      end
+
+      it "updates requires" do
+        spec.should_receive(:update_requires)
+        spec.send(:update_contents)
+      end
+
+      it "updates files" do
+        spec.should_receive(:update_files)
+        spec.send(:update_contents)
+      end
+    end
+  end # describe Spec
+end # module Polisher::RPM