polisher 0.10.2 → 0.11.1

data/spec/git/pkg_spec.rb

@@ -0,0 +1,21 @@
+#
+# Licensed under the MIT license
+# Copyright (C) 2013-2014 Red Hat, Inc.
+
+require 'polisher/git/pkg'
+
+module Polisher
+  describe Git::Pkg do
+    describe "#initialize" do
+      it "initializes name" do
+        pkg = described_class.new :name => 'pkg_name'
+        pkg.name.should == 'pkg_name'
+      end
+
+      it "initializes version" do
+        pkg = described_class.new :version => 'pkg_version'
+        pkg.version.should == 'pkg_version'
+      end
+    end
+  end # describe Git::Pkg
+end # module Polisher

data/spec/git/project_spec.rb

@@ -0,0 +1,21 @@
+#
+# Licensed under the MIT license
+# Copyright (C) 2013-2014 Red Hat, Inc.
+
+require 'polisher/git/project'
+
+module Polisher
+  describe Git::Project do
+    describe "#vendored" do
+      context "repo not cloned" do
+        it "clones repo" do
+          git = described_class.new
+          git.should_receive(:cloned?).and_return(false)
+          git.should_receive(:clone)
+          git.should_receive(:vendored_file_paths).and_return([]) # stub out
+          git.vendored
+        end
+      end
+    end
+  end
+end # module Polisher

data/spec/git/repo_spec.rb

@@ -0,0 +1,160 @@
+#
+# Licensed under the MIT license
+# Copyright (C) 2013-2014 Red Hat, Inc.
+
+require 'awesome_spawn'
+require 'polisher/git/repo'
+
+module Polisher
+  describe Git::Repo do
+    describe "#initialize" do
+      it "initializes url" do
+        repo = described_class.new :url => 'repo_url'
+        repo.url.should == 'repo_url'
+      end
+    end
+
+    describe "#path" do
+      it "returns set path" do
+        repo = described_class.new :path => 'repo_path'
+        repo.path.should == 'repo_path'
+      end
+
+      it "returns git cache path for url" do
+        repo = described_class.new :url => 'repo_url'
+        Polisher::GitCache.should_receive(:path_for)
+                          .with('repo_url')
+                          .and_return('repo_path')
+        repo.path.should == 'repo_path'
+      end
+    end
+
+    describe "#clobber" do
+      it "rm -rf's path" do
+        repo = described_class.new :path => 'repo_path'
+        FileUtils.should_receive(:rm_rf).with('repo_path')
+        repo.clobber!
+        RSpec::Mocks.proxy_for(FileUtils).reset # XXX
+      end
+    end
+
+    describe "#clone" do
+      it "runs git clone" do
+        expected = "/usr/bin/git clone repo_url repo_path"
+        AwesomeSpawn.should_receive(:run!).with(expected)
+
+        repo = described_class.new :url => 'repo_url'
+        repo.should_receive(:path).and_return('repo_path')
+        repo.clone
+      end
+    end
+
+    describe "#cloned?" do
+      before(:each) do
+        @repo = described_class.new
+        @repo.should_receive(:path).and_return('repo_path')
+      end
+
+      context "repo path directory exists" do
+        it "returns true" do
+          File.should_receive(:directory?).with('repo_path').and_return(true)
+          @repo.should be_cloned
+        end
+      end
+
+      context "repo path directory does not exist" do
+        it "returns false" do
+          File.should_receive(:directory?).with('repo_path').and_return(false)
+          @repo.should_not be_cloned
+        end
+      end
+    end
+
+    describe "#in_repo" do
+      it "chdir to repo path, invokes block, restores dir" do
+        repo = described_class.new
+        Dir.mktmpdir do |dir|
+          repo.should_receive(:path).and_return(dir)
+
+          expected = Pathname.new(dir).realpath.to_s
+          invoked = false
+          orig = Dir.pwd
+          repo.in_repo do
+            Dir.pwd.should == expected
+            invoked = true
+          end
+          Dir.pwd.should == orig
+          invoked.should be_true
+        end
+      end
+    end
+
+    describe "#file_paths" do
+      it "returns list of all first paths in git repo" do
+        expected = ['file1', 'dir1/file2', 'dir2']
+        repo = described_class.new
+        repo.should_receive(:in_repo).and_yield
+        Dir.should_receive(:[]).with('**/*').and_return(expected)
+        repo.file_paths.should == expected
+      end
+    end
+
+    describe "#include?" do
+      context "file paths includes file" do
+        it "returns true" do
+          repo = described_class.new
+          repo.should_receive(:file_paths).and_return(['foo'])
+          repo.include?('foo').should be_true
+        end
+      end
+
+      context "file paths does not include file" do
+        it "returns false" do
+          repo = described_class.new
+          repo.should_receive(:file_paths).and_return([])
+          repo.include?('foo').should be_false
+        end
+      end
+    end
+
+    describe "#reset!" do
+      it "resets git repo to head" do
+        expected = "/usr/bin/git reset HEAD~ --hard"
+        repo = described_class.new
+        repo.should_receive(:in_repo).and_yield
+        AwesomeSpawn.should_receive(:run!).with(expected)
+        repo.reset!
+      end
+    end
+
+    describe "#pull" do
+      it "git pulls" do
+        expected = "/usr/bin/git pull"
+        repo = described_class.new
+        repo.should_receive(:in_repo).and_yield
+        AwesomeSpawn.should_receive(:run!).with(expected)
+        repo.pull
+      end
+    end
+
+    describe "#checkout" do
+      it "git checks out target" do
+        expected = "/usr/bin/git checkout master"
+        repo = described_class.new
+        repo.should_receive(:in_repo).and_yield
+        AwesomeSpawn.should_receive(:run!).with(expected)
+        repo.checkout('master')
+      end
+    end
+
+    describe "#commit" do
+      it "git commits with message" do
+        expected = "/usr/bin/git commit -m 'msg'"
+        repo = described_class.new
+        repo.should_receive(:in_repo).and_yield
+        AwesomeSpawn.should_receive(:run!).with(expected)
+        repo.commit('msg')
+      end
+    end
+  end
+end # module Polisher

data/spec/{vendor_spec.rb → mixins/vendored_deps_spec.rb}

@@ -3,9 +3,7 @@
 # Licensed under the MIT license
 # Copyright (C) 2014 Red Hat, Inc.
 
-require 'spec_helper'
-
-require 'polisher/vendor'
+require 'polisher/mixins/vendored_deps'
 
 module Polisher
   describe HasVendoredDeps do
@@ -16,7 +14,7 @@ module Polisher
 
     describe "#vendored_file_paths" do
       it "returns file marks in gem marked as vendored" do
-        expected = [ 'vendor/foo.rb', 'vendor/bar/foo.rb']
+        expected = ['vendor/foo.rb', 'vendor/bar/foo.rb']
         paths    = ['foo.rb'] + expected
         gem = Polisher::Gem.new
         gem.should_receive(:file_paths).and_return(paths)

data/spec/mixins/versioned_dependencies_spec.rb

@@ -0,0 +1,48 @@
+# Polisher VersionedDependencies Spec
+#
+# Licensed under the MIT license
+# Copyright (C) 2013-2014 Red Hat, Inc.
+
+require 'polisher/mixins/versioned_dependencies'
+
+module Polisher
+  describe VersionedDependencies do
+    before(:each) do
+      @obj = Object.new
+      @obj.extend(VersionedDependencies)
+    end
+
+    it "retrieves versions of each dependency in configured targets"
+    it "invokes block with targets / versions"
+
+    describe "#dependency_for" do
+      it "returns dependency w/ the specified name" do
+        dep1 = ::Gem::Dependency.new 'dep1'
+        dep2 = ::Gem::Dependency.new 'dep2'
+        @obj.should_receive(:deps).twice.and_return([dep1, dep2])
+        @obj.dependency_for('dep1').should == dep1
+        @obj.dependency_for('dep2').should == dep2
+      end
+    end
+
+    describe "#missing_dependencies" do
+      it "returns dependencies with no matching target versions"
+    end
+
+    describe "#dependencies_satisfied?" do
+      context "no missing dependencies" do
+        it "returns true" do
+          @obj.should_receive(:missing_dependencies).and_return([])
+          @obj.dependencies_satisfied?.should be_true
+        end
+      end
+
+      context "missing dependencies found" do
+        it "returns false" do
+          @obj.should_receive(:missing_dependencies).and_return(['rails'])
+          @obj.dependencies_satisfied?.should be_false
+        end
+      end
+    end
+  end # described VersionedDependencies
+end # module Polisher

data/spec/rpm/patch_spec.rb

@@ -0,0 +1,48 @@
+# Polisher RPM Patch Specs
+#
+# Licensed under the MIT license
+# Copyright (C) 2014 Red Hat, Inc.
+
+require 'polisher/rpm/patch'
+
+module Polisher::RPM
+  describe Patch do
+    let(:patch) { described_class.new }
+
+    describe "#initialize" do
+      it "initializes patch attributes" do
+        patch.title   = 'title'
+        patch.content = 'content'
+      end
+    end
+
+    describe "#spec_line" do
+      it "returns spec patch line" do
+        patch.title = 'title'
+        patch.spec_line(1).should == "Patch1: title"
+      end
+    end
+
+    describe "::from" do
+      it "returns patch for each file modified in diff" do
+        diff = "diff -r file1.rb file2.rb\ncontents\ncontents\n" \
+               "diff -r file2.rb file3.rb\nmore contents"
+        result = described_class.from(diff)
+
+        result.size.should == 2
+        result[0].should be_an_instance_of(Patch)
+        result[0].title.should == 'file1.rb'
+        result[0].content.should == "contents\ncontents\n"
+        result[1].should be_an_instance_of(Patch)
+        result[1].title.should == 'file2.rb'
+        result[1].content.should == "more contents"
+      end
+
+      it "skips 'Only In Lines'" do
+        diff = "diff -r file1.rb file2.rb\ncontents\nOnly in foo.rb"
+        result = described_class.from(diff)
+        result[0].content.should == "contents\n"
+      end
+    end
+  end # describe Patch
+end # module Polisher::RPM

data/spec/rpm/requirement/attributes_spec.rb

@@ -0,0 +1,34 @@
+#
+# Licensed under the MIT license
+# Copyright (C) 2014 Red Hat, Inc.
+
+require 'polisher/rpm/requirement'
+
+module Polisher::RPM
+  describe Requirement do
+    describe "#str" do
+      it "returns requirement in string format" do
+        req = described_class.new :name => 'rubygem(activesupport)'
+        req.str.should == 'rubygem(activesupport)'
+
+        req = described_class.new :name => 'rubygem(activesupport)',
+                                  :condition => '>=', :version => '4.0'
+        req.str.should == 'rubygem(activesupport) >= 4.0'
+      end
+    end
+
+    describe "#specifier" do
+      it "returns specifier in string format" do
+        req = described_class.new :condition => '>=', :version => '10.0'
+        req.specifier.should == '>= 10.0'
+      end
+
+      context "version is nil" do
+        it "returns nil" do
+          req = described_class.new
+          req.specifier.should be_nil
+        end
+      end
+    end
+  end # describe Requirement
+end # module Polisher::RPM

data/spec/rpm/requirement/comparison_spec.rb

@@ -0,0 +1,286 @@
+#
+# Licensed under the MIT license
+# Copyright (C) 2014 Red Hat, Inc.
+
+require 'polisher/rpm/spec'
+require 'polisher/rpm/requirement'
+
+module Polisher::RPM
+  describe Requirement do
+    describe "#==" do
+      context "requirements are equal" do
+        it "returns true" do
+          req1 = described_class.new
+          req2 = described_class.new
+          req1.should == req2
+
+          req1 = described_class.parse 'rubygem(rails)'
+          req2 = described_class.parse 'rubygem(rails)'
+          req1.should == req2
+
+          req1 = described_class.parse 'rubygem(rails) >= 1.0.0'
+          req2 = described_class.parse 'rubygem(rails) >= 1.0.0'
+          req1.should == req2
+        end
+      end
+
+      context "requirements are not equal" do
+        it "returns true" do
+          req1 = described_class.parse 'rubygem(rails)'
+          req2 = described_class.parse 'rubygem(rake)'
+          req1.should_not == req2
+
+          req1 = described_class.parse 'rubygem(rake) > 1'
+          req2 = described_class.parse 'rubygem(rake) > 2'
+          req1.should_not == req2
+        end
+      end
+    end
+
+    describe "#gcd" do
+      it "selects / returns max version less than local version" do
+        req = described_class.new :version => "5.0.0"
+        req.gcd(['1.0', '2.0', '5.0', '5.1', '6.1']).should == '2.0'
+      end
+    end
+
+    describe "#min_satisfying_version" do
+      context "no version req" do
+        it "returns 0" do
+          req = described_class.new
+          req.min_satisfying_version.should == "0.0"
+        end
+      end
+
+      context "= req" do
+        it "returns local version" do
+          req = described_class.new :condition => '=', :version => '5.0.0'
+          req.min_satisfying_version.should == '5.0.0'
+        end
+      end
+
+      context "> req" do
+        it "returns next version" do
+          req = described_class.new :condition => '>', :version => '5.0.0'
+          req.min_satisfying_version.should == '5.0.1'
+        end
+      end
+
+      context ">= req" do
+        it "returns local version" do
+          req = described_class.new :condition => '>=', :version => '5.0.0'
+          req.min_satisfying_version.should == '5.0.0'
+        end
+      end
+
+      context "< req" do
+        it "returns 0" do
+          req = described_class.new :condition => '<', :version => '5.0.0'
+          req.min_satisfying_version.should == "0.0"
+        end
+      end
+
+      context "<= req" do
+        it "returns 0" do
+          req = described_class.new :condition => '<=', :version => '5.0.0'
+          req.min_satisfying_version.should == "0.0"
+        end
+      end
+    end
+
+    describe "#max_version_satisfying" do
+      context "no version req" do
+        it "returns infinity" do
+          req = described_class.new
+          req.max_satisfying_version.should == Float::INFINITY
+        end
+      end
+
+      context "= req" do
+        it "returns version" do
+          req = described_class.new :condition => '=', :version => '1.2.3'
+          req.max_satisfying_version.should == '1.2.3'
+        end
+      end
+
+      context "> req" do
+        it "returns infinity" do
+          req = described_class.new :condition => '>', :version => '1.2.3'
+          req.max_satisfying_version.should == Float::INFINITY
+        end
+      end
+
+      context ">= req" do
+        it "returns infinity" do
+          req = described_class.new :condition => '>=', :version => '1.2.3'
+          req.max_satisfying_version.should == Float::INFINITY
+        end
+      end
+
+      context "< req" do
+        context "versions list not specified" do
+          it "raises argument error" do
+            req = described_class.new :condition => '<', :version => '1.2.3'
+            lambda {
+              req.max_satisfying_version
+            }.should raise_error(ArgumentError)
+          end
+        end
+
+        it "returns gcd of list" do
+          req = described_class.new :condition => '<', :version => '1.2.3'
+          req.should_receive(:gcd).and_return('3')
+          req.max_satisfying_version(['1', '2']).should == '3'
+        end
+      end
+
+      context "<= req" do
+        it "returns version" do
+          req = described_class.new :condition => '<=', :version => '1.2.3'
+          req.max_satisfying_version.should == '1.2.3'
+        end
+      end
+    end
+
+    describe "#min_failing_version" do
+      context "no version req" do
+        it "raises argument error" do
+          req = described_class.new
+          lambda{
+            req.min_failing_version
+          }.should raise_error(ArgumentError)
+        end
+      end
+
+      context "= req" do
+        it "returns next version" do
+          req = described_class.new :condition => '=', :version => '5.0.0'
+          req.min_failing_version.should == '5.0.1'
+        end
+      end
+
+      context "> req" do
+        it "returns 0" do
+          req = described_class.new :condition => '>', :version => '5.0.0'
+          req.min_failing_version.should == '0.0'
+        end
+      end
+
+      context ">= req" do
+        it "returns 0" do
+          req = described_class.new :condition => '>=', :version => '5.0.0'
+          req.min_failing_version.should == '0.0'
+        end
+      end
+
+      context "< req" do
+        it "returns version" do
+          req = described_class.new :condition => '<', :version => '5.0.0'
+          req.min_failing_version.should == '5.0.0'
+        end
+      end
+
+      context "<= req" do
+        it "returns next version" do
+          req = described_class.new :condition => '<=', :version => '5.0.0'
+          req.min_failing_version.should == '5.0.1'
+        end
+      end
+    end
+
+    describe "#max_failing_version" do
+      context "no version req" do
+        it "raises argument error" do
+          req = described_class.new
+          lambda {
+            req.max_failing_version
+          }.should raise_error(ArgumentError)
+        end
+      end
+
+      context "= req" do
+        context "versions are nil" do
+          it "raises ArgumentError" do
+            req = described_class.new :condition => '=', :version => '2.0'
+            lambda {
+              req.max_failing_version
+            }.should raise_error(ArgumentError)
+          end
+        end
+
+        it "returns gcd of list" do
+          req = described_class.new :condition => '=', :version => '2.0'
+          req.should_receive(:gcd).and_return('abc')
+          req.max_failing_version(['1.2']).should == 'abc'
+        end
+      end
+
+      context "> req" do
+        it "returns version" do
+          req = described_class.new :condition => '>', :version => '2.0'
+          req.max_failing_version.should == '2.0'
+        end
+      end
+
+      context ">= req" do
+        context "versions are nil" do
+          it "raises ArgumentError" do
+            req = described_class.new :condition => '>=', :version => '2.0'
+            lambda {
+              req.max_failing_version
+            }.should raise_error(ArgumentError)
+          end
+        end
+
+        it "returns gcd of list" do
+          req = described_class.new :condition => '>=', :version => '2.0'
+          req.should_receive(:gcd).and_return('abc')
+          req.max_failing_version(['1.2']).should == 'abc'
+        end
+      end
+
+      context "< req" do
+        it "raises argument error" do
+          req = described_class.new :condition => '<', :version => '2.0'
+          lambda {
+            req.max_failing_version
+          }.should raise_error(ArgumentError)
+        end
+      end
+
+      context "<= req" do
+        it "raises argument error" do
+          req = described_class.new :condition => '<', :version => '2.0'
+          lambda {
+            req.max_failing_version
+          }.should raise_error(ArgumentError)
+        end
+      end
+    end
+
+    describe "#matches?" do
+      context "requirement is same as dep requirement" do
+        it "returns true" do
+          dep = ::Gem::Dependency.new 'rails',  '~> 1.0.0'
+          req = described_class.new :name      => 'rubygem(rails)',
+                                    :condition => '=>',
+                                    :version   => '1.0.0'
+          req.matches?(dep).should be_true
+
+          req.condition = '<'
+          req.version = '1.1'
+          req.matches?(dep).should be_true
+        end
+      end
+
+      context "requirement is not same as dep requirement" do
+        it "returns false" do
+          dep = ::Gem::Dependency.new 'rails'
+          req = described_class.new :name => 'rake'
+
+          req.matches?(dep).should be_false
+        end
+      end
+    end
+  end # describe Requirement
+end # module Polisher::RPM