polisher 0.10.2 → 0.11.1

data/spec/gem/files_spec.rb

@@ -0,0 +1,171 @@
+#
+# Licensed under the MIT license
+# Copyright (C) 2013-2014 Red Hat, Inc.
+
+require 'polisher/gem'
+
+module Polisher
+  describe Gem do
+    describe "::ignorable_file?" do
+      context "args matches an ignorable file" do
+        it "returns true" do
+          described_class.ignorable_file?('foo.gemspec').should be_true
+          described_class.ignorable_file?('Gemfile').should be_true
+        end
+      end
+
+      context "args does not match an ignorable file" do
+        it "returns false" do
+          described_class.ignorable_file?('.rvmra').should be_false
+          described_class.ignorable_file?('foo.gemspoc').should be_false
+        end
+      end
+    end
+
+    describe "::runtime_file?" do
+      context "file is a runtime file" do
+        it "returns true" do
+          described_class.runtime_file?('lib').should be_true
+          described_class.runtime_file?('bin').should be_true
+        end
+      end
+
+      context "file is not a runtime file" do
+        it "returns false" do
+          described_class.runtime_file?('spec').should be_false
+        end
+      end
+    end
+
+    describe "::license_file?" do
+      context "file is a runtime file" do
+        it "returns true" do
+          described_class.license_file?('LICENSE').should be_true
+          described_class.license_file?('LICENCE').should be_true
+          described_class.license_file?('MIT-LICENSE').should be_true
+        end
+      end
+
+      context "file is not a runtime file" do
+        it "returns false" do
+          described_class.license_file?('something').should be_false
+        end
+      end
+    end
+
+    describe "::doc_file?" do
+      context "file is on doc file list" do
+        it "returns true" do
+          described_class.doc_file?('CHANGELOG').should be_true
+        end
+      end
+
+      context "file is not on doc file list" do
+        it "returns false" do
+          described_class.doc_file?('foobar.rb').should be_false
+        end
+      end
+    end
+
+    describe "#has_file_satisfied_by?" do
+      context "specified spec file satisfies at least one gem file" do
+        it "returns true" do
+          spec_file = 'spec_file'
+          gem_file  = 'gem_file'
+          RPM::Spec.should_receive(:file_satisfies?)
+                   .with(spec_file, gem_file)
+                   .and_return(true)
+
+          gem = Polisher::Gem.new
+          gem.should_receive(:file_paths).and_return([gem_file])
+          gem.has_file_satisfied_by?(spec_file).should be_true
+        end
+      end
+
+      context "specified spec file does not satisfy any gem files" do
+        it "returns false" do
+          spec_file = 'spec_file'
+          gem_file  = 'gem_file'
+          RPM::Spec.should_receive(:file_satisfies?)
+                   .with(spec_file, gem_file)
+                   .and_return(false)
+
+          gem = Polisher::Gem.new
+          gem.should_receive(:file_paths).and_return([gem_file])
+          gem.has_file_satisfied_by?(spec_file).should be_false
+        end
+      end
+    end
+
+    describe "#unpack" do
+      before do
+        @gem = described_class.new :path => 'gem_path'
+        @pkg = ::Gem::Installer.new 'gem_path'
+        ::Gem::Installer.should_receive(:new)
+                        .with('gem_path', :unpack => true)
+                        .and_return(@pkg)
+      end
+
+      context "no block specified" do
+        before do
+          Dir.should_receive(:mktmpdir).and_return('polisher_tmpdir')
+        end
+
+        it "unpacks gem at gem_path into temp dir" do
+          @pkg.should_receive(:unpack).with('polisher_tmpdir')
+          @gem.unpack
+        end
+
+        it "returns tmp dir" do
+          @pkg.should_receive(:unpack)
+          @gem.unpack.should == 'polisher_tmpdir'
+        end
+      end
+
+      context "block specified" do
+        before do
+          @bl = proc {}
+          Dir.should_receive(:mktmpdir).and_yield('polisher_tmpdir')
+        end
+        it "invokes block with tmp dir" do
+          @bl.should_receive(:call).with('polisher_tmpdir')
+          @pkg.should_receive(:unpack).with('polisher_tmpdir')
+          @gem.unpack &@bl
+        end
+
+        it "returns nil" do
+          @pkg.should_receive(:unpack)
+          @gem.unpack(&@bl).should be_nil
+        end
+      end
+    end
+
+    describe "#each_file" do
+      it "invokes block with path to each file in gem" do
+        gem = described_class.new
+        gem.should_receive(:unpack).and_yield('unpack_dir')
+        pathname = Pathname.new('unpack_dir')
+        Pathname.should_receive(:new).with('unpack_dir').and_return(pathname)
+        pathname.should_receive(:find)
+                .and_yield('unpack_dir')
+                .and_yield('unpack_dir/t1')
+                .and_yield('unpack_dir/')
+                .and_yield('t2')
+                .and_yield('t3')
+        bl = proc{}
+        bl.should_receive(:call).with('t1')
+        bl.should_receive(:call).with('t2')
+        bl.should_receive(:call).with('t3')
+        gem.each_file &bl
+      end
+    end
+
+    describe "#file_paths" do
+      it "returns list of file paths in gem" do
+        gem = described_class.new
+        gem.should_receive(:each_file).and_yield('file1').and_yield('file2')
+        gem.file_paths.should == %w(file1 file2)
+      end
+    end
+  end # describe Gem
+end # module Polisher

data/spec/gem/parser_spec.rb

@@ -0,0 +1,44 @@
+#
+# Licensed under the MIT license
+# Copyright (C) 2013-2014 Red Hat, Inc.
+
+require 'polisher/gem'
+
+module Polisher
+  describe Gem do
+    describe "::parse" do
+      it "returns new gem" do
+        gem = described_class.parse
+        gem.should be_an_instance_of(described_class)
+      end
+
+      it "parses gem from gem spec" do
+        spec = Polisher::Test::GEM_SPEC
+        gem  = described_class.parse(:gemspec => spec[:path])
+        gem.name.should     == spec[:name]
+        gem.version.should  == spec[:version]
+        gem.deps.should     == spec[:deps]
+        gem.dev_deps.should == spec[:dev_deps]
+      end
+
+      it "parses gem from gem at path" do
+        spec = Polisher::Test::GEM_SPEC
+        pkg = ::Gem::Package.new('path')
+        ::Gem::Package.should_receive(:new).with('path').and_return(pkg)
+        pkg.should_receive(:spec).and_return(spec[:path])
+
+        gem = described_class.parse :gem => 'path'
+        gem.name.should == spec[:name]
+        gem.path.should == 'path'
+      end
+
+      it "parses gem from metadata hash" do
+        gem = described_class.parse gem_json[:json]
+        gem.name.should     == gem_json[:name]
+        gem.version.should  == gem_json[:version]
+        gem.deps.should     == gem_json[:deps]
+        gem.dev_deps.should == gem_json[:dev_deps]
+      end
+    end
+  end # describe Gem
+end # module Polisher

data/spec/gem/retriever_spec.rb

@@ -0,0 +1,124 @@
+#
+# Licensed under the MIT license
+# Copyright (C) 2013-2014 Red Hat, Inc.
+
+require 'polisher/gem'
+
+module Polisher
+  describe Gem do
+    describe "::download_gem" do
+      context "gem in GemCache" do
+        it "returns GemCache gem" do
+          gem = described_class.new
+          GemCache.should_receive(:get).with('polisher', '1.1')
+                                       .and_return(gem)
+          described_class.download_gem('polisher', '1.1').should == gem
+        end
+      end
+
+      it "uses curl to download gem" do
+        GemCache.should_receive(:get).and_return(nil)
+        curl = Curl::Easy.new
+        described_class.should_receive(:client)
+                       .at_least(:once).and_return(curl)
+        curl.should_receive(:http_get)
+        curl.should_receive(:body_str).and_return('') # stub out body_str
+
+        described_class.download_gem 'polisher', '2.2'
+        curl.url.should == "https://rubygems.org/gems/polisher-2.2.gem"
+      end
+
+      it "sets gem in gem cache" do
+        GemCache.should_receive(:get).and_return(nil)
+        curl = Curl::Easy.new
+        described_class.should_receive(:client)
+                       .at_least(:once).and_return(curl)
+        curl.stub(:http_get) # stub out http_get
+        curl.should_receive(:body_str).and_return('gem')
+        GemCache.should_receive(:set)
+                .with('polisher', '1.1', 'gem')
+        described_class.download_gem 'polisher', '1.1'
+      end
+
+      it "returns downloaded gem binary contents" do
+        GemCache.should_receive(:get).and_return(nil)
+        curl = Curl::Easy.new
+        described_class.should_receive(:client)
+                       .at_least(:once).and_return(curl)
+        curl.stub(:http_get) # stub out http_get
+        curl.should_receive(:body_str).and_return('gem')
+        described_class.download_gem('polisher', '1.1').should == 'gem'
+      end
+    end
+
+    describe "::from_rubygems" do
+      it "downloads gem" do
+        described_class.should_receive(:download_gem)
+                       .with('polisher', '0.9')
+                       .at_least(:once)
+        described_class.should_receive(:from_gem)
+        described_class.from_rubygems('polisher', '0.9')
+      end
+
+      it "returns instantiated gem" do
+        described_class.should_receive(:download_gem)
+                       .at_least(:once)
+        gem = described_class.new
+        described_class.should_receive(:from_gem)
+                       .with(described_class.downloaded_gem_path('polisher', '0.9'))
+                       .and_return(gem)
+        described_class.from_rubygems('polisher', '0.9').should == gem
+      end
+    end
+
+    describe "::download_gem_path" do
+      it "downloads gem" do
+        gem = described_class.new
+        described_class.should_receive(:download_gem)
+        gem.downloaded_gem_path
+      end
+
+      it "returns gem cache path for gem" do
+        # stub out d/l
+        gem = described_class.new :name => 'rails', :version => '1.0'
+        described_class.should_receive(:download_gem)
+        Polisher::GemCache.should_receive(:path_for)
+                          .with('rails', '1.0')
+                          .at_least(:once)
+                          .and_return('rails_path')
+        gem.downloaded_gem_path.should == 'rails_path'
+      end
+    end
+
+    describe "::retrieve" do
+      it "returns gem retrieved from rubygems" do
+        curl = Curl::Easy.new
+        curl.should_receive(:body_str).and_return('spec')
+
+        url = "https://rubygems.org/api/v1/gems/rails.json"
+        Curl::Easy.should_receive(:http_get).with(url).and_return(curl)
+
+        gem = described_class.new
+        described_class.should_receive(:parse).with('spec').and_return(gem)
+
+        described_class.retrieve('rails').should == gem
+      end
+    end
+
+    describe "#download_gem" do
+      it "downloads gem specified by attributes" do
+        described_class.should_receive(:download_gem)
+                       .with('polisher', '0.8')
+        described_class.new(:name => 'polisher', :version => '0.8').download_gem
+      end
+    end
+
+    describe "#download_gem_path" do
+      it "returns path of gem specified by attributes" do
+        described_class.should_receive(:downloaded_gem_path)
+                       .with('polisher', '0.8')
+        described_class.new(:name => 'polisher', :version => '0.8').downloaded_gem_path
+      end
+    end
+  end # describe Gem
+end # module Polisher

data/spec/gem/state_spec.rb

@@ -0,0 +1,79 @@
+#
+# Licensed under the MIT license
+# Copyright (C) 2013-2014 Red Hat, Inc.
+
+require 'polisher/gem'
+
+module Polisher
+  describe Gem do
+    describe "#koji_tags" do
+      it "returns hash of configured koji tags to versions of gem in them"
+    end
+
+    describe "#koji_state" do
+      context "koji_tags are empty" do
+        it "returns :missing"
+      end
+
+      context "no dependency check specified" do
+        it "returns :available"
+      end
+
+      context "version in koji tag matches dependency check" do
+        it "returns available"
+      end
+
+      context "dependency check is not satisfied" do
+        it "returns missing"
+      end
+    end
+
+    describe "#distgit" do
+      it "return distgit package for gem"
+    end
+
+    describe "#distgit_branches" do
+      it "maps koji tags to distgit branches and returns"
+
+      context "koji tags are empty" do
+        it "returns valid distgit branches"
+      end
+
+      context "no corresponding distgit branches to koji tags" do
+        it "returns valid distgit branches"
+      end
+    end
+
+    describe "#distgit_versions" do
+      it "returns versions of specs in distgit branches"
+    end
+
+    describe "#distgit_state" do
+      it "clones distgit repo"
+
+      context "error cloning repo" do
+        it "returns :missing_repo"
+      end
+
+      context "valid_branches are empty" do
+        it "returns :missing_branch"
+      end
+
+      context "distgit_versions are empty" do
+        it "returns :missing_spec"
+      end
+
+      context "dependency check not specified" do
+        it "returns :available"
+      end
+
+      context "version in distgit matches dependency check" do
+        it "returns :available"
+      end
+
+      context "dependency check not satisfieid" do
+        it "returns :missing"
+      end
+    end
+  end # describe Gem
+end # module Polisher

data/spec/gem/versions_spec.rb

@@ -0,0 +1,148 @@
+#
+# Licensed under the MIT license
+# Copyright (C) 2013-2014 Red Hat, Inc.
+
+require 'polisher/gem'
+
+module Polisher
+  describe Gem do
+    describe "::local_versions_for" do
+      before(:each) do
+        # XXX clear the cached version of the gem specification db
+        described_class.instance_variable_set(:@local_db, nil)
+
+        gem1 = ::Gem::Specification.new 'rake', '1.0'
+        gem2 = ::Gem::Specification.new 'rake', '2.0'
+        gem3 = ::Gem::Specification.new 'rails', '3.0'
+        ::Gem::Specification.should_receive(:all).and_return([gem1, gem2, gem3])
+
+        @version1 = ::Gem::Version.new '1.0'
+        @version2 = ::Gem::Version.new '2.0'
+      end
+
+      it "returns versions of specified gem in local db" do
+        described_class.local_versions_for('rake').should == [@version1, @version2]
+      end
+
+      it "invokes cb with versions retrieved" do
+        cb = proc {}
+        cb.should_receive(:call).with(:local_gem, 'rake', [@version1, @version2])
+        described_class.local_versions_for('rake', &cb)
+      end
+    end
+
+    describe "::remote_versions_for" do
+      it "retrieves versions from rubygems.org" do
+        curl = Curl::Easy.new
+        described_class.should_receive(:client)
+                       .at_least(:once).and_return(curl)
+        curl.should_receive(:http_get)
+
+        # actual output too verbose, just including bits we need
+        curl.should_receive(:body_str)
+            .and_return([{'number' => 1.1}, {'number' => 2.2}].to_json)
+        described_class.remote_versions_for('polisher').should == [1.1, 2.2]
+        curl.url.should == "https://rubygems.org/api/v1/versions/polisher.json"
+      end
+    end
+
+    describe "::lastest_version_of" do
+      it "retrieves latests version of gem available on rubygems.org" do
+        described_class.should_receive(:remote_versions_for)
+                       .with('polisher')
+                       .and_return(['2.2', '1.1'])
+        described_class.latest_version_of('polisher').should == '2.2'
+      end
+    end
+
+    describe "#versions" do
+      it "looks up and returns versions of gem" do
+        gem = described_class.new :name => 'rails'
+        Polisher::VersionChecker.should_receive(:versions_for)
+                                .with('rails')
+                                .and_return(:koji => ['1.1.1'])
+        gem.versions.should == {'rails' => {:koji => ['1.1.1']}}
+      end
+
+      context "recursive is true" do
+        it "retrieves dependency versions" do
+          # stub out version checker
+          retrieved = {:koji => ['1.0']}
+          Polisher::VersionChecker.should_receive(:versions_for)
+                                  .and_return(retrieved)
+
+          versions = {}
+          gem = described_class.new :name => 'rails'
+          gem.should_receive(:dependency_versions)
+             .with(:recursive => true, :versions => {'rails' => retrieved})
+             .and_call_original
+          gem.versions(:recursive => true, :versions => versions)
+             .should == {'rails' => {:koji => ['1.0']}}
+        end
+
+        context "dev_deps is true" do
+          it "retrieves dev dependency versions" do
+            # stub out version checker
+            retrieved = {:koji => ['1.0']}
+            Polisher::VersionChecker.should_receive(:versions_for)
+                                    .and_return(retrieved)
+
+            versions = {}
+            gem = described_class.new :name => 'rails'
+            gem.should_receive(:dependency_versions)
+               .with(:recursive => true, :dev_deps => true,
+                      :versions => {'rails' => retrieved})
+               .and_call_original
+            gem.should_receive(:dependency_versions)
+               .with(:recursive => true, :dev => true, :dev_deps => true,
+                      :versions => {'rails' => retrieved})
+               .and_call_original
+            gem.versions(:recursive => true, :dev_deps => true,
+                         :versions => versions)
+               .should == {'rails' => {:koji => ['1.0']}}
+          end
+        end
+      end
+    end
+
+    describe "#dependency_versions" do
+      it "retrieves dependency versions" do
+        gem = described_class.new
+        gem.should_receive(:deps).and_return([::Gem::Dependency.new('rake')])
+        described_class.should_receive(:retrieve)
+                       .with('rake').and_return(gem)
+
+        versions = {'rake' => {:koji => ['2.1']}}
+        gem.should_receive(:versions).and_return(versions)
+        gem.dependency_versions.should == versions
+      end
+
+      it "retrieves dev dependency versions" do
+        gem = described_class.new
+        gem.should_receive(:dev_deps).and_return([::Gem::Dependency.new('rake')])
+        described_class.should_receive(:retrieve)
+                       .with('rake').and_return(gem)
+
+        versions = {'rake' => {:koji => ['2.1']}}
+        gem.should_receive(:versions).and_return(versions)
+        gem.dependency_versions(:dev => true).should == versions
+      end
+
+      context "error during gem or version retrieval" do
+        it "sets version to 'unknown'" do
+          gem = described_class.new
+          gem.should_receive(:deps).and_return([::Gem::Dependency.new('rake')])
+          described_class.should_receive(:retrieve)
+                         .with('rake').and_raise(RuntimeError)
+
+          versions = {:all => [:unknown]}
+          gem.should_not_receive(:versions)
+          Polisher::VersionChecker.should_receive(:unknown_version)
+                                  .with(:all, 'rake')
+                                  .and_return(versions)
+          gem.dependency_versions.should == {'rake' => versions}
+        end
+      end
+    end
+  end # describe Gem
+end # module Polisher