polisher 0.10.2 → 0.11.1

data/spec/data/rubygem-activesupport.spec

@@ -114,125 +114,3 @@ popd
 
 * Tue Mar 19 2013 Vít Ondruch <vondruch@redhat.com> - 1:3.2.13-1
 - Update to ActiveSupport 3.2.13.
-
-* Fri Mar 01 2013 Vít Ondruch <vondruch@redhat.com> - 1:3.2.12-2
-- Rebuild for https://fedoraproject.org/wiki/Features/Ruby_2.0.0
-
-* Tue Feb 12 2013 Vít Ondruch <vondruch@redhat.com> - 1:3.2.12-1
-- Update to ActiveSupport 3.2.12.
-
-* Wed Jan 09 2013 Vít Ondruch <vondruch@redhat.com> - 1:3.2.11-1
-- Update to ActiveSupport 3.2.11.
-
-* Thu Jan 03 2013 Vít Ondruch <vondruch@redhat.com> - 1:3.2.10-1
-- Update to ActiveSupport 3.2.10.
-
-* Mon Aug 13 2012 Vít Ondruch <vondruch@redhat.com> - 1:3.2.8-1
-- Update to ActiveSupport 3.2.8.
-
-* Mon Jul 30 2012 Vít Ondruch <vondruch@redhat.com> - 1:3.2.7-1
-- Update to ActiveSupport 3.2.7.
-
-* Wed Jul 18 2012 Bohuslav Kabrda <bkabrda@redhat.com> - 1:3.2.6-1
-- Update to ActiveSupport 3.2.6.
-- Removed unneeded BuildRoot tag.
-- Tests no longer fail with newer versions of Mocha, remove workaround.
-
-* Fri Jun 15 2012 Vít Ondruch <vondruch@redhat.com> - 1:3.0.15-1
-- Update to ActiveSupport 3.0.15.
-
-* Fri Jun 01 2012 Vít Ondruch <vondruch@redhat.com> - 1:3.0.13-1
-- Update to ActiveSupport 3.0.13.
-
-* Wed Apr 18 2012 Bohuslav Kabrda <bkabrda@redhat.com> - 1:3.0.11-5
-- Add the bigdecimal dependency to gemspec.
-
-* Fri Mar 16 2012 Bohuslav Kabrda <bkabrda@redhat.com> - 1:3.0.11-4
-- The CVE patch name now contains the CVE id.
-
-* Mon Mar 05 2012 Bohuslav Kabrda <bkabrda@redhat.com> - 1:3.0.11-3
-- Patch for CVE-2012-1098
-
-* Tue Jan 24 2012 Bohuslav Kabrda <bkabrda@redhat.com> - 1:3.0.11-1
-- Rebuilt for Ruby 1.9.3.
-- Update to ActiveSupport 3.0.11.
-
-* Mon Aug 22 2011 Vít Ondruch <vondruch@redhat.com> - 1:3.0.10-1
-- Update to ActiveSupport 3.0.10
-
-* Fri Jul 01 2011 Vít Ondruch <vondruch@redhat.com> - 1:3.0.9-1
-- Update to ActiveSupport 3.0.9
-- Changed %%define into %%global
-- Removed unnecessary %%clean section
-
-* Thu Jun 16 2011 Mo Morsi <mmorsi@redhat.com> - 1:3.0.5-3
-- Reverting accidental change adding a few gem flags
-
-* Thu Jun 16 2011 Mo Morsi <mmorsi@redhat.com> - 1:3.0.5-2
-- Include fix for CVE-2011-2197
-
-* Thu Mar 24 2011 Vít Ondruch <vondruch@redhat.com> - 1:3.0.5-1
-- Update to ActiveSupport 3.0.5
-- Remove Rake dependnecy
-
-* Mon Feb 14 2011 Mohammed Morsi <mmorsi@redhat.com> - 1:3.0.3-4
-- fix bad dates in the spec changelog
-
-* Thu Feb 10 2011 Mohammed Morsi <mmorsi@redhat.com> - 1:3.0.3-3
-- include i18n runtime dependency
-
-* Wed Feb 09 2011 Fedora Release Engineering <rel-eng@lists.fedoraproject.org> - 1:3.0.3-2
-- Rebuilt for https://fedoraproject.org/wiki/Fedora_15_Mass_Rebuild
-
-* Mon Jan 10 2011 Mohammed Morsi <mmorsi@redhat.com> - 1:3.0.3-1
-- update to rails 3
-
-* Wed Aug 25 2010 Mohammed Morsi <mmorsi@redhat.com> - 1:2.3.8-2
-- bumped version
-
-* Wed Aug 04 2010 Mohammed Morsi <mmorsi@redhat.com> - 1:2.3.8-1
-- Update to 2.3.8
-- Added check section with rubygem-mocha dependency
-- Added upsteam Rakefile and test suite to run tests
-
-* Thu Jan 28 2010 Mamoru Tasaka <mtasaka@ioa.s.u-tokyo.ac.jp> - 1:2.3.5-1
-- Update to 2.3.5
-
-* Wed Oct  7 2009 David Lutterkort <lutter@redhat.com> - 1:2.3.4-2
-- Bump Epoch to ensure upgrade path from F-11
-
-* Mon Sep 7 2009 Mamoru Tasaka <mtasaka@ioa.s.u-tokyo.ac.jp> - 2.3.4-1
-- Update to 2.3.4 (bug 520843, CVE-2009-3009)
-
-* Sun Jul 26 2009 Jeroen van Meeuwen <j.van.meeuwen@ogd.nl> - 2.3.3-1
-- New upstream version
-
-* Mon Mar 16 2009 Jeroen van Meeuwen <kanarip@fedoraproject.org> - 2.3.2-1
-- New upstream version
-
-* Wed Feb 25 2009 Fedora Release Engineering <rel-eng@lists.fedoraproject.org> - 2.2.2-2
-- Rebuilt for https://fedoraproject.org/wiki/Fedora_11_Mass_Rebuild
-
-* Mon Nov 24 2008 Jeroen van Meeuwen <kanarip@fedoraproject.org> - 2.2.2-1
-- New upstream version
-
-* Tue Sep 16 2008 David Lutterkort <dlutter@redhat.com> - 2.1.1-1
-- New version (fixes CVE-2008-4094)
-
-* Thu Jul 31 2008 Michael Stahnke <stahnma@fedoraproject.org> - 2.1.0-1
-- New Upstream
-
-* Mon Apr 07 2008 David Lutterkort <dlutter@redhat.com> - 2.0.2-1
-- New version
-
-* Mon Dec 10 2007 David Lutterkort <dlutter@redhat.com> - 2.0.1-1
-- New version
-
-* Wed Nov 28 2007 David Lutterkort <dlutter@redhat.com> - 1.4.4-3
-- Fix buildroot
-
-* Tue Nov 13 2007 David Lutterkort <dlutter@redhat.com> - 1.4.4-2
-- Install README and CHANGELOG in _docdir
-
-* Tue Oct 30 2007 David Lutterkort <dlutter@redhat.com> - 1.4.4-1
-- Initial package

data/spec/fixtures/gem_json.rb

@@ -0,0 +1,49 @@
+module Polisher
+  module Test
+    module Fixtures
+      class GemJson
+        def url
+          @url ||="https://rubygems.org/api/v1/gems/rails.json"
+        end
+
+        def json_path
+          @json_path ||= "#{data_dir}/rails.json"
+        end
+
+        def json
+          @json ||= File.read(json_path)
+        end
+
+        def name
+          @name ||= 'rails'
+        end
+
+        def version
+          @version ||= '4.0.1'
+        end
+
+        def deps
+          @deps ||= [::Gem::Dependency.new("actionmailer", '= 4.0.1'),
+                     ::Gem::Dependency.new("actionpack", '= 4.0.1'),
+                     ::Gem::Dependency.new("activerecord", '= 4.0.1'),
+                     ::Gem::Dependency.new("activesupport", '= 4.0.1'),
+                     ::Gem::Dependency.new("bundler", "< 2.0", ">= 1.3.0"),
+                     ::Gem::Dependency.new("railties", '= 4.0.1'),
+                     ::Gem::Dependency.new("sprockets-rails", '~> 2.0.0')]
+        end
+
+        def dev_deps
+          @dev_deps ||= []
+        end
+
+        def [](key)
+          self.send(key.intern)
+        end
+      end # class GemJson
+    end # module Fixtures
+
+    def gem_json
+      @gem_json ||= Fixtures::GemJson.new
+    end
+  end # module Test
+end # module Polisher

data/spec/fixtures/gem_spec.rb

@@ -0,0 +1,13 @@
+module Polisher
+  module Test
+    GEM_SPEC = {
+      :path     => "#{data_dir}/mysql-2.9.1.gemspec",
+      :name     => 'mysql',
+      :version  => '2.9.1',
+      :deps     => [],
+      :dev_deps => [::Gem::Dependency.new('rdoc', '~> 3.10', :development),
+                    ::Gem::Dependency.new('rake-compiler', '~> 0.8.1', :development),
+                    ::Gem::Dependency.new('hoe', '~> 3.5', :development)]
+    }
+  end # module Test
+end # module Polisher

data/spec/fixtures/gemfile.rb

@@ -0,0 +1,10 @@
+module Polisher
+  module Test
+    GEMFILE = {
+      :path     => "#{data_dir}/Gemfile",
+      :contents => File.read("#{data_dir}/Gemfile"),
+      :deps     => [::Gem::Dependency.new("rubygems", ::Gem::Requirement.new([">= 0"]), :runtime),
+                    ::Gem::Dependency.new("cinch", ::Gem::Requirement.new([">= 0"]), :runtime)]
+    }
+  end # module Test
+end # module Polisher

data/spec/fixtures/local_gem.rb

@@ -0,0 +1,62 @@
+module Polisher
+  module Test
+    module Fixtures
+      class LocalGem
+        def name
+          @name ||= 'rspec'
+        end
+
+        def version
+          @version ||= '2.12.0'
+        end
+
+        def json_url
+          @json_url ||= "https://rubygems.org/api/v1/gems/#{name}.json"
+        end
+
+        def json_path
+          @json_path ||= "#{data_dir}/#{name}.json"
+        end
+
+        def json
+          @json ||= File.read(json_path)
+        end
+
+        def gem_path
+          @gem_contents_path ||= "#{data_dir}/#{name}-#{version}.gem"
+        end
+
+        def gem
+          @gem ||= File.read(local_gem_contents_path)
+        end
+
+        def url
+          @gem_url ||= "https://rubygems.org/gems/#{name}-#{version}.gem"
+        end
+
+        def deps
+          @deps ||= [::Gem::Dependency.new('rspec-core',         '~> 2.14.0'),
+                     ::Gem::Dependency.new('rspec-expectations', '~> 2.14.0'),
+                     ::Gem::Dependency.new('rspec-mocks',        '~> 2.14.0')]
+        end
+
+        def dev_deps
+          @dev_deps ||= []
+        end
+
+        def files
+          @files ||= ['License.txt', 'README.md', 'lib', 'lib/rspec',
+                      'lib/rspec/version.rb', 'lib/rspec.rb']
+        end
+
+        def [](key)
+          self.send(key.intern)
+        end
+      end # class LocalGem
+    end # module Fixtures
+
+    def local_gem
+      @local_gem ||= Fixtures::LocalGem.new
+    end
+  end # module Test
+end # module Polisher

data/spec/fixtures/rpm_spec.rb

@@ -0,0 +1,91 @@
+require 'polisher/rpm/requirement'
+
+module Polisher
+  module Test
+    module Fixtures
+      class RpmSpec
+        def path
+          @path ||= "#{data_dir}/rubygem-activesupport.spec"
+        end
+
+        def contents
+          @contents ||= File.read(path)
+        end
+
+        def name
+          @name ||= "activesupport"
+        end
+
+        def version
+          @version ||= "4.0.0"
+        end
+
+        def release
+          @release ||= "1%{?dist}"
+        end
+
+        def requires
+          @requires ||= [Polisher::RPM::Requirement.parse("ruby(rubygems)"),
+                         Polisher::RPM::Requirement.parse("ruby(release)"), 
+                         Polisher::RPM::Requirement.parse("rubygem(bigdecimal)"),
+                         Polisher::RPM::Requirement.parse("rubygem(dalli)"),
+                         Polisher::RPM::Requirement.parse("rubygem(i18n) >= 0.6"),
+                         Polisher::RPM::Requirement.parse("rubygem(i18n) < 1.0"),
+                         Polisher::RPM::Requirement.parse("rubygem(minitest) >= 4.2"),
+                         Polisher::RPM::Requirement.parse("rubygem(minitest) < 5"),
+                         Polisher::RPM::Requirement.parse("rubygem(multi_json) >= 1.0"),
+                         Polisher::RPM::Requirement.parse("rubygem(multi_json) < 2"),
+                         Polisher::RPM::Requirement.parse("rubygem(rack)"),
+                         Polisher::RPM::Requirement.parse("rubygem(thread_safe)"),
+                         Polisher::RPM::Requirement.parse("rubygem(tzinfo) >= 0.3.37"),
+                         Polisher::RPM::Requirement.parse("rubygem(tzinfo) < 0.4.0")]
+        end
+
+        def build_requires
+          @build_requires ||= [Polisher::RPM::Requirement.parse("rubygems-devel"),
+                               Polisher::RPM::Requirement.parse("rubygem(bigdecimal)"),
+                               Polisher::RPM::Requirement.parse("rubygem(builder)"),
+                               Polisher::RPM::Requirement.parse("rubygem(dalli)"),
+                               Polisher::RPM::Requirement.parse("rubygem(i18n) >= 0.6"),
+                               Polisher::RPM::Requirement.parse("rubygem(i18n) < 1.0"),
+                               Polisher::RPM::Requirement.parse("rubygem(minitest)"),
+                               Polisher::RPM::Requirement.parse("rubygem(mocha)"),
+                               Polisher::RPM::Requirement.parse("rubygem(multi_json) >= 1.0"),
+                               Polisher::RPM::Requirement.parse("rubygem(multi_json) < 2"),
+                               Polisher::RPM::Requirement.parse("rubygem(rack)"),
+                               Polisher::RPM::Requirement.parse("rubygem(thread_safe)"),
+                               Polisher::RPM::Requirement.parse("rubygem(tzinfo) >= 0.3.37"),
+                               Polisher::RPM::Requirement.parse("rubygem(tzinfo) < 0.4.0")]
+        end
+
+        def changelog
+          @changelog ||= <<EOS
+* Fri Aug 09 2013 Josef Stribny <jstribny@redhat.com> - 1:4.0.0-2
+- Fix: add minitest to requires
+
+* Tue Jul 30 2013 Josef Stribny <jstribny@redhat.com> - 1:4.0.0-1
+- Update to ActiveSupport 4.0.0.
+
+* Tue Mar 19 2013 Vít Ondruch <vondruch@redhat.com> - 1:3.2.13-1
+- Update to ActiveSupport 3.2.13.
+EOS
+        end
+
+        def files
+          @files ||= {"activesupport" => ["%dir %{gem_instdir}", "%doc %{gem_instdir}/CHANGELOG.md",
+                                          "%{gem_libdir}", "%doc %{gem_instdir}/MIT-LICENSE",
+                                          "%doc %{gem_instdir}/README.rdoc", "%doc %{gem_docdir}",
+                                          "%{gem_cache}", "%{gem_spec}", "%{gem_instdir}/test"]}
+        end
+
+        def [](key)
+          self.send(key.intern)
+        end
+      end # class RpmSpec
+    end # module Fixtures
+
+    def rpm_spec
+      @rpm_spec ||= Fixtures::RpmSpec.new
+    end
+  end # module Test
+end # module Polisher

data/spec/gem/attributes_spec.rb

@@ -0,0 +1,17 @@
+#
+# Licensed under the MIT license
+# Copyright (C) 2013-2014 Red Hat, Inc.
+
+require 'polisher/gem'
+
+module Polisher
+  describe Gem do
+    describe "#file_name" do
+      it "returns name-version.gem" do
+        expected = 'rails-4.0.0.gem'
+        Polisher::Gem.new(:name => 'rails', :version => '4.0.0')
+                     .file_name.should == expected
+      end
+    end
+  end # describe Gem
+end # module Polisher

data/spec/gem/diff_spec.rb

@@ -0,0 +1,80 @@
+#
+# Licensed under the MIT license
+# Copyright (C) 2013-2014 Red Hat, Inc.
+
+require 'polisher/gem'
+require 'polisher/git/repo'
+require 'awesome_spawn'
+
+module Polisher
+  describe Gem do
+    describe "#diff" do
+      before(:each) do
+        @gem1 = described_class.new
+        @gem2 = described_class.new
+        @repo = Polisher::Git::Repo.new
+        @result = AwesomeSpawn::CommandResult.new '', 'diff_out', '', 0
+      end
+
+      it "requires awesome_spawn dependency" do
+        @gem1.should_receive(:require_dep!).with('awesome_spawn')
+        @gem1.diff(@gem2)
+      end
+
+      it "requires diff cmd" do
+        @gem1.should_receive(:require_cmd!).with(@gem1.diff_cmd)
+        @gem1.diff(@gem2)
+      end
+
+      it "runs diff against unpacked local and other gems and returns output" do
+        @gem1.should_receive(:unpack).and_return('dir1')
+        @gem2.should_receive(:unpack).and_return('dir2')
+        AwesomeSpawn.should_receive(:run)
+          .with("#{Polisher::Gem.diff_cmd} -r dir1 dir2")
+          .and_return(@result)
+        @gem1.diff(@gem2).should == @result.output
+      end
+
+      it "runs diff against unpacked local gem and git repo and returns output" do
+        @gem1.should_receive(:unpack).and_return('dir1')
+        @repo.should_receive(:path).and_return('dir2')
+        AwesomeSpawn.should_receive(:run)
+          .with("#{Polisher::Gem.diff_cmd} -r dir1 dir2")
+          .and_return(@result)
+        @gem1.diff(@repo).should == @result.output
+      end
+
+      it "replaces directories in output" do
+        @gem1.should_receive(:unpack).and_return('dir1')
+        @gem2.should_receive(:unpack).and_return('dir2')
+        @result = AwesomeSpawn::CommandResult.new '', 'dir1Adir2B', '', 0
+        AwesomeSpawn.should_receive(:run).and_return(@result)
+        @gem1.diff(@gem2).should == 'aAbB'
+      end
+
+      it "removes unpacked gem dirs" do
+        @gem1.should_receive(:unpack).and_return('dir1')
+        @gem2.should_receive(:unpack).and_return('dir2')
+        AwesomeSpawn.should_receive(:run).and_return(@result)
+        FileUtils.should_receive(:rm_rf).with('dir1')
+        FileUtils.should_receive(:rm_rf).with('dir2')
+        # XXX for the GemCache dir cleaning:
+        FileUtils.should_receive(:rm_rf).at_least(:once)
+        @gem1.diff(@gem2)
+      end
+
+      context "error during operations" do
+        it "removes unpacked gem dirs" do
+          @gem1.should_receive(:unpack).and_return('dir1')
+          @gem2.should_receive(:unpack).and_return('dir2')
+          AwesomeSpawn.should_receive(:run).
+            and_raise(AwesomeSpawn::CommandResultError.new('', ''))
+          FileUtils.should_receive(:rm_rf).with('dir1')
+          FileUtils.should_receive(:rm_rf).with('dir2')
+          FileUtils.should_receive(:rm_rf).at_least(:once)
+          @gem1.diff(@gem2)
+        end
+      end
+    end
+  end # describe Gem
+end # module Polisher