paperclip-fix 4.3.7

data/spec/paperclip/thumbnail_spec.rb

@@ -0,0 +1,500 @@
+require 'spec_helper'
+
+describe Paperclip::Thumbnail do
+  context "A Paperclip Tempfile" do
+    before do
+      @tempfile = Paperclip::Tempfile.new(["file", ".jpg"])
+    end
+
+    after { @tempfile.close }
+
+    it "has its path contain a real extension" do
+      assert_equal ".jpg", File.extname(@tempfile.path)
+    end
+
+    it "is a real Tempfile" do
+      assert @tempfile.is_a?(::Tempfile)
+    end
+  end
+
+  context "Another Paperclip Tempfile" do
+    before do
+      @tempfile = Paperclip::Tempfile.new("file")
+    end
+
+    after { @tempfile.close }
+
+    it "does not have an extension if not given one" do
+      assert_equal "", File.extname(@tempfile.path)
+    end
+
+    it "is a real Tempfile" do
+      assert @tempfile.is_a?(::Tempfile)
+    end
+  end
+
+  context "An image" do
+    before do
+      @file = File.new(fixture_file("5k.png"), 'rb')
+    end
+
+    after { @file.close }
+
+    [["600x600>", "434x66"],
+     ["400x400>", "400x61"],
+     ["32x32<", "434x66"],
+     [nil, "434x66"]
+    ].each do |args|
+      context "being thumbnailed with a geometry of #{args[0]}" do
+        before do
+          @thumb = Paperclip::Thumbnail.new(@file, geometry: args[0])
+        end
+
+        it "starts with dimensions of 434x66" do
+          cmd = %Q[identify -format "%wx%h" "#{@file.path}"]
+          assert_equal "434x66", `#{cmd}`.chomp
+        end
+
+        it "reports the correct target geometry" do
+          assert_equal args[0].to_s, @thumb.target_geometry.to_s
+        end
+
+        context "when made" do
+          before do
+            @thumb_result = @thumb.make
+          end
+
+          it "is the size we expect it to be" do
+            cmd = %Q[identify -format "%wx%h" "#{@thumb_result.path}"]
+            assert_equal args[1], `#{cmd}`.chomp
+          end
+        end
+      end
+    end
+
+    context "being thumbnailed at 100x50 with cropping" do
+      before do
+        @thumb = Paperclip::Thumbnail.new(@file, geometry: "100x50#")
+      end
+
+      it "lets us know when a command isn't found versus a processing error" do
+        old_path = ENV['PATH']
+        begin
+          Cocaine::CommandLine.path = ''
+          Paperclip.options[:command_path] = ''
+          ENV['PATH'] = ''
+          assert_raises(Paperclip::Errors::CommandNotFoundError) do
+            silence_stream(STDERR) do
+              @thumb.make
+            end
+          end
+        ensure
+          ENV['PATH'] = old_path
+        end
+      end
+
+      it "reports its correct current and target geometries" do
+        assert_equal "100x50#", @thumb.target_geometry.to_s
+        assert_equal "434x66", @thumb.current_geometry.to_s
+      end
+
+      it "reports its correct format" do
+        assert_nil @thumb.format
+      end
+
+      it "has whiny turned on by default" do
+        assert @thumb.whiny
+      end
+
+      it "has convert_options set to nil by default" do
+        assert_equal nil, @thumb.convert_options
+      end
+
+      it "has source_file_options set to nil by default" do
+        assert_equal nil, @thumb.source_file_options
+      end
+
+      it "sends the right command to convert when sent #make" do
+        @thumb.expects(:convert).with do |*arg|
+          arg[0] == ':source -auto-orient -resize "x50" -crop "100x50+114+0" +repage :dest' &&
+          arg[1][:source] == "#{File.expand_path(@thumb.file.path)}[0]"
+        end
+        @thumb.make
+      end
+
+      it "creates the thumbnail when sent #make" do
+        dst = @thumb.make
+        assert_match /100x50/, `identify "#{dst.path}"`
+      end
+    end
+
+    it 'crops a EXIF-rotated image properly' do
+      file = File.new(fixture_file('rotated.jpg'))
+      thumb = Paperclip::Thumbnail.new(file, geometry: "50x50#")
+
+      output_file = thumb.make
+
+      command = Cocaine::CommandLine.new("identify", "-format %wx%h :file")
+      assert_equal "50x50", command.run(file: output_file.path).strip
+    end
+
+    context "being thumbnailed with source file options set" do
+      before do
+        @thumb = Paperclip::Thumbnail.new(@file,
+                                          geometry: "100x50#",
+                                          source_file_options: "-strip")
+      end
+
+      it "has source_file_options value set" do
+        assert_equal ["-strip"], @thumb.source_file_options
+      end
+
+      it "sends the right command to convert when sent #make" do
+        @thumb.expects(:convert).with do |*arg|
+          arg[0] == '-strip :source -auto-orient -resize "x50" -crop "100x50+114+0" +repage :dest' &&
+          arg[1][:source] == "#{File.expand_path(@thumb.file.path)}[0]"
+        end
+        @thumb.make
+      end
+
+      it "creates the thumbnail when sent #make" do
+        dst = @thumb.make
+        assert_match /100x50/, `identify "#{dst.path}"`
+      end
+
+      context "redefined to have bad source_file_options setting" do
+        before do
+          @thumb = Paperclip::Thumbnail.new(@file,
+                                            geometry: "100x50#",
+                                            source_file_options: "-this-aint-no-option")
+        end
+
+        it "errors when trying to create the thumbnail" do
+          assert_raises(Paperclip::Error) do
+            silence_stream(STDERR) do
+              @thumb.make
+            end
+          end
+        end
+      end
+    end
+
+    context "being thumbnailed with convert options set" do
+      before do
+        @thumb = Paperclip::Thumbnail.new(@file,
+                                          geometry: "100x50#",
+                                          convert_options: "-strip -depth 8")
+      end
+
+      it "has convert_options value set" do
+        assert_equal %w"-strip -depth 8", @thumb.convert_options
+      end
+
+      it "sends the right command to convert when sent #make" do
+        @thumb.expects(:convert).with do |*arg|
+          arg[0] == ':source -auto-orient -resize "x50" -crop "100x50+114+0" +repage -strip -depth 8 :dest' &&
+          arg[1][:source] == "#{File.expand_path(@thumb.file.path)}[0]"
+        end
+        @thumb.make
+      end
+
+      it "creates the thumbnail when sent #make" do
+        dst = @thumb.make
+        assert_match /100x50/, `identify "#{dst.path}"`
+      end
+
+      context "redefined to have bad convert_options setting" do
+        before do
+          @thumb = Paperclip::Thumbnail.new(@file,
+                                            geometry: "100x50#",
+                                            convert_options: "-this-aint-no-option")
+        end
+
+        it "errors when trying to create the thumbnail" do
+          assert_raises(Paperclip::Error) do
+            silence_stream(STDERR) do
+              @thumb.make
+            end
+          end
+        end
+
+        it "lets us know when a command isn't found versus a processing error" do
+          old_path = ENV['PATH']
+          begin
+            Cocaine::CommandLine.path = ''
+            Paperclip.options[:command_path] = ''
+            ENV['PATH'] = ''
+            assert_raises(Paperclip::Errors::CommandNotFoundError) do
+              silence_stream(STDERR) do
+                @thumb.make
+              end
+            end
+          ensure
+            ENV['PATH'] = old_path
+          end
+        end
+      end
+    end
+
+    context "being thumbnailed with a blank geometry string" do
+      before do
+        @thumb = Paperclip::Thumbnail.new(@file,
+                                          geometry: "",
+                                          convert_options: "-gravity center -crop \"300x300+0-0\"")
+      end
+
+      it "does not get resized by default" do
+        assert !@thumb.transformation_command.include?("-resize")
+      end
+    end
+
+    context "being thumbnailed with default animated option (true)" do
+      it "calls identify to check for animated images when sent #make" do
+        thumb = Paperclip::Thumbnail.new(@file, geometry: "100x50#")
+        thumb.expects(:identify).at_least_once.with do |*arg|
+          arg[0] == '-format %m :file' &&
+          arg[1][:file] == "#{File.expand_path(thumb.file.path)}[0]"
+        end
+        thumb.make
+      end
+    end
+
+    context "passing a custom file geometry parser" do
+      after do
+        Object.send(:remove_const, :GeoParser) if Object.const_defined?(:GeoParser)
+      end
+
+      it "produces the appropriate transformation_command" do
+        GeoParser = Class.new do
+          def self.from_file(file)
+            new
+          end
+
+          def transformation_to(target, should_crop)
+            ["SCALE", "CROP"]
+          end
+        end
+
+        thumb = Paperclip::Thumbnail.new(@file, geometry: '50x50', file_geometry_parser: ::GeoParser)
+
+        transformation_command = thumb.transformation_command
+
+        assert transformation_command.include?('-crop'),
+          %{expected #{transformation_command.inspect} to include '-crop'}
+        assert transformation_command.include?('"CROP"'),
+          %{expected #{transformation_command.inspect} to include '"CROP"'}
+        assert transformation_command.include?('-resize'),
+          %{expected #{transformation_command.inspect} to include '-resize'}
+        assert transformation_command.include?('"SCALE"'),
+          %{expected #{transformation_command.inspect} to include '"SCALE"'}
+      end
+    end
+
+    context "passing a custom geometry string parser" do
+      after do
+        Object.send(:remove_const, :GeoParser) if Object.const_defined?(:GeoParser)
+      end
+
+      it "produces the appropriate transformation_command" do
+        GeoParser = Class.new do
+          def self.parse(s)
+            new
+          end
+
+          def to_s
+            "151x167"
+          end
+        end
+
+        thumb = Paperclip::Thumbnail.new(@file, geometry: '50x50', string_geometry_parser: ::GeoParser)
+
+        transformation_command = thumb.transformation_command
+
+        assert transformation_command.include?('"151x167"'),
+          %{expected #{transformation_command.inspect} to include '151x167'}
+      end
+    end
+  end
+
+  context "A multipage PDF" do
+    before do
+      @file = File.new(fixture_file("twopage.pdf"), 'rb')
+    end
+
+    after { @file.close }
+
+    it "starts with two pages with dimensions 612x792" do
+      cmd = %Q[identify -format "%wx%h" "#{@file.path}"]
+      assert_equal "612x792"*2, `#{cmd}`.chomp
+    end
+
+    context "being thumbnailed at 100x100 with cropping" do
+      before do
+        @thumb = Paperclip::Thumbnail.new(@file, geometry: "100x100#", format: :png)
+      end
+
+      it "reports its correct current and target geometries" do
+        assert_equal "100x100#", @thumb.target_geometry.to_s
+        assert_equal "612x792", @thumb.current_geometry.to_s
+      end
+
+      it "reports its correct format" do
+        assert_equal :png, @thumb.format
+      end
+
+      it "creates the thumbnail when sent #make" do
+        dst = @thumb.make
+        assert_match /100x100/, `identify "#{dst.path}"`
+      end
+    end
+  end
+
+  context "An animated gif" do
+    before do
+      @file = File.new(fixture_file("animated.gif"), 'rb')
+    end
+
+    after { @file.close }
+
+    it "starts with 12 frames with size 100x100" do
+      cmd = %Q[identify -format "%wx%h" "#{@file.path}"]
+      assert_equal "100x100"*12, `#{cmd}`.chomp
+    end
+
+    context "with static output" do
+      before do
+       @thumb = Paperclip::Thumbnail.new(@file, geometry: "50x50", format: :jpg)
+      end
+
+      it "creates the single frame thumbnail when sent #make" do
+        dst = @thumb.make
+        cmd = %Q[identify -format "%wx%h" "#{dst.path}"]
+        assert_equal "50x50", `#{cmd}`.chomp
+      end
+    end
+
+    context "with animated output format" do
+      before do
+       @thumb = Paperclip::Thumbnail.new(@file, geometry: "50x50", format: :gif)
+      end
+
+      it "creates the 12 frames thumbnail when sent #make" do
+        dst = @thumb.make
+        cmd = %Q[identify -format "%wx%h," "#{dst.path}"]
+        frames = `#{cmd}`.chomp.split(',')
+        assert_equal 12, frames.size
+        assert_frame_dimensions (45..50), frames
+      end
+
+      it "uses the -coalesce option" do
+        assert_equal @thumb.transformation_command.first, "-coalesce"
+      end
+
+      it "uses the -layers 'optimize' option" do
+        assert_equal @thumb.transformation_command.last, '-layers "optimize"'
+      end
+    end
+
+    context "with omitted output format" do
+      before do
+       @thumb = Paperclip::Thumbnail.new(@file, geometry: "50x50")
+      end
+
+      it "creates the 12 frames thumbnail when sent #make" do
+        dst = @thumb.make
+        cmd = %Q[identify -format "%wx%h," "#{dst.path}"]
+        frames = `#{cmd}`.chomp.split(',')
+        assert_equal 12, frames.size
+        assert_frame_dimensions (45..50), frames
+      end
+
+      it "uses the -coalesce option" do
+        assert_equal @thumb.transformation_command.first, "-coalesce"
+      end
+
+      it "uses the -layers 'optimize' option" do
+        assert_equal @thumb.transformation_command.last, '-layers "optimize"'
+      end
+    end
+
+    context "with unidentified source format" do
+      before do
+        @unidentified_file = File.new(fixture_file("animated.unknown"), 'rb')
+        @thumb = Paperclip::Thumbnail.new(@file, geometry: "60x60")
+      end
+
+      it "creates the 12 frames thumbnail when sent #make" do
+        dst = @thumb.make
+        cmd = %Q[identify -format "%wx%h," "#{dst.path}"]
+        frames = `#{cmd}`.chomp.split(',')
+        assert_equal 12, frames.size
+        assert_frame_dimensions (55..60), frames
+      end
+
+      it "uses the -coalesce option" do
+        assert_equal @thumb.transformation_command.first, "-coalesce"
+      end
+
+      it "uses the -layers 'optimize' option" do
+        assert_equal @thumb.transformation_command.last, '-layers "optimize"'
+      end
+    end
+
+    context "with no source format" do
+      before do
+        @unidentified_file = File.new(fixture_file("animated"), 'rb')
+        @thumb = Paperclip::Thumbnail.new(@file, geometry: "70x70")
+      end
+
+      it "creates the 12 frames thumbnail when sent #make" do
+        dst = @thumb.make
+        cmd = %Q[identify -format "%wx%h," "#{dst.path}"]
+        frames = `#{cmd}`.chomp.split(',')
+        assert_equal 12, frames.size
+        assert_frame_dimensions (60..70), frames
+      end
+
+      it "uses the -coalesce option" do
+        assert_equal @thumb.transformation_command.first, "-coalesce"
+      end
+
+      it "uses the -layers 'optimize' option" do
+        assert_equal @thumb.transformation_command.last, '-layers "optimize"'
+      end
+    end
+
+    context "with animated option set to false" do
+      before do
+       @thumb = Paperclip::Thumbnail.new(@file, geometry: "50x50", animated: false)
+      end
+
+      it "outputs the gif format" do
+        dst = @thumb.make
+        cmd = %Q[identify "#{dst.path}"]
+        assert_match /GIF/, `#{cmd}`.chomp
+      end
+
+      it "creates the single frame thumbnail when sent #make" do
+        dst = @thumb.make
+        cmd = %Q[identify -format "%wx%h" "#{dst.path}"]
+        assert_equal "50x50", `#{cmd}`.chomp
+      end
+    end
+  end
+
+  context "with a really long file name" do
+    before do
+      tempfile = Tempfile.new("f")
+      tempfile_additional_chars = tempfile.path.split("/")[-1].length + 15
+      image_file = File.new(fixture_file("5k.png"), "rb")
+      @file = Tempfile.new("f" * (255 - tempfile_additional_chars))
+      @file.write(image_file.read)
+      @file.rewind
+    end
+
+    it "does not throw Errno::ENAMETOOLONG" do
+      thumb = Paperclip::Thumbnail.new(@file, geometry: "50x50", format: :gif)
+      expect { thumb.make }.to_not raise_error
+    end
+  end
+end

data/spec/paperclip/url_generator_spec.rb

@@ -0,0 +1,211 @@
+# encoding: utf-8
+require 'spec_helper'
+
+describe Paperclip::UrlGenerator do
+  it "uses the given interpolator" do
+    expected = "the expected result"
+    mock_attachment = MockAttachment.new
+    mock_interpolator = MockInterpolator.new(result: expected)
+
+    url_generator = Paperclip::UrlGenerator.new(mock_attachment,
+                                                { interpolator: mock_interpolator })
+    result = url_generator.for(:style_name, {})
+
+    assert_equal expected, result
+    assert mock_interpolator.has_interpolated_attachment?(mock_attachment)
+    assert mock_interpolator.has_interpolated_style_name?(:style_name)
+  end
+
+  it "uses the default URL when no file is assigned" do
+    mock_attachment = MockAttachment.new
+    mock_interpolator = MockInterpolator.new
+    default_url = "the default url"
+    options = { interpolator: mock_interpolator, default_url: default_url}
+
+    url_generator = Paperclip::UrlGenerator.new(mock_attachment, options)
+    url_generator.for(:style_name, {})
+
+    assert mock_interpolator.has_interpolated_pattern?(default_url),
+      "expected the interpolator to be passed #{default_url.inspect} but it wasn't"
+  end
+
+  it "executes the default URL lambda when no file is assigned" do
+    mock_attachment = MockAttachment.new
+    mock_interpolator = MockInterpolator.new
+    default_url = lambda {|attachment| "the #{attachment.class.name} default url" }
+    options = { interpolator: mock_interpolator, default_url: default_url}
+
+    url_generator = Paperclip::UrlGenerator.new(mock_attachment, options)
+    url_generator.for(:style_name, {})
+
+    assert mock_interpolator.has_interpolated_pattern?("the MockAttachment default url"),
+      %{expected the interpolator to be passed "the MockAttachment default url", but it wasn't}
+  end
+
+  it "executes the method named by the symbol as the default URL when no file is assigned" do
+    mock_model = FakeModel.new
+    mock_attachment = MockAttachment.new(model: mock_model)
+    mock_interpolator = MockInterpolator.new
+    default_url = :to_s
+    options = { interpolator: mock_interpolator, default_url: default_url}
+
+    url_generator = Paperclip::UrlGenerator.new(mock_attachment, options)
+    url_generator.for(:style_name, {})
+
+    assert mock_interpolator.has_interpolated_pattern?(mock_model.to_s),
+      %{expected the interpolator to be passed #{mock_model.to_s}, but it wasn't}
+  end
+
+  it "URL-escapes spaces if asked to" do
+    expected = "the expected result"
+    mock_attachment = MockAttachment.new
+    mock_interpolator = MockInterpolator.new(result: expected)
+    options = { interpolator: mock_interpolator }
+    url_generator = Paperclip::UrlGenerator.new(mock_attachment, options)
+
+    result = url_generator.for(:style_name, {escape: true})
+
+    assert_equal "the%20expected%20result", result
+  end
+
+  it "escapes the result of the interpolator using a method on the object, if asked to escape" do
+    expected = Class.new do
+      def escape
+        "the escaped result"
+      end
+    end.new
+    mock_attachment = MockAttachment.new
+    mock_interpolator = MockInterpolator.new(result: expected)
+    options = { interpolator: mock_interpolator }
+    url_generator = Paperclip::UrlGenerator.new(mock_attachment, options)
+
+    result = url_generator.for(:style_name, {escape: true})
+
+    assert_equal "the escaped result", result
+  end
+
+  it "leaves spaces unescaped as asked to" do
+    expected = "the expected result"
+    mock_attachment = MockAttachment.new
+    mock_interpolator = MockInterpolator.new(result: expected)
+    options = { interpolator: mock_interpolator }
+    url_generator = Paperclip::UrlGenerator.new(mock_attachment, options)
+
+    result = url_generator.for(:style_name, {escape: false})
+
+    assert_equal "the expected result", result
+  end
+
+  it "defaults to leaving spaces unescaped" do
+    expected = "the expected result"
+    mock_attachment = MockAttachment.new
+    mock_interpolator = MockInterpolator.new(result: expected)
+    options = { interpolator: mock_interpolator }
+    url_generator = Paperclip::UrlGenerator.new(mock_attachment, options)
+
+    result = url_generator.for(:style_name, {})
+
+    assert_equal "the expected result", result
+  end
+
+  it "produces URLs without the updated_at value when the object does not respond to updated_at" do
+    expected = "the expected result"
+    mock_interpolator = MockInterpolator.new(result: expected)
+    mock_attachment = MockAttachment.new(responds_to_updated_at: false)
+    options = { interpolator: mock_interpolator }
+    url_generator = Paperclip::UrlGenerator.new(mock_attachment, options)
+
+    result = url_generator.for(:style_name, {timestamp: true})
+
+    assert_equal expected, result
+  end
+
+  it "produces URLs without the updated_at value when the updated_at value is nil" do
+    expected = "the expected result"
+    mock_interpolator = MockInterpolator.new(result: expected)
+    mock_attachment = MockAttachment.new(responds_to_updated_at: true, updated_at: nil)
+    options = { interpolator: mock_interpolator }
+    url_generator = Paperclip::UrlGenerator.new(mock_attachment, options)
+
+    result = url_generator.for(:style_name, {timestamp: true})
+
+    assert_equal expected, result
+  end
+
+  it "produces URLs with the updated_at when it exists" do
+    expected = "the expected result"
+    updated_at = 1231231234
+    mock_interpolator = MockInterpolator.new(result: expected)
+    mock_attachment = MockAttachment.new(updated_at: updated_at)
+    options = { interpolator: mock_interpolator }
+    url_generator = Paperclip::UrlGenerator.new(mock_attachment, options)
+
+    result = url_generator.for(:style_name, {timestamp: true})
+
+    assert_equal "#{expected}?#{updated_at}", result
+  end
+
+  it "produces URLs with the updated_at when it exists, separated with a & if a ? follow by = already exists" do
+    expected = "the?expected=result"
+    updated_at = 1231231234
+    mock_interpolator = MockInterpolator.new(result: expected)
+    mock_attachment = MockAttachment.new(updated_at: updated_at)
+    options = { interpolator: mock_interpolator }
+    url_generator = Paperclip::UrlGenerator.new(mock_attachment, options)
+
+    result = url_generator.for(:style_name, {timestamp: true})
+
+    assert_equal "#{expected}&#{updated_at}", result
+  end
+
+  it "produces URLs without the updated_at when told to do as much" do
+    expected = "the expected result"
+    updated_at = 1231231234
+    mock_interpolator = MockInterpolator.new(result: expected)
+    mock_attachment = MockAttachment.new(updated_at: updated_at)
+    options = { interpolator: mock_interpolator }
+    url_generator = Paperclip::UrlGenerator.new(mock_attachment, options)
+
+    result = url_generator.for(:style_name, {timestamp: false})
+
+    assert_equal expected, result
+  end
+
+  it "produces the correct URL when the instance has a file name" do
+    expected = "the expected result"
+    mock_attachment = MockAttachment.new(original_filename: 'exists')
+    mock_interpolator = MockInterpolator.new
+    options = { interpolator: mock_interpolator, url: expected}
+
+    url_generator = Paperclip::UrlGenerator.new(mock_attachment, options)
+    url_generator.for(:style_name, {})
+
+    assert mock_interpolator.has_interpolated_pattern?(expected),
+      "expected the interpolator to be passed #{expected.inspect} but it wasn't"
+  end
+
+  describe "should be able to escape (, ), [, and ]." do
+    def generate(expected, updated_at=nil)
+      mock_attachment = MockAttachment.new(updated_at: updated_at)
+      mock_interpolator = MockInterpolator.new(result: expected)
+      options = { interpolator: mock_interpolator }
+      url_generator = Paperclip::UrlGenerator.new(mock_attachment, options)
+      def url_generator.respond_to(params)
+        false if params == :escape
+      end
+      url_generator.for(:style_name, {escape: true, timestamp: !!updated_at})
+    end
+
+    it "not timestamp" do
+      expected = "the(expected)result[]"
+      assert_equal "the%28expected%29result%5B%5D", generate(expected)
+    end
+
+    it "timestamp" do
+      expected = "the(expected)result[]"
+      updated_at = 1231231234
+      assert_equal "the%28expected%29result%5B%5D?#{updated_at}",
+        generate(expected, updated_at)
+    end
+  end
+end