paperclip-fix 4.3.7

data/spec/paperclip/plural_cache_spec.rb

@@ -0,0 +1,37 @@
+require 'spec_helper'
+
+describe 'Plural cache' do
+  it 'caches pluralizations' do
+    cache = Paperclip::Interpolations::PluralCache.new
+    symbol = :box
+
+    first = cache.pluralize_symbol(symbol)
+    second = cache.pluralize_symbol(symbol)
+    expect(first).to equal(second)
+  end
+
+  it 'caches pluralizations and underscores' do
+    class BigBox ; end
+    cache = Paperclip::Interpolations::PluralCache.new
+    klass = BigBox
+
+    first = cache.underscore_and_pluralize_class(klass)
+    second = cache.underscore_and_pluralize_class(klass)
+    expect(first).to equal(second)
+  end
+
+  it 'pluralizes words' do
+    cache = Paperclip::Interpolations::PluralCache.new
+    symbol = :box
+
+    expect(cache.pluralize_symbol(symbol)).to eq("boxes")
+  end
+
+  it 'pluralizes and underscore class names' do
+    class BigBox ; end
+    cache = Paperclip::Interpolations::PluralCache.new
+    klass = BigBox
+
+    expect(cache.underscore_and_pluralize_class(klass)).to eq("big_boxes")
+  end
+end

data/spec/paperclip/processor_helpers_spec.rb

@@ -0,0 +1,57 @@
+require 'spec_helper'
+
+describe Paperclip::ProcessorHelpers do
+  describe '.load_processor' do
+    context 'when the file exists in lib/paperclip' do
+      it 'loads it correctly' do
+        pathname = Pathname.new('my_app')
+        main_path = 'main_path'
+        alternate_path = 'alternate_path'
+
+        Rails.stubs(:root).returns(pathname)
+        File.expects(:expand_path).with(pathname.join('lib/paperclip', 'custom.rb')).returns(main_path)
+        File.expects(:expand_path).with(pathname.join('lib/paperclip_processors', 'custom.rb')).returns(alternate_path)
+        File.expects(:exist?).with(main_path).returns(true)
+        File.expects(:exist?).with(alternate_path).returns(false)
+
+        Paperclip.expects(:require).with(main_path)
+
+        Paperclip.load_processor(:custom)
+      end
+    end
+
+    context 'when the file exists in lib/paperclip_processors' do
+      it 'loads it correctly' do
+        pathname = Pathname.new('my_app')
+        main_path = 'main_path'
+        alternate_path = 'alternate_path'
+
+        Rails.stubs(:root).returns(pathname)
+        File.expects(:expand_path).with(pathname.join('lib/paperclip', 'custom.rb')).returns(main_path)
+        File.expects(:expand_path).with(pathname.join('lib/paperclip_processors', 'custom.rb')).returns(alternate_path)
+        File.expects(:exist?).with(main_path).returns(false)
+        File.expects(:exist?).with(alternate_path).returns(true)
+
+        Paperclip.expects(:require).with(alternate_path)
+
+        Paperclip.load_processor(:custom)
+      end
+    end
+
+    context 'when the file does not exist in lib/paperclip_processors' do
+      it 'raises an error' do
+        pathname = Pathname.new('my_app')
+        main_path = 'main_path'
+        alternate_path = 'alternate_path'
+
+        Rails.stubs(:root).returns(pathname)
+        File.stubs(:expand_path).with(pathname.join('lib/paperclip', 'custom.rb')).returns(main_path)
+        File.stubs(:expand_path).with(pathname.join('lib/paperclip_processors', 'custom.rb')).returns(alternate_path)
+        File.stubs(:exist?).with(main_path).returns(false)
+        File.stubs(:exist?).with(alternate_path).returns(false)
+
+        assert_raises(LoadError) { Paperclip.processor(:custom) }
+      end
+    end
+  end
+end

data/spec/paperclip/processor_spec.rb

@@ -0,0 +1,26 @@
+require 'spec_helper'
+
+describe Paperclip::Processor do
+  it "instantiates and call #make when sent #make to the class" do
+    processor = mock
+    processor.expects(:make).with()
+    Paperclip::Processor.expects(:new).with(:one, :two, :three).returns(processor)
+    Paperclip::Processor.make(:one, :two, :three)
+  end
+
+  context "Calling #convert" do
+    it "runs the convert command with Cocaine" do
+      Paperclip.options[:log_command] = false
+      Cocaine::CommandLine.expects(:new).with("convert", "stuff", {}).returns(stub(:run))
+      Paperclip::Processor.new('filename').convert("stuff")
+    end
+  end
+
+  context "Calling #identify" do
+    it "runs the identify command with Cocaine" do
+      Paperclip.options[:log_command] = false
+      Cocaine::CommandLine.expects(:new).with("identify", "stuff", {}).returns(stub(:run))
+      Paperclip::Processor.new('filename').identify("stuff")
+    end
+  end
+end

data/spec/paperclip/rails_environment_spec.rb

@@ -0,0 +1,33 @@
+require 'spec_helper'
+
+describe Paperclip::RailsEnvironment do
+
+  it "returns nil when Rails isn't defined" do
+    resetting_rails_to(nil) do
+      expect(Paperclip::RailsEnvironment.get).to be_nil
+    end
+  end
+
+  it "returns nil when Rails.env isn't defined" do
+    resetting_rails_to({}) do
+      expect(Paperclip::RailsEnvironment.get).to be_nil
+    end
+  end
+
+  it "returns the value of Rails.env if it is set" do
+    resetting_rails_to(OpenStruct.new(env: "foo")) do
+      expect(Paperclip::RailsEnvironment.get).to eq "foo"
+    end
+  end
+
+  def resetting_rails_to(new_value)
+    begin
+      previous_rails = Object.send(:remove_const, "Rails")
+      Object.const_set("Rails", new_value) unless new_value.nil?
+      yield
+    ensure
+      Object.send(:remove_const, "Rails") if Object.const_defined?("Rails")
+      Object.const_set("Rails", previous_rails)
+    end
+  end
+end

data/spec/paperclip/rake_spec.rb

@@ -0,0 +1,103 @@
+require 'spec_helper'
+require 'rake'
+load './lib/tasks/paperclip.rake'
+
+describe Rake do
+  context "calling `rake paperclip:refresh:thumbnails`" do
+    before do
+      rebuild_model
+      Paperclip::Task.stubs(:obtain_class).returns('Dummy')
+      @bogus_instance = Dummy.new
+      @bogus_instance.id = 'some_id'
+      @bogus_instance.avatar.stubs(:reprocess!)
+      @valid_instance = Dummy.new
+      @valid_instance.avatar.stubs(:reprocess!)
+      Paperclip::Task.stubs(:log_error)
+      Paperclip.stubs(:each_instance_with_attachment).multiple_yields @bogus_instance, @valid_instance
+    end
+    context "when there is an exception in reprocess!" do
+      before do
+        @bogus_instance.avatar.stubs(:reprocess!).raises
+      end
+
+      it "catches the exception" do
+        assert_nothing_raised do
+          ::Rake::Task['paperclip:refresh:thumbnails'].execute
+        end
+      end
+
+      it "continues to the next instance" do
+        @valid_instance.avatar.expects(:reprocess!)
+        ::Rake::Task['paperclip:refresh:thumbnails'].execute
+      end
+
+      it "prints the exception" do
+        exception_msg = 'Some Exception'
+        @bogus_instance.avatar.stubs(:reprocess!).raises(exception_msg)
+        Paperclip::Task.expects(:log_error).with do |str|
+          str.match exception_msg
+        end
+        ::Rake::Task['paperclip:refresh:thumbnails'].execute
+      end
+
+      it "prints the class name" do
+        Paperclip::Task.expects(:log_error).with do |str|
+          str.match 'Dummy'
+        end
+        ::Rake::Task['paperclip:refresh:thumbnails'].execute
+      end
+
+      it "prints the instance ID" do
+        Paperclip::Task.expects(:log_error).with do |str|
+          str.match "ID #{@bogus_instance.id}"
+        end
+        ::Rake::Task['paperclip:refresh:thumbnails'].execute
+      end
+    end
+
+    context "when there is an error in reprocess!" do
+      before do
+        @errors = mock('errors')
+        @errors.stubs(:full_messages).returns([''])
+        @errors.stubs(:blank?).returns(false)
+        @bogus_instance.stubs(:errors).returns(@errors)
+      end
+
+      it "continues to the next instance" do
+        @valid_instance.avatar.expects(:reprocess!)
+        ::Rake::Task['paperclip:refresh:thumbnails'].execute
+      end
+
+      it "prints the error" do
+        error_msg = 'Some Error'
+        @errors.stubs(:full_messages).returns([error_msg])
+        Paperclip::Task.expects(:log_error).with do |str|
+          str.match error_msg
+        end
+        ::Rake::Task['paperclip:refresh:thumbnails'].execute
+      end
+
+      it "prints the class name" do
+        Paperclip::Task.expects(:log_error).with do |str|
+          str.match 'Dummy'
+        end
+        ::Rake::Task['paperclip:refresh:thumbnails'].execute
+      end
+
+      it "prints the instance ID" do
+        Paperclip::Task.expects(:log_error).with do |str|
+          str.match "ID #{@bogus_instance.id}"
+        end
+        ::Rake::Task['paperclip:refresh:thumbnails'].execute
+      end
+    end
+  end
+
+  context "Paperclip::Task.log_error method" do
+    it "prints its argument to STDERR" do
+      msg = 'Some Message'
+      $stderr.expects(:puts).with(msg)
+      Paperclip::Task.log_error(msg)
+    end
+  end
+end

data/spec/paperclip/schema_spec.rb

@@ -0,0 +1,248 @@
+require 'spec_helper'
+require 'paperclip/schema'
+require 'active_support/testing/deprecation'
+
+describe Paperclip::Schema do
+  include ActiveSupport::Testing::Deprecation
+
+  before do
+    rebuild_class
+  end
+
+  after do
+    Dummy.connection.drop_table :dummies rescue nil
+  end
+
+  context "within table definition" do
+    context "using #has_attached_file" do
+      before do
+        ActiveSupport::Deprecation.silenced = false
+      end
+      it "creates attachment columns" do
+        Dummy.connection.create_table :dummies, force: true do |t|
+          ActiveSupport::Deprecation.silence do
+            t.has_attached_file :avatar
+          end
+        end
+
+        columns = Dummy.columns.map{ |column| [column.name, column.type] }
+
+        expect(columns).to include(['avatar_file_name', :string])
+        expect(columns).to include(['avatar_content_type', :string])
+        expect(columns).to include(['avatar_file_size', :integer])
+        expect(columns).to include(['avatar_updated_at', :datetime])
+      end
+
+      it "displays deprecation warning" do
+        Dummy.connection.create_table :dummies, force: true do |t|
+          assert_deprecated do
+            t.has_attached_file :avatar
+          end
+        end
+      end
+    end
+
+    context "using #attachment" do
+      before do
+        Dummy.connection.create_table :dummies, force: true do |t|
+          t.attachment :avatar
+        end
+      end
+
+      it "creates attachment columns" do
+        columns = Dummy.columns.map{ |column| [column.name, column.type] }
+
+        expect(columns).to include(['avatar_file_name', :string])
+        expect(columns).to include(['avatar_content_type', :string])
+        expect(columns).to include(['avatar_file_size', :integer])
+        expect(columns).to include(['avatar_updated_at', :datetime])
+      end
+    end
+
+    context "using #attachment with options" do
+      before do
+        Dummy.connection.create_table :dummies, force: true do |t|
+          t.attachment :avatar, default: 1, file_name: { default: 'default' }
+        end
+      end
+
+      it "sets defaults on columns" do
+        defaults_columns = ["avatar_file_name", "avatar_content_type", "avatar_file_size"]
+        columns = Dummy.columns.select { |e| defaults_columns.include? e.name }
+
+        expect(columns).to have_column("avatar_file_name").with_default("default")
+        expect(columns).to have_column("avatar_content_type").with_default("1")
+        expect(columns).to have_column("avatar_file_size").with_default(1)
+      end
+    end
+  end
+
+  context "within schema statement" do
+    before do
+      Dummy.connection.create_table :dummies, force: true
+    end
+
+    context "migrating up" do
+      context "with single attachment" do
+        before do
+          Dummy.connection.add_attachment :dummies, :avatar
+        end
+
+        it "creates attachment columns" do
+          columns = Dummy.columns.map{ |column| [column.name, column.type] }
+
+          expect(columns).to include(['avatar_file_name', :string])
+          expect(columns).to include(['avatar_content_type', :string])
+          expect(columns).to include(['avatar_file_size', :integer])
+          expect(columns).to include(['avatar_updated_at', :datetime])
+        end
+      end
+
+      context "with single attachment and options" do
+        before do
+          Dummy.connection.add_attachment :dummies, :avatar, default: '1', file_name: { default: 'default' }
+        end
+
+        it "sets defaults on columns" do
+          defaults_columns = ["avatar_file_name", "avatar_content_type", "avatar_file_size"]
+          columns = Dummy.columns.select { |e| defaults_columns.include? e.name }
+
+          expect(columns).to have_column("avatar_file_name").with_default("default")
+          expect(columns).to have_column("avatar_content_type").with_default("1")
+          expect(columns).to have_column("avatar_file_size").with_default(1)
+        end
+      end
+
+      context "with multiple attachments" do
+        before do
+          Dummy.connection.add_attachment :dummies, :avatar, :photo
+        end
+
+        it "creates attachment columns" do
+          columns = Dummy.columns.map{ |column| [column.name, column.type] }
+
+          expect(columns).to include(['avatar_file_name', :string])
+          expect(columns).to include(['avatar_content_type', :string])
+          expect(columns).to include(['avatar_file_size', :integer])
+          expect(columns).to include(['avatar_updated_at', :datetime])
+          expect(columns).to include(['photo_file_name', :string])
+          expect(columns).to include(['photo_content_type', :string])
+          expect(columns).to include(['photo_file_size', :integer])
+          expect(columns).to include(['photo_updated_at', :datetime])
+        end
+      end
+
+      context "with multiple attachments and options" do
+        before do
+          Dummy.connection.add_attachment :dummies, :avatar, :photo, default: '1', file_name: { default: 'default' }
+        end
+
+        it "sets defaults on columns" do
+          defaults_columns = ["avatar_file_name", "avatar_content_type", "avatar_file_size", "photo_file_name", "photo_content_type", "photo_file_size"]
+          columns = Dummy.columns.select { |e| defaults_columns.include? e.name }
+
+          expect(columns).to have_column("avatar_file_name").with_default("default")
+          expect(columns).to have_column("avatar_content_type").with_default("1")
+          expect(columns).to have_column("avatar_file_size").with_default(1)
+          expect(columns).to have_column("photo_file_name").with_default("default")
+          expect(columns).to have_column("photo_content_type").with_default("1")
+          expect(columns).to have_column("photo_file_size").with_default(1)
+        end
+      end
+
+      context "with no attachment" do
+        it "raises an error" do
+          assert_raises ArgumentError do
+            Dummy.connection.add_attachment :dummies
+          end
+        end
+      end
+    end
+
+    context "migrating down" do
+      before do
+        Dummy.connection.change_table :dummies do |t|
+          t.column :avatar_file_name, :string
+          t.column :avatar_content_type, :string
+          t.column :avatar_file_size, :integer
+          t.column :avatar_updated_at, :datetime
+        end
+      end
+
+      context "using #drop_attached_file" do
+        before do
+          ActiveSupport::Deprecation.silenced = false
+        end
+        it "removes the attachment columns" do
+          ActiveSupport::Deprecation.silence do
+            Dummy.connection.drop_attached_file :dummies, :avatar
+          end
+
+          columns = Dummy.columns.map{ |column| [column.name, column.type] }
+
+          expect(columns).to_not include(['avatar_file_name', :string])
+          expect(columns).to_not include(['avatar_content_type', :string])
+          expect(columns).to_not include(['avatar_file_size', :integer])
+          expect(columns).to_not include(['avatar_updated_at', :datetime])
+        end
+
+        it "displays a deprecation warning" do
+          assert_deprecated do
+            Dummy.connection.drop_attached_file :dummies, :avatar
+          end
+        end
+      end
+
+      context "using #remove_attachment" do
+        context "with single attachment" do
+          before do
+            Dummy.connection.remove_attachment :dummies, :avatar
+          end
+
+          it "removes the attachment columns" do
+            columns = Dummy.columns.map{ |column| [column.name, column.type] }
+
+            expect(columns).to_not include(['avatar_file_name', :string])
+            expect(columns).to_not include(['avatar_content_type', :string])
+            expect(columns).to_not include(['avatar_file_size', :integer])
+            expect(columns).to_not include(['avatar_updated_at', :datetime])
+          end
+        end
+
+        context "with multiple attachments" do
+          before do
+            Dummy.connection.change_table :dummies do |t|
+              t.column :photo_file_name, :string
+              t.column :photo_content_type, :string
+              t.column :photo_file_size, :integer
+              t.column :photo_updated_at, :datetime
+            end
+
+            Dummy.connection.remove_attachment :dummies, :avatar, :photo
+          end
+
+          it "removes the attachment columns" do
+            columns = Dummy.columns.map{ |column| [column.name, column.type] }
+
+            expect(columns).to_not include(['avatar_file_name', :string])
+            expect(columns).to_not include(['avatar_content_type', :string])
+            expect(columns).to_not include(['avatar_file_size', :integer])
+            expect(columns).to_not include(['avatar_updated_at', :datetime])
+            expect(columns).to_not include(['photo_file_name', :string])
+            expect(columns).to_not include(['photo_content_type', :string])
+            expect(columns).to_not include(['photo_file_size', :integer])
+            expect(columns).to_not include(['photo_updated_at', :datetime])
+          end
+        end
+
+        context "with no attachment" do
+          it "raises an error" do
+            assert_raises ArgumentError do
+              Dummy.connection.remove_attachment :dummies
+            end
+          end
+        end
+      end
+    end
+  end
+end

data/spec/paperclip/storage/filesystem_spec.rb

@@ -0,0 +1,79 @@
+require 'spec_helper'
+
+describe Paperclip::Storage::Filesystem do
+  context "Filesystem" do
+    context "normal file" do
+      before do
+        rebuild_model styles: { thumbnail: "25x25#" }
+        @dummy = Dummy.create!
+
+        @file = File.open(fixture_file('5k.png'))
+        @dummy.avatar = @file
+      end
+
+      after { @file.close }
+
+      it "allows file assignment" do
+        assert @dummy.save
+      end
+
+      it "stores the original" do
+        @dummy.save
+        assert_file_exists(@dummy.avatar.path)
+      end
+
+      it "stores the thumbnail" do
+        @dummy.save
+        assert_file_exists(@dummy.avatar.path(:thumbnail))
+      end
+
+      it "is rewinded after flush_writes" do
+        @dummy.avatar.instance_eval "def after_flush_writes; end"
+
+        files = @dummy.avatar.queued_for_write.values
+        @dummy.save
+        assert files.none?(&:eof?), "Expect all the files to be rewinded."
+      end
+
+      it "is removed after after_flush_writes" do
+        paths = @dummy.avatar.queued_for_write.values.map(&:path)
+        @dummy.save
+        assert paths.none?{ |path| File.exist?(path) },
+          "Expect all the files to be deleted."
+      end
+
+      it 'copies the file to a known location with copy_to_local_file' do
+        tempfile = Tempfile.new("known_location")
+        @dummy.avatar.copy_to_local_file(:original, tempfile.path)
+        tempfile.rewind
+        assert_equal @file.read, tempfile.read
+        tempfile.close
+      end
+    end
+
+    context "with file that has space in file name" do
+      before do
+        rebuild_model styles: { thumbnail: "25x25#" }
+        @dummy = Dummy.create!
+
+        @file = File.open(fixture_file('spaced file.png'))
+        @dummy.avatar = @file
+        @dummy.save
+      end
+
+      after { @file.close }
+
+      it "stores the file" do
+        assert_file_exists(@dummy.avatar.path)
+      end
+
+      it "returns a replaced version for path" do
+        assert_match /.+\/spaced_file\.png/, @dummy.avatar.path
+      end
+
+      it "returns a replaced version for url" do
+        assert_match /.+\/spaced_file\.png/, @dummy.avatar.url
+      end
+    end
+  end
+end