paperclip-fix 4.3.7

data/spec/paperclip/interpolations_spec.rb

@@ -0,0 +1,262 @@
+require 'spec_helper'
+
+describe Paperclip::Interpolations do
+  it "returns all methods but the infrastructure when sent #all" do
+    methods = Paperclip::Interpolations.all
+    assert ! methods.include?(:[])
+    assert ! methods.include?(:[]=)
+    assert ! methods.include?(:all)
+    methods.each do |m|
+      assert Paperclip::Interpolations.respond_to?(m)
+    end
+  end
+
+  it "returns the Rails.root" do
+    assert_equal Rails.root, Paperclip::Interpolations.rails_root(:attachment, :style)
+  end
+
+  it "returns the Rails.env" do
+    assert_equal Rails.env, Paperclip::Interpolations.rails_env(:attachment, :style)
+  end
+
+  it "returns the class of the Interpolations module when called with no params" do
+    assert_equal Module, Paperclip::Interpolations.class
+  end
+
+  it "returns the class of the instance" do
+    class Thing ; end
+    attachment = mock
+    attachment.expects(:instance).returns(attachment)
+    attachment.expects(:class).returns(Thing)
+    assert_equal "things", Paperclip::Interpolations.class(attachment, :style)
+  end
+
+  it "returns the basename of the file" do
+    attachment = mock
+    attachment.expects(:original_filename).returns("one.jpg").times(1)
+    assert_equal "one", Paperclip::Interpolations.basename(attachment, :style)
+  end
+
+  it "returns the extension of the file" do
+    attachment = mock
+    attachment.expects(:original_filename).returns("one.jpg")
+    attachment.expects(:styles).returns({})
+    assert_equal "jpg", Paperclip::Interpolations.extension(attachment, :style)
+  end
+
+  it "returns the extension of the file as the format if defined in the style" do
+    attachment = mock
+    attachment.expects(:original_filename).never
+    attachment.expects(:styles).twice.returns({style: {format: "png"}})
+
+    [:style, 'style'].each do |style|
+      assert_equal "png", Paperclip::Interpolations.extension(attachment, style)
+    end
+  end
+
+  it "returns the extension of the file based on the content type" do
+    attachment = mock
+    attachment.expects(:content_type).returns('image/png')
+    attachment.expects(:styles).returns({})
+    interpolations = Paperclip::Interpolations
+    interpolations.expects(:extension).returns('random')
+    assert_equal "png", interpolations.content_type_extension(attachment, :style)
+  end
+
+  it "returns the original extension of the file if it matches a content type extension" do
+    attachment = mock
+    attachment.expects(:content_type).returns('image/jpeg')
+    attachment.expects(:styles).returns({})
+    interpolations = Paperclip::Interpolations
+    interpolations.expects(:extension).returns('jpe')
+    assert_equal "jpe", interpolations.content_type_extension(attachment, :style)
+  end
+
+  it "returns the extension of the file with a dot" do
+    attachment = mock
+    attachment.expects(:original_filename).returns("one.jpg")
+    attachment.expects(:styles).returns({})
+    assert_equal ".jpg", Paperclip::Interpolations.dotextension(attachment, :style)
+  end
+
+  it "returns the extension of the file without a dot if the extension is empty" do
+    attachment = mock
+    attachment.expects(:original_filename).returns("one")
+    attachment.expects(:styles).returns({})
+    assert_equal "", Paperclip::Interpolations.dotextension(attachment, :style)
+  end
+
+  it "returns the latter half of the content type of the extension if no match found" do
+    attachment = mock
+    attachment.expects(:content_type).at_least_once().returns('not/found')
+    attachment.expects(:styles).returns({})
+    interpolations = Paperclip::Interpolations
+    interpolations.expects(:extension).returns('random')
+    assert_equal "found", interpolations.content_type_extension(attachment, :style)
+  end
+
+  it "returns the format if defined in the style, ignoring the content type" do
+    attachment = mock
+    attachment.expects(:content_type).returns('image/jpeg')
+    attachment.expects(:styles).returns({style: {format: "png"}})
+    interpolations = Paperclip::Interpolations
+    interpolations.expects(:extension).returns('random')
+    assert_equal "png", interpolations.content_type_extension(attachment, :style)
+  end
+
+  it "is able to handle numeric style names" do
+    attachment = mock(
+      styles: {:"4" => {format: :expected_extension}}
+    )
+    assert_equal :expected_extension, Paperclip::Interpolations.extension(attachment, 4)
+  end
+
+  it "returns the #to_param of the attachment" do
+    attachment = mock
+    attachment.expects(:to_param).returns("23-awesome")
+    attachment.expects(:instance).returns(attachment)
+    assert_equal "23-awesome", Paperclip::Interpolations.param(attachment, :style)
+  end
+
+  it "returns the id of the attachment" do
+    attachment = mock
+    attachment.expects(:id).returns(23)
+    attachment.expects(:instance).returns(attachment)
+    assert_equal 23, Paperclip::Interpolations.id(attachment, :style)
+  end
+
+  it "returns nil for attachments to new records" do
+    attachment = mock
+    attachment.expects(:id).returns(nil)
+    attachment.expects(:instance).returns(attachment)
+    assert_nil Paperclip::Interpolations.id(attachment, :style)
+  end
+
+  it "returns the partitioned id of the attachment when the id is an integer" do
+    attachment = mock
+    attachment.expects(:id).returns(23)
+    attachment.expects(:instance).returns(attachment)
+    assert_equal "000/000/023", Paperclip::Interpolations.id_partition(attachment, :style)
+  end
+
+  it "returns the partitioned id of the attachment when the id is a string" do
+    attachment = mock
+    attachment.expects(:id).returns("32fnj23oio2f")
+    attachment.expects(:instance).returns(attachment)
+    assert_equal "32f/nj2/3oi", Paperclip::Interpolations.id_partition(attachment, :style)
+  end
+
+  it "returns nil for the partitioned id of an attachment to a new record (when the id is nil)" do
+    attachment = mock
+    attachment.expects(:id).returns(nil)
+    attachment.expects(:instance).returns(attachment)
+    assert_nil Paperclip::Interpolations.id_partition(attachment, :style)
+  end
+
+  it "returns the name of the attachment" do
+    attachment = mock
+    attachment.expects(:name).returns("file")
+    assert_equal "files", Paperclip::Interpolations.attachment(attachment, :style)
+  end
+
+  it "returns the style" do
+    assert_equal :style, Paperclip::Interpolations.style(:attachment, :style)
+  end
+
+  it "returns the default style" do
+    attachment = mock
+    attachment.expects(:default_style).returns(:default_style)
+    assert_equal :default_style, Paperclip::Interpolations.style(attachment, nil)
+  end
+
+  it "reinterpolates :url" do
+    attachment = mock
+    attachment.expects(:url).with(:style, timestamp: false, escape: false).returns("1234")
+    assert_equal "1234", Paperclip::Interpolations.url(attachment, :style)
+  end
+
+  it "raises if infinite loop detcted reinterpolating :url" do
+    attachment = Object.new
+    class << attachment
+      def url(*args)
+        Paperclip::Interpolations.url(self, :style)
+      end
+    end
+    assert_raises(Paperclip::Errors::InfiniteInterpolationError){ Paperclip::Interpolations.url(attachment, :style) }
+  end
+
+  it "returns the filename as basename.extension" do
+    attachment = mock
+    attachment.expects(:styles).returns({})
+    attachment.expects(:original_filename).returns("one.jpg").times(2)
+    assert_equal "one.jpg", Paperclip::Interpolations.filename(attachment, :style)
+  end
+
+  it "returns the filename as basename.extension when format supplied" do
+    attachment = mock
+    attachment.expects(:styles).returns({style: {format: :png}})
+    attachment.expects(:original_filename).returns("one.jpg").times(1)
+    assert_equal "one.png", Paperclip::Interpolations.filename(attachment, :style)
+  end
+
+  it "returns the filename as basename when extension is blank" do
+    attachment = mock
+    attachment.stubs(:styles).returns({})
+    attachment.stubs(:original_filename).returns("one")
+    assert_equal "one", Paperclip::Interpolations.filename(attachment, :style)
+  end
+  
+  it "returns the basename when the extension contains regexp special characters" do
+    attachment = mock
+    attachment.stubs(:styles).returns({})
+    attachment.stubs(:original_filename).returns("one.ab)")
+    assert_equal "one", Paperclip::Interpolations.basename(attachment, :style)
+  end
+
+  it "returns the timestamp" do
+    now = Time.now
+    zone = 'UTC'
+    attachment = mock
+    attachment.expects(:instance_read).with(:updated_at).returns(now)
+    attachment.expects(:time_zone).returns(zone)
+    assert_equal now.in_time_zone(zone).to_s, Paperclip::Interpolations.timestamp(attachment, :style)
+  end
+
+  it "returns updated_at" do
+    attachment = mock
+    seconds_since_epoch = 1234567890
+    attachment.expects(:updated_at).returns(seconds_since_epoch)
+    assert_equal seconds_since_epoch, Paperclip::Interpolations.updated_at(attachment, :style)
+  end
+
+  it "returns attachment's hash when passing both arguments" do
+    attachment = mock
+    fake_hash = "a_wicked_secure_hash"
+    attachment.expects(:hash_key).returns(fake_hash)
+    assert_equal fake_hash, Paperclip::Interpolations.hash(attachment, :style)
+  end
+
+  it "returns Object#hash when passing no argument" do
+    attachment = mock
+    fake_hash = "a_wicked_secure_hash"
+    attachment.expects(:hash_key).never.returns(fake_hash)
+    assert_not_equal fake_hash, Paperclip::Interpolations.hash
+  end
+
+  it "calls all expected interpolations with the given arguments" do
+    Paperclip::Interpolations.expects(:id).with(:attachment, :style).returns(1234)
+    Paperclip::Interpolations.expects(:attachment).with(:attachment, :style).returns("attachments")
+    Paperclip::Interpolations.expects(:notreal).never
+    value = Paperclip::Interpolations.interpolate(":notreal/:id/:attachment", :attachment, :style)
+    assert_equal ":notreal/1234/attachments", value
+  end
+
+  it "handles question marks" do
+    Paperclip.interpolates :foo? do
+      "bar"
+    end
+    Paperclip::Interpolations.expects(:fool).never
+    value = Paperclip::Interpolations.interpolate(":fo/:foo?")
+    assert_equal ":fo/bar", value
+  end
+end

data/spec/paperclip/io_adapters/abstract_adapter_spec.rb

@@ -0,0 +1,78 @@
+require 'spec_helper'
+
+describe Paperclip::AbstractAdapter do
+  class TestAdapter < Paperclip::AbstractAdapter
+    attr_accessor :tempfile
+
+    def content_type
+      Paperclip::ContentTypeDetector.new(path).detect
+    end
+  end
+
+  context "content type from file contents" do
+    before do
+      @adapter = TestAdapter.new
+      @adapter.stubs(:path).returns("image.png")
+      Paperclip.stubs(:run).returns("image/png\n")
+      Paperclip::ContentTypeDetector.any_instance.stubs(:type_from_mime_magic).returns("image/png")
+    end
+
+    it "returns the content type without newline" do
+      assert_equal "image/png", @adapter.content_type
+    end
+  end
+
+  context "nil?" do
+    it "returns false" do
+      assert !TestAdapter.new.nil?
+    end
+  end
+
+  context "delegation" do
+    before do
+      @adapter = TestAdapter.new
+      @adapter.tempfile = stub("Tempfile")
+    end
+
+    [:binmode, :binmode?, :close, :close!, :closed?, :eof?, :path, :rewind, :unlink].each do |method|
+      it "delegates #{method} to @tempfile" do
+        @adapter.tempfile.stubs(method)
+        @adapter.public_send(method)
+        assert_received @adapter.tempfile, method
+      end
+    end
+  end
+
+  it 'gets rid of slashes and colons in filenames' do
+    @adapter = TestAdapter.new
+    @adapter.original_filename = "awesome/file:name.png"
+
+    assert_equal "awesome_file_name.png", @adapter.original_filename
+  end
+
+  it 'is an assignment' do
+    assert TestAdapter.new.assignment?
+  end
+
+  it 'is not nil' do
+    assert !TestAdapter.new.nil?
+  end
+
+  it "generates a destination filename with no original filename" do
+    @adapter = TestAdapter.new
+    expect(@adapter.send(:destination).path).to_not be_nil
+  end
+
+  it 'uses the original filename to generate the tempfile' do
+    @adapter = TestAdapter.new
+    @adapter.original_filename = "file.png"
+    expect(@adapter.send(:destination).path).to end_with(".png")
+  end
+
+  context "#original_filename=" do
+    it "should not fail with a nil original filename" do
+      adapter = TestAdapter.new
+      expect{ adapter.original_filename = nil }.not_to raise_error
+    end
+  end
+end

data/spec/paperclip/io_adapters/attachment_adapter_spec.rb

@@ -0,0 +1,139 @@
+require 'spec_helper'
+
+describe Paperclip::AttachmentAdapter do
+  before do
+    rebuild_model path: "tmp/:class/:attachment/:style/:filename", styles: {thumb: '50x50'}
+    @attachment = Dummy.new.avatar
+  end
+
+  context "for an attachment" do
+    before do
+      @file = File.new(fixture_file("5k.png"))
+      @file.binmode
+
+      @attachment.assign(@file)
+      @attachment.save
+      @subject = Paperclip.io_adapters.for(@attachment)
+    end
+
+    after do
+      @file.close
+      @subject.close
+    end
+
+    it "gets the right filename" do
+      assert_equal "5k.png", @subject.original_filename
+    end
+
+    it "forces binmode on tempfile" do
+      assert @subject.instance_variable_get("@tempfile").binmode?
+    end
+
+    it "gets the content type" do
+      assert_equal "image/png", @subject.content_type
+    end
+
+    it "gets the file's size" do
+      assert_equal 4456, @subject.size
+    end
+
+    it "returns false for a call to nil?" do
+      assert ! @subject.nil?
+    end
+
+    it "generates a MD5 hash of the contents" do
+      expected = Digest::MD5.file(@file.path).to_s
+      assert_equal expected, @subject.fingerprint
+    end
+
+    it "reads the contents of the file" do
+      expected = @file.read
+      actual = @subject.read
+      assert expected.length > 0
+      assert_equal expected.length, actual.length
+      assert_equal expected, actual
+    end
+
+  end
+
+  context "for a file with restricted characters in the name" do
+    before do
+      file_contents = IO.read(fixture_file("animated.gif"))
+      @file = StringIO.new(file_contents)
+      @file.stubs(:original_filename).returns('image:restricted.gif')
+      @file.binmode
+
+      @attachment.assign(@file)
+      @attachment.save
+      @subject = Paperclip.io_adapters.for(@attachment)
+    end
+
+    after do
+      @subject.close
+    end
+
+    it "does not generate paths that include restricted characters" do
+      expect(@subject.path).to_not match(/:/)
+    end
+
+    it "does not generate filenames that include restricted characters" do
+      assert_equal 'image_restricted.gif', @subject.original_filename
+    end
+  end
+
+  context "for a style" do
+    before do
+      @file = File.new(fixture_file("5k.png"))
+      @file.binmode
+
+      @attachment.assign(@file)
+
+      @thumb = Tempfile.new("thumbnail").tap(&:binmode)
+      FileUtils.cp @attachment.queued_for_write[:thumb].path, @thumb.path
+
+      @attachment.save
+      @subject = Paperclip.io_adapters.for(@attachment.styles[:thumb])
+    end
+
+    after do
+      @file.close
+      @thumb.close
+      @subject.close
+    end
+
+    it "gets the original filename" do
+      assert_equal "5k.png", @subject.original_filename
+    end
+
+    it "forces binmode on tempfile" do
+      assert @subject.instance_variable_get("@tempfile").binmode?
+    end
+
+    it "gets the content type" do
+      assert_equal "image/png", @subject.content_type
+    end
+
+    it "gets the thumbnail's file size" do
+      assert_equal @thumb.size, @subject.size
+    end
+
+    it "returns false for a call to nil?" do
+      assert ! @subject.nil?
+    end
+
+    it "generates a MD5 hash of the contents" do
+      expected = Digest::MD5.file(@thumb.path).to_s
+      assert_equal expected, @subject.fingerprint
+    end
+
+    it "reads the contents of the thumbnail" do
+      @thumb.rewind
+      expected = @thumb.read
+      actual = @subject.read
+      assert expected.length > 0
+      assert_equal expected.length, actual.length
+      assert_equal expected, actual
+    end
+
+  end
+end

data/spec/paperclip/io_adapters/data_uri_adapter_spec.rb

@@ -0,0 +1,83 @@
+require 'spec_helper'
+
+describe Paperclip::DataUriAdapter do
+  after do
+    if @subject
+      @subject.close
+    end
+  end
+
+  it 'allows a missing mime-type' do
+    adapter = Paperclip.io_adapters.for("data:;base64,#{original_base64_content}")
+    assert_equal Paperclip::DataUriAdapter, adapter.class
+  end
+
+  it 'alows mime type that has dot in it' do
+    adapter = Paperclip.io_adapters.for("data:image/vnd.microsoft.icon;base64,#{original_base64_content}")
+    assert_equal Paperclip::DataUriAdapter, adapter.class
+  end
+
+  context "a new instance" do
+    before do
+      @contents = "data:image/png;base64,#{original_base64_content}"
+      @subject = Paperclip.io_adapters.for(@contents)
+    end
+
+    it "returns a nondescript file name" do
+      assert_equal "data", @subject.original_filename
+    end
+
+    it "returns a content type" do
+      assert_equal "image/png", @subject.content_type
+    end
+
+    it "returns the size of the data" do
+      assert_equal 4456, @subject.size
+    end
+
+    it "generates a correct MD5 hash of the contents" do
+      assert_equal(
+        Digest::MD5.hexdigest(Base64.decode64(original_base64_content)),
+        @subject.fingerprint
+      )
+    end
+
+    it "generates correct fingerprint after read" do
+      fingerprint = Digest::MD5.hexdigest(@subject.read)
+      assert_equal fingerprint, @subject.fingerprint
+    end
+
+    it "generates same fingerprint" do
+      assert_equal @subject.fingerprint, @subject.fingerprint
+    end
+
+    it 'accepts a content_type' do
+      @subject.content_type = 'image/png'
+      assert_equal 'image/png', @subject.content_type
+    end
+
+    it 'accepts an original_filename' do
+      @subject.original_filename = 'image.png'
+      assert_equal 'image.png', @subject.original_filename
+    end
+
+    it "does not generate filenames that include restricted characters" do
+      @subject.original_filename = 'image:restricted.png'
+      assert_equal 'image_restricted.png', @subject.original_filename
+    end
+
+    it "does not generate paths that include restricted characters" do
+      @subject.original_filename = 'image:restricted.png'
+      expect(@subject.path).to_not match(/:/)
+    end
+
+  end
+
+  def original_base64_content
+    Base64.encode64(original_file_contents)
+  end
+
+  def original_file_contents
+    @original_file_contents ||= File.read(fixture_file('5k.png'))
+  end
+end

data/spec/paperclip/io_adapters/empty_string_adapter_spec.rb

@@ -0,0 +1,17 @@
+require 'spec_helper'
+
+describe Paperclip::EmptyStringAdapter do
+  context 'a new instance' do
+    before do
+      @subject = Paperclip.io_adapters.for('')
+    end
+
+    it "returns false for a call to nil?" do
+      assert !@subject.nil?
+    end
+
+    it 'returns false for a call to assignment?' do
+      assert !@subject.assignment?
+    end
+  end
+end