paperclip-fix 4.3.7

data/spec/paperclip/matchers/validate_attachment_content_type_matcher_spec.rb

@@ -0,0 +1,99 @@
+require 'spec_helper'
+require 'paperclip/matchers'
+
+describe Paperclip::Shoulda::Matchers::ValidateAttachmentContentTypeMatcher do
+  extend Paperclip::Shoulda::Matchers
+
+  before do
+    reset_table("dummies") do |d|
+      d.string :title
+      d.string :avatar_file_name
+      d.string :avatar_content_type
+    end
+    reset_class "Dummy"
+    Dummy.do_not_validate_attachment_file_type :avatar
+    Dummy.has_attached_file :avatar
+  end
+
+  it "rejects a class with no validation" do
+    expect(matcher).to_not accept(Dummy)
+  end
+
+  it 'rejects a class when the validation fails' do
+    Dummy.validates_attachment_content_type :avatar, content_type: %r{audio/.*}
+    expect(matcher).to_not accept(Dummy)
+  end
+
+  it "accepts a class with a matching validation" do
+    Dummy.validates_attachment_content_type :avatar, content_type: %r{image/.*}
+    expect(matcher).to accept(Dummy)
+  end
+
+  it "accepts a class with other validations but matching types" do
+    Dummy.validates_presence_of :title
+    Dummy.validates_attachment_content_type :avatar, content_type: %r{image/.*}
+    expect(matcher).to accept(Dummy)
+  end
+
+  it "accepts a class that matches and a matcher that only specifies 'allowing'" do
+    Dummy.validates_attachment_content_type :avatar, content_type: %r{image/.*}
+    matcher = plain_matcher.allowing(%w(image/png image/jpeg))
+
+    expect(matcher).to accept(Dummy)
+  end
+
+  it "rejects a class that does not match and a matcher that only specifies 'allowing'" do
+    Dummy.validates_attachment_content_type :avatar, content_type: %r{audio/.*}
+    matcher = plain_matcher.allowing(%w(image/png image/jpeg))
+
+    expect(matcher).to_not accept(Dummy)
+  end
+
+  it "accepts a class that matches and a matcher that only specifies 'rejecting'" do
+    Dummy.validates_attachment_content_type :avatar, content_type: %r{image/.*}
+    matcher = plain_matcher.rejecting(%w(audio/mp3 application/octet-stream))
+
+    expect(matcher).to accept(Dummy)
+  end
+
+  it "rejects a class that does not match and a matcher that only specifies 'rejecting'" do
+    Dummy.validates_attachment_content_type :avatar, content_type: %r{audio/.*}
+    matcher = plain_matcher.rejecting(%w(audio/mp3 application/octet-stream))
+
+    expect(matcher).to_not accept(Dummy)
+  end
+
+  context "using an :if to control the validation" do
+    before do
+      Dummy.class_eval do
+        validates_attachment_content_type :avatar, content_type: %r{image/*} , if: :go
+        attr_accessor :go
+      end
+    end
+
+    it "runs the validation if the control is true" do
+      dummy = Dummy.new
+      dummy.go = true
+      expect(matcher).to accept(dummy)
+    end
+
+    it "does not run the validation if the control is false" do
+      dummy = Dummy.new
+      dummy.go = false
+      expect(matcher).to_not accept(dummy)
+    end
+  end
+
+  private
+
+  def plain_matcher
+    self.class.validate_attachment_content_type(:avatar)
+  end
+
+  def matcher
+    plain_matcher.
+      allowing(%w(image/png image/jpeg)).
+      rejecting(%w(audio/mp3 application/octet-stream))
+  end
+
+end

data/spec/paperclip/matchers/validate_attachment_presence_matcher_spec.rb

@@ -0,0 +1,69 @@
+require 'spec_helper'
+require 'paperclip/matchers'
+
+describe Paperclip::Shoulda::Matchers::ValidateAttachmentPresenceMatcher do
+  extend Paperclip::Shoulda::Matchers
+
+  before do
+    reset_table("dummies") do |d|
+      d.string :avatar_file_name
+    end
+    reset_class "Dummy"
+    Dummy.has_attached_file :avatar
+    Dummy.do_not_validate_attachment_file_type :avatar
+  end
+
+  it "rejects a class with no validation" do
+    expect(matcher).to_not accept(Dummy)
+  end
+
+  it "accepts a class with a matching validation" do
+    Dummy.validates_attachment_presence :avatar
+    expect(matcher).to accept(Dummy)
+  end
+
+  it "accepts an instance with other attachment validations" do
+    reset_table("dummies") do |d|
+      d.string :avatar_file_name
+      d.string :avatar_content_type
+    end
+    Dummy.class_eval do
+      validates_attachment_presence :avatar
+      validates_attachment_content_type :avatar, content_type: 'image/gif'
+    end
+    dummy = Dummy.new
+
+    dummy.avatar = File.new fixture_file('5k.png')
+
+    expect(matcher).to accept(dummy)
+  end
+
+  context "using an :if to control the validation" do
+    before do
+      Dummy.class_eval do
+        validates_attachment_presence :avatar, if: :go
+        attr_accessor :go
+      end
+    end
+
+    it "runs the validation if the control is true" do
+      dummy = Dummy.new
+      dummy.avatar = nil
+      dummy.go = true
+      expect(matcher).to accept(dummy)
+    end
+
+    it "does not run the validation if the control is false" do
+      dummy = Dummy.new
+      dummy.avatar = nil
+      dummy.go = false
+      expect(matcher).to_not accept(dummy)
+    end
+  end
+
+  private
+
+  def matcher
+    self.class.validate_attachment_presence(:avatar)
+  end
+end

data/spec/paperclip/matchers/validate_attachment_size_matcher_spec.rb

@@ -0,0 +1,88 @@
+require 'spec_helper'
+require 'paperclip/matchers'
+
+describe Paperclip::Shoulda::Matchers::ValidateAttachmentSizeMatcher do
+  extend Paperclip::Shoulda::Matchers
+
+  before do
+    reset_table("dummies") do |d|
+      d.string :avatar_file_name
+      d.integer :avatar_file_size
+    end
+    reset_class "Dummy"
+    Dummy.do_not_validate_attachment_file_type :avatar
+    Dummy.has_attached_file :avatar
+  end
+
+  context "Limiting size" do
+    it "rejects a class with no validation" do
+      expect(matcher.in(256..1024)).to_not accept(Dummy)
+    end
+
+    it "rejects a class with a validation that's too high" do
+      Dummy.validates_attachment_size :avatar, in: 256..2048
+      expect(matcher.in(256..1024)).to_not accept(Dummy)
+    end
+
+    it "accepts a class with a validation that's too low" do
+      Dummy.validates_attachment_size :avatar, in: 0..1024
+      expect(matcher.in(256..1024)).to_not accept(Dummy)
+    end
+
+    it "accepts a class with a validation that matches" do
+      Dummy.validates_attachment_size :avatar, in: 256..1024
+      expect(matcher.in(256..1024)).to accept(Dummy)
+    end
+  end
+
+  context "allowing anything" do
+    it "given a class with an upper limit" do
+      Dummy.validates_attachment_size :avatar, less_than: 1
+      expect(matcher).to accept(Dummy)
+    end
+
+    it "given a class with a lower limit" do
+      Dummy.validates_attachment_size :avatar, greater_than: 1
+      expect(matcher).to accept(Dummy)
+    end
+  end
+
+  context "using an :if to control the validation" do
+    before do
+      Dummy.class_eval do
+        validates_attachment_size :avatar, greater_than: 1024, if: :go
+        attr_accessor :go
+      end
+    end
+
+    it "run the validation if the control is true" do
+      dummy = Dummy.new
+      dummy.go = true
+      expect(matcher.greater_than(1024)).to accept(dummy)
+    end
+
+    it "not run the validation if the control is false" do
+      dummy = Dummy.new
+      dummy.go = false
+      expect(matcher.greater_than(1024)).to_not accept(dummy)
+    end
+  end
+
+  context "post processing" do
+    before do
+      Dummy.validates_attachment_size :avatar, greater_than: 1024
+    end
+
+    it "be skipped" do
+      dummy = Dummy.new
+      dummy.avatar.expects(:post_process).never
+      expect(matcher.greater_than(1024)).to accept(dummy)
+    end
+  end
+
+  private
+
+  def matcher
+    self.class.validate_attachment_size(:avatar)
+  end
+end

data/spec/paperclip/media_type_spoof_detector_spec.rb

@@ -0,0 +1,79 @@
+require 'spec_helper'
+
+describe Paperclip::MediaTypeSpoofDetector do
+  it 'rejects a file that is named .html and identifies as PNG' do
+    file = File.open(fixture_file("5k.png"))
+    assert Paperclip::MediaTypeSpoofDetector.using(file, "5k.html", "image/png").spoofed?
+  end
+
+  it 'does not reject a file that is named .jpg and identifies as PNG' do
+    file = File.open(fixture_file("5k.png"))
+    assert ! Paperclip::MediaTypeSpoofDetector.using(file, "5k.jpg", "image/png").spoofed?
+  end
+
+  it 'does not reject a file that is named .html and identifies as HTML' do
+    file = File.open(fixture_file("empty.html"))
+    assert ! Paperclip::MediaTypeSpoofDetector.using(file, "empty.html", "text/html").spoofed?
+  end
+
+  it 'does not reject a file that does not have a name' do
+    file = File.open(fixture_file("empty.html"))
+    assert ! Paperclip::MediaTypeSpoofDetector.using(file, "", "text/html").spoofed?
+  end
+
+  it 'does not reject a file that does have an extension' do
+    file = File.open(fixture_file("empty.html"))
+    assert ! Paperclip::MediaTypeSpoofDetector.using(file, "data", "text/html").spoofed?
+  end
+
+  it 'does not reject when the supplied file is an IOAdapter' do
+    adapter = Paperclip.io_adapters.for(File.new(fixture_file("5k.png")))
+    assert ! Paperclip::MediaTypeSpoofDetector.using(adapter, adapter.original_filename, adapter.content_type).spoofed?
+  end
+
+  it 'does not reject when the extension => content_type is in :content_type_mappings' do
+    begin
+      Paperclip.options[:content_type_mappings] = { pem: "text/plain" }
+      file = Tempfile.open(["test", ".PEM"])
+      file.puts "Certificate!"
+      file.close
+      adapter = Paperclip.io_adapters.for(File.new(file.path));
+      assert ! Paperclip::MediaTypeSpoofDetector.using(adapter, adapter.original_filename, adapter.content_type).spoofed?
+    ensure
+      Paperclip.options[:content_type_mappings] = {}
+    end
+  end
+
+  context "file named .html and is as HTML, but we're told JPG" do
+    let(:file) { File.open(fixture_file("empty.html")) }
+    let(:spoofed?) { Paperclip::MediaTypeSpoofDetector.using(file, "empty.html", "image/jpg").spoofed? }
+
+    it "rejects the file" do
+      assert spoofed?
+    end
+
+    it "logs info about the detected spoof" do
+      Paperclip.expects(:log).with('Content Type Spoof: Filename empty.html (image/jpg from Headers, ["text/html"] from Extension), content type discovered from file command: text/html. See documentation to allow this combination.')
+      spoofed?
+    end
+  end
+
+  it "does not reject if content_type is empty but otherwise checks out" do
+    file = File.open(fixture_file("empty.html"))
+    assert ! Paperclip::MediaTypeSpoofDetector.using(file, "empty.html", "").spoofed?
+  end
+
+  it 'does allow array as :content_type_mappings' do
+    begin
+      Paperclip.options[:content_type_mappings] = {
+        html: ['binary', 'text/html']
+      }
+      file = File.open(fixture_file('empty.html'))
+      spoofed = Paperclip::MediaTypeSpoofDetector
+                .using(file, "empty.html", "text/html").spoofed?
+      assert !spoofed
+    ensure
+      Paperclip.options[:content_type_mappings] = {}
+    end
+  end
+end

data/spec/paperclip/meta_class_spec.rb

@@ -0,0 +1,30 @@
+require 'spec_helper'
+
+describe 'Metaclasses' do
+  context "A meta-class of dummy" do
+    if active_support_version >= "4.1" || ruby_version < "2.1"
+      before do
+        rebuild_model
+        reset_class("Dummy")
+      end
+
+      it "is able to use Paperclip like a normal class" do
+        @dummy = Dummy.new
+
+        assert_nothing_raised do
+          rebuild_meta_class_of(@dummy)
+        end
+      end
+
+      it "works like any other instance" do
+        @dummy = Dummy.new
+        rebuild_meta_class_of(@dummy)
+
+        assert_nothing_raised do
+          @dummy.avatar = File.new(fixture_file("5k.png"), 'rb')
+        end
+        assert @dummy.save
+      end
+    end
+  end
+end

data/spec/paperclip/paperclip_missing_attachment_styles_spec.rb

@@ -0,0 +1,84 @@
+require 'spec_helper'
+
+describe 'Missing Attachment Styles' do
+  before do
+    Paperclip::AttachmentRegistry.clear
+  end
+
+  after do
+    File.unlink(Paperclip.registered_attachments_styles_path) rescue nil
+  end
+
+  it "enables to get and set path to registered styles file" do
+    assert_equal ROOT.join('tmp/public/system/paperclip_attachments.yml').to_s, Paperclip.registered_attachments_styles_path
+    Paperclip.registered_attachments_styles_path = '/tmp/config/paperclip_attachments.yml'
+    assert_equal '/tmp/config/paperclip_attachments.yml', Paperclip.registered_attachments_styles_path
+    Paperclip.registered_attachments_styles_path = nil
+    assert_equal ROOT.join('tmp/public/system/paperclip_attachments.yml').to_s, Paperclip.registered_attachments_styles_path
+  end
+
+  it "is able to get current attachment styles" do
+    assert_equal Hash.new, Paperclip.send(:current_attachments_styles)
+    rebuild_model styles: {croppable: '600x600>', big: '1000x1000>'}
+    expected_hash = { Dummy: {avatar: [:big, :croppable]}}
+    assert_equal expected_hash, Paperclip.send(:current_attachments_styles)
+  end
+
+  it "is able to save current attachment styles for further comparison" do
+    rebuild_model styles: {croppable: '600x600>', big: '1000x1000>'}
+    Paperclip.save_current_attachments_styles!
+    expected_hash = { Dummy: {avatar: [:big, :croppable]}}
+    assert_equal expected_hash, YAML.load_file(Paperclip.registered_attachments_styles_path)
+  end
+
+  it "is able to read registered attachment styles from file" do
+    rebuild_model styles: {croppable: '600x600>', big: '1000x1000>'}
+    Paperclip.save_current_attachments_styles!
+    expected_hash = { Dummy: {avatar: [:big, :croppable]}}
+    assert_equal expected_hash, Paperclip.send(:get_registered_attachments_styles)
+  end
+
+  it "is able to calculate differences between registered styles and current styles" do
+    rebuild_model styles: {croppable: '600x600>', big: '1000x1000>'}
+    Paperclip.save_current_attachments_styles!
+    rebuild_model styles: {thumb: 'x100', export: 'x400>', croppable: '600x600>', big: '1000x1000>'}
+    expected_hash = { Dummy: {avatar: [:export, :thumb]} }
+    assert_equal expected_hash, Paperclip.missing_attachments_styles
+
+    ActiveRecord::Base.connection.create_table :books, force: true
+    class ::Book < ActiveRecord::Base
+      has_attached_file :cover, styles: {small: 'x100', large: '1000x1000>'}
+      has_attached_file :sample, styles: {thumb: 'x100'}
+    end
+
+    expected_hash = {
+      Dummy: {avatar: [:export, :thumb]},
+      Book: {sample: [:thumb], cover: [:large, :small]}
+    }
+    assert_equal expected_hash, Paperclip.missing_attachments_styles
+    Paperclip.save_current_attachments_styles!
+    assert_equal Hash.new, Paperclip.missing_attachments_styles
+  end
+
+  it "is able to calculate differences when a new attachment is added to a model" do
+    rebuild_model styles: {croppable: '600x600>', big: '1000x1000>'}
+    Paperclip.save_current_attachments_styles!
+
+    class ::Dummy
+      has_attached_file :photo, styles: {small: 'x100', large: '1000x1000>'}
+    end
+
+    expected_hash = {
+      Dummy: {photo: [:large, :small]}
+    }
+    assert_equal expected_hash, Paperclip.missing_attachments_styles
+    Paperclip.save_current_attachments_styles!
+    assert_equal Hash.new, Paperclip.missing_attachments_styles
+  end
+
+  # It's impossible to build styles hash without loading from database whole bunch of records
+  it "skips lambda-styles" do
+    rebuild_model styles: lambda{ |attachment| attachment.instance.other == 'a' ? {thumb: "50x50#"} : {large: "400x400"} }
+    assert_equal Hash.new, Paperclip.send(:current_attachments_styles)
+  end
+end

data/spec/paperclip/paperclip_spec.rb

@@ -0,0 +1,222 @@
+require 'spec_helper'
+
+describe Paperclip do
+  context ".run" do
+    before do
+      Paperclip.options[:log_command] = false
+      Cocaine::CommandLine.expects(:new).with("convert", "stuff", {}).returns(stub(:run))
+      @original_command_line_path = Cocaine::CommandLine.path
+    end
+
+    after do
+      Paperclip.options[:log_command] = true
+      Cocaine::CommandLine.path = @original_command_line_path
+    end
+
+    it "runs the command with Cocaine" do
+      Paperclip.run("convert", "stuff")
+    end
+
+    it "saves Cocaine::CommandLine.path that set before" do
+      Cocaine::CommandLine.path = "/opt/my_app/bin"
+      Paperclip.run("convert", "stuff")
+      expect(Cocaine::CommandLine.path).to match("/opt/my_app/bin")
+    end
+
+    it "does not duplicate Cocaine::CommandLine.path on multiple runs" do
+      Cocaine::CommandLine.expects(:new).with("convert", "more_stuff", {}).returns(stub(:run))
+      Cocaine::CommandLine.path = nil
+      Paperclip.options[:command_path] = "/opt/my_app/bin"
+      Paperclip.run("convert", "stuff")
+      Paperclip.run("convert", "more_stuff")
+      assert_equal 1, [Cocaine::CommandLine.path].flatten.size
+    end
+  end
+
+  it 'does not raise errors when doing a lot of running' do
+    Paperclip.options[:command_path] = ["/usr/local/bin"] * 1024
+    Cocaine::CommandLine.path = "/something/else"
+    100.times do |x|
+      Paperclip.run("echo", x.to_s)
+    end
+  end
+
+  context "Calling Paperclip.log without options[:logger] set" do
+    before do
+      Paperclip.logger = nil
+      Paperclip.options[:logger] = nil
+    end
+
+    after do
+      Paperclip.options[:logger] = ActiveRecord::Base.logger
+      Paperclip.logger = ActiveRecord::Base.logger
+    end
+
+    it "does not raise an error when log is called" do
+      silence_stream(STDOUT) do
+        Paperclip.log('something')
+      end
+    end
+  end
+  context "Calling Paperclip.run with a logger" do
+    it "passes the defined logger if :log_command is set" do
+      Paperclip.options[:log_command] = true
+      Cocaine::CommandLine.expects(:new).with("convert", "stuff", logger: Paperclip.logger).returns(stub(:run))
+      Paperclip.run("convert", "stuff")
+    end
+  end
+
+  context "Paperclip.each_instance_with_attachment" do
+    before do
+      @file = File.new(fixture_file("5k.png"), 'rb')
+      d1 = Dummy.create(avatar: @file)
+      d2 = Dummy.create
+      d3 = Dummy.create(avatar: @file)
+      @expected = [d1, d3]
+    end
+
+    after { @file.close }
+
+    it "yields every instance of a model that has an attachment" do
+      actual = []
+      Paperclip.each_instance_with_attachment("Dummy", "avatar") do |instance|
+        actual << instance
+      end
+      expect(actual).to match_array @expected
+    end
+  end
+
+  it "raises when sent #processor and the name of a class that doesn't exist" do
+    assert_raises(LoadError){ Paperclip.processor(:boogey_man) }
+  end
+
+  it "returns a class when sent #processor and the name of a class under Paperclip" do
+    assert_equal ::Paperclip::Thumbnail, Paperclip.processor(:thumbnail)
+  end
+
+  it "gets a class from a namespaced class name" do
+    class ::One; class Two; end; end
+    assert_equal ::One::Two, Paperclip.class_for("One::Two")
+  end
+
+  it "raises when class doesn't exist in specified namespace" do
+    class ::Three; end
+    class ::Four; end
+    assert_raises NameError do
+      Paperclip.class_for("Three::Four")
+    end
+  end
+
+  context "An ActiveRecord model with an 'avatar' attachment" do
+    before do
+      Paperclip::Deprecations.stubs(:check)
+      rebuild_model path: "tmp/:class/omg/:style.:extension"
+      @file = File.new(fixture_file("5k.png"), 'rb')
+    end
+
+    after { @file.close }
+
+    it "does not error when trying to also create a 'blah' attachment" do
+      assert_nothing_raised do
+        Dummy.class_eval do
+          has_attached_file :blah
+        end
+      end
+    end
+
+    if using_protected_attributes?
+      context "that is attr_protected" do
+        before do
+          Dummy.class_eval do
+            attr_protected :avatar
+          end
+          @dummy = Dummy.new
+        end
+
+        it "does not assign the avatar on mass-set" do
+          @dummy.attributes = { other: "I'm set!",
+                                avatar: @file }
+
+          assert_equal "I'm set!", @dummy.other
+          assert ! @dummy.avatar?
+        end
+
+        it "allows assigment on normal set" do
+          @dummy.other  = "I'm set!"
+          @dummy.avatar = @file
+
+          assert_equal "I'm set!", @dummy.other
+          assert @dummy.avatar?
+        end
+      end
+    end
+
+    it "calls Paperclip::Deprecations.check" do
+      expect(Paperclip::Deprecations).to have_received(:check)
+    end
+
+    context "with a subclass" do
+      before do
+        class ::SubDummy < Dummy; end
+      end
+
+      it "is able to use the attachment from the subclass" do
+        assert_nothing_raised do
+          @subdummy = SubDummy.create(avatar: @file)
+        end
+      end
+
+      after do
+        SubDummy.delete_all
+        Object.send(:remove_const, "SubDummy") rescue nil
+      end
+    end
+
+    it "has an avatar getter method" do
+      assert Dummy.new.respond_to?(:avatar)
+    end
+
+    it "has an avatar setter method" do
+      assert Dummy.new.respond_to?(:avatar=)
+    end
+
+    context "that is valid" do
+      before do
+        @dummy = Dummy.new
+        @dummy.avatar = @file
+      end
+
+      it "is valid" do
+        assert @dummy.valid?
+      end
+    end
+
+    it "does not have Attachment in the ActiveRecord::Base namespace" do
+      assert_raises(NameError) do
+        ActiveRecord::Base::Attachment
+      end
+    end
+  end
+
+  context "configuring a custom processor" do
+    before do
+      @freedom_processor = Class.new do
+        def make(file, options = {}, attachment = nil)
+          file
+        end
+      end.new
+
+      Paperclip.configure do |config|
+        config.register_processor(:freedom, @freedom_processor)
+      end
+    end
+
+    it "is able to find the custom processor" do
+      assert_equal @freedom_processor, Paperclip.processor(:freedom)
+    end
+
+    after do
+      Paperclip.clear_processors!
+    end
+  end
+end