pact_broker 2.77.0 → 2.80.0

data/spec/lib/pact_broker/relationships/groupify_spec.rb

@@ -1,6 +1,6 @@
-require 'spec_helper'
-require 'pact_broker/relationships/groupify'
-require 'pact_broker/domain/index_item'
+require "spec_helper"
+require "pact_broker/relationships/groupify"
+require "pact_broker/domain/index_item"
 
 module PactBroker
 
@@ -10,18 +10,18 @@ module PactBroker
 
       describe ".call" do
 
-        let(:consumer_a) { double('consumer a', id: 1, name: 'consumer a') }
-        let(:consumer_b) { double('consumer b', id: 2, name: 'consumer b') }
-        let(:consumer_c) { double('consumer c', id: 3, name: 'consumer c') }
+        let(:consumer_a) { double("consumer a", id: 1, name: "consumer a") }
+        let(:consumer_b) { double("consumer b", id: 2, name: "consumer b") }
+        let(:consumer_c) { double("consumer c", id: 3, name: "consumer c") }
 
-        let(:consumer_l) { double('consumer l', id: 4, name: 'consumer l') }
-        let(:consumer_m) { double('consumer m', id: 5, name: 'consumer m') }
+        let(:consumer_l) { double("consumer l", id: 4, name: "consumer l") }
+        let(:consumer_m) { double("consumer m", id: 5, name: "consumer m") }
 
-        let(:provider_p) { double('provider p', id: 6, name: 'provider p') }
+        let(:provider_p) { double("provider p", id: 6, name: "provider p") }
 
-        let(:provider_x) { double('provider x', id: 7, name: 'provider x') }
-        let(:provider_y) { double('provider y', id: 8, name: 'provider y') }
-        let(:provider_z) { double('provider z', id: 9, name: 'provider z') }
+        let(:provider_x) { double("provider x", id: 7, name: "provider x") }
+        let(:provider_y) { double("provider y", id: 8, name: "provider y") }
+        let(:provider_z) { double("provider z", id: 9, name: "provider z") }
 
         let(:relationship_1) { Domain::IndexItem.new(consumer_a, provider_x) }
         let(:relationship_4) { Domain::IndexItem.new(consumer_a, provider_y) }

data/spec/lib/pact_broker/tags/repository_spec.rb

@@ -1,5 +1,5 @@
-require 'spec_helper'
-require 'pact_broker/tags/repository'
+require "spec_helper"
+require "pact_broker/tags/repository"
 
 module PactBroker
   module Tags

data/spec/lib/pact_broker/tags/service_spec.rb

@@ -1,5 +1,5 @@
-require 'spec_helper'
-require 'pact_broker/tags/service'
+require "spec_helper"
+require "pact_broker/tags/service"
 
 module PactBroker
   module Tags

data/spec/lib/pact_broker/ui/controllers/can_i_deploy_spec.rb

@@ -1,4 +1,4 @@
-require 'pact_broker/ui/controllers/can_i_deploy'
+require "pact_broker/ui/controllers/can_i_deploy"
 
 module PactBroker
   module UI

data/spec/lib/pact_broker/ui/controllers/clusters_spec.rb

@@ -1,6 +1,6 @@
-require 'spec_helper'
-require 'pact_broker/ui/controllers/clusters'
-require 'rack/test'
+require "spec_helper"
+require "pact_broker/ui/controllers/clusters"
+require "rack/test"
 
 module PactBroker
   module UI

data/spec/lib/pact_broker/ui/controllers/index_spec.rb

@@ -1,6 +1,6 @@
-require 'rack/test'
-require 'pact_broker/ui/controllers/index'
-require 'pact_broker/index/service'
+require "rack/test"
+require "pact_broker/ui/controllers/index"
+require "pact_broker/index/service"
 
 module PactBroker
   module UI
@@ -16,8 +16,16 @@ module PactBroker
 
             before do
               TestDataBuilder.new
-                .create_consumer
-                .create_provider
+                .create_consumer("Test App")
+                .create_provider("Test API")
+                .create_consumer_version
+                .create_pact
+                .create_webhook
+                .create_verification
+
+              TestDataBuilder.new
+                .create_consumer("Example App")
+                .create_provider("Example API")
                 .create_consumer_version
                 .create_pact
                 .create_webhook
@@ -33,7 +41,7 @@ module PactBroker
             context "when pagination parameters are present" do
               it "passes through pagination parameters to the search" do
                 expect(PactBroker::Index::Service).to receive(:find_index_items).with(hash_including(page_number: 2, page_size: 40))
-                get "/", { page: '2', pageSize: '40' }
+                get "/", { page: "2", pageSize: "40" }
               end
             end
 
@@ -41,7 +49,7 @@ module PactBroker
               context "when tags=true" do
                 it "passes through default pagination parameters to the search with page_size=30" do
                   expect(PactBroker::Index::Service).to receive(:find_index_items).with(hash_including(page_number: 1, page_size: 30))
-                  get "/", { tags: 'true' }
+                  get "/", { tags: "true" }
                 end
               end
 
@@ -60,7 +68,7 @@ module PactBroker
 
               it "passes tags: true to the IndexService" do
                 expect(PactBroker::Index::Service).to receive(:find_index_items).with(hash_including(tags: true))
-                get "/", { tags: 'true' }
+                get "/", { tags: "true" }
               end
             end
 
@@ -85,6 +93,37 @@ module PactBroker
                 get "/", { tags: "prod" }
               end
             end
+
+            context "when parameter search presents" do
+              context "when it is blank" do
+                it "ignores it" do
+                  get "/", { search_name: "" }
+
+                  expect(last_response.body).to include("Example App")
+                  expect(last_response.status).to eq(200)
+                end
+              end
+
+              context "when it is NOT blank and the pacticipant name exists" do
+                it "returns the pacticipant which matches the query" do
+                  get "/", { search: "app" }
+
+                  expect(last_response.body).to include("Example App")
+                  expect(last_response.status).to eq(200)
+                end
+              end
+
+              context "when it is NOT blank but the pacticipant name does NOT exist" do
+                it "returns no pacts" do
+                  get "/", { search: "does not exist" }
+
+                  expect(last_response.body).not_to include("does not exit")
+                  expect(last_response.body).not_to include("Example App")
+                  expect(last_response.body).not_to include("Test App")
+                  expect(last_response.status).to eq(200)
+                end
+              end
+            end
           end
         end
       end

data/spec/lib/pact_broker/ui/view_models/index_item_spec.rb

@@ -1,27 +1,27 @@
-require 'spec_helper'
-require 'pact_broker/ui/view_models/index_item'
-require 'pact_broker/domain/index_item'
+require "spec_helper"
+require "pact_broker/ui/view_models/index_item"
+require "pact_broker/domain/index_item"
 
 module PactBroker
   module UI
     module ViewDomain
       describe IndexItem do
 
-        let(:consumer) { instance_double("PactBroker::Domain::Pacticipant", name: 'Consumer Name')}
-        let(:provider) { instance_double("PactBroker::Domain::Pacticipant", name: 'Provider Name')}
+        let(:consumer) { instance_double("PactBroker::Domain::Pacticipant", name: "Consumer Name")}
+        let(:provider) { instance_double("PactBroker::Domain::Pacticipant", name: "Provider Name")}
         let(:latest_pact) { instance_double("PactBroker::Domain::Pact", consumer_version_number: "1.2.3") }
         let(:latest_verification) { instance_double("PactBroker::Domain::Verification") }
         let(:domain_relationship) { PactBroker::Domain::IndexItem.new(consumer, provider, latest_pact, latest, latest_verification, [], [], tags, latest_verification_latest_tags)}
         let(:tags) { [] }
-        let(:verification_tag_1) { instance_double("PactBroker::Tags::TagWithLatestFlag", name: 'dev') }
-        let(:verification_tag_2) { instance_double("PactBroker::Tags::TagWithLatestFlag", name: 'prod') }
+        let(:verification_tag_1) { instance_double("PactBroker::Tags::TagWithLatestFlag", name: "dev") }
+        let(:verification_tag_2) { instance_double("PactBroker::Tags::TagWithLatestFlag", name: "prod") }
         let(:latest_verification_latest_tags) { [verification_tag_1, verification_tag_2]  }
         let(:latest) { true }
 
         subject { IndexItem.new(domain_relationship) }
 
-        its(:consumer_name) { should eq 'Consumer Name'}
-        its(:provider_name) { should eq 'Provider Name'}
+        its(:consumer_name) { should eq "Consumer Name"}
+        its(:provider_name) { should eq "Provider Name"}
         its(:latest_pact_url) { should eq "/pacts/provider/Provider%20Name/consumer/Consumer%20Name/latest" }
         its(:pact_url) { should eq "/pacts/provider/Provider%20Name/consumer/Consumer%20Name/version/1.2.3" }
         its(:pact_matrix_url) { should eq "/matrix/provider/Provider%20Name/consumer/Consumer%20Name" }

data/spec/lib/pact_broker/ui/view_models/index_items_spec.rb

@@ -1,6 +1,6 @@
-require 'spec_helper'
-require 'pact_broker/ui/view_models/index_items'
-require 'pact_broker/index/page'
+require "spec_helper"
+require "pact_broker/ui/view_models/index_items"
+require "pact_broker/index/page"
 
 module PactBroker
   module UI

data/spec/lib/pact_broker/ui/view_models/matrix_deployed_version_spec.rb

@@ -0,0 +1,29 @@
+require "pact_broker/ui/view_models/matrix_deployed_version"
+
+module PactBroker
+  module UI
+    module ViewDomain
+      describe MatrixDeployedVersion do
+        before do
+          allow(subject).to receive(:deployed_version_url).and_return("http://deployed_version")
+          allow(subject).to receive(:hal_browser_url) do | url |
+            "http://halbrowser#" + url
+          end
+        end
+        subject(:matrix_deployed_version) { MatrixDeployedVersion.new(deployed_version) }
+        let(:deployed_version) do
+          instance_double("PactBroker::Deployments::DeployedVersion",
+            environment: environment,
+            created_at: created_at
+          )
+        end
+        let(:created_at) { DateTime.now - 1 }
+        let(:environment) { instance_double("PactBroker::Deployments::Environment", name: "test", display_name: "Test") }
+
+        its(:environment_name) { is_expected.to eq "test" }
+        its(:tooltip) { is_expected.to eq "Currently deployed to Test (1 day ago)" }
+        its(:url) { is_expected.to eq "http://halbrowser#http://deployed_version" }
+      end
+    end
+  end
+end

data/spec/lib/pact_broker/verifications/pseudo_branch_status_spec.rb

@@ -1,4 +1,4 @@
-require 'pact_broker/verifications/pseudo_branch_status'
+require "pact_broker/verifications/pseudo_branch_status"
 
 module PactBroker
   module Verifications
@@ -7,8 +7,8 @@ module PactBroker
 
         let(:latest_verification) { instance_double("PactBroker::Domain::Verification", pact_version_sha: latest_verification_pact_version_sha, success: success) }
         let(:latest_pact) { instance_double("PactBroker::Domain::Pact", pact_version_sha: pact_pact_version_sha) }
-        let(:pact_pact_version_sha) { '1234' }
-        let(:latest_verification_pact_version_sha) { '1234' }
+        let(:pact_pact_version_sha) { "1234" }
+        let(:latest_verification_pact_version_sha) { "1234" }
         let(:success) { true }
 
         subject { PseudoBranchStatus.new(latest_pact, latest_verification) }
@@ -33,12 +33,12 @@ module PactBroker
         end
 
         context "when the pact has changed since the last successful verification" do
-          let(:pact_pact_version_sha) { '4566' }
+          let(:pact_pact_version_sha) { "4566" }
           its(:to_sym) { is_expected.to eq :stale }
         end
 
         context "when the pact has changed since the last failed verification" do
-          let(:pact_pact_version_sha) { '4566' }
+          let(:pact_pact_version_sha) { "4566" }
           let(:success) { false }
           its(:to_sym) { is_expected.to eq :failed }
         end

data/spec/lib/pact_broker/verifications/repository_spec.rb

@@ -1,4 +1,4 @@
-require 'pact_broker/verifications/repository'
+require "pact_broker/verifications/repository"
 
 module PactBroker
   module Verifications
@@ -36,7 +36,7 @@ module PactBroker
 
           builder
             .create_verification(number: 1)
-            .create_verification(number: 2, provider_version: '3.7.4')
+            .create_verification(number: 2, provider_version: "3.7.4")
             .create_consumer_version("1.2.3")
             .create_pact
             .create_verification(number: 1)
@@ -199,14 +199,14 @@ module PactBroker
               .create_pact
           end
 
-          subject { Repository.new.find_latest_verification_for("Consumer1", "Provider1", 'prod')}
+          subject { Repository.new.find_latest_verification_for("Consumer1", "Provider1", "prod")}
 
           it "finds the latest verifications for the given consumer version with the specified tag" do
             expect(subject.provider_version_number).to eq "5.4.3"
           end
 
           context "when no verification exists" do
-            subject { Repository.new.find_latest_verification_for("Consumer1", "Provider1", 'foo')}
+            subject { Repository.new.find_latest_verification_for("Consumer1", "Provider1", "foo")}
 
             it "returns nil" do
               expect(subject).to be nil

data/spec/lib/pact_broker/verifications/sequence_spec.rb

@@ -1,4 +1,4 @@
-require 'pact_broker/verifications/sequence'
+require "pact_broker/verifications/sequence"
 
 module PactBroker
   module Verifications

data/spec/lib/pact_broker/verifications/service_spec.rb

@@ -1,7 +1,7 @@
-require 'pact_broker/verifications/service'
-require 'pact_broker/verifications/repository'
-require 'pact_broker/webhooks/execution_configuration'
-require 'pact_broker/webhooks/trigger_service'
+require "pact_broker/verifications/service"
+require "pact_broker/verifications/repository"
+require "pact_broker/webhooks/execution_configuration"
+require "pact_broker/webhooks/trigger_service"
 
 module PactBroker
 
@@ -11,28 +11,26 @@ module PactBroker
         allow(Service).to receive(:logger).and_return(logger)
       end
 
-      let(:logger) { double('logger').as_null_object }
+      let(:logger) { double("logger").as_null_object }
 
       subject { PactBroker::Verifications::Service }
 
       describe "#create" do
         before do
-          allow(PactBroker::Webhooks::TriggerService).to receive(:trigger_webhooks_for_verification_results_publication)
-          allow(webhook_execution_configuration).to receive(:with_webhook_context).and_return(webhook_execution_configuration)
+          allow(Service).to receive(:broadcast)
         end
 
-        let(:options) { { webhook_execution_configuration: webhook_execution_configuration } }
         let(:event_context) { { some: "data" } }
         let(:expected_event_context) { { some: "data", provider_version_tags: ["dev"] } }
-        let(:webhook_execution_configuration) { instance_double(PactBroker::Webhooks::ExecutionConfiguration) }
-        let(:params) { { 'success' => true, 'providerApplicationVersion' => '4.5.6', 'wip' => true, 'testResults' => { 'some' => 'results' }} }
+        let(:params) { { "success" => success, "providerApplicationVersion" => "4.5.6", "wip" => true, "testResults" => { "some" => "results" }} }
+        let(:success) { true }
         let(:pact) do
           td.create_pact_with_hierarchy
-            .create_provider_version('4.5.6')
-            .create_provider_version_tag('dev')
+            .create_provider_version("4.5.6")
+            .create_provider_version_tag("dev")
             .and_return(:pact)
         end
-        let(:create_verification) { subject.create 3, params, pact, event_context, options }
+        let(:create_verification) { subject.create 3, params, pact, event_context }
 
         it "logs the creation" do
           expect(logger).to receive(:info).with(/.*verification.*3/, payload: {"providerApplicationVersion"=>"4.5.6", "success"=>true, "wip"=>true})
@@ -44,7 +42,7 @@ module PactBroker
           expect(verification.wip).to be true
           expect(verification.success).to be true
           expect(verification.number).to eq 3
-          expect(verification.test_results).to eq 'some' => 'results'
+          expect(verification.test_results).to eq "some" => "results"
         end
 
         it "sets the pact content for the verification" do
@@ -56,23 +54,30 @@ module PactBroker
         it "sets the provider version" do
           verification = create_verification
           expect(verification.provider_version).to_not be nil
-          expect(verification.provider_version_number).to eq '4.5.6'
+          expect(verification.provider_version_number).to eq "4.5.6"
         end
 
-        it "sets the provider version tags on the webhook execution configuration" do
-          expect(webhook_execution_configuration).to receive(:with_webhook_context).with(provider_version_tags: %w[dev])
+        it "it broadcasts the provider_verification_published event" do
+          expect(Service).to receive(:broadcast).with(:provider_verification_published, pact: pact, verification: instance_of(PactBroker::Domain::Verification), event_context: hash_including(provider_version_tags: %w[dev]))
           create_verification
         end
 
-        it "invokes the webhooks for the verification" do
-          verification = create_verification
-          expect(PactBroker::Webhooks::TriggerService).to have_received(:trigger_webhooks_for_verification_results_publication).with(
-            pact,
-            verification,
-            expected_event_context,
-            options
-          )
+        context "when the verification is successful" do
+          it "it broadcasts the provider_verification_succeeded event" do
+            expect(Service).to receive(:broadcast).with(:provider_verification_succeeded, pact: pact, verification: instance_of(PactBroker::Domain::Verification), event_context: hash_including(provider_version_tags: %w[dev]))
+            create_verification
+          end
         end
+
+        context "when the verification is not successful" do
+          let(:success) { false }
+
+          it "it broadcasts the provider_verification_failed event" do
+            expect(Service).to receive(:broadcast).with(:provider_verification_failed, pact: pact, verification: instance_of(PactBroker::Domain::Verification), event_context: hash_including(provider_version_tags: %w[dev]))
+            create_verification
+          end
+        end
+
       end
 
       describe "#errors" do

data/spec/lib/pact_broker/verifications/summary_for_consumer_version_spec.rb

@@ -1,4 +1,4 @@
-require 'pact_broker/verifications/summary_for_consumer_version'
+require "pact_broker/verifications/summary_for_consumer_version"
 
 module PactBroker
   module Verifications
@@ -8,19 +8,19 @@ module PactBroker
       let(:verification_1) do
         instance_double("PactBroker::Domain::Verification",
           success: true,
-          provider_name: 'Successful Provider'
+          provider_name: "Successful Provider"
         )
       end
       let(:verification_2) do
         instance_double("PactBroker::Domain::Verification",
           success: false,
-          provider_name: 'Failed Provider'
+          provider_name: "Failed Provider"
         )
       end
 
-      let(:pact_1) { instance_double("pact", provider_name: 'Successful Provider') }
-      let(:pact_2) { instance_double("pact", provider_name: 'Failed Provider') }
-      let(:pact_3) { instance_double("pact", provider_name: 'Unknown Provider') }
+      let(:pact_1) { instance_double("pact", provider_name: "Successful Provider") }
+      let(:pact_2) { instance_double("pact", provider_name: "Failed Provider") }
+      let(:pact_3) { instance_double("pact", provider_name: "Unknown Provider") }
 
       let(:pacts) do
         [pact_1, pact_2, pact_3]