pact_broker 2.77.0 → 2.80.0

data/spec/lib/pact_broker/app_spec.rb

@@ -1,4 +1,4 @@
-require 'pact_broker/app'
+require "pact_broker/app"
 
 module PactBroker
   describe App do
@@ -28,7 +28,7 @@ module PactBroker
 
     it "adds the X-Pact-Broker-Version header" do
       get "/"
-      expect(last_response.headers['X-Pact-Broker-Version']).to match /\d/
+      expect(last_response.headers["X-Pact-Broker-Version"]).to match(/\d/)
     end
 
     class Middleware
@@ -55,8 +55,8 @@ module PactBroker
     describe "before_resource and after_resource" do
       CALLBACKS = []
       before do
-        PactBroker.configuration.before_resource { | resource | CALLBACKS << "before" }
-        PactBroker.configuration.after_resource { | resource | CALLBACKS << "after" }
+        PactBroker.configuration.before_resource { | _resource | CALLBACKS << "before" }
+        PactBroker.configuration.after_resource { | _resource | CALLBACKS << "after" }
       end
 
       it "executes the callbacks" do
@@ -72,7 +72,7 @@ module PactBroker
       end
 
       context "when the UI returns a non 404 response" do
-        let(:custom_ui) { double('ui', call: [200, {}, ["hello"]]) }
+        let(:custom_ui) { double("ui", call: [200, {}, ["hello"]]) }
 
         it "returns the given page" do
           expect(last_response.body).to eq "hello"
@@ -80,7 +80,7 @@ module PactBroker
       end
 
       context "when the UI returns a 404 response" do
-        let(:custom_ui) { double('ui', call: [404, {}, []]) }
+        let(:custom_ui) { double("ui", call: [404, {}, []]) }
 
         it "passes on the call to the rest of the app" do
           expect(last_response.status).to eq 200
@@ -95,7 +95,7 @@ module PactBroker
       end
 
       context "when the API returns a non 404 response" do
-        let(:custom_api) { double('api', call: [200, {}, ["hello"]]) }
+        let(:custom_api) { double("api", call: [200, {}, ["hello"]]) }
 
         it "returns the given resource" do
           expect(last_response.body).to eq "hello"
@@ -103,7 +103,7 @@ module PactBroker
       end
 
       context "when the custom API returns a 404 response" do
-        let(:custom_api) { double('api', call: [404, {}, []]) }
+        let(:custom_api) { double("api", call: [404, {}, []]) }
 
         it "passes on the call to the rest of the app" do
           expect(last_response.body).to_not eq "hello"
@@ -113,9 +113,9 @@ module PactBroker
 
     describe "use_xxx_auth" do
       class TestAuth
-        def initialize app, *args, &block
+        def initialize app, *_args
           @app = Rack::Auth::Basic.new(app, "Protected") do | username, password |
-            username == 'foo' && password == 'bar'
+            username == "foo" && password == "bar"
           end
         end
 
@@ -128,11 +128,11 @@ module PactBroker
         it "allows the API to be protected" do
           app.use_api_auth TestAuth
 
-          basic_authorize 'foo', 'bar'
+          basic_authorize "foo", "bar"
           get "/"
           expect(last_response.status).to eq 200
 
-          basic_authorize 'foo', 'wrong'
+          basic_authorize "foo", "wrong"
           get "/"
           expect(last_response.status).to eq 401
           expect(last_response.headers["WWW-Authenticate"]).to eq "Basic realm=\"Protected\""
@@ -143,12 +143,12 @@ module PactBroker
         it "allows the UI to be protected" do
           app.use_ui_auth TestAuth
 
-          basic_authorize 'foo', 'bar'
-          get "/", nil, {'HTTP_ACCEPT' => 'text/html'}
+          basic_authorize "foo", "bar"
+          get "/", nil, {"HTTP_ACCEPT" => "text/html"}
           expect(last_response.status).to eq 200
 
-          basic_authorize 'foo', 'wrong'
-          get "/", nil, {'HTTP_ACCEPT' => 'text/html'}
+          basic_authorize "foo", "wrong"
+          get "/", nil, {"HTTP_ACCEPT" => "text/html"}
           expect(last_response.status).to eq 401
           expect(last_response.headers["WWW-Authenticate"]).to eq "Basic realm=\"Protected\""
         end
@@ -167,36 +167,36 @@ module PactBroker
           allow(TestAuth2).to receive(:new).and_return(test_auth_2)
         end
 
-        let(:test_auth_1) { instance_double('TestAuth1', call: [404, {}, []]) }
-        let(:test_auth_2) { instance_double('TestAuth2', call: [404, {}, []]) }
+        let(:test_auth_1) { instance_double("TestAuth1", call: [404, {}, []]) }
+        let(:test_auth_2) { instance_double("TestAuth2", call: [404, {}, []]) }
 
         it "calls the UI auth before the API auth" do
           expect(test_auth_1).to receive(:call).ordered
           expect(test_auth_2).to receive(:call).ordered
           app.use_ui_auth TestAuth1
           app.use_api_auth TestAuth2
-          get "/", nil, {'HTTP_ACCEPT' => 'text/html'}
+          get "/", nil, {"HTTP_ACCEPT" => "text/html"}
         end
       end
     end
 
     describe "authenticate" do
       before do
-        PactBroker.configuration.authenticate do | resource, authorization_header, options |
-          authorization_header == 'letmein'
+        PactBroker.configuration.authenticate do | _resource, authorization_header, _options |
+          authorization_header == "letmein"
         end
       end
 
       context "with an invalid Authorization header" do
         it "returns a 401" do
-          get "/", {}, {'HTTP_AUTHORIZATION' => 'wrong'}
+          get "/", {}, {"HTTP_AUTHORIZATION" => "wrong"}
           expect(last_response.status).to eq 401
         end
       end
 
       context "with valid Authorization header" do
         it "returns a 200" do
-          get "/", {}, {'HTTP_AUTHORIZATION' => 'letmein'}
+          get "/", {}, {"HTTP_AUTHORIZATION" => "letmein"}
           expect(last_response.status).to eq 200
         end
       end
@@ -204,14 +204,14 @@ module PactBroker
 
     describe "authenticate_with_basic_auth" do
       before do
-        PactBroker.configuration.authenticate_with_basic_auth do | resource, username, password, options |
-          username == 'username' && password == 'password'
+        PactBroker.configuration.authenticate_with_basic_auth do | _resource, username, password, _options |
+          username == "username" && password == "password"
         end
       end
 
       context "with a request for the API with incorrect username or password" do
         it "returns a 401" do
-          basic_authorize 'foo', 'password'
+          basic_authorize "foo", "password"
           get "/"
           expect(last_response.status).to eq 401
         end
@@ -219,15 +219,15 @@ module PactBroker
 
       context "with a request for the UI with incorrect username or password" do
         it "returns a 401" do
-          basic_authorize 'foo', 'password'
-          get "/", nil, {'HTTP_ACCEPT' => 'text/html'}
+          basic_authorize "foo", "password"
+          get "/", nil, {"HTTP_ACCEPT" => "text/html"}
           expect(last_response.status).to eq 401
         end
       end
 
       context "with a request for diagnostics with incorrect username or password" do
         it "returns a 401" do
-          basic_authorize 'foo', 'password'
+          basic_authorize "foo", "password"
           get "/diagnostic/status/heartbeat"
           expect(last_response.status).to eq 401
         end
@@ -235,7 +235,7 @@ module PactBroker
 
       context "with a request for the API with correct username and password" do
         it "returns a 200" do
-          basic_authorize 'username', 'password'
+          basic_authorize "username", "password"
           get "/"
           expect(last_response.status).to eq 200
         end
@@ -243,15 +243,15 @@ module PactBroker
 
       context "with a request for the UI with correct username or password" do
         it "returns a 200" do
-          basic_authorize 'username', 'password'
-          get "/", nil, {'HTTP_ACCEPT' => 'text/html'}
+          basic_authorize "username", "password"
+          get "/", nil, {"HTTP_ACCEPT" => "text/html"}
           expect(last_response.status).to eq 200
         end
       end
 
       context "with a request for diagnostics with correct username or password" do
         it "returns a 200" do
-          basic_authorize 'username', 'password'
+          basic_authorize "username", "password"
           get "/diagnostic/status/heartbeat"
           expect(last_response.status).to eq 200
         end
@@ -260,28 +260,28 @@ module PactBroker
 
     describe "authorize" do
       before do
-        PactBroker.configuration.authorize do | resource, options |
-          resource.request.headers['Role'] == 'important'
+        PactBroker.configuration.authorize do | resource, _options |
+          resource.request.headers["Role"] == "important"
         end
       end
 
       context "with a request for the API with an authorized request" do
         it "returns a 200" do
-          get "/", nil, {'HTTP_ROLE' => 'important'}
+          get "/", nil, {"HTTP_ROLE" => "important"}
           expect(last_response.status).to eq 200
         end
       end
 
       context "with a request for the UI with an authorized request" do
         it "returns a 200" do
-          get "/", nil, {'HTTP_ACCEPT' => 'text/html', 'HTTP_ROLE' => 'important'}
+          get "/", nil, {"HTTP_ACCEPT" => "text/html", "HTTP_ROLE" => "important"}
           expect(last_response.status).to eq 200
         end
       end
 
       context "with a request for diagnostics with an authorized request" do
         it "returns a 200" do
-          get "/diagnostic/status/heartbeat", nil, {'HTTP_ROLE' => 'important'}
+          get "/diagnostic/status/heartbeat", nil, {"HTTP_ROLE" => "important"}
           expect(last_response.status).to eq 200
         end
       end
@@ -295,7 +295,7 @@ module PactBroker
 
       context "with a request for the UI with an unauthorized request" do
         it "returns a 200 because there's no point doing authorization on the UI at the moment" do
-          get "/", nil, {'HTTP_ACCEPT' => 'text/html'}
+          get "/", nil, {"HTTP_ACCEPT" => "text/html"}
           expect(last_response.status).to eq 200
         end
       end
@@ -309,7 +309,7 @@ module PactBroker
     end
 
     describe "transactions", no_db_clean: true do
-      let(:pact_content) { load_fixture('a_consumer-a_provider.json') }
+      let(:pact_content) { load_fixture("a_consumer-a_provider.json") }
       let(:path) { "/pacts/provider/A%20Provider/consumer/A%20Consumer/versions/1.2.3" }
       let(:response_body_json) { JSON.parse(subject.body) }
 
@@ -322,7 +322,7 @@ module PactBroker
         PactBroker::Database.truncate
       end
 
-      subject { put path, pact_content, { 'CONTENT_TYPE' => 'application/json' }; last_response  }
+      subject { put path, pact_content, { "CONTENT_TYPE" => "application/json" }; last_response  }
 
       it "wraps the API with a database transaction" do
         expect { subject }.to_not change { PactBroker::Domain::Pacticipant.count }
@@ -330,10 +330,10 @@ module PactBroker
     end
 
     describe "when resource is not found" do
-      subject { get("/does/not/exist", nil, { 'CONTENT_TYPE' => 'application/hal+json' })  }
+      subject { get("/does/not/exist", nil, { "CONTENT_TYPE" => "application/hal+json" })  }
 
       it "returns a Content-Type of application/hal+json" do
-        expect(subject.headers['Content-Type']).to eq 'application/hal+json'
+        expect(subject.headers["Content-Type"]).to eq "application/hal+json;charset=utf-8"
       end
 
       it "returns a JSON body" do

data/spec/lib/pact_broker/badges/service_spec.rb

@@ -1,5 +1,5 @@
-require 'pact_broker/badges/service'
-require 'webmock/rspec'
+require "pact_broker/badges/service"
+require "webmock/rspec"
 
 module PactBroker
   module Badges
@@ -9,7 +9,7 @@ module PactBroker
       let(:label) { nil }
       let(:initials) { false }
       let(:pseudo_branch_verification_status) { :success }
-      let(:logger) { double('logger').as_null_object }
+      let(:logger) { double("logger").as_null_object }
       let(:expected_url) { "https://img.shields.io/badge/#{expected_left_text}-#{expected_right_text}-#{expected_color}.svg" }
       let(:expected_color) { "brightgreen" }
       let(:expected_right_text) { "verified" }
@@ -51,7 +51,7 @@ module PactBroker
 
       describe "#pact_verification_badge" do
         it "returns the svg file" do
-           expect(subject).to eq "svg"
+          expect(subject).to eq "svg"
         end
 
         it "caches the response" do
@@ -129,7 +129,7 @@ module PactBroker
 
         context "when label is consumer" do
           let(:expected_left_text) { "foo--bar%20pact" }
-          let(:label) { 'consumer' }
+          let(:label) { "consumer" }
 
           it "creates a badge with only the consumer name" do
             subject
@@ -151,7 +151,7 @@ module PactBroker
 
         context "when label is provider" do
           let(:expected_left_text) { "thing__blah%20pact" }
-          let(:label) { 'provider' }
+          let(:label) { "provider" }
 
           it "creates a badge with only the provider name" do
             subject

data/spec/lib/pact_broker/build_http_options_spec.rb

@@ -1,5 +1,5 @@
-require 'spec_helper'
-require 'pact_broker/build_http_options'
+require "spec_helper"
+require "pact_broker/build_http_options"
 
 module PactBroker
   describe BuildHttpOptions do
@@ -12,7 +12,7 @@ module PactBroker
       end
 
       describe "when given an insecure URL" do
-        let(:url) { 'http://example.org/insecure' }
+        let(:url) { "http://example.org/insecure" }
         
         it "should provide an empty configuration object" do
           expect(subject).to eq({})
@@ -21,7 +21,7 @@ module PactBroker
       end
       
       describe "when given a secure URL" do
-        let(:url) { 'https://example.org/secure' }
+        let(:url) { "https://example.org/secure" }
         
         it "should validate the full certificate chain" do
           expect(subject).to include({:use_ssl => true, :verify_mode => 1})
@@ -35,7 +35,7 @@ module PactBroker
         PactBroker.configuration.disable_ssl_verification = true
       end
       
-      let(:url) { 'https://example.org/secure' }
+      let(:url) { "https://example.org/secure" }
       
       describe "when given a secure URL" do
         it "should not validate certificates" do

data/spec/lib/pact_broker/certificates/service_spec.rb

@@ -1,10 +1,10 @@
-require 'pact_broker/certificates/service'
+require "pact_broker/certificates/service"
 
 module PactBroker
   module Certificates
     describe Service do
-      let(:certificate_content) { File.read('spec/fixtures/certificate.pem') }
-      let(:logger) { spy('logger') }
+      let(:certificate_content) { File.read("spec/fixtures/certificate.pem") }
+      let(:logger) { spy("logger") }
 
       before do
         allow(Service).to receive(:logger).and_return(logger)
@@ -21,7 +21,7 @@ module PactBroker
           let(:cert_store) { instance_spy(OpenSSL::X509::Store) }
 
           before do
-            Certificate.create(uuid: '1234', content: certificate_content)
+            Certificate.create(uuid: "1234", content: certificate_content)
 
             allow(cert_store).to receive(:add_cert).and_raise(StandardError)
             allow(OpenSSL::X509::Store).to receive(:new).and_return(cert_store)
@@ -42,7 +42,7 @@ module PactBroker
 
       describe "#find_all_certificates" do
         let!(:certificate) do
-          Certificate.create(uuid: '1234', content: certificate_content)
+          Certificate.create(uuid: "1234", content: certificate_content)
         end
 
         subject { Service.find_all_certificates }
@@ -54,7 +54,7 @@ module PactBroker
         end
 
         context "with a valid CA file" do
-          let(:certificate_content) { File.read('spec/fixtures/certificates/cacert.pem') }
+          let(:certificate_content) { File.read("spec/fixtures/certificates/cacert.pem") }
 
           it "returns all the X509 Certificate objects" do
             expect(logger).to_not receive(:error).with(/Error.*1234/)
@@ -63,7 +63,7 @@ module PactBroker
         end
 
         context "with an invalid certificate file" do
-          let(:certificate_content) { File.read('spec/fixtures/certificate-invalid.pem') }
+          let(:certificate_content) { File.read("spec/fixtures/certificate-invalid.pem") }
 
           it "logs an error" do
             expect(logger).to receive(:warn).with(/Error.*1234/, StandardError)

data/spec/lib/pact_broker/config/load_spec.rb

@@ -1,4 +1,4 @@
-require 'pact_broker/config/load'
+require "pact_broker/config/load"
 
 module PactBroker
   module Config
@@ -11,16 +11,16 @@ module PactBroker
         end
 
         before do
-          Setting.create(name: 'foo', type: 'json', value: {"a" => "thing"}.to_json)
-          Setting.create(name: 'bar', type: 'string', value: "bar")
-          Setting.create(name: 'nana', type: 'integer', value: "1")
-          Setting.create(name: 'meep', type: 'float', value: "1.2")
-          Setting.create(name: 'lalala', type: 'boolean', value: "1")
-          Setting.create(name: 'meow', type: 'boolean', value: "0")
-          Setting.create(name: 'peebo', type: 'string', value: nil)
-          Setting.create(name: 'unknown', type: 'string', value: nil)
-          Setting.create(name: 'whitelist', type: 'space_delimited_string_list', value: 'foo bar')
-          Setting.create(name: 'blah', type: 'symbol', value: 'boop')
+          Setting.create(name: "foo", type: "json", value: {"a" => "thing"}.to_json)
+          Setting.create(name: "bar", type: "string", value: "bar")
+          Setting.create(name: "nana", type: "integer", value: "1")
+          Setting.create(name: "meep", type: "float", value: "1.2")
+          Setting.create(name: "lalala", type: "boolean", value: "1")
+          Setting.create(name: "meow", type: "boolean", value: "0")
+          Setting.create(name: "peebo", type: "string", value: nil)
+          Setting.create(name: "unknown", type: "string", value: nil)
+          Setting.create(name: "whitelist", type: "space_delimited_string_list", value: "foo bar")
+          Setting.create(name: "blah", type: "symbol", value: "boop")
         end
 
         let(:configuration) { MockConfig.new }

data/spec/lib/pact_broker/config/save_and_load_spec.rb

@@ -1,5 +1,5 @@
-require 'pact_broker/config/load'
-require 'pact_broker/config/save'
+require "pact_broker/config/load"
+require "pact_broker/config/save"
 
 module PactBroker
   module Config

data/spec/lib/pact_broker/config/save_spec.rb

@@ -1,6 +1,6 @@
-require 'pact_broker/config/save'
-require 'pact_broker/configuration'
-require 'pact_broker/config/space_delimited_string_list'
+require "pact_broker/config/save"
+require "pact_broker/configuration"
+require "pact_broker/config/space_delimited_string_list"
 
 module PactBroker
   module Config
@@ -13,7 +13,7 @@ module PactBroker
             foo: true,
             bar: false,
             wiffle: ["a", "b", "c"],
-            meep: {a: 'thing'},
+            meep: {a: "thing"},
             flop: nil,
             blah: :boop,
             peebo: 1,
@@ -26,72 +26,72 @@ module PactBroker
 
         it "saves a Symbol" do
           subject
-          setting = Setting.find(name: 'blah')
-          expect(setting.type).to eq 'symbol'
-          expect(setting.value).to eq 'boop'
+          setting = Setting.find(name: "blah")
+          expect(setting.type).to eq "symbol"
+          expect(setting.value).to eq "boop"
         end
 
         it "saves a false config setting to the database" do
           subject
-          setting = Setting.find(name: 'foo')
-          expect(setting.type).to eq 'boolean'
-          expect(setting.value).to eq '1'
+          setting = Setting.find(name: "foo")
+          expect(setting.type).to eq "boolean"
+          expect(setting.value).to eq "1"
         end
 
         it "saves a true config setting to the database" do
           subject
-          setting = Setting.find(name: 'bar')
-          expect(setting.type).to eq 'boolean'
-          expect(setting.value).to eq '0'
+          setting = Setting.find(name: "bar")
+          expect(setting.type).to eq "boolean"
+          expect(setting.value).to eq "0"
         end
 
         it "saves an array to the database" do
           subject
-          setting = Setting.find(name: 'wiffle')
-          expect(setting.type).to eq 'json'
+          setting = Setting.find(name: "wiffle")
+          expect(setting.type).to eq "json"
           expect(setting.value).to eq '["a","b","c"]'
         end
 
         it "saves a hash to the database" do
           subject
-          setting = Setting.find(name: 'meep')
-          expect(setting.type).to eq 'json'
+          setting = Setting.find(name: "meep")
+          expect(setting.type).to eq "json"
           expect(setting.value).to eq "{\"a\":\"thing\"}"
         end
 
         it "saves a nil to the database" do
           subject
-          setting = Setting.find(name: 'flop')
-          expect(setting.type).to eq 'string'
+          setting = Setting.find(name: "flop")
+          expect(setting.type).to eq "string"
           expect(setting.value).to eq nil
         end
 
         it "saves an Integer to the database" do
           subject
-          setting = Setting.find(name: 'peebo')
-          expect(setting.type).to eq 'integer'
-          expect(setting.value).to eq '1'
+          setting = Setting.find(name: "peebo")
+          expect(setting.type).to eq "integer"
+          expect(setting.value).to eq "1"
         end
 
         it "saves a Float to the database" do
           subject
-          setting = Setting.find(name: 'lalala')
-          expect(setting.type).to eq 'float'
-          expect(setting.value).to eq '1.2'
+          setting = Setting.find(name: "lalala")
+          expect(setting.type).to eq "float"
+          expect(setting.value).to eq "1.2"
         end
 
         it "saves a SpaceDelimitedStringList" do
           subject
-          setting = Setting.find(name: 'whitelist')
-          expect(setting.type).to eq 'space_delimited_string_list'
-          expect(setting.value).to eq 'foo bar'
+          setting = Setting.find(name: "whitelist")
+          expect(setting.type).to eq "space_delimited_string_list"
+          expect(setting.value).to eq "foo bar"
         end
 
         it "does not save an arbitrary object to the database" do
           allow(Save.logger).to receive(:warn)
           expect(Save.logger).to receive(:warn).with("Could not save configuration setting \"meow\" to database as the class Object is not supported.")
           subject
-          setting = Setting.find(name: 'meow')
+          setting = Setting.find(name: "meow")
           expect(setting).to be nil
         end
       end