pact_broker 2.77.0 → 2.80.0

data/spec/lib/pact_broker/pacticipants/service_spec.rb

@@ -1,7 +1,7 @@
-require 'spec_helper'
-require 'pact_broker/pacticipants/service'
-require 'pact_broker/domain/tag'
-require 'pact_broker/domain/pact'
+require "spec_helper"
+require "pact_broker/pacticipants/service"
+require "pact_broker/domain/tag"
+require "pact_broker/domain/pact"
 
 module PactBroker
   module Pacticipants
@@ -11,29 +11,15 @@ module PactBroker
       end
 
       let(:td) { TestDataBuilder.new }
-      let(:logger) { double('logger').as_null_object }
+      let(:logger) { double("logger").as_null_object }
 
       subject{ Service }
 
-      describe ".update" do
-        before do
-          td.create_pacticipant("Foo")
-        end
-
-        let(:params) { { 'name' => 'Foo', 'repositoryUrl' => 'http://foo' } }
-
-        subject { Service.update(params) }
-
-        it "updates the repositoryUrl" do
-          expect(subject.repository_url).to eq 'http://foo'
-        end
-      end
-
       describe ".messages_for_potential_duplicate_pacticipants" do
 
-        let(:base_url) { 'http://example.org' }
-        let(:fred_duplicates) { [double('Frederich pacticipant')] }
-        let(:mary_dulicates) { [double('Marta pacticipant')] }
+        let(:base_url) { "http://example.org" }
+        let(:fred_duplicates) { [double("Frederich pacticipant")] }
+        let(:mary_dulicates) { [double("Marta pacticipant")] }
 
         before do
           allow(Service).to receive(:find_potential_duplicate_pacticipants).with("Fred").and_return(fred_duplicates)
@@ -73,11 +59,11 @@ module PactBroker
       end
 
       describe ".find_potential_duplicate_pacticipants" do
-        let(:pacticipant_name) { 'pacticipant_name' }
+        let(:pacticipant_name) { "pacticipant_name" }
         let(:duplicates) { ["Fred", "Mary"] }
         let(:pacticipant_names) { double("pacticipant_names") }
-        let(:fred) { double('fred pacticipant')}
-        let(:mary) { double('mary pacticipant')}
+        let(:fred) { double("fred pacticipant")}
+        let(:mary) { double("mary pacticipant")}
         let(:pacticipant_repository) { instance_double(PactBroker::Pacticipants::Repository)}
 
         before do
@@ -136,101 +122,69 @@ module PactBroker
 
         context "deleting a consumer" do
           it "deletes the pacticipant" do
-            expect{ delete_consumer }.to change{
-                PactBroker::Domain::Pacticipant.all.count
-              }.by(-1)
+            expect{ delete_consumer }.to change{ PactBroker::Domain::Pacticipant.all.count }.by(-1)
           end
 
           it "deletes the child versions" do
-            expect{ delete_consumer }.to change{
-              PactBroker::Domain::Version.where(number: "1.2.3").count
-              }.by(-1)
+            expect{ delete_consumer }.to change{ PactBroker::Domain::Version.where(number: "1.2.3").count }.by(-1)
           end
 
           it "deletes the child tags" do
-            expect{ delete_consumer }.to change{
-              PactBroker::Domain::Tag.where(name: "prod").count
-              }.by(-1)
+            expect{ delete_consumer }.to change{ PactBroker::Domain::Tag.where(name: "prod").count }.by(-1)
           end
 
           it "deletes the webhooks" do
-            expect{ delete_consumer }.to change{
-              PactBroker::Webhooks::Webhook.count
-              }.by(-1)
+            expect{ delete_consumer }.to change{ PactBroker::Webhooks::Webhook.count }.by(-1)
           end
 
           it "deletes the triggered webhooks" do
-            expect{ delete_consumer }.to change{
-              PactBroker::Webhooks::TriggeredWebhook.count
-              }.by(-1)
+            expect{ delete_consumer }.to change{ PactBroker::Webhooks::TriggeredWebhook.count }.by(-1)
           end
 
           it "deletes the webhook executions" do
-            expect{ delete_consumer }.to change{
-              PactBroker::Webhooks::Execution.count
-              }.by(-1)
+            expect{ delete_consumer }.to change{ PactBroker::Webhooks::Execution.count }.by(-1)
           end
 
           it "deletes the child pacts" do
-            expect{ delete_consumer }.to change{
-              PactBroker::Pacts::PactPublication.count
-              }.by(-2)
+            expect{ delete_consumer }.to change{ PactBroker::Pacts::PactPublication.count }.by(-2)
           end
 
           it "deletes the verifications" do
-            expect{ delete_consumer }.to change{
-              PactBroker::Domain::Verification.count
-              }.by(-1)
+            expect{ delete_consumer }.to change{ PactBroker::Domain::Verification.count }.by(-1)
           end
         end
 
         context "deleting a provider" do
           it "deletes the pacticipant" do
-            expect{ delete_provider }.to change{
-                PactBroker::Domain::Pacticipant.all.count
-              }.by(-1)
+            expect{ delete_provider }.to change{ PactBroker::Domain::Pacticipant.all.count }.by(-1)
           end
 
           it "does not delete any versions" do
-            expect{ delete_provider }.to change{
-              PactBroker::Domain::Version.where(number: "1.2.3").count
-              }.by(0)
+            expect{ delete_provider }.to change{ PactBroker::Domain::Version.where(number: "1.2.3").count }.by(0)
           end
 
           it "deletes the child tags only if there are any" do
-            expect{ delete_provider }.to change{
-              PactBroker::Domain::Tag.where(name: "prod").count
-              }.by(0)
+            expect{ delete_provider }.to change{ PactBroker::Domain::Tag.where(name: "prod").count }.by(0)
           end
 
           it "deletes the webhooks" do
-            expect{ delete_provider }.to change{
-              PactBroker::Webhooks::Webhook.count
-              }.by(-1)
+            expect{ delete_provider }.to change{ PactBroker::Webhooks::Webhook.count }.by(-1)
           end
 
           it "deletes the triggered webhooks" do
-            expect{ delete_provider }.to change{
-              PactBroker::Webhooks::TriggeredWebhook.count
-              }.by(-1)
+            expect{ delete_provider }.to change{ PactBroker::Webhooks::TriggeredWebhook.count }.by(-1)
           end
 
           it "deletes the webhook executions" do
-            expect{ delete_provider }.to change{
-              PactBroker::Webhooks::Execution.count
-              }.by(-1)
+            expect{ delete_provider }.to change{ PactBroker::Webhooks::Execution.count }.by(-1)
           end
 
           it "deletes the child pacts" do
-            expect{ delete_provider }.to change{
-              PactBroker::Pacts::PactPublication.count
-              }.by(-2)
+            expect{ delete_provider }.to change{ PactBroker::Pacts::PactPublication.count }.by(-2)
           end
 
           it "deletes the verifications" do
-            expect{ delete_provider }.to change{
-              PactBroker::Domain::Verification.count
-              }.by(-1)
+            expect{ delete_provider }.to change{ PactBroker::Domain::Verification.count }.by(-1)
           end
 
         end

data/spec/lib/pact_broker/pacts/build_verifiable_pact_notices_spec.rb

@@ -1,4 +1,4 @@
-require 'pact_broker/pacts/build_verifiable_pact_notices'
+require "pact_broker/pacts/build_verifiable_pact_notices"
 
 module PactBroker
   module Pacts
@@ -9,18 +9,18 @@ module PactBroker
 
       let(:verifiable_pact_messages) do
         instance_double(VerifiablePactMessages,
-          inclusion_reason: 'the inclusion reason',
-          pending_reason: 'pending reason',
-          verification_success_true_published_false: 'verification_success_true_published_false',
-          verification_success_false_published_false: 'verification_success_false_published_false',
-          verification_success_true_published_true: 'verification_success_true_published_true',
-          verification_success_false_published_true: 'verification_success_false_published_true'
+          inclusion_reason: "the inclusion reason",
+          pending_reason: "pending reason",
+          verification_success_true_published_false: "verification_success_true_published_false",
+          verification_success_false_published_false: "verification_success_false_published_false",
+          verification_success_true_published_true: "verification_success_true_published_true",
+          verification_success_false_published_true: "verification_success_false_published_true"
         )
       end
 
       let(:options) { {} }
-      let(:pact_url) { 'http://pact' }
-      let(:verifiable_pact) { instance_double('PactBroker::Pacts::VerifiablePact') }
+      let(:pact_url) { "http://pact" }
+      let(:verifiable_pact) { instance_double("PactBroker::Pacts::VerifiablePact") }
 
       subject { BuildVerifiablePactNotices.call(verifiable_pact, pact_url, options) }
 
@@ -32,7 +32,7 @@ module PactBroker
               :text => "the inclusion reason"
             },{
               :when => "before_verification",
-              :text => 'pending reason'
+              :text => "pending reason"
             },{
               :when => "after_verification:success_true_published_false",
               :text => "verification_success_true_published_false"

data/spec/lib/pact_broker/pacts/content_spec.rb

@@ -1,4 +1,4 @@
-require 'pact_broker/pacts/content'
+require "pact_broker/pacts/content"
 
 module PactBroker
   module Pacts
@@ -6,10 +6,10 @@ module PactBroker
       describe "with_ids" do
         let(:pact_hash) do
           {
-            'ignored' => 'foo',
-            'interactions' => [interaction],
-            'metadata' => {
-              'foo' => 'bar'
+            "ignored" => "foo",
+            "interactions" => [interaction],
+            "metadata" => {
+              "foo" => "bar"
             }
           }
         end
@@ -47,10 +47,10 @@ module PactBroker
         context "when the pact is a message pact" do
           let(:pact_hash) do
             {
-              'ignored' => 'foo',
-              'messages' => [interaction],
-              'metadata' => {
-                'foo' => 'bar'
+              "ignored" => "foo",
+              "messages" => [interaction],
+              "metadata" => {
+                "foo" => "bar"
               }
             }
           end
@@ -76,11 +76,11 @@ module PactBroker
         context "with messages" do
           let(:pact_hash) do
             {
-              'ignored' => 'foo',
-              'messages' => [1],
-              'metadata' => {
-                'pactSpecification' => {
-                  'version' => '1'
+              "ignored" => "foo",
+              "messages" => [1],
+              "metadata" => {
+                "pactSpecification" => {
+                  "version" => "1"
                 }
               }
             }
@@ -88,8 +88,8 @@ module PactBroker
 
           let(:expected_content) do
             {
-              'messages' => [1],
-              'pact_specification_version' => '1'
+              "messages" => [1],
+              "pact_specification_version" => "1"
             }
           end
 
@@ -101,11 +101,11 @@ module PactBroker
         context "with interactions" do
           let(:pact_hash) do
             {
-              'ignored' => 'foo',
-              'interactions' => [1],
-              'metadata' => {
-                'pactSpecification' => {
-                  'version' => '1'
+              "ignored" => "foo",
+              "interactions" => [1],
+              "metadata" => {
+                "pactSpecification" => {
+                  "version" => "1"
                 }
               }
             }
@@ -113,8 +113,8 @@ module PactBroker
 
           let(:expected_content) do
             {
-              'interactions' => [1],
-              'pact_specification_version' => '1'
+              "interactions" => [1],
+              "pact_specification_version" => "1"
             }
           end
 
@@ -126,12 +126,12 @@ module PactBroker
         context "with both messages and interactions, even though this should never happen" do
           let(:pact_hash) do
             {
-              'ignored' => 'foo',
-              'interactions' => [1],
-              'messages' => [2],
-              'metadata' => {
-                'pactSpecification' => {
-                  'version' => '1'
+              "ignored" => "foo",
+              "interactions" => [1],
+              "messages" => [2],
+              "metadata" => {
+                "pactSpecification" => {
+                  "version" => "1"
                 }
               }
             }
@@ -139,9 +139,9 @@ module PactBroker
 
           let(:expected_content) do
             {
-              'interactions' => [1],
-              'messages' => [2],
-              'pact_specification_version' => '1'
+              "interactions" => [1],
+              "messages" => [2],
+              "pact_specification_version" => "1"
             }
           end
 
@@ -153,11 +153,11 @@ module PactBroker
         context "with neither messages nor interactions" do
           let(:pact_hash) do
             {
-              'ignored' => 'foo',
-              'foo' => [1],
-              'metadata' => {
-                'pactSpecification' => {
-                  'version' => '1'
+              "ignored" => "foo",
+              "foo" => [1],
+              "metadata" => {
+                "pactSpecification" => {
+                  "version" => "1"
                 }
               }
             }
@@ -181,47 +181,47 @@ module PactBroker
 
       describe "#pact_specification_version" do
         subject { Content.from_hash(json) }
-        context 'with pactSpecification.version' do
+        context "with pactSpecification.version" do
           let(:json) do
             {
-              'metadata' => {
-                'pactSpecification' => {
-                  'version' => '1'
+              "metadata" => {
+                "pactSpecification" => {
+                  "version" => "1"
                 }
               }
             }
           end
 
-          its(:pact_specification_version) { is_expected.to eq '1' }
+          its(:pact_specification_version) { is_expected.to eq "1" }
         end
 
-        context 'with pact-specification.version' do
+        context "with pact-specification.version" do
           let(:json) do
             {
-              'metadata' => {
-                'pact-specification' => {
-                  'version' => '1'
+              "metadata" => {
+                "pact-specification" => {
+                  "version" => "1"
                 }
               }
             }
           end
 
-          its(:pact_specification_version) { is_expected.to eq '1' }
+          its(:pact_specification_version) { is_expected.to eq "1" }
         end
 
-        context 'with pactSpecificationVersion' do
+        context "with pactSpecificationVersion" do
           let(:json) do
             {
-              'metadata' => {
-                'pactSpecificationVersion' => '1'
+              "metadata" => {
+                "pactSpecificationVersion" => "1"
               }
             }
           end
 
-          its(:pact_specification_version) { is_expected.to eq '1' }
+          its(:pact_specification_version) { is_expected.to eq "1" }
         end
 
-        context 'with an array for content' do
+        context "with an array for content" do
           let(:json) { [] }
 
           its(:pact_specification_version) { is_expected.to eq nil }
@@ -411,13 +411,13 @@ module PactBroker
       describe "interaction_ids" do
         let(:interaction_1) do
           {
-            _id: '1'
+            _id: "1"
           }
         end
 
         let(:interaction_2) do
           {
-            _id: '2'
+            _id: "2"
           }
         end
 
@@ -434,7 +434,7 @@ module PactBroker
 
         subject { Content.from_json(content_hash.to_json) }
 
-        its(:interaction_ids) { is_expected.to eq ['1', '2'] }
+        its(:interaction_ids) { is_expected.to eq ["1", "2"] }
 
         context "when there are no interactions" do
           let(:content_hash) { {} }

data/spec/lib/pact_broker/pacts/create_formatted_diff_spec.rb

@@ -1,6 +1,6 @@
-require 'spec_helper'
-require 'pact_broker/pacts/create_formatted_diff'
-require 'pact_broker/pacts/repository'
+require "spec_helper"
+require "pact_broker/pacts/create_formatted_diff"
+require "pact_broker/pacts/repository"
 
 module PactBroker
   module Pacts
@@ -8,20 +8,20 @@ module PactBroker
       describe ".call" do
 
         let(:pact_content_version_1) do
-          hash = load_json_fixture('consumer-provider.json')
-          hash['interactions'].first['request']['method'] = 'post'
+          hash = load_json_fixture("consumer-provider.json")
+          hash["interactions"].first["request"]["method"] = "post"
           hash.to_json
         end
 
-        let(:pact_content_version_2) { load_fixture('consumer-provider.json') }
+        let(:pact_content_version_2) { load_fixture("consumer-provider.json") }
 
         subject { CreateFormattedDiff.call(pact_content_version_2, pact_content_version_1) }
 
         it "returns the formatted diff" do
-          expect(subject).to include 'interactions'
-          expect(subject).to match /\-.*post/
-          expect(subject).to match /\+.*get/
-          expect(subject).to_not include 'Key'
+          expect(subject).to include "interactions"
+          expect(subject).to match(/\-.*post/)
+          expect(subject).to match(/\+.*get/)
+          expect(subject).to_not include "Key"
         end
       end
     end