pact_broker 2.77.0 → 2.80.0

data/spec/lib/pact_broker/api/decorators/dashboard_decorator_spec.rb

@@ -1,14 +1,14 @@
-require 'pact_broker/api/decorators/dashboard_decorator'
-require 'pact_broker/domain/index_item'
+require "pact_broker/api/decorators/dashboard_decorator"
+require "pact_broker/domain/index_item"
 
-ORIGINAL_TZ = ENV['TZ']
+ORIGINAL_TZ = ENV["TZ"]
 
 module PactBroker
   module Api
     module Decorators
       describe DashboardDecorator do
         let(:index_item) do
-          instance_double('PactBroker::Domain::IndexItem',
+          instance_double("PactBroker::Domain::IndexItem",
             consumer: consumer,
             provider: provider,
             consumer_name: consumer.name,
@@ -18,51 +18,51 @@ module PactBroker
             provider_version: provider_version,
             consumer_version: consumer_version,
             last_webhook_execution_date: last_webhook_execution_date,
-            webhook_status: 'blah',
-            pseudo_branch_verification_status: 'wiffle',
+            webhook_status: "blah",
+            pseudo_branch_verification_status: "wiffle",
             provider_version_number: provider_version.number,
             provider_version_branch: provider_version.branch,
             consumer_version_number: consumer_version.number,
             consumer_version_branch: consumer_version.branch,
-            tag_names: ['prod'],
-            latest_verification_latest_tags: [double('tag', name: 'dev', latest?: true)]
+            tag_names: ["prod"],
+            latest_verification_latest_tags: [double("tag", name: "dev", latest?: true)]
           )
         end
-        let(:consumer) { instance_double('PactBroker::Domain::Pacticipant', name: 'Foo') }
-        let(:provider) { instance_double('PactBroker::Domain::Pacticipant', name: 'Bar') }
-        let(:pact) { instance_double('PactBroker::Domain::Pact', created_at: created_at) }
-        let(:verification) { instance_double('PactBroker::Domain::Verification', success: true, created_at: created_at) }
-        let(:consumer_version) { instance_double('PactBroker::Domain::Version', number: '1', pacticipant: consumer, branch: "main") }
-        let(:provider_version) { instance_double('PactBroker::Domain::Version', number: '2', pacticipant: provider, branch: "main") }
+        let(:consumer) { instance_double("PactBroker::Domain::Pacticipant", name: "Foo") }
+        let(:provider) { instance_double("PactBroker::Domain::Pacticipant", name: "Bar") }
+        let(:pact) { instance_double("PactBroker::Domain::Pact", created_at: created_at) }
+        let(:verification) { instance_double("PactBroker::Domain::Verification", success: true, created_at: created_at) }
+        let(:consumer_version) { instance_double("PactBroker::Domain::Version", number: "1", pacticipant: consumer, branch: "main") }
+        let(:provider_version) { instance_double("PactBroker::Domain::Version", number: "2", pacticipant: provider, branch: "main") }
         let(:last_webhook_execution_date) { created_at }
-        let(:base_url) { 'http://example.org' }
+        let(:base_url) { "http://example.org" }
         let(:options) { { user_options: { base_url: base_url } } }
         let(:dashboard_json) { DashboardDecorator.new([index_item]).to_json(options) }
         let(:created_at) { td.in_utc { DateTime.new(2018) } }
 
         before do
-          allow_any_instance_of(DashboardDecorator).to receive(:pact_url).with(base_url, pact).and_return('pact_url')
-          allow_any_instance_of(DashboardDecorator).to receive(:latest_verification_for_pact_url).with(pact, base_url, false).and_return('latest_verification_url')
-          allow_any_instance_of(DashboardDecorator).to receive(:pacticipant_url).with(base_url, consumer).and_return('consumer_url')
-          allow_any_instance_of(DashboardDecorator).to receive(:pacticipant_url).with(base_url, provider).and_return('provider_url')
-          allow_any_instance_of(DashboardDecorator).to receive(:version_url).with(base_url, consumer_version).and_return('consumer_version_url')
-          allow_any_instance_of(DashboardDecorator).to receive(:webhooks_status_url).with(consumer, provider, base_url).and_return('webhooks_status_url')
-          allow_any_instance_of(DashboardDecorator).to receive(:tag_url) do | instance, base_url, tag |
+          allow_any_instance_of(DashboardDecorator).to receive(:pact_url).with(base_url, pact).and_return("pact_url")
+          allow_any_instance_of(DashboardDecorator).to receive(:latest_verification_for_pact_url).with(pact, base_url, false).and_return("latest_verification_url")
+          allow_any_instance_of(DashboardDecorator).to receive(:pacticipant_url).with(base_url, consumer).and_return("consumer_url")
+          allow_any_instance_of(DashboardDecorator).to receive(:pacticipant_url).with(base_url, provider).and_return("provider_url")
+          allow_any_instance_of(DashboardDecorator).to receive(:version_url).with(base_url, consumer_version).and_return("consumer_version_url")
+          allow_any_instance_of(DashboardDecorator).to receive(:webhooks_status_url).with(consumer, provider, base_url).and_return("webhooks_status_url")
+          allow_any_instance_of(DashboardDecorator).to receive(:tag_url) do | _instance, base_url, tag |
             if tag.version == consumer_version
-              expect(tag.name).to eq 'prod'
+              expect(tag.name).to eq "prod"
               expect(tag.version).to be consumer_version
               expect(base_url).to eq base_url
-              'pact_prod_tag_url'
+              "pact_prod_tag_url"
             else
-              expect(tag.name).to eq 'dev'
+              expect(tag.name).to eq "dev"
               expect(tag.version).to be provider_version
               expect(base_url).to eq base_url
-              'verification_dev_tag_url'
+              "verification_dev_tag_url"
             end
           end
         end
 
-        let(:expected_hash) { JSON.parse(File.read('spec/fixtures/dashboard.json')) }
+        let(:expected_hash) { JSON.parse(File.read("spec/fixtures/dashboard.json")) }
 
         subject { JSON.parse(dashboard_json) }
 
@@ -74,8 +74,8 @@ module PactBroker
           let(:verification) { nil }
 
           it "has a null last verification and provider version" do
-            expected_hash['items'][0]['latestVerificationResult'] = nil
-            expected_hash['items'][0]['provider']['version'] = nil
+            expected_hash["items"][0]["latestVerificationResult"] = nil
+            expected_hash["items"][0]["provider"]["version"] = nil
             expect(subject).to match_pact(expected_hash, {allow_unexpected_keys: false})
           end
         end
@@ -84,7 +84,7 @@ module PactBroker
           let(:last_webhook_execution_date) { nil }
 
           it "has a null latestWebhookExecution" do
-            expected_hash['items'][0]['latestWebhookExecution'] = nil
+            expected_hash["items"][0]["latestWebhookExecution"] = nil
             expect(subject).to match_pact(expected_hash, {allow_unexpected_keys: false})
           end
         end

data/spec/lib/pact_broker/api/decorators/embedded_label_decorator_spec.rb

@@ -1,4 +1,4 @@
-require 'pact_broker/api/decorators/embedded_label_decorator'
+require "pact_broker/api/decorators/embedded_label_decorator"
 
 module PactBroker
   module Api
@@ -13,7 +13,7 @@ module PactBroker
             .and_return(:label)
         end
 
-        let(:options) { { user_options: { base_url: 'http://example.org' } } }
+        let(:options) { { user_options: { base_url: "http://example.org" } } }
 
         subject { JSON.parse EmbeddedLabelDecorator.new(label).to_json(options), symbolize_names: true }
 

data/spec/lib/pact_broker/api/decorators/embedded_tag_decorator_spec.rb

@@ -1,6 +1,6 @@
-require 'pact_broker/api/decorators/embedded_tag_decorator'
-require 'pact_broker/tags/repository'
-require 'support/test_data_builder'
+require "pact_broker/api/decorators/embedded_tag_decorator"
+require "pact_broker/tags/repository"
+require "support/test_data_builder"
 
 module PactBroker
 
@@ -15,10 +15,10 @@ module PactBroker
             .create_consumer("Consumer")
             .create_version("1.2.3")
             .create_tag("prod")
-          PactBroker::Tags::Repository.new.find(tag_name: 'prod', pacticipant_version_number: '1.2.3', pacticipant_name: 'Consumer')
+          PactBroker::Tags::Repository.new.find(tag_name: "prod", pacticipant_version_number: "1.2.3", pacticipant_name: "Consumer")
         end
 
-        let(:options) { { user_options: { base_url: 'http://example.org' } } }
+        let(:options) { { user_options: { base_url: "http://example.org" } } }
         let(:json) { EmbeddedTagDecorator.new(tag).to_json(options) }
 
         subject { JSON.parse json, symbolize_names: true }

data/spec/lib/pact_broker/api/decorators/embedded_version_decorator_spec.rb

@@ -1,5 +1,5 @@
-require 'spec_helper'
-require 'pact_broker/api/decorators/embedded_version_decorator'
+require "spec_helper"
+require "pact_broker/api/decorators/embedded_version_decorator"
 
 module PactBroker
   module Api
@@ -13,7 +13,7 @@ module PactBroker
           PactBroker::Versions::Repository.new.find_by_pacticipant_name_and_number "Consumer", "1.2.3"
         end
 
-        let(:options) { { user_options: { base_url: 'http://example.org' } } }
+        let(:options) { { user_options: { base_url: "http://example.org" } } }
 
         subject { JSON.parse EmbeddedVersionDecorator.new(version).to_json(options), symbolize_names: true }
 

data/spec/lib/pact_broker/api/decorators/extended_pact_decorator_spec.rb

@@ -1,25 +1,25 @@
-require 'pact_broker/api/decorators/extended_pact_decorator'
+require "pact_broker/api/decorators/extended_pact_decorator"
 
 module PactBroker
   module Api
     module Decorators
       describe ExtendedPactDecorator do
         before do
-          allow(decorator).to receive(:templated_diff_url).and_return('templated-diff-url')
-          allow(decorator).to receive(:verification_publication_url).and_return('verification-publication-url')
+          allow(decorator).to receive(:templated_diff_url).and_return("templated-diff-url")
+          allow(decorator).to receive(:verification_publication_url).and_return("verification-publication-url")
         end
         let(:content_hash) {
           {
-            'consumer' => {'name' => 'Consumer'},
-            'provider' => {'name' => 'Provider'},
-            'interactions' => [],
-            'metadata' => {}
+            "consumer" => {"name" => "Consumer"},
+            "provider" => {"name" => "Provider"},
+            "interactions" => [],
+            "metadata" => {}
           }
         }
 
-        let(:base_url) { 'http://example.org' }
+        let(:base_url) { "http://example.org" }
         let(:created_at) { Time.new(2014, 3, 4) }
-        let(:pact) { double('pact',
+        let(:pact) { double("pact",
           content_hash: content_hash,
           created_at: created_at,
           consumer: consumer,
@@ -27,23 +27,23 @@ module PactBroker
           provider: provider,
           provider_name: provider.name,
           consumer_version: consumer_version,
-          consumer_version_number: '1234',
-          pact_version_sha: '9999',
+          consumer_version_number: "1234",
+          pact_version_sha: "9999",
           revision_number: 2,
-          name: 'A Pact',
+          name: "A Pact",
           head_tag_names: head_tag_names
         )}
-        let(:head_tag_names) { ['prod'] }
-        let(:consumer) { instance_double(PactBroker::Domain::Pacticipant, name: 'A Consumer')}
-        let(:provider) { instance_double(PactBroker::Domain::Pacticipant, name: 'A Provider')}
-        let(:consumer_version) { instance_double(PactBroker::Domain::Version, number: '1234', pacticipant: consumer)}
+        let(:head_tag_names) { ["prod"] }
+        let(:consumer) { instance_double(PactBroker::Domain::Pacticipant, name: "A Consumer")}
+        let(:provider) { instance_double(PactBroker::Domain::Pacticipant, name: "A Provider")}
+        let(:consumer_version) { instance_double(PactBroker::Domain::Version, number: "1234", pacticipant: consumer)}
         let(:metadata) { "abcd" }
         let(:decorator) { ExtendedPactDecorator.new(pact) }
         let(:json) { decorator.to_json(user_options: { base_url: base_url, metadata: metadata }) }
         subject { JSON.parse(json, symbolize_names: true) }
 
         it "includes an array of tags" do
-          expect(subject[:_embedded][:tags].first).to include name: 'prod', latest: true
+          expect(subject[:_embedded][:tags].first).to include name: "prod", latest: true
           # Can't seem to stub the verification_publication_url method on the TagDecorator
           expect(subject[:_embedded][:tags].first[:_links][:'pb:latest-pact'][:href]).to eq "http://example.org/pacts/provider/A%20Provider/consumer/A%20Consumer/latest/prod"
           expect(subject[:_embedded][:tags].first[:_links][:self][:href]).to eq "http://example.org/pacticipants/A%20Consumer/versions/1234/tags/prod"

data/spec/lib/pact_broker/api/decorators/integration_decorator_spec.rb

@@ -1,5 +1,5 @@
-require 'pact_broker/api/decorators/integration_decorator'
-require 'pact_broker/integrations/integration'
+require "pact_broker/api/decorators/integration_decorator"
+require "pact_broker/integrations/integration"
 
 module PactBroker
   module Api
@@ -22,7 +22,7 @@ module PactBroker
         let(:provider) { double("provider", name: "the provider") }
         let(:pseudo_branch_verification_status) { double("pseudo_branch_verification_status", to_s: "some_status") }
 
-        let(:options) { { user_options: { base_url: 'http://example.org' } } }
+        let(:options) { { user_options: { base_url: "http://example.org" } } }
         let(:expected_hash) do
           {
             "consumer" => {

data/spec/lib/pact_broker/api/decorators/integrations_decorator_spec.rb

@@ -1,4 +1,4 @@
-require 'pact_broker/api/decorators/integrations_decorator'
+require "pact_broker/api/decorators/integrations_decorator"
 
 module PactBroker
   module Api
@@ -8,9 +8,9 @@ module PactBroker
           allow(IntegrationDecorator).to receive(:new).and_return(integration_decorator)
         end
         let(:integration_decorator) { instance_double(IntegrationDecorator).as_null_object }
-        let(:integration) { double('integration') }
+        let(:integration) { double("integration") }
         let(:integrations_decorator) { IntegrationsDecorator.new([integration]) }
-        let(:options) { { user_options: { resource_url: 'http://example.org/integrations' } } }
+        let(:options) { { user_options: { resource_url: "http://example.org/integrations" } } }
 
         let(:json) { integrations_decorator.to_json(options) }
 

data/spec/lib/pact_broker/api/decorators/label_decorator_spec.rb

@@ -1,4 +1,4 @@
-require 'pact_broker/api/decorators/label_decorator'
+require "pact_broker/api/decorators/label_decorator"
 
 module PactBroker
   module Api
@@ -13,7 +13,7 @@ module PactBroker
             .and_return(:label)
         end
 
-        let(:options) { { user_options: { base_url: 'http://example.org' } } }
+        let(:options) { { user_options: { base_url: "http://example.org" } } }
 
         subject { JSON.parse LabelDecorator.new(label).to_json(options), symbolize_names: true }
 

data/spec/lib/pact_broker/api/decorators/latest_pact_decorator_spec.rb

@@ -1,5 +1,5 @@
-require 'spec_helper'
-require 'pact_broker/api/decorators/latest_pact_decorator'
+require "spec_helper"
+require "pact_broker/api/decorators/latest_pact_decorator"
 
 module PactBroker
 
@@ -9,9 +9,9 @@ module PactBroker
 
       describe LatestPactDecorator do
 
-        let(:pact_domain) { TestDataBuilder.new.create_pact_with_hierarchy('Consumer', '1.2.3', 'Provider').and_return(:pact) }
+        let(:pact_domain) { TestDataBuilder.new.create_pact_with_hierarchy("Consumer", "1.2.3", "Provider").and_return(:pact) }
         let(:pact) { RepresentablePact.new(pact_domain) }
-        let(:base_url) { 'http://example.org' }
+        let(:base_url) { "http://example.org" }
 
         subject { JSON.parse LatestPactDecorator.new(pact).to_json(user_options: { base_url: base_url }), symbolize_names: true}
 

data/spec/lib/pact_broker/api/decorators/matrix_decorator_spec.rb

@@ -1,19 +1,22 @@
-require 'pact_broker/api/decorators/matrix_decorator'
-require 'pact_broker/matrix/query_results_with_deployment_status_summary'
-require 'pact_broker/matrix/deployment_status_summary'
-require 'pact_broker/matrix/quick_row'
+require "pact_broker/api/decorators/matrix_decorator"
+require "pact_broker/matrix/query_results_with_deployment_status_summary"
+require "pact_broker/matrix/deployment_status_summary"
+require "pact_broker/matrix/quick_row"
 
 module PactBroker
   module Api
     module Decorators
       describe MatrixDecorator do
         describe "to_json" do
+          before do
+            allow_any_instance_of(ReasonDecorator).to receive(:to_s).and_return("foo")
+          end
           let(:verification_date) { DateTime.new(2017, 12, 31) }
           let(:pact_created_at) { DateTime.new(2017, 1, 1) }
           let(:row_1_success) { true }
           let(:row_2_success) { true }
           let(:row_1) do
-            instance_double('PactBroker::Matrix::QuickRow',
+            instance_double("PactBroker::Matrix::QuickRow",
               {
                 consumer_name: "Consumer",
                 consumer_version_number: "1.0.0",
@@ -33,7 +36,7 @@ module PactBroker
           end
 
           let(:row_2) do
-            instance_double('PactBroker::Matrix::QuickRow',
+            instance_double("PactBroker::Matrix::QuickRow",
               {
                 consumer_name: "Consumer",
                 consumer_version_number: "1.0.0",
@@ -53,27 +56,27 @@ module PactBroker
 
           let(:consumer_hash) do
             {
-              name: 'Consumer',
+              name: "Consumer",
               _links: {
                 self: {
-                  href: 'http://example.org/pacticipants/Consumer'
+                  href: "http://example.org/pacticipants/Consumer"
                 }
               },
               version: {
-                number: '1.0.0',
-                branch: 'main',
+                number: "1.0.0",
+                branch: "main",
                 _links: {
                   self: {
-                    href: 'http://example.org/pacticipants/Consumer/versions/1.0.0'
+                    href: "http://example.org/pacticipants/Consumer/versions/1.0.0"
                   }
                 },
                 tags: [
                   {
-                    name: 'prod',
+                    name: "prod",
                     latest: true,
                     _links: {
                       self: {
-                        href: 'http://example.org/pacticipants/Consumer/versions/1.0.0/tags/prod'
+                        href: "http://example.org/pacticipants/Consumer/versions/1.0.0/tags/prod"
                       }
                     }
                   }
@@ -84,27 +87,27 @@ module PactBroker
 
           let(:provider_hash) do
             {
-              name: 'Provider',
+              name: "Provider",
               _links: {
                 self: {
-                  href: 'http://example.org/pacticipants/Provider'
+                  href: "http://example.org/pacticipants/Provider"
                 }
               },
               version: {
-                number: '4.5.6',
-                branch: 'feat/x',
+                number: "4.5.6",
+                branch: "feat/x",
                 _links: {
                   self: {
-                    href: 'http://example.org/pacticipants/Provider/versions/4.5.6'
+                    href: "http://example.org/pacticipants/Provider/versions/4.5.6"
                   }
                 },
                 tags: [
                   {
-                    name: 'master',
+                    name: "master",
                     latest: false,
                     _links: {
                       self: {
-                        href: 'http://example.org/pacticipants/Provider/versions/4.5.6/tags/master'
+                        href: "http://example.org/pacticipants/Provider/versions/4.5.6/tags/master"
                       }
                     }
                   }
@@ -153,14 +156,16 @@ module PactBroker
           end
 
           let(:query_results) do
-            double('QueryResults',
-              rows: [row_1, row_2],
+            double("QueryResults",
+              considered_rows: [row_1, row_2],
+              ignored_rows: ignored_rows,
               selectors: selectors,
               options: options,
               resolved_selectors: resolved_selectors,
               integrations: integrations
             )
           end
+          let(:ignored_rows) { [] }
           let(:query_results_with_deployment_status_summary){ PactBroker::Matrix::QueryResultsWithDeploymentStatusSummary.new(query_results, deployment_status_summary)}
           let(:selectors) { nil }
           let(:integrations){ [] }
@@ -168,10 +173,12 @@ module PactBroker
           let(:resolved_selectors) { nil }
           let(:counts) { { success: 1 } }
           let(:deployment_status_summary) do
-            instance_double('PactBroker::Matrix::DeploymentStatusSummary', reasons: ['foo', 'bar'], deployable?: deployable, counts: counts)
+            instance_double("PactBroker::Matrix::DeploymentStatusSummary", reasons: [reason_1, reason_2], deployable?: deployable, counts: counts)
           end
+          let(:reason_1) { instance_double("PactBroker::Matrix::Reason", type: "info") }
+          let(:reason_2) { instance_double("PactBroker::Matrix::Reason", type: "warning") }
           let(:deployable) { true }
-          let(:json) { MatrixDecorator.new(query_results_with_deployment_status_summary).to_json(user_options: { base_url: 'http://example.org' }) }
+          let(:json) { MatrixDecorator.new(query_results_with_deployment_status_summary).to_json(user_options: { base_url: "http://example.org" }) }
           let(:parsed_json) { JSON.parse(json, symbolize_names: true) }
 
           it "includes the consumer details" do
@@ -192,10 +199,15 @@ module PactBroker
 
           it "includes a summary" do
             expect(parsed_json[:summary][:deployable]).to eq true
-            expect(parsed_json[:summary][:reason]).to eq "foo\nbar"
+            expect(parsed_json[:summary][:reason]).to eq "foo\nfoo"
             expect(parsed_json[:summary][:success]).to eq 1
           end
 
+          it "includes notices" do
+            expect(parsed_json[:notices][0]).to eq text: "foo", type: "info"
+            expect(parsed_json[:notices][1]).to eq text: "foo", type: "warning"
+          end
+
           context "when the pact has not been verified" do
             before do
               allow(row_2).to receive(:success).and_return(nil)
@@ -212,6 +224,19 @@ module PactBroker
               expect(parsed_json[:matrix][1][:verificationResult]).to eq verification_hash
             end
           end
+
+          context "with ignored rows" do
+            let(:ignored_rows) { [row_1] }
+
+            it "includes the considered and ignored rows" do
+              expect(parsed_json[:matrix].size).to eq 3
+              expect(parsed_json[:matrix].first).to_not have_key(:ignored)
+            end
+
+            it "includes the ignored flag" do
+              expect(parsed_json[:matrix].last[:ignored]).to be true
+            end
+          end
         end
       end
     end