openstudio-standards 0.4.0 → 0.5.0

data/lib/openstudio-standards/standards/necb/ECMS/hvac_systems.rb

@@ -255,7 +255,6 @@ class ECMS
       end
     end
     max_net_vert_distance = max_vert_distance + min_vert_distance
-    max_net_vert_distance = [max_net_vert_distance, 0.000001].max
 
     return max_equiv_distance, max_net_vert_distance
   end
@@ -467,10 +466,10 @@ class ECMS
   # =============================================================================================================================
   # The first 5 letters of the air loop name designate the system type (sys_abbr). This method updates the system type designation 
   # in the air loop name. At the same time the chosen air loop names are checked to avoid duplicate names from being used in the 
-  # hash for system to zomes.
+  # hash for system to zones.
   def update_system_zones_map_keys(system_zones_map,sys_abbr)
     updated_system_zones_map = {}
-    system_zones_map.sort.each do |sname,zones|
+    system_zones_map.each do |sname,zones|
       updated_sys_name = "#{sys_abbr}#{sname[5..-1]}"
       if !updated_system_zones_map.has_key? updated_sys_name
         updated_system_zones_map[updated_sys_name] = zones
@@ -595,12 +594,12 @@ class ECMS
 
   # =============================================================================================================================
   # Apply efficiencies for ECM 'hs08_ccashp_vrf'
-  def apply_efficiency_ecm_hs08_ccashp_vrf(model, air_sys_eqpt_type: 'ccashp')
+  def apply_efficiency_ecm_hs08_ccashp_vrf(model, standard, air_sys_eqpt_type: 'ccashp')
     # Use same performance data as ECM 'hs09_ccashpsys' for air system
     if air_sys_eqpt_type == 'ccashp'
-      apply_efficiency_ecm_hs09_ccashp_baseboard(model)
+      apply_efficiency_ecm_hs09_ccashp_baseboard(model,standard)
     elsif air_sys_eqpt_type == 'ashp'
-      apply_efficiency_ecm_hs12_ashp_baseboard(model)
+      apply_efficiency_ecm_hs12_ashp_baseboard(model,standard)
     end
     # Apply efficiency for VRF units
     eqpt_name = 'Mitsubishi_Hyper_Heating_VRF_Outdoor_Unit'
@@ -1042,8 +1041,13 @@ class ECMS
     htg_eqpt = nil
     case loop_htg_eqpt_type.downcase
     when "district_heating"
-     htg_eqpt = OpenStudio::Model::DistrictHeating.new(model)
-     htg_eqpt.setName("DistrictHeating")
+      if model.version < OpenStudio::VersionString.new('3.7.0')
+        htg_eqpt = OpenStudio::Model::DistrictHeating.new(model)
+      else
+        htg_eqpt = OpenStudio::Model::DistrictHeatingWater.new(model)
+      end
+      htg_eqpt.setName("DistrictHeating")
+    
     when "heatpump_watertowater_equationfit"
       htg_eqpt = OpenStudio::Model::HeatPumpWaterToWaterEquationFitHeating.new(model)
       htg_eqpt.setName("HeatPumpWaterToWaterEquationFitHeating")
@@ -1106,7 +1110,11 @@ class ECMS
       heat_rej_eqpt = OpenStudio::Model::GroundHeatExchangerVertical.new(model)
       heat_rej_eqpt.setName("GroundHeatExchangerVertical")
     when "district_heating"
-      heat_rej_eqpt = OpenStudio::Model::DistrictHeating.new(model)
+      if model.version < OpenStudio::VersionString.new('3.7.0')
+        heat_rej_eqpt = OpenStudio::Model::DistrictHeating.new(model)
+      else
+        heat_rej_eqpt = OpenStudio::Model::DistrictHeatingWater.new(model)
+      end
       heat_rej_eqpt.setName("DistrictHeating")
     when "district_cooling"
       heat_rej_eqpt = OpenStudio::Model::DistrictCooling.new(model)
@@ -1253,13 +1261,16 @@ class ECMS
       coil_cooling_dx_variable_speed_apply_curves(clg_dx_coil, eqpt_name)
       coil_heating_dx_variable_speed_apply_curves(htg_dx_coil, eqpt_name)
       # add zone equipment and diffuser
-      zone_htg_eqpt_type = 'baseboard_hotwater' if heating_fuel == 'NaturalGas'
-      zone_htg_eqpt_type = 'baseboard_electric' if heating_fuel == 'Electricity'
-      zone_htg_eqpt_type = 'ptac_electric_off' if sys_info['sys_vent_type'] == 'doas'
-      zone_clg_eqpt_type = 'none'
-      zone_clg_eqpt_type = 'ptac_electric_off' if sys_info['sys_vent_type'] == 'doas'
-      zone_fan_type = 'none'
-      zone_fan_type = 'constant_volume' if sys_info['sys_vent_type'] == 'doas'
+      if sys_info['sys_vent_type'] == 'doas'
+        zone_htg_eqpt_type = 'ptac_electric_off'
+        zone_clg_eqpt_type = 'ptac_electric_off'
+        zone_fan_type = 'constant_volume'
+      else
+        zone_htg_eqpt_type = 'baseboard_electric' if updated_heating_fuel == 'Electricity'
+        zone_htg_eqpt_type = 'baseboard_hotwater' if updated_heating_fuel == 'NaturalGas'
+        zone_clg_eqpt_type = 'none'
+        zone_fan_type = 'none'
+      end
       add_zone_eqpt(model: model,
                     airloop: airloop,
                     zones: zones,
@@ -1271,9 +1282,9 @@ class ECMS
                     zone_fan_type: zone_fan_type,
                     hw_loop: hw_loop)
       # for doas use baseboard electric or hotwater as backup for PTAC units
-      zone_htg_eqpt_type = 'baseboard_hotwater' if heating_fuel == 'NaturalGas'
-      zone_htg_eqpt_type = 'baseboard_electric' if heating_fuel == 'Electricity'
       if sys_info['sys_vent_type'] == 'doas'
+        zone_htg_eqpt_type = 'baseboard_electric' if updated_heating_fuel == 'Electricity'
+        zone_htg_eqpt_type = 'baseboard_hotwater' if updated_heating_fuel == 'NaturalGas'
         add_zone_eqpt(model: model,
                       airloop: airloop,
                       zones: zones,
@@ -1294,7 +1305,7 @@ class ECMS
 
   # =============================================================================================================================
   # Apply effiencies for ECM "hs09_ccashp_baseboard"
-  def apply_efficiency_ecm_hs09_ccashp_baseboard(model)
+  def apply_efficiency_ecm_hs09_ccashp_baseboard(model,standard)
     # fraction of electric backup heating coil capacity assigned to dx heating coil
     fr_backup_coil_cap_as_dx_coil_cap = 0.5
     model.getAirLoopHVACs.sort.each do |isys|
@@ -1464,9 +1475,9 @@ class ECMS
 
   # =============================================================================================================================
   # Apply efficiencies and performance curves for ECM "hs11_ashp_pthp"
-  def apply_efficiency_ecm_hs11_ashp_pthp(model)
+  def apply_efficiency_ecm_hs11_ashp_pthp(model,standard)
     fr_backup_coil_cap_as_dx_coil_cap = 0.5 # fraction of electric backup heating coil capacity assigned to dx heating coil
-    apply_efficiency_ecm_hs12_ashp_baseboard(model)
+    apply_efficiency_ecm_hs12_ashp_baseboard(model,standard)
     pthp_eqpt_name = 'HS11_PTHP'
     model.getAirLoopHVACs.sort.each do |isys|
       isys.thermalZones.each do |zone|
@@ -1576,13 +1587,16 @@ class ECMS
       coil_cooling_dx_single_speed_apply_curves(clg_dx_coil,eqpt_name)
       coil_heating_dx_single_speed_apply_curves(htg_dx_coil,eqpt_name)
       # add zone equipment and diffuser
-      zone_htg_eqpt_type = 'baseboard_hotwater' if heating_fuel == 'NaturalGas'
-      zone_htg_eqpt_type = 'baseboard_electric' if heating_fuel == 'Electricity'
-      zone_htg_eqpt_type = 'ptac_electric_off' if sys_info['sys_vent_type'] == 'doas'
-      zone_clg_eqpt_type = 'none'
-      zone_clg_eqpt_type = 'ptac_electric_off' if sys_info['sys_vent_type'] == 'doas'
-      zone_fan_type = 'none'
-      zone_fan_type = 'constant_volume' if sys_info['sys_vent_type'] == 'doas'
+      if sys_info['sys_vent_type'] == 'doas'
+        zone_htg_eqpt_type = 'ptac_electric_off'
+        zone_clg_eqpt_type = 'ptac_electric_off'
+        zone_fan_type = 'constant_volume'
+      else
+        zone_htg_eqpt_type = 'baseboard_electric' if updated_heating_fuel == 'Electricity'
+        zone_htg_eqpt_type = 'baseboard_hotwater' if updated_heating_fuel == 'NaturalGas'
+        zone_clg_eqpt_type = 'none'
+        zone_fan_type = 'none'
+      end
       add_zone_eqpt(model: model,
                     airloop: airloop,
                     zones: zones,
@@ -1595,6 +1609,8 @@ class ECMS
                     hw_loop: hw_loop)
       # for doas use baseboard electric or hotwater as backup for PTAC units
       if sys_info['sys_vent_type'] == 'doas'
+        zone_htg_eqpt_type = 'baseboard_electric' if updated_heating_fuel == 'Electricity'
+        zone_htg_eqpt_type = 'baseboard_hotwater' if updated_heating_fuel == 'NaturalGas'
         add_zone_eqpt(model: model,
                       airloop: airloop,
                       zones: zones,
@@ -1630,7 +1646,7 @@ class ECMS
 
   # =============================================================================================================================
   # Apply efficiencies and performance curves for ECM "hs12_ashp_baseboard"
-  def apply_efficiency_ecm_hs12_ashp_baseboard(model)
+  def apply_efficiency_ecm_hs12_ashp_baseboard(model,standard)
     fr_backup_coil_cap_as_dx_coil_cap = 0.5 # fraction of electric backup heating coil capacity assigned to dx heating coil
     ashp_eqpt_name = 'NECB2015_ASHP'
     model.getAirLoopHVACs.sort.each do |isys|
@@ -1706,9 +1722,9 @@ class ECMS
 
   # =============================================================================================================================
   # Apply efficiencies and performance curves for ECM "hs12_ashp_vrf"
-  def apply_efficiency_ecm_hs13_ashp_vrf(model)
+  def apply_efficiency_ecm_hs13_ashp_vrf(model,standard)
     # call method for ECM hs08 with ASHP in air system
-    apply_efficiency_ecm_hs08_ccashp_vrf(model, air_sys_eqpt_type: 'ashp')
+    apply_efficiency_ecm_hs08_ccashp_vrf(model, standard, air_sys_eqpt_type: 'ashp')
   end
 
   # =============================================================================================================================
@@ -1825,7 +1841,7 @@ class ECMS
                                              loop_spm_type: 'Scheduled',
                                              loop_setpoint: 50.0,
                                              loop_temp_diff: 5.0)
-    model.getCoilHeatingWaters.each {|coil| hw_loop.addDemandBranchForComponent(coil)}
+    model.getCoilHeatingWaters.sort.each {|coil| hw_loop.addDemandBranchForComponent(coil)}
     hcapf_curve_name = "HEATPUMP_WATERTOWATER_HCAPF"
     hcapf_curve = model_add_curve(model, hcapf_curve_name)
     if hcapf_curve
@@ -1857,7 +1873,7 @@ class ECMS
     
     chw_loop_clg_eqpt.setName('ChillerWaterCooled')
     chw_loop_clg_eqpt.setCondenserType("WaterCooled")
-    model.getCoilCoolingWaters.each {|coil| chw_loop.addDemandBranchForComponent(coil)}
+    model.getCoilCoolingWaters.sort.each {|coil| chw_loop.addDemandBranchForComponent(coil)}
     sec_chiller = OpenStudio::Model::ChillerElectricEIR.new(model)
     chw_loop_clg_eqpt_outlet_node = chw_loop_clg_eqpt.supplyOutletModelObject.get.to_Node.get
     sec_chiller.addToNode(chw_loop_clg_eqpt_outlet_node)
@@ -1900,20 +1916,23 @@ class ECMS
 
   #=============================================================================================================================
   # Appy efficiencies for ECM "hs14_cgshp_fancoils"
-  def apply_efficiency_ecm_hs14_cgshp_fancoils(model)
+  def apply_efficiency_ecm_hs14_cgshp_fancoils(model,standard)
     heatpump_siz_f = 0.4  # sizing factor for water-source heat pump (heating mode)
     chiller_siz_f = 0.4  # sizing factor for water-cooled chiller 
-    # get water-source heat pump
+    # get water-source heat pump and boiler
     hw_loops = model.getPlantLoops.select {|loop| loop.sizingPlant.loopType.to_s.downcase == 'heating'}
     hw_heatpump_loop = nil
     hw_heatpump = nil
+    hw_boiler = nil
     hw_loops.each do |hw_loop|
       hw_heatpumps = hw_loop.supplyComponents.select {|comp| comp.to_HeatPumpWaterToWaterEquationFitHeating.is_initialized}
       if !hw_heatpumps.empty?
         hw_heatpump_loop = hw_loop
         hw_heatpump = hw_heatpumps[0].to_HeatPumpWaterToWaterEquationFitHeating.get
-        break
       end
+      hw_boilers = hw_loop.supplyComponents.select {|comp| comp.to_BoilerHotWater.is_initialized}
+      hw_boiler = hw_boilers[0].to_BoilerHotWater.get if !hw_boilers.empty?
+      break if !hw_heatpump_loop.nil? && !hw_heatpump.nil? && !hw_boiler.nil?
     end
     raise("apply_efficiency_ecm_hs14_cgshp_fancoils: no water-source heat pump found in heating loop #{hw_loops.name.to_s}") if hw_heatpump.nil?
     cw_loop = model.getPlantLoops.select {|loop| loop.sizingPlant.loopType.to_s.downcase == 'condenser'}[0]
@@ -1937,8 +1956,10 @@ class ECMS
     cw_loop.setMaximumLoopFlowRate(cw_loop_max_flow)
     cw_loop_pump = cw_loop.supplyComponents.select {|comp| comp.to_PumpVariableSpeed.is_initialized}[0].to_PumpVariableSpeed.get
     cw_loop_pump.setRatedFlowRate(cw_loop_max_flow)
-    # set heating capacity of water-source heat pump
-    if hw_heatpump.ratedHeatingCapacity.is_initialized
+    # set heating capacity of water-source heat pump and boiler
+    if hw_heatpump.autosizedRatedHeatingCapacity.is_initialized
+      cap = hw_heatpump.autosizedRatedHeatingCapacity.to_f
+    elsif hw_heatpump.ratedHeatingCapacity.is_initialized
       cap = hw_heatpump.ratedHeatingCapacity.to_f
     elsif hw_heatpump.autosizedRatedHeatingCapacity.is_initialized
       cap = hw_heatpump.autosizedRatedHeatingCapacity.to_f
@@ -1946,18 +1967,22 @@ class ECMS
       raise("apply_efficiency_ecm_hs14_cgshp_fancoils: capacity of water-source heat pump #{hw_heatpump.name.to_s} is not defined")
     end
     hw_heatpump.setRatedHeatingCapacity(heatpump_siz_f*cap)
-    # set cooling capacity of water-cooled chiller
+    hw_boiler.setNominalCapacity((1.0-heatpump_siz_f)*cap)
+    # set cooling capacity of chillers
     chillers = chw_loop.supplyComponents.select {|comp| comp.to_ChillerElectricEIR.is_initialized}
     chiller_water_cooled = nil
+    chiller_air_cooled = nil
     chillers.each do |comp|
       chlr = comp.to_ChillerElectricEIR.get
-      if chlr.name.to_s.include? 'ChillerWaterCooled'
-        chiller_water_cooled = chlr
-        break
-      end
-    end
+      chiller_water_cooled = chlr if chlr.name.to_s.include? 'ChillerWaterCooled'
+      chiller_air_cooled = chlr if chlr.name.to_s.include? 'ChillerAirCooled'
+      break if !chiller_water_cooled.nil? && !chiller_air_cooled.nil?
+    end 
     raise("apply_efficiency_ecm_hs14_cgshp_fancoils: no water-cooled chiller found in cooling loop #{chw_loop.name.to_s}") if chiller_water_cooled.nil?
-    if chiller_water_cooled.referenceCapacity.is_initialized
+    raise("apply_efficiency_ecm_hs14_cgshp_fancoils: no air-cooled chiller found in cooling loop #{chw_loop.name.to_s}") if chiller_air_cooled.nil?
+    if chiller_water_cooled.autosizedReferenceCapacity.is_initialized
+      cap = chiller_water_cooled.autosizedReferenceCapacity.to_f
+    elsif chiller_water_cooled.referenceCapacity.is_initialized
       cap = chiller_water_cooled.referenceCapacity.to_f
     elsif chiller_water_cooled.autosizedReferenceCapacity.is_initialized
       cap = chiller_water_cooled.autosizedReferenceCapacity.to_f
@@ -1965,6 +1990,24 @@ class ECMS
       raise("apply_efficiency_ecm_hs14_cgshp_fancoils: cooling capacity of chiller #{chiller_water_cooled.name.to_s} is not defined")
     end
     chiller_water_cooled.setReferenceCapacity(chiller_siz_f*cap)
+    chiller_air_cooled.setReferenceCapacity((1.0-chiller_siz_f)*cap)
+    # call standard efficiency method again for water-cooled chiller
+    new_chlr_name = chiller_water_cooled.name.to_s.chomp!(chiller_water_cooled.name.to_s.split.last).strip
+    new_chlr_name = new_chlr_name.chomp!(new_chlr_name.split.last).strip
+    new_chlr_name = new_chlr_name.chomp!(new_chlr_name.split.last).strip
+    chiller_water_cooled.setName(new_chlr_name)
+    standard.chiller_electric_eir_apply_efficiency_and_curves(chiller_water_cooled,nil)
+    # set curves and cop of air-cooled chiller
+    chlr_cap_w = (1.0-chiller_siz_f)*cap
+    chlr_cap_ton = OpenStudio.convert(chlr_cap_w, 'W', 'ton').get
+    search_criteria = {}
+    search_criteria['cooling_type'] = 'AirCooled'
+    chlr_props = model_find_object(standards_data['tables']['chiller_types_ecm']['table'], search_criteria, chlr_cap_ton)
+    chiller_air_cooled.setName("ChillerAirCooled #{chlr_props['compressor_type']}")
+    search_criteria = {}
+    search_criteria['name'] = 'NECB2020_AirCooledChiller'
+    search_criteria['compressor_type'] = chlr_props['compressor_type']
+    chiller_electric_eir_apply_curves_and_cop(chiller_air_cooled, search_criteria)
   end
 
   #=============================================================================================================================
@@ -1975,11 +2018,20 @@ class ECMS
     # maximum district cooling rate on the summer design day.
 
     cw_loops = model.getPlantLoops.select{|loop| loop.sizingPlant.loopType.to_s.downcase == 'condenser'}
-    ghx_loops = cw_loops.select {|loop| loop.name.to_s.downcase.include? 'glhx'}
+    ghx_loops = cw_loops.select { |loop| loop.name.to_s.downcase.include? 'glhx' }
     return if ghx_loops.empty?
     ghx_loop = ghx_loops[0]
-    dist_htg_eqpts = ghx_loop.supplyComponents.select {|comp| comp.to_DistrictHeating.is_initialized}
-    dist_htg_eqpt = dist_htg_eqpts[0].to_DistrictHeating.get if !dist_htg_eqpts.empty?
+    dist_htg_eqpts = ghx_loop.supplyComponents.select { |comp| comp.iddObjectType.valueName.to_s.include?('DistrictHeating') }
+    if !dist_htg_eqpts.empty?
+      case dist_htg_eqpts[0].iddObjectType.valueName.to_s
+      when 'OS_DistrictHeating'
+        dist_htg_eqpt = dist_htg_eqpts[0].to_DistrictHeating.get
+      when 'OS_DistrictHeatingWater'
+        dist_htg_eqpt = dist_htg_eqpts[0].to_DistrictHeatingWater.get
+      when 'OS_DistrictHeatingSteam'
+        dist_htg_eqpt = dist_htg_eqpts[0].to_DistrictHeatingSteam.get
+      end
+    end
     dist_clg_eqpts = ghx_loop.supplyComponents.select {|comp| comp.to_DistrictCooling.is_initialized}
     dist_clg_eqpt = dist_clg_eqpts[0].to_DistrictCooling.get if !dist_clg_eqpts.empty?
     raise("set_cond_loop_district_cap: condenser loop doesn't have a district heating and district cooling objects") if dist_htg_eqpts.empty? || dist_clg_eqpts.empty?
@@ -2101,14 +2153,13 @@ class ECMS
     capacity_w = coil_heating_dx_single_speed_find_capacity(coil_heating_dx_single_speed)
     capacity_w = [1.0,capacity_w].max
     capacity_btu_per_hr = OpenStudio.convert(capacity_w, 'W', 'Btu/hr').get
-    capacity_kbtu_per_hr = OpenStudio.convert(capacity_w, 'W', 'kBtu/hr').get
 
     # Lookup efficiencies
     props = model_find_object(standards_data['tables']['heat_pump_heating_ecm']['table'], search_criteria, capacity_btu_per_hr)
 
     # Check to make sure properties were found
     if props.nil?
-      OpenStudio.logFree(OpenStudio::Warn, 'openstudio.standards.CoilHeatingDXSingleSpeed', "For #{coil_heating_dx_single_speed.name}, cannot find efficiency info using #{search_criteria}, cannot apply efficiency standard.")
+      OpenStudio.logFree(OpenStudio::Warn, 'openstudio.standards.CoilHeatingDXSingleSpeed', "For #{coil_heating_dx_single_speed.name}, cannot find efficiency info using #{search_criteria}.")
       successfully_set_all_properties = false
     end
 
@@ -2168,6 +2219,62 @@ class ECMS
 
   end
 
+  # =============================================================================================================================
+  # Applies the performance curves "ChillerElectricEIR" object.
+  def chiller_electric_eir_apply_curves_and_cop(chiller_electric_eir, search_criteria)
+    successfully_set_all_properties = true
+
+    # Get the capacity
+    capacity_w = chiller_electric_eir_find_capacity(chiller_electric_eir)
+    capacity_tons = OpenStudio.convert(capacity_w, 'W', 'ton').get
+
+    # Lookup performance curves
+    chlr_props = model_find_object(standards_data['tables']['chillers_ecm']['table'], search_criteria, capacity_tons)
+
+    # Check to make sure properties were found
+    if chlr_props.nil?
+      OpenStudio.logFree(OpenStudio::Warn, 'openstudio.standard.ChillerElectricEIR', "For #{chiller_electric_eir.name}, cannot find efficiency info using #{search_criteria}")
+      successfully_set_all_properties = false
+    end
+
+    # CAP-FT curve
+    capft = model_add_curve(chiller_electric_eir.model, chlr_props['capft'])
+    if capft
+      chiller_electric_eir.setCoolingCapacityFunctionOfTemperature(capft)
+    else
+      OpenStudio.logFree(OpenStudio::Warn, 'openstudio.standard.ChillerElectricEIR', "For #{chiller_electric_eir.name}, cannot find cap_ft curve, will not be set.")
+      successfully_set_all_properties = false
+    end
+
+    # EIR-FT curve
+    eirft = model_add_curve(chiller_electric_eir.model, chlr_props['eirft'])
+    if eirft
+      chiller_electric_eir.setElectricInputToCoolingOutputRatioFunctionOfTemperature(eirft)
+    else
+      OpenStudio.logFree(OpenStudio::Warn, 'openstudio.standard.ChillerElectricEIR', "For #{chiller_electric_eir.name}, cannot find eir_ft curve, will not be set.")
+      successfully_set_all_properties = false
+    end
+
+    # EIR-FPLR curve
+    eirfplr = model_add_curve(chiller_electric_eir.model, chlr_props['eirfplr'])
+    if eirfplr
+      chiller_electric_eir.setElectricInputToCoolingOutputRatioFunctionOfPLR(eirfplr)
+    else
+      OpenStudio.logFree(OpenStudio::Warn, 'openstudio.standard.ChillerElectricEIR', "For #{chiller_electric_eir.name}, cannot find eir_fplr curve, will not be set.")
+      successfully_set_all_properties = false
+    end
+
+    # set COP
+    cop = chlr_props['minimum_coefficient_of_performance_cooling'].to_f
+    if cop
+      chiller_electric_eir.setReferenceCOP(cop)
+    else
+      OpenStudio.logFree(OpenStudio::Warn, 'openstudio.standard.ChillerElectricEIR', "For #{chiller_electric_eir.name}, cannot find cop, will not be set.")
+      successfully_set_all_properties = false
+    end
+    
+  end
+
   # =============================================================================================================================
   # Applies the performance curves "CoilCoolingDXVariableSpeed" object.
   def coil_cooling_dx_variable_speed_apply_curves(coil_cooling_dx_variable_speed, eqpt_name)
@@ -2177,7 +2284,6 @@ class ECMS
     capacity_w = coil_cooling_dx_variable_speed_find_capacity(coil_cooling_dx_variable_speed)
     capacity_w = [1.0,capacity_w].max
     capacity_btu_per_hr = OpenStudio.convert(capacity_w, 'W', 'Btu/hr').get
-    capacity_kbtu_per_hr = OpenStudio.convert(capacity_w, 'W', 'kBtu/hr').get
 
     # Lookup performance curves
     search_criteria = {}
@@ -2250,14 +2356,13 @@ class ECMS
     capacity_w = coil_heating_dx_variable_speed_find_capacity(coil_heating_dx_variable_speed)
     capacity_w = [1.0,capacity_w].max
     capacity_btu_per_hr = OpenStudio.convert(capacity_w, 'W', 'Btu/hr').get
-    capacity_kbtu_per_hr = OpenStudio.convert(capacity_w, 'W', 'kBtu/hr').get
 
     # Lookup performance curves
     props = model_find_object(standards_data['tables']['heat_pump_heating_ecm']['table'], search_criteria, capacity_btu_per_hr)
 
     # Check to make sure properties were found
     if props.nil?
-      OpenStudio.logFree(OpenStudio::Warn, 'openstudio.standards.CoilHeatingDXVariableSpeed', "For #{coil_heating_dx_variable_speed.name}, cannot find efficiency info using #{search_criteria}, cannot apply efficiency standard.")
+      OpenStudio.logFree(OpenStudio::Warn, 'openstudio.standards.CoilHeatingDXVariableSpeed', "For #{coil_heating_dx_variable_speed.name}, cannot find efficiency info using #{search_criteria}.")
       successfully_set_all_properties = false
     end
 
@@ -2328,7 +2433,6 @@ class ECMS
     capacity_w = airconditioner_variablerefrigerantflow_cooling_find_capacity(airconditioner_variablerefrigerantflow)
     capacity_w = [1.0,capacity_w].max
     capacity_btu_per_hr = OpenStudio.convert(capacity_w, 'W', 'Btu/hr').get
-    capacity_kbtu_per_hr = OpenStudio.convert(capacity_w, 'W', 'kBtu/hr').get
 
     # Lookup performance curves
     props = model_find_object(standards_data['tables']['heat_pump_cooling_ecm']['table'], search_criteria, capacity_btu_per_hr)
@@ -2460,7 +2564,6 @@ class ECMS
     capacity_w = airconditioner_variablerefrigerantflow_heating_find_capacity(airconditioner_variablerefrigerantflow)
     capacity_w = [1.0,capacity_w].max
     capacity_btu_per_hr = OpenStudio.convert(capacity_w, 'W', 'Btu/hr').get
-    capacity_kbtu_per_hr = OpenStudio.convert(capacity_w, 'W', 'kBtu/hr').get
 
     # Lookup performance curves
     props = model_find_object(standards_data['tables']['heat_pump_heating_ecm']['table'], search_criteria, capacity_btu_per_hr)
@@ -2587,12 +2690,12 @@ class ECMS
 
     # Check to make sure properties were found
     if ac_props.nil?
-      OpenStudio.logFree(OpenStudio::Warn, 'openstudio.standards.CoilCoolingDXSingleSpeed', "For #{coil_cooling_dx_single_speed.name}, cannot find efficiency info using #{search_criteria}, cannot apply efficiency standard.")
+      OpenStudio.logFree(OpenStudio::Warn, 'openstudio.standards.CoilCoolingDXSingleSpeed', "For #{coil_cooling_dx_single_speed.name}, cannot find efficiency info using #{search_criteria}.")
       successfully_set_all_properties = false
       return successfully_set_all_properties
     end
 
-    # Get the minimum efficiency standards
+    # Get the minimum efficiency
     cop = nil
 
     # If specified as SEER
@@ -2659,12 +2762,12 @@ class ECMS
 
     # Check to make sure properties were found
     if props.nil?
-      OpenStudio.logFree(OpenStudio::Warn, 'openstudio.standards.CoilHeatingDXSingleSpeed', "For #{coil_heating_dx_single_speed.name}, cannot find efficiency info using #{search_criteria}, cannot apply efficiency standard.")
+      OpenStudio.logFree(OpenStudio::Warn, 'openstudio.standards.CoilHeatingDXSingleSpeed', "For #{coil_heating_dx_single_speed.name}, cannot find efficiency info using #{search_criteria}")
       successfully_set_all_properties = false
       return successfully_set_all_properties
     end
 
-    # Get the minimum efficiency standards
+    # Get the minimum efficiency
     cop = nil
 
     # If specified as EER
@@ -2723,12 +2826,12 @@ class ECMS
 
     # Check to make sure properties were found
     if ac_props.nil?
-      OpenStudio.logFree(OpenStudio::Warn, 'openstudio.standards.CoilCoolingDXVariableSpeed', "For #{coil_cooling_dx_variable_speed.name}, cannot find efficiency info using #{search_criteria}, cannot apply efficiency standard.")
+      OpenStudio.logFree(OpenStudio::Warn, 'openstudio.standards.CoilCoolingDXVariableSpeed', "For #{coil_cooling_dx_variable_speed.name}, cannot find efficiency info using #{search_criteria}.")
       successfully_set_all_properties = false
       return successfully_set_all_properties
     end
 
-    # Get the minimum efficiency standards
+    # Get the minimum efficiency
     cop = nil
 
     # If specified as SEER
@@ -2795,12 +2898,12 @@ class ECMS
 
     # Check to make sure properties were found
     if props.nil?
-      OpenStudio.logFree(OpenStudio::Warn, 'openstudio.standards.CoilHeatingDXVariableSpeed', "For #{coil_heating_dx_variable_speed.name}, cannot find efficiency info using #{search_criteria}, cannot apply efficiency standard.")
+      OpenStudio.logFree(OpenStudio::Warn, 'openstudio.standards.CoilHeatingDXVariableSpeed', "For #{coil_heating_dx_variable_speed.name}, cannot find efficiency info using #{search_criteria}.")
       successfully_set_all_properties = false
       return successfully_set_all_properties
     end
 
-    # Get the minimum efficiency standards
+    # Get the minimum efficiency
     cop = nil
 
     # If specified as EER
@@ -2859,12 +2962,12 @@ class ECMS
 
     # Check to make sure properties were found
     if props.nil?
-      OpenStudio.logFree(OpenStudio::Warn, 'openstudio.standards.AirConditionerVariableRefrigerantFlow', "For #{airconditioner_variablerefrigerantflow.name}, cannot find efficiency info using #{search_criteria}, cannot apply efficiency standard.")
+      OpenStudio.logFree(OpenStudio::Warn, 'openstudio.standards.AirConditionerVariableRefrigerantFlow', "For #{airconditioner_variablerefrigerantflow.name}, cannot find efficiency info using #{search_criteria}.")
       successfully_set_all_properties = false
       return successfully_set_all_properties
     end
 
-    # Get the minimum efficiency standards
+    # Get the minimum efficiency
     cop = nil
 
     # If specified as EER
@@ -2923,12 +3026,12 @@ class ECMS
 
     # Check to make sure properties were found
     if props.nil?
-      OpenStudio.logFree(OpenStudio::Warn, 'openstudio.standards.AirConditionerVariableRefrigerantFlow', "For #{airconditioner_variablerefrigerantflow.name}, cannot find heating efficiency info using #{search_criteria}, cannot apply efficiency standard.")
+      OpenStudio.logFree(OpenStudio::Warn, 'openstudio.standards.AirConditionerVariableRefrigerantFlow', "For #{airconditioner_variablerefrigerantflow.name}, cannot find heating efficiency info using #{search_criteria}.")
       successfully_set_all_properties = false
       return successfully_set_all_properties
     end
 
-    # Get the minimum efficiency standards
+    # Get the minimum efficiency
     cop = nil
 
     # If specified as EER
@@ -2981,7 +3084,7 @@ class ECMS
     elsif coil_cooling_dx_variable_speed.autosizedGrossRatedTotalCoolingCapacityAtSelectedNominalSpeedLevel.is_initialized
       capacity_w = coil_cooling_dx_variable_speed.autosizedGrossRatedTotalCoolingCapacityAtSelectedNominalSpeedLevel.get
     else
-      OpenStudio.logFree(OpenStudio::Warn, 'openstudio.standards.CoilCoolingDXVariableSpeed', "For #{coil_cooling_dx_variable_speed.name} capacity is not available, cannot apply efficiency standard.")
+      OpenStudio.logFree(OpenStudio::Warn, 'openstudio.standards.CoilCoolingDXVariableSpeed', "For #{coil_cooling_dx_variable_speed.name} capacity is not available.")
       return 0.0
     end
 
@@ -2997,7 +3100,7 @@ class ECMS
     elsif coil_heating_dx_variable_speed.autosizedRatedHeatingCapacityAtSelectedNominalSpeedLevel.is_initialized
       capacity_w = coil_heating_dx_variable_speed.autosizedRatedHeatingCapacityAtSelectedNominalSpeedLevel.get
     else
-      OpenStudio.logFree(OpenStudio::Warn, 'openstudio.standards.CoilHeatingDXVariableSpeed', "For #{coil_heating_dx_variable_speed.name} capacity is not available, cannot apply efficiency standard.")
+      OpenStudio.logFree(OpenStudio::Warn, 'openstudio.standards.CoilHeatingDXVariableSpeed', "For #{coil_heating_dx_variable_speed.name} capacity is not available.")
       return 0.0
     end
 
@@ -3014,7 +3117,7 @@ class ECMS
       capacity_w = airconditioner_variablerefrigerantflow.autosizedRatedTotalCoolingCapacity.get
       airconditioner_variablerefrigerantflow.setRatedTotalCoolingCapacity(capacity_w)
     else
-      OpenStudio.logFree(OpenStudio::Warn, 'openstudio.standards.AirConditionerVariableRefrigerantFlow', "For #{airconditioner_variablerefrigerantflow.name} cooling capacity is not available, cannot apply efficiency standard.")
+      OpenStudio.logFree(OpenStudio::Warn, 'openstudio.standards.AirConditionerVariableRefrigerantFlow', "For #{airconditioner_variablerefrigerantflow.name} cooling capacity is not available.")
       return 0.0
     end
 
@@ -3031,7 +3134,24 @@ class ECMS
       capacity_w = airconditioner_variablerefrigerantflow.autosizedRatedTotalHeatingCapacity.get
       airconditioner_variablerefrigerantflow.setRatedTotalHeatingCapacity(capacity_w)
     else
-      OpenStudio.logFree(OpenStudio::Warn, 'openstudio.standards.AirConditionerVariableRefrigerantFlow', "For #{airconditioner_variablerefrigerantflow.name} heating capacity is not available, cannot apply efficiency standard.")
+      OpenStudio.logFree(OpenStudio::Warn, 'openstudio.standards.AirConditionerVariableRefrigerantFlow', "For #{airconditioner_variablerefrigerantflow.name} heating capacity is not available.")
+      return 0.0
+    end
+
+    return capacity_w
+  end
+
+  # =============================================================================================================================
+  # Find cooling capacity for "ChillerElectricEIR" object
+  def chiller_electric_eir_find_capacity(chiller_electric_eir)
+    capacity_w = nil
+    if chiller_electric_eir.referenceCapacity.is_initialized
+      capacity_w = chiller_electric_eir.referenceCapacity.get
+    elsif chiller_electric_eir.autosizedRererenceCapacity.is_initialized
+      capacity_w = chiller_electric_eir.autosizedRerenceCapacity.get
+      chiller_electric_eir.setReferenceCapacity(capacity_w)
+    else
+      OpenStudio.logFree(OpenStudio::Warn, 'openstudio.standards.ChillerElectricEIR', "For #{chiller_electric_eir.name} capacity not available")
       return 0.0
     end
 
@@ -3234,7 +3354,7 @@ class ECMS
   # If an efficiency is set but is not between 0.01 and 1.0 it returns an error.  Otherwise, it looks for mixed water
   # heaters.  If it finds any it then calls the reset_shw_efficiency method which resets the the shw efficiency and the
   # part load curve. It also renames the shw tank with the following pattern:
-  # {valume}Gal {eff_name} Water Heater - {Capacity}kBtu/hr {efficiency} Therm Eff
+  #   {volume}Gal {eff_name} Water Heater - {Capacity}kBtu/hr {efficiency} Therm Eff
   def modify_shw_efficiency(model:, shw_eff: nil)
     return if shw_eff.nil?
 
@@ -3279,7 +3399,7 @@ class ECMS
   # This method sets the efficiency of the shw heater to whatever is entered in eff["efficiency"].  It then looks for the
   # "part_load_curve" value in the curves.json file.  If it does not find one it returns an error.  If it finds one it
   # resets the part load curve to whatever was found.  It then renames the shw tank according to the following pattern:
-  # {valume}Gal {eff_name} Water Heater - {Capacity}kBtu/hr {efficiency} Therm Eff
+  #   {volume}Gal {eff_name} Water Heater - {Capacity}kBtu/hr {efficiency} Therm Eff
   def reset_shw_efficiency(model:, component:, eff:)
     return if component.heaterFuelType.to_s.upcase == 'ELECTRICITY'
 

data/lib/openstudio-standards/standards/necb/ECMS/pv_ground.rb

@@ -90,7 +90,7 @@ class ECMS
   # Method for calculating footprint of the building model
   def calculate_building_footprint(model:)
     building_footprint_m2_array = []
-    lowest_floor = 10000000000.0 # dummy number as initialization to find the lowest floor among spaces #TODO: Question:it it fine that it has been assumed that the floor of all lowest spaces are at the same level?
+    lowest_floor = 10000000000.0 # dummy number as initialization to find the lowest floor among spaces # @todo Question:it it fine that it has been assumed that the floor of all lowest spaces are at the same level?
     model.getSpaces.sort.each do |space|
       space.surfaces.sort.select { |surface| (surface.surfaceType == 'Floor') && (surface.outsideBoundaryCondition != 'Surface') && (surface.outsideBoundaryCondition != 'Adiabatic') }.each do |surface|
         floor_vertices = surface.vertices

data/lib/openstudio-standards/standards/necb/NECB2011/autozone.rb

@@ -4,7 +4,7 @@ class NECB2011
   # e.g. (Prototype.secondary_school.rb) file.
   #
   # @param (see #add_constructions)
-  # @return [Bool] returns true if successful, false if not
+  # @return [Boolean] returns true if successful, false if not
   def model_create_thermal_zones(model, space_multiplier_map = nil)
     OpenStudio.logFree(OpenStudio::Info, 'openstudio.model.Model', 'Started creating thermal zones')
     space_multiplier_map = {} if space_multiplier_map.nil?
@@ -193,8 +193,14 @@ class NECB2011
     @stored_space_cooling_sizing_loads = {}
     model.getSpaces.sort.each do |space|
       space_type = space.spaceType.get.standardsSpaceType.get
-      @stored_space_heating_sizing_loads[space] = space_type == '- undefined -' ? 0.0 : space.thermalZone.get.heatingDesignLoad.get
-      @stored_space_cooling_sizing_loads[space] = space_type == '- undefined -' ? 0.0 : space.thermalZone.get.coolingDesignLoad.get
+
+      # error if zone design load methods are not available
+      if space.model.version < OpenStudio::VersionString.new('3.6.0')
+        OpenStudio.logFree(OpenStudio::Error, 'openstudio.autozone', "Required ThermalZone methods .autosizedHeatingDesignLoad and .autosizedCoolingDesignLoad are not available in pre-OpenStudio 3.6.0 versions. Use a more recent version of OpenStudio.")
+      end
+
+      @stored_space_heating_sizing_loads[space] = space_type == '- undefined -' ? 0.0 : space.thermalZone.get.autosizedHeatingDesignLoad.get / space.floorArea
+      @stored_space_cooling_sizing_loads[space] = space_type == '- undefined -' ? 0.0 : space.thermalZone.get.autosizedCoolingDesignLoad.get / space.floorArea
     end
   end
 
@@ -795,7 +801,7 @@ class NECB2011
   end
 
   # This model determines the dominant NECB schedule type
-  # @param model [OpenStudio::model::Model] A model object
+  # @param model [OpenStudio::Model::Model] A model object
   # return s.each [String]
   def determine_dominant_necb_schedule_type(model)
     return determine_dominant_schedule(model.getSpaces)