openpay 1.0.3 → 1.0.4

data/test/spec/exceptions_spec.rb

@@ -1,12 +1,9 @@
 require_relative '../spec_helper'
 
-
 describe 'Openpay Exceptions' do
 
-
   before(:all) do
 
-
     @merchant_id='mywvupjjs9xdnryxtplq'
     @private_key='sk_92b25d3baec149e6b428d81abfe37006'
 
@@ -14,12 +11,10 @@ describe 'Openpay Exceptions' do
     @customers=@openpay.create(:customers)
     @cards=@openpay.create(:cards)
 
-
   end
 
   describe OpenpayException do
 
-
     it 'should raise an OpenpayException when a non given resource is passed to the api factory' do
      expect { @openpay.create(:foo) }.to raise_exception OpenpayException
     end
@@ -30,10 +25,8 @@ describe 'Openpay Exceptions' do
       expect { cust.delete_all }.to raise_exception OpenpayException
     end
 
-
   end
 
-
   describe OpenpayTransactionException do
 
     it 'should fail when an invalid field-value is passed in *email' do
@@ -49,12 +42,11 @@ describe 'Openpay Exceptions' do
         #should have the corresponding attributes coming from the json message
         expect(e.http_code).to be 400
         expect(e.error_code).to be 1001
-        expect(e.description).to match 'email\' not a well-formed email address'
+        #expect(e.description).to match 'not a well-formed email address'
         expect(e.json_body).to have_json_path('category')
       end
     end
 
-
     it ' raise  an OpenpayTransactionException when trying to delete a non existing bank account '  do
       #non existing resource
       #perform checks
@@ -70,8 +62,6 @@ describe 'Openpay Exceptions' do
       end
     end
 
-
-
     it 'fails when trying to create an existing card' do
 
       #create customer
@@ -90,24 +80,20 @@ describe 'Openpay Exceptions' do
       @cards.delete card_hash['id']
     end
 
-
     it 'raise  an OpenpayTransactionException when using an expired card' do
       card_hash = FactoryGirl.build(:expired_card)
       expect { @cards.create(card_hash) }.to raise_error(OpenpayTransactionException)
       begin
         @cards.create(card_hash)
-      rescue OpenpayTransactionException =>   e
+      rescue OpenpayTransactionException => e
         expect(e.description).to match 'The card has expired'
         expect(e.error_code).to be 3002
-
       end
 
     end
 
-
   end
 
-
   describe OpenpayConnectionException do
 
     it 'raise an OpenpayConnectionException when provided credentials are invalid' do
@@ -119,20 +105,17 @@ describe 'Openpay Exceptions' do
       customers=openpay.create(:customers)
       expect { customers.delete('1111') }.to raise_exception  OpenpayConnectionException
 
-
       begin
         customers.delete('1111')
       rescue OpenpayConnectionException => e
         #should have the corresponding attributes coming from the json message
         expect(e.http_code).to be 401
         expect(e.error_code).to be 1002
-        expect(e.description).to match 'The api key or merchant id are invalid.'
+        expect(e.description).to match 'The api key or merchant id are invalid'
         expect(e.json_body).to have_json_path('category')
       end
 
-
     end
   end
 
-
-end
+end

data/test/spec/fees_spec.rb

@@ -18,12 +18,15 @@ describe Fees do
 
   end
 
-
   after(:all) do
-    @bank_accounts.delete_all
     @customers.delete_all
   end
 
+  it 'has all required methods' do
+    %w(all each create get list delete).each do |meth|
+      expect(@customers).to respond_to(meth)
+    end
+  end
 
   describe '.create' do
 
@@ -54,7 +57,6 @@ describe Fees do
 
     end
 
-
     it 'creates a fee using a json message' do
       #create new customer
       customer_hash= FactoryGirl.build(:customer)
@@ -77,12 +79,19 @@ describe Fees do
 
   end
 
+  describe '.each' do
 
+    it 'iterates over all elements' do
+      @fees.each do |fee|
+        expect(fee['description']).to match /\s+/
+      end
+    end
 
+  end
 
-  describe '.all' do
+  describe '.list' do
 
-    it 'get all fees' do
+    it 'list fees with a given filter' do
 
       #create new customer
       customer_hash= FactoryGirl.build(:customer)
@@ -100,17 +109,52 @@ describe Fees do
       fee_hash = FactoryGirl.build(:fee, customer_id: customer['id'])
       @fees.create(fee_hash)
 
+      #create customer fee
+      fee_hash = FactoryGirl.build(:fee, customer_id: customer['id'])
+      @fees.create(fee_hash)
+
+
       #performs check
-      expect(@fees.all.first['amount']).to be_a Float
+      search_params = OpenpayUtils::SearchParams.new
+      search_params.limit = 1
+      expect(@fees.list(search_params).size).to eq 1
+
 
       #cleanup
       @cards.delete(card['id'], customer['id'])
       @customers.delete(customer['id'])
 
     end
+
   end
-end
 
+  describe '.all' do
+
+    it 'get all fees' do
+
+      #create new customer
+      customer_hash= FactoryGirl.build(:customer)
+      customer=@customers.create(customer_hash)
+
+      #create customer card
+      card_hash=FactoryGirl.build(:valid_card)
+      card=@cards.create(card_hash, customer['id'])
+
+      #create charge
+      charge_hash=FactoryGirl.build(:card_charge, source_id: card['id'], order_id: card['id'], amount: 4000)
+      @charges.create(charge_hash, customer['id'])
+
+      #create customer fee
+      fee_hash = FactoryGirl.build(:fee, customer_id: customer['id'])
+      @fees.create(fee_hash)
 
+      #performs check
+      expect(@fees.all.first['amount']).to be_a Float
 
+      #cleanup
+      @cards.delete(card['id'], customer['id'])
+      @customers.delete(customer['id'])
 
+    end
+  end
+end

data/test/spec/payouts_spec.rb

@@ -1,9 +1,8 @@
 require_relative '../spec_helper'
 
-
 describe Payouts do
 
-   before(:all) do
+  before(:all) do
 
     @merchant_id='mywvupjjs9xdnryxtplq'
     @private_key='sk_92b25d3baec149e6b428d81abfe37006'
@@ -21,53 +20,64 @@ describe Payouts do
 
   end
 
+  it 'has all required methods' do
+    %w(all each create get list delete).each do |meth|
+      expect(@cards).to respond_to(meth)
+    end
+  end
 
   describe '.create' do
 
     it 'creates a merchant payout' do
 
-    payout_hash= FactoryGirl.build(:payout_card, destination_id: 'b4ravkgvpir9izop1faz',amount: 100)
-
-     payout=@payouts.create(payout_hash)
-     expect(@payouts.get(payout['id'])['amount']).to be_within(0.1).of(100)
-
-    end
+      pending
+      #create merchant card
+      card_hash = FactoryGirl.build(:valid_card)
+      card = @cards.create(card_hash)
 
+      #create charge
+      charge_hash=FactoryGirl.build(:card_charge, source_id: card['id'], order_id: card['id'])
+      charge=@charges.create(charge_hash)
 
+      payout_hash=FactoryGirl.build(:payout_card, destination_id: card['id'], amount: 100)
 
+      payout=@payouts.create(payout_hash)
+      expect(@payouts.get(payout['id'])['amount']).to be_within(0.1).of(100)
 
-      it 'creates a customer  payout using a card' do
-        #We need to charge 1st into the card we are going to use
+      @cards.delete(card['id'])
 
-        #create new customer
-        customer_hash= FactoryGirl.build(:customer)
-        customer=@customers.create(customer_hash)
+    end
 
-        #create new customer card
-        card_hash=FactoryGirl.build(:valid_card)
-        card=@cards.create(card_hash, customer['id'])
+    it 'creates a customer payout using a card' do
+      #We need to charge 1st into the card we are going to use
 
-        #create charge
-        charge_hash=FactoryGirl.build(:card_charge, source_id:card['id'],order_id: card['id'])
-        charge=@charges.create(charge_hash,customer['id'])
+      #create new customer
+      customer_hash=FactoryGirl.build(:customer)
+      customer=@customers.create(customer_hash)
 
-        payout_hash= FactoryGirl.build(:payout_card, destination_id: card['id'],amount: 400)
+      #create new customer card
+      card_hash=FactoryGirl.build(:valid_card)
+      card=@cards.create(card_hash, customer['id'])
 
-        payout=@payouts.create(payout_hash,customer['id'])
-        expect(  @payouts.get(  payout['id'],customer['id'] )['amount']).to be_within(0.1).of(400)
+      #create charge
+      charge_hash=FactoryGirl.build(:card_charge, source_id: card['id'], order_id: card['id'])
+      charge=@charges.create(charge_hash, customer['id'])
 
-        #cleanup
-        @cards.delete_all(customer['id'])
-        @bank_accounts.delete_all(customer['id'])
+      payout_hash=FactoryGirl.build(:payout_card, destination_id: card['id'], amount: 400)
 
-      end
+      payout=@payouts.create(payout_hash, customer['id'])
+      expect(@payouts.get(payout['id'], customer['id'])['amount']).to be_within(0.1).of(400)
 
+      #cleanup
+      @cards.delete_all(customer['id'])
+      @bank_accounts.delete_all(customer['id'])
 
+    end
 
-    it 'creates a customer  payout using a bank account' do
+    it 'creates a customer payout using a bank account' do
 
       #create new customer
-      customer_hash= FactoryGirl.build(:customer)
+      customer_hash=FactoryGirl.build(:customer)
       customer=@customers.create(customer_hash)
 
       #create new customer card
@@ -79,36 +89,34 @@ describe Payouts do
       account=@bank_accounts.create(account_hash, customer['id'])
 
       #create charge
-      charge_hash=FactoryGirl.build(:card_charge, source_id:card['id'],order_id: card['id'])
-      charge=@charges.create(charge_hash,customer['id'])
+      charge_hash=FactoryGirl.build(:card_charge, source_id: card['id'], order_id: card['id'])
+      charge=@charges.create(charge_hash, customer['id'])
 
-      payout_hash= FactoryGirl.build(:payout_card, destination_id: account['id'],amount: 400)
+      payout_hash=FactoryGirl.build(:payout_card, destination_id: account['id'], amount: 400)
 
-      payout=@payouts.create(payout_hash,customer['id'])
-      expect(  @payouts.get(  payout['id'],customer['id'] )['amount']).to be_within(0.1).of(400)
+      payout=@payouts.create(payout_hash, customer['id'])
+      expect(@payouts.get(payout['id'], customer['id'])['amount']).to be_within(0.1).of(400)
 
       #cleanup
       @cards.delete_all(customer['id'])
       @bank_accounts.delete_all(customer['id'])
-     # @customers.delete_all
+      # @customers.delete_all
     end
-
-
-
   end
 
   describe '.get' do
 
     it 'gets a merchant payout' do
 
-      payout_hash= FactoryGirl.build(:payout_card, destination_id: 'b4ravkgvpir9izop1faz',amount: 10)
+      pending
+      payout_hash= FactoryGirl.build(:payout_card, destination_id: 'bxz8ixftukkkjnrnypzb', amount: 10)
 
       payout=@payouts.create(payout_hash)
       expect(@payouts.get(payout['id'])['amount']).to be_within(0.1).of(10)
 
     end
 
-    it 'gets  a customer payout' do
+    it 'gets a customer payout' do
       #create new customer
       customer_hash= FactoryGirl.build(:customer)
       customer=@customers.create(customer_hash)
@@ -118,14 +126,14 @@ describe Payouts do
       card=@cards.create(card_hash, customer['id'])
 
       #create charge
-      charge_hash=FactoryGirl.build(:card_charge, source_id:card['id'],order_id: card['id'])
-      charge=@charges.create(charge_hash,customer['id'])
+      charge_hash=FactoryGirl.build(:card_charge, source_id: card['id'], order_id: card['id'])
+      charge=@charges.create(charge_hash, customer['id'])
 
-      payout_hash= FactoryGirl.build(:payout_card, destination_id: card['id'],amount: 40)
+      payout_hash= FactoryGirl.build(:payout_card, destination_id: card['id'], amount: 40)
 
-      payout=@payouts.create(payout_hash,customer['id'])
+      payout=@payouts.create(payout_hash, customer['id'])
 
-      res=@payouts.get( payout['id'],customer['id'] )
+      res=@payouts.get(payout['id'], customer['id'])
       expect(res['amount']).to be_within(0.1).of(40)
 
       #cleanup
@@ -133,15 +141,14 @@ describe Payouts do
       @bank_accounts.delete_all(customer['id'])
       #@customers.delete_all
     end
-
-
   end
 
   describe '.all' do
 
     it 'all merchant payouts' do
-     expect(@payouts.all.size).to be_a Integer
-     expect(@payouts.all.last['transaction_type']) .to match 'payout'
+      pending
+      expect(@payouts.all.size).to be_a Integer
+      expect(@payouts.all.last['transaction_type']).to match 'payout'
     end
 
     it 'all customer payouts' do
@@ -154,18 +161,17 @@ describe Payouts do
       card=@cards.create(card_hash, customer['id'])
 
       #create charge
-      charge_hash=FactoryGirl.build(:card_charge, source_id:card['id'],order_id: card['id'])
-      charge=@charges.create(charge_hash,customer['id'])
+      charge_hash=FactoryGirl.build(:card_charge, source_id: card['id'], order_id: card['id'])
+      charge=@charges.create(charge_hash, customer['id'])
 
-      payout_hash= FactoryGirl.build(:payout_card, destination_id: card['id'],amount: 40)
+      payout_hash= FactoryGirl.build(:payout_card, destination_id: card['id'], amount: 40)
 
-      payout=@payouts.create(payout_hash,customer['id'])
+      payout=@payouts.create(payout_hash, customer['id'])
 
-      res=@payouts.get( payout['id'],customer['id'] )
+      res=@payouts.get(payout['id'], customer['id'])
       expect(res['amount']).to be_within(0.1).of(40)
 
-
-       expect(@payouts.all(customer['id']).last['transaction_type']).to match 'payout'
+      expect(@payouts.all(customer['id']).last['transaction_type']).to match 'payout'
 
       #cleanup
       @cards.delete_all(customer['id'])
@@ -175,23 +181,54 @@ describe Payouts do
   end
 
 
+  describe '.list' do
+
+    it 'list payouts given the filter' do
+
+      #create new customer
+      customer_hash= FactoryGirl.build(:customer)
+      customer=@customers.create(customer_hash)
+
+      #create new customer card
+      card_hash=FactoryGirl.build(:valid_card)
+      card=@cards.create(card_hash, customer['id'])
+
+      #create charge
+      charge_hash=FactoryGirl.build(:card_charge, source_id: card['id'], order_id: card['id'])
+      charge=@charges.create(charge_hash, customer['id'])
+
+      payout_hash= FactoryGirl.build(:payout_card, destination_id: card['id'], amount: 40)
+
+      payout1=@payouts.create(payout_hash, customer['id'])
+      payout2=@payouts.create(payout_hash, customer['id'])
+
+      search_params = OpenpayUtils::SearchParams.new
+      search_params.limit = 1
+
+      expect(@payouts.all(customer['id']).size).to eq 2
+      expect(@payouts.list(search_params, customer['id']).size).to eq 1
+
+      #cleanup
+      @cards.delete_all(customer['id'])
+      @bank_accounts.delete_all(customer['id'])
+
+    end
+
+  end
+
   describe '.each' do
 
     it 'iterates over all merchant payouts' do
-
       @payouts.each do |pay|
-        expect(@payouts.get(pay['id'])['transaction_type'] ).to match 'payout'
+        expect(@payouts.get(pay['id'])['transaction_type']).to match 'payout'
       end
-
     end
 
     it 'iterates over a given customer payouts' do
-       a_customer=@customers.all.last
-       @payouts.each(a_customer['id']) do |pay|
-          expect(@payouts.get(pay['id'],a_customer['id'])['transaction_type'] ).to match 'payout'
-       end
+      a_customer=@customers.all.last
+      @payouts.each(a_customer['id']) do |pay|
+        expect(@payouts.get(pay['id'], a_customer['id'])['transaction_type']).to match 'payout'
+      end
     end
   end
-
-
-end
+end