openpay 1.0.3 → 1.0.4

data/lib/openpay/open_pay_resource_factory.rb

@@ -3,7 +3,7 @@ class OpenPayResourceFactory
     begin
       Object.const_get(resource.capitalize).new(merchant_id,private_key,production)
     rescue NameError
-         raise OpenpayException.new("Invalid resource name:#{resource}",false)
+      raise OpenpayException.new("Invalid resource name:#{resource}",false)
     end
   end
 end

data/lib/openpay/openpay_api.rb

@@ -9,31 +9,26 @@ require 'errors/openpay_exception'
 LOG= Logger.new(STDOUT)
 #change to Logger::DEBUG if need trace information
 #due the nature of the information, we recommend to never use a log file when in debug
-LOG.level=Logger::ERROR
+LOG.level=Logger::FATAL
 
 class OpenpayApi
   #API Endpoints
   API_DEV='https://sandbox-api.openpay.mx/v1/'
   API_PROD='https://api.openpay.mx/v1/'
 
-  #by default the testing environment is used
-  def initialize(merchant_id, private_key,production=false)
+  #by default testing environment is used
+  def initialize(merchant_id, private_key, production=false)
     @merchant_id=merchant_id
     @private_key=private_key
     @production=production
   end
 
-
-  # @return [nil]
   def create(resource)
-    klass=OpenPayResourceFactory::create(resource, @merchant_id,@private_key,@production)
-    #attach api hook to be able to refere to same API instance from created resources
-    #TODO we may move it to the initialize method
+    klass=OpenPayResourceFactory::create(resource, @merchant_id, @private_key, @production)
     klass.api_hook=self
     klass
   end
 
-
   def OpenpayApi::base_url(production)
     if production
       API_PROD
@@ -42,8 +37,7 @@ class OpenpayApi
     end
   end
 
-
-  def  env
+  def env
     if @production
       :production
     else
@@ -51,8 +45,4 @@ class OpenpayApi
     end
   end
 
-
-
-
-
-end
+end

data/lib/openpay/payouts.rb

@@ -1,19 +1,13 @@
 require 'open_pay_resource'
 
-
-
 class Payouts < OpenPayResource
 
-
-
-
-
   def all(customer_id=nil)
     if customer_id
       customers=@api_hook.create(:customers)
       customers.all_payouts(customer_id)
     else
-      super   ''
+      super ''
     end
   end
 
@@ -26,24 +20,19 @@ class Payouts < OpenPayResource
     end
   end
 
-
   def each(customer_id=nil)
     if customer_id
       customers=@api_hook.create(:customers)
       customers.each_payout(customer_id)  do |cust|
-         yield cust
+        yield cust
       end
     else
       all.each do |cust|
         yield cust
-     end
-  end
-
+      end
+    end
   end
 
-
-
-
   def create(payout, customer_id=nil)
     if customer_id
       customers=@api_hook.create(:customers)
@@ -53,7 +42,14 @@ class Payouts < OpenPayResource
     end
   end
 
+  def list(search_params, customer_id=nil)
+    if customer_id
+      customers=@api_hook.create(:customers)
+      customers.list_payouts(customer_id, search_params)
+    else
+      super search_params
+    end
+  end
 
 
-
-end
+end

data/lib/openpay/plans.rb

@@ -10,14 +10,8 @@ class Plans  < OpenPayResource
     get("#{plan_id}/subscriptions")
   end
 
-
   def all_subscriptions(plan_id)
     get("#{plan_id}/subscriptions")
   end
 
-
-  def each
-  end
-
-
-end
+end

data/lib/openpay/subscriptions.rb

@@ -1,37 +1,27 @@
 require 'open_pay_resource'
 
-class Subscriptions  < OpenPayResource
+class Subscriptions < OpenPayResource
 
-
-
-  def create(subscription,plan_id)
+  def create(subscription, customer_id)
     customers=@api_hook.create(:customers)
-    customers.create_subscription(subscription,plan_id)
+    customers.create_subscription(subscription, customer_id)
   end
 
+  def delete(subscription_id, customer_id)
+    customers=@api_hook.create(:customers)
+    customers.delete_subscription(customer_id, subscription_id)
+  end
 
-def delete(subscription_id,customer_id)
-  customers=@api_hook.create(:customers)
-  customers.delete_subscription(customer_id, subscription_id)
-end
-
-
-  def get(subscription_id,customer_id)
-
+  def get(subscription_id, customer_id)
     customers=@api_hook.create(:customers)
     customers.get_subscription(customer_id, subscription_id)
-
   end
 
-
   def all(customer_id)
-
     customers=@api_hook.create(:customers)
     customers.all_subscriptions(customer_id)
-
   end
 
-
   def each(customer_id)
     customers=@api_hook.create(:customers)
     customers.each_subscription(customer_id) do |c|
@@ -39,20 +29,22 @@ end
     end
   end
 
+  def list(search_params,customer_id=nil)
+    if customer_id
+      customers=@api_hook.create(:customers)
+      customers.list_subscriptions(customer_id,search_params)
+    else
+      super search_params
+    end
+  end
+
+  def update(subscription_id,customer_id,params)
+    customers=@api_hook.create(:customers)
+    customers.update_subscription(subscription_id,customer_id,params)
+  end
 
   def delete_all(customer_id)
     customers=@api_hook.create(:customers)
     customers.delete_all_subscriptions(customer_id)
-
   end
-
-
-
-
-
-
-
-
-
-
 end

data/lib/openpay/transfers.rb

@@ -1,13 +1,10 @@
 require 'open_pay_resource'
 
-class  Transfers < OpenPayResource
-
-
-  def create(transfer,customer_id)
-
-      customers=@api_hook.create(:customers)
-      customers.create_transfer(customer_id,transfer)
+class Transfers < OpenPayResource
 
+  def create(transfer, customer_id)
+    customers=@api_hook.create(:customers)
+    customers.create_transfer(customer_id, transfer)
   end
 
   def all(customer_id)
@@ -15,27 +12,26 @@ class  Transfers < OpenPayResource
     customers.all_transfers(customer_id)
   end
 
-
-
-  def get(transfer,customer_id)
-
+  def get(transfer, customer_id)
     customers=@api_hook.create(:customers)
-    customers.get_transfer(customer_id,transfer)
-
+    customers.get_transfer(customer_id, transfer)
   end
 
-
   def each(customer_id)
     customers=@api_hook.create(:customers)
     customers.each_transfer(customer_id) do |tran|
       yield tran
     end
-
   end
 
-
-
-
+  def list(search_params, customer_id=nil)
+    if customer_id
+      customers=@api_hook.create(:customers)
+      customers.list_transfers(customer_id, search_params)
+    else
+      super search_params
+    end
+  end
 
 end
 

data/lib/openpay/utils/search_params.rb

@@ -0,0 +1,20 @@
+module OpenpayUtils
+
+  class SearchParams < OpenStruct
+
+    #"?creation[gte]=2013-11-01&limit=2&amount[lte]=100"
+    def to_str
+      filter = '?'
+      self.marshal_dump.each do |attribute, value|
+        if attribute =~ /(\w+)_(gte|lte)/
+          attribute = "#{$1}[#{$2}]"
+        end
+        filter << "#{attribute}=#{value}&"
+      end
+      filter.sub(/\&$/, '')
+    end
+
+    alias :to_s :to_str
+
+  end
+end

data/lib/version.rb

@@ -1,6 +1,5 @@
 module Openpay
-
   # Dec 31 2014, 6:00 PM Qro Local time.
   # 97 test cases passed / 220.232 secs
-  VERSION = '1.0.3'
+  VERSION = '1.0.4'
 end

data/openpay.gemspec

@@ -4,7 +4,6 @@ $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 
 require 'version'
 
-
 Gem::Specification.new do |spec|
   spec.name          = "openpay"
   spec.version       = Openpay::VERSION
@@ -23,16 +22,9 @@ Gem::Specification.new do |spec|
   spec.add_runtime_dependency 'rest-client'  , '~>1.6.7'
   spec.add_runtime_dependency 'json'
 
-
-
   spec.add_development_dependency 'bundler', '~> 1.3'
   spec.add_development_dependency 'rake'
   spec.add_development_dependency 'json_spec'
-  spec.add_development_dependency 'rspec'
-  spec.add_development_dependency 'factory_girl'  ,  '4.2.0'
   spec.post_install_message = 'Thanks for installing openpay. Enjoy !'
 
-
-
-
 end

data/test/Factories.rb

@@ -3,12 +3,12 @@ require 'factory_girl'
 
 FactoryGirl.define do
 
-  factory :customer, class:Hash do
+  factory :customer, class: Hash do
     name 'Ronnie'
     last_name 'Bermejo'
     email 'ronnie.bermejo.mx@gmail.com'
     phone_number '0180012345'
-    address {{
+    address { {
         postal_code: '76190',
         state: 'QRO',
         line1: 'LINE1',
@@ -16,48 +16,45 @@ FactoryGirl.define do
         line3: 'LINE3',
         country_code: 'MX',
         city: 'Queretaro',
-     }}
+    } }
 
     initialize_with { attributes }
 
   end
 
+  factory :valid_card, class: Hash do
 
-
-  factory :valid_card, class:Hash do
-
-        bank_name  'visa'
-        holder_name 'Vicente Olmos'
-        expiration_month '09'
-        card_number '4111111111111111'
-        expiration_year '14'
-        bank_code 'bmx'
-        cvv2  '111'
-       address {{
-           postal_code: '76190',
-           state: 'QRO',
-           line1: 'LINE1',
-           line2: 'LINE2',
-           line3: 'LINE3',
-           country_code: 'MX',
-           city: 'Queretaro',
-       }}
+    bank_name 'visa'
+    holder_name 'Vicente Olmos'
+    expiration_month '09'
+    card_number '4111111111111111'
+    expiration_year '14'
+    bank_code 'bmx'
+    cvv2 '111'
+    address { {
+        postal_code: '76190',
+        state: 'QRO',
+        line1: 'LINE1',
+        line2: 'LINE2',
+        line3: 'LINE3',
+        country_code: 'MX',
+        city: 'Queretaro',
+    } }
 
     initialize_with { attributes }
 
   end
 
+  factory :valid_card2, class: Hash do
 
-  factory :valid_card2, class:Hash do
-
-    bank_name  'visa'
+    bank_name 'visa'
     holder_name 'Alma Olmos'
     expiration_month '09'
     card_number '4242424242424242'
     expiration_year '14'
     bank_code 'bmx'
-    cvv2  '111'
-    address {{
+    cvv2 '111'
+    address { {
         postal_code: '76190',
         state: 'QRO',
         line1: 'LINE1',
@@ -65,24 +62,22 @@ FactoryGirl.define do
         line3: 'LINE3',
         country_code: 'MX',
         city: 'Queretaro',
-    }}
+    } }
 
     initialize_with { attributes }
 
   end
 
+  factory :only_deposit, class: Hash do
 
-
-  factory :only_deposit, class:Hash do
-
-    bank_name  'visa'
+    bank_name 'visa'
     holder_name 'Alma Olmos'
     expiration_month '09'
     card_number '4444444444444448'
     expiration_year '14'
     bank_code 'bmx'
-    cvv2  '111'
-    address {{
+    cvv2 '111'
+    address { {
         postal_code: '76190',
         state: 'QRO',
         line1: 'LINE1',
@@ -90,23 +85,22 @@ FactoryGirl.define do
         line3: 'LINE3',
         country_code: 'MX',
         city: 'Queretaro',
-    }}
+    } }
 
     initialize_with { attributes }
 
   end
 
+  factory :expired_card, class: Hash do
 
-  factory :expired_card, class:Hash do
-
-    bank_name  'visa'
+    bank_name 'visa'
     holder_name 'Vicente Olmos'
     expiration_month '09'
     card_number '4000000000000069'
     expiration_year '14'
     bank_code 'bmx'
-    cvv2  '111'
-    address {{
+    cvv2 '111'
+    address { {
         postal_code: '76190',
         state: 'QRO',
         line1: 'LINE1',
@@ -114,145 +108,105 @@ FactoryGirl.define do
         line3: 'LINE3',
         country_code: 'MX',
         city: 'Queretaro',
-    }}
+    } }
 
     initialize_with { attributes }
 
   end
 
+  factory :bank_account, class: Hash do
 
+    holder_name 'Juan Perez'
+    self.alias 'Cuenta principal'
+    clabe '032180000118359719'
 
-  factory :bank_account, class:Hash do
-
-        holder_name  'Juan Perez'
-        self.alias  'Cuenta principal'
-        clabe  '032180000118359719'
-
-        initialize_with { attributes }
+    initialize_with { attributes }
 
   end
 
+  factory :card_charge, class: Hash do
 
+    amount "1000"
+    description "Cargo inicial a tarjeta"
+    source_id "string"
+    method "card"
+    order_id 'required'
 
-  factory :card_charge, class:Hash do
-
-
-        amount  "1000"
-        description "Cargo inicial a tarjeta"
-        source_id "string"
-        method  "card"
-        order_id 'required'
-
-       initialize_with { attributes }
-
+    initialize_with { attributes }
 
   end
 
-  factory :bank_charge, class:Hash do
+  factory :bank_charge, class: Hash do
 
-    amount  "10000"
+    amount "10000"
     description "Cargo con banco"
-    source_id "string"
     order_id 'required'
-    method  "bank_account"
-
+    method "bank_account"
 
     initialize_with { attributes }
 
-
   end
 
-
-
-  factory :refund_description, class:Hash do
+  factory :refund_description, class: Hash do
     description 'A peticion del cliente'
     initialize_with { attributes }
 
   end
 
-
-  factory :fee, class:Hash do
-        customer_id  'dvocf97jd20es3tw5laz'
-        amount  '12.50'
-        description  'Cobro de Comision'
-        initialize_with { attributes }
-
+  factory :fee, class: Hash do
+    customer_id 'dvocf97jd20es3tw5laz'
+    amount '12.50'
+    description 'Cobro de Comision'
+    initialize_with { attributes }
   end
 
+  factory :payout_card, class: Hash do
 
+    method 'card'
+    destination_id '4444444444444448'
+    amount '2'
+    description 'Retiro de saldo semanal'
 
-  factory :payout_card, class:Hash do
-
-        method 'card'
-        destination_id '4444444444444448'
-        amount '2'
-        description 'Retiro de saldo semanal'
-
-        initialize_with { attributes }
-
+    initialize_with { attributes }
 
   end
 
+  factory :payout_bank_account, class: Hash do
 
-  factory :payout_bank_account, class:Hash do
-
-    method  'bank_account'
+    method 'bank_account'
     amount '1000'
     destination_id 'required'
     description 'Retiro de saldo semanal'
 
     initialize_with { attributes }
 
-
   end
 
+  factory :plan, class: Hash do
 
-
-
-  factory :plan, class:Hash do
-
-        amount '150.00'
-        status_after_retry 'cancelled'
-        retry_times  2
-        name 'Curso de ingles'
-        repeat_unit  'week'
-        trial_days 30
-        repeat_every 1
-         initialize_with { attributes }
-
+    amount '150.00'
+    status_after_retry 'cancelled'
+    retry_times 2
+    name 'Curso de ingles'
+    repeat_unit 'week'
+    trial_days 30
+    repeat_every 1
+    initialize_with { attributes }
 
   end
 
-
-
-  factory :transfer, class:Hash do
-
-        customer_id  'required'
-        amount 12.50
-        description 'Transferencia entre cuentas'
-        initialize_with { attributes }
-
-
+  factory :transfer, class: Hash do
+    customer_id 'required'
+    amount 12.50
+    description 'Transferencia entre cuentas'
+    initialize_with { attributes }
   end
 
-
-  factory :subscription, class:Hash do
-
-    trial_days  30
+  factory :subscription, class: Hash do
+    trial_days 30
     card_id 'required'
     plan_id 'required'
     initialize_with { attributes }
-
-
-
-
-
-
   end
 
-
-
-
-
-
 end