openpay 1.0.3 → 1.0.4

data/test/spec/bankaccounts_spec.rb

@@ -1,24 +1,25 @@
 require_relative '../spec_helper'
 
 
-describe  Bankaccounts do
+describe Bankaccounts do
 
- #bankaccounts for merchant cannot be created using the api
+  #bankaccounts for merchant cannot be created using the api
   #the merchant bank account should be created using the Openpay dashboard
   before(:all) do
 
     @merchant_id='mywvupjjs9xdnryxtplq'
     @private_key='sk_92b25d3baec149e6b428d81abfe37006'
 
-    @openpay=OpenpayApi.new(@merchant_id,@private_key)
+    @openpay=OpenpayApi.new(@merchant_id, @private_key)
     @bank_accounts=@openpay.create(:bankaccounts)
     @customers=@openpay.create(:customers)
 
   end
 
-
-  after(:all) do
-    @customers.delete_all
+  it 'has all required methods' do
+    %w(all each create get list delete).each do |meth|
+      expect(@bank_accounts).to respond_to(meth)
+    end
   end
 
   describe '.create' do
@@ -28,19 +29,18 @@ describe  Bankaccounts do
       customer=@customers.create(customer_hash)
 
       account_hash=FactoryGirl.build(:bank_account)
-      bank=@bank_accounts.create(account_hash,customer['id'])
+      bank=@bank_accounts.create(account_hash, customer['id'])
 
-      bank_account=@bank_accounts.get(customer['id'],bank['id'])
+      bank_account=@bank_accounts.get(customer['id'], bank['id'])
       expect(bank_account['alias']).to match 'Cuenta principal'
 
-      @bank_accounts.delete(customer['id'],bank['id'])
+      @bank_accounts.delete(customer['id'], bank['id'])
+      @customers.delete(customer['id'])
 
     end
 
   end
 
-
-
   describe '.get' do
 
     it 'get a given bank account for a given customer' do
@@ -49,65 +49,76 @@ describe  Bankaccounts do
       customer=@customers.create(customer_hash)
 
       account_hash=FactoryGirl.build(:bank_account)
-      bank=@bank_accounts.create(account_hash,customer['id'])
+      bank=@bank_accounts.create(account_hash, customer['id'])
 
-      bank_account=@bank_accounts.get(customer['id'],bank['id'])
+      bank_account=@bank_accounts.get(customer['id'], bank['id'])
       expect(bank_account['alias']).to match 'Cuenta principal'
-      @bank_accounts.delete(customer['id'],bank['id'])
+      @bank_accounts.delete(customer['id'], bank['id'])
+      @customers.delete(customer['id'])
 
     end
 
   end
 
-
-
   describe '.each' do
 
-
     it 'iterator for  all given customer bank accounts' do
 
       customer_hash= FactoryGirl.build(:customer)
       customer=@customers.create(customer_hash)
 
       account_hash=FactoryGirl.build(:bank_account)
-      bank=@bank_accounts.create(account_hash,customer['id'])
+      bank=@bank_accounts.create(account_hash, customer['id'])
 
       @bank_accounts.each(customer['id']) do |bank_account|
-          expect( bank_account['alias']).to match 'Cuenta principal'
+        expect(bank_account['alias']).to match 'Cuenta principal'
       end
 
-      @bank_accounts.delete(customer['id'],bank['id'])
+      @bank_accounts.delete(customer['id'], bank['id'])
       @customers.delete(customer['id'])
 
     end
 
+  end
 
-end
+  describe '.list' do
 
+    it 'list the bank accounts using a given filter' do
 
-  describe '.list' do
+      customer_hash= FactoryGirl.build(:customer)
+      customer=@customers.create(customer_hash)
+      expect(@bank_accounts.all(customer['id']).size).to be 0
 
-    it 'should list the bank accounts using a given filter' do
-       pending
-    end
-  end
+      account_hash=FactoryGirl.build(:bank_account)
+      bank=@bank_accounts.create(account_hash, customer['id'])
+      expect(@bank_accounts.all(customer['id']).size).to be 1
 
+      search_params = OpenpayUtils::SearchParams.new
+      search_params.limit = 1
 
+      expect(@bank_accounts.all(customer['id']).size).to eq 1
+      expect(@bank_accounts.list(search_params , customer['id']).size).to eq 1
+
+      @bank_accounts.delete(customer['id'], bank['id'])
+      @customers.delete(customer['id'])
+
+    end
+  end
 
   describe '.all' do
 
-    it 'list all bank accounts for a given customer' do
+    it 'all bank accounts for a given customer' do
 
-         customer_hash= FactoryGirl.build(:customer)
-         customer=@customers.create(customer_hash)
-         expect(@bank_accounts.all(customer['id']).size).to be 0
+      customer_hash= FactoryGirl.build(:customer)
+      customer=@customers.create(customer_hash)
+      expect(@bank_accounts.all(customer['id']).size).to be 0
 
-         account_hash=FactoryGirl.build(:bank_account)
-         bank=@bank_accounts.create(account_hash,customer['id'])
-         expect(@bank_accounts.all(customer['id']).size).to be 1
+      account_hash=FactoryGirl.build(:bank_account)
+      bank=@bank_accounts.create(account_hash, customer['id'])
+      expect(@bank_accounts.all(customer['id']).size).to be 1
 
-         @bank_accounts.delete(customer['id'],bank['id'])
-         @customers.delete(customer['id'])
+      @bank_accounts.delete(customer['id'], bank['id'])
+      @customers.delete(customer['id'])
 
     end
 
@@ -117,33 +128,29 @@ end
 
   end
 
-
   describe '.delete' do
 
-    it 'deletes  a given  bank account' do
+    it 'deletes a given bank account' do
 
       customer_hash= FactoryGirl.build(:customer)
       customer=@customers.create(customer_hash)
       expect(@bank_accounts.all(customer['id']).size).to be 0
 
-
       account_hash=FactoryGirl.build(:bank_account)
-      bank=@bank_accounts.create(account_hash,customer['id'])
+      bank=@bank_accounts.create(account_hash, customer['id'])
       expect(@bank_accounts.all(customer['id']).size).to be 1
 
-      @bank_accounts.delete(customer['id'],bank['id'])
+      @bank_accounts.delete(customer['id'], bank['id'])
       @customers.delete(customer['id'])
 
     end
 
-
-    it 'fails to delete  a non existing  bank accounts' do
-         expect { @customers.delete('1111') }.to raise_exception  OpenpayTransactionException
+    it 'fails to delete a non existing bank accounts' do
+      expect { @customers.delete('1111') }.to raise_exception OpenpayTransactionException
     end
 
   end
 
-
   describe '.delete_all' do
 
     it 'deletes all bank accounts' do
@@ -153,34 +160,21 @@ end
 
       account_hash=FactoryGirl.build(:bank_account)
 
-      @bank_accounts.create(account_hash,customer['id'])
+      @bank_accounts.create(account_hash, customer['id'])
       expect(@bank_accounts.all(customer['id']).size).to be 1
 
       @bank_accounts.delete_all(customer['id'])
       expect(@bank_accounts.all(customer['id']).size).to be 0
 
+      @customers.delete(customer['id'])
 
     end
 
     it 'fails to deletes all bank accounts when used on PROD' do
-
       @openpayprod=OpenpayApi.new(@merchant_id, @private_key, true)
       bank_accounts=@openpayprod.create(:bankaccounts)
-
-      expect { bank_accounts.delete_all('111111') }.to raise_exception   OpenpayException
-
-
+      expect { bank_accounts.delete_all('111111') }.to raise_exception OpenpayException
     end
 
   end
-
-
-
-
-
-
-
-
-
-
-end
+end

data/test/spec/cards_spec.rb

@@ -3,6 +3,8 @@ require_relative '../spec_helper'
 
 describe Cards do
 
+  # %w(create delete get list each all fail).each do |meth|
+  # end
 
   before(:all) do
 
@@ -15,17 +17,21 @@ describe Cards do
 
     @cards.delete_all
 
-
   end
 
   after(:all) do
     #each test should build and clean it's own mess.
   end
 
+  it 'has all required methods' do
+    %w(all each create get list delete).each do |meth|
+        expect(@cards).to respond_to(meth)
+    end
+  end
 
   describe '.create' do
 
-    it 'creates  merchant card' do
+    it 'creates merchant card' do
 
       #creates merchant card
       card_hash = FactoryGirl.build(:valid_card)
@@ -40,13 +46,11 @@ describe Cards do
       expect(card['holder_name']).to match(name)
       expect(card['card_number']).to match('1111')
 
-       #cleanup
+      #cleanup
       @cards.delete(card['id'])
 
-
     end
 
-
     it 'creates a customer card' do
 
       #creates a customer
@@ -61,7 +65,7 @@ describe Cards do
 
       id=cards['id']
 
-     #performs check
+      #performs check
       customer_cards=customers.all_cards(customer['id'])
       expect(customer_cards.size).to be 1
       expect(cards['holder_name']).to match 'Pepe'
@@ -74,10 +78,8 @@ describe Cards do
       @cards.delete(id, customer['id'])
       @customers.delete(customer['id'])
 
-
     end
 
-
     it 'fails when trying to create an existing merchant card' do
 
       #creates merchant card
@@ -92,8 +94,6 @@ describe Cards do
 
     end
 
-
-
     it 'fails when trying to create an existing customer card' do
 
       #creates a customer
@@ -106,18 +106,15 @@ describe Cards do
       card=@cards.create(card_hash, customer['id'])
       expect(card).to be_a(Hash)
 
-     #performs check
-      expect { @cards.create(card_hash,customer['id']) }.to raise_error(OpenpayTransactionException)
+      #performs check
+      expect { @cards.create(card_hash, customer['id']) }.to raise_error(OpenpayTransactionException)
 
       #cleanup
-      @cards.delete(card['id'],customer['id'])
+      @cards.delete(card['id'], customer['id'])
       @customers.delete(customer['id'])
 
-
     end
 
-
-
     it 'fails when using an expired card' do
       card_hash = FactoryGirl.build(:expired_card)
       #check
@@ -125,14 +122,13 @@ describe Cards do
       #extended check
       begin
         @cards.create(card_hash)
-      rescue OpenpayTransactionException =>   e
+      rescue OpenpayTransactionException => e
         expect(e.description).to match 'The card has expired'
         expect(e.error_code).to be 3002
       end
 
     end
 
-
     it 'fails when using a stolen card' do
       card_json = FactoryGirl.build(:valid_card, card_number: '4000000000000119')
       expect { @cards.create(card_json) }.to raise_error(OpenpayTransactionException)
@@ -140,7 +136,6 @@ describe Cards do
 
   end
 
-
   describe '.each' do
 
     it 'iterates over all existing merchant cards' do
@@ -149,11 +144,8 @@ describe Cards do
       end
     end
 
-
     it 'iterates over all existing customer cards' do
 
-
-
       #creates a customer
       card_hash = FactoryGirl.build(:valid_card, holder_name: 'Pepe')
       customers=@openpay.create(:customers)
@@ -168,26 +160,16 @@ describe Cards do
         expect(c['expiration_year']).to match '14'
       end
 
-
       #cleanup
-      @cards.delete(card['id'],customer['id'])
+      @cards.delete(card['id'], customer['id'])
       @customers.delete(customer['id'])
 
-
-
-
     end
 
-
-
-
-
   end
 
-
   describe '.delete' do
 
-
     it 'deletes a merchant card' do
 
       #creates merchant card
@@ -199,20 +181,15 @@ describe Cards do
       name='Vicente Olmos'
 
       #perform check
-
       card=@cards.delete(id)
       expect { @cards.get(id) }.to raise_exception(OpenpayTransactionException)
 
-
     end
 
-
-
-     it 'fails to deletes a non existing card' do
+    it 'fails to deletes a non existing card' do
       expect { @cards.delete('1111111') }.to raise_exception(OpenpayTransactionException)
     end
 
-
     it 'deletes a customer card' do
 
       #create customer
@@ -228,22 +205,18 @@ describe Cards do
       @cards.delete(card['id'], customer['id'])
 
       #perform check
-     expect { @cards.get(card['id'],customer['id'])}.to raise_exception(OpenpayTransactionException)
+      expect { @cards.get(card['id'], customer['id']) }.to raise_exception(OpenpayTransactionException)
 
     end
 
-
     it 'fails to deletes a non existing  customer card' do
       expect { @cards.delete('1111111', '1111') }.to raise_exception(OpenpayTransactionException)
     end
 
-
   end
 
-
   describe '.get' do
 
-
     it ' gets an existing  merchant card' do
 
       #create merchant card
@@ -263,13 +236,11 @@ describe Cards do
 
     end
 
-
     it 'fails when getting a non existing card' do
       expect { @cards.get('11111') }.to raise_exception(OpenpayTransactionException)
     end
 
-
-    it ' gets an existing  customer card' do
+    it ' gets an existing customer card' do
 
       #create customer
       customer_hash = FactoryGirl.build(:customer)
@@ -293,18 +264,15 @@ describe Cards do
 
     end
 
-
     it 'fails when getting a non existing customer card' do
       expect { @cards.get('11111', '1111') }.to raise_exception(OpenpayTransactionException)
     end
 
-
   end
 
-
   describe '.all' do
 
-    it 'list all merchant cards' do
+    it 'all merchant cards' do
 
       #check initial state
       expect(@cards.all.size).to be 0
@@ -322,9 +290,7 @@ describe Cards do
 
     end
 
-
-    it 'list all customer cards' do
-
+    it 'all customer cards' do
 
       #create customer
       customer_hash = FactoryGirl.build(:customer)
@@ -346,34 +312,56 @@ describe Cards do
 
     end
 
-
-    it 'list cards for a non existing  customer' do
+    it 'cards for a non existing  customer' do
       expect { @cards.all('111111') }.to raise_exception OpenpayTransactionException
     end
 
-
   end
 
-
   describe '.list' do
 
     it 'list the merchant cards using a filter' do
 
-      pending
-      #creation[gte]=yyyy-mm-dd
-      #creation[lte]=yyyy-mm-dd
-      #offset=0&
-      #limit=10
-      # @cards.list('2000-01-01','2000-01-01',0,10)
+      #create merchant card
+      card_hash = FactoryGirl.build(:valid_card)
+      card1 = @cards.create(card_hash)
 
+      card_hash = FactoryGirl.build(:valid_card2)
+      card2 = @cards.create(card_hash)
 
+      search_params = OpenpayUtils::SearchParams.new
+      search_params.limit = 1
+      expect(@cards.list(search_params).size).to eq 1
+      @cards.delete_all
     end
 
-
     it 'list the customer cards using a filter' do
-      pending
-    end
 
+      #create customer
+      customer_hash = FactoryGirl.build(:customer)
+      customer = @customers.create(customer_hash)
+
+      #creates card
+      bank_name ='Banamex'
+      card_hash = FactoryGirl.build(:valid_card)
+      card = @cards.create(card_hash, customer['id'])
+      id = card['id']
+
+      #creates card 2
+      bank_name = 'Bancomer'
+      card_hash = FactoryGirl.build(:valid_card2)
+      card = @cards.create(card_hash, customer['id'])
+      id = card['id']
+
+      search_params = OpenpayUtils::SearchParams.new
+      search_params.limit = 1
+
+      expect(@cards.all(customer['id']).size).to eq 2
+      expect(@cards.list(search_params , customer['id']).size).to eq 1
+
+      @cards.delete_all(customer['id'])
+
+    end
 
   end
 
@@ -388,7 +376,6 @@ describe Cards do
 
     end
 
-
     it 'deletes all existing  merchant cards' do
 
       #create merchant card
@@ -399,7 +386,6 @@ describe Cards do
       card2_json = FactoryGirl.build(:valid_card2).to_json
       @cards.create(card2_json)
 
-
       #perform check
       expect(@cards.all.size).to be 2
 
@@ -409,12 +395,10 @@ describe Cards do
       #perform check
       expect(@cards.all.size).to be 0
 
-
     end
 
     it 'deletes all existing cards for a given customer' do
 
-
       #creates customer
       customer_hash = FactoryGirl.build(:customer)
       customer=@customers.create(customer_hash)
@@ -435,12 +419,8 @@ describe Cards do
       #check
       expect(@cards.all(customer['id']).size).to be 0
 
-
-
     end
 
-
   end
 
-
-end
+end