openpay 1.0.3 → 1.0.4

data/test/spec/charges_spec.rb

@@ -2,9 +2,6 @@ require_relative '../spec_helper'
 
 describe Charges do
 
-
-
-
   before(:all) do
 
     @merchant_id='mywvupjjs9xdnryxtplq'
@@ -17,28 +14,24 @@ describe Charges do
     @cards=@openpay.create(:cards)
     @bank_accounts=@openpay.create(:bankaccounts)
 
-
+    @cards.delete_all
 
   end
 
-
-  after(:all) do
-
+  it 'has all required methods' do
+    %w(all each create get list delete).each do |meth|
+      expect(@charges).to respond_to(meth)
+    end
   end
 
-
-
   describe '.create' do
 
     it 'creates a new merchant charge using the card method using a pre-stored card' do
 
-
       #create card
       card_hash=FactoryGirl.build(:valid_card)
       card=@cards.create(card_hash)
 
-
-
       #create charge attached to prev created card
       charge_hash=FactoryGirl.build(:card_charge, source_id: card['id'], order_id: card['id'],amount: 101)
       charge=@charges.create(charge_hash)
@@ -47,13 +40,11 @@ describe Charges do
       stored_charge=@charges.get(charge['id'])
       expect(stored_charge['amount']).to be_within(0.1).of(101)
 
-     #clean up
+      #clean up
       @cards.delete(card['id'])
 
-
     end
 
-
     it 'creates a new customer charge using the card method using a pre-stored card' do
 
       #create new customer
@@ -78,7 +69,6 @@ describe Charges do
 
     end
 
-
     it 'creates a new customer charge using the bank_account method' do
 
       #create new customer
@@ -90,7 +80,7 @@ describe Charges do
       account=@bank_accounts.create(account_hash,customer['id'])
 
       #create charge
-      charge_hash=FactoryGirl.build(:bank_charge, source_id:account['id'],order_id: account['id'])
+      charge_hash=FactoryGirl.build(:bank_charge, order_id: account['id'])
       charge=@charges.create(charge_hash,customer['id'])
 
       #perform check
@@ -103,18 +93,12 @@ describe Charges do
 
     end
 
-
-
   end
 
-
-
   describe '.get' do
 
-
     it 'gets a merchant charge'  do
 
-
       #create card
       card_hash=FactoryGirl.build(:valid_card)
       card=@cards.create(card_hash)
@@ -130,12 +114,9 @@ describe Charges do
       #clean up
       @cards.delete(card['id'])
 
-
-
     end
 
-
-    it  'gets a customer charge' do
+    it 'gets a customer charge' do
 
       #create new customer
       customer_hash= FactoryGirl.build(:customer)
@@ -159,46 +140,30 @@ describe Charges do
 
     end
 
-
-
-
-
   end
 
-
-
-
   describe '.all' do
 
-    it 'list all merchant charges' do
-
+    it 'all merchant charges' do
       #TODO test can be improved,  but since charges cannot be deleted it make this difficult
       expect(@charges.all.size).to be_a Integer
-
    end
 
-
-    it 'list all customer charges' do
+    it 'all customer charges' do
       #create new customer
       customer_hash= FactoryGirl.build(:customer)
       customer=@customers.create(customer_hash)
 
-
       expect(@charges.all(customer['id']).size).to be 0
       @customers.delete(customer['id'])
 
-
     end
 
   end
 
-
-
-
   describe '.capture' do
 
-
-    it 'captures  a merchant card charge'  do
+    it 'captures a merchant card charge'  do
 
       #create new customer
       customer_hash= FactoryGirl.build(:customer)
@@ -209,7 +174,7 @@ describe Charges do
       card=@cards.create(card_hash)
 
       #create merchant charge
-      charge_hash=FactoryGirl.build(:card_charge, source_id:card['id'],order_id: card['id'],amount: 4000,capture:'false')
+      charge_hash=FactoryGirl.build(:card_charge, source_id:card['id'],order_id: card['id'],amount: 4000, capture:'false')
       charge=@charges.create(charge_hash)
 
       #capture merchant charge
@@ -221,7 +186,7 @@ describe Charges do
 
     end
 
-    it 'captures  an customer card charge'  do
+    it 'captures a customer card charge' do
       #create new customer
       customer_hash= FactoryGirl.build(:customer)
       customer=@customers.create(customer_hash)
@@ -237,25 +202,73 @@ describe Charges do
       #capture customer charge
       @charges.capture(charge['id'],customer['id'])
 
+
       #clean up
       @cards.delete(card['id'],customer['id'])
       @customers.delete(customer['id'])
     end
 
+  end
 
+  describe '.confirm_capture' do
 
+    it 'confirms a capture on a merchant charge' do
 
-  end
+      #create new customer
+      customer_hash= FactoryGirl.build(:customer)
+      customer=@customers.create(customer_hash)
 
+      #create merchant card
+      card_hash=FactoryGirl.build(:valid_card)
+      card=@cards.create(card_hash)
 
+      #create merchant charge
+      charge_hash=FactoryGirl.build(:card_charge, source_id:card['id'],order_id: card['id'],amount: 4000, capture:'false')
+      charge=@charges.create(charge_hash)
 
+      confirm_capture_options = {  transaction_id: charge['id'], amount: 100  }
 
-  describe '.refund' do
+      #confirm capture
+      res = @charges.confirm_capture(confirm_capture_options)
+      expect(res['amount']).to eq 100
 
+      #clean up
+      @cards.delete(card['id'])
+      @customers.delete(customer['id'])
+
+    end
 
+    it 'confirms a capture on a customer charge' do
+
+      customer_hash= FactoryGirl.build(:customer)
+      customer=@customers.create(customer_hash)
+
+      #create customer card
+      card_hash=FactoryGirl.build(:valid_card)
+      card=@cards.create(card_hash,customer['id'])
+
+      #create charge
+      charge_hash=FactoryGirl.build(:card_charge, source_id:card['id'],order_id: card['id'],amount: 4000,capture:'false')
+      charge=@charges.create(charge_hash,customer['id'])
+
+      confirm_capture_options = { customer_id: customer['id'], transaction_id: charge['id'], amount: 100  }
+
+      #confirm capture
+      res = @charges.confirm_capture(confirm_capture_options)
+      expect(res['amount']).to eq 100
+
+      #clean up
+      @cards.delete(card['id'],customer['id'])
+      @customers.delete(customer['id'])
+
+    end
+
+  end
+
+  describe '.refund' do
 
     #Refunds apply only for card charges
-    it 'refunds  an existing merchant charge'  do
+    it 'refunds  an existing merchant charge' do
       #create card
       card_hash=FactoryGirl.build(:valid_card)
       card=@cards.create(card_hash)
@@ -271,16 +284,12 @@ describe Charges do
       @charges.refund(charge['id'],refund_description)
       expect(@charges.get(charge['id'])['refund']['amount'] ).to be_within(0.1).of(505)
 
-
       #clean up
       @cards.delete(card['id'])
 
     end
 
-
-
-
-    it 'refunds  an existing customer charge'  do
+    it 'refunds an existing customer charge' do
       #create new customer
       customer_hash= FactoryGirl.build(:customer)
       customer=@customers.create(customer_hash)
@@ -310,42 +319,47 @@ describe Charges do
 
   end
 
+  describe '.list' do
 
+    it 'list customer charges' do
 
+      #create new customer
+      customer_hash= FactoryGirl.build(:customer)
+      customer=@customers.create(customer_hash)
 
+      #create customer card
+      card_hash=FactoryGirl.build(:valid_card)
+      card=@cards.create(card_hash,customer['id'])
 
+      #create charge
+      charge_hash=FactoryGirl.build(:card_charge, source_id:card['id'],order_id: card['id'])
+      charge=@charges.create(charge_hash,customer['id'])
+      charge_hash=FactoryGirl.build(:card_charge, source_id:card['id'],order_id: card['id']+"1")
+      charge2=@charges.create(charge_hash,customer['id'])
 
+      #perform check
+      search_params = OpenpayUtils::SearchParams.new
+      search_params.limit = 1
+      expect(@charges.all(customer['id']).size).to eq 2
+      expect(@charges.list(search_params,customer['id']).size).to eq 1
 
+      #clean up
+      @cards.delete(card['id'],customer['id'])
+      @customers.delete(customer['id'])
 
-
-  describe '.list' do
-
-
-    it 'list merchant charges' do
-         pending
-    end
-
-
-
-    it 'list customer charges' do
-      pending
     end
 
-
   end
 
-
   describe '.each' do
 
     it 'iterates over merchant charges' do
-      @charges.each do       |charge|
+      @charges.each do |charge|
         #perform check.
         expect(charge['amount']).to be_a Float
       end
     end
 
-
-
     it 'iterate over customer charges' do
 
       #create new customer
@@ -363,13 +377,11 @@ describe Charges do
 
       @charges.create(charge2_hash,customer['id'])
 
-
       @charges.each(customer['id']) do |charge|
         expect(charge['operation_type']).to match 'in'
-       expect(charge['amount']).to be_within(0.1).of(4)
+        expect(charge['amount']).to be_within(0.1).of(4)
       end
 
-
       #cleanup
       @cards.delete(card['id'],customer['id'])
       @customers.delete(customer['id'])
@@ -378,11 +390,4 @@ describe Charges do
 
   end
 
-
-
-
-
-
-
-
-end
+end

data/test/spec/customers_spec.rb

@@ -1,9 +1,7 @@
 require_relative '../spec_helper'
 
-
 describe Customers do
 
-
   before(:all) do
 
     @merchant_id='mywvupjjs9xdnryxtplq'
@@ -12,14 +10,24 @@ describe Customers do
     @openpay=OpenpayApi.new(@merchant_id, @private_key)
     @customers=@openpay.create(:customers)
 
+    @customers.delete_all
+
+  end
+
+  after(:all) do
+    @customers.delete_all
   end
 
+  it 'has all required methods' do
+    %w(all each create get list delete).each do |meth|
+      expect(@customers).to respond_to(meth)
+    end
+  end
 
   describe '.create' do
 
     it 'creates a customer' do
 
-
       #creates a new customer
       name='Juan'
       last_name='Perez'
@@ -46,7 +54,6 @@ describe Customers do
 
     end
 
-
     it 'fails when passing invalid information' do
 
       #check no errors
@@ -62,8 +69,7 @@ describe Customers do
         @customers.create(customer_hash)
       rescue OpenpayTransactionException => e
         expect(e.http_code).to be 400
-        expect(e.description).to match 'not a well-formed email address'
-
+        expect(e.description).to match /email no es una direcci.n de correo bien formada/
       end
 
       expect(@customers.errors?).to be_true
@@ -72,10 +78,8 @@ describe Customers do
 
   end
 
-
   describe '.delete' do
 
-
     it 'deletes an existing customer' do
       #creates customer
       customer_hash = FactoryGirl.build(:customer, name: :delete_me)
@@ -89,7 +93,6 @@ describe Customers do
 
   end
 
-
   describe '.get' do
 
     it 'get a customer' do
@@ -105,33 +108,16 @@ describe Customers do
       @customers.delete(id)
     end
 
-
   end
 
-
   describe '.each' do
     it 'list all customers' do
-      #clean state just in case
-      @customers.delete_all
-
-      #create customers
-      name='cust1'
-      customer_hash = FactoryGirl.build(:customer, name: name)
-      customer=@customers.create(customer_hash)
-      id=customer['id']
-      customer2=@customers.create(customer_hash)
-      id2=customer2['id']
-      #perform check
       @customers.each do |cust|
-        expect(cust['name']).to match 'cust1'
+        expect(cust['id']).to match /.+/
       end
-      #cleanup
-      @customers.delete(id)
-      @customers.delete(id2)
     end
   end
 
-
   describe '.update' do
 
     it 'updates an existing customer' do
@@ -157,15 +143,36 @@ describe Customers do
 
   end
 
+  describe '.list' do
+
+    it 'list customers given the filter' do
+      # creates customer
+      name='customer_update_test'
+      customer_hash = FactoryGirl.build(:customer, name: name)
+
+      customer=@customers.create(customer_hash)
+      id=customer['id']
+
+      search_params = OpenpayUtils::SearchParams.new
+      search_params.limit=1
+
+      #perform check
+      expect(@customers.list(search_params).size).to eq 1
 
+      #cleanup
+      @customers.delete(id)
 
+    end
+
+  end
 
   describe '.all' do
 
-    it 'list all the customers' do
+    it 'all the customers' do
 
+      @customers.delete_all
       #initial state check
-      expect(@customers.all.size).to be 0
+      initial_num = @customers.all.size
 
       # creates customer
       name='customer_update_test'
@@ -173,21 +180,15 @@ describe Customers do
       customer=@customers.create(customer_hash)
 
       #performs check
-       expect(@customers.all.size).to be 1
+      expect(@customers.all.size).to eq (initial_num + 1)
 
       #cleanup
       @customers.delete(customer['id'])
 
-      #performs check
-      expect(@customers.all.size).to be 0
-
-
     end
 
-
   end
 
-
   describe '.delete_all' do
 
     it 'deletes all customer records' do
@@ -211,20 +212,9 @@ describe Customers do
       cust=@openpayprod.create(:customers)
       expect { cust.delete_all }.to raise_exception OpenpayException
 
-
     end
 
-
   end
 
-
 end
 
-
-
-
-
-
-
-
-