opal-rspec 0.6.2 → 0.7.0.rc.1

data/bin/opal

@@ -0,0 +1,3 @@
+#!/usr/bin/env ruby
+
+exec 'bundle', 'exec', 'opal', *ARGV

data/bin/opal-rspec

@@ -0,0 +1,3 @@
+#!/usr/bin/env ruby
+
+exec 'bundle', 'exec', 'opal-rspec', *ARGV

data/bin/setup

@@ -0,0 +1,7 @@
+#!/usr/bin/env bash
+set -euo pipefail
+IFS=$'\n\t'
+set -vx
+
+bundle install
+git submodule update --init

data/config.ru

@@ -1,17 +1,19 @@
 require 'opal/rspec'
+require 'opal/sprockets/server'
 
 Opal::Config.source_map_enabled = false
 Opal::Config.arity_check_enabled = true
 
-sprockets_env = Opal::RSpec::SprocketsEnvironment.new(spec_pattern='spec/opal/**/*_spec.{rb,opal}',
-                                                      spec_exclude_pattern=nil,
-                                                      spec_files=nil,
-                                                      default_path='spec/opal')
+sprockets_env = Opal::RSpec::SprocketsEnvironment.new(spec_pattern         = 'spec-opal/**/*_spec.{rb,opal}',
+                                                      spec_exclude_pattern = nil,
+                                                      spec_files           = nil,
+                                                      default_path         = 'spec-opal')
+
 sprockets_env.cache = ::Sprockets::Cache::FileStore.new(File.join('tmp', 'cache', 'opal_specs'))
-run Opal::Server.new(sprockets: sprockets_env) { |s|
-      s.main = 'sprockets_runner_js_errors'
-      # sprockets_runner_js_errors will not be in the opal load path by default
-      s.append_path 'spec/mri/integration/rack'
-      sprockets_env.add_spec_paths_to_sprockets
-      s.debug = ENV['OPAL_DEBUG']
-    }
+run Opal::Sprockets::Server.new(sprockets: sprockets_env) { |s|
+  s.main = 'sprockets_runner_js_errors'
+  # sprockets_runner_js_errors will not be in the opal load path by default
+  s.append_path 'spec/integration/rack'
+  sprockets_env.add_spec_paths_to_sprockets
+  s.debug = ENV['OPAL_DEBUG']
+}

data/example/Gemfile

@@ -1,4 +1,8 @@
 source 'https://rubygems.org'
 
 gem 'rake'
-gem 'opal-rspec', :path => '../'
+gem 'opal-rspec', path: '../'
+# gem 'opal', '~> 0.11.0.rc1'
+gem 'opal', path: '../../opal'
+gem 'opal-sprockets', github: 'opal/opal-sprockets'
+

data/exe/opal-rspec

@@ -0,0 +1,78 @@
+#!/usr/bin/env ruby
+
+# Error codes are taken from /usr/include/sysexits.h
+
+require 'rake'
+require 'opal/rspec/runner'
+
+require 'shellwords'
+require 'optparse'
+
+options = {}
+OptionParser.new do |parser|
+  parser.on('-c', '--[no-]color', '--[no-]colour', 'Enable color in the output.') do |o|
+    options[:color] = o
+  end
+
+  parser.on('-f', '--format FORMATTER', 'Choose a formatter.',
+            '  [p]rogress (default - dots)',
+            '  [d]ocumentation (group and example names)',
+            '  [h]tml',
+            '  [j]son',
+            '  custom formatter class name') do |o|
+    options[:formatters] ||= []
+    options[:formatters] << [o]
+  end
+  parser.on('-r', '--require PATH', 'Require a file.') do |path|
+    options[:requires] ||= []
+    options[:requires] << path
+  end
+  parser.on('-I PATH', 'Specify PATH to add to $LOAD_PATH (may be used more than once).') do |dir|
+    options[:includes] ||= []
+    options[:includes] << dir
+  end
+  parser.on('-P', '--pattern PATTERN', 'Load files matching pattern (default: "spec-opal/**/*_spec.rb").') do |o|
+    options[:pattern] = o
+  end
+  parser.on('--default-path PATH', 'Set the default path where RSpec looks for examples (can',
+            '  be a path to a file or a directory).') do |path|
+    options[:default_path] = path
+  end
+
+  parser.separator 'Opal specific options:'
+
+  parser.on('-R', '--runner NAME', 'Use a different JS runner (default is nodejs)') do |name|
+    options[:runner] = name
+  end
+
+end.parse!
+# p options: options
+
+runner = Opal::RSpec::Runner.new do |server, config|
+  spec_opts = []
+  spec_opts += ['--color', options[:color]] if options[:color]
+  options[:requires].each {|req| spec_opts += ['-r', req]} if options[:requires]
+  raise "can accept only one formatter at this time" if options[:formatters] && options[:formatters].size != 1
+  spec_opts += ['--format', options[:formatters].flatten.first] if options[:formatters]
+  raw_files = ARGV
+  # p raw_files: ARGV
+  files = raw_files.flat_map do |file|
+    if File.directory? file
+      Dir[File.join(file, '**{,/*/**}/*_spec{.js,}.rb')]
+    elsif File.file? file
+      file
+    else
+      raise "Can't stat path: #{file}"
+    end
+  end
+  # p files: files
+
+  options[:includes].each {|dir| server.append_path dir} if options[:includes]
+  config.default_path = options[:default_path]           if options[:default_path]
+  config.spec_opts    = spec_opts.shelljoin
+  config.files        = files
+end
+
+# puts runner.command
+runner.run
+

data/gemfiles/.bundle/config

@@ -0,0 +1,2 @@
+---
+BUNDLE_RETRY: "1"

data/gemfiles/opal_0.11.gemfile

@@ -0,0 +1,14 @@
+# This file was generated by Appraisal
+
+source "https://rubygems.org"
+
+gem "rspec", path: "../rspec/upstream"
+gem "rspec-support", path: "../rspec-support/upstream"
+gem "rspec-core", path: "../rspec-core/upstream"
+gem "rspec-mocks", path: "../rspec-mocks/upstream"
+gem "rspec-expectations", path: "../rspec-expectations/upstream"
+gem "pry"
+gem "opal", "~> 0.11.0"
+gem "opal-sprockets"
+
+gemspec path: "../"

data/gemfiles/opal_master.gemfile

@@ -0,0 +1,14 @@
+# This file was generated by Appraisal
+
+source "https://rubygems.org"
+
+gem "rspec", path: "../rspec/upstream"
+gem "rspec-support", path: "../rspec-support/upstream"
+gem "rspec-core", path: "../rspec-core/upstream"
+gem "rspec-mocks", path: "../rspec-mocks/upstream"
+gem "rspec-expectations", path: "../rspec-expectations/upstream"
+gem "pry"
+gem "opal", git: "https://github.com/opal/opal.git"
+gem "opal-sprockets", github: "opal/opal-sprockets"
+
+gemspec path: "../"

data/lib-opal/opal/rspec.rb

@@ -0,0 +1,5 @@
+require 'opal/rspec/pre_require_fixes'
+require 'opal/rspec/requires'
+require 'opal/rspec/fixes'
+require 'opal/rspec/default_config'
+require 'opal/rspec/browser' if JS[:document]

data/{opal → lib-opal}/opal/rspec/async.rb

@@ -1,5 +1,6 @@
-require 'opal/rspec/async/async_example'
+require 'opal/rspec/async/core_ext'
+require 'opal/rspec/async/example'
 require 'opal/rspec/async/example_group'
 require 'opal/rspec/async/hooks'
-require 'opal/rspec/async/legacy'
 require 'opal/rspec/async/reporter'
+require 'opal/rspec/async/runner'

data/lib-opal/opal/rspec/async/core_ext.rb

@@ -0,0 +1,23 @@
+require 'promise'
+
+module Kernel
+  def exit(status = true)
+    status = 0 if `status === true` # it's in JS because it can be null/undef
+
+    $__at_exit__ ||= []
+    process_promises = nil
+    exit_block = -> { `Opal.exit(status)`; nil }
+
+    next_at_exit = -> do
+      if $__at_exit__.size > 0
+        block = $__at_exit__.pop
+        result =  block.call
+        result.is_a?(Promise) ? result.then(&next_at_exit) : next_at_exit.call
+      else
+        result.is_a?(Promise) ? result.then(&exit_block) : exit_block.call
+      end
+    end
+
+    next_at_exit.call
+  end
+end

data/lib-opal/opal/rspec/async/example.rb

@@ -0,0 +1,187 @@
+require 'js'
+
+module ::RSpec::Core
+  class Example
+    # WAS:
+    #   def run_after_example
+    #     @example_group_class.hooks.run(:after, :example, self)
+    #     verify_mocks
+    #     assign_generated_description if RSpec.configuration.expecting_with_rspec?
+    #   rescue Exception => e
+    #     set_exception(e, "in an `after(:example)` hook")
+    #   ensure
+    #     @example_group_instance.teardown_mocks_for_rspec
+    #   end
+    # NOW:
+    def run_after_example
+      @example_group_class.hooks.run(:after, :example, self).then do
+        verify_mocks
+        assign_generated_description if RSpec.configuration.expecting_with_rspec?
+      end.rescue do |e|
+        set_exception(e, "in an `after(:example)` hook")
+      end.ensure do
+        @example_group_instance.teardown_mocks_for_rspec
+      end
+    end
+
+    def run(example_group_instance, reporter)
+      @example_group_instance = example_group_instance
+      RSpec.current_example = self
+
+      start(reporter)
+      Pending.mark_pending!(self, pending) if pending?
+
+      # WAS:
+      #   …
+      #     begin
+      #       if skipped?
+      #         Pending.mark_pending! self, skip
+      #       elsif !RSpec.configuration.dry_run?
+      #         with_around_example_hooks do
+      #           begin
+      #             run_before_example
+      #             @example_group_instance.instance_exec(self, &@example_block)
+      #
+      #             if pending?
+      #               Pending.mark_fixed! self
+      #
+      #               raise Pending::PendingExampleFixedError,
+      #                     'Expected example to fail since it is pending, but it passed.',
+      #                     [location]
+      #             end
+      #           rescue Pending::SkipDeclaredInExample
+      #             # no-op, required metadata has already been set by the `skip`
+      #             # method.
+      #           rescue Exception => e
+      #             set_exception(e)
+      #           ensure
+      #             run_after_example
+      #           end
+      #         end
+      #       end
+      #     rescue Exception => e
+      #       set_exception(e)
+      #     ensure
+      #       @example_group_instance.instance_variables.each do |ivar|
+      #         @example_group_instance.instance_variable_set(ivar, nil)
+      #       end
+      #       @example_group_instance = nil
+      #     end
+      #
+      #     finish(reporter)
+      #   ensure
+      #     RSpec.current_example = nil
+      Promise.value(true).then do
+        Promise.value(true).then do
+          if skipped?
+            Pending.mark_pending! self, skip
+          elsif !RSpec.configuration.dry_run?
+            with_around_example_hooks do
+              # WAS:
+              #   with_around_example_hooks do
+              #     begin
+              #       run_before_example
+              #       @example_group_instance.instance_exec(self, &@example_block)
+              #
+              #       if pending?
+              #         Pending.mark_fixed! self
+              #
+              #         raise Pending::PendingExampleFixedError,
+              #               'Expected example to fail since it is pending, but it passed.',
+              #               [location]
+              #       end
+              #     rescue Pending::SkipDeclaredInExample
+              #       # no-op, required metadata has already been set by the `skip`
+              #       # method.
+              #     rescue Exception => e
+              #       set_exception(e)
+              #     ensure
+              #       run_after_example
+              #     end
+              #   end
+              # NOW:
+              Promise.value(true).then do
+                run_before_example
+                .then do
+                  # TODO: Use subject! to create a before hook on the fly, might be cleaner than this
+                  # Might be a better way to do this, but then you end up with promises around the expectation handlers, which could get ugly
+                  begin
+                    subj = example_group_instance.subject
+                    if subj.is_a? Promise
+                      return subj.then do |resolved_subject|
+                        # This is a private method, but we're using Opal
+                        example_group_instance.__memoized[:subject] = resolved_subject
+                      end
+                    end
+                  rescue StandardError, JS::Error
+                    # Exception occurred while checking the subject, might be that the example
+                    # group had a described class, was not intending on using it as the subject,
+                    # and the initializer for that described class failed
+                  end
+                  Promise.value(true)
+                end
+                .then do
+                  # WAS:
+                  #   @example_group_instance.instance_exec(self, &@example_block)
+                  # NOW:
+                  Promise.value(@example_group_instance.instance_exec(self, &@example_block)).then do |result|
+                    result
+                  end.rescue do |ex|
+                    case ex
+                    when nil then Exception.new 'Async promise failed for unspecified reason'
+                    when Exception then ex
+                    else Exception.new(ex)
+                    end
+                  end
+                end
+                .then do
+                  # ORIGINAL:
+                  if pending?
+                    Pending.mark_fixed! self
+
+                    raise Pending::PendingExampleFixedError,
+                          'Expected example to fail since it is pending, but it passed.',
+                          [location]
+                  end
+                end
+              end.rescue do |e|
+                # WAS:
+                #   rescue Pending::SkipDeclaredInExample
+                #     # no-op, required metadata has already been set by the `skip`
+                #     # method.
+                #   rescue Exception => e
+                #     set_exception(e)
+                #   ensure
+                #     run_after_example
+                #   end
+                # NOW:
+                case e
+                when Pending::SkipDeclaredInExample
+                  # no-op, required metadata has already been set by the `skip`
+                  # method.
+                when Exception
+                  set_exception(e)
+                end
+              end.ensure do
+                run_after_example
+              end
+            end
+          end
+        end.rescue do |e|
+          set_exception(e)
+        end.ensure do
+          @example_group_instance.instance_variables.each do |ivar|
+            @example_group_instance.instance_variable_set(ivar, nil)
+          end
+          @example_group_instance = nil
+        end
+      end.then do
+        finish(reporter)
+      end.ensure do |result|
+        RSpec.current_example = nil
+        # promise always/ensure do not behave exactly like ensure, need to be explicit about value being returned
+        result
+      end
+    end
+  end
+end

data/{opal → lib-opal}/opal/rspec/async/example_group.rb

@@ -10,7 +10,7 @@ class ::RSpec::Core::ExampleGroup
   def delay_with_promise(duration, &block)
     result = Promise.new
     delay(duration) { result.resolve }
-    result.then &block
+    result.then(&block)
   end
 
   def self.process_descendants(our_examples_result, reporter)

data/{opal → lib-opal}/opal/rspec/async/hooks.rb

@@ -1,9 +1,11 @@
 class RSpec::Core::Hooks::HookCollection
   def run
+    # WAS:
+    #   hooks.each { |h| h.run(@example) }
+    # NOW:
     hooks.inject(Promise.value(true)) do |previous_hook_promise, next_hook|
       previous_hook_promise.then do
-        result = next_hook.run @example
-        Promise.value(result)
+        Promise.value(next_hook.run(@example))
       end
     end
   end

data/lib-opal/opal/rspec/async/legacy.rb

@@ -0,0 +1,49 @@
+# module Opal
+#   module RSpec
+#     module AsyncHelpers
+#       module ClassMethods
+#         def async(desc, *args, &block)
+#           options = ::RSpec::Core::Metadata.build_hash_from(args)
+#           options.update(:skip => ::RSpec::Core::Pending::NOT_YET_IMPLEMENTED) unless block
+#
+#           examples << Opal::RSpec::LegacyAsyncExample.new(self, desc, options, block)
+#           examples.last
+#         end
+#       end
+#
+#       attr_accessor :legacy_promise
+#
+#       def self.included(base)
+#         base.extend ClassMethods
+#       end
+#
+#       # Use {#async} instead.
+#       #
+#       # @deprecated
+#       def run_async(&block)
+#         async(&block)
+#       end
+#
+#       def async(&block)
+#         begin
+#           instance_eval &block
+#           legacy_promise.resolve
+#         rescue Exception => e
+#           legacy_promise.reject e
+#         end
+#       end
+#     end
+#   end
+# end
+#
+# class Opal::RSpec::LegacyAsyncExample < ::RSpec::Core::Example
+#   def initialize(example_group_class, description, user_metadata, example_block=nil)
+#     legacy_promise_ex_block = lambda do |example|
+#       self.legacy_promise = Promise.new
+#       instance_exec(example, &example_block)
+#       self.legacy_promise
+#     end
+#
+#     super example_group_class, description, user_metadata, legacy_promise_ex_block
+#   end
+# end