omnibus 3.2.2 → 4.0.0.beta.1

data/spec/unit/metadata_spec.rb

@@ -0,0 +1,207 @@
+require 'spec_helper'
+
+module Omnibus
+  describe Metadata do
+    let(:instance) do
+      double(described_class, path: '/path/to/package.deb.metadata.json')
+    end
+
+    let(:package) do
+      double(Package,
+        name:   'package',
+        path:   '/path/to/package.deb',
+        md5:    'abc123',
+        sha1:   'abc123',
+        sha256: 'abcd1234',
+        sha512: 'abcdef123456',
+      )
+    end
+
+    let(:data) { { foo: 'bar' } }
+
+    subject { described_class.new(package, data) }
+
+    describe '.arch' do
+      it 'returns the architecture' do
+        stub_ohai(platform: 'ubuntu', version: '12.04') do |data|
+          data['kernel']['machine'] = 'x86_64'
+        end
+        expect(described_class.arch).to eq('x86_64')
+      end
+    end
+
+    describe '.platform_shortname' do
+      it 'returns el on rhel' do
+        stub_ohai(platform: 'redhat', version: '6.4')
+        expect(described_class.platform_shortname).to eq('el')
+      end
+
+      it 'returns .platform on non-rhel systems' do
+        stub_ohai(platform: 'ubuntu', version: '12.04')
+        expect(described_class.platform_shortname).to eq('ubuntu')
+      end
+    end
+
+    describe '.platform_version' do
+      shared_examples 'a version manipulator' do |platform_shortname, version, expected|
+        context "on #{platform_shortname}-#{version}" do
+          it 'returns the correct value' do
+            stub_ohai(platform: 'ubuntu', version: '12.04') do |data|
+              data['platform'] = platform_shortname
+              data['platform_version'] = version
+            end
+
+            expect(described_class.platform_version).to eq(expected)
+          end
+        end
+      end
+
+      it_behaves_like 'a version manipulator', 'arch', '2009.02', '2009.02'
+      it_behaves_like 'a version manipulator', 'arch', '2014.06.01', '2014.06'
+      it_behaves_like 'a version manipulator', 'debian', '7.1', '7'
+      it_behaves_like 'a version manipulator', 'debian', '6.9', '6'
+      it_behaves_like 'a version manipulator', 'ubuntu', '10.04', '10.04'
+      it_behaves_like 'a version manipulator', 'ubuntu', '10.04.04', '10.04'
+      it_behaves_like 'a version manipulator', 'fedora', '11.5', '11'
+      it_behaves_like 'a version manipulator', 'freebsd', '10.0', '10'
+      it_behaves_like 'a version manipulator', 'rhel', '6.5', '6'
+      it_behaves_like 'a version manipulator', 'el', '6.5', '6'
+      it_behaves_like 'a version manipulator', 'centos', '5.9.6', '5'
+      it_behaves_like 'a version manipulator', 'aix', '7.1', '7.1'
+      it_behaves_like 'a version manipulator', 'gentoo', '2004.3', '2004.3'
+      it_behaves_like 'a version manipulator', 'mac_os_x', '10.9.1', '10.9'
+      it_behaves_like 'a version manipulator', 'openbsd', '5.4.4', '5.4'
+      it_behaves_like 'a version manipulator', 'slackware', '12.0.1', '12.0'
+      it_behaves_like 'a version manipulator', 'solaris2', '5.9', '5.9'
+      it_behaves_like 'a version manipulator', 'suse', '5.9', '5.9'
+      it_behaves_like 'a version manipulator', 'omnios', 'r151010', 'r151010'
+      it_behaves_like 'a version manipulator', 'smartos', '20120809T221258Z', '20120809T221258Z'
+      it_behaves_like 'a version manipulator', 'windows', '5.0.2195', '2000'
+      it_behaves_like 'a version manipulator', 'windows', '5.1.2600', 'xp'
+      it_behaves_like 'a version manipulator', 'windows', '5.2.3790', '2003r2'
+      it_behaves_like 'a version manipulator', 'windows', '6.0.6001', '2008'
+      it_behaves_like 'a version manipulator', 'windows', '6.1.7600', '7'
+      it_behaves_like 'a version manipulator', 'windows', '6.1.7601', '2008r2'
+      it_behaves_like 'a version manipulator', 'windows', '6.2.9200', '8'
+      it_behaves_like 'a version manipulator', 'windows', '6.3.9200', '8.1'
+      it_behaves_like 'a version manipulator', 'windows', '6.3.9600', '8.1'
+
+      context 'given an unknown platform' do
+        before do
+          stub_ohai(platform: 'ubuntu', version: '12.04') do |data|
+            data['platform'] = 'bacon'
+            data['platform_version'] = '1.crispy'
+          end
+        end
+
+        it 'raises an exception' do
+          expect { described_class.platform_version }
+            .to raise_error(UnknownPlatform)
+        end
+      end
+
+      context 'given an unknown windows platform version' do
+        before do
+          stub_ohai(platform: 'ubuntu', version: '12.04') do |data|
+            data['platform'] = 'windows'
+            data['platform_version'] = '1.2.3'
+          end
+        end
+
+        it 'raises an exception' do
+          expect { described_class.platform_version }
+            .to raise_error(UnknownPlatformVersion)
+        end
+      end
+    end
+
+    describe '.for_package' do
+      it 'raises an exception when the file does not exist' do
+        allow(File).to receive(:read).and_raise(Errno::ENOENT)
+        expect { described_class.for_package(package) }
+          .to raise_error(NoPackageMetadataFile)
+      end
+
+      it 'returns a metadata object' do
+        allow(File).to receive(:read).and_return('{ "platform": "ubuntu" }')
+        expect(described_class.for_package(package)).to be_a(described_class)
+      end
+
+      it 'loads the metadata from disk' do
+        allow(File).to receive(:read).and_return('{ "platform": "ubuntu" }')
+        instance = described_class.for_package(package)
+
+        expect(instance[:platform]).to eq('ubuntu')
+      end
+
+      it 'ensures platform version is properly truncated' do
+        allow(File).to receive(:read).and_return('{ "platform": "el", "platform_version": "5.10" }')
+        instance = described_class.for_package(package)
+
+        expect(instance[:platform_version]).to eq('5')
+      end
+
+      it 'correctly truncates sles platform versions' do
+        allow(File).to receive(:read).and_return('{ "platform": "sles", "platform_version": "11.2" }')
+        instance = described_class.for_package(package)
+
+        expect(instance[:platform_version]).to eq('11')
+      end
+
+      it 'ensures an iteration exists' do
+        allow(File).to receive(:read).and_return('{}')
+        instance = described_class.for_package(package)
+
+        expect(instance[:iteration]).to eq(1)
+      end
+
+      it 'does not change existing iterations' do
+        allow(File).to receive(:read).and_return('{ "iteration": 4 }')
+        instance = described_class.for_package(package)
+
+        expect(instance[:iteration]).to eq(4)
+      end
+    end
+
+    describe '.path_for' do
+      it 'returns the postfixed .metadata.json' do
+        expect(described_class.path_for(package))
+          .to eq('/path/to/package.deb.metadata.json')
+      end
+    end
+
+    describe '#name' do
+      it 'returns the basename of the package' do
+        expect(subject.name).to eq('package.deb.metadata.json')
+      end
+    end
+
+    describe '#path' do
+      it 'delegates to .path_for' do
+        expect(described_class).to receive(:path_for).once
+        subject.path
+      end
+    end
+
+    describe '#save' do
+      let(:file) { double(File) }
+
+      before { allow(File).to receive(:open).and_yield(file) }
+
+      it 'saves the file to disk' do
+        expect(file).to receive(:write).once
+        subject.save
+      end
+    end
+
+    describe '#to_json' do
+      it 'generates pretty JSON' do
+        expect(subject.to_json).to eq <<-EOH.gsub(/^ {10}/, '').strip
+          {
+            "foo": "bar"
+          }
+        EOH
+      end
+    end
+  end
+end

data/spec/unit/ohai_spec.rb

@@ -2,13 +2,6 @@ require 'spec_helper'
 
 module Omnibus
   describe Ohai do
-    context 'using dot notation' do
-      it 'does not raise an exception' do
-        expect { Ohai.kernel }.to_not raise_error
-        expect { Ohai.kernel.machine }.to_not raise_error
-      end
-    end
-
     context 'using hash notation' do
       it 'allows fetching values by hash notation' do
         expect { Ohai['kernel'] }.to_not raise_error

data/spec/unit/omnibus_spec.rb

@@ -18,60 +18,65 @@ describe Omnibus do
     Omnibus::Config.software_gems(['omnibus-software', 'custom-omnibus-software'])
   end
 
-  describe '#software_dirs' do
-    let(:software_dirs) { Omnibus.software_dirs }
-
-    it 'includes project_root' do
-      expect(software_dirs).to include('/foo/bar/config/software')
+  describe '#which' do
+    it 'returns nil when the file does not exist' do
+      stub_env('PATH', nil)
+      expect(subject.which('not_a_real_executable')).to be nil
     end
 
-    it 'includes local_software_dirs dirs' do
-      expect(software_dirs).to include('/local/config/software')
-      expect(software_dirs).to include('/other/config/software')
+    it 'retusnt the path when the file exists' do
+      ruby = Bundler.which('ruby')
+      expect(subject.which(ruby)).to eq(ruby)
     end
+  end
 
-    it 'includes software_gems dirs' do
-      expect(software_dirs).to include('/gem/omnibus-software/config/software')
-      expect(software_dirs).to include('/gem/custom-omnibus-software/config/software')
+  describe '#project_path' do
+    before do
+      allow(Omnibus).to receive(:project_map)
+        .and_return('chef' => '/projects/chef')
     end
 
-    it 'has the correct precedence order' do
-      expect(software_dirs).to eq([
-        '/foo/bar/config/software',
-        '/local/config/software',
-        '/other/config/software',
-        '/gem/omnibus-software/config/software',
-        '/gem/custom-omnibus-software/config/software',
-      ])
+    it 'accepts a string' do
+      expect(subject.project_path('chef')).to eq('/projects/chef')
     end
-  end
 
-  describe '#software_map' do
-    let(:software_map) { Omnibus.send(:software_map) }
+    it 'accepts a symbol' do
+      expect(subject.project_path(:chef)).to eq('/projects/chef')
+    end
 
-    it 'returns a hash' do
-      expect(software_map).to be_a(Hash)
+    it 'returns nil when the project does not exist' do
+      expect(subject.project_path('bacon')).to be nil
     end
   end
 
-  describe '#process_dsl_files' do
+  describe '#software_path' do
     before do
-      Omnibus::Config.project_root(complicated_path)
-      stub_ohai(platform: 'ubuntu', version: '12.04')
+      allow(Omnibus).to receive(:software_map)
+        .and_return('chef' => '/software/chef')
     end
 
-    it 'populates the 5 projects' do
-      Omnibus.process_dsl_files
+    it 'accepts a string' do
+      expect(subject.software_path('chef')).to eq('/software/chef')
+    end
 
-      expect(Omnibus.projects.size).to eq(5)
+    it 'accepts a symbol' do
+      expect(subject.software_path(:chef)).to eq('/software/chef')
+    end
 
-      names = Omnibus.projects.map(&:name)
-      expect(names).to include('angrychef')
-      expect(names).to include('chef-windows')
-      expect(names).to include('chef')
-      expect(names).to include('chefdk-windows')
-      expect(names).to include('chefdk')
+    it 'returns nil when the project does not exist' do
+      expect(subject.software_path('bacon')).to be nil
     end
+  end
 
+  describe '#possible_paths_for' do
+    it 'searches all paths' do
+      expect(subject.possible_paths_for('file')).to eq(%w(
+        /foo/bar/file
+        /local/file
+        /other/file
+        /gem/omnibus-software/file
+        /gem/custom-omnibus-software/file
+      ))
+    end
   end
 end

data/spec/unit/package_spec.rb

@@ -1,221 +1,6 @@
 require 'spec_helper'
 
 module Omnibus
-  describe Package::Metadata do
-    let(:instance) do
-      double(Package::Metadata,
-        path: '/path/to/package.deb.metadata.json',
-      )
-    end
-
-    let(:package) do
-      double(Package,
-        name:   'package',
-        path:   '/path/to/package.deb',
-        md5:    'abc123',
-        sha1:   'abc123',
-        sha256: 'abcd1234',
-        sha512: 'abcdef123456',
-      )
-    end
-
-    let(:data) { { foo: 'bar' } }
-
-    subject { described_class.new(package, data) }
-
-    describe '.generate' do
-      it 'writes out the file' do
-        allow(described_class).to receive(:new).and_return(instance)
-        expect(instance).to receive(:save).once
-
-        described_class.generate(package, data)
-      end
-
-      describe '#arch' do
-        it 'returns the architecture' do
-          stub_ohai(platform: 'ubuntu', version: '12.04') do |data|
-            data['kernel']['machine'] = 'x86_64'
-          end
-          expect(described_class.arch).to eq('x86_64')
-        end
-      end
-
-      describe '#platform_shortname' do
-        it 'returns el on rhel' do
-          stub_ohai(platform: 'redhat', version: '6.4')
-          expect(described_class.platform_shortname).to eq('el')
-        end
-
-        it 'returns #platform on non-rhel systems' do
-          stub_ohai(platform: 'ubuntu', version: '12.04')
-          expect(described_class.platform_shortname).to eq('ubuntu')
-        end
-      end
-
-      describe '#platform_version' do
-        shared_examples 'a version manipulator' do |platform_shortname, version, expected|
-          context "on #{platform_shortname}-#{version}" do
-            it 'returns the correct value' do
-              stub_ohai(platform: 'ubuntu', version: '12.04') do |data|
-                data['platform'] = platform_shortname
-                data['platform_version'] = version
-              end
-
-              expect(described_class.platform_version).to eq(expected)
-            end
-          end
-        end
-
-        it_behaves_like 'a version manipulator', 'arch', '2009.02', '2009.02'
-        it_behaves_like 'a version manipulator', 'arch', '2014.06.01', '2014.06'
-        it_behaves_like 'a version manipulator', 'debian', '7.1', '7'
-        it_behaves_like 'a version manipulator', 'debian', '6.9', '6'
-        it_behaves_like 'a version manipulator', 'ubuntu', '10.04', '10.04'
-        it_behaves_like 'a version manipulator', 'ubuntu', '10.04.04', '10.04'
-        it_behaves_like 'a version manipulator', 'fedora', '11.5', '11'
-        it_behaves_like 'a version manipulator', 'freebsd', '10.0', '10'
-        it_behaves_like 'a version manipulator', 'rhel', '6.5', '6'
-        it_behaves_like 'a version manipulator', 'el', '6.5', '6'
-        it_behaves_like 'a version manipulator', 'centos', '5.9.6', '5'
-        it_behaves_like 'a version manipulator', 'aix', '7.1', '7.1'
-        it_behaves_like 'a version manipulator', 'gentoo', '2004.3', '2004.3'
-        it_behaves_like 'a version manipulator', 'mac_os_x', '10.9.1', '10.9'
-        it_behaves_like 'a version manipulator', 'openbsd', '5.4.4', '5.4'
-        it_behaves_like 'a version manipulator', 'slackware', '12.0.1', '12.0'
-        it_behaves_like 'a version manipulator', 'solaris2', '5.9', '5.9'
-        it_behaves_like 'a version manipulator', 'suse', '5.9', '5.9'
-        it_behaves_like 'a version manipulator', 'omnios', 'r151010', 'r151010'
-        it_behaves_like 'a version manipulator', 'smartos', '20120809T221258Z', '20120809T221258Z'
-        it_behaves_like 'a version manipulator', 'windows', '5.0.2195', '2000'
-        it_behaves_like 'a version manipulator', 'windows', '5.1.2600', 'xp'
-        it_behaves_like 'a version manipulator', 'windows', '5.2.3790', '2003r2'
-        it_behaves_like 'a version manipulator', 'windows', '6.0.6001', '2008'
-        it_behaves_like 'a version manipulator', 'windows', '6.1.7600', '7'
-        it_behaves_like 'a version manipulator', 'windows', '6.1.7601', '2008r2'
-        it_behaves_like 'a version manipulator', 'windows', '6.2.9200', '8'
-        it_behaves_like 'a version manipulator', 'windows', '6.3.9200', '8.1'
-        it_behaves_like 'a version manipulator', 'windows', '6.3.9600', '8.1'
-
-        context 'given an unknown platform' do
-          before do
-            stub_ohai(platform: 'ubuntu', version: '12.04') do |data|
-              data['platform'] = 'bacon'
-              data['platform_version'] = '1.crispy'
-            end
-          end
-
-          it 'raises an exception' do
-            expect { described_class.platform_version }
-              .to raise_error(UnknownPlatform)
-          end
-        end
-
-        context 'given an unknown windows platform version' do
-          before do
-            stub_ohai(platform: 'ubuntu', version: '12.04') do |data|
-              data['platform'] = 'windows'
-              data['platform_version'] = '1.2.3'
-            end
-          end
-
-          it 'raises an exception' do
-            expect { described_class.platform_version }
-              .to raise_error(UnknownPlatformVersion)
-          end
-        end
-      end
-    end
-
-    describe '.for_package' do
-      it 'raises an exception when the file does not exist' do
-        allow(File).to receive(:read).and_raise(Errno::ENOENT)
-        expect { described_class.for_package(package) }
-          .to raise_error(NoPackageMetadataFile)
-      end
-
-      it 'returns a metadata object' do
-        allow(File).to receive(:read).and_return('{ "platform": "ubuntu" }')
-        expect(described_class.for_package(package)).to be_a(described_class)
-      end
-
-      it 'loads the metadata from disk' do
-        allow(File).to receive(:read).and_return('{ "platform": "ubuntu" }')
-        instance = described_class.for_package(package)
-
-        expect(instance[:platform]).to eq('ubuntu')
-      end
-
-      it 'ensures platform version is properly truncated' do
-        allow(File).to receive(:read).and_return('{ "platform": "el", "platform_version": "5.10" }')
-        instance = described_class.for_package(package)
-
-        expect(instance[:platform_version]).to eq('5')
-      end
-
-      it 'correctly truncates sles platform versions' do
-        allow(File).to receive(:read).and_return('{ "platform": "sles", "platform_version": "11.2" }')
-        instance = described_class.for_package(package)
-
-        expect(instance[:platform_version]).to eq('11')
-      end
-
-      it 'ensures an iteration exists' do
-        allow(File).to receive(:read).and_return('{}')
-        instance = described_class.for_package(package)
-
-        expect(instance[:iteration]).to eq(1)
-      end
-
-      it 'does not change existing iterations' do
-        allow(File).to receive(:read).and_return('{ "iteration": 4 }')
-        instance = described_class.for_package(package)
-
-        expect(instance[:iteration]).to eq(4)
-      end
-    end
-
-    describe '.path_for' do
-      it 'returns the postfixed .metadata.json' do
-        expect(described_class.path_for(package))
-          .to eq('/path/to/package.deb.metadata.json')
-      end
-    end
-
-    describe '#name' do
-      it 'returns the basename of the package' do
-        expect(subject.name).to eq('package.deb.metadata.json')
-      end
-    end
-
-    describe '#path' do
-      it 'delegates to .path_for' do
-        expect(described_class).to receive(:path_for).once
-        subject.path
-      end
-    end
-
-    describe '#save' do
-      let(:file) { double(File) }
-
-      before { allow(File).to receive(:open).and_yield(file) }
-
-      it 'saves the file to disk' do
-        expect(file).to receive(:write).once
-        subject.save
-      end
-    end
-
-    describe '#to_json' do
-      it 'generates pretty JSON' do
-        expect(subject.to_json).to eq <<-EOH.gsub(/^ {10}/, '').strip
-          {
-            "foo": "bar"
-          }
-        EOH
-      end
-    end
-  end
-
   describe Package do
     let(:path) { '/path/to/files/thing.deb' }
 
@@ -289,7 +74,7 @@ module Omnibus
       before { allow(IO).to receive(:read).and_return(content) }
 
       it 'returns a Metadata object' do
-        expect(subject.metadata).to be_a(Package::Metadata)
+        expect(subject.metadata).to be_a(Metadata)
       end
 
       it 'reads the information in the file' do