omnibus 3.2.2 → 4.0.0.beta.1

data/spec/support/logging_helpers.rb

@@ -0,0 +1,33 @@
+module Omnibus
+  module RSpec
+    module LoggingHelpers
+      #
+      # Grab the result of the log command. Since Omnibus uses the block form of
+      # the logger, this method handles both types of logging.
+      #
+      # @example
+      #   output = capture_logging { some_command }
+      #   expect(output).to include('whatever')
+      #
+      def capture_logging
+        original = Omnibus.logger
+        Omnibus.logger = TestLogger.new
+        yield
+        Omnibus.logger.output
+      ensure
+        Omnibus.logger = original
+      end
+
+      class TestLogger < Logger
+        def initialize(*)
+          super(StringIO.new)
+          @level = -1
+        end
+
+        def output
+          io.string
+        end
+      end
+    end
+  end
+end

data/spec/support/matchers.rb

@@ -0,0 +1,36 @@
+require 'rspec/expectations'
+
+# expect('/path/to/directory').to be_a_directory
+RSpec::Matchers.define :be_a_directory do
+  match do |actual|
+    File.directory?(actual)
+  end
+end
+
+# expect('/path/to/directory').to be_a_file
+RSpec::Matchers.define :be_a_file do
+  match do |actual|
+    File.file?(actual)
+  end
+end
+
+# expect('/path/to/directory').to be_a_symlink
+RSpec::Matchers.define :be_a_symlink do
+  match do |actual|
+    File.symlink?(actual)
+  end
+end
+
+# expect('/path/to/directory').to be_a_symlink_to
+RSpec::Matchers.define :be_a_symlink_to do |path|
+  match do |actual|
+    File.symlink?(actual) && File.readlink(actual) == path
+  end
+end
+
+# expect('/path/to/file').to be_an_executable
+RSpec::Matchers.define :be_an_executable do
+  match do |actual|
+    File.executable?(actual)
+  end
+end

data/spec/support/ohai_helpers.rb

@@ -0,0 +1,22 @@
+require 'fauxhai'
+require 'omnibus/ohai'
+
+module Omnibus
+  module RSpec
+    module OhaiHelpers
+      #
+      # Stub Ohai with the given data.
+      #
+      def stub_ohai(options = {}, &block)
+        ohai = Mash.from_hash(Fauxhai.mock(options, &block).data)
+        allow(Ohai).to receive(:ohai).and_return(ohai)
+
+        # If we asked for Windows, we should also specify that magical
+        # +File::ALT_SEPARATOR+ variable
+        if options[:platform] && options[:platform] == 'windows'
+          stub_const('File::ALT_SEPARATOR', '\\')
+        end
+      end
+    end
+  end
+end

data/spec/support/path_helpers.rb

@@ -0,0 +1,19 @@
+module Omnibus
+  module RSpec
+    module PathHelpers
+      def fixture_path(*pieces)
+        File.join(fixtures_path, *pieces)
+      end
+
+      def tmp_path
+        File.expand_path('../../tmp', __FILE__)
+      end
+
+      private
+
+      def fixtures_path
+        File.expand_path('../../fixtures', __FILE__)
+      end
+    end
+  end
+end

data/spec/support/shell_helpers.rb

@@ -0,0 +1,14 @@
+require 'mixlib/shellout'
+
+module Omnibus
+  module RSpec
+    module ShellHelpers
+      def shellout!(command, options = {})
+        cmd = Mixlib::ShellOut.new(command, options)
+        cmd.environment['HOME'] = '/tmp' unless ENV['HOME']
+        cmd.run_command
+        cmd
+      end
+    end
+  end
+end

data/spec/unit/build_version_dsl_spec.rb

@@ -1,20 +1,3 @@
-#
-# Copyright:: Copyright (c) 2014 Chef Software, Inc.
-# License:: Apache License, Version 2.0
-#
-# Licensed under the Apache License, Version 2.0 (the "License");
-# you may not use this file except in compliance with the License.
-# You may obtain a copy of the License at
-#
-#     http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
-#
-
 require 'spec_helper'
 
 module Omnibus

data/spec/unit/build_version_spec.rb

@@ -24,8 +24,7 @@ module Omnibus
         its(:prerelease_tag) { should be_nil }
         its(:git_sha_tag) { should be_nil }
         its(:commits_since_tag) { should == 0 }
-        its(:development_version?) { should be_truthy }
-        its(:prerelease_version?) { should be_falsey }
+        its(:prerelease_version?) { should be(false) }
       end
 
       # SemVer compliant prerelease version
@@ -35,7 +34,6 @@ module Omnibus
         its(:prerelease_tag) { should == 'alpha.2' }
         its(:git_sha_tag) { should be_nil }
         its(:commits_since_tag) { should == 0 }
-        its(:development_version?) { should be_falsey }
         its(:prerelease_version?) { should be_truthy }
       end
 
@@ -46,7 +44,6 @@ module Omnibus
         its(:prerelease_tag) { should == 'alpha.3' }
         its(:git_sha_tag) { should == 'f55b180' }
         its(:commits_since_tag) { should == 59 }
-        its(:development_version?) { should be_falsey }
         its(:prerelease_version?) { should be_truthy }
       end
 
@@ -59,7 +56,6 @@ module Omnibus
         its(:prerelease_tag) { should == 'rc.0' }
         its(:git_sha_tag) { should be_nil }
         its(:commits_since_tag) { should == 0 }
-        its(:development_version?) { should be_falsey }
         its(:prerelease_version?) { should be_truthy }
       end
 
@@ -70,7 +66,6 @@ module Omnibus
         its(:prerelease_tag) { should == 'alpha-2' }
         its(:git_sha_tag) { should be_nil }
         its(:commits_since_tag) { should == 0 }
-        its(:development_version?) { should be_falsey }
         its(:prerelease_version?) { should be_truthy }
       end
 
@@ -81,7 +76,6 @@ module Omnibus
         its(:prerelease_tag) { should == 'alpha-2' }
         its(:git_sha_tag) { should == 'f55b180' }
         its(:commits_since_tag) { should == 59 }
-        its(:development_version?) { should be_falsey }
         its(:prerelease_version?) { should be_truthy }
       end
 
@@ -92,7 +86,6 @@ module Omnibus
         its(:prerelease_tag) { should == 'alpha2' }
         its(:git_sha_tag) { should be_nil }
         its(:commits_since_tag) { should == 0 }
-        its(:development_version?) { should be_falsey }
         its(:prerelease_version?) { should be_truthy }
       end
     end
@@ -171,17 +164,6 @@ module Omnibus
       end
     end
 
-    describe 'deprecated full output' do
-      it 'generates a valid git describe version' do
-        expect(BuildVersion.full).to match(valid_git_describe_regex)
-      end
-
-      it 'outputs a deprecation message' do
-        output = capture_logging { BuildVersion.full }
-        expect(output).to include('DEPRECATED')
-      end
-    end
-
     describe '`git describe` command failure' do
       before do
         stderr = <<-STDERR

data/spec/unit/builder_spec.rb

@@ -12,54 +12,166 @@ module Omnibus
 
     subject { described_class.new(software) }
 
-    context 'DSL methods' do
+    describe '#command' do
+      it 'is a DSL method' do
+        expect(subject).to have_exposed_method(:command)
+      end
+    end
+
+    describe '#patch' do
+      it 'is a DSL method' do
+        expect(subject).to have_exposed_method(:patch)
+      end
+    end
+
+    describe '#workers' do
+      it 'is a DSL method' do
+        expect(subject).to have_exposed_method(:workers)
+      end
+    end
+
+    describe '#ruby' do
+      it 'is a DSL method' do
+        expect(subject).to have_exposed_method(:ruby)
+      end
+    end
+
+    describe '#gem' do
+      it 'is a DSL method' do
+        expect(subject).to have_exposed_method(:gem)
+      end
+    end
+
+    describe '#bundle' do
+      it 'is a DSL method' do
+        expect(subject).to have_exposed_method(:bundle)
+      end
+    end
+
+    describe '#block' do
+      it 'is a DSL method' do
+        expect(subject).to have_exposed_method(:block)
+      end
+    end
+
+    describe '#erb' do
+      it 'is a DSL method' do
+        expect(subject).to have_exposed_method(:erb)
+      end
+    end
+
+    describe '#mkdir' do
+      it 'is a DSL method' do
+        expect(subject).to have_exposed_method(:mkdir)
+      end
+    end
+
+    describe '#touch' do
+      it 'is a DSL method' do
+        expect(subject).to have_exposed_method(:touch)
+      end
+    end
+
+    describe '#delete' do
+      it 'is a DSL method' do
+        expect(subject).to have_exposed_method(:delete)
+      end
+    end
+
+    describe '#copy' do
+      it 'is a DSL method' do
+        expect(subject).to have_exposed_method(:copy)
+      end
+    end
+
+    describe '#move' do
+      it 'is a DSL method' do
+        expect(subject).to have_exposed_method(:move)
+      end
+    end
+
+    describe '#link' do
+      it 'is a DSL method' do
+        expect(subject).to have_exposed_method(:link)
+      end
+    end
+
+    describe '#sync' do
+      it 'is a DSL method' do
+        expect(subject).to have_exposed_method(:sync)
+      end
+    end
+
+    describe '#windows_safe_path' do
+      it 'is a DSL method' do
+        expect(subject).to have_exposed_method(:windows_safe_path)
+      end
+    end
+
+    describe '#project_dir' do
+      it 'is a DSL method' do
+        expect(subject).to have_exposed_method(:project_dir)
+      end
+    end
+
+    describe '#install_dir' do
+      it 'is a DSL method' do
+        expect(subject).to have_exposed_method(:install_dir)
+      end
+    end
+
+    describe '#make' do
       before do
-        allow(subject).to receive(:find_file).and_return([nil, '/path'])
-      end
-
-      it_behaves_like 'a cleanroom setter', :command, %|command 'echo "hello"'|
-      it_behaves_like 'a cleanroom setter', :patch, %|patch source: 'diff.patch'|
-      it_behaves_like 'a cleanroom getter', :workers
-      it_behaves_like 'a cleanroom getter', :max_build_jobs
-      it_behaves_like 'a cleanroom setter', :ruby, %|ruby '-e "puts"'|
-      it_behaves_like 'a cleanroom setter', :gem, %|gem 'install bacon'|
-      it_behaves_like 'a cleanroom setter', :bundle, %|bundle 'install'|
-      it_behaves_like 'a cleanroom setter', :block, <<-EOH.gsub(/^ {8}/, '')
-        block 'A named block' do
-          # Complex operation
+        allow(subject).to receive(:command)
+      end
+
+      context 'when :bin is present' do
+        it 'uses the custom bin' do
+          expect(subject).to receive(:command)
+            .with('/path/to/make', {})
+          subject.make(bin: '/path/to/make')
+        end
+      end
+
+      context 'when gmake is present' do
+        before do
+          allow(Omnibus).to receive(:which)
+            .with('gmake')
+            .and_return('/bin/gmake')
+        end
+
+        it 'uses gmake and sets MAKE=gmake' do
+          expect(subject).to receive(:command)
+            .with('gmake', env: { 'MAKE' => 'gmake' })
+          subject.make
+        end
+      end
+
+      context 'when gmake is not present' do
+        before do
+          allow(Omnibus).to receive(:which)
+            .and_return(nil)
+        end
+
+        it 'uses make' do
+          expect(subject).to receive(:command)
+            .with('make', {})
+          subject.make
         end
-      EOH
-      it_behaves_like 'a cleanroom setter', :erb,  <<-EOH.gsub(/^ {8}/, '')
-        erb source: 'template.erb',
-            dest: '/path/to/file',
-            vars: { a: 'b', c: 'd' }
-      EOH
-      it_behaves_like 'a cleanroom setter', :mkdir, %|mkdir 'path'|
-      it_behaves_like 'a cleanroom setter', :touch, %|touch 'file'|
-      it_behaves_like 'a cleanroom setter', :delete, %|delete 'file'|
-      it_behaves_like 'a cleanroom setter', :copy, %|copy 'file', 'file2'|
-      it_behaves_like 'a cleanroom setter', :move, %|move 'file', 'file2'|
-      it_behaves_like 'a cleanroom setter', :link, %|link 'file', 'file2'|
-      it_behaves_like 'a cleanroom setter', :sync, %|sync 'a/', 'b/'|
-      it_behaves_like 'a cleanroom getter', :project_root, %|puts project_root|
-      it_behaves_like 'a cleanroom getter', :windows_safe_path, %|puts windows_safe_path('foo')|
-
-      # From software
-      it_behaves_like 'a cleanroom getter', :project_dir
-      it_behaves_like 'a cleanroom getter', :install_dir
-    end
-
-    describe '#max_build_jobs' do
-      before { allow(subject).to receive(:workers).and_return(5) }
-
-      it 'prints a deprecation' do
-        output = capture_logging { subject.max_build_jobs }
-        expect(output).to include("Please use `workers' instead.")
-      end
-
-      it 'delegates to #workers' do
-        expect(subject).to receive(:workers).once
-        subject.max_build_jobs
+      end
+
+      it 'accepts 0 options' do
+        expect { subject.make }.to_not raise_error
+      end
+
+      it 'accepts an additional command string' do
+        expect { subject.make('install') }.to_not raise_error
+      end
+
+      it 'persists given options' do
+        expect(subject).to receive(:command)
+          .with(anything(), timeout: 3600)
+        subject.make(timeout: 3600)
       end
     end
   end

data/spec/unit/compressor_spec.rb

@@ -0,0 +1,45 @@
+require 'spec_helper'
+
+module Omnibus
+  describe Compressor do
+    describe '.for_current_system' do
+      context 'on Mac OS X' do
+        before { stub_ohai(platform: 'mac_os_x', version: '10.9.2') }
+
+        context 'when :dmg is activated' do
+          it 'prefers dmg' do
+            expect(described_class.for_current_system([:tgz, :dmg])).to eq(Compressor::DMG)
+          end
+        end
+
+        context 'when :dmg is not activated' do
+          it 'prefers tgz' do
+            expect(described_class.for_current_system([:tgz, :foo])).to eq(Compressor::TGZ)
+          end
+        end
+
+        context 'when nothing is given' do
+          it 'returns null' do
+            expect(described_class.for_current_system([])).to eq(Compressor::Null)
+          end
+        end
+      end
+
+      context 'on Ubuntu' do
+        before { stub_ohai(platform: 'ubuntu', version: '14.04') }
+
+        context 'when :tgz activated' do
+          it 'prefers tgz' do
+            expect(described_class.for_current_system([:tgz, :foo])).to eq(Compressor::TGZ)
+          end
+        end
+
+        context 'when nothing is given' do
+          it 'returns null' do
+            expect(described_class.for_current_system([])).to eq(Compressor::Null)
+          end
+        end
+      end
+    end
+  end
+end