omnibus 3.2.2 → 4.0.0.beta.1

data/spec/unit/fetchers/path_fetcher_spec.rb

@@ -0,0 +1,111 @@
+require 'spec_helper'
+
+module Omnibus
+  describe PathFetcher do
+    let(:source_path) { '/local/path' }
+    let(:project_dir) { '/project/dir' }
+
+    let(:software) do
+      double(Software,
+        name: 'software',
+        source: { path: source_path },
+        project_dir: project_dir,
+      )
+    end
+
+    subject { described_class.new(software) }
+
+    describe '#fetch_required?' do
+      context 'when the SHAs match' do
+        before do
+          allow(subject).to receive(:target_shasum).and_return('abcd1234')
+          allow(subject).to receive(:destination_shasum).and_return('abcd1234')
+        end
+
+        it 'returns false' do
+          expect(subject.fetch_required?).to be(false)
+        end
+      end
+
+      context 'when the SHAs do not match' do
+        before do
+          allow(subject).to receive(:target_shasum).and_return('abcd1234')
+          allow(subject).to receive(:destination_shasum).and_return('efgh5678')
+        end
+
+        it 'returns true' do
+          expect(subject.fetch_required?).to be_truthy
+        end
+      end
+    end
+
+    describe '#version_guid' do
+      it 'returns the path' do
+        expect(subject.version_guid).to eq("path:#{source_path}")
+      end
+    end
+
+    describe '#clean' do
+      before do
+        allow(FileUtils).to receive(:rm_rf)
+        allow(subject).to receive(:fetch)
+      end
+
+      context 'when the directory exists' do
+        before do
+          allow(File).to receive(:exist?).with(project_dir).and_return(true)
+        end
+
+        it 'removes the directory' do
+          expect(FileUtils).to receive(:rm_rf).with(project_dir).once
+          subject.clean
+        end
+
+        it 'returns true' do
+          expect(subject.clean).to be_truthy
+        end
+      end
+
+      context 'when the directory does not exist' do
+        before do
+          allow(File).to receive(:exist?).with(project_dir).and_return(false)
+        end
+
+        it 'does not remove the directory' do
+          expect(FileUtils).to_not receive(:rm_rf)
+          subject.clean
+        end
+
+        it 'returns false' do
+          expect(subject.clean).to be(false)
+        end
+      end
+    end
+
+    describe '#fetch' do
+      before do
+        allow(subject).to receive(:create_required_directories)
+        allow(FileSyncer).to receive(:sync)
+      end
+
+      it 'copies the new files over' do
+        expect(FileSyncer).to receive(:sync).with(source_path, project_dir)
+        subject.fetch
+      end
+    end
+
+    describe '#version_for_cache' do
+      let(:shasum) { 'abcd1234' }
+
+      before do
+        allow(subject).to receive(:digest_directory)
+          .with(project_dir, :sha256)
+          .and_return(shasum)
+      end
+
+      it 'returns the shasum of the project_dir' do
+        expect(subject.version_for_cache).to eq("path:#{source_path}|shasum:#{shasum}")
+      end
+    end
+  end
+end

data/spec/unit/generator_spec.rb

@@ -0,0 +1,137 @@
+require 'spec_helper'
+
+module Omnibus
+  describe Generator do
+    let(:generator_out) { StringIO.new }
+    let(:generator_err) { StringIO.new }
+
+    before do
+      allow_any_instance_of(Thor::Shell::Basic).to receive(:stdout)
+        .and_return(generator_out)
+      allow_any_instance_of(Thor::Shell::Basic).to receive(:stdout)
+        .and_return(generator_err)
+    end
+
+    let(:structure) do
+      Dir.glob("#{tmp_path}/**/*", File::FNM_DOTMATCH)
+        .sort
+        .reject { |path| %w(. ..).include?(File.basename(path)) }
+        .map { |path| path.sub("#{tmp_path}/", '') }
+    end
+
+    context 'with no arguments' do
+      it 'generates the proper file structure' do
+        Generator.new(['name'], path: tmp_path).invoke_all
+
+        expect(structure).to eq(%w(
+          omnibus-name
+          omnibus-name/.gitignore
+          omnibus-name/.kitchen.local.yml
+          omnibus-name/.kitchen.yml
+          omnibus-name/Berksfile
+          omnibus-name/Gemfile
+          omnibus-name/README.md
+          omnibus-name/config
+          omnibus-name/config/projects
+          omnibus-name/config/projects/name.rb
+          omnibus-name/config/software
+          omnibus-name/config/software/name-zlib.rb
+          omnibus-name/omnibus.rb
+          omnibus-name/package-scripts
+          omnibus-name/package-scripts/name
+          omnibus-name/package-scripts/name/postinst
+          omnibus-name/package-scripts/name/postrm
+          omnibus-name/package-scripts/name/preinst
+          omnibus-name/package-scripts/name/prerm
+        ))
+      end
+    end
+
+    context 'with the --bff-assets flag' do
+      it 'generates the proper file structure' do
+        Generator.new(['name'], path: tmp_path, bff_assets: true).invoke_all
+
+        expect(structure).to include(*%w(
+          omnibus-name/resources/bff/gen.template.erb
+          omnibus-name/resources/bff/postinstall.sh
+          omnibus-name/resources/bff/unpostinstall.sh
+        ))
+      end
+    end
+
+    context 'with the --deb-assets flag' do
+      it 'generates the proper file structure' do
+        Generator.new(['name'], path: tmp_path, deb_assets: true).invoke_all
+
+        expect(structure).to include(*%w(
+          omnibus-name/resources/deb/conffiles.erb
+          omnibus-name/resources/deb/control.erb
+          omnibus-name/resources/deb/md5sums.erb
+        ))
+      end
+    end
+
+    context 'with the --dmg-assets flag' do
+      it 'generates the proper file structure' do
+        Generator.new(['name'], path: tmp_path, dmg_assets: true).invoke_all
+
+        expect(structure).to include(*%w(
+          omnibus-name/resources/dmg/background.png
+          omnibus-name/resources/dmg/icon.png
+        ))
+      end
+    end
+
+    context 'with the --makeself-assets flag' do
+      it 'generates the proper file structure' do
+        Generator.new(['name'], path: tmp_path, makeself_assets: true).invoke_all
+
+        expect(structure).to include(*%w(
+          omnibus-name/resources/makeself/post_extract.sh.erb
+        ))
+      end
+    end
+
+    context 'with the --msi-assets flag' do
+      it 'generates the proper file structure' do
+        Generator.new(['name'], path: tmp_path, msi_assets: true).invoke_all
+
+        expect(structure).to include(*%w(
+          omnibus-name/resources/msi/assets/LICENSE.rtf
+          omnibus-name/resources/msi/assets/banner_background.bmp
+          omnibus-name/resources/msi/assets/dialog_background.bmp
+          omnibus-name/resources/msi/assets/project.ico
+          omnibus-name/resources/msi/assets/project_16x16.ico
+          omnibus-name/resources/msi/assets/project_32x32.ico
+          omnibus-name/resources/msi/localization-en-us.wxl.erb
+          omnibus-name/resources/msi/parameters.wxi.erb
+          omnibus-name/resources/msi/source.wxs.erb
+        ))
+      end
+    end
+
+    context 'with the --pkg-assets flag' do
+      it 'generates the proper file structure' do
+        Generator.new(['name'], path: tmp_path, pkg_assets: true).invoke_all
+
+        expect(structure).to include(*%w(
+          omnibus-name/resources/pkg/background.png
+          omnibus-name/resources/pkg/license.html.erb
+          omnibus-name/resources/pkg/welcome.html.erb
+        ))
+      end
+    end
+
+    context 'with the --rpm-assets flag' do
+      it 'generates the proper file structure' do
+        Generator.new(['name'], path: tmp_path, rpm_assets: true).invoke_all
+
+        expect(structure).to include(*%w(
+          omnibus-name/resources/rpm/rpmmacros.erb
+          omnibus-name/resources/rpm/signing.erb
+          omnibus-name/resources/rpm/spec.erb
+        ))
+      end
+    end
+  end
+end

data/spec/unit/git_cache_spec.rb

@@ -2,53 +2,43 @@ require 'spec_helper'
 
 module Omnibus
   describe GitCache do
-    before do
-      allow(IO).to receive(:read).and_call_original
-    end
-
     let(:project) do
-      allow(IO).to receive(:read)
-        .with('/path/to/demo.rb')
-        .and_return <<-EOH.gsub(/^ {10}/, '')
-          name 'demo'
-          install_dir '/opt/demo'
+      Project.new('/path/to/demo.rb').evaluate do
+        name 'demo'
+        install_dir '/opt/demo'
 
-          build_version '1.0.0'
+        build_version '1.0.0'
 
-          maintainer 'Chef Software, Inc'
-          homepage 'http://getchef.com'
+        maintainer 'Chef Software, Inc'
+        homepage 'http://getchef.com'
 
-          dependency 'preparation'
-          dependency 'snoopy'
-          dependency 'zlib'
-        EOH
-
-      Project.load('/path/to/demo.rb')
+        dependency 'preparation'
+        dependency 'snoopy'
+        dependency 'zlib'
+      end
     end
 
     let(:install_dir) { project.install_dir }
 
-    let(:zlib_config) { File.join(RSpec::SPEC_DATA, 'software', 'zlib.rb') }
-
     let(:zlib) do
-      software = Software.new(project, {}, zlib_config)
-      software.name('zlib')
-      software.default_version('1.7.2')
-      software
+      Software.new(project, 'zlib.rb').evaluate do
+        name 'zlib'
+        default_version '1.7.2'
+      end
     end
 
     let(:snoopy) do
-      software = Software.new(project, {}, 'snoopy.rb')
-      software.name('snoopy')
-      software.default_version('1.0.0')
-      software
+      Software.new(project, 'snoopy.rb').evaluate do
+        name 'snoopy'
+        default_version '1.0.0'
+      end
     end
 
     let(:preparation) do
-      software = Software.new(project, {}, 'preparation.rb')
-      software.name('preparation')
-      software.default_version('1.0.0')
-      software
+      Software.new(project, 'preparation.rb').evaluate do
+        name 'preparation'
+        default_version '1.0.0'
+      end
     end
 
     let(:cache_path) { File.join('/var/cache/omnibus/cache/git_cache', install_dir) }
@@ -68,7 +58,7 @@ module Omnibus
 
     describe '#tag' do
       it 'returns the correct tag' do
-        expect(ipc.tag).to eql('zlib-cd7af52fa55e629e79960ba744e4b8a00913a330903489c36a86b6432f1ba8ba')
+        expect(ipc.tag).to eql('zlib-24a8ec71da04059dcf7ed3c6e8e0fd9d155476abe4b5156d1f13c42e85478c2b')
       end
 
       describe 'with no deps' do
@@ -77,7 +67,7 @@ module Omnibus
         end
 
         it 'returns the correct tag' do
-          expect(ipc.tag).to eql('zlib-89bac4cbe2ebae5e75b67ef88ef8d91289c0b655f130fef57b580fc05a83c686')
+          expect(ipc.tag).to eql('zlib-ee71fc1a512f03b9dd46c1fd9b5ab71fcc51b638857bf328496a31abb2654c2b')
         end
       end
     end

data/spec/unit/library_spec.rb

@@ -6,8 +6,8 @@ module Omnibus
     # Helper method for generating a fake software definition.
     #
     def generate_software(name, version, dependencies = [])
-      software = Software.new(project, {}, "#{name}.rb")
-      software.name(name.to_s)
+      software = Software.new(project, "#{name}.rb")
+      software.name(name)
       software.version(version)
 
       dependencies.each do |dependency|
@@ -17,7 +17,24 @@ module Omnibus
       software
     end
 
-    let(:project) { Project.load(project_path('chefdk')) }
+    let(:project) do
+      Project.new.evaluate do
+        name          'chef-dk'
+        maintainer    'Chef Software, Inc'
+        homepage      'http://getchef.com'
+        build_version '1.0.0'
+
+        install_dir '/opt/chefdk'
+
+        dependency 'preparation'
+        dependency 'erchef'
+        dependency 'postgresql'
+        dependency 'ruby'
+        dependency 'chef'
+        dependency 'chefdk'
+      end
+    end
+
     let(:library) { Library.new(project) }
 
     let(:bundler)     { generate_software('bundler', '1.5.4') }
@@ -52,26 +69,6 @@ module Omnibus
     end
 
     describe '#build_order' do
-      let(:project) do
-        allow(IO).to receive(:read)
-          .with('/chef-server.rb')
-          .and_return <<-EOH.gsub(/^ {12}/, '')
-            name          'chef-server'
-            maintainer    'Chef Software, Inc'
-            homepage      'http://getchef.com'
-            build_version '1.0.0'
-
-            install_dir '/opt/chef-server'
-
-            dependency 'preparation'
-            dependency 'erchef'
-            dependency 'postgresql'
-            dependency 'chef'
-          EOH
-
-        Project.load('/chef-server.rb')
-      end
-
       let(:library) do
         library = Library.new(project)
         library.component_added(preparation)
@@ -99,28 +96,6 @@ module Omnibus
       context 'with a complex dep tree' do
         let(:chefdk) { generate_software('chefdk', '1.0.0.alpha', %w(bundler ruby)) }
 
-        let(:project) do
-          allow(IO).to receive(:read)
-            .with('/chefdk.rb')
-            .and_return <<-EOH.gsub(/^ {12}/, '')
-              name          'chef-dk'
-              maintainer    'Chef Software, Inc'
-              homepage      'http://getchef.com'
-              build_version '1.0.0'
-
-              install_dir '/opt/chefdk'
-
-              dependency 'preparation'
-              dependency 'erchef'
-              dependency 'postgresql'
-              dependency 'ruby'
-              dependency 'chef'
-              dependency 'chefdk'
-            EOH
-
-          Project.load('/chefdk.rb')
-        end
-
         let(:library) do
           # This is the LOAD ORDER
           library = Library.new(project)
@@ -150,43 +125,7 @@ module Omnibus
               erchef, # project dep
               chef, # project dep
               chefdk, # project dep
-             ])
-        end
-      end
-
-      context 'with real data' do
-        before do
-          Config.project_root(complicated_path)
-
-          # Ohai stuff
-          stub_const('File::ALT_SEPARATOR', '\\')
-          stub_ohai(platform: 'windows', version: '2012')
-
-          Omnibus.process_dsl_files
-        end
-
-        let(:chefdk_windows) do
-          Omnibus.projects.find { |p| p.name.to_s == 'chefdk-windows' }
-        end
-
-        it 'has the right build order for chefdk-windows on windows' do
-          names = chefdk_windows.library.build_order.map { |m| m.name.to_s }
-          expect(names).to eql([
-            'preparation', # via project dep
-            'ruby-windows', # via libyaml-windows trans dep
-            'libyaml-windows', # via ruby-windows trans
-            'ruby-windows-devkit', # via trans dep from chef-windows
-            'bundler', # via trans dep from chef-windows
-            'cacerts', # via chef-windows
-            'chef-windows', # via transitive dep from chefdk
-            'nokogiri', # via test-kitchen
-            'test-kitchen', # via chefdk
-            'appbundler', # via chefdk
-            'berkshelf', # via chefdk
-            'chef-vault', # via chefdk
-            'chefdk', # via project dep
-            'chef-client-msi', # via top level dep
-          ])
+           ])
         end
       end
     end