omnibus 3.2.2 → 4.0.0.beta.1

data/spec/unit/compressors/base_spec.rb

@@ -0,0 +1,26 @@
+require 'stringio'
+
+module Omnibus
+  describe Compressor::Base do
+    let(:packager) { double(Packager::Base) }
+    let(:project)  { double(Project, packager: packager) }
+
+    describe '.initialize' do
+      subject { described_class.new(project) }
+
+      it 'sets the project' do
+        expect(subject.project).to eq(project)
+      end
+
+      it 'sets the packager' do
+        expect(subject.packager).to eq(packager)
+      end
+    end
+
+    subject { described_class.new(project) }
+
+    it 'inherits from Packager' do
+      expect(subject).to be_a(Packager::Base)
+    end
+  end
+end

data/spec/unit/compressors/dmg_spec.rb

@@ -0,0 +1,291 @@
+require 'spec_helper'
+
+module Omnibus
+  describe Compressor::DMG do
+    let(:project) do
+      Project.new.tap do |project|
+        project.name('project')
+        project.homepage('https://example.com')
+        project.install_dir('/opt/project')
+        project.build_version('1.2.3')
+        project.build_iteration('2')
+        project.maintainer('Chef Software')
+      end
+    end
+
+    subject { described_class.new(project) }
+
+    let(:project_root) { "#{tmp_path}/project/root" }
+    let(:package_dir)  { "#{tmp_path}/package/dir" }
+    let(:staging_dir)  { "#{tmp_path}/staging/dir" }
+
+    before do
+      allow(project).to receive(:packager)
+        .and_return(Packager::PKG.new(project))
+
+      Config.project_root(project_root)
+      Config.package_dir(package_dir)
+
+      allow(subject).to receive(:staging_dir)
+        .and_return(staging_dir)
+      create_directory(staging_dir)
+
+      allow(subject).to receive(:shellout!)
+    end
+
+    describe '#window_bounds' do
+      it 'is a DSL method' do
+        expect(subject).to have_exposed_method(:window_bounds)
+      end
+
+      it 'has a default value' do
+        expect(subject.window_bounds).to eq('100, 100, 750, 600')
+      end
+    end
+
+    describe '#pkg_position' do
+      it 'is a DSL method' do
+        expect(subject).to have_exposed_method(:pkg_position)
+      end
+
+      it 'has a default value' do
+        expect(subject.pkg_position).to eq('535, 50')
+      end
+    end
+
+    describe '#id' do
+      it 'is :dmg' do
+        expect(subject.id).to eq(:dmg)
+      end
+    end
+
+    describe '#resources_dir' do
+      it 'is nested inside the staging_dir' do
+        expect(subject.resources_dir).to eq("#{staging_dir}/Resources")
+      end
+    end
+
+    describe '#clean_disks' do
+      it 'logs a message' do
+        allow(subject).to receive(:shellout!)
+          .and_return(double(Mixlib::ShellOut, stdout: ''))
+
+        output = capture_logging { subject.clean_disks }
+        expect(output).to include('Cleaning previously mounted disks')
+      end
+    end
+
+    describe '#create_writable_dmg' do
+      it 'logs a message' do
+        output = capture_logging { subject.create_writable_dmg }
+        expect(output).to include('Creating writable dmg')
+      end
+
+      it 'runs the hdiutil command' do
+        expect(subject).to receive(:shellout!)
+          .with <<-EOH.gsub(/^ {12}/, '')
+            hdiutil create \\
+              -srcfolder "#{staging_dir}/Resources" \\
+              -volname "Project" \\
+              -fs HFS+ \\
+              -fsargs "-c c=64,a=16,e=16" \\
+              -format UDRW \\
+              -size 512000k \\
+              "#{staging_dir}/project-writable.dmg"
+          EOH
+
+        subject.create_writable_dmg
+      end
+    end
+
+    describe '#attach_dmg' do
+      before do
+        allow(subject).to receive(:shellout!)
+          .and_return(shellout)
+      end
+
+      let(:shellout) { double(Mixlib::ShellOut, stdout: "hello\n") }
+
+      it 'logs a message' do
+        output = capture_logging { subject.attach_dmg }
+        expect(output).to include('Attaching dmg as disk')
+      end
+
+      it 'runs the hdiutil command' do
+        expect(subject).to receive(:shellout!)
+          .with <<-EOH.gsub(/^ {12}/, '')
+            hdiutil attach \\
+              -readwrite \\
+              -noverify \\
+              -noautoopen \\
+              "#{staging_dir}/project-writable.dmg" | egrep '^/dev/' | sed 1q | awk '{print $1}'
+          EOH
+
+        subject.attach_dmg
+      end
+
+      it 'returns the stripped stdout' do
+        expect(subject.attach_dmg).to eq('hello')
+      end
+    end
+
+    describe '#set_volume_icon' do
+      it 'logs a message' do
+        output = capture_logging { subject.set_volume_icon }
+        expect(output).to include('Setting volume icon')
+      end
+
+      it 'runs the sips commands' do
+        icon = subject.resource_path('icon.png')
+
+        expect(subject).to receive(:shellout!)
+          .with <<-EOH.gsub(/^ {12}/, '')
+            # Generate the icns
+            mkdir tmp.iconset
+            sips -z 16 16     #{icon} --out tmp.iconset/icon_16x16.png
+            sips -z 32 32     #{icon} --out tmp.iconset/icon_16x16@2x.png
+            sips -z 32 32     #{icon} --out tmp.iconset/icon_32x32.png
+            sips -z 64 64     #{icon} --out tmp.iconset/icon_32x32@2x.png
+            sips -z 128 128   #{icon} --out tmp.iconset/icon_128x128.png
+            sips -z 256 256   #{icon} --out tmp.iconset/icon_128x128@2x.png
+            sips -z 256 256   #{icon} --out tmp.iconset/icon_256x256.png
+            sips -z 512 512   #{icon} --out tmp.iconset/icon_256x256@2x.png
+            sips -z 512 512   #{icon} --out tmp.iconset/icon_512x512.png
+            sips -z 1024 1024 #{icon} --out tmp.iconset/icon_512x512@2x.png
+            iconutil -c icns tmp.iconset
+
+            # Copy it over
+            cp tmp.icns "/Volumes/Project/.VolumeIcon.icns"
+
+            # Source the icon
+            SetFile -a C "/Volumes/Project"
+          EOH
+
+        subject.set_volume_icon
+      end
+    end
+
+    describe '#prettify_dmg' do
+      it 'logs a message' do
+        output = capture_logging { subject.prettify_dmg }
+        expect(output).to include('Making the dmg all pretty and stuff')
+      end
+
+      it 'renders the apple script template' do
+        subject.prettify_dmg
+        expect("#{staging_dir}/create_dmg.osascript").to be_a_file
+      end
+
+      it 'has the correct content' do
+        subject.prettify_dmg
+        contents = File.read("#{staging_dir}/create_dmg.osascript")
+
+        expect(contents).to include('tell application "Finder"')
+        expect(contents).to include('  tell disk "Project"')
+        expect(contents).to include('    open')
+        expect(contents).to include('    set current view of container window to icon view')
+        expect(contents).to include('    set toolbar visible of container window to false')
+        expect(contents).to include('    set statusbar visible of container window to false')
+        expect(contents).to include('    set the bounds of container window to {100, 100, 750, 600}')
+        expect(contents).to include('    set theViewOptions to the icon view options of container window')
+        expect(contents).to include('    set arrangement of theViewOptions to not arranged')
+        expect(contents).to include('    set icon size of theViewOptions to 72')
+        expect(contents).to include('    set background picture of theViewOptions to file ".support:background.png"')
+        expect(contents).to include('    delay 5')
+        expect(contents).to include('    set position of item "project-1.2.3-2.pkg" of container window to {535, 50}')
+        expect(contents).to include('    update without registering applications')
+        expect(contents).to include('    delay 5')
+        expect(contents).to include('  end tell')
+        expect(contents).to include('end tell')
+      end
+
+      it 'runs the apple script' do
+        expect(subject).to receive(:shellout!)
+          .with <<-EOH.gsub(/^ {12}/, '')
+            osascript "#{staging_dir}/create_dmg.osascript"
+          EOH
+
+        subject.prettify_dmg
+      end
+    end
+
+    describe '#compress_dmg' do
+      it 'logs a message' do
+        output = capture_logging { subject.compress_dmg }
+        expect(output).to include('Compressing dmg')
+      end
+
+      it 'runs the magical command series' do
+        device = '/dev/sda1'
+        subject.instance_variable_set(:@device, device)
+
+        expect(subject).to receive(:shellout!)
+          .with <<-EOH.gsub(/^ {12}/, '')
+            chmod -Rf go-w /Volumes/Project
+            sync
+            hdiutil detach "#{device}"
+            hdiutil convert \\
+              "#{staging_dir}/project-writable.dmg" \\
+              -format UDZO \\
+              -imagekey \\
+              zlib-level=9 \\
+              -o "#{package_dir}/project-1.2.3-2.dmg"
+            rm -rf "#{staging_dir}/project-writable.dmg"
+          EOH
+
+        subject.compress_dmg
+      end
+    end
+
+    describe '#set_dmg_icon' do
+      it 'logs a message' do
+        output = capture_logging { subject.set_dmg_icon }
+        expect(output).to include('Setting dmg icon')
+      end
+
+      it 'runs the sips commands' do
+        icon = subject.resource_path('icon.png')
+
+        expect(subject).to receive(:shellout!)
+          .with <<-EOH.gsub(/^ {12}/, '')
+            # Convert the png to an icon
+            sips -i "#{icon}"
+
+            # Extract the icon into its own resource
+            DeRez -only icns "#{icon}" > tmp.rsrc
+
+            # Append the icon reosurce to the DMG
+            Rez -append tmp.rsrc -o "#{package_dir}/project-1.2.3-2.dmg"
+
+            # Source the icon
+            SetFile -a C "#{package_dir}/project-1.2.3-2.dmg"
+          EOH
+
+        subject.set_dmg_icon
+      end
+    end
+
+    describe '#package_name' do
+      it 'includes the name, version, and build iteration' do
+        expect(subject.package_name).to eq('project-1.2.3-2.dmg')
+      end
+    end
+
+    describe '#writable_dmg' do
+      it 'is in the staging_dir' do
+        expect(subject.writable_dmg).to include(staging_dir)
+      end
+
+      it 'is project-writable' do
+        expect(subject.writable_dmg).to include('project-writable.dmg')
+      end
+    end
+
+    describe '#volume_name' do
+      it 'is the project friendly_name' do
+        project.friendly_name('Friendly Bacon Bits')
+        expect(subject.volume_name).to eq('Friendly Bacon Bits')
+      end
+    end
+  end
+end

data/spec/unit/compressors/null_spec.rb

@@ -0,0 +1,23 @@
+require 'spec_helper'
+
+module Omnibus
+  describe Compressor::Null do
+    let(:packager) { double(Packager::Base) }
+    let(:project)  { double(Project, packager: packager) }
+
+    subject { described_class.new(project) }
+
+    describe '#id' do
+      it 'is :dmg' do
+        expect(subject.id).to eq(:null)
+      end
+    end
+
+    describe '#run!' do
+      it 'does nothing' do
+        expect(subject).to_not receive(:instance_eval)
+        subject.run!
+      end
+    end
+  end
+end

data/spec/unit/compressors/tgz_spec.rb

@@ -0,0 +1,67 @@
+require 'spec_helper'
+
+module Omnibus
+  describe Compressor::TGZ do
+    let(:project) do
+      Project.new.tap do |project|
+        project.name('project')
+        project.homepage('https://example.com')
+        project.install_dir('/opt/project')
+        project.build_version('1.2.3')
+        project.build_iteration('2')
+        project.maintainer('Chef Software')
+      end
+    end
+
+    subject { described_class.new(project) }
+
+    let(:project_root) { "#{tmp_path}/project/root" }
+    let(:package_dir)  { "#{tmp_path}/package/dir" }
+    let(:staging_dir)  { "#{tmp_path}/staging/dir" }
+
+    before do
+      create_directory(project_root)
+      create_directory(package_dir)
+      create_directory(staging_dir)
+
+      allow(project).to receive(:packager)
+        .and_return(Packager::PKG.new(project))
+
+      Config.project_root(project_root)
+      Config.package_dir(package_dir)
+
+      allow(subject).to receive(:staging_dir)
+        .and_return(staging_dir)
+
+      allow(subject).to receive(:shellout!)
+    end
+
+    describe '#package_name' do
+      it 'returns the name of the packager' do
+        expect(subject.package_name).to eq('project-1.2.3-2.pkg.tar.gz')
+      end
+    end
+
+    describe '#write_tgz' do
+      before do
+        File.open("#{staging_dir}/project-1.2.3-2.pkg", 'wb') do |f|
+          f.write " "*1_000_000
+        end
+      end
+
+      it 'generates the file' do
+        subject.write_tgz
+        expect("#{staging_dir}/project-1.2.3-2.pkg.tar.gz").to be_a_file
+      end
+
+      it 'has the correct content' do
+        subject.write_tgz
+        file = File.open("#{staging_dir}/project-1.2.3-2.pkg.tar.gz", 'rb')
+        contents = file.read
+        file.close
+
+        expect(contents).to include("\x1F\x8B\b\x00".force_encoding('ASCII-8BIT'))
+      end
+    end
+  end
+end

data/spec/unit/config_spec.rb

@@ -31,40 +31,52 @@ module Omnibus
     include_examples 'a configurable', :base_dir, '/var/cache/omnibus'
     include_examples 'a configurable', :cache_dir, '/var/cache/omnibus/cache'
     include_examples 'a configurable', :git_cache_dir, '/var/cache/omnibus/cache/git_cache'
-    include_examples 'a configurable', :install_path_cache_dir, '/var/cache/omnibus/cache/git_cache'
     include_examples 'a configurable', :source_dir, '/var/cache/omnibus/src'
     include_examples 'a configurable', :build_dir, '/var/cache/omnibus/build'
     include_examples 'a configurable', :package_dir, '/var/cache/omnibus/pkg'
-    include_examples 'a configurable', :package_tmp, '/var/cache/omnibus/pkg-tmp'
     include_examples 'a configurable', :project_root, Dir.pwd
-    include_examples 'a configurable', :build_dmg, true
-    include_examples 'a configurable', :dmg_window_bounds, '100, 100, 750, 600'
-    include_examples 'a configurable', :dmg_pkg_position, '535, 50'
-    include_examples 'a configurable', :override_file, nil
     include_examples 'a configurable', :local_software_dirs, []
-    include_examples 'a configurable', :software_gem, ['omnibus-software']
     include_examples 'a configurable', :software_gems, ['omnibus-software']
     include_examples 'a configurable', :solaris_compiler, nil
     include_examples 'a configurable', :append_timestamp, true
-    include_examples 'a configurable', :build_retries, 3
+    include_examples 'a configurable', :build_retries, 0
     include_examples 'a configurable', :use_git_caching, true
 
-    context 'on Windows' do
-      before do
-        stub_ohai(platform: 'windows', version: '2012')
+    describe '#workers' do
+      context 'when the Ohai data is not present' do
+        before do
+          stub_ohai(platform: 'ubuntu', version: '12.04') do |data|
+            data['cpu'] = nil
+          end
+        end
+
+        it 'defaults to 3' do
+          expect(described_class.workers).to eq(3)
+        end
+      end
+
+      context 'when the Ohai data is present' do
+        before do
+          stub_ohai(platform: 'ubuntu', version: '12.04') do |data|
+            data['cpu'] = { 'total' => '5' }
+          end
+        end
 
-        # This is not defined on Linuxy Rubies
-        stub_const('File::ALT_SEPARATOR', '\\')
+        it 'defaults to the value + 6' do
+          expect(described_class.workers).to eq(6)
+        end
       end
+    end
+
+    context 'on Windows' do
+      before { stub_ohai(platform: 'windows', version: '2012') }
 
       include_examples 'a configurable', :base_dir, 'C:/omnibus-ruby'
       include_examples 'a configurable', :cache_dir, 'C:/omnibus-ruby/cache'
       include_examples 'a configurable', :git_cache_dir, 'C:/omnibus-ruby/cache/git_cache'
-      include_examples 'a configurable', :install_path_cache_dir, 'C:/omnibus-ruby/cache/git_cache'
       include_examples 'a configurable', :source_dir, 'C:/omnibus-ruby/src'
       include_examples 'a configurable', :build_dir, 'C:/omnibus-ruby/build'
       include_examples 'a configurable', :package_dir, 'C:/omnibus-ruby/pkg'
-      include_examples 'a configurable', :package_tmp, 'C:/omnibus-ruby/pkg-tmp'
     end
 
     context 'when base_dir is changed' do
@@ -72,28 +84,9 @@ module Omnibus
 
       include_examples 'a configurable', :cache_dir, '/foo/bar/cache'
       include_examples 'a configurable', :git_cache_dir, '/foo/bar/cache/git_cache'
-      include_examples 'a configurable', :install_path_cache_dir, '/foo/bar/cache/git_cache'
       include_examples 'a configurable', :source_dir, '/foo/bar/src'
       include_examples 'a configurable', :build_dir, '/foo/bar/build'
       include_examples 'a configurable', :package_dir, '/foo/bar/pkg'
-      include_examples 'a configurable', :package_tmp, '/foo/bar/pkg-tmp'
-    end
-
-    context '#install_path_cache_dir' do
-      it 'is deprecated' do
-        expect(Omnibus.logger).to receive(:deprecated).with('Config')
-        described_class.install_path_cache_dir
-      end
-
-      it 'defaults to #git_cache_dir' do
-        expect(described_class.install_path_cache_dir).to eq(described_class.git_cache_dir)
-      end
-
-      it 'overrides the value of #git_cache_dir when specified' do
-        path = '/magical/path/with/ponies'
-        described_class.install_path_cache_dir(path)
-        expect(described_class.git_cache_dir).to eq(path)
-      end
     end
   end
 end