mongoid 8.1.4 → 9.0.0

data/spec/mongoid/monkey_patches_spec.rb

@@ -0,0 +1,211 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+# @note This test ensures that we do not inadvertently introduce new monkey patches
+# to Mongoid. Existing monkey patch methods which are marked with +Mongoid.deprecated+
+# are excluded from this test.
+RSpec.describe('Do not add monkey patches') do # rubocop:disable RSpec/DescribeClass
+  classes = [
+    Object,
+    Array,
+    BigDecimal,
+    Date,
+    DateTime,
+    FalseClass,
+    Float,
+    Hash,
+    Integer,
+    Module,
+    NilClass,
+    Range,
+    Regexp,
+    Set,
+    String,
+    Symbol,
+    Time,
+    TrueClass,
+    ActiveSupport::TimeWithZone,
+    BSON::Binary,
+    BSON::Decimal128,
+    BSON::ObjectId,
+    BSON::Regexp,
+    BSON::Regexp::Raw
+  ]
+
+  expected_instance_methods = {
+    Object => %i[
+      __add__
+      __add_from_array__
+      __array__
+      __deep_copy__
+      __evolve_object_id__
+      __expand_complex__
+      __intersect__
+      __intersect_from_array__
+      __intersect_from_object__
+      __mongoize_object_id__
+      __union__
+      __union_from_object__
+      ivar
+      mongoize
+      numeric?
+      remove_ivar
+      resizable?
+      substitutable
+    ],
+    Array => %i[
+      __evolve_date__
+      __evolve_time__
+      __mongoize_time__
+      __sort_option__
+      __sort_pair__
+      delete_one
+    ],
+    Date => %i[
+      __evolve_date__
+      __evolve_time__
+      __mongoize_time__
+    ],
+    DateTime => %i[
+      __evolve_date__
+      __evolve_time__
+      __mongoize_time__
+    ],
+    FalseClass => %i[is_a?],
+    Float => %i[
+      __evolve_date__
+      __evolve_time__
+      __mongoize_time__
+    ],
+    Hash => %i[
+      __sort_option__
+    ],
+    Integer => %i[
+      __evolve_date__
+      __evolve_time__
+      __mongoize_time__
+    ],
+    Module => %i[
+      re_define_method
+    ],
+    NilClass => %i[
+      __evolve_date__
+      __evolve_time__
+      __expanded__
+      __override__
+      collectionize
+    ],
+    Range => %i[
+      __evolve_date__
+      __evolve_range__
+      __evolve_time__
+    ],
+    String => %i[
+      __evolve_date__
+      __evolve_time__
+      __expr_part__
+      __mongo_expression__
+      __mongoize_time__
+      __sort_option__
+      before_type_cast?
+      collectionize
+      reader
+      valid_method_name?
+      writer?
+    ],
+    Symbol => %i[
+      __expr_part__
+      add_to_set
+      all
+      asc
+      ascending
+      avg
+      desc
+      descending
+      elem_match
+      eq
+      exists
+      first
+      gt
+      gte
+      in
+      intersects_line
+      intersects_point
+      intersects_polygon
+      last
+      lt
+      lte
+      max
+      min
+      mod
+      ne
+      near
+      near_sphere
+      nin
+      not
+      push
+      sum
+      with_size
+      with_type
+      within_box
+      within_polygon
+    ],
+    TrueClass => %i[is_a?],
+    Time => %i[
+      __evolve_date__
+      __evolve_time__
+      __mongoize_time__
+    ],
+    ActiveSupport::TimeWithZone => %i[
+      __evolve_date__
+      __evolve_time__
+      __mongoize_time__
+      _bson_to_i
+    ],
+    BSON::Decimal128 => %i[
+      __evolve_decimal128__
+    ]
+  }.each_value(&:sort!)
+
+  expected_class_methods = {
+    Object => %i[
+      demongoize
+      evolve
+      re_define_method
+    ],
+    Float => %i[__numeric__],
+    Integer => %i[__numeric__],
+    String => %i[__expr_part__],
+    Symbol => %i[add_key]
+  }.each_value(&:sort!)
+
+  def mongoid_method?(method)
+    method.source_location&.first&.include?('/lib/mongoid/')
+  end
+
+  def added_instance_methods(klass)
+    methods = klass.instance_methods.select { |m| mongoid_method?(klass.instance_method(m)) }
+    methods -= added_instance_methods(Object) unless klass == Object
+    methods.sort
+  end
+
+  def added_class_methods(klass)
+    methods = klass.methods.select { |m| mongoid_method?(klass.method(m)) }
+    methods -= added_instance_methods(Object)
+    methods -= added_class_methods(Object) unless klass == Object
+    methods.sort
+  end
+
+  classes.each do |klass|
+    context klass.name do
+      it 'adds no unexpected instance methods' do
+        expect(added_instance_methods(klass)).to eq(expected_instance_methods[klass] || [])
+      end
+
+      it 'adds no unexpected class methods' do
+        expect(added_class_methods(klass)).to eq(expected_class_methods[klass] || [])
+      end
+    end
+  end
+end

data/spec/mongoid/persistable/creatable_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 require "spec_helper"
 

data/spec/mongoid/persistable/deletable_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 require "spec_helper"
 
@@ -11,35 +12,15 @@ describe Mongoid::Persistable::Deletable do
     end
 
     context "when deleting a readonly document" do
-
-      context "when legacy_attributes is true" do
-        config_override :legacy_readonly, true
-
-        let(:from_db) do
-          Person.only(:_id).first
-        end
-
-        it "raises an error" do
-          expect(from_db.readonly?).to be true
-          expect {
-            from_db.delete
-          }.to raise_error(Mongoid::Errors::ReadonlyDocument)
-        end
+      let(:from_db) do
+        Person.first.tap(&:readonly!)
       end
 
-      context "when legacy_attributes is false" do
-        config_override :legacy_readonly, false
-
-        let(:from_db) do
-          Person.first.tap(&:readonly!)
-        end
-
-        it "raises an error" do
-          expect(from_db.readonly?).to be true
-          expect {
-            from_db.delete
-          }.to raise_error(Mongoid::Errors::ReadonlyDocument)
-        end
+      it "raises an error" do
+        expect(from_db.readonly?).to be true
+        expect {
+          from_db.delete
+        }.to raise_error(Mongoid::Errors::ReadonlyDocument)
       end
     end
 
@@ -57,7 +38,7 @@ describe Mongoid::Persistable::Deletable do
       end
     end
 
-    context "when removing a root document" do
+    context "when deleting a root document" do
 
       let!(:deleted) do
         person.delete
@@ -76,9 +57,28 @@ describe Mongoid::Persistable::Deletable do
       it "resets the flagged for destroy flag" do
         expect(person).to_not be_flagged_for_destroy
       end
+
+      context 'when :persist option false' do
+
+        let!(:deleted) do
+          person.delete(persist: false)
+        end
+
+        it "does not delete the document from the collection" do
+          expect(Person.find(person.id)).to eq person
+        end
+
+        it "returns true" do
+          expect(deleted).to be true
+        end
+
+        it "does not set the flagged for destroy flag" do
+          expect(person).to_not be_flagged_for_destroy
+        end
+      end
     end
 
-    context "when removing an embedded document" do
+    context "when deleting an embedded document" do
 
       let(:address) do
         person.addresses.build(street: "Bond Street")
@@ -114,13 +114,60 @@ describe Mongoid::Persistable::Deletable do
           Person.find(person.id)
         end
 
-        it "removes the object from the parent and database" do
+        it "removes the object from the parent" do
+          expect(person.addresses).to be_empty
+        end
+
+        it "removes the object from the database" do
+          expect(from_db.addresses).to be_empty
+        end
+      end
+
+      context 'when :persist option false' do
+
+        before do
+          address.save!
+          address.delete(persist: false)
+        end
+
+        let(:from_db) do
+          Person.find(person.id)
+        end
+
+        it "does not remove the object from the parent" do
+          expect(person.addresses).to eq [address]
+          expect(person.addresses.first).to_not be_flagged_for_destroy
+        end
+
+        it "does not remove the object from the database" do
+          expect(from_db.addresses).to eq [address]
+          expect(from_db.addresses.first).to_not be_flagged_for_destroy
+        end
+      end
+
+      context 'when :suppress option true' do
+
+        before do
+          address.save!
+          address.delete(suppress: true)
+        end
+
+        let(:from_db) do
+          Person.find(person.id)
+        end
+
+        it "does not remove the object from the parent" do
+          expect(person.addresses).to eq [address]
+          expect(person.addresses.first).to_not be_flagged_for_destroy
+        end
+
+        it "removes the object from the database" do
           expect(from_db.addresses).to be_empty
         end
       end
     end
 
-    context "when removing deeply embedded documents" do
+    context "when deleting deeply embedded documents" do
 
       context "when the document has been saved" do