mongoid 8.1.4 → 9.0.0

data/spec/mongoid/config/introspection_spec.rb

@@ -0,0 +1,114 @@
+# frozen_string_literal: true
+# rubocop:todo all
+
+require "spec_helper"
+
+describe Mongoid::Config::Introspection do
+
+  context "CONFIG_RB_PATH" do
+    it "refers to an actual source file" do
+      expect(File.exist?(Mongoid::Config::Introspection::CONFIG_RB_PATH)).to be true
+    end
+  end
+
+  context "#options" do
+    let(:options) { Mongoid::Config::Introspection.options }
+    let(:all_options) { Mongoid::Config::Introspection.options(include_deprecated: true) }
+    let(:deprecated_options) { all_options.select(&:deprecated?) }
+
+    # NOTE: the "with deprecated options" context tests a configuration option
+    # that is known to be deprecated (see `let(:option_name)`). When this
+    # deprecated option is eventually removed, the "exclude" spec will break.
+    # At that time, update the `:option_name` helper to reference a different
+    # deprecated option (if any), or else skip the specs in this context.
+    context "with deprecated options" do
+      let(:option_name) { "background_indexing" }
+
+      it "should exclude deprecated options by default" do
+        option = options.detect { |opt| opt.name == option_name }
+        expect(option).to be_nil
+      end
+
+      it "deprecated options should be included when requested" do
+        option = all_options.detect { |opt| opt.name == option_name }
+        expect(option).not_to be_nil
+      end
+    end
+
+    Mongoid::Config.defaults.each do |name, default_value|
+      context "for the `#{name}` option" do
+        let(:option) { all_options.detect { |opt| opt.name == name.to_s } }
+        let(:live_option) { options.detect { |opt| opt.name == name.to_s } }
+
+        it "should be parsed by the introspection scraper" do
+          expect(option).not_to be_nil
+          expect(option.default).to be == default_value.inspect
+          expect(option.comment.strip).not_to be_empty
+        end
+
+        it "should be excluded by default if it is deprecated" do
+          if option.deprecated?
+            expect(live_option).to be_nil
+          else
+            expect(live_option).to be == option
+          end
+        end
+      end
+    end
+  end
+
+  describe Mongoid::Config::Introspection::Option do
+    let(:option) do
+      Mongoid::Config::Introspection::Option.new(
+        "name", "default", "   # line 1\n    # line 2\n")
+    end
+
+    context ".from_captures" do
+      it "populates the option's fields" do
+        option = Mongoid::Config::Introspection::Option.from_captures([nil, "# comment", "name", "default"])
+        expect(option.name).to be == "name"
+        expect(option.default).to be == "default"
+        expect(option.comment).to be == "# comment"
+      end
+    end
+
+    context "#initialize" do
+      it "unindents the given comment" do
+        expect(option.name).to be == "name"
+        expect(option.default).to be == "default"
+        expect(option.comment).to be == "# line 1\n# line 2"
+      end
+    end
+
+    context "#indented_comment" do
+      it "has defaults" do
+        expect(option.indented_comment).to be == "# line 1\n  # line 2"
+      end
+
+      it "allows indentation to be specified" do
+        expect(option.indented_comment(indent: 3)).to be == "# line 1\n   # line 2"
+      end
+
+      it "allows the first line to be indented" do
+        expect(option.indented_comment(indent: 3, indent_first_line: true))
+          .to be == "   # line 1\n   # line 2"
+      end
+    end
+
+    context "#deprecated?" do
+      let(:deprecated_option) do
+        Mongoid::Config::Introspection::Option.new(
+          "name", "default", "# this\n# is (Deprecated), yo\n")
+      end
+
+      it "is not deprecated by default" do
+        expect(option.deprecated?).not_to be true
+      end
+
+      it "is deprecated when the comment includes \"(Deprecated)\"" do
+        expect(deprecated_option.deprecated?).to be true
+      end
+    end
+  end
+
+end

data/spec/mongoid/config/options_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 require "spec_helper"
 

data/spec/mongoid/config_spec.rb

@@ -1,15 +1,11 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 require "spec_helper"
+require "support/feature_sandbox"
 
 describe Mongoid::Config do
 
-  after(:all) do
-    if defined?(RailsTemp)
-      Rails = RailsTemp
-    end
-  end
-
   after do
     Mongoid.configure do |config|
       config.load_configuration(CONFIG)
@@ -70,11 +66,6 @@ describe Mongoid::Config do
   context "when the log level is not set in the configuration" do
 
     before do
-      if defined?(Rails)
-        RailsTemp = Rails unless defined?(RailsTemp)
-        Object.send(:remove_const, :Rails)
-      end
-
       Mongoid.configure do |config|
         config.load_configuration(CONFIG)
       end
@@ -354,99 +345,22 @@ describe Mongoid::Config do
     it_behaves_like "a config option"
   end
 
-  context 'when setting the broken_updates option in the config' do
-    let(:option) { :broken_updates }
-    let(:default) { false }
-
-    it_behaves_like "a config option"
-  end
-
-  context 'when setting the legacy_triple_equals option in the config' do
-    let(:option) { :legacy_triple_equals }
-    let(:default) { false }
-
-    it_behaves_like "a config option"
-  end
-
-  context 'when setting the broken_scoping option in the config' do
-    let(:option) { :broken_scoping }
-    let(:default) { false }
-
-    it_behaves_like "a config option"
-  end
-
-  context 'when setting the broken_aggregables option in the config' do
-    let(:option) { :broken_aggregables }
-    let(:default) { false }
-
-    it_behaves_like "a config option"
-  end
-
-  context 'when setting the broken_alias_handling option in the config' do
-    let(:option) { :broken_alias_handling }
-    let(:default) { false }
-
-    it_behaves_like "a config option"
-  end
-
-  context 'when setting the broken_and option in the config' do
-    let(:option) { :broken_and }
-    let(:default) { false }
-
-    it_behaves_like "a config option"
-  end
-
-  context 'when setting the compare_time_by_ms option in the config' do
-    let(:option) { :compare_time_by_ms }
-    let(:default) { true }
-
-    it_behaves_like "a config option"
-  end
-
-  context 'when setting the object_id_as_json_oid option in the config' do
-    let(:option) { :object_id_as_json_oid }
-    let(:default) { false }
-
-    it_behaves_like "a config option"
-  end
-
-  context 'when setting the legacy_pluck_distinct option in the config' do
-    let(:option) { :legacy_pluck_distinct }
-    let(:default) { false }
-
-    it_behaves_like "a config option"
-  end
-
-  context 'when setting the overwrite_chained_operators option in the config' do
-    let(:option) { :overwrite_chained_operators }
+  context 'when setting the legacy_readonly option in the config' do
+    let(:option) { :legacy_readonly }
     let(:default) { false }
 
     it_behaves_like "a config option"
   end
 
-  context 'when setting the legacy_attributes option in the config' do
-    let(:option) { :legacy_attributes }
+  context 'when setting the legacy_persistence_context_behavior option in the config' do
+    let(:option) { :legacy_persistence_context_behavior }
     let(:default) { false }
 
     it_behaves_like "a config option"
   end
 
-  context 'when setting the legacy_readonly option in the config' do
-    let(:option) { :legacy_readonly }
-    let(:default) { true }
-
-    it_behaves_like "a config option"
-  end
-
   describe "#load!" do
 
-    before(:all) do
-      if defined?(Rails)
-        RailsTemp = Rails
-        Object.send(:remove_const, :Rails)
-      end
-    end
-
     let(:file) do
       File.join(File.dirname(__FILE__), "..", "config", "mongoid.yml")
     end
@@ -487,20 +401,12 @@ describe Mongoid::Config do
 
       context "when in a Rails environment" do
 
-        before do
-          module Rails
-            def self.logger
-              ::Logger.new($stdout)
-            end
-          end
-          Mongoid.logger = Rails.logger
-          described_class.load!(file, :test)
-        end
-
-        after do
-          if defined?(Rails)
-            RailsTemp = Rails unless defined?(RailsTemp)
-            Object.send(:remove_const, :Rails)
+        around do |example|
+          FeatureSandbox.quarantine do
+            require "support/rails_mock"
+            Mongoid.logger = Rails.logger
+            described_class.load!(file, :test)
+            example.run
           end
         end
 
@@ -545,10 +451,6 @@ describe Mongoid::Config do
         expect(described_class.raise_not_found_error).to be true
       end
 
-      it "sets the use activesupport time zone option" do
-        expect(described_class.use_activesupport_time_zone).to be true
-      end
-
       it "sets the use utc option" do
         expect(described_class.use_utc).to be false
       end
@@ -629,10 +531,6 @@ describe Mongoid::Config do
           expect(described_class.raise_not_found_error).to be true
         end
 
-        it "sets the use activesupport time zone option" do
-          expect(described_class.use_activesupport_time_zone).to be true
-        end
-
         it "sets the use utc option" do
           expect(described_class.use_utc).to be false
         end
@@ -691,22 +589,22 @@ describe Mongoid::Config do
           {
             auto_encryption_options: {
               'key_vault_namespace' => 'admin.datakeys',
-              'kms_providers' => { 'local' => { 'key' => 'z7iYiYKLuYymEWtk4kfny1ESBwwFdA58qMqff96A8ghiOcIK75lJGPUIocku8LOFjQuEgeIP4xlln3s7r93FV9J5sAE7zg8U' } },
-              'schema_map' => { 'blog_development.comments' => {
+              'kms_providers' => {'local' => {'key' => 'z7iYiYKLuYymEWtk4kfny1ESBwwFdA58qMqff96A8ghiOcIK75lJGPUIocku8LOFjQuEgeIP4xlln3s7r93FV9J5sAE7zg8U'}},
+              'schema_map' => {'blog_development.comments' => {
                 'bsonType' => 'object',
                 'properties' => {
-                  'message' => { 'encrypt' => {
+                  'message' => {'encrypt' => {
                     'algorithm' => 'AEAD_AES_256_CBC_HMAC_SHA_512-Deterministic',
                     'bsonType' => 'string',
                     'keyId' => [BSON::Binary.new("G\xF0 5\xCC@HX\xA2%b\x97\xA9a\xA8\xE7", :uuid)],
-                  } },
+                  }},
                 },
-              } } },
+              }}},
             database: 'mongoid_test',
             platform: "mongoid-#{Mongoid::VERSION}",
             wrapping_libraries: [
-              { 'name' => 'Mongoid', 'version' => Mongoid::VERSION },
-            ],
+              {'name' => 'Mongoid', 'version' => Mongoid::VERSION},
+            ]
           }
         )
 
@@ -949,18 +847,7 @@ describe Mongoid::Config do
   end
 
   describe 'deprecations' do
-    { use_activesupport_time_zone: true,
-      broken_aggregables: false,
-      broken_alias_handling: false,
-      broken_and: false,
-      broken_scoping: false,
-      broken_updates: false,
-      compare_time_by_ms: true,
-      legacy_attributes: false,
-      legacy_pluck_distinct: false,
-      legacy_triple_equals: false,
-      object_id_as_json_oid: false,
-      overwrite_chained_operators: false }.each do |option, default|
+    {}.each do |option, default|
 
       context ":#{option} option" do
 

data/spec/mongoid/contextual/aggregable/memory_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 require "spec_helper"
 

data/spec/mongoid/contextual/aggregable/memory_table_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 require "spec_helper"
 

data/spec/mongoid/contextual/aggregable/mongo_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 require "spec_helper"
 
@@ -165,22 +166,9 @@ describe Mongoid::Contextual::Aggregable::Mongo do
           expect(aggregates["min"]).to be_nil
         end
 
-        context "when broken_aggregables feature flag is not set" do
-          config_override :broken_aggregables, false
-
-          it "returns a sum" do
-            expect(aggregates["sum"]).to eq 0
-          end
-        end
-
-        context "when broken_aggregables feature flag is set" do
-          config_override :broken_aggregables, true
-
-          it "returns nil" do
-            expect(aggregates["sum"]).to be_nil
-          end
+        it "returns a sum" do
+          expect(aggregates["sum"]).to eq 0
         end
-
       end
 
       context "when the field sometimes exists" do
@@ -251,20 +239,8 @@ describe Mongoid::Contextual::Aggregable::Mongo do
           context.aggregates(:non_existent)
         end
 
-        context "when broken_aggregables feature flag is not set" do
-          config_override :broken_aggregables, false
-
-          it "returns empty result" do
-            expect(aggregates).to eq({ "count" => 0, "sum" => 0, "avg" => nil, "min" => nil, "max" => nil })
-          end
-        end
-
-        context "when broken_aggregables feature flag is set" do
-          config_override :broken_aggregables, true
-
-          it "returns empty result" do
-            expect(aggregates).to eq({ "count" => 0, "sum" => nil, "avg" => nil, "min" => nil, "max" => nil })
-          end
+        it "returns empty result" do
+          expect(aggregates).to eq({ "count" => 0, "sum" => 0, "avg" => nil, "min" => nil, "max" => nil })
         end
       end
     end

data/spec/mongoid/contextual/aggregable/none_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 require "spec_helper"
 
@@ -23,20 +24,8 @@ describe Mongoid::Contextual::Aggregable::None do
       expect(context.sum).to eq(0)
     end
 
-    context "when broken_aggregables feature flag is not set" do
-      config_override :broken_aggregables, false
-
-      it "returns zero when arg given" do
-        expect(context.sum(:likes)).to eq(0)
-      end
-    end
-
-    context "when broken_aggregables feature flag is set" do
-      config_override :broken_aggregables, true
-
-      it "returns the input when arg given" do
-        expect(context.sum(:likes)).to eq(:likes)
-      end
+    it "returns zero when arg given" do
+      expect(context.sum(:likes)).to eq(0)
     end
   end