mongoid 8.1.4 → 9.0.0

data/spec/mongoid/errors/invalid_storage_options_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 require "spec_helper"
 

data/spec/mongoid/errors/invalid_time_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 require "spec_helper"
 

data/spec/mongoid/errors/inverse_not_found_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 require "spec_helper"
 

data/spec/mongoid/errors/mixed_client_configuration_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 require "spec_helper"
 

data/spec/mongoid/errors/mixed_relations_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 require "spec_helper"
 

data/spec/mongoid/errors/mongoid_error_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 require 'spec_helper'
 
@@ -9,28 +10,14 @@ describe Mongoid::Errors::MongoidError do
   let(:options) { {} }
 
   before do
-    # JRuby 9.3 RUBY_VERSION is set to 2.6.8, but the behavior matches Ruby 2.7.
-    # See https://github.com/jruby/jruby/issues/7184
-    if RUBY_VERSION >= '2.7' || (BSON::Environment.jruby? && JRUBY_VERSION >= '9.3')
-      {"message_title" => "message", "summary_title" => "summary", "resolution_title" => "resolution"}.each do |key, name|
-        expect(::I18n).to receive(:translate).with("mongoid.errors.messages.#{key}", **{}).and_return(name)
-      end
-
-      ["message", "summary", "resolution"].each do |name|
-        expect(::I18n).to receive(:translate).
-          with("mongoid.errors.messages.#{key}.#{name}", **{}).
-          and_return(name)
-      end
-    else
-      {"message_title" => "message", "summary_title" => "summary", "resolution_title" => "resolution"}.each do |key, name|
-        expect(::I18n).to receive(:translate).with("mongoid.errors.messages.#{key}", {}).and_return(name)
-      end
-
-      ["message", "summary", "resolution"].each do |name|
-        expect(::I18n).to receive(:translate).
-          with("mongoid.errors.messages.#{key}.#{name}", {}).
-          and_return(name)
-      end
+    {"message_title" => "message", "summary_title" => "summary", "resolution_title" => "resolution"}.each do |key, name|
+      expect(::I18n).to receive(:translate).with("mongoid.errors.messages.#{key}", **{}).and_return(name)
+    end
+
+    ["message", "summary", "resolution"].each do |name|
+      expect(::I18n).to receive(:translate).
+        with("mongoid.errors.messages.#{key}.#{name}", **{}).
+        and_return(name)
     end
 
     error.compose_message(key, options)

data/spec/mongoid/errors/nested_attributes_metadata_not_found_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 require "spec_helper"
 

data/spec/mongoid/errors/no_client_config_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 require "spec_helper"
 

data/spec/mongoid/errors/no_client_database_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 require "spec_helper"
 

data/spec/mongoid/errors/no_client_hosts_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 require "spec_helper"
 

data/spec/mongoid/errors/no_clients_config_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 require "spec_helper"
 

data/spec/mongoid/errors/no_environment_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 require "spec_helper"
 

data/spec/mongoid/errors/no_map_reduce_output_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 require "spec_helper"
 

data/spec/mongoid/errors/no_metadata_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 require 'spec_helper'
 

data/spec/mongoid/errors/no_parent_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 require "spec_helper"
 

data/spec/mongoid/errors/readonly_attribute_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 require "spec_helper"
 

data/spec/mongoid/errors/readonly_document_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 require "spec_helper"
 

data/spec/mongoid/errors/scope_overwrite_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 require "spec_helper"
 

data/spec/mongoid/errors/too_many_nested_attribute_records_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 require "spec_helper"
 

data/spec/mongoid/errors/unknown_attribute_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 require "spec_helper"
 

data/spec/mongoid/errors/unsaved_document_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 require "spec_helper"
 

data/spec/mongoid/errors/unsupported_javascript_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 require "spec_helper"
 

data/spec/mongoid/errors/validations_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 require "spec_helper"
 

data/spec/mongoid/extensions/array_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 require "spec_helper"
 
@@ -202,156 +203,6 @@ describe Mongoid::Extensions::Array do
     end
   end
 
-  describe ".__mongoize_fk__" do
-
-    context "when the related model uses object ids" do
-
-      let(:association) do
-        Person.relations["preferences"]
-      end
-
-      context "when provided an object id" do
-
-        let(:object_id) do
-          BSON::ObjectId.new
-        end
-
-        let(:fk) do
-          Array.__mongoize_fk__(association, object_id)
-        end
-
-        it "returns the object id as an array" do
-          expect(fk).to eq([ object_id ])
-        end
-      end
-
-      context "when provided a object ids" do
-
-        let(:object_id) do
-          BSON::ObjectId.new
-        end
-
-        let(:fk) do
-          Array.__mongoize_fk__(association, [ object_id ])
-        end
-
-        it "returns the object ids" do
-          expect(fk).to eq([ object_id ])
-        end
-      end
-
-      context "when provided a string" do
-
-        context "when the string is a legal object id" do
-
-          let(:object_id) do
-            BSON::ObjectId.new
-          end
-
-          let(:fk) do
-            Array.__mongoize_fk__(association, object_id.to_s)
-          end
-
-          it "returns the object id in an array" do
-            expect(fk).to eq([ object_id ])
-          end
-        end
-
-        context "when the string is not a legal object id" do
-
-          let(:string) do
-            "blah"
-          end
-
-          let(:fk) do
-            Array.__mongoize_fk__(association, string)
-          end
-
-          it "returns the string in an array" do
-            expect(fk).to eq([ string ])
-          end
-        end
-
-        context "when the string is blank" do
-
-          let(:fk) do
-            Array.__mongoize_fk__(association, "")
-          end
-
-          it "returns an empty array" do
-            expect(fk).to be_empty
-          end
-        end
-      end
-
-      context "when provided nil" do
-
-        let(:fk) do
-          Array.__mongoize_fk__(association, nil)
-        end
-
-        it "returns an empty array" do
-          expect(fk).to be_empty
-        end
-      end
-
-      context "when provided an array of strings" do
-
-        context "when the strings are legal object ids" do
-
-          let(:object_id) do
-            BSON::ObjectId.new
-          end
-
-          let(:fk) do
-            Array.__mongoize_fk__(association, [ object_id.to_s ])
-          end
-
-          it "returns the object id in an array" do
-            expect(fk).to eq([ object_id ])
-          end
-        end
-
-        context "when the strings are not legal object ids" do
-
-          let(:string) do
-            "blah"
-          end
-
-          let(:fk) do
-            Array.__mongoize_fk__(association, [ string ])
-          end
-
-          it "returns the string in an array" do
-            expect(fk).to eq([ string ])
-          end
-        end
-
-        context "when the strings are blank" do
-
-          let(:fk) do
-            Array.__mongoize_fk__(association, [ "", "" ])
-          end
-
-          it "returns an empty array" do
-            expect(fk).to be_empty
-          end
-        end
-      end
-
-      context "when provided nils" do
-
-        let(:fk) do
-          Array.__mongoize_fk__(association, [ nil, nil, nil ])
-        end
-
-        it "returns an empty array" do
-          expect(fk).to be_empty
-        end
-      end
-    end
-  end
-
   describe "#__mongoize_time__" do
 
     let(:array) do
@@ -362,8 +213,8 @@ describe Mongoid::Extensions::Array do
       array.__mongoize_time__
     end
 
-    context "when using active support's time zone" do
-      include_context 'using AS time zone'
+    context "when setting ActiveSupport time zone" do
+      include_context 'setting ActiveSupport time zone'
 
       # In AS time zone (could be different from Ruby time zone)
       let(:expected_time) { ::Time.zone.local(*array).in_time_zone }
@@ -375,44 +226,6 @@ describe Mongoid::Extensions::Array do
       it_behaves_like 'mongoizes to AS::TimeWithZone'
       it_behaves_like 'maintains precision when mongoized'
     end
-
-    context "when not using active support's time zone" do
-      include_context 'not using AS time zone'
-
-      # In Ruby time zone (could be different from AS time zone)
-      let(:expected_time) { ::Time.local(*array).in_time_zone }
-
-      it_behaves_like 'mongoizes to Time'
-      it_behaves_like 'maintains precision when mongoized'
-    end
-  end
-
-  describe "#blank_criteria?" do
-
-    context "when the array has an empty _id criteria" do
-
-      context "when only the id criteria is in the array" do
-
-        let(:array) do
-          [{ "_id" => { "$in" => [] }}]
-        end
-
-        it "is false" do
-          expect(array.blank_criteria?).to be false
-        end
-      end
-
-      context "when the id criteria is in the array with others" do
-
-        let(:array) do
-          [{ "_id" => "test" }, { "_id" => { "$in" => [] }}]
-        end
-
-        it "is false" do
-          expect(array.blank_criteria?).to be false
-        end
-      end
-    end
   end
 
   describe "#delete_one" do
@@ -542,78 +355,6 @@ describe Mongoid::Extensions::Array do
     end
   end
 
-  describe "#multi_arged?" do
-
-    context "when there are multiple elements" do
-
-      let(:array) do
-        [ 1, 2, 3 ]
-      end
-
-      it "returns true" do
-        expect(array).to be_multi_arged
-      end
-    end
-
-    context "when there is one element" do
-
-      context "when the element is a non enumerable" do
-
-        let(:array) do
-          [ 1 ]
-        end
-
-        it "returns false" do
-          expect(array).to_not be_multi_arged
-        end
-      end
-
-      context "when the element is resizable Hash instance" do
-
-        let(:array) do
-          [{'key' => 'value'}]
-        end
-
-        it "returns false" do
-          expect(array).to_not be_multi_arged
-        end
-      end
-
-      context "when the element is array of resizable Hash instances" do
-
-        let(:array) do
-          [[{'key1' => 'value2'},{'key1' => 'value2'}]]
-        end
-
-        it "returns true" do
-          expect(array).to be_multi_arged
-        end
-      end
-
-      context "when the element is an array" do
-
-        let(:array) do
-          [[ 1 ]]
-        end
-
-        it "returns true" do
-          expect(array).to be_multi_arged
-        end
-      end
-
-      context "when the element is a range" do
-
-        let(:array) do
-          [ 1..2 ]
-        end
-
-        it "returns true" do
-          expect(array).to be_multi_arged
-        end
-      end
-    end
-  end
-
   describe ".resizable?" do
 
     it "returns true" do

data/spec/mongoid/extensions/big_decimal_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 require "spec_helper"
 
@@ -123,7 +124,7 @@ describe Mongoid::Extensions::BigDecimal do
         end
 
         it "returns a float" do
-          expect(demongoized).to eq(value)
+          expect(demongoized).to be_within(0.00001).of(value)
         end
       end
 
@@ -283,8 +284,8 @@ describe Mongoid::Extensions::BigDecimal do
           expect(value).to be_a(ActiveSupport::Duration)
         end
 
-        it "returns nil" do
-          expect(mongoized).to eq(7200)
+        it "returns the casted value as a string" do
+          expect(mongoized).to eq("7200.0")
         end
       end
 
@@ -571,7 +572,7 @@ describe Mongoid::Extensions::BigDecimal do
         end
 
         it "returns a float" do
-          expect(demongoized).to eq(value)
+          expect(demongoized).to be_within(0.00001).of(value)
         end
       end
 

data/spec/mongoid/extensions/binary_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 require "spec_helper"
 

data/spec/mongoid/extensions/boolean_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 require "spec_helper"
 

data/spec/mongoid/extensions/date_class_mongoize_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 require "spec_helper"
 
@@ -27,7 +28,7 @@ describe Mongoid::Extensions::Date do
 
     context "when provided a string" do
       # This also configures a non-UTC time zone for AS which we want
-      include_context 'using AS time zone'
+      include_context 'setting ActiveSupport time zone'
 
       context "when the string is a valid date" do
 
@@ -120,7 +121,7 @@ describe Mongoid::Extensions::Date do
     end
 
     context "when provided a float" do
-      include_context 'using AS time zone'
+      include_context 'setting ActiveSupport time zone'
 
       let(:float) do
         time.to_f
@@ -160,7 +161,7 @@ describe Mongoid::Extensions::Date do
     end
 
     context "when provided an integer" do
-      include_context 'using AS time zone'
+      include_context 'setting ActiveSupport time zone'
 
       let(:integer) do
         time.to_i
@@ -200,7 +201,7 @@ describe Mongoid::Extensions::Date do
     end
 
     context "when provided a time" do
-      include_context 'using AS time zone'
+      include_context 'setting ActiveSupport time zone'
 
       let(:mongoized) do
         Date.mongoize(time)
@@ -236,7 +237,7 @@ describe Mongoid::Extensions::Date do
     end
 
     context "when provided an AS::TimeWithZone" do
-      include_context 'using AS time zone'
+      include_context 'setting ActiveSupport time zone'
 
       let(:mongoized) do
         Date.mongoize(time)
@@ -273,7 +274,7 @@ describe Mongoid::Extensions::Date do
     end
 
     context "when provided a DateTime" do
-      include_context 'using AS time zone'
+      include_context 'setting ActiveSupport time zone'
 
       let(:mongoized) do
         Date.mongoize(date_time)
@@ -310,7 +311,7 @@ describe Mongoid::Extensions::Date do
     end
 
     context "when provided an array" do
-      include_context 'using AS time zone'
+      include_context 'setting ActiveSupport time zone'
 
       let(:expected) do
         Time.utc(2010, 1, 1, 0, 0, 0)

data/spec/mongoid/extensions/date_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 require "spec_helper"
 
@@ -6,8 +7,8 @@ describe Mongoid::Extensions::Date do
 
   describe "__mongoize_time__" do
 
-    context "when using active support's time zone" do
-      include_context 'using AS time zone'
+    context "when setting ActiveSupport time zone" do
+      include_context 'setting ActiveSupport time zone'
 
       let(:date) do
         Date.new(2010, 1, 1)
@@ -23,24 +24,6 @@ describe Mongoid::Extensions::Date do
 
       it_behaves_like 'mongoizes to AS::TimeWithZone'
     end
-
-    context "when not using active support's time zone" do
-      include_context 'not using AS time zone'
-
-      let(:date) do
-        Date.new(2010, 1, 1)
-      end
-
-      let(:expected_time) do
-        Time.local(2010, 1, 1, 0, 0, 0, 0)
-      end
-
-      let(:mongoized) do
-        date.__mongoize_time__
-      end
-
-      it_behaves_like 'mongoizes to Time'
-    end
   end
 
   describe ".demongoize" do

data/spec/mongoid/extensions/date_time_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 require "spec_helper"
 
@@ -18,19 +19,12 @@ describe Mongoid::Extensions::DateTime do
 
     let(:expected_time) { date_time.to_time.in_time_zone }
 
-    context "when using active support's time zone" do
-      include_context 'using AS time zone'
+    context "when setting ActiveSupport time zone" do
+      include_context 'setting ActiveSupport time zone'
 
       it_behaves_like 'mongoizes to AS::TimeWithZone'
       it_behaves_like 'maintains precision when mongoized'
     end
-
-    context "when not using active support's time zone" do
-      include_context 'not using AS time zone'
-
-      it_behaves_like 'mongoizes to Time'
-      it_behaves_like 'maintains precision when mongoized'
-    end
   end
 
   describe ".demongoize" do

data/spec/mongoid/extensions/decimal128_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 require "spec_helper"