mongoid 8.1.4 → 9.0.0

data/spec/mongoid/contextual/mongo/documents_loader_spec.rb

@@ -1,11 +1,10 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 require "spec_helper"
+require 'concurrent-ruby'
 
 describe Mongoid::Contextual::Mongo::DocumentsLoader do
-  # https://jira.mongodb.org/browse/MONGOID-5505
-  require_mri
-
   let(:view) do
     double('view').tap do |view|
       allow(view).to receive(:map)
@@ -31,6 +30,10 @@ describe Mongoid::Contextual::Mongo::DocumentsLoader do
   end
 
   context 'state management' do
+    # Java does not allow creating a ThreadPoolExecutor with 0 max and
+    # min threads.
+    require_mri
+
     let(:executor) do
       # Such executor will never execute a task, so it guarantees that
       # our task will stay in its initial state.
@@ -103,6 +106,10 @@ describe Mongoid::Contextual::Mongo::DocumentsLoader do
     end
 
     context 'synchronously' do
+      # Java does not allow creating a ThreadPoolExecutor with 0 max and
+      # min threads.
+      require_mri
+
       let(:executor) do
         # Such executor will never execute a task, so it guarantees that
         # our task will stay in its initial state.

data/spec/mongoid/contextual/mongo_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 require "spec_helper"
 
@@ -137,7 +138,6 @@ describe Mongoid::Contextual::Mongo do
     end
 
     context 'when a collation is specified' do
-      min_server_version '3.4'
 
       let(:context) do
         described_class.new(criteria)
@@ -233,6 +233,34 @@ describe Mongoid::Contextual::Mongo do
         end
       end
     end
+
+    context "when including a default scope" do
+
+      let(:criteria) do
+        Band.where(name: "New Order")
+      end
+
+      before do
+        5.times { Band.create! }
+        Band.default_scope ->{ criteria }
+      end
+
+      after do
+        Band.default_scoping = nil
+      end
+
+      it 'raises an error' do
+        expect do
+          Band.estimated_count
+        end.to raise_error(Mongoid::Errors::InvalidEstimatedCountScoping)
+      end
+
+      it "does not raise an error on unscoped" do
+        expect do
+          expect(Band.unscoped.estimated_count).to eq(5)
+        end
+      end
+    end
   end
 
 
@@ -276,7 +304,6 @@ describe Mongoid::Contextual::Mongo do
         end
 
         context 'when the criteria has a collation' do
-          min_server_version '3.4'
 
           let(:criteria) do
             Band.where(name: "DEPECHE MODE").collation(locale: 'en_US', strength: 2)
@@ -381,7 +408,6 @@ describe Mongoid::Contextual::Mongo do
         end
 
         context 'when the criteria has a collation' do
-          min_server_version '3.4'
 
           let(:criteria) do
             Band.where(name: "DEPECHE MODE").collation(locale: 'en_US', strength: 2)
@@ -459,74 +485,70 @@ describe Mongoid::Contextual::Mongo do
       Band.create!(name: "10,000 Maniacs", years: 20, sales: "1E2")
     end
 
-    with_config_values :legacy_pluck_distinct, true, false do
-      context "when limiting the result set" do
-
-        let(:criteria) do
-          Band.where(name: "Depeche Mode")
-        end
+    context "when limiting the result set" do
 
-        let(:context) do
-          described_class.new(criteria)
-        end
+      let(:criteria) do
+        Band.where(name: "Depeche Mode")
+      end
 
-        it "returns the distinct matching fields" do
-          expect(context.distinct(:name)).to eq([ "Depeche Mode" ])
-        end
+      let(:context) do
+        described_class.new(criteria)
       end
 
-      context "when not limiting the result set" do
+      it "returns the distinct matching fields" do
+        expect(context.distinct(:name)).to eq([ "Depeche Mode" ])
+      end
+    end
 
-        let(:criteria) do
-          Band.criteria
-        end
+    context "when not limiting the result set" do
 
-        let(:context) do
-          described_class.new(criteria)
-        end
+      let(:criteria) do
+        Band.criteria
+      end
 
-        it "returns the distinct field values" do
-          expect(context.distinct(:name).sort).to eq([ "10,000 Maniacs", "Depeche Mode", "New Order" ].sort)
-        end
+      let(:context) do
+        described_class.new(criteria)
       end
 
-      context "when providing an aliased field" do
+      it "returns the distinct field values" do
+        expect(context.distinct(:name).sort).to eq([ "10,000 Maniacs", "Depeche Mode", "New Order" ].sort)
+      end
+    end
 
-        let(:criteria) do
-          Band.criteria
-        end
+    context "when providing an aliased field" do
 
-        let(:context) do
-          described_class.new(criteria)
-        end
+      let(:criteria) do
+        Band.criteria
+      end
 
-        it "returns the distinct field values" do
-          expect(context.distinct(:years).sort).to eq([ 20, 25, 30 ])
-        end
+      let(:context) do
+        described_class.new(criteria)
       end
 
-      context 'when a collation is specified' do
-        min_server_version '3.4'
+      it "returns the distinct field values" do
+        expect(context.distinct(:years).sort).to eq([ 20, 25, 30 ])
+      end
+    end
 
-        before do
-          Band.create!(name: 'DEPECHE MODE')
-        end
+    context 'when a collation is specified' do
+      before do
+        Band.create!(name: 'DEPECHE MODE')
+      end
 
-        let(:context) do
-          described_class.new(criteria)
-        end
+      let(:context) do
+        described_class.new(criteria)
+      end
 
-        let(:expected_results) do
-          ["10,000 Maniacs", "Depeche Mode", "New Order"]
-        end
+      let(:expected_results) do
+        ["10,000 Maniacs", "Depeche Mode", "New Order"]
+      end
 
-        let(:criteria) do
-          Band.where({}).collation(locale: 'en_US', strength: 2)
-        end
+      let(:criteria) do
+        Band.where({}).collation(locale: 'en_US', strength: 2)
+      end
 
-        it 'applies the collation' do
-          expect(context.distinct(:name).sort).to eq(expected_results.sort)
-        end
+      it 'applies the collation' do
+        expect(context.distinct(:name).sort).to eq(expected_results.sort)
       end
     end
 
@@ -539,34 +561,8 @@ describe Mongoid::Contextual::Mongo do
         described_class.new(criteria)
       end
 
-      context "when legacy_pluck_distinct is set" do
-        config_override :legacy_pluck_distinct, true
-
-        context 'when storing BigDecimal as string' do
-          config_override :map_big_decimal_to_decimal128, false
-
-          it "returns the non-demongoized distinct field values" do
-            expect(context.distinct(:sales).sort).to eq([ "1E2", "2E3" ])
-          end
-        end
-
-        context 'when storing BigDecimal as decimal128' do
-          config_override :map_big_decimal_to_decimal128, true
-          min_bson_version '4.15.0'
-          max_bson_version '4.99.99'
-
-          it "returns the non-demongoized distinct field values" do
-            expect(context.distinct(:sales).sort).to eq([ BSON::Decimal128.new("1E2"), BSON::Decimal128.new("2E3") ])
-          end
-        end
-      end
-
-      context "when legacy_pluck_distinct is not set" do
-        config_override :legacy_pluck_distinct, false
-
-        it "returns the non-demongoized distinct field values" do
-          expect(context.distinct(:sales).sort).to eq([ BigDecimal("1E2"), BigDecimal("2E3") ])
-        end
+      it "returns the non-demongoized distinct field values" do
+        expect(context.distinct(:sales).sort).to eq([ BigDecimal("1E2"), BigDecimal("2E3") ])
       end
     end
 
@@ -590,38 +586,14 @@ describe Mongoid::Contextual::Mongo do
       end
 
       context "when getting the field without _translations" do
-        context "when legacy_pluck_distinct is set" do
-          config_override :legacy_pluck_distinct, true
-
-          it "gets the full hash" do
-            expect(context.distinct(:description)).to eq([{ "de" => "deutsch-text", "en" => "english-text" }])
-          end
-        end
-
-        context "when legacy_pluck_distinct is not set" do
-          config_override :legacy_pluck_distinct, false
-
-          it "gets the demongoized localized field" do
-            expect(context.distinct(:description)).to eq([ 'deutsch-text' ])
-          end
+        it "gets the demongoized localized field" do
+          expect(context.distinct(:description)).to eq([ 'deutsch-text' ])
         end
       end
 
       context "when getting the field with _translations" do
-        context "when legacy_pluck_distinct is set" do
-          config_override :legacy_pluck_distinct, true
-
-          it "gets an empty list" do
-            expect(context.distinct(:description_translations)).to eq([])
-          end
-        end
-
-        context "when legacy_pluck_distinct is not set" do
-          config_override :legacy_pluck_distinct, false
-
-          it "gets the full hash" do
-            expect(context.distinct(:description_translations)).to eq([ { "de" => "deutsch-text", "en" => "english-text" } ])
-          end
+        it "gets the full hash" do
+          expect(context.distinct(:description_translations)).to eq([ { "de" => "deutsch-text", "en" => "english-text" } ])
         end
       end
 
@@ -631,20 +603,8 @@ describe Mongoid::Contextual::Mongo do
           context.distinct(:'description.de')
         end
 
-        context "when legacy_pluck_distinct is set" do
-          config_override :legacy_pluck_distinct, true
-
-          it 'returns the specific translation' do
-            expect(distinct).to eq([ 'deutsch-text' ])
-          end
-        end
-
-        context "when legacy_pluck_distinct is not set" do
-          config_override :legacy_pluck_distinct, false
-
-          it 'returns the specific translation' do
-            expect(distinct).to eq([ "deutsch-text" ])
-          end
+        it 'returns the specific translation' do
+          expect(distinct).to eq([ "deutsch-text" ])
         end
       end
 
@@ -654,20 +614,8 @@ describe Mongoid::Contextual::Mongo do
           context.distinct(:'description_translations.de')
         end
 
-        context "when legacy_pluck_distinct is set" do
-          config_override :legacy_pluck_distinct, true
-
-          it 'returns the empty list' do
-            expect(distinct).to eq([])
-          end
-        end
-
-        context "when legacy_pluck_distinct is not set" do
-          config_override :legacy_pluck_distinct, false
-
-          it 'returns the specific translations' do
-            expect(distinct).to eq(['deutsch-text'])
-          end
+        it 'returns the specific translations' do
+          expect(distinct).to eq(['deutsch-text'])
         end
       end
 
@@ -683,23 +631,11 @@ describe Mongoid::Contextual::Mongo do
           context.distinct(:description).first
         end
 
-        context "when legacy_pluck_distinct is set" do
-          config_override :legacy_pluck_distinct, true
-
-          it "does not correctly use the fallback" do
-            distinct.should == {"de"=>"deutsch-text", "en"=>"english-text"}
-          end
-        end
-
-        context "when legacy_pluck_distinct is not set" do
-          config_override :legacy_pluck_distinct, false
-
-          it "correctly uses the fallback" do
-            I18n.locale = :en
-            Dictionary.create!(description: 'english-text')
-            I18n.locale = :he
-            distinct.should == "english-text"
-          end
+        it "correctly uses the fallback" do
+          I18n.locale = :en
+          Dictionary.create!(description: 'english-text')
+          I18n.locale = :he
+          distinct.should == "english-text"
         end
       end
 
@@ -736,36 +672,16 @@ describe Mongoid::Contextual::Mongo do
           context.distinct("pass.name_translations.en").first
         end
 
-        context "when legacy_pluck_distinct is set" do
-          config_override :legacy_pluck_distinct, true
-
-          it "returns the full hash" do
-            expect(distinct).to eq({ "en" => "Neil", "he" => "Nissim" })
-          end
-
-          it "returns the empty hash" do
-            expect(distinct_translations).to eq(nil)
-          end
-
-          it "returns the empty hash" do
-            expect(distinct_translations_field).to eq(nil)
-          end
+        it "returns the translation for the current locale" do
+          expect(distinct).to eq("Nissim")
         end
 
-        context "when legacy_pluck_distinct is not set" do
-          config_override :legacy_pluck_distinct, false
-
-          it "returns the translation for the current locale" do
-            expect(distinct).to eq("Nissim")
-          end
-
-          it "returns the full _translation hash" do
-            expect(distinct_translations).to eq({ "en" => "Neil", "he" => "Nissim" })
-          end
+        it "returns the full _translation hash" do
+          expect(distinct_translations).to eq({ "en" => "Neil", "he" => "Nissim" })
+        end
 
-          it "returns the translation for the requested locale" do
-            expect(distinct_translations_field).to eq("Neil")
-          end
+        it "returns the translation for the requested locale" do
+          expect(distinct_translations_field).to eq("Neil")
         end
       end
     end
@@ -777,21 +693,8 @@ describe Mongoid::Contextual::Mongo do
       let(:criteria) { Band.where(_id: band.id) }
       let(:context) { described_class.new(criteria) }
 
-      context "when legacy_pluck_distinct is set" do
-        config_override :legacy_pluck_distinct, true
-        config_override :map_big_decimal_to_decimal128, true
-        max_bson_version '4.99.99'
-
-        it "returns the distinct matching fields" do
-          expect(context.distinct("label.sales")).to eq([ BSON::Decimal128.new('1E+2') ])
-        end
-      end
-
-      context "when legacy_pluck_distinct is not set" do
-        config_override :legacy_pluck_distinct, false
-        it "returns the distinct matching fields" do
-          expect(context.distinct("label.sales")).to eq([ BigDecimal("1E2") ])
-        end
+      it "returns the distinct matching fields" do
+        expect(context.distinct("label.sales")).to eq([ BigDecimal("1E2") ])
       end
     end
   end
@@ -1257,7 +1160,6 @@ describe Mongoid::Contextual::Mongo do
     end
 
     context 'when the criteria has a collation' do
-      min_server_version '3.4'
 
       let(:criteria) do
         Band.where(name: "DEPECHE MODE").collation(locale: 'en_US', strength: 2)
@@ -1714,7 +1616,6 @@ describe Mongoid::Contextual::Mongo do
       end
 
       context 'when a collation is specified on the criteria' do
-        min_server_version '3.4'
 
         let(:criteria) do
           Band.where(name: "DEPECHE MODE").collation(locale: 'en_US', strength: 2)
@@ -1868,7 +1769,6 @@ describe Mongoid::Contextual::Mongo do
       end
 
       context 'when a collation is specified on the criteria' do
-        min_server_version '3.4'
 
         let(:criteria) do
           Band.where(name: "DEPECHE MODE").collation(locale: 'en_US', strength: 2)
@@ -1943,7 +1843,6 @@ describe Mongoid::Contextual::Mongo do
       end
 
       context 'when a collation is specified on the criteria' do
-        min_server_version '3.4'
 
         let(:criteria) do
           Band.where(name: "DEPECHE MODE").collation(locale: 'en_US', strength: 2)
@@ -2020,7 +1919,6 @@ describe Mongoid::Contextual::Mongo do
         end
 
         context 'when the criteria has a collation' do
-          min_server_version '3.4'
 
           let(:criteria) do
             Band.where(name: "DEPECHE MODE").collation(locale: 'en_US', strength: 2)
@@ -2193,7 +2091,6 @@ describe Mongoid::Contextual::Mongo do
           end
 
           context 'when the criteria has a collation' do
-            min_server_version '3.4'
 
             let(:criteria) do
               Band.where(name: "DEPECHE MODE").collation(locale: 'en_US', strength: 2)
@@ -2366,7 +2263,6 @@ describe Mongoid::Contextual::Mongo do
       end
 
       context 'when the criteria has a collation' do
-        min_server_version '3.4'
 
         let(:criteria) do
           Band.where(name: "DEPECHE MODE").collation(locale: 'en_US', strength: 2)
@@ -2539,7 +2435,6 @@ describe Mongoid::Contextual::Mongo do
         end
 
         context 'when the criteria has a collation' do
-          min_server_version '3.4'
 
           let(:criteria) do
             Band.where(name: "DEPECHE MODE").collation(locale: 'en_US', strength: 2)
@@ -3588,7 +3483,6 @@ describe Mongoid::Contextual::Mongo do
     end
 
     context 'when provided array filters' do
-      min_server_version '3.6'
 
       before do
         Band.delete_all
@@ -3810,7 +3704,6 @@ describe Mongoid::Contextual::Mongo do
     end
 
     context 'when provided array filters' do
-      min_server_version '3.6'
 
       before do
         Band.delete_all

data/spec/mongoid/contextual/none_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 require "spec_helper"
 

data/spec/mongoid/copyable_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 require "spec_helper"
 

data/spec/mongoid/copyable_spec_models.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 module CopyableSpec
   class A