mongoid 7.3.5 → 7.4.0

data/spec/mongoid/interceptable_spec.rb

@@ -1,11 +1,18 @@
 # frozen_string_literal: true
-# encoding: utf-8
 
 require "spec_helper"
 require_relative './interceptable_spec_models'
 
 describe Mongoid::Interceptable do
 
+  before do
+    # The find and initialize callbacks I added were causing failures
+    # because they were causing updates when we were asserting no updates
+    # happened.
+    Label.reset_callbacks(:initialize)
+    Label.reset_callbacks(:find)
+  end
+
   class TestClass
     include Mongoid::Interceptable
 
@@ -78,7 +85,7 @@ describe Mongoid::Interceptable do
   describe ".after_find" do
 
     let!(:player) do
-      Player.create
+      Player.create!
     end
 
     context "when the callback is on a root document" do
@@ -131,7 +138,7 @@ describe Mongoid::Interceptable do
     context "when the callback is on an embedded document" do
 
       let!(:implant) do
-        player.implants.create
+        player.implants.create!
       end
 
       context "when when the document is instantiated" do
@@ -201,7 +208,7 @@ describe Mongoid::Interceptable do
           ]
         })
         book.id = '123'
-        book.save
+        book.save!
         book
       end
 
@@ -213,7 +220,7 @@ describe Mongoid::Interceptable do
         book.pages.each do | page |
           page.notes.destroy_all
           page.notes.new(message: new_message)
-          page.save
+          page.save!
         end
       end
 
@@ -276,7 +283,7 @@ describe Mongoid::Interceptable do
 
       before do
         expect(artist).to receive(:before_create_stub).once.and_return(true)
-        artist.save
+        artist.save!
       end
 
       it "gets saved" do
@@ -321,7 +328,7 @@ describe Mongoid::Interceptable do
         end
 
         it "the save returns true" do
-          expect(artist.save).to be true
+          expect(artist.save!).to be true
         end
       end
 
@@ -345,7 +352,7 @@ describe Mongoid::Interceptable do
     context "when updating" do
 
       let(:artist) do
-        Artist.create(name: "Depeche Mode").tap do |artist|
+        Artist.create!(name: "Depeche Mode").tap do |artist|
           artist.name = "The Mountain Goats"
         end
       end
@@ -361,7 +368,7 @@ describe Mongoid::Interceptable do
         end
 
         it "the save returns true" do
-          expect(artist.save).to be true
+          expect(artist.save!).to be true
         end
       end
 
@@ -386,7 +393,7 @@ describe Mongoid::Interceptable do
   describe ".before_destroy" do
 
     let(:artist) do
-      Artist.create(name: "Depeche Mode")
+      Artist.create!(name: "Depeche Mode")
     end
 
     before do
@@ -431,7 +438,7 @@ describe Mongoid::Interceptable do
       end
 
       let!(:record) do
-        moderat.records.create(name: "Moderat")
+        moderat.records.create!(name: "Moderat")
       end
 
       before do
@@ -545,7 +552,7 @@ describe Mongoid::Interceptable do
 
           it "does not cascade to the child" do
             Band.accepts_nested_attributes_for :records, allow_destroy: true
-            expect(band.update_attributes(attributes)).to be true
+            expect(band.update_attributes!(attributes)).to be true
           end
         end
       end
@@ -576,7 +583,7 @@ describe Mongoid::Interceptable do
 
           it "only executes the callbacks once for each embed" do
             expect(note).to receive(:update_saved).twice
-            band.save
+            band.save!
           end
         end
       end
@@ -585,7 +592,7 @@ describe Mongoid::Interceptable do
     context "when cascading after initialize" do
 
       let!(:person) do
-        Person.create
+        Person.create!
       end
 
       before do
@@ -624,7 +631,7 @@ describe Mongoid::Interceptable do
             end
 
             before do
-              band.save
+              band.save!
             end
 
             it "executes the callback" do
@@ -635,7 +642,7 @@ describe Mongoid::Interceptable do
           context "when the parent is persisted" do
 
             let(:band) do
-              Band.create(name: "Moderat")
+              Band.create!(name: "Moderat")
             end
 
             let!(:label) do
@@ -643,7 +650,7 @@ describe Mongoid::Interceptable do
             end
 
             before do
-              band.save
+              band.save!
             end
 
             it "executes the callback" do
@@ -655,7 +662,7 @@ describe Mongoid::Interceptable do
         context "when the child is persisted" do
 
           let(:band) do
-            Band.create(name: "Moderat")
+            Band.create!(name: "Moderat")
           end
 
           let!(:label) do
@@ -664,7 +671,7 @@ describe Mongoid::Interceptable do
 
           before do
             label.after_create_called = false
-            band.save
+            band.save!
           end
 
           it "does not execute the callback" do
@@ -688,7 +695,7 @@ describe Mongoid::Interceptable do
             end
 
             before do
-              band.save
+              band.save!
             end
 
             it "executes the callback" do
@@ -699,7 +706,7 @@ describe Mongoid::Interceptable do
           context "when the parent is persisted" do
 
             let(:band) do
-              Band.create(name: "Moderat")
+              Band.create!(name: "Moderat")
             end
 
             let!(:label) do
@@ -707,7 +714,7 @@ describe Mongoid::Interceptable do
             end
 
             before do
-              band.save
+              band.save!
             end
 
             it "executes the callback" do
@@ -719,7 +726,7 @@ describe Mongoid::Interceptable do
         context "when the child is persisted" do
 
           let(:band) do
-            Band.create(name: "Moderat")
+            Band.create!(name: "Moderat")
           end
 
           let!(:label) do
@@ -727,7 +734,7 @@ describe Mongoid::Interceptable do
           end
 
           before do
-            band.save
+            band.save!
           end
 
           it "executes the callback" do
@@ -751,7 +758,7 @@ describe Mongoid::Interceptable do
             end
 
             before do
-              band.save
+              band.save!
             end
 
             it "does not execute the callback" do
@@ -762,7 +769,7 @@ describe Mongoid::Interceptable do
           context "when the parent is persisted" do
 
             let(:band) do
-              Band.create(name: "Moderat")
+              Band.create!(name: "Moderat")
             end
 
             let!(:label) do
@@ -770,7 +777,7 @@ describe Mongoid::Interceptable do
             end
 
             before do
-              band.save
+              band.save!
             end
 
             it "does not execute the callback" do
@@ -782,7 +789,7 @@ describe Mongoid::Interceptable do
         context "when the child is persisted" do
 
           let(:band) do
-            Band.create(name: "Moderat")
+            Band.create!(name: "Moderat")
           end
 
           context "when the child is dirty" do
@@ -793,7 +800,7 @@ describe Mongoid::Interceptable do
 
             before do
               label.name = "Nothing"
-              band.save
+              band.save!
             end
 
             it "executes the callback" do
@@ -808,7 +815,7 @@ describe Mongoid::Interceptable do
             end
 
             before do
-              band.save
+              band.save!
             end
 
             it "does not execute the callback" do
@@ -833,7 +840,7 @@ describe Mongoid::Interceptable do
             end
 
             before do
-              band.save
+              band.save!
             end
 
             it "executes the callback" do
@@ -844,7 +851,7 @@ describe Mongoid::Interceptable do
           context "when the parent is persisted" do
 
             let(:band) do
-              Band.create(name: "Moderat")
+              Band.create!(name: "Moderat")
             end
 
             let!(:label) do
@@ -852,7 +859,7 @@ describe Mongoid::Interceptable do
             end
 
             before do
-              band.save
+              band.save!
             end
 
             it "executes the callback" do
@@ -864,7 +871,7 @@ describe Mongoid::Interceptable do
         context "when the child is persisted" do
 
           let(:band) do
-            Band.create(name: "Moderat")
+            Band.create!(name: "Moderat")
           end
 
           let!(:label) do
@@ -872,7 +879,7 @@ describe Mongoid::Interceptable do
           end
 
           before do
-            band.save
+            band.save!
           end
 
           it "executes the callback" do
@@ -896,7 +903,7 @@ describe Mongoid::Interceptable do
             end
 
             before do
-              band.save
+              band.save!
             end
 
             it "executes the callback" do
@@ -907,7 +914,7 @@ describe Mongoid::Interceptable do
           context "when the parent is persisted" do
 
             let(:band) do
-              Band.create(name: "Moderat")
+              Band.create!(name: "Moderat")
             end
 
             let!(:record) do
@@ -915,7 +922,7 @@ describe Mongoid::Interceptable do
             end
 
             before do
-              band.save
+              band.save!
             end
 
             it "executes the callback" do
@@ -927,16 +934,16 @@ describe Mongoid::Interceptable do
         context "when the child is persisted" do
 
           let(:band) do
-            Band.create(name: "Moderat")
+            Band.create!(name: "Moderat")
           end
 
           let!(:record) do
-            band.records.create(name: "Moderat")
+            band.records.create!(name: "Moderat")
           end
 
           before do
             record.before_create_called = false
-            band.save
+            band.save!
           end
 
           it "does not execute the callback" do
@@ -960,7 +967,7 @@ describe Mongoid::Interceptable do
             end
 
             before do
-              band.save
+              band.save!
             end
 
             it "executes the callback" do
@@ -975,7 +982,7 @@ describe Mongoid::Interceptable do
           context "when the parent is persisted" do
 
             let(:band) do
-              Band.create(name: "Moderat")
+              Band.create!(name: "Moderat")
             end
 
             let!(:record) do
@@ -983,7 +990,7 @@ describe Mongoid::Interceptable do
             end
 
             before do
-              band.save
+              band.save!
             end
 
             it "executes the callback" do
@@ -999,15 +1006,15 @@ describe Mongoid::Interceptable do
         context "when the child is persisted" do
 
           let(:band) do
-            Band.create(name: "Moderat")
+            Band.create!(name: "Moderat")
           end
 
           let!(:record) do
-            band.records.create(name: "Moderat")
+            band.records.create!(name: "Moderat")
           end
 
           before do
-            band.save
+            band.save!
           end
 
           it "executes the callback" do
@@ -1022,7 +1029,7 @@ describe Mongoid::Interceptable do
         context "when the child is created" do
 
           let!(:band) do
-            Band.create
+            Band.create!
           end
 
           let!(:label) do
@@ -1050,7 +1057,7 @@ describe Mongoid::Interceptable do
             end
 
             before do
-              band.save
+              band.save!
             end
 
             it "does not execute the callback" do
@@ -1061,7 +1068,7 @@ describe Mongoid::Interceptable do
           context "when the parent is persisted" do
 
             let(:band) do
-              Band.create(name: "Moderat")
+              Band.create!(name: "Moderat")
             end
 
             let!(:record) do
@@ -1069,7 +1076,7 @@ describe Mongoid::Interceptable do
             end
 
             before do
-              band.save
+              band.save!
             end
 
             it "does not execute the callback" do
@@ -1081,18 +1088,18 @@ describe Mongoid::Interceptable do
         context "when the child is persisted" do
 
           let(:band) do
-            Band.create(name: "Moderat")
+            Band.create!(name: "Moderat")
           end
 
           let!(:record) do
-            band.records.create(name: "Moderat")
+            band.records.create!(name: "Moderat")
           end
 
           context "when the child is dirty" do
 
             before do
               record.name = "Nothing"
-              band.save
+              band.save!
             end
 
             it "executes the callback" do
@@ -1107,7 +1114,7 @@ describe Mongoid::Interceptable do
           context "when the child is not dirty" do
 
             before do
-              band.save
+              band.save!
             end
 
             it "does not execute the callback" do
@@ -1132,7 +1139,7 @@ describe Mongoid::Interceptable do
             end
 
             before do
-              band.save
+              band.save!
             end
 
             it "executes the callback" do
@@ -1147,7 +1154,7 @@ describe Mongoid::Interceptable do
           context "when the parent is persisted" do
 
             let(:band) do
-              Band.create(name: "Moderat")
+              Band.create!(name: "Moderat")
             end
 
             let!(:record) do
@@ -1155,7 +1162,7 @@ describe Mongoid::Interceptable do
             end
 
             before do
-              band.save
+              band.save!
             end
 
             it "executes the callback" do
@@ -1170,7 +1177,7 @@ describe Mongoid::Interceptable do
           context 'when the parent is updated' do
 
             let(:band) do
-              Band.create(name: "Moderat")
+              Band.create!(name: "Moderat")
             end
 
             before do
@@ -1190,7 +1197,7 @@ describe Mongoid::Interceptable do
         context 'when the parent is updated' do
 
           let(:band) do
-            Band.create(name: "Moderat")
+            Band.create!(name: "Moderat")
           end
 
           before do
@@ -1209,15 +1216,15 @@ describe Mongoid::Interceptable do
         context "when the child is persisted" do
 
           let(:band) do
-            Band.create(name: "Moderat")
+            Band.create!(name: "Moderat")
           end
 
           let!(:record) do
-            band.records.create(name: "Moderat")
+            band.records.create!(name: "Moderat")
           end
 
           before do
-            band.save
+            band.save!
           end
 
           it "executes the callback" do
@@ -1252,7 +1259,7 @@ describe Mongoid::Interceptable do
             end
 
             before do
-              band.save
+              band.save!
             end
 
             it "executes the callback" do
@@ -1263,7 +1270,7 @@ describe Mongoid::Interceptable do
           context "when the root is persisted" do
 
             let(:band) do
-              Band.create(name: "Moderat")
+              Band.create!(name: "Moderat")
             end
 
             let!(:record) do
@@ -1275,7 +1282,7 @@ describe Mongoid::Interceptable do
             end
 
             before do
-              band.save
+              band.save!
             end
 
             it "executes the callback" do
@@ -1287,20 +1294,20 @@ describe Mongoid::Interceptable do
         context "when the child is persisted" do
 
           let(:band) do
-            Band.create(name: "Moderat")
+            Band.create!(name: "Moderat")
           end
 
           let!(:record) do
-            band.records.create(name: "Moderat")
+            band.records.create!(name: "Moderat")
           end
 
           let!(:track) do
-            record.tracks.create(name: "Berlin")
+            record.tracks.create!(name: "Berlin")
           end
 
           before do
             track.before_create_called = false
-            band.save
+            band.save!
           end
 
           it "does not execute the callback" do
@@ -1328,7 +1335,7 @@ describe Mongoid::Interceptable do
             end
 
             before do
-              band.save
+              band.save!
             end
 
             let(:reloaded) do
@@ -1347,7 +1354,7 @@ describe Mongoid::Interceptable do
           context "when the parent is persisted" do
 
             let(:band) do
-              Band.create(name: "Moderat")
+              Band.create!(name: "Moderat")
             end
 
             let!(:record) do
@@ -1359,7 +1366,7 @@ describe Mongoid::Interceptable do
             end
 
             before do
-              band.save
+              band.save!
             end
 
             let(:reloaded) do
@@ -1379,19 +1386,19 @@ describe Mongoid::Interceptable do
         context "when the child is persisted" do
 
           let(:band) do
-            Band.create(name: "Moderat")
+            Band.create!(name: "Moderat")
           end
 
           let!(:record) do
-            band.records.create(name: "Moderat")
+            band.records.create!(name: "Moderat")
           end
 
           let!(:track) do
-            record.tracks.create(name: "Berlin")
+            record.tracks.create!(name: "Berlin")
           end
 
           before do
-            band.save
+            band.save!
           end
 
           let(:reloaded) do
@@ -1427,7 +1434,7 @@ describe Mongoid::Interceptable do
             end
 
             before do
-              band.save
+              band.save!
             end
 
             it "does not execute the callback" do
@@ -1438,7 +1445,7 @@ describe Mongoid::Interceptable do
           context "when the parent is persisted" do
 
             let(:band) do
-              Band.create(name: "Moderat")
+              Band.create!(name: "Moderat")
             end
 
             let!(:record) do
@@ -1450,7 +1457,7 @@ describe Mongoid::Interceptable do
             end
 
             before do
-              band.save
+              band.save!
             end
 
             it "does not execute the callback" do
@@ -1462,22 +1469,22 @@ describe Mongoid::Interceptable do
         context "when the child is persisted" do
 
           let(:band) do
-            Band.create(name: "Moderat")
+            Band.create!(name: "Moderat")
           end
 
           let!(:record) do
-            band.records.create(name: "Moderat")
+            band.records.create!(name: "Moderat")
           end
 
           let!(:track) do
-            record.tracks.create(name: "Berlin")
+            record.tracks.create!(name: "Berlin")
           end
 
           context "when the child is dirty" do
 
             before do
               track.name = "Rusty Nails"
-              band.save
+              band.save!
             end
 
             let(:reloaded) do
@@ -1496,7 +1503,7 @@ describe Mongoid::Interceptable do
           context "when the child is not dirty" do
 
             before do
-              band.save
+              band.save!
             end
 
             it "does not execute the callback" do
@@ -1544,7 +1551,7 @@ describe Mongoid::Interceptable do
             end
 
             before do
-              band.save
+              band.save!
             end
 
             it "executes the callback" do
@@ -1555,7 +1562,7 @@ describe Mongoid::Interceptable do
           context "when the parent is persisted" do
 
             let(:band) do
-              Band.create(name: "Moderat")
+              Band.create!(name: "Moderat")
             end
 
             let!(:record) do
@@ -1567,7 +1574,7 @@ describe Mongoid::Interceptable do
             end
 
             before do
-              band.save
+              band.save!
             end
 
             it "executes the callback" do
@@ -1579,19 +1586,19 @@ describe Mongoid::Interceptable do
         context "when the child is persisted" do
 
           let(:band) do
-            Band.create(name: "Moderat")
+            Band.create!(name: "Moderat")
           end
 
           let!(:record) do
-            band.records.create(name: "Moderat")
+            band.records.create!(name: "Moderat")
           end
 
           let!(:track) do
-            record.tracks.create(name: "Berlin")
+            record.tracks.create!(name: "Berlin")
           end
 
           before do
-            band.save
+            band.save!
           end
 
           it "executes the callback" do
@@ -1618,11 +1625,11 @@ describe Mongoid::Interceptable do
     end
 
     before do
-      parent.save
+      parent.save!
     end
 
     it "does not duplicate the child documents" do
-      parent.children.create(position: 1)
+      parent.children.create!(position: 1)
       expect(ParentDoc.find(parent.id).children.size).to eq(1)
     end
   end
@@ -1673,7 +1680,7 @@ describe Mongoid::Interceptable do
     context "when updating a document" do
 
       let(:person) do
-        Person.create.tap do |person|
+        Person.create!.tap do |person|
           person.attributes = {
             mode: :prevent_save,
             title: "Associate",