mongoid 7.3.5 → 7.4.0

data/spec/mongoid/attributes/nested_spec.rb

@@ -1,5 +1,4 @@
 # frozen_string_literal: true
-# encoding: utf-8
 
 require "spec_helper"
 
@@ -192,7 +191,7 @@ describe Mongoid::Attributes::Nested do
       end
 
       context "when adding existing document to a relation" do
-        let(:preference) { Preference.create(name: 'sample preference') }
+        let(:preference) { Preference.create!(name: 'sample preference') }
         let(:person) do
           Person.new(
             preferences_attributes: { 0 => { id: preference.id, name: preference.name } }
@@ -243,7 +242,7 @@ describe Mongoid::Attributes::Nested do
         context "when the parent document is persisted" do
 
           let(:person) do
-            Person.create
+            Person.create!
           end
 
           before do
@@ -273,7 +272,7 @@ describe Mongoid::Attributes::Nested do
             context "when saving the parent" do
 
               before do
-                person.save
+                person.save!
                 person.reload
               end
 
@@ -375,7 +374,7 @@ describe Mongoid::Attributes::Nested do
             context "when all attributes are empty" do
 
               let(:product) do
-                Product.create(name: "testing")
+                Product.create!(name: "testing")
               end
 
               it "does not add the document" do
@@ -608,7 +607,7 @@ describe Mongoid::Attributes::Nested do
                       end
 
                       let(:owner) do
-                        PetOwner.create
+                        PetOwner.create!
                       end
 
                       let!(:pet) do
@@ -617,7 +616,7 @@ describe Mongoid::Attributes::Nested do
 
                       before do
                         owner.pet_attributes = { id: pet.id, _destroy: truth }
-                        owner.save
+                        owner.save!
                       end
 
                       it "destroys the existing document" do
@@ -1035,7 +1034,7 @@ describe Mongoid::Attributes::Nested do
         context "when the parent document is persisted" do
 
           let(:person) do
-            Person.create
+            Person.create!
           end
 
           before do
@@ -1069,7 +1068,7 @@ describe Mongoid::Attributes::Nested do
             context "when saving the parent" do
 
               before do
-                person.save
+                person.save!
                 person.reload
               end
 
@@ -1185,7 +1184,7 @@ describe Mongoid::Attributes::Nested do
             context "when the parent is saved" do
 
               before do
-                band.save
+                band.save!
               end
 
               it "runs the first child create callbacks" do
@@ -1377,7 +1376,7 @@ describe Mongoid::Attributes::Nested do
                   end
 
                   let!(:record) do
-                    band.records.create
+                    band.records.create!
                   end
 
                   let(:attributes) do
@@ -1415,17 +1414,17 @@ describe Mongoid::Attributes::Nested do
                   end
 
                   let!(:band) do
-                    Band.create
+                    Band.create!
                   end
 
                   let!(:record) do
-                    band.records.create
+                    band.records.create!
                   end
 
                   before do
                     band.records_attributes =
                       { "foo" => { "id" => record.id, "_destroy" => true }}
-                    band.save
+                    band.save!
                   end
 
                   it "deletes the child document" do
@@ -1450,7 +1449,7 @@ describe Mongoid::Attributes::Nested do
                   context "when the parent is persisted" do
 
                     let!(:persisted) do
-                      Person.create(age: 42)
+                      Person.create!(age: 42)
                     end
 
                     context "when the child halts the callback chain in a before callback" do
@@ -1458,11 +1457,11 @@ describe Mongoid::Attributes::Nested do
                       context "when the child is not paranoid" do
 
                         let(:actor) do
-                          Actor.create
+                          Actor.create!
                         end
 
                         let!(:thing) do
-                          actor.things.create
+                          actor.things.create!
                         end
 
                         before do
@@ -1480,11 +1479,11 @@ describe Mongoid::Attributes::Nested do
                     context "when only 1 child has the default persisted" do
 
                       let!(:app_one) do
-                        persisted.appointments.create
+                        persisted.appointments.create!
                       end
 
                       let!(:app_two) do
-                        persisted.appointments.create.tap do |app|
+                        persisted.appointments.create!.tap do |app|
                           app.unset(:timed)
                         end
                       end
@@ -1501,7 +1500,7 @@ describe Mongoid::Attributes::Nested do
                               "bar" => { "id" => app_one.id, "_destroy" => true },
                               "foo" => { "id" => app_two.id, "_destroy" => true }
                             }
-                          from_db.save
+                          from_db.save!
                         end
 
                         it "destroys both children" do
@@ -1576,7 +1575,7 @@ describe Mongoid::Attributes::Nested do
                       context "when the parent is persisted" do
 
                         let!(:persisted) do
-                          Person.create do |p|
+                          Person.create! do |p|
                             p.addresses << [ address_one, address_two ]
                           end
                         end
@@ -1623,7 +1622,7 @@ describe Mongoid::Attributes::Nested do
                           context "when saving the parent" do
 
                             before do
-                              persisted.save
+                              persisted.save!
                             end
 
                             it "deletes the marked document from the relation" do
@@ -1679,7 +1678,7 @@ describe Mongoid::Attributes::Nested do
                           context "when saving the parent" do
 
                             before do
-                              persisted.save
+                              persisted.save!
                             end
 
                             it "deletes the marked document from the relation" do
@@ -2391,8 +2390,8 @@ describe Mongoid::Attributes::Nested do
               end
 
               before do
-                pizza.topping = Topping.create(name: "cheese")
-                pizza.update_attributes(topping_attributes: { name: "onions" })
+                pizza.topping = Topping.create!(name: "cheese")
+                pizza.update_attributes!(topping_attributes: { name: "onions" })
               end
 
               it "persists the attribute changes" do
@@ -2967,7 +2966,7 @@ describe Mongoid::Attributes::Nested do
         context "when ids are passed" do
 
           let(:person) do
-            Person.create
+            Person.create!
           end
 
           before do
@@ -3032,7 +3031,7 @@ describe Mongoid::Attributes::Nested do
                       "0" => { "id" => post_one.id, "title" => "testing again" },
                       "1" => { "id" => post_two.id, "title" => "$$$" }
                     }
-                  person.save
+                  person.save!
                 end
 
                 it "does not perist the invalid value" do
@@ -3308,7 +3307,7 @@ describe Mongoid::Attributes::Nested do
               context "when the parent is saved" do
 
                 before do
-                  person.save
+                  person.save!
                   person.posts_attributes =
                     [
                       { "title" => "Third" },
@@ -3723,7 +3722,7 @@ describe Mongoid::Attributes::Nested do
         context "when ids are passed" do
 
           let(:person) do
-            Person.create
+            Person.create!
           end
 
           before do
@@ -4305,7 +4304,7 @@ describe Mongoid::Attributes::Nested do
     end
   end
 
-  describe "#update_attributes" do
+  describe "#update_attributes!" do
 
     before do
       Person.send(:undef_method, :addresses_attributes=)
@@ -4315,11 +4314,11 @@ describe Mongoid::Attributes::Nested do
     context "when embedding one level behind a has many" do
 
       let(:node) do
-        Node.create
+        Node.create!
       end
 
       let!(:server) do
-        node.servers.create(name: "prod")
+        node.servers.create!(name: "prod")
       end
 
       context "when adding a new embedded document" do
@@ -4338,7 +4337,7 @@ describe Mongoid::Attributes::Nested do
         end
 
         before do
-          node.update_attributes(attributes)
+          node.update_attributes!(attributes)
         end
 
         it "adds the new embedded document" do
@@ -4354,11 +4353,11 @@ describe Mongoid::Attributes::Nested do
     context "when deleting the child document" do
 
       let(:person) do
-        Person.create
+        Person.create!
       end
 
       let!(:service) do
-        person.services.create(sid: "123")
+        person.services.create!(sid: "123")
       end
 
       let(:attributes) do
@@ -4370,7 +4369,7 @@ describe Mongoid::Attributes::Nested do
       end
 
       before do
-        person.update_attributes(attributes)
+        person.update_attributes!(attributes)
       end
 
       it "removes the document from the parent" do
@@ -4408,15 +4407,15 @@ describe Mongoid::Attributes::Nested do
       end
 
       let(:dokument) do
-        Dokument.create
+        Dokument.create!
       end
 
       let!(:address) do
-        dokument.addresses.create(street: "hobrecht")
+        dokument.addresses.create!(street: "hobrecht")
       end
 
       let!(:location) do
-        address.locations.create(name: "work")
+        address.locations.create!(name: "work")
       end
 
       let(:attributes) do
@@ -4428,7 +4427,7 @@ describe Mongoid::Attributes::Nested do
       end
 
       before do
-        address.update_attributes(attributes)
+        address.update_attributes!(attributes)
         address.reload
       end
 
@@ -4440,21 +4439,21 @@ describe Mongoid::Attributes::Nested do
     context "when nesting multiple levels" do
 
       let!(:person) do
-        Person.create
+        Person.create!
       end
 
       context "when second level is a one to many" do
 
         let(:person_one) do
-          Person.create
+          Person.create!
         end
 
         let!(:address_one) do
-          person_one.addresses.create(street: "hobrecht")
+          person_one.addresses.create!(street: "hobrecht")
         end
 
         let!(:location_one) do
-          address_one.locations.create(name: "home")
+          address_one.locations.create!(name: "home")
         end
 
         context "when destroying a second level document" do
@@ -4471,7 +4470,7 @@ describe Mongoid::Attributes::Nested do
           end
 
           before do
-            person_one.update_attributes(attributes)
+            person_one.update_attributes!(attributes)
           end
 
           it "deletes the document from the relation" do
@@ -4486,15 +4485,15 @@ describe Mongoid::Attributes::Nested do
         context "when destroying a second level document with callbacks" do
 
           let(:band) do
-            Band.create(name: "Tool")
+            Band.create!(name: "Tool")
           end
 
           let(:record) do
-            band.records.create(name: "Undertow")
+            band.records.create!(name: "Undertow")
           end
 
           let!(:track) do
-            record.tracks.create(name: "Sober")
+            record.tracks.create!(name: "Sober")
           end
 
           context "when cascading callbacks" do
@@ -4521,7 +4520,7 @@ describe Mongoid::Attributes::Nested do
             end
 
             before do
-              band.update_attributes(attributes)
+              band.update_attributes!(attributes)
             end
 
             it "removes the child from the relation" do
@@ -4554,7 +4553,7 @@ describe Mongoid::Attributes::Nested do
             end
 
             before do
-              person.update_attributes(attributes)
+              person.update_attributes!(attributes)
             end
 
             let(:address) do
@@ -4577,11 +4576,11 @@ describe Mongoid::Attributes::Nested do
           context "when adding to an existing document in the first level" do
 
             let!(:address) do
-              person.addresses.create(street: "hobrecht")
+              person.addresses.create!(street: "hobrecht")
             end
 
             let!(:location) do
-              address.locations.create(name: "work")
+              address.locations.create!(name: "work")
             end
 
             let(:attributes) do
@@ -4594,7 +4593,7 @@ describe Mongoid::Attributes::Nested do
             end
 
             before do
-              person.update_attributes(attributes)
+              person.update_attributes!(attributes)
               person.reload
             end
 
@@ -4625,7 +4624,7 @@ describe Mongoid::Attributes::Nested do
           end
 
           before do
-            person.update_attributes(attributes)
+            person.update_attributes!(attributes)
           end
 
           let(:address) do
@@ -4651,7 +4650,7 @@ describe Mongoid::Attributes::Nested do
         context "when the nested document is not polymorphic" do
 
           let!(:address) do
-            person.addresses.create(street: "Alexanderstr", number: 1)
+            person.addresses.create!(street: "Alexanderstr", number: 1)
           end
 
           let!(:code) do
@@ -4674,7 +4673,7 @@ describe Mongoid::Attributes::Nested do
           end
 
           before do
-            person.update_attributes(attributes)
+            person.update_attributes!(attributes)
           end
 
           it "updates the first level embedded document" do
@@ -4691,7 +4690,7 @@ describe Mongoid::Attributes::Nested do
           context "when the first level is an embeds many" do
 
             let!(:address) do
-              person.addresses.create(street: "Alexanderstr", number: 1)
+              person.addresses.create!(street: "Alexanderstr", number: 1)
             end
 
             let!(:target) do
@@ -4714,7 +4713,7 @@ describe Mongoid::Attributes::Nested do
             end
 
             before do
-              person.update_attributes(attributes)
+              person.update_attributes!(attributes)
             end
 
             it "updates the first level embedded document" do
@@ -4750,7 +4749,7 @@ describe Mongoid::Attributes::Nested do
               end
 
               before do
-                person.update_attributes(attributes)
+                person.update_attributes!(attributes)
               end
 
               it "updates the nested embedded document" do
@@ -4767,7 +4766,7 @@ describe Mongoid::Attributes::Nested do
       context "when updating with valid attributes" do
 
         let(:user) do
-          User.create
+          User.create!
         end
 
         let(:params) do
@@ -4777,7 +4776,7 @@ describe Mongoid::Attributes::Nested do
         end
 
         before do
-          user.update_attributes(params)
+          user.update_attributes!(params)
         end
 
         around do |example|
@@ -4803,11 +4802,11 @@ describe Mongoid::Attributes::Nested do
       context "when the document is freshly loaded from the db" do
 
         let!(:node) do
-          Node.create
+          Node.create!
         end
 
         let!(:server) do
-          node.servers.create(name: "test")
+          node.servers.create!(name: "test")
         end
 
         before do
@@ -4840,11 +4839,11 @@ describe Mongoid::Attributes::Nested do
     context "when the relation is an embeds many" do
 
       let(:league) do
-        League.create
+        League.create!
       end
 
       let!(:division) do
-        league.divisions.create(name: "Old Name")
+        league.divisions.create!(name: "Old Name")
       end
 
       context "when additional validation is set" do
@@ -4899,7 +4898,7 @@ describe Mongoid::Attributes::Nested do
         end
 
         before do
-          league.update_attributes(params)
+          league.update_attributes!(params)
         end
 
         it "sets the nested attributes" do
@@ -4919,7 +4918,7 @@ describe Mongoid::Attributes::Nested do
           end
 
           before do
-            league.update_attributes(new_params)
+            league.update_attributes!(new_params)
           end
 
           it "sets the nested attributes" do

data/spec/mongoid/attributes/projector_spec.rb

@@ -1,12 +1,15 @@
 # frozen_string_literal: true
-# encoding: utf-8
 
 require "spec_helper"
 
 describe Mongoid::Attributes::Projector do
   Dir[File.join(File.dirname(__FILE__), 'projector_data', '*.yml')].sort.each do |path|
     context File.basename(path) do
-      specs = YAML.load(File.read(path))
+      specs = if RUBY_VERSION.start_with?("2.5")
+                YAML.safe_load(File.read(path), [], [], true)
+              else
+                YAML.safe_load(File.read(path), aliases: true)
+              end
 
       specs.each do |spec|
         context spec['name'] do

data/spec/mongoid/attributes/readonly_spec.rb

@@ -1,5 +1,4 @@
 # frozen_string_literal: true
-# encoding: utf-8
 
 require "spec_helper"
 
@@ -58,7 +57,7 @@ describe Mongoid::Attributes::Readonly do
       end
 
       let(:person) do
-        Person.create(title: "sir", terms: true, aliased_timestamp: Time.at(42))
+        Person.create!(title: "sir", terms: true, aliased_timestamp: Time.at(42))
       end
 
       it "sets the first readonly value" do
@@ -93,20 +92,20 @@ describe Mongoid::Attributes::Readonly do
       end
 
       let(:person) do
-        Person.create(title: "sir", terms: true, score: 1, aliased_timestamp: Time.at(42))
+        Person.create!(title: "sir", terms: true, score: 1, aliased_timestamp: Time.at(42))
       end
 
       context "when updating via the setter" do
 
         it "does not update the first field" do
           person.title = 'mr'
-          person.save
+          person.save!
           expect(person.reload.title).to eq("sir")
         end
 
         it "does not update the second field" do
           person.aliased_timestamp = Time.at(43)
-          person.save
+          person.save!
           expect(person.reload.aliased_timestamp).to eq(Time.at(42))
         end
       end
@@ -117,7 +116,7 @@ describe Mongoid::Attributes::Readonly do
 
           it "updates the field" do
             person.inc(score: 1)
-            person.save
+            person.save!
             expect(person.reload.score).to eq(2)
           end
         end
@@ -126,7 +125,7 @@ describe Mongoid::Attributes::Readonly do
 
           it "updates the fields" do
             person.inc(score: 1, age: 1)
-            person.save
+            person.save!
             expect(person.reload.score).to eq(2)
             expect(person.reload.age).to eq(101)
           end
@@ -139,16 +138,16 @@ describe Mongoid::Attributes::Readonly do
 
           it "does the update" do
             person.bit(score: { or: 13 })
-            person.save
+            person.save!
             expect(person.reload.score).to eq(13)
           end
         end
 
         context 'with multiple fields operation' do
 
-          it "udpates the attribute" do
+          it "updates the attribute" do
             person.bit(age: {and: 13}, score: {or: 13})
-            person.save
+            person.save!
             expect(person.reload.score).to eq(13)
             expect(person.reload.age).to eq(4)
           end
@@ -159,13 +158,13 @@ describe Mongoid::Attributes::Readonly do
 
         it "does not update the first field" do
           person[:title] = "mr"
-          person.save
+          person.save!
           expect(person.reload.title).to eq("sir")
         end
 
         it "does not update the second field" do
           person[:aliased_timestamp] = Time.at(43)
-          person.save
+          person.save!
           expect(person.reload.aliased_timestamp).to eq(Time.at(42))
         end
       end
@@ -174,13 +173,13 @@ describe Mongoid::Attributes::Readonly do
 
         it "does not update the first field" do
           person.write_attribute(:title, "mr")
-          person.save
+          person.save!
           expect(person.reload.title).to eq("sir")
         end
 
         it "does not update the second field" do
           person.write_attribute(:aliased_timestamp, Time.at(43))
-          person.save
+          person.save!
           expect(person.reload.aliased_timestamp).to eq(Time.at(42))
         end
       end
@@ -188,14 +187,14 @@ describe Mongoid::Attributes::Readonly do
       context "when updating via update_attributes" do
 
         it "does not update the first field" do
-          person.update_attributes(title: "mr", aliased_timestamp: Time.at(43))
-          person.save
+          person.update_attributes!(title: "mr", aliased_timestamp: Time.at(43))
+          person.save!
           expect(person.reload.title).to eq("sir")
         end
 
         it "does not update the second field" do
-          person.update_attributes(title: "mr", aliased_timestamp: Time.at(43))
-          person.save
+          person.update_attributes!(title: "mr", aliased_timestamp: Time.at(43))
+          person.save!
           expect(person.reload.aliased_timestamp).to eq(Time.at(42))
         end
       end
@@ -204,13 +203,13 @@ describe Mongoid::Attributes::Readonly do
 
         it "does not update the first field" do
           person.update_attributes!(title: "mr", aliased_timestamp: Time.at(43))
-          person.save
+          person.save!
           expect(person.reload.title).to eq("sir")
         end
 
         it "does not update the second field" do
           person.update_attributes!(title: "mr", aliased_timestamp: Time.at(43))
-          person.save
+          person.save!
           expect(person.reload.aliased_timestamp).to eq(Time.at(42))
         end
       end
@@ -243,11 +242,11 @@ describe Mongoid::Attributes::Readonly do
       context 'when the relation exists' do
 
         let(:mother) do
-          Person.create
+          Person.create!
         end
 
         let(:child) do
-          Person.create(mother: mother)
+          Person.create!(mother: mother)
           Person.find_by(mother: mother)
         end
 
@@ -259,7 +258,7 @@ describe Mongoid::Attributes::Readonly do
       context 'when the relation does not exist' do
 
         let(:child) do
-          Person.create
+          Person.create!
         end
 
         it 'the relation is nil' do