mongoid 7.3.5 → 7.4.0

data/spec/mongoid/contextual/aggregable/mongo_spec.rb

@@ -1,5 +1,4 @@
 # frozen_string_literal: true
-# encoding: utf-8
 
 require "spec_helper"
 
@@ -10,11 +9,11 @@ describe Mongoid::Contextual::Aggregable::Mongo do
     context "when provided a single field" do
 
       let!(:depeche) do
-        Band.create(name: "Depeche Mode", likes: 1000, years: 1000)
+        Band.create!(name: "Depeche Mode", likes: 1000, years: 1000)
       end
 
       let!(:tool) do
-        Band.create(name: "Tool", likes: 500, years: 800)
+        Band.create!(name: "Tool", likes: 500, years: 800)
       end
 
       let(:criteria) do
@@ -142,7 +141,6 @@ describe Mongoid::Contextual::Aggregable::Mongo do
             expect(aggregates["sum"]).to eq(1000)
           end
         end
-
       end
 
       context "when the field does not exist" do
@@ -167,18 +165,31 @@ describe Mongoid::Contextual::Aggregable::Mongo do
           expect(aggregates["min"]).to be_nil
         end
 
-        it "returns a sum" do
-          expect(aggregates["sum"]).to be_nil
+        context "when broken_aggregables feature flag is not set" do
+          config_override :broken_aggregables, false
+
+          it "returns a sum" do
+            expect(aggregates["sum"]).to eq 0
+          end
+        end
+
+        context "when broken_aggregables feature flag is set" do
+          config_override :broken_aggregables, true
+
+          it "returns nil" do
+            expect(aggregates["sum"]).to be_nil
+          end
         end
+
       end
 
       context "when the field sometimes exists" do
         let!(:oasis) do
-          Band.create(name: "Oasis", likes: 50)
+          Band.create!(name: "Oasis", likes: 50)
         end
 
         let!(:radiohead) do
-          Band.create(name: "Radiohead")
+          Band.create!(name: "Radiohead")
         end
 
         context "and the field doesn't exist on the last document" do
@@ -205,7 +216,7 @@ describe Mongoid::Contextual::Aggregable::Mongo do
 
         context "and the field doesn't exist on the before-last document" do
           let!(:u2) do
-            Band.create(name: "U2", likes: 100)
+            Band.create!(name: "U2", likes: 100)
           end
 
           let(:criteria) do
@@ -240,8 +251,20 @@ describe Mongoid::Contextual::Aggregable::Mongo do
           context.aggregates(:non_existent)
         end
 
-        it "returns nil" do
-          expect(aggregates).to eq({ "count" => 0, "sum" => nil, "avg" => nil, "min" => nil, "max" => nil })
+        context "when broken_aggregables feature flag is not set" do
+          config_override :broken_aggregables, false
+
+          it "returns empty result" do
+            expect(aggregates).to eq({ "count" => 0, "sum" => 0, "avg" => nil, "min" => nil, "max" => nil })
+          end
+        end
+
+        context "when broken_aggregables feature flag is set" do
+          config_override :broken_aggregables, true
+
+          it "returns empty result" do
+            expect(aggregates).to eq({ "count" => 0, "sum" => nil, "avg" => nil, "min" => nil, "max" => nil })
+          end
         end
       end
     end
@@ -254,11 +277,11 @@ describe Mongoid::Contextual::Aggregable::Mongo do
       context "when there are matching documents" do
 
         let!(:depeche) do
-          Band.create(name: "Depeche Mode", likes: 1000)
+          Band.create!(name: "Depeche Mode", likes: 1000)
         end
 
         let!(:tool) do
-          Band.create(name: "Tool", likes: 500)
+          Band.create!(name: "Tool", likes: 500)
         end
 
         let(:criteria) do
@@ -281,7 +304,7 @@ describe Mongoid::Contextual::Aggregable::Mongo do
       context "when no documents match" do
 
         let!(:depeche) do
-          Band.create(name: "Depeche Mode", likes: 1000)
+          Band.create!(name: "Depeche Mode", likes: 1000)
         end
 
         let(:criteria) do
@@ -308,7 +331,7 @@ describe Mongoid::Contextual::Aggregable::Mongo do
     context 'when the field does not exist in any document' do
 
       let!(:depeche) do
-        Band.create(name: "Depeche Mode", likes: 1000)
+        Band.create!(name: "Depeche Mode", likes: 1000)
       end
 
       let(:criteria) do
@@ -331,11 +354,11 @@ describe Mongoid::Contextual::Aggregable::Mongo do
     context "when provided a single field" do
 
       let!(:depeche) do
-        Band.create(name: "Depeche Mode", likes: 1000)
+        Band.create!(name: "Depeche Mode", likes: 1000)
       end
 
       let!(:tool) do
-        Band.create(name: "Tool", likes: 500)
+        Band.create!(name: "Tool", likes: 500)
       end
 
       let(:criteria) do
@@ -396,11 +419,11 @@ describe Mongoid::Contextual::Aggregable::Mongo do
     context "when provided a single field" do
 
       let!(:depeche) do
-        Band.create(name: "Depeche Mode", likes: 1000)
+        Band.create!(name: "Depeche Mode", likes: 1000)
       end
 
       let!(:tool) do
-        Band.create(name: "Tool", likes: 500)
+        Band.create!(name: "Tool", likes: 500)
       end
 
       let(:criteria) do
@@ -461,11 +484,11 @@ describe Mongoid::Contextual::Aggregable::Mongo do
     context "when provided a single field" do
 
       let!(:depeche) do
-        Band.create(name: "Depeche Mode", likes: 1000)
+        Band.create!(name: "Depeche Mode", likes: 1000)
       end
 
       let!(:tool) do
-        Band.create(name: "Tool", likes: 500)
+        Band.create!(name: "Tool", likes: 500)
       end
 
       let(:criteria) do
@@ -518,4 +541,80 @@ describe Mongoid::Contextual::Aggregable::Mongo do
       end
     end
   end
+
+  describe '#pipeline' do
+    let(:context) { Mongoid::Contextual::Mongo.new(criteria) }
+    let(:pipeline) { context.send(:pipeline, :likes) }
+    subject(:stages) { pipeline.map {|s| s.keys.first } }
+
+    context "with sort" do
+
+      context "without limit or skip" do
+        let(:criteria) { Band.desc(:name) }
+
+        it 'should omit the $sort stage' do
+          expect(stages).to eq %w[$match $group]
+        end
+      end
+
+      context "with limit" do
+        let(:criteria) { Band.desc(:name).limit(1) }
+
+        it 'should include the $sort stage' do
+          expect(stages).to eq %w[$match $sort $limit $group]
+        end
+      end
+
+      context "with skip" do
+        let(:criteria) { Band.desc(:name).skip(1) }
+
+        it 'should include the $sort stage' do
+          expect(stages).to eq %w[$match $sort $skip $group]
+        end
+      end
+
+      context "with skip and skip" do
+        let(:criteria) { Band.desc(:name).limit(1).skip(1) }
+
+        it 'should include the $sort stage' do
+          expect(stages).to eq %w[$match $sort $skip $limit $group]
+        end
+      end
+    end
+
+    context "without sort" do
+
+      context "without limit or skip" do
+        let(:criteria) { Band.all }
+
+        it 'should omit the $sort stage' do
+          expect(stages).to eq %w[$match $group]
+        end
+      end
+
+      context "with limit" do
+        let(:criteria) { Band.limit(1) }
+
+        it 'should include the $sort stage' do
+          expect(stages).to eq %w[$match $limit $group]
+        end
+      end
+
+      context "with skip" do
+        let(:criteria) { Band.skip(1) }
+
+        it 'should include the $sort stage' do
+          expect(stages).to eq %w[$match $skip $group]
+        end
+      end
+
+      context "with skip and skip" do
+        let(:criteria) { Band.limit(1).skip(1) }
+
+        it 'should include the $sort stage' do
+          expect(stages).to eq %w[$match $skip $limit $group]
+        end
+      end
+    end
+  end
 end

data/spec/mongoid/contextual/aggregable/none_spec.rb

@@ -0,0 +1,60 @@
+# frozen_string_literal: true
+
+require "spec_helper"
+
+describe Mongoid::Contextual::Aggregable::None do
+
+  before do
+    Band.create!(name: "Depeche Mode")
+  end
+
+  let(:context) do
+    Mongoid::Contextual::None.new(Band.where(name: "Depeche Mode"))
+  end
+
+  describe "#aggregates" do
+    it "returns fixed values" do
+      expect(context.aggregates(:likes)).to eq("count" => 0, "avg" => nil, "max" => nil, "min" => nil, "sum" => 0)
+    end
+  end
+
+  describe "#sum" do
+    it "returns zero" do
+      expect(context.sum).to eq(0)
+    end
+
+    context "when broken_aggregables feature flag is not set" do
+      config_override :broken_aggregables, false
+
+      it "returns zero when arg given" do
+        expect(context.sum(:likes)).to eq(0)
+      end
+    end
+
+    context "when broken_aggregables feature flag is set" do
+      config_override :broken_aggregables, true
+
+      it "returns the input when arg given" do
+        expect(context.sum(:likes)).to eq(:likes)
+      end
+    end
+  end
+
+  describe "#avg" do
+    it "returns nil" do
+      expect(context.avg(:likes)).to eq(nil)
+    end
+  end
+
+  describe "#min and #max" do
+    it "returns nil" do
+      expect(context.min).to eq(nil)
+      expect(context.max).to eq(nil)
+    end
+
+    it "returns nil when arg given" do
+      expect(context.min(:likes)).to eq(nil)
+      expect(context.max(:likes)).to eq(nil)
+    end
+  end
+end

data/spec/mongoid/contextual/atomic_spec.rb

@@ -1,5 +1,4 @@
 # frozen_string_literal: true
-# encoding: utf-8
 
 require "spec_helper"
 
@@ -8,15 +7,15 @@ describe Mongoid::Contextual::Atomic do
   describe "#add_to_set" do
 
     let!(:depeche_mode) do
-      Band.create(members: [ "Dave" ])
+      Band.create!(members: [ "Dave" ])
     end
 
     let!(:new_order) do
-      Band.create(members: [ "Peter" ])
+      Band.create!(members: [ "Peter" ])
     end
 
     let!(:smiths) do
-      Band.create
+      Band.create!
     end
 
     context "when the criteria has no sorting" do
@@ -105,15 +104,15 @@ describe Mongoid::Contextual::Atomic do
   describe "#add_each_to_set" do
 
     let!(:depeche_mode) do
-      Band.create(members: [ "Dave" ])
+      Band.create!(members: [ "Dave" ])
     end
 
     let!(:new_order) do
-      Band.create(members: [ "Peter" ])
+      Band.create!(members: [ "Peter" ])
     end
 
     let!(:smiths) do
-      Band.create
+      Band.create!
     end
 
     context "when the criteria has no sorting" do
@@ -202,7 +201,7 @@ describe Mongoid::Contextual::Atomic do
   describe "#bit" do
 
     let!(:depeche_mode) do
-      Band.create(likes: 60)
+      Band.create!(likes: 60)
     end
 
     let(:criteria) do
@@ -250,7 +249,7 @@ describe Mongoid::Contextual::Atomic do
       min_server_version '3.4'
 
       let!(:depeche_mode) do
-        Band.create(members: [ "Dave" ], likes: 60)
+        Band.create!(members: [ "Dave" ], likes: 60)
       end
 
       let(:criteria) do
@@ -274,15 +273,15 @@ describe Mongoid::Contextual::Atomic do
   describe "#inc" do
 
     let!(:depeche_mode) do
-      Band.create(likes: 60)
+      Band.create!(likes: 60)
     end
 
     let!(:smiths) do
-      Band.create
+      Band.create!
     end
 
     let!(:beatles) do
-      Band.create(years: 2)
+      Band.create!(years: 2)
     end
 
     let(:criteria) do
@@ -330,7 +329,7 @@ describe Mongoid::Contextual::Atomic do
       min_server_version '3.4'
 
       let!(:depeche_mode) do
-        Band.create(members: [ "Dave" ])
+        Band.create!(members: [ "Dave" ])
       end
 
       let(:criteria) do
@@ -354,11 +353,11 @@ describe Mongoid::Contextual::Atomic do
   describe "#pop" do
 
     let!(:depeche_mode) do
-      Band.create(members: [ "Dave", "Martin" ])
+      Band.create!(members: [ "Dave", "Martin" ])
     end
 
     let!(:smiths) do
-      Band.create
+      Band.create!
     end
 
     let(:criteria) do
@@ -403,7 +402,7 @@ describe Mongoid::Contextual::Atomic do
       min_server_version '3.4'
 
       let!(:depeche_mode) do
-        Band.create(members: [ "Dave" ])
+        Band.create!(members: [ "Dave" ])
       end
 
       let(:criteria) do
@@ -427,11 +426,11 @@ describe Mongoid::Contextual::Atomic do
   describe "#pull" do
 
     let!(:depeche_mode) do
-      Band.create(members: [ "Dave", "Alan" ])
+      Band.create!(members: [ "Dave", "Alan" ])
     end
 
     let!(:smiths) do
-      Band.create
+      Band.create!
     end
 
     let(:criteria) do
@@ -458,7 +457,7 @@ describe Mongoid::Contextual::Atomic do
       min_server_version '3.4'
 
       let!(:depeche_mode) do
-        Band.create(members: [ "Dave" ])
+        Band.create!(members: [ "Dave" ])
       end
 
       let(:criteria) do
@@ -484,11 +483,11 @@ describe Mongoid::Contextual::Atomic do
     context 'when the criteria does not have a collation' do
 
       let!(:depeche_mode) do
-        Band.create(members: [ "Dave", "Alan", "Fletch" ])
+        Band.create!(members: [ "Dave", "Alan", "Fletch" ])
       end
 
       let!(:smiths) do
-        Band.create
+        Band.create!
       end
 
       let(:criteria) do
@@ -516,7 +515,7 @@ describe Mongoid::Contextual::Atomic do
       min_server_version '3.4'
 
       let!(:depeche_mode) do
-        Band.create(members: [ "Dave", "Alan", "Fletch" ])
+        Band.create!(members: [ "Dave", "Alan", "Fletch" ])
       end
 
       let(:criteria) do
@@ -542,11 +541,11 @@ describe Mongoid::Contextual::Atomic do
     context 'when the criteria does not have a collation' do
 
       let!(:depeche_mode) do
-        Band.create(members: [ "Dave" ])
+        Band.create!(members: [ "Dave" ])
       end
 
       let!(:smiths) do
-        Band.create
+        Band.create!
       end
 
       let(:criteria) do
@@ -574,11 +573,11 @@ describe Mongoid::Contextual::Atomic do
       min_server_version '3.4'
 
       let!(:depeche_mode) do
-        Band.create(members: [ "Dave" ])
+        Band.create!(members: [ "Dave" ])
       end
 
       let!(:smiths) do
-        Band.create
+        Band.create!
       end
 
       let(:criteria) do
@@ -608,11 +607,11 @@ describe Mongoid::Contextual::Atomic do
     context 'when the criteria does not have a collation' do
 
       let!(:depeche_mode) do
-        Band.create(members: [ "Dave" ])
+        Band.create!(members: [ "Dave" ])
       end
 
       let!(:smiths) do
-        Band.create
+        Band.create!
       end
 
       let(:criteria) do
@@ -640,11 +639,11 @@ describe Mongoid::Contextual::Atomic do
       min_server_version '3.4'
 
       let!(:depeche_mode) do
-        Band.create(members: [ "Dave" ])
+        Band.create!(members: [ "Dave" ])
       end
 
       let!(:smiths) do
-        Band.create
+        Band.create!
       end
 
       let(:criteria) do
@@ -670,11 +669,11 @@ describe Mongoid::Contextual::Atomic do
     context 'when the criteria does not have a collation' do
 
       let!(:depeche_mode) do
-        Band.create(members: [ "Dave" ])
+        Band.create!(members: [ "Dave" ])
       end
 
       let!(:smiths) do
-        Band.create
+        Band.create!
       end
 
       let(:criteria) do
@@ -686,15 +685,15 @@ describe Mongoid::Contextual::Atomic do
       end
 
       before do
-        context.rename(members: :artists)
+        context.rename(members: :musicians)
       end
 
       it "renames existing fields" do
-        expect(depeche_mode.reload.artists).to eq([ "Dave" ])
+        expect(depeche_mode.reload.musicians).to eq([ "Dave" ])
       end
 
       it "does not rename non existent fields" do
-        expect(smiths.reload).to_not respond_to(:artists)
+        expect(smiths.reload).to_not respond_to(:musicians)
       end
     end
 
@@ -702,11 +701,11 @@ describe Mongoid::Contextual::Atomic do
       min_server_version '3.4'
 
       let!(:depeche_mode) do
-        Band.create(members: [ "Dave" ])
+        Band.create!(members: [ "Dave" ])
       end
 
       let!(:smiths) do
-        Band.create
+        Band.create!
       end
 
       let(:criteria) do
@@ -718,15 +717,15 @@ describe Mongoid::Contextual::Atomic do
       end
 
       before do
-        context.rename(members: :artists)
+        context.rename(members: :musicians)
       end
 
       it "renames existing fields" do
-        expect(depeche_mode.reload.artists).to eq([ "Dave" ])
+        expect(depeche_mode.reload.musicians).to eq([ "Dave" ])
       end
 
       it "does not rename non existent fields" do
-        expect(smiths.reload).to_not respond_to(:artists)
+        expect(smiths.reload).to_not respond_to(:musicians)
       end
     end
   end
@@ -734,11 +733,11 @@ describe Mongoid::Contextual::Atomic do
   describe "#set" do
 
     let!(:depeche_mode) do
-      Band.create(name: "Depeche Mode")
+      Band.create!(name: "Depeche Mode")
     end
 
     let!(:smiths) do
-      Band.create
+      Band.create!
     end
 
     let(:criteria) do
@@ -780,11 +779,11 @@ describe Mongoid::Contextual::Atomic do
     context "when unsetting a single field" do
 
       let!(:depeche_mode) do
-        Band.create(name: "Depeche Mode", years: 10)
+        Band.create!(name: "Depeche Mode", years: 10)
       end
 
       let!(:new_order) do
-        Band.create(name: "New Order", years: 10)
+        Band.create!(name: "New Order", years: 10)
       end
 
       let(:criteria) do
@@ -830,7 +829,7 @@ describe Mongoid::Contextual::Atomic do
     context "when unsetting multiple fields" do
 
       let!(:new_order) do
-        Band.create(name: "New Order", genres: %w[electro dub], years: 10,
+        Band.create!(name: "New Order", genres: %w[electro dub], years: 10,
           likes: 200, rating: 4.3, origin: 'Space')
       end
 
@@ -912,11 +911,11 @@ describe Mongoid::Contextual::Atomic do
       min_server_version '3.4'
 
       let!(:depeche_mode) do
-        Band.create(name: "Depeche Mode", years: 10)
+        Band.create!(name: "Depeche Mode", years: 10)
       end
 
       let!(:new_order) do
-        Band.create(name: "New Order", years: 10)
+        Band.create!(name: "New Order", years: 10)
       end
 
       let(:criteria) do