mongoid 7.3.5 → 7.4.0

data/spec/integration/discriminator_value_spec.rb

@@ -1,5 +1,4 @@
 # frozen_string_literal: true
-# encoding: utf-8
 
 require 'spec_helper'
 

data/spec/integration/document_spec.rb

@@ -1,5 +1,4 @@
 # frozen_string_literal: true
-# encoding: utf-8
 
 require 'spec_helper'
 

data/spec/integration/i18n_fallbacks_spec.rb

@@ -1,5 +1,4 @@
 # frozen_string_literal: true
-# encoding: utf-8
 
 require 'spec_helper'
 

data/spec/integration/matcher_examples_spec.rb

@@ -1,5 +1,4 @@
 # frozen_string_literal: true
-# encoding: utf-8
 
 require 'spec_helper'
 

data/spec/integration/matcher_operator_spec.rb

@@ -1,5 +1,4 @@
 # frozen_string_literal: true
-# encoding: utf-8
 
 require 'spec_helper'
 
@@ -15,7 +14,32 @@ end
 describe 'Matcher operators' do
   Dir[File.join(File.dirname(__FILE__), 'matcher_operator_data', '*.yml')].sort.each do |path|
     context File.basename(path) do
-      specs = YAML.load(File.read(path))
+      permitted_classes = [ BigDecimal,
+                            Date,
+                            Time,
+                            Range,
+                            Regexp,
+                            Symbol,
+                            BSON::Binary,
+                            BSON::Code,
+                            BSON::CodeWithScope,
+                            BSON::DbPointer,
+                            BSON::Decimal128,
+                            BSON::Int32,
+                            BSON::Int64,
+                            BSON::MaxKey,
+                            BSON::MinKey,
+                            BSON::ObjectId,
+                            BSON::Regexp::Raw,
+                            BSON::Symbol::Raw,
+                            BSON::Timestamp,
+                            BSON::Undefined ]
+
+      specs = if RUBY_VERSION.start_with?("2.5")
+                YAML.safe_load(File.read(path), permitted_classes, [], true)
+              else
+                YAML.safe_load(File.read(path), permitted_classes: permitted_classes, aliases: true)
+              end
 
       specs.each do |spec|
         context spec['name'] do
@@ -52,7 +76,7 @@ describe 'Matcher operators' do
           end
 
           context 'server query' do
-            let!(:document) { Mop.create(spec.fetch('document')) }
+            let!(:document) { Mop.create!(spec.fetch('document')) }
 
             context 'via driver' do
               if mop_error?(spec, 'driver')

data/spec/integration/matcher_spec.rb

@@ -1,5 +1,4 @@
 # frozen_string_literal: true
-# encoding: utf-8
 
 require 'spec_helper'
 
@@ -20,6 +19,101 @@ describe 'Matcher operators' do
     end
   end
 
+  context 'when comparing Time objects' do
+    let(:time) {Time.utc(2021, 10, 25, 10, 30, 30, 581345)}
+    let(:document) do
+      ConsumptionPeriod.new(:started_at => time)
+    end
+
+    context 'comparing millisecond precision' do
+      let(:time_millis) {Time.utc(2021, 10, 25, 10, 30, 30, 581774)}
+
+      context "when compare_time_by_ms feature flag is set" do
+        config_override :compare_time_by_ms, true
+
+        context 'with exact match' do
+          let(:query) do
+            {'started_at' => time_millis}
+          end
+
+          it_behaves_like 'is true'
+
+          context 'and query has different timezone' do
+            let(:time_millis) do
+              Time.utc(2021, 10, 25, 10, 30, 30, 581345).in_time_zone("Stockholm")
+            end
+
+            it_behaves_like 'is true'
+          end
+        end
+
+        context 'with $in' do
+          let(:query) do
+            {'started_at' => {:$in => [time_millis]}}
+          end
+
+          it_behaves_like 'is true'
+        end
+
+        context 'when matching an element in an array' do
+          let(:document) do
+            Mop.new(:array_field => [time])
+          end
+
+          context 'with equals match' do
+            let(:query) do
+              {'array_field' => time_millis}
+            end
+
+            it_behaves_like 'is true'
+          end
+        end
+      end
+
+      context "when compare_time_by_ms feature flag is not set" do
+        config_override :compare_time_by_ms, false
+
+        context 'with exact match' do
+          let(:query) do
+            {'started_at' => time_millis}
+          end
+
+          it_behaves_like 'is false'
+
+          context 'and query has different timezone' do
+            let(:time_millis) do
+              Time.utc(2021, 10, 25, 10, 30, 30, 581345).in_time_zone("Stockholm")
+            end
+
+            it_behaves_like 'is true'
+          end
+        end
+
+        context 'with $in' do
+          let(:query) do
+            {'started_at' => {:$in => [time_millis]}}
+          end
+
+          it_behaves_like 'is false'
+        end
+
+        context 'when matching an element in an array' do
+          let(:document) do
+            Mop.new(:array_field => [time])
+          end
+
+          context 'with equals match' do
+            let(:query) do
+              {'array_field' => time_millis}
+            end
+
+            it_behaves_like 'is false'
+          end
+        end
+      end
+    end
+  end
+
   context 'when querying nested document' do
     context 'embeds_one' do
       let(:document) do

data/spec/integration/server_query_spec.rb

@@ -1,5 +1,4 @@
 # frozen_string_literal: true
-# encoding: utf-8
 
 require 'spec_helper'
 

data/spec/integration/shardable_spec.rb

@@ -1,5 +1,4 @@
 # frozen_string_literal: true
-# encoding: utf-8
 
 require 'spec_helper'
 require_relative '../mongoid/shardable_models'

data/spec/integration/stringified_symbol_field_spec.rb

@@ -91,7 +91,7 @@ describe "StringifiedSymbol fields" do
     end
 
     it "sends the value as a string" do
-      Order.create(saved_status: [0, 1, 2])
+      Order.create!(saved_status: [0, 1, 2])
       event = insert_events.second
       doc = event.command["documents"].first
       expect(doc["saved_status"]).to eq("[0, 1, 2]")
@@ -187,4 +187,17 @@ describe "StringifiedSymbol fields" do
       expect(event.command["updates"].first["u"]["$set"]["saved_status"]).to eq("[3, 4, 5]")
     end
   end
+  
+  context "when StringifiedSymbol is embedded" do 
+    
+    describe "When the embedded field is not unique" do
+      
+      it "should be invalid" do
+        order = Order.new
+        order.purchased_items.build(item_id: :foo)
+        order.purchased_items.build(item_id: :foo)
+        expect(order.invalid?).to be true
+      end
+    end
+  end
 end

data/spec/lite_spec_helper.rb

@@ -1,5 +1,4 @@
 # frozen_string_literal: true
-# encoding: utf-8
 
 $LOAD_PATH.unshift(File.dirname(__FILE__))
 $LOAD_PATH.unshift(File.join(File.dirname(__FILE__), "..", "lib"))

data/spec/mongoid/association/accessors_spec.rb

@@ -1,5 +1,4 @@
 # frozen_string_literal: true
-# encoding: utf-8
 
 require "spec_helper"
 
@@ -8,7 +7,7 @@ describe Mongoid::Association::Accessors do
   describe "\#{getter}?" do
 
     let(:person) do
-      Person.create
+      Person.create!
     end
 
     context "when the association is a has one" do
@@ -89,7 +88,7 @@ describe Mongoid::Association::Accessors do
       context "when the association is named next" do
 
         let(:user) do
-          User.create
+          User.create!
         end
 
         it "allows the existence check" do
@@ -167,6 +166,36 @@ describe Mongoid::Association::Accessors do
           end
         end
       end
+
+      context "when the association is set to nil first" do
+        context "when broken_updates feature flag is not set" do
+          config_override :broken_updates, false
+
+          let!(:name) do
+            person.build_name
+          end
+
+          it "returns true" do
+            person.name = nil
+            person.name = name
+            expect(person).to have_name
+          end
+        end
+
+        context "when broken_updates feature flag is set" do
+          config_override :broken_updates, true
+
+          let!(:name) do
+            person.build_name
+          end
+
+          it "returns true" do
+            person.name = nil
+            person.name = name
+            expect(person).to have_name
+          end
+        end
+      end
     end
 
     context "when the association is an embeds many" do
@@ -355,13 +384,13 @@ describe Mongoid::Association::Accessors do
     context "when the association is not polymorphic" do
 
       let(:person) do
-        Person.create
+        Person.create!
       end
 
       context "when the association is a many to many" do
 
         let!(:preference) do
-          Preference.create(name: "Setting")
+          Preference.create!(name: "Setting")
         end
 
         before do
@@ -413,7 +442,7 @@ describe Mongoid::Association::Accessors do
       context "when the association is a many to one" do
 
         let!(:post) do
-          Post.create(title: "First!")
+          Post.create!(title: "First!")
         end
 
         before do
@@ -465,7 +494,7 @@ describe Mongoid::Association::Accessors do
       context "when the association is a references one" do
 
         let!(:game) do
-          Game.create(name: "Centipeded")
+          Game.create!(name: "Centipeded")
         end
 
         before do
@@ -520,15 +549,15 @@ describe Mongoid::Association::Accessors do
       context "when there's a single references many/one" do
 
         let!(:movie) do
-          Movie.create(title: "Inception")
+          Movie.create!(title: "Inception")
         end
 
         let!(:book) do
-          Book.create(title: "Jurassic Park")
+          Book.create!(title: "Jurassic Park")
         end
 
         let!(:movie_rating) do
-          movie.ratings.create(value: 10)
+          movie.ratings.create!(value: 10)
         end
 
         let!(:book_rating) do
@@ -833,7 +862,7 @@ describe Mongoid::Association::Accessors do
       context "when setting the _ids accessor" do
 
         let(:post) do
-          Post.create
+          Post.create!
         end
 
         before do
@@ -911,7 +940,7 @@ describe Mongoid::Association::Accessors do
     end
 
     let(:person) do
-      Person.create
+      Person.create!
     end
 
     context "when value is an empty string" do
@@ -970,13 +999,13 @@ describe Mongoid::Association::Accessors do
   context 'when setting the association more than once' do
 
     let(:person) do
-      Person.create
+      Person.create!
     end
 
     context 'when the association is a references one' do
 
       let(:game) do
-        Game.create
+        Game.create!
       end
 
       before do
@@ -992,7 +1021,7 @@ describe Mongoid::Association::Accessors do
     context 'when the association is a references many' do
 
       let!(:preference) do
-        Preference.create(name: "Setting")
+        Preference.create!(name: "Setting")
       end
 
       before do

data/spec/mongoid/association/auto_save_spec.rb

@@ -1,7 +1,8 @@
 # frozen_string_literal: true
-# encoding: utf-8
 
 require "spec_helper"
+require_relative './referenced/has_many_models'
+require_relative './referenced/has_one_models'
 
 describe Mongoid::Association::Referenced::AutoSave do
 
@@ -22,22 +23,59 @@ describe Mongoid::Association::Referenced::AutoSave do
 
     context "when the option is not provided" do
 
-      let(:game) do
-        Game.new(name: "Tekken")
-      end
+      context 'has_many' do
+
+        let(:parent) do
+          HmmSchool.new
+        end
+
+        let(:child) do
+          HmmStudent.new(name: "Panda")
+        end
+
+        before do
+          parent.students = [child]
+        end
+
+        context "when saving the parent document" do
+
+          before do
+            parent.associations[:students].options[:autosave].should be_falsy
+
+            parent.save!
+          end
 
-      before do
-        person.game = game
+          it "does not save the child" do
+            expect(child).to_not be_persisted
+          end
+        end
       end
 
-      context "when saving the parent document" do
+      context 'has_one' do
+
+        let(:parent) do
+          HomCollege.new
+        end
+
+        let(:child) do
+          HomAccreditation.new
+        end
 
         before do
-          person.save
+          parent.accreditation = child
         end
 
-        it "does not save the relation" do
-          expect(game).to_not be_persisted
+        context "when saving the parent document" do
+
+          before do
+            parent.associations[:accreditation].options[:autosave].should be_falsy
+
+            parent.save!
+          end
+
+          it "does not save the child" do
+            expect(child).to_not be_persisted
+          end
         end
       end
     end
@@ -57,7 +95,7 @@ describe Mongoid::Association::Referenced::AutoSave do
         it "does not add the autosave callback twice" do
           expect(drug).to receive(:save).once
           person.drugs.push(drug)
-          person.save
+          person.save!
         end
       end
 
@@ -77,7 +115,7 @@ describe Mongoid::Association::Referenced::AutoSave do
 
             before do
               person.drugs << drug
-              person.save
+              person.save!
             end
 
             it "saves the relation" do
@@ -103,7 +141,7 @@ describe Mongoid::Association::Referenced::AutoSave do
             before do
               person.with(database: other_database) do |per|
                 per.drugs << drug
-                per.save
+                per.save!
               end
             end
 
@@ -118,9 +156,9 @@ describe Mongoid::Association::Referenced::AutoSave do
         context "when saving an existing parent document" do
 
           before do
-            person.save
+            person.save!
             person.drugs << drug
-            person.save
+            person.save!
           end
 
           it "saves the relation" do
@@ -136,11 +174,11 @@ describe Mongoid::Association::Referenced::AutoSave do
 
           before do
             person.drugs << drug
-            person.save
+            person.save!
           end
 
           it 'does not load the association' do
-            from_db.save
+            from_db.save!
             expect(from_db.ivar(:drugs)).to be false
           end
         end
@@ -156,7 +194,7 @@ describe Mongoid::Association::Referenced::AutoSave do
 
           before do
             person.account = account
-            person.save
+            person.save!
           end
 
           it "saves the relation" do
@@ -171,9 +209,9 @@ describe Mongoid::Association::Referenced::AutoSave do
         context "when saving an existing parent document" do
 
           before do
-            person.save
+            person.save!
             person.account = account
-            person.save
+            person.save!
           end
 
           it "saves the relation" do
@@ -189,14 +227,14 @@ describe Mongoid::Association::Referenced::AutoSave do
 
           before do
             person.account = account
-            person.save
+            person.save!
           end
 
           it "sends one insert" do
             account.name = "account"
             expect_query(1) do
               person.with(write: {w:0}) do |_person|
-                _person.save
+                _person.save!
               end
             end
           end
@@ -210,11 +248,11 @@ describe Mongoid::Association::Referenced::AutoSave do
 
           before do
             person.account = account
-            person.save
+            person.save!
           end
 
           it 'does not load the association' do
-            from_db.save
+            from_db.save!
             expect(from_db.ivar(:account)).to be false
           end
         end
@@ -234,7 +272,7 @@ describe Mongoid::Association::Referenced::AutoSave do
 
           before do
             ghost.movie = movie
-            ghost.save
+            ghost.save!
           end
 
           it "saves the relation" do
@@ -245,9 +283,9 @@ describe Mongoid::Association::Referenced::AutoSave do
         context "when saving an existing parent document" do
 
           before do
-            ghost.save
+            ghost.save!
             ghost.movie = movie
-            ghost.save
+            ghost.save!
           end
 
           it "saves the relation" do
@@ -259,7 +297,7 @@ describe Mongoid::Association::Referenced::AutoSave do
       context "when it has two relations with autosaves" do
 
         let!(:person) do
-          Person.create(drugs: [percocet], account: account)
+          Person.create!(drugs: [percocet], account: account)
         end
 
         let(:from_db) do
@@ -282,7 +320,7 @@ describe Mongoid::Association::Referenced::AutoSave do
 
           before do
             from_db.drugs = [placebo]
-            from_db.save
+            from_db.save!
           end
 
           it 'loads the updated association' do
@@ -297,7 +335,7 @@ describe Mongoid::Association::Referenced::AutoSave do
         context "when updating none document" do
 
           before do
-            from_db.save
+            from_db.save!
           end
 
           it 'doest not load drugs association' do
@@ -338,22 +376,22 @@ describe Mongoid::Association::Referenced::AutoSave do
         end
 
         let(:king) do
-          King.create
+          King.create!
         end
 
         let(:peasant) do
-          Peasant.create
+          Peasant.create!
         end
 
         let(:harvest) do
-          Harvest.create(season: 'Summer')
+          Harvest.create!(season: 'Summer')
         end
 
         before do
           peasant.harvest = harvest
           king.peasant = peasant
           harvest.season = 'Fall'
-          king.save
+          king.save!
         end
 
         it 'cascades the save' do

data/spec/mongoid/association/builders_spec.rb

@@ -1,5 +1,4 @@
 # frozen_string_literal: true
-# encoding: utf-8
 
 require "spec_helper"
 
@@ -177,7 +176,7 @@ describe Mongoid::Association::Builders do
     context "when the parent is persisted" do
 
       let(:person) do
-        Person.create
+        Person.create!
       end
 
       context "when the relation is a has one" do

data/spec/mongoid/association/constrainable_spec.rb

@@ -1,5 +1,4 @@
 # frozen_string_literal: true
-# encoding: utf-8
 
 require "spec_helper"