mongoid 6.4.8 → 7.0.0

data/spec/mongoid/extensions/string_spec.rb

@@ -277,77 +277,49 @@ describe Mongoid::Extensions::String do
     context "when the string is an integer" do
 
       it "returns true" do
-        expect("1234".numeric?).to eq(true)
+        expect("1234").to be_numeric
       end
     end
 
     context "when string is a float" do
 
       it "returns true" do
-        expect("1234.123".numeric?).to eq(true)
+        expect("1234.123").to be_numeric
       end
     end
 
     context "when the string is has exponents" do
 
       it "returns true" do
-        expect("1234.123123E4".numeric?).to eq(true)
+        expect("1234.123123E4").to be_numeric
       end
     end
 
     context "when the string is non numeric" do
 
       it "returns false" do
-        expect("blah".numeric?).to eq(false)
+        expect("blah").to_not be_numeric
       end
     end
 
     context "when the string is NaN" do
 
       it "returns true" do
-        expect("NaN".numeric?).to eq(true)
-      end
-    end
-
-    context "when the string is NaN and junk in front" do
-
-      it "returns false" do
-        expect("a\nNaN".numeric?).to eq(false)
-      end
-    end
-
-    context "when the string is NaN and whitespace at end" do
-
-      it "returns false" do
-        expect("NaN\n".numeric?).to eq(false)
+        expect("NaN").to be_numeric
       end
     end
 
     context "when the string is Infinity" do
 
       it "returns true" do
-        expect("Infinity".numeric?).to eq(true)
-      end
-    end
-
-    context "when the string contains Infinity and junk in front" do
-
-      it "returns false" do
-        expect("a\nInfinity".numeric?).to eq(false)
-      end
-    end
-
-    context "when the string contains Infinity and whitespace at end" do
-
-      it "returns false" do
-        expect("Infinity\n".numeric?).to eq(false)
+        expect("Infinity").to be_numeric
       end
     end
 
     context "when the string is -Infinity" do
 
       it "returns true" do
-        expect("-Infinity".numeric?).to eq(true)
+        expect("-Infinity").to be_numeric
       end
     end
   end

data/spec/mongoid/factory_spec.rb

@@ -92,7 +92,7 @@ describe Mongoid::Factory do
     context "when the type is a symbol" do
 
       let(:person) do
-        described_class.build(Person, {:_type => "Doctor"})
+        described_class.build(Person, { :_type => "Doctor" })
       end
 
       it "instantiates the subclass" do
@@ -192,5 +192,23 @@ describe Mongoid::Factory do
         expect(document.title).to eq("Sir")
       end
     end
+
+    context 'when type does not correspond to a Class name' do
+
+      let(:attributes) do
+        { "title" => "Sir", "_type" => "invalid_class_name" }
+      end
+
+      let(:person) do
+        described_class.from_db(Person, attributes)
+      end
+
+      it 'raises a exception' do
+        expect {
+          person
+        }.to raise_exception(Mongoid::Errors::UnknownModel)
+      end
+
+    end
   end
 end

data/spec/mongoid/fields/foreign_key_spec.rb

@@ -7,7 +7,7 @@ describe Mongoid::Fields::ForeignKey do
     let(:field) do
       described_class.new(
         :vals,
-        metadata: Person.relations["preferences"],
+        association: Person.relations["preferences"],
         type: Array,
         default: [],
         identity: true
@@ -68,7 +68,7 @@ describe Mongoid::Fields::ForeignKey do
     let(:field) do
       described_class.new(
         :vals,
-        metadata: Person.relations["posts"],
+        association: Person.relations["posts"],
         type: Array,
         default: default,
         identity: true
@@ -89,7 +89,7 @@ describe Mongoid::Fields::ForeignKey do
     let(:field) do
       described_class.new(
         :vals,
-        metadata: Person.relations["posts"],
+        association: Person.relations["posts"],
         type: Array,
         default: [],
         identity: true
@@ -103,14 +103,14 @@ describe Mongoid::Fields::ForeignKey do
 
   describe "#evolve" do
 
-    let(:metadata) do
+    let(:association) do
       Person.reflect_on_association(:preferences)
     end
 
     context "when provided a document" do
 
       let(:field) do
-        described_class.new(:person_id, type: Object, metadata: metadata)
+        described_class.new(:person_id, type: Object, association: association)
       end
 
       let(:game) do
@@ -129,7 +129,7 @@ describe Mongoid::Fields::ForeignKey do
     context "when the type is an array" do
 
       let(:field) do
-        described_class.new(:preference_ids, type: Array, default: [], metadata: metadata)
+        described_class.new(:preference_ids, type: Array, default: [], association: association)
       end
 
       context "when providing a single value" do
@@ -197,12 +197,12 @@ describe Mongoid::Fields::ForeignKey do
 
           context "when the relation stores ids as strings" do
 
-            let!(:metadata) do
+            let!(:association) do
               Agent.reflect_on_association(:accounts)
             end
 
             let!(:field) do
-              described_class.new(:account_ids, type: Array, default: [], metadata: metadata)
+              described_class.new(:account_ids, type: Array, default: [], association: association)
             end
 
             let(:id_one) do
@@ -260,12 +260,12 @@ describe Mongoid::Fields::ForeignKey do
 
     context "when the type is an object" do
 
-      let(:metadata) do
+      let(:association) do
         Game.reflect_on_association(:person)
       end
 
       let(:field) do
-        described_class.new(:person_id, type: Object, metadata: metadata)
+        described_class.new(:person_id, type: Object, association: association)
       end
 
       context "when providing a single value" do
@@ -312,12 +312,12 @@ describe Mongoid::Fields::ForeignKey do
 
         context "when the relation stores string ids" do
 
-          let(:metadata) do
+          let(:association) do
             Comment.reflect_on_association(:account)
           end
 
           let(:field) do
-            described_class.new(:person_id, type: Object, metadata: metadata)
+            described_class.new(:person_id, type: Object, association: association)
           end
 
           context "when the value is an id string" do
@@ -384,12 +384,12 @@ describe Mongoid::Fields::ForeignKey do
 
           context "when the relation stores ids as strings" do
 
-            let(:metadata) do
+            let(:association) do
               Comment.reflect_on_association(:account)
             end
 
             let(:field) do
-              described_class.new(:person_id, type: Object, metadata: metadata)
+              described_class.new(:person_id, type: Object, association: association)
             end
 
             let(:id_one) do
@@ -445,14 +445,14 @@ describe Mongoid::Fields::ForeignKey do
       end
     end
 
-    context "when the metadata is polymoprhic" do
+    context "when the association is polymoprhic" do
 
-      let(:metadata) do
+      let(:association) do
         Agent.reflect_on_association(:names)
       end
 
       let(:field) do
-        described_class.new(:nameable_id, type: Object, metadata: metadata)
+        described_class.new(:nameable_id, type: Object, association: association)
       end
 
       let(:value) do
@@ -464,7 +464,7 @@ describe Mongoid::Fields::ForeignKey do
       end
 
       it "does not change the foreign key" do
-        expect(evolved).to be(value)
+        expect(evolved).to eq(BSON::ObjectId.from_string(value))
       end
     end
   end
@@ -500,12 +500,8 @@ describe Mongoid::Fields::ForeignKey do
 
       context "when the array is object ids" do
 
-        let(:metadata) do
-          Mongoid::Relations::Metadata.new(
-            inverse_class_name: "Game",
-            name: :person,
-            relation: Mongoid::Relations::Referenced::In
-          )
+        let(:association) do
+          Game.relations["person"]
         end
 
         let(:field) do
@@ -514,7 +510,7 @@ describe Mongoid::Fields::ForeignKey do
             type: Array,
             default: [],
             identity: true,
-            metadata: metadata,
+            association: association,
             overwrite: true
           )
         end
@@ -589,12 +585,8 @@ describe Mongoid::Fields::ForeignKey do
 
       context "when the array is object ids" do
 
-        let(:metadata) do
-          Mongoid::Relations::Metadata.new(
-            inverse_class_name: "Game",
-            name: :person,
-            relation: Mongoid::Relations::Referenced::In
-          )
+        let(:association) do
+          Game.relations['person']
         end
 
         let(:field) do
@@ -603,7 +595,7 @@ describe Mongoid::Fields::ForeignKey do
             type: Object,
             default: nil,
             identity: true,
-            metadata: metadata,
+            association: association,
             overwrite: true
           )
         end

data/spec/mongoid/fields_spec.rb

@@ -816,7 +816,7 @@ describe Mongoid::Fields do
 
     context "when the field name conflicts with mongoid's internals" do
 
-      [:__metadata, :invalid].each do |meth|
+      [:_association, :invalid].each do |meth|
         context "when the field is named #{meth}" do
 
           it "raises an error" do
@@ -1171,7 +1171,7 @@ describe Mongoid::Fields do
     end
 
     let(:decimal) do
-      BigDecimal("1000000.00")
+      BigDecimal.new("1000000.00")
     end
 
     context "when setting to a big decimal" do

data/spec/mongoid/findable_spec.rb

@@ -10,7 +10,7 @@ describe Mongoid::Findable do
     end
 
     it "returns the distinct values for the field" do
-      expect(Band.distinct(:name).sort).to eq([ "Photek", "Tool" ])
+      expect(Band.distinct(:name)).to eq([ "Tool", "Photek" ])
     end
   end
 

data/spec/mongoid/indexable_spec.rb

@@ -89,8 +89,9 @@ describe Mongoid::Indexable do
         klass.create_indexes
       end
 
-      it "creates the indexes" do
-        expect(klass.collection.indexes.get(_type: 1)).to_not be_nil
+      it "creates the indexes by using specified background option" do
+        index = klass.collection.indexes.get(_type: 1)
+        expect(index[:background]).to eq(true)
       end
     end
 
@@ -104,12 +105,9 @@ describe Mongoid::Indexable do
         end
       end
 
-      before do
-        klass.create_indexes
-      end
-
       after do
         klass.remove_indexes
+        Mongoid::Config.background_indexing = false
       end
 
       let(:indexes) do
@@ -118,8 +116,20 @@ describe Mongoid::Indexable do
         end
       end
 
-      it "creates the indexes" do
-        expect(indexes.get(_type: 1)).to_not be_nil
+      it "creates the indexes by using default background_indexing option" do
+        klass.create_indexes
+
+        index = indexes.get(_type: 1)
+        expect(index[:background]).to eq(Mongoid::Config.background_indexing)
+      end
+
+      it "creates the indexes by using specified background_indexing option" do
+        Mongoid::Config.background_indexing = true
+
+        klass.create_indexes
+
+        index = indexes.get(_type: 1)
+        expect(index[:background]).to eq(true)
       end
     end
 

data/spec/mongoid/interceptable_spec.rb

@@ -526,6 +526,8 @@ describe Mongoid::Interceptable do
           end
 
           after(:all) do
+            # ActiveSupport may raise an error when trying to reset callbacks on all of Band's
+            # descendants, regardless of whether they have a particular callback defined.
             begin; Band.reset_callbacks(:rearrange); rescue; end
           end
 
@@ -597,7 +599,7 @@ describe Mongoid::Interceptable do
       it "raises an error" do
         expect {
           Band.has_and_belongs_to_many :tags, cascade_callbacks: true
-        }.to raise_error(Mongoid::Errors::InvalidOptions)
+        }.to raise_error(Mongoid::Errors::InvalidRelationOption)
       end
     end
 
@@ -1181,6 +1183,25 @@ describe Mongoid::Interceptable do
           end
         end
 
+        context 'when the parent is updated' do
+
+          let(:band) do
+            Band.create(name: "Moderat")
+          end
+
+          before do
+            band.update(records: [ { name: 'Black on Both Sides' }])
+          end
+
+          it 'executes the callback' do
+            expect(band.records.first.before_validation_called).to be true
+          end
+
+          it 'persists the change' do
+            expect(band.reload.records.first.before_validation_called).to be true
+          end
+        end
+
         context "when the child is persisted" do
 
           let(:band) do

data/spec/mongoid/matchable/elem_match_spec.rb

@@ -53,6 +53,19 @@ describe Mongoid::Matchable::ElemMatch do
           expect(matcher._matches?("$elemMatch" => {"a" => {"$in" => [1]}, "b" => {"$gt" => 1}})).to be true
         end
       end
+
+      context "when using a $not operator that matches" do
+
+        it "returns true" do
+          expect(matcher._matches?("$elemMatch" => {"a" => {"$not" => 4}})).to be true
+        end
+      end
+    end
+
+    context "when using symbols and a :$not operator that matches" do
+      it "returns true" do
+        expect(matcher._matches?(:$elemMatch => {"a" => {:$not => 4}})).to be true
+      end
     end
 
     context "when there is not a sub document that matches the criteria" do
@@ -74,6 +87,13 @@ describe Mongoid::Matchable::ElemMatch do
           expect(matcher._matches?("$elemMatch" => {"a" => {"$in" => [1]}, "b" => {"$gt" => 10}})).to be false
         end
       end
+
+      context "when using a $not operator that does not match" do
+
+        it "returns true" do
+          expect(matcher._matches?("$elemMatch" => {"a" => {"$not" => 1}})).to be true
+        end
+      end
     end
 
     context "when using a criteria that matches partially but not a single sub document" do

data/spec/mongoid/matchable_spec.rb

@@ -86,7 +86,7 @@ describe Mongoid::Matchable do
           let(:selector) do
             { "occupants.0" => "Tim" }
           end
-
+          
           it "returns true" do
             expect(document.locations.first._matches?(selector)).to be true
           end
@@ -774,31 +774,6 @@ describe Mongoid::Matchable do
         end
       end
 
-      context "with an $nor selector" do
-
-        context "when the attributes match" do
-
-          let(:selector) do
-            { "$nor" => [ { number: 10 }, { number: { "$gt" => 199 } } ] }
-          end
-
-          it "returns true" do
-            expect(document._matches?(selector)).to be true
-          end
-        end
-
-        context "when the attributes do not match" do
-
-          let(:selector) do
-            { "$nor" => [ { number: 10 }, { number: { "$gt" => 99 } } ] }
-          end
-
-          it "returns false" do
-            expect(document._matches?(selector)).to be false
-          end
-        end
-      end
-
       context "with a $size selector" do
 
         context "when the attributes match" do

data/spec/mongoid/persistable/incrementable_spec.rb

@@ -66,15 +66,15 @@ describe Mongoid::Persistable::Incrementable do
       context "when providing big decimal values" do
 
         let(:five) do
-          BigDecimal("5.0")
+          BigDecimal.new("5.0")
         end
 
         let(:neg_ten) do
-          BigDecimal("-10.0")
+          BigDecimal.new("-10.0")
         end
 
         let(:thirty) do
-          BigDecimal("30.0")
+          BigDecimal.new("30.0")
         end
 
         let!(:inc) do
@@ -151,15 +151,15 @@ describe Mongoid::Persistable::Incrementable do
       context "when providing big decimal values" do
 
         let(:five) do
-          BigDecimal("5.0")
+          BigDecimal.new("5.0")
         end
 
         let(:neg_ten) do
-          BigDecimal("-10.0")
+          BigDecimal.new("-10.0")
         end
 
         let(:thirty) do
-          BigDecimal("30.0")
+          BigDecimal.new("30.0")
         end
 
         let!(:inc) do

data/spec/mongoid/persistable/savable_spec.rb

@@ -190,7 +190,7 @@ describe Mongoid::Persistable::Savable do
               "name.first_name" => "Ryan"
             },
             "$push"=> {
-              "addresses" =>  { '$each' => [ { "_id" => address.id, "street" => "Bond St" } ] }
+              "addresses" => { '$each' => [ { "_id" => address.id, "street" => "Bond St" } ] }
             }
           })
         end
@@ -309,7 +309,7 @@ describe Mongoid::Persistable::Savable do
         expect {
           person.username = 'unloaded-attribute'
           person.save
-        }.to raise_error(Mongoid::Errors::ReadonlyAttribute)
+        }.to raise_error(ActiveModel::MissingAttributeError)
       end
 
       context 'when the changed attribute is aliased' do

data/spec/mongoid/persistable/settable_spec.rb

@@ -278,22 +278,7 @@ describe Mongoid::Persistable::Settable do
       end
     end
 
-    context 'when the field is a nested hash' do
-
-      context 'when the field is reset to an empty hash' do
-
-        before do
-          church.set('location' => {})
-        end
-
-        it 'updates the field locally' do
-          expect(church.location).to eq({})
-        end
-
-        it 'updates the field in the database' do
-          expect(church.reload.location).to eq({})
-        end
-      end
+    context 'when the field is a bested hash' do
 
       context 'when a leaf value in the nested hash is updated' do
 
@@ -315,25 +300,6 @@ describe Mongoid::Persistable::Settable do
         end
       end
 
-      context 'when a leaf value in the nested hash is updated to a number' do
-
-        let(:church) do
-          Church.new.tap do |a|
-            a.location = {'address' => {'city' => 'Berlin', 'street' => 'Yorckstr'}}
-            a.name = 'Church1'
-            a.save
-          end
-        end
-
-        before do
-          church.set('location.address.city' => 12345)
-        end
-
-        it 'updates the nested value to the correct value' do
-          expect(church.name).to eq('Church1')
-          expect(church.location).to eql({'address' => {'city' => 12345, 'street' => 'Yorckstr'}})
-        end
-      end
 
       context 'when the nested hash is many levels deep' do
 

data/spec/mongoid/persistable_spec.rb

@@ -57,7 +57,7 @@ describe Mongoid::Persistable do
             "$bit" => { "likes" => { :and => 13 }},
             "$set" => { "name" => "Placebo" },
             "$unset" => { "origin" => true }},
-           { session: nil }]
+            { :session => nil } ]
         end
 
         before do
@@ -83,8 +83,8 @@ describe Mongoid::Persistable do
             "$inc" => { "member_count" => 10 },
             "$bit" => { "likes" => { :and => 13 }},
             "$set" => { "name" => "Placebo" },
-            "$unset" => { "origin" => true }},
-           { :session => nil } ]
+            "$unset" => { "origin" => true } },
+            { :session => nil } ]
         end
 
         before do
@@ -107,12 +107,12 @@ describe Mongoid::Persistable do
       context "when given multiple operations of the same type" do
 
         let(:operations) do
-          [{
+         [{
             "$inc" => { "member_count" => 10, "other_count" => 10 },
             "$bit" => { "likes" => { :and => 13 }},
             "$set" => { "name" => "Placebo" },
             "$unset" => { "origin" => true }},
-            { session: nil }]
+            { :session => nil } ]
         end
 
         before do
@@ -149,7 +149,7 @@ describe Mongoid::Persistable do
             "$bit" => { "likes" => { :and => 13 }},
             "$set" => { "name" => "Placebo" },
             "$unset" => { "origin" => true }},
-            { session: nil }]
+            { :session => nil } ]
         end
 
         before do
@@ -200,6 +200,21 @@ describe Mongoid::Persistable do
         expect(document.atomically).to be true
       end
     end
+
+    context "when the block has no operations" do
+        before do
+          expect_any_instance_of(Mongo::Collection::View).to_not receive(:update_one)
+        end
+
+        let!(:update) do
+          document.atomically do
+          end
+        end
+
+        it "doesn't update the document" do
+          expect(document.reload.origin).to eq("London")
+        end
+    end
   end
 
   describe "#fail_due_to_valiation!" do