mongoid 6.4.8 → 7.0.0

data/spec/mongoid/association/depending_spec.rb

@@ -0,0 +1,613 @@
+require "spec_helper"
+
+describe Mongoid::Association::Depending do
+
+  around(:each) do |example|
+    relations_before = Person.relations
+    example.run
+    Person.relations = relations_before
+  end
+
+  describe "#apply_delete_dependencies!" do
+
+    let(:band) do
+      Band.new
+    end
+
+    context "when the association exists in the list of dependencies" do
+
+      context "when the association has no dependent strategy" do
+
+        before do
+          band.dependents.push(Band.relations["records"])
+        end
+
+        after do
+          band.dependents.delete(Band.relations["records"])
+        end
+
+        it "ignores the dependency" do
+          expect(band.apply_delete_dependencies!).to eq([Band.relations["records"]])
+        end
+      end
+    end
+  end
+
+  describe ".define_dependency!" do
+
+    let(:klass) do
+      Class.new.tap { |c| c.send(:include, Mongoid::Document) }
+    end
+
+    context "when the association metadata doesnt exist" do
+
+      before do
+        klass.dependents.push("nothing")
+      end
+
+      it "does not raise an error" do
+        expect {
+          klass.new.apply_delete_dependencies!
+        }.not_to raise_error
+      end
+    end
+
+    context "when a dependent option is provided" do
+
+      let!(:association) do
+        klass.has_many :posts, dependent: :destroy
+      end
+
+      after do
+        klass.relations.delete(association.name.to_s)
+      end
+
+      it "adds the relation to the dependents" do
+        expect(klass.dependents).to include(klass.relations["posts"])
+      end
+    end
+
+    context "when no dependent option is provided" do
+
+      let!(:association) do
+        klass.has_many :posts
+      end
+
+      after do
+        klass.relations.delete(association.name.to_s)
+      end
+
+      it "does not add a relation to the dependents" do
+        expect(klass.dependents).to_not include(association)
+      end
+    end
+
+    context 'when the class is defined more than once' do
+
+      let!(:association) do
+        klass.has_many :posts, dependent: :destroy
+        klass.has_many :posts, dependent: :destroy
+      end
+
+      it 'only creates the dependency once' do
+        expect(klass.dependents.size).to eq(1)
+      end
+    end
+  end
+
+  [:delete, :destroy].each do |method|
+
+    describe "##{method}" do
+
+      context "when cascading removals" do
+
+        context "when strategy is delete" do
+
+          let(:person) do
+            Person.create
+          end
+
+          let!(:post) do
+            person.posts.create(title: "Testing")
+          end
+
+          before do
+            person.send(method)
+          end
+
+          it "deletes the associated documents" do
+            expect {
+              Post.find(post.id)
+            }.to raise_error(Mongoid::Errors::DocumentNotFound)
+          end
+        end
+
+        context "when strategy is destroy" do
+
+          let(:person) do
+            Person.create
+          end
+
+          let!(:game) do
+            person.create_game(name: "Pong")
+          end
+
+          before do
+            person.send(method)
+          end
+
+          it "destroys the associated documents" do
+            expect {
+              Game.find(game.id)
+            }.to raise_error(Mongoid::Errors::DocumentNotFound)
+          end
+        end
+
+        context "when strategy is nullify" do
+
+          context "when nullifying a references many" do
+
+            let(:movie) do
+              Movie.create(title: "Bladerunner")
+            end
+
+            let!(:rating) do
+              movie.ratings.create(value: 10)
+            end
+
+            let(:from_db) do
+              Rating.find(rating.id)
+            end
+
+            before do
+              movie.send(method)
+            end
+
+            it "removes the references to the removed document" do
+              expect(from_db.ratable_id).to be_nil
+            end
+          end
+
+          context "when nullifying a references one" do
+
+            context "when the relation exists" do
+
+              let(:book) do
+                Book.create(title: "Neuromancer")
+              end
+
+              let!(:rating) do
+                book.create_rating(value: 10)
+              end
+
+              let(:from_db) do
+                Rating.find(rating.id)
+              end
+
+              before do
+                book.send(method)
+              end
+
+              it "removes the references to the removed document" do
+                expect(from_db.ratable_id).to be_nil
+              end
+            end
+
+            context "when the relation is nil" do
+
+              let(:book) do
+                Book.create(title: "Neuromancer")
+              end
+
+              it "returns nil" do
+                expect(book.send(method)).to be true
+              end
+            end
+          end
+
+          context "when nullifying a many to many" do
+
+            let(:person) do
+              Person.create
+            end
+
+            let!(:preference) do
+              person.preferences.create(name: "Setting")
+            end
+
+            let(:from_db) do
+              Preference.find(preference.id)
+            end
+
+            before do
+              person.send(method)
+            end
+
+            it "removes the references from the removed document" do
+              expect(person.preference_ids).to_not include(preference.id)
+            end
+
+            it "removes the references to the removed document" do
+              expect(from_db.person_ids).to_not include(person.id)
+            end
+          end
+        end
+
+        context "when dependent is restrict_with_error" do
+
+          context "when restricting a references many" do
+
+            let!(:association) do
+              Person.has_many :drugs, dependent: :restrict_with_exception
+            end
+
+            after do
+              Person.dependents.delete(association)
+              Person.has_many :drugs, validate: false
+            end
+
+            context "when the relation is empty" do
+
+              let(:person) do
+                Person.new drugs: []
+              end
+
+              it "raises no error" do
+                expect { person.send(method) }.to_not raise_error
+              end
+
+              it "deletes the parent" do
+                person.send(method)
+                expect(person).to be_destroyed
+              end
+            end
+
+            context "when the relation is not empty" do
+
+              let(:person) do
+                Person.new drugs: [Drug.new]
+              end
+
+              it "raises DeleteRestriction error" do
+                expect { person.send(method) }.to raise_error(Mongoid::Errors::DeleteRestriction)
+              end
+            end
+          end
+
+          context "when restricting a references one" do
+
+            let!(:association) do
+              Person.has_one :account, dependent: :restrict_with_exception
+            end
+
+            after do
+              Person.dependents.delete(association)
+              Person.has_one :account, validate: false
+            end
+
+            context "when the relation is empty" do
+
+              let(:person) do
+                Person.new account: nil
+              end
+
+              it "raises no error" do
+                expect { person.send(method) }.to_not raise_error
+              end
+
+              it "deletes the parent" do
+                person.send(method)
+                expect(person).to be_destroyed
+              end
+            end
+
+            context "when the relation is not empty" do
+
+              let(:person) do
+                Person.new account: Account.new(name: 'test')
+              end
+
+              it "raises DeleteRestriction error" do
+                expect { person.send(method) }.to raise_error(Mongoid::Errors::DeleteRestriction)
+              end
+            end
+          end
+
+          context "when restricting a many to many" do
+
+            let!(:association) do
+              Person.has_and_belongs_to_many :houses, dependent: :restrict_with_exception
+            end
+
+            after do
+              Person.dependents.delete(association)
+              Person.has_and_belongs_to_many :houses, validate: false
+            end
+
+            context "when the relation is empty" do
+
+              let(:person) do
+                Person.new houses: []
+              end
+
+              it "raises no error" do
+                expect { person.send(method) }.to_not raise_error
+              end
+
+              it "deletes the parent" do
+                person.send(method)
+                expect(person).to be_destroyed
+              end
+            end
+
+            context "when the relation is not empty" do
+
+              let(:person) do
+                Person.new houses: [House.new]
+              end
+
+              it "raises DeleteRestriction error" do
+                expect { person.send(method) }.to raise_error(Mongoid::Errors::DeleteRestriction)
+              end
+            end
+          end
+        end
+      end
+    end
+  end
+
+  context 'when the strategy is :delete_all' do
+
+    let(:person) do
+      Person.create
+    end
+
+    context "when cascading a has one" do
+
+      context "when the relation exists" do
+
+        let!(:home) do
+          person.create_home
+        end
+
+        before do
+          person.delete
+        end
+
+        it "deletes the relation" do
+          expect(home).to be_destroyed
+        end
+
+        it "persists the deletion" do
+          expect {
+            home.reload
+          }.to raise_error(Mongoid::Errors::DocumentNotFound)
+        end
+      end
+
+      context "when the relation does not exist" do
+
+        before do
+          person.delete
+        end
+
+        it "deletes the base document" do
+          expect(person).to be_destroyed
+        end
+      end
+    end
+
+    context "when cascading a has many" do
+
+      context "when the relation has documents" do
+
+        let!(:post_one) do
+          person.posts.create(title: "one")
+        end
+
+        let!(:post_two) do
+          person.posts.create(title: "two")
+        end
+
+        context "when the documents are in memory" do
+
+          before do
+            expect(post_one).to receive(:delete).never
+            expect(post_two).to receive(:delete).never
+            person.delete
+          end
+
+          it "deletes the first document" do
+            expect(post_one).to be_destroyed
+          end
+
+          it "deletes the second document" do
+            expect(post_two).to be_destroyed
+          end
+
+          it "unbinds the first document" do
+            expect(post_one.person).to be_nil
+          end
+
+          it "unbinds the second document" do
+            expect(post_two.person).to be_nil
+          end
+
+          it "removes the documents from the relation" do
+            expect(person.posts).to be_empty
+          end
+
+          it "persists the first deletion" do
+            expect {
+              post_one.reload
+            }.to raise_error(Mongoid::Errors::DocumentNotFound)
+          end
+
+          it "persists the second deletion" do
+            expect {
+              post_two.reload
+            }.to raise_error(Mongoid::Errors::DocumentNotFound)
+          end
+        end
+      end
+    end
+  end
+
+  context 'when the strategy is :destroy' do
+
+    let!(:association) do
+      Person.has_many :destroyable_posts, class_name: "Post", dependent: :destroy
+    end
+
+    after do
+      Person.dependents.delete(association)
+    end
+
+    let(:person) do
+      Person.new
+    end
+
+    let(:post) do
+      Post.new
+    end
+
+    context "when the documents exist" do
+
+      before do
+        expect(post).to receive(:destroy)
+        person.destroyable_posts << post
+      end
+
+      it "destroys all documents in the relation" do
+        person.delete
+      end
+    end
+
+    context "when no documents exist" do
+
+      before do
+        expect(post).to receive(:destroy).never
+      end
+
+      it "it does not destroy the relation" do
+        person.delete
+      end
+    end
+  end
+
+  context 'when the strategy is :nullify' do
+
+    let!(:association) do
+      Person.has_many :nullifyable_posts, class_name: "Post", dependent: :nullify
+    end
+
+    after do
+      Person.dependents.delete(association)
+    end
+
+    let(:person) do
+      Person.new
+    end
+
+    let(:posts_relation) do
+      person.posts
+    end
+
+    before do
+      allow(person).to receive(:nullifyable_posts).and_return(posts_relation)
+      expect(posts_relation).to receive(:nullify)
+    end
+
+    it "nullifies the relation" do
+      person.delete
+    end
+  end
+
+  context 'when the strategy is :restrict_with_exception' do
+
+    let(:person) do
+      Person.new
+    end
+
+    let(:post) do
+      Post.new
+    end
+
+    let!(:association) do
+      Person.has_many :restrictable_posts, class_name: "Post", dependent: :restrict_with_exception
+    end
+
+    after do
+      Person.dependents.delete(association)
+    end
+
+    context 'when there are related objects' do
+
+      before do
+        person.restrictable_posts << post
+        expect(post).to receive(:delete).never
+        expect(post).to receive(:destroy).never
+      end
+
+      it 'raises an exception and leaves the related one intact' do
+        expect { person.delete }.to raise_exception(Mongoid::Errors::DeleteRestriction)
+      end
+    end
+
+    context 'when there are no related objects' do
+
+      before do
+        expect(post).to receive(:delete).never
+        expect(post).to receive(:destroy).never
+      end
+
+      it 'deletes the object and leaves the other one intact' do
+        expect(person.delete).to be(true)
+      end
+    end
+  end
+
+  context 'when the strategy is :restrict_with_error' do
+
+    let(:person) do
+      Person.new
+    end
+
+    let(:post) do
+      Post.new
+    end
+
+    let!(:association) do
+      Person.has_many :restrictable_posts, class_name: "Post", dependent: :restrict_with_error
+    end
+
+    after do
+      Person.dependents.delete(association)
+    end
+
+    context 'when there are related objects' do
+
+      before do
+        person.restrictable_posts << post
+      end
+
+      it 'adds an error to the parent object' do
+        expect(person.delete).to be(false)
+        expect(person.errors[:restrictable_posts].first).to be(
+          Mongoid::Association::Depending::RESTRICT_ERROR_MSG)
+      end
+    end
+
+    context 'when there are no related objects' do
+
+      before do
+        expect(post).to receive(:delete).never
+        expect(post).to receive(:destroy).never
+      end
+
+      it 'deletes the object and leaves the other one intact' do
+        expect(person.delete).to be(true)
+      end
+    end
+  end
+end

data/spec/mongoid/{relations → association}/eager_spec.rb

@@ -1,6 +1,6 @@
 require "spec_helper"
 
-describe Mongoid::Relations::Eager do
+describe Mongoid::Association::EagerLoadable do
 
   describe ".preload" do
 
@@ -122,12 +122,12 @@ describe Mongoid::Relations::Eager do
         Person.all.to_a
       end
 
-      let(:posts_metadata) do
+      let(:posts_association) do
         Person.reflect_on_association(:posts)
       end
 
       it "runs the has_many preload" do
-        expect(Mongoid::Relations::Eager::HasMany).to receive(:new).with([posts_metadata], docs).once.and_call_original
+        expect(Mongoid::Association::Referenced::HasMany::Eager).to receive(:new).with([posts_association], docs).once.and_call_original
 
         context.eager_load(docs)
       end
@@ -154,31 +154,31 @@ describe Mongoid::Relations::Eager do
         Person.all.to_a
       end
 
-      let(:posts_metadata) do
+      let(:posts_association) do
         Person.reflect_on_association(:posts)
       end
 
-      let(:houses_metadata) do
+      let(:houses_association) do
         Person.reflect_on_association(:houses)
       end
 
-      let(:cat_metadata) do
+      let(:cat_association) do
         Person.reflect_on_association(:cat)
       end
 
       it "runs the has_many preload" do
-        expect(Mongoid::Relations::Eager::HasMany).to receive(:new).with([posts_metadata], docs).once.and_call_original
+        expect(Mongoid::Association::Referenced::HasMany::Eager).to receive(:new).with([posts_association], docs).once.and_call_original
 
         context.eager_load(docs)
       end
 
       it "runs the has_one preload" do
-        expect(Mongoid::Relations::Eager::HasOne).to receive(:new).with([cat_metadata], docs).once.and_call_original
+        expect(Mongoid::Association::Referenced::HasOne::Eager).to receive(:new).with([cat_association], docs).once.and_call_original
         context.eager_load(docs)
       end
 
       it "runs the has_and_belongs_to_many preload" do
-        expect(Mongoid::Relations::Eager::HasAndBelongsToMany).to receive(:new).with([houses_metadata], docs).once.and_call_original
+        expect(Mongoid::Association::Referenced::HasAndBelongsToMany::Eager).to receive(:new).with([houses_association], docs).once.and_call_original
         context.eager_load(docs)
       end
 
@@ -233,16 +233,16 @@ describe Mongoid::Relations::Eager do
         Person.all.to_a
       end
 
-      let(:book_metadata) do
+      let(:book_association) do
         Person.reflect_on_association(:book)
       end
 
-      let(:cat_metadata) do
+      let(:cat_association) do
         Person.reflect_on_association(:cat)
       end
 
       it "runs the has_one preload" do
-        expect(Mongoid::Relations::Eager::HasOne).to receive(:new).with([book_metadata, cat_metadata], docs).once.and_call_original
+        expect(Mongoid::Association::Referenced::HasOne::Eager).to receive(:new).with([book_association, cat_association], docs).once.and_call_original
         context.eager_load(docs)
       end
     end

data/spec/mongoid/{relations → association/embedded}/cyclic_spec.rb

@@ -1,6 +1,6 @@
 require "spec_helper"
 
-describe Mongoid::Relations::Cyclic do
+describe Mongoid::Association::Embedded::Cyclic do
 
   describe ".recursively_embeds_many" do