mongoid 6.4.8 → 7.0.0

data/spec/mongoid/{relations → association}/polymorphic_spec.rb

@@ -1,6 +1,6 @@
 require "spec_helper"
 
-describe Mongoid::Relations::Polymorphic do
+describe "Polymorphic Associations" do
 
   describe "#polymorph" do
 
@@ -12,16 +12,8 @@ describe Mongoid::Relations::Polymorphic do
 
       context "when the relation stores a foreign key" do
 
-        let(:metadata) do
-          Mongoid::Relations::Metadata.new(
-            name: :ratable,
-            polymorphic: true,
-            relation: Mongoid::Relations::Referenced::In
-          )
-        end
-
-        let!(:polymorphed) do
-          klass.polymorph(metadata)
+        let!(:association) do
+          klass.belongs_to :ratable, polymorphic: true
         end
 
         it "sets polymorphic to true" do
@@ -31,24 +23,12 @@ describe Mongoid::Relations::Polymorphic do
         it "adds the foreign key type field" do
           expect(klass.fields["ratable_type"]).to_not be_nil
         end
-
-        it "returns self" do
-          expect(polymorphed).to eq(klass)
-        end
       end
 
       context "when the relation does not store a foreign key" do
 
-        let(:metadata) do
-          Mongoid::Relations::Metadata.new(
-            name: :ratings,
-            as: :ratable,
-            relation: Mongoid::Relations::Referenced::Many
-          )
-        end
-
-        before do
-          klass.polymorph(metadata)
+        let!(:association) do
+          klass.has_many :ratings, as: :ratable
         end
 
         it "sets polymorphic to true" do
@@ -67,15 +47,8 @@ describe Mongoid::Relations::Polymorphic do
 
     context "when the relation is not polymorphic" do
 
-      let(:metadata) do
-        Mongoid::Relations::Metadata.new(
-          name: :ratings,
-          relation: Mongoid::Relations::Referenced::Many
-        )
-      end
-
-      before do
-        klass.polymorph(metadata)
+      let!(:association) do
+        klass.has_many :ratings
       end
 
       it "sets polymorphic to false" do

data/spec/mongoid/{relations/bindings/referenced/in_spec.rb → association/referenced/belongs_to/binding_spec.rb}

@@ -1,6 +1,6 @@
 require "spec_helper"
 
-describe Mongoid::Relations::Bindings::Referenced::In do
+describe Mongoid::Association::Referenced::BelongsTo::Binding do
 
   let(:person) do
     Person.new
@@ -14,11 +14,11 @@ describe Mongoid::Relations::Bindings::Referenced::In do
     Post.new
   end
 
-  let(:game_metadata) do
+  let(:game_association) do
     Game.relations["person"]
   end
 
-  let(:post_metadata) do
+  let(:post_association) do
     Post.relations["person"]
   end
 
@@ -27,7 +27,7 @@ describe Mongoid::Relations::Bindings::Referenced::In do
     context "when the child of an references one" do
 
       let(:binding) do
-        described_class.new(game, person, game_metadata)
+        described_class.new(game, person, game_association)
       end
 
       context "when the document is bindable with default pk" do
@@ -90,7 +90,7 @@ describe Mongoid::Relations::Bindings::Referenced::In do
     context "when the child of an references many" do
 
       let(:binding) do
-        described_class.new(post, person, post_metadata)
+        described_class.new(post, person, post_association)
       end
 
       context "when the document is bindable" do
@@ -129,7 +129,7 @@ describe Mongoid::Relations::Bindings::Referenced::In do
     context "when the child of an references one" do
 
       let(:binding) do
-        described_class.new(game, person, game_metadata)
+        described_class.new(game, person, game_association)
       end
 
       context "when the document is unbindable" do
@@ -162,7 +162,7 @@ describe Mongoid::Relations::Bindings::Referenced::In do
     context "when the child of an references many" do
 
       let(:binding) do
-        described_class.new(post, person, post_metadata)
+        described_class.new(post, person, post_association)
       end
 
       context "when the document is unbindable" do

data/spec/mongoid/{relations/builders/referenced/in_spec.rb → association/referenced/belongs_to/buildable_spec.rb}

@@ -1,6 +1,6 @@
 require "spec_helper"
 
-describe Mongoid::Relations::Builders::Referenced::In do
+describe Mongoid::Association::Referenced::BelongsTo::Buildable do
 
   let(:base) do
     double
@@ -8,45 +8,28 @@ describe Mongoid::Relations::Builders::Referenced::In do
 
   describe "#build" do
 
-    let(:criteria) do
-      Person.where(_id: object_id)
+    let(:document) do
+      association.build(base, object)
     end
 
-    let(:metadata) do
-      double(
-        klass: Person,
-        name: :person,
-        foreign_key: "person_id",
-        criteria: criteria
-      )
-    end
-
-    let(:builder) do
-      described_class.new(base, metadata, object)
+    let(:association) do
+      Post.relations['person']
     end
 
     context "when provided an id" do
 
       context "when the object is an object id" do
 
-        let(:object_id) do
-          BSON::ObjectId.new
+        let!(:person) do
+          Person.create(_id: object)
         end
 
         let(:object) do
-          object_id
-        end
-
-        let(:person) do
-          double
+          BSON::ObjectId.new
         end
 
         before do
-          expect(criteria).to receive(:first).and_return(person)
-        end
-
-        let!(:document) do
-          builder.build
+          expect(Person).to receive(:where).with(association.primary_key => object).and_call_original
         end
 
         it "sets the document" do
@@ -54,40 +37,52 @@ describe Mongoid::Relations::Builders::Referenced::In do
         end
       end
 
-      context "when the object is an integer" do
+      context 'when the id is nil' do
+
+        let(:object) do
+          nil
+        end
 
         before do
-          Person.field :_id, overwrite: true, type: Integer
+          expect(Person).not_to receive(:where)
         end
 
-        after do
-          Person.field(
-            :_id,
-            overwrite: true,
-            type: BSON::ObjectId,
-            pre_processed: true,
-            default: ->{ BSON::ObjectId.new }
-          )
+        it 'returns nil' do
+          expect(document).to be_nil
         end
+      end
 
-        let(:object_id) do
-          666
+      context "when the id does not correspond to a document in the database" do
+
+        let!(:person) do
+          Person.create
         end
 
         let(:object) do
-          object_id
+          BSON::ObjectId.new
         end
 
-        let(:person) do
-          double
+        before do
+          expect(Person).to receive(:where).with(association.primary_key => object).and_call_original
         end
 
-        before do
-          expect(criteria).to receive(:first).and_return(person)
+        it 'returns nil' do
+          expect(document).to be_nil
+        end
+      end
+
+      context "when the object is an integer" do
+
+        let!(:person) do
+          Person.create(_id: object)
+        end
+
+        let(:object) do
+          666
         end
 
-        let!(:document) do
-          builder.build
+        before do
+          expect(Person).to receive(:where).with(association.primary_key => object).and_call_original
         end
 
         it "sets the document" do
@@ -98,50 +93,22 @@ describe Mongoid::Relations::Builders::Referenced::In do
 
     context "when provided a object" do
 
-      let(:object) do
-        Person.new
+      let!(:person) do
+        Person.create
       end
 
-      let(:builder) do
-        described_class.new(base, nil, object)
+      let(:object) do
+        Person.new
       end
 
-      let(:document) do
-        builder.build
+      before do
+        expect(Person).not_to receive(:where)
       end
 
       it "returns the object" do
         expect(document).to eq(object)
       end
     end
-  end
-
-  describe "#build" do
-
-    let(:game) do
-      Game.new
-    end
-
-    context "when no document found in the database" do
-
-      context "when the id is nil" do
-
-        it "returns nil" do
-          expect(game.person).to be_nil
-        end
-      end
-
-      context "when the id is incorrect" do
-
-        before do
-          game.person_id = BSON::ObjectId.new
-        end
-
-        it "returns nil" do
-          expect(game.person).to be_nil
-        end
-      end
-    end
 
     context "when the document is persisted" do
 

data/spec/mongoid/{relations/eager/belongs_to_spec.rb → association/referenced/belongs_to/eager_spec.rb}

@@ -1,6 +1,6 @@
 require "spec_helper"
 
-describe Mongoid::Relations::Eager::BelongsTo do
+describe Mongoid::Association::Referenced::BelongsTo::Eager do
 
   describe ".grouped_docs" do
 
@@ -12,13 +12,13 @@ describe Mongoid::Relations::Eager::BelongsTo do
       Person.create!
     end
 
-    let(:metadata) do
+    let(:association) do
       Post.reflect_on_association(:person)
     end
 
     let(:eager) do
-      described_class.new([metadata], docs).tap do |b|
-        b.shift_metadata
+      described_class.new([association], docs).tap do |b|
+        b.send(:shift_association)
       end
     end
 
@@ -27,7 +27,7 @@ describe Mongoid::Relations::Eager::BelongsTo do
     end
 
     it "aggregates by the parent id" do
-      expect(eager.grouped_docs.keys).to eq([person.id])
+      expect(eager.send(:grouped_docs).keys).to eq([person.id])
     end
   end
 
@@ -41,13 +41,13 @@ describe Mongoid::Relations::Eager::BelongsTo do
       Person.create!
     end
 
-    let(:metadata) do
+    let(:association) do
       Post.reflect_on_association(:person)
     end
 
     let(:eager) do
-      described_class.new([metadata], docs).tap do |b|
-        b.shift_metadata
+      described_class.new([association], docs).tap do |b|
+        b.send(:shift_association)
       end
     end
 
@@ -59,7 +59,7 @@ describe Mongoid::Relations::Eager::BelongsTo do
       docs.each do |doc|
         expect(doc).to receive(:set_relation).with(:person, :foo)
       end
-      eager.set_on_parent(person.id, :foo)
+      eager.send(:set_on_parent, person.id, :foo)
     end
   end
 

data/spec/mongoid/{relations/referenced/in_spec.rb → association/referenced/belongs_to/proxy_spec.rb}

@@ -1,6 +1,6 @@
 require "spec_helper"
 
-describe Mongoid::Relations::Referenced::In do
+describe Mongoid::Association::Referenced::BelongsTo::Proxy do
 
   before(:all) do
     Person.reset_callbacks(:validate)
@@ -78,8 +78,8 @@ describe Mongoid::Relations::Referenced::In do
         expect(address.account).to eq(account)
       end
 
-      it "does not erase the metadata" do
-        expect(address.__metadata).to_not be_nil
+      it "does not erase the association metadata" do
+        expect(address._association).to_not be_nil
       end
 
       it "allows saving of the embedded document" do
@@ -106,7 +106,7 @@ describe Mongoid::Relations::Referenced::In do
           end
 
           it "sets the target of the relation" do
-            expect(game.person.target).to eq(person)
+            expect(game.person._target).to eq(person)
           end
 
           it "sets the foreign key on the relation" do
@@ -141,7 +141,7 @@ describe Mongoid::Relations::Referenced::In do
           end
 
           it "sets the target of the relation" do
-            expect(game.person.target).to eq(person)
+            expect(game.person._target).to eq(person)
           end
 
           it "sets the foreign key of the relation" do
@@ -203,7 +203,7 @@ describe Mongoid::Relations::Referenced::In do
           end
 
           it "sets the target of the relation" do
-            expect(rating.ratable.target).to eq(bar)
+            expect(rating.ratable._target).to eq(bar)
           end
 
           it "sets the foreign key on the relation" do
@@ -238,7 +238,7 @@ describe Mongoid::Relations::Referenced::In do
           end
 
           it "sets the target of the relation" do
-            expect(rating.ratable.target).to eq(bar)
+            expect(rating.ratable._target).to eq(bar)
           end
 
           it "sets the foreign key of the relation" do
@@ -317,7 +317,7 @@ describe Mongoid::Relations::Referenced::In do
           end
 
           it "sets the target of the relation" do
-            expect(post.person.target).to eq(person)
+            expect(post.person._target).to eq(person)
           end
 
           it "sets the foreign key on the relation" do
@@ -344,7 +344,7 @@ describe Mongoid::Relations::Referenced::In do
           end
 
           it "sets the target of the relation" do
-            expect(post.person.target).to eq(person)
+            expect(post.person._target).to eq(person)
           end
 
           it "sets the foreign key of the relation" do
@@ -388,7 +388,7 @@ describe Mongoid::Relations::Referenced::In do
 
           it "should assign as expected" do
             eye.suspended_in = eye_bowl
-            expect(eye.suspended_in.target).to eq(eye_bowl)
+            expect(eye.suspended_in._target).to eq(eye_bowl)
           end
         end
 
@@ -409,7 +409,7 @@ describe Mongoid::Relations::Referenced::In do
             end
 
             it "sets the target of the relation" do
-              expect(rating.ratable.target).to eq(movie)
+              expect(rating.ratable._target).to eq(movie)
             end
 
             it "sets the foreign key on the relation" do
@@ -436,7 +436,7 @@ describe Mongoid::Relations::Referenced::In do
             end
 
             it "sets the target of the relation" do
-              expect(rating.ratable.target).to eq(movie)
+              expect(rating.ratable._target).to eq(movie)
             end
 
             it "sets the foreign key of the relation" do
@@ -470,6 +470,13 @@ describe Mongoid::Relations::Referenced::In do
 
       context "when relation is has_one" do
 
+        around(:each) do |example|
+          original_account_dependents = Account.dependents
+          Account.dependents = []
+          example.run
+          Account.dependents = original_account_dependents
+        end
+
         before do
           Account.belongs_to :person, dependent: :destroy
           Person.has_one :account
@@ -514,6 +521,13 @@ describe Mongoid::Relations::Referenced::In do
 
       context "when relation is has_many" do
 
+        around(:each) do |example|
+          original_drug_dependents = Drug.dependents
+          Drug.dependents = []
+          example.run
+          Drug.dependents = original_drug_dependents
+        end
+
         before do
           Drug.belongs_to :person, dependent: :destroy
           Person.has_many :drugs
@@ -562,8 +576,15 @@ describe Mongoid::Relations::Referenced::In do
 
       context "when relation is has_one" do
 
+        around(:each) do |example|
+          original_account_dependents = Account.dependents
+          Account.dependents = []
+          example.run
+          Account.dependents = original_account_dependents
+        end
+
         before do
-          Account.belongs_to :person, dependent: :delete
+          Account.belongs_to :person, dependent: :delete_all
           Person.has_one :account
           person.account = account
           person.save
@@ -595,8 +616,15 @@ describe Mongoid::Relations::Referenced::In do
 
       context "when relation is has_many" do
 
+        around(:each) do |example|
+          original_drug_dependents = Drug.dependents
+          Drug.dependents = []
+          example.run
+          Drug.dependents = original_drug_dependents
+        end
+
         before do
-          Drug.belongs_to :person, dependent: :delete
+          Drug.belongs_to :person, dependent: :delete_all
           Person.has_many :drugs
           person.drugs = [drug]
           person.save
@@ -643,6 +671,13 @@ describe Mongoid::Relations::Referenced::In do
 
       context "when relation is has_one" do
 
+        around(:each) do |example|
+          original_account_dependents = Account.dependents
+          Account.dependents = []
+          example.run
+          Account.dependents = original_account_dependents
+        end
+
         before do
           Account.belongs_to :person, dependent: :nullify
           Person.has_one :account
@@ -675,6 +710,13 @@ describe Mongoid::Relations::Referenced::In do
 
       context "when relation is has_many" do
 
+        around(:each) do |example|
+          original_drug_dependents = Drug.dependents
+          Drug.dependents = []
+          example.run
+          Drug.dependents = original_drug_dependents
+        end
+
         before do
           Drug.belongs_to :person, dependent: :nullify
           Person.has_many :drugs
@@ -980,48 +1022,6 @@ describe Mongoid::Relations::Referenced::In do
     end
   end
 
-  describe ".builder" do
-
-    let(:builder_klass) do
-      Mongoid::Relations::Builders::Referenced::In
-    end
-
-    let(:document) do
-      double
-    end
-
-    let(:metadata) do
-      double(extension?: false)
-    end
-
-    it "returns the embedded in builder" do
-      expect(
-        described_class.builder(nil, metadata, document)
-      ).to be_a_kind_of(builder_klass)
-    end
-  end
-
-  describe ".embedded?" do
-
-    it "returns false" do
-      expect(described_class).to_not be_embedded
-    end
-  end
-
-  describe ".foreign_key_suffix" do
-
-    it "returns _id" do
-      expect(described_class.foreign_key_suffix).to eq("_id")
-    end
-  end
-
-  describe ".macro" do
-
-    it "returns belongs_to" do
-      expect(described_class.macro).to eq(:belongs_to)
-    end
-  end
-
   describe "#respond_to?" do
 
     let(:person) do
@@ -1047,40 +1047,6 @@ describe Mongoid::Relations::Referenced::In do
     end
   end
 
-  describe ".stores_foreign_key?" do
-
-    it "returns true" do
-      expect(described_class.stores_foreign_key?).to be true
-    end
-  end
-
-  describe ".valid_options" do
-
-    it "returns the valid options" do
-      expect(described_class.valid_options).to eq(
-        [
-          :autobuild,
-          :autosave,
-          :dependent,
-          :foreign_key,
-          :index,
-          :polymorphic,
-          :primary_key,
-          :touch,
-          :optional,
-          :required
-        ]
-      )
-    end
-  end
-
-  describe ".validation_default" do
-
-    it "returns false" do
-      expect(described_class.validation_default).to be false
-    end
-  end
-
   context "when the relation is self referencing" do
 
     let(:game_one) do
@@ -1280,7 +1246,7 @@ describe Mongoid::Relations::Referenced::In do
 
       before do
         Person.collection.find({ _id: person_one.id }).
-          update_one({ "$set" => { title: "Madam" }})
+            update_one({ "$set" => { title: "Madam" }})
       end
 
       let(:reloaded) do