mongoid 6.4.8 → 7.0.0

data/lib/mongoid/matchable.rb

@@ -11,7 +11,6 @@ require "mongoid/matchable/lte"
 require "mongoid/matchable/ne"
 require "mongoid/matchable/nin"
 require "mongoid/matchable/or"
-require "mongoid/matchable/nor"
 require "mongoid/matchable/size"
 require "mongoid/matchable/elem_match"
 require "mongoid/matchable/regexp"
@@ -41,7 +40,6 @@ module Mongoid
       "$ne" => Ne,
       "$nin" => Nin,
       "$or" => Or,
-      "$nor" => Nor,
       "$size" => Size
     }.with_indifferent_access.freeze
 
@@ -126,7 +124,6 @@ module Mongoid
           case key.to_s
             when "$or" then Or.new(value, document)
             when "$and" then And.new(value, document)
-            when "$nor" then Nor.new(value, document)
             else Default.new(extract_attribute(document, key))
           end
         end

data/lib/mongoid/persistable/creatable.rb

@@ -63,7 +63,7 @@ module Mongoid
           selector = _parent.atomic_selector
           _root.collection.find(selector).update_one(
               positionally(selector, atomic_inserts),
-              session: _session)
+              session: session)
         end
       end
 
@@ -78,7 +78,7 @@ module Mongoid
       #
       # @since 4.0.0
       def insert_as_root
-        collection.insert_one(as_attributes, session: _session)
+        collection.insert_one(as_attributes, session: session)
       end
 
       # Post process an insert, which sets the new record attribute to false

data/lib/mongoid/persistable/deletable.rb

@@ -21,10 +21,12 @@ module Mongoid
       def delete(options = {})
         raise Errors::ReadonlyDocument.new(self.class) if readonly?
         prepare_delete do
-          if embedded?
-            delete_as_embedded(options)
-          else
-            delete_as_root
+          unless options[:persist] == false
+            if embedded?
+              delete_as_embedded(options)
+            else
+              delete_as_root
+            end
           end
         end
       end
@@ -64,7 +66,7 @@ module Mongoid
           selector = _parent.atomic_selector
           _root.collection.find(selector).update_one(
               positionally(selector, atomic_deletes),
-              session: _session)
+              session: session)
         end
         true
       end
@@ -80,7 +82,7 @@ module Mongoid
       #
       # @since 4.0.0
       def delete_as_root
-        collection.find(atomic_selector).delete_one(session: _session)
+        collection.find(atomic_selector).delete_one(session: session)
         true
       end
 
@@ -113,11 +115,10 @@ module Mongoid
       #
       # @since 4.0.0
       def prepare_delete
-        cascade!
+        return false unless catch(:abort) { apply_delete_dependencies! }
         yield(self)
         freeze
         self.destroyed = true
-        true
       end
 
       module ClassMethods

data/lib/mongoid/persistable/incrementable.rb

@@ -28,7 +28,7 @@ module Mongoid
             attributes[field] = (current || 0) + increment
             ops[atomic_attribute_name(field)] = increment
           end
-          { "$inc" => ops }
+          { "$inc" => ops } unless ops.empty?
         end
       end
     end

data/lib/mongoid/persistable/logical.rb

@@ -30,7 +30,7 @@ module Mongoid
             attributes[field] = value
             ops[atomic_attribute_name(field)] = values
           end
-          { "$bit" => ops }
+          { "$bit" => ops } unless ops.empty?
         end
       end
     end

data/lib/mongoid/persistable/settable.rb

@@ -25,15 +25,15 @@ module Mongoid
 
             field_and_value_hash = hasherizer(field.split('.'), value)
             field = field_and_value_hash.keys.first.to_s
-            value = field_and_value_hash[field]
 
-            if fields[field] && fields[field].type == Hash && attributes.key?(field) && Hash === value && !value.empty?
+            if fields[field] && fields[field].type == Hash && attributes.key?(field)
               merger = proc { |key, v1, v2| Hash === v1 && Hash === v2 ? v1.merge(v2, &merger) : v2 }
-              value = (attributes[field] || {}).merge(value, &merger)
+              value = (attributes[field] || {}).merge(field_and_value_hash[field], &merger)
+              process_attribute(field.to_s, value)
+            else
+              process_attribute(field.to_s, field_and_value_hash[field])
             end
 
-            process_attribute(field.to_s, value)
-
             unless relations.include?(field.to_s)
               ops[atomic_attribute_name(field)] = attributes[field]
             end

data/lib/mongoid/persistable/updatable.rb

@@ -134,9 +134,9 @@ module Mongoid
           unless updates.empty?
             coll = collection(_root)
             selector = atomic_selector
-            coll.find(selector).update_one(positionally(selector, updates), session: _session)
+            coll.find(selector).update_one(positionally(selector, updates), session: session)
             conflicts.each_pair do |key, value|
-              coll.find(selector).update_one(positionally(selector, { key => value }), session: _session)
+              coll.find(selector).update_one(positionally(selector, { key => value }), session: session)
             end
           end
         end

data/lib/mongoid/persistable/upsertable.rb

@@ -22,7 +22,7 @@ module Mongoid
       def upsert(options = {})
         prepare_upsert(options) do
           collection.find(atomic_selector).update_one(
-              as_attributes, upsert: true, session: _session)
+              as_attributes, upsert: true, session: session)
         end
       end
 

data/lib/mongoid/persistable.rb

@@ -162,10 +162,9 @@ module Mongoid
     # @since 4.0.0
     def process_atomic_operations(operations)
       operations.each do |field, value|
-        as_writable_attribute!(field, value) do |access|
-          yield(access, value)
-          remove_change(access)
-        end
+        access = database_field_name(field)
+        yield(access, value)
+        remove_change(access)
       end
     end
 
@@ -202,9 +201,9 @@ module Mongoid
     #
     # @since 4.0.0
     def persist_atomic_operations(operations)
-      if persisted? && operations
+      if persisted? && operations && !operations.empty?
         selector = atomic_selector
-        _root.collection.find(selector).update_one(positionally(selector, operations), session: _session)
+        _root.collection.find(selector).update_one(positionally(selector, operations), session: session)
       end
     end
   end

data/lib/mongoid/persistence_context.rb

@@ -107,10 +107,6 @@ module Mongoid
     #
     # @since 6.0.0
     def client
-      client_options = send(:client_options)
-      if client_options[:read].is_a?(Symbol)
-        client_options = client_options.merge(read: {mode: client_options[:read]})
-      end
       @client ||= (client = Clients.with_name(client_name)
                     client = client.use(database_name) if database_name_option
                     client.with(client_options))
@@ -212,7 +208,7 @@ module Mongoid
         if context = get(object)
           context.client.close unless (context.cluster.equal?(cluster) || cluster.nil?)
         end
-      ensure
+      ensure  
         Thread.current["[mongoid][#{object.object_id}]:context"] = nil
       end
     end

data/lib/mongoid/query_cache.rb

@@ -159,14 +159,11 @@ module Mongoid
       private
 
       def process(result)
-        documents = super
-
-        if @cursor_id.zero? && !@after_first_batch
-          @cached_documents ||= []
-          @cached_documents.concat(documents)
-        end
-
-        @after_first_batch = true
+        @remaining -= result.returned_count if limited?
+        @cursor_id = result.cursor_id
+        @coll_name ||= result.namespace.sub("#{database.name}.", '') if result.namespace
+        documents = result.documents
+        (@cached_documents ||= []).concat(documents)
         documents
       end
     end
@@ -221,40 +218,20 @@ module Mongoid
       #
       # @since 5.0.0
       def each
-        if system_collection? || !QueryCache.enabled? || (respond_to?(:write?, true) && write?)
+        if system_collection? || !QueryCache.enabled?
           super
         else
-          @cursor = nil
-          unless @cursor = cached_cursor
-
-            if driver_supports_cursor_sessions?
-              session = client.send(:get_session, @options)
-              read_with_retry(session, server_selector) do |server|
-                result = send_initial_query(server, session)
-                @cursor = get_cursor(result, server, session)
-              end
-            else
-              read_with_retry do
-                server = server_selector.select_server(cluster)
-                result = send_initial_query(server)
-                @cursor = get_cursor(result, server)
-              end
-            end
-          end
-
-          if block_given?
-            if limit && limit != -1
-              @cursor.to_a[0...limit].each do |doc|
-                yield doc
-              end
-            else
-              @cursor.each do |doc|
-                yield doc
-              end
+          unless cursor = cached_cursor
+            read_with_retry do
+              server = server_selector.select_server(cluster)
+              cursor = CachedCursor.new(view, send_initial_query(server), server)
+              QueryCache.cache_table[cache_key] = cursor
             end
-          else
-            @cursor.to_enum
           end
+          cursor.each do |doc|
+            yield doc
+          end if block_given?
+          cursor
         end
       end
 
@@ -264,28 +241,12 @@ module Mongoid
         if limit
           key = [ collection.namespace, selector, nil, skip, sort, projection, collation  ]
           cursor = QueryCache.cache_table[key]
-        end
-        cursor || QueryCache.cache_table[cache_key]
-      end
-
-      def get_cursor(result, server, session = nil)
-        if result.cursor_id == 0 || result.cursor_id.nil?
-          cursor = if session
-            CachedCursor.new(view, result, server, session: session)
-          else
-            CachedCursor.new(view, result, server)
-          end
-
-          QueryCache.cache_table[cache_key] = cursor
-        else
-          cursor = if session
-            Mongo::Cursor.new(view, result, server, session: session)
-          else
-            Mongo::Cursor.new(view, result, server)
+          if cursor
+            limited_docs = cursor.to_a[0...limit.abs]
+            cursor.instance_variable_set(:@cached_documents, limited_docs)
           end
         end
-
-        cursor
+        cursor || QueryCache.cache_table[cache_key]
       end
 
       def cache_key
@@ -295,12 +256,6 @@ module Mongoid
       def system_collection?
         collection.namespace =~ /^system./
       end
-
-      def driver_supports_cursor_sessions?
-        # Driver versions 2.9 and newer support passing in a session to the
-        # cursor object.
-        (Mongo::VERSION.split('.').map(&:to_i) <=> [2, 9, 0]) > 0
-      end
     end
 
     # Adds behaviour to the query cache for collections.

data/lib/mongoid/railtie.rb

@@ -102,23 +102,6 @@ module Rails
         puts "There is a configuration error with the current mongoid.yml."
         puts e.message
       end
-
-      # Include Controller extension that measures Mongoid runtime
-      # during request processing. The value then appears in Rails'
-      # instrumentation event `process_action.action_controller`.
-      #
-      # The measurement is made via internal Mongo monitoring subscription
-      initializer "mongoid.runtime-metric" do
-        require "mongoid/railties/controller_runtime"
-
-        ActiveSupport.on_load :action_controller do
-          include ::Mongoid::Railties::ControllerRuntime::ControllerExtension
-        end
-
-        Mongo::Monitoring::Global.subscribe Mongo::Monitoring::COMMAND,
-            ::Mongoid::Railties::ControllerRuntime::Collector.new
-      end
-
     end
   end
 end

data/lib/mongoid/reloadable.rb

@@ -58,7 +58,7 @@ module Mongoid
     #
     # @since 2.3.2
     def reload_root_document
-      {}.merge(collection.find({ _id: _id }, session: _session).read(mode: :primary).first || {})
+      {}.merge(collection.find({ _id: _id }, session: session).read(mode: :primary).first || {})
     end
 
     # Reload the embedded document.

data/lib/mongoid/scopable.rb

@@ -102,7 +102,7 @@ module Mongoid
       #
       # @since 3.0.0
       def default_scopable?
-        default_scoping? && !Threaded.without_default_scope?(self)
+        default_scoping? && !Threaded.executing?(:without_default_scope)
       end
 
       # Get a queryable, either the last one on the scope stack or a fresh one.
@@ -244,10 +244,10 @@ module Mongoid
       #
       # @since 3.0.0
       def without_default_scope
-        Threaded.begin_without_default_scope(self)
+        Threaded.begin_execution("without_default_scope")
         yield
       ensure
-        Threaded.exit_without_default_scope(self)
+        Threaded.exit_execution("without_default_scope")
       end
 
       private

data/lib/mongoid/serializable.rb

@@ -101,7 +101,7 @@ module Mongoid
         value = send(name)
         attrs[name] = value ? value.serializable_hash(options) : nil
       elsif names.include?(name) && !fields.key?(name)
-        attrs[name] = read_attribute(name)
+        attrs[name] = read_raw_attribute(name)
       elsif !attribute_missing?(name)
         attrs[name] = send(name)
       end
@@ -124,9 +124,9 @@ module Mongoid
     def serialize_relations(attributes = {}, options = {})
       inclusions = options[:include]
       relation_names(inclusions).each do |name|
-        metadata = relations[name.to_s]
-        if metadata && relation = send(metadata.name)
-          attributes[metadata.name.to_s] =
+        association = relations[name.to_s]
+        if association && relation = send(association.name)
+          attributes[association.name.to_s] =
             relation.serializable_hash(relation_options(inclusions, options, name))
         end
       end

data/lib/mongoid/shardable.rb

@@ -37,7 +37,7 @@ module Mongoid
     def shard_key_selector
       selector = {}
       shard_key_fields.each do |field|
-        selector[field.to_s] = send(field)
+        selector[field.to_s] = new_record? ? send(field) : attribute_was(field)
       end
       selector
     end

data/lib/mongoid/tasks/database.rb

@@ -44,7 +44,7 @@ module Mongoid
         models.each do |model|
           unless model.embedded?
             begin
-              model.collection.indexes(session: model.send(:_session)).each do |index|
+              model.collection.indexes(session: model.send(:session)).each do |index|
                 # ignore default index
                 unless index['name'] == '_id_'
                   key = index['key'].symbolize_keys
@@ -77,7 +77,7 @@ module Mongoid
           indexes.each do |index|
             key = index['key'].symbolize_keys
             collection = model.collection
-            collection.indexes(session: model.send(:_session)).drop_one(key)
+            collection.indexes(session: model.send(:session)).drop_one(key)
             logger.info(
               "MONGOID: Removed index '#{index['name']}' on collection " +
               "'#{collection.name}' in database '#{collection.database.name}'."

data/lib/mongoid/threaded.rb

@@ -163,30 +163,6 @@ module Mongoid
       validations_for(document.class).delete_one(document._id)
     end
 
-    # Begin suppressing default scopes for given model on the current thread.
-    #
-    # @example Begin without default scope stack.
-    #   Threaded.begin_without_default_scope(klass)
-    #
-    # @param [ Class ] klass The model to suppress default scoping on.
-    #
-    # @api private
-    def begin_without_default_scope(klass)
-      stack(:without_default_scope).push(klass)
-    end
-
-    # Exit suppressing default scopes for given model on the current thread.
-    #
-    # @example Exit without default scope stack.
-    #   Threaded.exit_without_default_scope(klass)
-    #
-    # @param [ Class ] klass The model to unsuppress default scoping on.
-    #
-    # @api private
-    def exit_without_default_scope(klass)
-      stack(:without_default_scope).delete(klass)
-    end
-
     # Get the global client override.
     #
     # @example Get the global client override.
@@ -271,18 +247,6 @@ module Mongoid
       end
     end
 
-    # Is the given klass' default scope suppressed on the current thread?
-    #
-    # @example Is the given klass' default scope suppressed?
-    #   Threaded.without_default_scope?(klass)
-    #
-    # @param [ Class ] klass The model to check for default scope suppression.
-    #
-    # @api private
-    def without_default_scope?(klass)
-      stack(:without_default_scope).include?(klass)
-    end
-
     # Is the document autosaved on the current thread?
     #
     # @example Is the document autosaved?

data/lib/mongoid/traversable.rb

@@ -8,7 +8,7 @@ module Mongoid
     extend ActiveSupport::Concern
 
     def _parent
-      @__parent
+      @__parent ||= nil
     end
 
     def _parent=(p)
@@ -40,7 +40,7 @@ module Mongoid
     # @since 2.4.0
     def collect_children
       children = []
-      embedded_relations.each_pair do |name, metadata|
+      embedded_relations.each_pair do |name, association|
         without_autobuild do
           child = send(name)
           Array.wrap(child).each do |doc|
@@ -101,7 +101,7 @@ module Mongoid
     #
     # @since 2.0.0.beta.1
     def remove_child(child)
-      name = child.metadata_name
+      name = child.association_name
       if child.embedded_one?
         remove_ivar(name)
       else

data/lib/mongoid/validatable/presence.rb

@@ -62,8 +62,8 @@ module Mongoid
       # @since 3.0.0
       def relation_or_fk_missing?(doc, attr, value)
         return true if value.blank? && doc.send(attr).blank?
-        metadata = doc.relations[attr.to_s]
-        metadata.stores_foreign_key? && doc.send(metadata.foreign_key).blank?
+        association = doc.relations[attr.to_s]
+        association.stores_foreign_key? && doc.send(association.foreign_key).blank?
       end
 
       # For guarding against false values.

data/lib/mongoid/validatable/uniqueness.rb

@@ -224,9 +224,9 @@ module Mongoid
       #
       # @since 2.4.4
       def to_validate(document, attribute, value)
-        metadata = document.relations[attribute.to_s]
-        if metadata && metadata.stores_foreign_key?
-          [ metadata.foreign_key, value && value._id ]
+        association = document.relations[attribute.to_s]
+        if association && association.stores_foreign_key?
+          [ association.foreign_key, value && value._id ]
         else
           [ attribute, value ]
         end
@@ -246,7 +246,7 @@ module Mongoid
       # @since 2.4.10
       def validate_embedded(document, attribute, value)
         return if skip_validation?(document)
-        relation = document._parent.send(document.metadata_name)
+        relation = document._parent.send(document.association_name)
         criteria = create_criteria(relation, document, attribute, value)
         criteria = criteria.merge(options[:conditions].call) if options[:conditions]
         add_error(document, attribute, value) if criteria.count > 1

data/lib/mongoid/validatable.rb

@@ -127,14 +127,14 @@ module Mongoid
       # was not provided or set to true.
       #
       # @example Set up validation.
-      #   Person.validates_relation(metadata)
+      #   Person.validates_relation(association)
       #
-      # @param [ Metadata ] metadata The relation metadata.
+      # @param [ Association ] association The association metadata.
       #
       # @since 2.0.0.rc.1
-      def validates_relation(metadata)
-        if metadata.validate?
-          validates_associated(metadata.name)
+      def validates_relation(association)
+        if association.validate?
+          validates_associated(association.name)
         end
       end
 
@@ -154,9 +154,9 @@ module Mongoid
       def validates_with(*args, &block)
         if args.first == PresenceValidator
           args.last[:attributes].each do |name|
-            metadata = relations[name.to_s]
-            if metadata && metadata[:autosave] != false
-              autosave(metadata.merge!(autosave: true))
+            association = relations[name.to_s]
+            if association && association.autosave?
+              Association::Referenced::AutoSave.define_autosave!(association)
             end
           end
         end

data/lib/mongoid/version.rb

@@ -1,4 +1,4 @@
 # encoding: utf-8
 module Mongoid
-  VERSION = "6.4.8"
+  VERSION = "7.0.0"
 end

data/lib/mongoid.rb

@@ -101,5 +101,5 @@ module Mongoid
   #   Mongoid.database = Mongo::Connection.new.db("test")
   #
   # @since 1.0.0
-  delegate(*(Config.public_instance_methods(false) - [ :logger=, :logger ]), to: Config)
+  delegate(*(Config.public_instance_methods(false) - [ :logger=, :logger ] << { to: Config }))
 end

data/lib/rails/generators/mongoid/config/templates/mongoid.yml

@@ -149,6 +149,9 @@ development:
     # Application name that is printed to the mongodb logs upon establishing a
     # connection in server versions >= 3.4. Note that the name cannot exceed 128 bytes.
     # app_name: MyApplicationName
+
+    # Use background indexes by default if `background` option not specified. (default: false)
+    # background_indexing: false
 test:
   clients:
     default:

data/spec/app/models/animal.rb

@@ -9,7 +9,8 @@ class Animal
   field :tags, type: Array
 
   embedded_in :person
-  embedded_in :circus
+  embedded_in :circus, class_name: 'Circus' # class_name is necessary because ActiveRecord think the singular of Circus
+                                            # is Circu
 
   validates_format_of :name, without: /\$\$\$/
 

data/spec/app/models/bomb.rb

@@ -1,4 +1,4 @@
 class Bomb
   include Mongoid::Document
-  has_one :explosion, dependent: :delete, autobuild: true
+  has_one :explosion, dependent: :delete_all, autobuild: true
 end

data/spec/app/models/message.rb

@@ -5,7 +5,7 @@ class Message
   field :priority, type: Integer
 
   embedded_in :person
-  has_and_belongs_to_many :receviers, class_name: "Person", inverse_of: nil
+  has_and_belongs_to_many :receivers, class_name: "Person", inverse_of: nil
 
   has_one :post, as: :posteable
 end

data/spec/app/models/person.rb

@@ -85,7 +85,7 @@ class Person
 
   has_many \
     :posts,
-    dependent: :delete,
+    dependent: :delete_all,
     validate: false do
     def extension
       "Testing"
@@ -105,7 +105,7 @@ class Person
   has_one :account, validate: false
   has_one :cat, dependent: :nullify, validate: false, primary_key: :username
   has_one :book, autobuild: true, validate: false
-  has_one :home, dependent: :delete, validate: false
+  has_one :home, dependent: :delete_all, validate: false
 
   has_and_belongs_to_many \
     :administrated_events,
@@ -114,6 +114,9 @@ class Person
     dependent:  :nullify,
     validate: false
 
+  belongs_to :mother, class_name: 'Person'
+  has_many :children, class_name: 'Person'
+
   accepts_nested_attributes_for :addresses
   accepts_nested_attributes_for :name, update_only: true
   accepts_nested_attributes_for :pet, allow_destroy: true

data/spec/app/models/shipment_address.rb

@@ -1,2 +1,3 @@
 class ShipmentAddress < Address
+  field :shipping_name, localize: true
 end