mods 2.4.0 → 3.0.0

data/spec/lib/name_spec.rb

@@ -0,0 +1,368 @@
+require 'spec_helper'
+
+RSpec.describe "Mods <name> Element" do
+  context 'with a record with a provided language' do
+    subject(:record) do
+      mods_record(<<-XML)
+        <name type='personal'><namePart xml:lang='fr-FR' type='given'>Jean</namePart><namePart xml:lang='en-US' type='given'>John</namePart></name>
+      XML
+    end
+
+    it "has the expected attributes" do
+      expect(record.personal_name.namePart).to match_array([
+        have_attributes(text: 'Jean', lang: 'fr-FR', type_at: 'given'),
+        have_attributes(text: 'John', lang: 'en-US', type_at: 'given'),
+      ])
+    end
+  end
+
+  context 'with a recod without a role' do
+    subject(:record) do
+      mods_record(<<-XML)
+        <name type='personal'><namePart>Crusty</namePart></name>
+      XML
+    end
+
+    it 'does not have a role' do
+      expect(record.personal_name.role).to be_empty
+      expect(record.personal_name.role.code).to be_empty
+      expect(record.personal_name.role.authority).to be_empty
+    end
+  end
+
+  context 'with a record with a text role' do
+    subject(:record) do
+      mods_record(<<-XML)
+        <name type='personal'><namePart>Crusty</namePart>
+        <role><roleTerm authority='marcrelator' type='text'>creator</roleTerm><role></name>
+      XML
+    end
+
+    it 'has the expected attributes' do
+      expect(record.plain_name.first).to have_attributes(
+        type_at: 'personal',
+        namePart: match_array([
+          have_attributes(text: 'Crusty')
+        ]),
+        role: have_attributes(
+          roleTerm: have_attributes(
+            text: 'creator',
+            type_at: ['text'],
+            authority: ['marcrelator']
+          ),
+          authority: ['marcrelator'],
+          code: [],
+          value: ['creator']
+        )
+      )
+    end
+  end
+
+  context 'with a record with a code role' do
+    subject(:record) do
+      mods_record(<<-XML)
+        <name type='personal'>
+          <namePart type='given'>John</namePart>
+          <namePart type='family'>Huston</namePart>
+          <role>
+              <roleTerm type='code' authority='marcrelator'>drt</roleTerm>
+          </role>
+        </name>
+      XML
+    end
+
+    it 'has the expected attributes' do
+      expect(record.plain_name.first).to have_attributes(
+        type_at: 'personal',
+        display_value: 'Huston, John',
+        namePart: match_array([
+          have_attributes(text: 'John', type_at: 'given'),
+          have_attributes(text: 'Huston', type_at: 'family'),
+        ]),
+        role: have_attributes(
+          roleTerm: match_array([
+            have_attributes(
+              text: 'drt',
+              type_at: 'code',
+              authority: 'marcrelator',
+              value: 'Director'
+            )
+          ]),
+          authority: ['marcrelator'],
+          code: ['drt'],
+          value: ['Director']
+        )
+      )
+    end
+  end
+
+  context 'with an alternate name' do
+    subject(:record) do
+      mods_record(<<-XML)
+        <name>
+            <namePart>Claudia Alta Johnson</namePart>
+            <alternativeName altType="nickname">
+              <namePart>Lady Bird Johnson</namePart>
+            </alternativeName>
+        </name>
+      XML
+    end
+
+    it 'has the expected attributes' do
+      expect(record.plain_name.first).to have_attributes(
+        namePart: have_attributes(text: 'Claudia Alta Johnson'),
+        alternative_name: match_array([
+          have_attributes(
+            altType: 'nickname',
+            namePart: have_attributes(text: 'Lady Bird Johnson')
+          )
+        ])
+      )
+    end
+  end
+
+  context 'with both a personal and corporate name' do
+    subject(:record) do
+      mods_record(<<-XML)
+        <name type='corporate'><namePart>ABC Corp</namePart></name>
+        <name type='personal'><namePart>Crusty</namePart></name>
+      XML
+    end
+
+    describe '#personal_name' do
+      it 'selects the name with the type "personal"' do
+        expect(record.personal_name).to match_array([
+          have_attributes(text: 'Crusty')
+        ])
+      end
+    end
+
+    describe '#corporate_name' do
+      it 'selects the name with the type "corporate"' do
+        expect(record.corporate_name).to match_array([
+          have_attributes(text: 'ABC Corp')
+        ])
+      end
+    end
+  end
+
+  context 'with a role with both text and a code' do
+    subject(:record) do
+      mods_record <<-XML
+        <name><namePart>anyone</namePart>
+          <role>
+            <roleTerm type='text' authority='marcrelator'>CreatorFake</roleTerm>
+            <roleTerm type='code' authority='marcrelator'>cre</roleTerm>
+          </role>
+        </name>
+      XML
+    end
+
+    it 'prefers the value of the text term' do
+      expect(record.plain_name.role.value).to eq ['CreatorFake']
+    end
+
+    it 'can return the code' do
+      expect(record.plain_name.role.code).to eq ['cre']
+    end
+  end
+
+  context 'with multiple roles' do
+    subject(:record) do
+      mods_record <<-XML
+        <name><namePart>Fats Waller</namePart>
+          <role>
+            <roleTerm type='text' authority='marcrelator'>CreatorFake</roleTerm>
+            <roleTerm type='code' authority='marcrelator'>cre</roleTerm>
+          </role>
+          <role>
+            <roleTerm type='text'>Performer</roleTerm>
+          </role>
+        </name>
+      XML
+    end
+
+    it 'returns both values' do
+      expect(record.plain_name.role.value).to eq ['CreatorFake', 'Performer']
+    end
+
+    it 'can return the code' do
+      expect(record.plain_name.role.code).to eq ['cre']
+    end
+  end
+
+  context 'with additional name metadata' do
+    subject(:record) do
+      mods_record <<-XML
+        <name>
+          <namePart>Exciting Prints</namePart>
+          <affiliation>whatever</affiliation>
+          <description>anything</description>
+          <role><roleTerm type='text'>some role</roleTerm></role>
+        </name>
+      XML
+    end
+
+    describe '#display_value' do
+      it 'has the expected value' do
+        expect(record.plain_name.first.display_value).to eq 'Exciting Prints'
+      end
+    end
+  end
+
+  context 'with an empty name' do
+    subject(:record) do
+      mods_record <<-XML
+        <name>
+          <namePart></namePart>
+        </name>
+      XML
+    end
+
+    describe '#display_value' do
+      it 'is blank' do
+        expect(record.plain_name.first.display_value).to be_nil
+      end
+    end
+  end
+
+  context 'with a displayForm' do
+    subject(:record) do
+      mods_record <<-XML
+        <name type='personal'>
+          <namePart>Alterman, Eric</namePart>
+          <displayForm>Eric Alterman</displayForm>
+        </name>
+      XML
+    end
+
+    describe '#display_value' do
+      it 'is the displayForm' do
+        expect(record.plain_name.first.display_value).to eq 'Eric Alterman'
+      end
+    end
+  end
+
+  context 'with a record with a displayForm that includes some dates' do
+    subject(:record) do
+      mods_record <<-XML
+        <name>
+          <namePart>Woolf, Virginia</namePart>
+          <namePart type='date'>1882-1941</namePart>
+          <displayForm>Woolf, Virginia, 1882-1941</namePart>
+        </name>
+      XML
+    end
+
+    describe '#display_value_w_dates' do
+      it 'does not duplicate the dates' do
+        expect(record.plain_name.first.display_value).to eq 'Woolf, Virginia, 1882-1941'
+        expect(record.plain_name.first.display_value_w_date).to eq 'Woolf, Virginia, 1882-1941'
+      end
+    end
+  end
+
+  context 'with a record with a namePart for dates' do
+    subject(:record) do
+      mods_record(<<-XML)
+        <name>
+          <namePart>Suzy</namePart>
+          <namePart type='date'>1920-</namePart>
+        </name>
+      XML
+    end
+
+    it 'has the expected attributes' do
+      expect(record.plain_name.first).to have_attributes(
+        display_value: 'Suzy',
+        display_value_w_date: 'Suzy, 1920-'
+      )
+    end
+  end
+
+  context 'without a family name and given name' do
+    subject(:record) do
+      mods_record("<name type='personal'>
+                <namePart type='given'>John Paul</namePart>
+                <namePart type='termsOfAddress'>II</namePart>
+                <namePart type='termsOfAddress'>Pope</namePart>
+                <namePart type='date'>1920-2005</namePart>
+            </name>")
+    end
+
+    describe '#display_value' do
+      it 'just concatenates the name parts' do
+        expect(record.personal_name.first.display_value).to eq 'John Paul II, Pope'
+      end
+    end
+
+    describe '#display_value_w_date' do
+      it 'includes the dates' do
+       expect(record.personal_name.first.display_value_w_date).to eq 'John Paul II, Pope, 1920-2005'
+      end
+    end
+  end
+
+  context 'with a bunch of untyped name parts' do
+    subject(:record) do
+      mods_record("<name type='personal'>
+                  <namePart>Crusty</namePart>
+                  <namePart>The Clown</namePart>
+                  <namePart type='date'>1920-2005</namePart>
+              </name>")
+    end
+
+    describe '#display_value' do
+      it 'concatenates the untyped name parts' do
+        expect(record.personal_name.first.display_value).to eq('Crusty The Clown')
+      end
+    end
+  end
+
+  context 'with a corporate name' do
+    subject(:record) do
+      mods_record("<name type='corporate'>
+            <namePart>United States</namePart>
+            <namePart>Court of Appeals (2nd Circuit)</namePart>
+        </name>")
+    end
+
+    it 'concatenates the untyped name parts' do
+      expect(record.corporate_name.first.display_value).to eq('United States Court of Appeals (2nd Circuit)')
+    end
+  end
+
+  context 'with a complex example' do
+    subject(:record) do
+      mods_record <<-XML
+        <name>
+            <namePart>Sean Connery</namePart>
+            <role><roleTerm type='code' authority='marcrelator'>drt</roleTerm></role>
+        </name>
+        <name>
+            <namePart>Pierce Brosnan</namePart>
+            <role>
+              <roleTerm type='text'>CreatorFake</roleTerm>
+              <roleTerm type='code' authority='marcrelator'>cre</roleTerm>
+            </role>
+            <role><roleTerm type='text' authority='marcrelator'>Actor</roleTerm></role>
+        </name>
+        <name>
+            <namePart>Daniel Craig</namePart>
+            <role>
+              <roleTerm type='text' authority='marcrelator'>Actor</roleTerm>
+              <roleTerm type='code' authority='marcrelator'>cre</roleTerm>
+            </role>
+        </name>
+      XML
+    end
+
+    it 'has the expected attributes' do
+      expect(record.plain_name).to match_array([
+        have_attributes(role: have_attributes(value: ['Director'], code: ['drt'], authority: ['marcrelator'], size: 1)),
+        have_attributes(role: have_attributes(value: ['CreatorFake', 'Actor'], code: ['cre'], authority: ['marcrelator', 'marcrelator'], size: 2)),
+        have_attributes(role: have_attributes(value: ['Actor'], code: ['cre'], authority: ['marcrelator'], size: 1)),
+      ])
+    end
+  end
+end

data/spec/lib/origin_info_spec.rb

@@ -0,0 +1,134 @@
+# encoding: utf-8
+require 'spec_helper'
+
+describe "Mods <originInfo> Element" do
+  describe "#place" do
+    describe "#place_term" do
+      context 'with a single value' do
+        let(:terms) do
+          mods_record(<<-XML).origin_info.place.placeTerm
+            <originInfo><place><placeTerm authority='marccountry' type='code'>fr</placeTerm></place></originInfo>
+          XML
+        end
+
+        it 'has the expected attributes' do
+          expect(terms.first).to have_attributes(
+            authority: 'marccountry',
+            type_at: 'code',
+            text: 'fr'
+          )
+        end
+      end
+
+      context 'with a multi-valued place' do
+        let(:terms) do
+          mods_record(<<-XML).origin_info.place.placeTerm
+            <originInfo>
+              <place><placeTerm>France</placeTerm></place>
+              <place><placeTerm>Italy</placeTerm></place>
+            </originInfo>
+          XML
+        end
+
+        it 'has elements for each place' do
+          expect(terms.map(&:text)).to eq ['France', 'Italy']
+        end
+      end
+    end
+  end
+
+  describe "#publisher" do
+    subject(:publishers) do
+      mods_record(<<-XML).origin_info.publisher
+        <originInfo><publisher>Olney</publisher></origin_info>
+      XML
+    end
+
+    it "should get element values" do
+      expect(publishers.map(&:text)).to eq(["Olney"])
+    end
+  end
+
+  describe '#as_object' do
+    describe '#key_dates' do
+      it 'should extract the date with the keyDate attribute' do
+        origin_info = mods_record("<originInfo><dateCreated>other date</dateCreated><dateCreated keyDate='yes'>key date</dateCreated></originInfo>").origin_info
+        expect(origin_info.as_object.first.key_dates.first.text).to eq 'key date'
+      end
+      it 'should extract a date range when the keyDate attribute is on the start of the range' do
+        origin_info = mods_record("<originInfo><dateCreated point='end'>other date</dateCreated><dateCreated keyDate='yes' point='start'>key date</dateCreated></originInfo>").origin_info
+        expect(origin_info.as_object.first.key_dates.map(&:text)).to eq ['key date', 'other date']
+      end
+    end
+  end
+
+  Mods::ORIGIN_INFO_DATE_ELEMENTS.each do |elname|
+    context "<#{elname}> child elements" do
+      it "should recognize each element" do
+        origin_info = mods_record("<originInfo><#{elname}>date</#{elname}></originInfo>").origin_info.send(elname.to_sym)
+        expect(origin_info.map(&:text)).to eq(["date"])
+      end
+      it "should recognize encoding attribute on each element" do
+        origin_info = mods_record("<originInfo><#{elname} encoding='foo'>date</#{elname}></originInfo>").origin_info.send(elname.to_sym)
+        expect(origin_info.encoding).to eq(["foo"])
+      end
+      it "should recognize keyDate attribute" do
+        origin_info = mods_record("<originInfo><#{elname} keyDate='foo'>date</#{elname}></originInfo>").origin_info.send(elname.to_sym)
+        expect(origin_info.keyDate).to eq(["foo"])
+      end
+      it "should recognize point attribute" do
+      # NOTE: values allowed are 'start' and 'end'
+        origin_info = mods_record("<originInfo><#{elname} point='foo'>date</#{elname}></originInfo>").origin_info.send(elname.to_sym)
+        expect(origin_info.point).to eq(["foo"])
+      end
+      it "should recognize qualifier attribute" do
+        origin_info = mods_record("<originInfo><#{elname} qualifier='foo'>date</#{elname}></originInfo>").origin_info.send(elname.to_sym)
+        expect(origin_info.qualifier).to eq(["foo"])
+      end
+      it "should recognize type attribute only on dateOther" do
+        origin_info = mods_record("<originInfo><#{elname} type='foo'>date</#{elname}></originInfo>").origin_info.send(elname.to_sym)
+        if elname == 'dateOther'
+          expect(origin_info.type_at).to eq(["foo"])
+        else
+          expect { origin_info.type_at}.to raise_exception(NoMethodError, /type_at/)
+        end
+      end
+    end # <xxxDate> child elements
+  end
+
+  context 'edition' do
+    subject(:origin_info) do
+      mods_record(<<-XML).origin_info
+        <originInfo><edition>7th ed.</edition></originInfo>
+      XML
+    end
+
+    it "gets element value" do
+      expect(origin_info.edition).to have_attributes(text: '7th ed.')
+    end
+  end
+
+  context "<issuance> child element" do
+    subject(:origin_info) do
+      mods_record(<<-XML).origin_info
+        <originInfo><issuance>monographic</issuance></originInfo>
+      XML
+    end
+
+    it "gets element value" do
+      expect(origin_info.issuance).to have_attributes(text: 'monographic')
+    end
+  end
+
+  context "<frequency> child element" do
+    subject(:origin_info) do
+      mods_record(<<-XML).origin_info
+        <originInfo><frequency authority='marcfrequency'>Annual</frequency></originInfo>
+      XML
+    end
+
+    it "has the right attributes" do
+      expect(origin_info.frequency).to have_attributes(text: 'Annual', authority: ['marcfrequency'])
+    end
+  end
+end

data/spec/lib/part_spec.rb

@@ -0,0 +1,162 @@
+require 'spec_helper'
+
+RSpec.describe "Mods <part> Element" do
+  context 'with a basicpart' do
+    subject(:part) do
+      mods_record("<part>
+              <detail>
+                  <title>Wayfarers (Poem)</title>
+              </detail>
+              <extent unit='pages'>
+                  <start>97</start>
+                  <end>98</end>
+              </extent>
+          </part>").part
+    end
+
+    it 'has the expected attributes' do
+      expect(part.first).to have_attributes(
+        detail: match_array([
+          have_attributes(
+            title: match_array([have_attributes(text: 'Wayfarers (Poem)')]),
+            number: [],
+          )
+        ]),
+        extent: match_array([
+          have_attributes(
+            unit: 'pages',
+            start: have_attributes(text: '97'),
+            end: have_attributes(text: '98'),
+          )
+        ])
+      )
+    end
+  end
+  context 'with a part with a detail number' do
+    subject(:part) do
+      mods_record("<part>
+              <detail type='page number'>
+                  <number>3</number>
+              </detail>
+              <extent unit='pages'>
+                  <start>3</start>
+              </extent>
+          </part>").part
+    end
+
+    it 'has the expected attributes' do
+      expect(part.first).to have_attributes(
+        detail: match_array([
+          have_attributes(
+            type_at: 'page number',
+            number: match_array([have_attributes(text: '3')])
+          )
+        ]),
+        extent: match_array([
+          have_attributes(
+            unit: 'pages',
+            start: have_attributes(text: '3')
+          )
+        ])
+      )
+    end
+  end
+  context 'with a part with a number and caption' do
+    subject(:part) do
+      mods_record("<part>
+              <detail type='issue'>
+                  <number>1</number>
+                  <caption>no.</caption>
+              </detail>
+          </part>").part
+    end
+
+    it 'has the expected attributes' do
+      expect(part.first).to have_attributes(
+        detail: match_array([
+          have_attributes(
+            type_at: 'issue',
+            number: match_array([have_attributes(text: '1')]),
+            caption: match_array([have_attributes(text: 'no.')])
+          )
+        ])
+      )
+    end
+  end
+
+  context 'with a typed part' do
+    subject(:part) do
+      mods_record("<part ID='p1' order='1' type='paragraph'>anything</part>").part
+    end
+
+    it 'has the expected attributes' do
+      expect(part.first).to have_attributes(
+        id_at: 'p1',
+        order: '1',
+        type_at: 'paragraph',
+        text: 'anything'
+      )
+    end
+  end
+
+  context 'with a level attribute' do
+    subject(:part) { mods_record("<part><detail level='val'>anything</detail></part>").part }
+
+    it 'has the expected attributes' do
+      expect(part.first).to have_attributes(
+        detail: match_array([have_attributes(level: 'val')])
+      )
+    end
+  end
+
+  context 'with a total element' do
+    subject(:part) { mods_record("<part><extent><total>anything</total></extent></part>").part }
+
+    it 'has the expected attributes' do
+      expect(part.first).to have_attributes(
+        extent: match_array([have_attributes(total: match_array([have_attributes(text: 'anything')]))])
+      )
+    end
+  end
+
+  context 'with a list element' do
+    subject(:part) { mods_record("<part><extent><list>anything</list></extent></part>").part }
+
+    it 'has the expected attributes' do
+      expect(part.first).to have_attributes(
+        extent: match_array([have_attributes(list: match_array([have_attributes(text: 'anything')]))])
+      )
+    end
+  end
+
+  context "<date> child element" do
+    subject(:date) do
+      mods_record("<part><date encoding='w3cdtf'>1999</date></part>").part.date
+    end
+
+    it 'has the expected date attributes' do
+      expect(date.first).to have_attributes(
+        encoding: 'w3cdtf',
+        text: '1999',
+        point: [],
+        qualifier: []
+      )
+    end
+
+    it 'does not have a keyDate attribute' do
+      expect(date.first).not_to respond_to(:keyDate)
+    end
+  end
+
+  context "<text> child element as .text_el term" do
+    subject(:part) do
+      mods_record("<part><text type='bar' displayLabel='foo'>1999</text></part>").part
+    end
+
+    describe '#text_el' do
+      it "has the expected attributes" do
+        expect(part.first.text_el).to have_attributes(text: '1999', displayLabel: ['foo'], type_at: ['bar'])
+      end
+    end
+  end
+end