mods 2.4.0 → 3.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 93d01c5f52e3486f8ec3405b3f30355dd4f2fc31
-  data.tar.gz: 55ef282f94d86ef30908e1a8bc865c388132f15d
+SHA256:
+  metadata.gz: 30381fee9ce7d47827010ce02902834f10118daeb381bdfa65bcc5adf778b65f
+  data.tar.gz: 65b9fac4ebee7589010039dbba9cbd8b204a94987443ec2c68e36a7509f39685
 SHA512:
-  metadata.gz: 20aaf32888be2c3511a8faf35ff5e985495c3e705277a50c0a3fba03d541bf340bbb0972becba9e32da530179bd8d97de894defcb31c6cd60825a6777bcf4692
-  data.tar.gz: 402b4bd7f93f0b35471a241bee110acc1e34574c913862599a7fde5fe5ed49d48d9e06d7adced7d2c1258f3bf41e92e7dfa5cb35a69350477696c7470d79af5f
+  metadata.gz: e9ecec0384d8c4d931cace14b32ddc9e2b5161ed6ef9f61af27fb89d9993643db790f98966f8ddea419008bd03588cbc6aaf4dfee25b404c5a392deae1b3e78e
+  data.tar.gz: 79b733073abbf0ee6dc8da9835c86e44be67f1f298a4e09f3d6380772ff51713cd63c121daf2bb0ae0751ab9ffb3954003eb24ecffde1a7e89ed3c542cead994

data/.github/workflows/ruby.yml

@@ -0,0 +1,24 @@
+name: CI
+
+on:
+  push:
+    branches: [ master ]
+  pull_request:
+    branches: [ master ]
+
+jobs:
+  tests:
+    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        ruby: [jruby-9.3.2.0, 2.7, '3.0', 3.1]
+    steps:
+    - uses: actions/checkout@v2
+    - name: Set up Ruby
+      uses: ruby/setup-ruby@v1
+      with:
+        ruby-version: ${{ matrix.ruby }}
+    - name: Install dependencies
+      run: bundle install
+    - name: Run tests
+      run: bundle exec rake

data/.gitignore

@@ -22,3 +22,4 @@ tmtags
 .idea/*
 to_delete
 .byebug_history
+/spec/examples.txt

data/Gemfile

@@ -3,10 +3,6 @@ source 'https://rubygems.org'
 # See mods.gemspec for this gem's dependencies
 gemspec
 
-group :test do
-  gem 'coveralls', require: false
-end
-
 # Pin to activesupport 4.x for older versions of ruby
 gem 'activesupport', '~> 4.2' if RUBY_VERSION < '2.2.2'
 gem 'byebug', platform: :mri

data/README.md

@@ -1,8 +1,6 @@
 # Mods
 
-[<img src="https://secure.travis-ci.org/sul-dlss/mods.png?branch=master" alt="Build Status"/>](http://travis-ci.org/sul-dlss/mods) [<img
-src="https://coveralls.io/repos/sul-dlss/mods/badge.png" alt="Coverage Status"/>](https://coveralls.io/r/sul-dlss/mods) [<img
-src="https://gemnasium.com/sul-dlss/mods.png" alt="Dependency Status"/>](https://gemnasium.com/sul-dlss/mods) [<img
+[<img src="https://secure.travis-ci.org/sul-dlss/mods.png?branch=master" alt="Build Status"/>](http://travis-ci.org/sul-dlss/mods) [![Code Climate Test Coverage](https://codeclimate.com/github/sul-dlss/mods/badges/coverage.svg)](https://codeclimate.com/github/sul-dlss/mods/coverage) [<img
 src="https://badge.fury.io/rb/mods.svg" alt="Gem Version"/>](http://badge.fury.io/rb/mods)
 
 A Gem to parse MODS (Metadata Object Description Schema) records.  More information about MODS can be found at

data/lib/mods/date.rb

@@ -11,7 +11,7 @@ module Mods
     # @param [Nokogiri::XML::Element] xml A date-flavored MODS field from the XML
     # @return [Mods::Date]
     def self.from_element(xml)
-      case xml.attr(:encoding)
+      case xml.attr(:encoding)&.downcase
       when 'w3cdtf'
         Mods::Date::W3cdtfFormat.new(xml)
       when 'iso8601'
@@ -23,12 +23,13 @@ module Mods
       # when 'temper'
       #   Mods::Date::TemperFormat.new(xml)
       else
-        date_class = Mods::Date if xml.text =~ /\p{Hebrew}/
+        date_class = UnparseableDate if xml.text =~ /\p{Hebrew}/ || xml.text =~ /^-/
         date_class ||= [
           MMDDYYYYFormat,
           MMDDYYFormat,
           YearRangeFormat,
           DecadeAsYearDashFormat,
+          DecadeStringFormat,
           EmbeddedBCYearFormat,
           EmbeddedYearFormat,
           EmbeddedThreeDigitYearFormat,
@@ -49,7 +50,7 @@ module Mods
     # Strict ISO8601-encoded date parser
     class Iso8601Format < Date
       def self.parse_date(text)
-        @date = ::Date.parse(normalize_to_edtf(text))
+        ::Date.parse(normalize_to_edtf(text))
       end
     end
 
@@ -62,7 +63,16 @@ module Mods
       attr_reader :date
 
       def self.normalize_to_edtf(text)
-        text
+        return '0000' if text.strip == '0'
+
+        case text
+        when /^\d{1,3}$/
+          text.rjust(4, "0") if text =~ /^\d{1,3}$/
+        when /^-\d{1,3}$/
+          "-#{text.sub(/^-/, '').rjust(4, "0")}"
+        else
+          text
+        end
       end
     end
 
@@ -100,6 +110,12 @@ module Mods
       end
     end
 
+    class UnparseableDate < ExtractorDateFormat
+      def self.parse_date(text)
+        nil
+      end
+    end
+
     # Full text extractor for MM/DD/YYYY and MM/DD/YYY-formatted dates
     class MMDDYYYYFormat < ExtractorDateFormat
       REGEX = /(?<month>\d{1,2})\/(?<day>\d{1,2})\/(?<year>\d{3,4})/
@@ -201,7 +217,17 @@ module Mods
 
     # Full-text extractor for data formatted as YYY-
     class DecadeAsYearDashFormat < ExtractorDateFormat
-      REGEX = /(?<!\d)(?<year>\d{3})[-_x?](?!\d)/
+      REGEX = /(?<!\d)(?<year>\d{3})[-_xu?](?!\d)/
+
+      def self.normalize_to_edtf(text)
+        matches = text.match(REGEX)
+        "#{matches[:year]}X"
+      end
+    end
+
+    # Full-text extractor for data formatted as YYY0s
+    class DecadeStringFormat < ExtractorDateFormat
+      REGEX = /(?<!\d)(?<year>\d{3})0s(?!\d)/
 
       def self.normalize_to_edtf(text)
         matches = text.match(REGEX)
@@ -221,42 +247,42 @@ module Mods
 
     # Full-text extractor that tries hard to pick any year present in the data
     class EmbeddedYearFormat < ExtractorDateFormat
-      REGEX = /(?<prefix>-)?(?<!\d)(?<year>\d{4})(?!\d)/
+      REGEX = /(?<!\d)(?<year>\d{4})(?!\d)/
 
       def self.normalize_to_edtf(text)
         matches = text.match(REGEX)
-        "#{matches[:prefix]}#{matches[:year].rjust(4, "0")}"
+        "#{matches[:year].rjust(4, "0")}"
       end
     end
 
     # Full-text extractor that tries hard to pick any year present in the data
     class EmbeddedThreeDigitYearFormat < ExtractorDateFormat
-      REGEX = /(?<prefix>-)?(?<!\d)(?<year>\d{3})(?!\d)(?!\d)/
+      REGEX = /(?<!\d)(?<year>\d{3})(?!\d)(?!\d)/
 
       def self.normalize_to_edtf(text)
         matches = text.match(REGEX)
-        "#{matches[:prefix]}#{matches[:year].rjust(4, "0")}"
+        "#{matches[:year].rjust(4, "0")}"
       end
     end
 
     # Full-text extractor that tries hard to pick any year present in the data
     class OneOrTwoDigitYearFormat < ExtractorDateFormat
-      REGEX = /^(?<prefix>-)?(?<year>\d{1,2})$/
+      REGEX = /^(?<year>\d{1,2})$/
 
       def self.normalize_to_edtf(text)
         matches = text.match(REGEX)
-        "#{matches[:prefix]}#{matches[:year].rjust(4, "0")}"
+        "#{matches[:year].rjust(4, "0")}"
       end
     end
 
     # Full-text extractor that tries hard to pick any year present in the data
     class EmbeddedYearWithBracketsFormat < ExtractorDateFormat
       # [YYY]Y Y[YYY] [YY]YY Y[YY]Y YY[YY] YYY[Y] YY[Y]Y Y[Y]YY [Y]YYY
-      REGEX = /(?<prefix>-)?(?<year>[\d\[\]]{6})(?!\d)/
+      REGEX = /(?<year>[\d\[\]]{6})(?!\d)/
 
       def self.normalize_to_edtf(text)
         matches = text.match(REGEX)
-        "#{matches[:prefix]}#{matches[:year].gsub('[', '').gsub(']', '')}"
+        "#{matches[:year].gsub('[', '').gsub(']', '')}"
       end
     end
 
@@ -327,7 +353,9 @@ module Mods
     #
     # @return [String]
     def type
-      xml.attr(:type)
+      return if xml.attr(:type)&.empty?
+
+      xml.attr(:type)&.downcase
     end
 
     ##
@@ -335,7 +363,9 @@ module Mods
     #
     # @return [String]
     def encoding
-      xml.attr(:encoding)
+      return if xml.attr(:encoding)&.empty?
+
+      xml.attr(:encoding)&.downcase
     end
 
     ##
@@ -359,7 +389,9 @@ module Mods
     #
     # @return [String]
     def point
-      xml.attr(:point)
+      return if xml.attr(:point)&.empty?
+
+      xml.attr(:point)&.downcase
     end
 
     ##
@@ -391,7 +423,7 @@ module Mods
     #
     # @return [String]
     def qualifier
-      xml.attr(:qualifier)
+      xml.attr(:qualifier)&.downcase
     end
 
     ##
@@ -419,6 +451,8 @@ module Mods
     end
 
     def precision
+      return :unknown unless date_range || date
+
       if date_range.is_a? EDTF::Century
         :century
       elsif date_range.is_a? EDTF::Decade

data/lib/mods/marc_country_codes.rb

@@ -1,8 +1,8 @@
-# encoding: UTF-8
-
 # Represents the Marc Country Codes mapped to names, from http://www.loc.gov/marc/countries/countries_code.html 2013-01-03
-#key - Marc Country code
-#value - Marc Country term
+# key - Marc Country code
+# value - Marc Country term
+# frozen_string_literal: true
+
 MARC_COUNTRY = {
   'aa' => "Albania",
   'abc' => "Alberta",
@@ -11,7 +11,6 @@ MARC_COUNTRY = {
   'ae' => "Algeria",
   'af' => "Afghanistan",
   'ag' => "Argentina",
-  #'ai' => "Anguilla", # discontinued
   'ai' => "Armenia (Republic)",
   'air' => "Armenian S.S.R.", # discontinued
   'aj' => "Azerbaijan",
@@ -40,7 +39,7 @@ MARC_COUNTRY = {
   'bi' => "British Indian Ocean Territory",
   'bl' => "Brazil",
   'bm' => "Bermuda Islands",
-  'bn' => "Bosnia and Hercegovina",
+  'bn' => "Bosnia and Herzegovina",
   'bo' => "Bolivia",
   'bp' => "Solomon Islands",
   'br' => "Burma",
@@ -74,7 +73,7 @@ MARC_COUNTRY = {
   'cs' => "Czechoslovakia", # discontinued
   'ctu' => "Connecticut",
   'cu' => "Cuba",
-  'cv' => "Cape Verde",
+  'cv' => "Cabo Verde",
   'cw' => "Cook Islands",
   'cx' => "Central African Republic",
   'cy' => "Cyprus",
@@ -109,6 +108,7 @@ MARC_COUNTRY = {
   'gb' => "Kiribati",
   'gd' => "Grenada",
   'ge' => "Germany (East)", # discontinued
+  'gg' => "Guernsey",
   'gh' => "Ghana",
   'gi' => "Gibraltar",
   'gl' => "Greenland",
@@ -137,6 +137,7 @@ MARC_COUNTRY = {
   'ie' => "Ireland",
   'ii' => "India",
   'ilu' => "Illinois",
+  'im' => "Isle of Man",
   'inu' => "Indiana",
   'io' => "Indonesia",
   'iq' => "Iraq",
@@ -148,6 +149,7 @@ MARC_COUNTRY = {
   'iw' => "Israel-Jordan Demilitarized Zones", # discontinued
   'iy' => "Iraq-Saudi Arabia Neutral Zone",
   'ja' => "Japan",
+  'je' => "Jersey",
   'ji' => "Johnston Atoll",
   'jm' => "Jamaica",
   'jn' => "Jan Mayen", # discontinued
@@ -284,7 +286,7 @@ MARC_COUNTRY = {
   'snc' => "Saskatchewan",
   'so' => "Somalia",
   'sp' => "Spain",
-  'sq' => "Swaziland",
+  'sq' => "Eswatini",
   'sr' => "Surinam",
   'ss' => "Western Sahara",
   'st' => "Saint-Martin",
@@ -365,7 +367,7 @@ MARC_COUNTRY = {
   'xk' => "Saint Lucia",
   'xl' => "Saint Pierre and Miquelon",
   'xm' => "Saint Vincent and the Grenadines",
-  'xn' => "Macedonia",
+  'xn' => "North Macedonia",
   'xna' => "New South Wales",
   'xo' => "Slovakia",
   'xoa' => "Northern Territory",
@@ -384,4 +386,4 @@ MARC_COUNTRY = {
   'ys' => "Yemen (People's Democratic Republic)", # discontinued
   'yu' => "Serbia and Montenegro", # discontinued
   'za' => "Zambia"
-}
+}.freeze