mods 2.4.0 → 3.0.0

data/spec/integration/parker_spec.rb

@@ -0,0 +1,217 @@
+require 'spec_helper'
+
+RSpec.describe 'Parker manuscript' do
+  let(:record) do
+    Mods::Record.new.from_file(File.expand_path('../fixture_data/hp566jq8781.xml', __dir__))
+  end
+
+  it 'has title data' do
+    expect(record.title_info).to match_array(
+      [
+        have_attributes(
+          authority: 'Corpus Christi College',
+          title: have_attributes(text: 'Cambridge, Corpus Christi College, MS 367: Miscellaneous Compilation including Old English Material and Historical and Philosophical Works')
+        ),
+        have_attributes(
+          authority: 'James Catalog',
+          type_at: 'alternative',
+          title: have_attributes(text: 'Chronica. Anglo-Saxon fragments, etc.')
+        )
+      ]
+    )
+
+    expect(record.title_info.full_title).to match_array([
+      "Cambridge, Corpus Christi College, MS 367: Miscellaneous Compilation including Old English Material and Historical and Philosophical Works",
+      "Chronica. Anglo-Saxon fragments, etc."
+    ])
+
+    expect(record.title_info.short_title).to eq [
+      "Cambridge, Corpus Christi College, MS 367: Miscellaneous Compilation including Old English Material and Historical and Philosophical Works"
+    ]
+
+    expect(record.title_info.sort_title).to eq [
+      "Cambridge, Corpus Christi College, MS 367: Miscellaneous Compilation including Old English Material and Historical and Philosophical Works"
+    ]
+    
+    expect(record.title_info.alternative_title).to eq [
+      "Chronica. Anglo-Saxon fragments, etc."
+    ]
+  end
+  
+
+  it 'has typeOfResource data' do
+    expect(record.typeOfResource).to match_array([
+      have_attributes(
+        manuscript: 'yes',
+        text: 'mixed material'
+      )
+    ])
+  end
+
+  it 'has originInfo data' do
+    expect(record.origin_info.to_a).to include(
+      have_attributes(
+        dateCreated: match_array([
+          have_attributes(
+            encoding: 'w3cdtf',
+            keyDate: 'yes',
+            point: 'start',
+            qualifier: 'approximate',
+            text: '1400'
+          ),
+          have_attributes(
+            text: '1499'
+          )
+        ]),
+      ),
+      have_attributes(
+        dateCreated: match_array([
+          have_attributes(
+            text: '1300'
+          ),
+          have_attributes(
+            text: '1399'
+          )
+        ])
+      )
+    )
+  end
+
+  it 'has abstract data' do
+    expect(record.abstract).to match_array([
+      have_attributes(
+        displayLabel: 'Summary',
+        type_at: 'summary',
+        text: a_string_starting_with('CCCC MS 367')
+      )
+    ])
+  end
+
+  it 'has table of contents data' do
+    expect(record.tableOfContents).to match_array([
+      have_attributes(
+        displayLabel: 'Contents',
+        text: a_string_starting_with('Polychronicon (epitome and continuation to 1429)')
+      )
+    ])
+  end
+
+  it 'has notes' do
+    expect(record.note).to match_array([
+      have_attributes(
+        displayLabel: 'M.R. James Date',
+        type_at: 'date',
+        text: 'xv, xi-xii, xiv, xi'
+      )
+    ])
+  end
+
+  it 'has languages' do
+    expect(record.language.length).to eq 2
+    expect(record.language.code_term).to match_array([
+      have_attributes(
+        authority: 'iso639-2b',
+        text: 'lat',
+        type_at: 'code'
+      ),
+      have_attributes(
+        text: 'ang'
+      ),
+    ])
+    expect(record.language.text_term).to be_empty
+  end
+
+  it 'has a physical description' do
+    expect(record.physical_description.first).to have_attributes(
+      note: array_including(
+        have_attributes(
+          displayLabel: 'Material',
+          type_at: 'material',
+          text: 'Paper and vellum'
+        ),
+        have_attributes(
+          text: 'five volumes'
+        ),
+        have_attributes(
+          text: '220'
+        )
+      ),
+      extent: match_array([
+        have_attributes(text: 'ff. 53 + 52')
+      ])
+    )
+  end
+
+  it 'has identifiers' do
+    expect(record.identifier.to_a).to include(
+      have_attributes(
+        text: '342',
+        displayLabel: 'TJames'
+      ),
+      have_attributes(
+        text: '19. 9',
+        displayLabel: 'Stanley'
+      )
+    )
+  end
+
+  it 'has a location' do
+    expect(record.location.to_a).to include(
+      have_attributes(
+        physicalLocation: have_attributes(
+          text: 'UK, Cambridge, Corpus Christi College, Parker Library',
+          type_at: ['repository']
+        ),
+        shelfLocator: have_attributes(
+          text: 'MS 367'
+        )
+      )
+    )
+  end
+
+  it 'has related items' do
+    expect(record.related_item.to_a).to include(
+      have_attributes(
+        displayLabel: 'Downloadable James Catalogue Record',
+        type_at: 'isReferencedBy',
+        titleInfo: array_including(
+          have_attributes(
+            title: have_attributes(
+              text: a_string_starting_with('https://stacks.stanford.edu')
+            )
+          )
+        )
+      ),
+      have_attributes(
+        type_at: 'constituent',
+        titleInfo: array_including([
+          have_attributes(
+            title: [
+              have_attributes(text: 'Ranulf Higden OSB, Polychronicon (epitome and continuation to 1429)')
+            ],
+            partNumber: [
+              have_attributes(text: '1r-29v')
+            ]
+          )
+        ]),
+        note: array_including(
+          have_attributes(text: 'Dates are marked in the margin'),
+          have_attributes(type_at: 'incipit', text: a_string_starting_with('(1r) Ieronimus'))
+        )
+      )
+    )
+  end
+
+  it 'has access conditions' do
+    expect(record.accessCondition).to match_array([
+      have_attributes(
+        type_at: 'useAndReproduction',
+        text: a_string_starting_with('Images courtesy')
+      ),
+      have_attributes(
+        type_at: 'license',
+        text: a_string_starting_with('CC by-nc: Attribution')
+      )
+    ])
+  end
+end

data/spec/{date_spec.rb → lib/date_spec.rb}

@@ -209,6 +209,9 @@ RSpec.describe Mods::Date do
       '1900-uu-uu' => Date.parse('1900-01-01')..Date.parse('1900-12-31'),
       '1900-uu-15' => Date.parse('1900-01-15')..Date.parse('1900-12-15'),
       '1900-06-uu' => Date.parse('1900-06-01')..Date.parse('1900-06-30'),
+      '-250' => Date.parse('-250-01-01')..Date.parse('-250-12-31'), # EDTF requires a 4 digit year, but what can you do.
+      '63' => Date.parse('0063-01-01')..Date.parse('0063-12-31'),
+      '125' => Date.parse('125-01-01')..Date.parse('125-12-31'),
     }.each do |data, expected|
       describe "with #{data}" do
         let(:date_element) { "<dateCreated encoding=\"edtf\">#{data}</dateCreated>" }
@@ -303,7 +306,8 @@ RSpec.describe Mods::Date do
     {
       'Minguo 19 [1930]' => Date.parse('1930-01-01')..Date.parse('1930-12-31'),
       '1745 mag. 14' => Date.parse('1745-01-01')..Date.parse('1745-12-31'),
-      '-745' => Date.parse('-745-01-01')..Date.parse('-745-12-31'),
+      '-745' => '', # too ambiguious to even attempt.
+      '-1999' => '', # too ambiguious to even attempt.
       '[1923]' => Date.parse('1923-01-01')..Date.parse('1923-12-31'),
       '1532.' => Date.parse('1532-01-01')..Date.parse('1532-12-31'),
       '[ca 1834]' => Date.parse('1834-01-01')..Date.parse('1834-12-31'),
@@ -319,8 +323,11 @@ RSpec.describe Mods::Date do
       '193-' => Date.parse('1930-01-01')..Date.parse('1939-12-31'),
       '196_' => Date.parse('1960-01-01')..Date.parse('1969-12-31'),
       '196x' => Date.parse('1960-01-01')..Date.parse('1969-12-31'),
+      '196u' => Date.parse('1960-01-01')..Date.parse('1969-12-31'),
+      '1960s' => Date.parse('1960-01-01')..Date.parse('1969-12-31'),
       '186?' => Date.parse('1860-01-01')..Date.parse('1869-12-31'),
       '1700?' => Date.parse('1700-01-01')..Date.parse('1700-12-31'),
+      'early 1730s' => Date.parse('1730-01-01')..Date.parse('1739-12-31'),
       '[1670-1684]' => Date.parse('1670-01-01')..Date.parse('1684-12-31'),
       '[18]74' => Date.parse('1874-01-01')..Date.parse('1874-12-31'),
       '250 B.C.' => Date.parse('-0249-01-01')..Date.parse('-249-12-31'),

data/spec/lib/language_spec.rb

@@ -0,0 +1,123 @@
+require 'spec_helper'
+
+RSpec.describe 'Mods <language> Element' do
+  context 'with a simple record one with language term' do
+    subject(:record) do
+      mods_record("<language><languageTerm authority='iso639-2b' type='code'>fre</languageTerm></language>")
+    end
+
+    describe '#languages' do
+      it 'translates the code into text' do
+        expect(record.languages).to eq(['French'])
+      end
+    end
+
+    describe '#language' do
+      describe '#languageTerm' do
+        it 'has attribute accessors' do
+          expect(record.language.languageTerm).to have_attributes(
+            type_at: ['code'],
+            authority: ['iso639-2b'],
+            text: 'fre',
+            size: 1
+          )
+        end
+      end
+
+      describe '#code_term' do
+        it 'gets the languageTerms with type="code"' do
+          expect(record.language.code_term.map(&:text)).to eq ['fre']
+        end
+      end
+
+      describe '#text_term' do
+        it 'filters out the languageTerms with type="code"' do
+          expect(record.language.text_term).to be_empty
+        end
+      end
+    end
+  end
+
+  context 'with a record with a mix of language codes and plain-text languages' do
+    subject(:record) do
+      mods_record(<<-XML)
+        <language>
+          <languageTerm authority='iso639-2b' type='code'>spa</languageTerm>
+          <languageTerm authority='iso639-2b' type='text'>Spanish</languageTerm>
+          <languageTerm authority='iso639-2b' type='code'>dut</languageTerm>
+          <languageTerm authority='iso639-2b' type='text'>Dutch</languageTerm>
+        </language>
+      XML
+    end
+
+    describe '#languages' do
+      it 'translates the code into text' do
+        expect(record.languages).to include 'Spanish; Castilian', 'Dutch; Flemish'
+      end
+
+      it 'passes thru language values that are already text (not code)' do
+        expect(record.languages).to include 'Spanish', 'Dutch'
+      end
+    end
+
+    describe '#language' do
+      describe '#code_term' do
+        it 'gets the languageTerms with type="code"' do
+          expect(record.language.code_term.map(&:text)).to eq ['spa', 'dut']
+        end
+      end
+
+      describe '#text_term' do
+        it 'filters out the languageTerms with type="code"' do
+          expect(record.language.text_term.map(&:text)).to eq %w[Spanish Dutch]
+        end
+      end
+    end
+  end
+
+  context 'with a record with multiple language codes in one element' do
+    subject(:record) do
+      mods_record(<<-XML)
+        <language>
+          <languageTerm authority='iso639-2b' type='code'>per ara, dut</languageTerm>
+        </language>
+      XML
+    end
+
+    describe '#languages' do
+      it 'creates a separate value for each language in a comma, space, or | separated list' do
+        expect(record.languages).to include 'Arabic', 'Persian', 'Dutch; Flemish'
+      end
+    end
+  end
+
+  context 'with a record without a languageTerm child' do
+    subject(:record) do
+      mods_record(<<-XML)
+        <language>Greek</language>
+      XML
+    end
+
+    describe '#languages' do
+      it 'preserves values that are not inside <languageTerm> elements' do
+        expect(mods_record('<language>Greek</language>').languages).to eq(['Greek'])
+      end
+    end
+  end
+
+  context 'wih a record with some authority attributes' do
+    subject(:record) do
+      mods_record(<<-XML)
+        <language><languageTerm authorityURI='http://example.com' valueURI='http://example.com/zzz'>zzz</languageTerm></language>
+      XML
+    end
+
+    describe '#language' do
+      describe '#languageTerm' do
+        it 'recognizes other authority attributes' do
+          expect(record.language.languageTerm).to have_attributes(authorityURI: ['http://example.com'], valueURI: ['http://example.com/zzz'])
+        end
+      end
+    end
+  end
+end

data/spec/lib/location_spec.rb

@@ -0,0 +1,175 @@
+require 'spec_helper'
+
+RSpec.describe "Mods <location> Element" do
+  context 'with a record with a physical location' do
+    subject(:record) do
+      mods_record("<location><physicalLocation>here</physicalLocation></location>")
+    end
+
+    it "should have access to text value of element" do
+      expect(record.location.physicalLocation.text).to eq("here")
+    end
+  end
+
+  context 'with a record with a physical location that has an authority' do
+    subject(:record) do
+      mods_record("<location><physicalLocation authority='marcorg'>MnRM</physicalLocation></location>")
+    end
+
+    it "should have access to text value of element" do
+      expect(record.location.physicalLocation.map { |n| n.text }).to eq(["MnRM"])
+    end
+
+    it "should recognize authority attribute" do
+      expect(record.location.physicalLocation.authority).to eq(["marcorg"])
+    end
+  end
+
+  context 'with a record with a displayLabel' do
+    subject(:record) do
+      mods_record("<location><physicalLocation displayLabel='Correspondence'>some address</physicalLocation></location>")
+    end
+
+    it "should recognize displayLabel attribute" do
+      expect(record.location.physicalLocation.displayLabel).to eq(["Correspondence"])
+    end
+  end
+
+  context 'with a record with a shelfLocator' do
+    subject(:record) do
+      mods_record(<<-XML)
+        <location>
+          <physicalLocation>Library of Congress </physicalLocation>
+          <shelfLocator>DAG no. 1410</shelfLocator>
+        </location>
+      XML
+    end
+
+    it "has a shelfLocator child element" do
+      expect(record.location.shelfLocator.map { |n| n.text }).to eq(["DAG no. 1410"])
+    end
+  end
+
+  context 'with a record with a url location' do
+    let(:url_attribs) do
+      mods_record(<<-XML).location.url
+        <location>
+          <url
+            displayLabel='Digital collection of 46 images available online'
+            usage='primary display'
+            note='something'
+            dateLastAccessed='2021-12-21'>
+            http://searchworks.stanford.edu/?f%5Bcollection%5D%5B%5D=The+Reid+W.+Dennis+Collection+of+California+Lithographs&amp;view=gallery
+          </url>
+        </location>
+      XML
+    end
+
+    it 'has the right attributes' do
+      expect(url_attribs).to have_attributes(
+        displayLabel: ['Digital collection of 46 images available online'],
+        usage: ['primary display'],
+        note: ['something'],
+        dateLastAccessed: ['2021-12-21']
+      )
+    end
+  end
+
+  context 'with a record with multiple urls' do
+    let(:mult_flavor_loc_urls) do
+      mods_record(<<-XML).location.url
+        <location>
+          <url access='preview'>http://preview.org</url>
+          <url access='object in context'>http://context.org</url>
+          <url access='raw object'>http://object.org</url>
+        </location>
+      XML
+    end
+
+    describe '#url' do
+      it 'has access to text value of element' do
+        expect(mult_flavor_loc_urls.map(&:text)).to eq ["http://preview.org", "http://context.org", "http://object.org"]
+      end
+
+      describe '#access' do
+        it 'provides access to the access attributes' do
+          expect(mult_flavor_loc_urls.access).to eq ['preview', 'object in context', 'raw object']
+        end
+      end
+    end
+  end
+
+  context 'with an empty url element' do
+    let(:empty_url) do
+      mods_record(<<-XML).location.url
+        <location><url /></location>
+      XML
+    end
+
+    it 'is an empty string for single empty url element' do
+      expect(empty_url.text).to be_empty
+    end
+  end
+
+  context 'with a record with holdingSimple data' do
+    subject(:record) do
+      mods_record(<<-XML)
+        <location>
+          <physicalLocation authority='marcorg'>MnRM</physicalLocation>
+          <holdingSimple>
+            <copyInformation>
+              <subLocation>Patient reading room</subLocation>
+              <shelfLocator>QH511.A1J68</shelfLocator>
+              <enumerationAndChronology unitType='1'> v.1-v.8 1970-1976</enumerationAndChronology>
+            </copyInformation>
+          </holdingSimple>
+        </location>
+      XML
+    end
+
+    it "has aholdingSimple child element" do
+      expect(record.location.holdingSimple.copyInformation.first).to have_attributes(
+        sub_location: have_attributes(text: 'Patient reading room'),
+        shelf_locator: have_attributes(text: 'QH511.A1J68'),
+        enumeration_and_chronology: have_attributes(text: ' v.1-v.8 1970-1976', unitType: ['1'])
+      )
+    end
+  end
+
+
+  context 'with a record with holdingComplex data' do
+    subject(:record) do
+      mods_record(<<-XML)
+        <location>
+          <physicalLocation>Menlo Park Public Library</physicalLocation>
+          <holdingExternal>
+            <holding xmlns='info:ofi/fmt:xml:xsd:iso20775' xsi:schemaLocation='info:ofi/fmt:xml:xsd:iso20775 http://www.loc.gov/standards/iso20775/N130_ISOholdings_v6_1.xsd'>
+              <institutionIdentifier>
+                <value>JRF</value>
+                <typeOrSource>
+                    <pointer>http://worldcat.org/registry/institutions/</pointer>
+                </typeOrSource>
+              </institutionIdentifier>
+              <physicalLocation>Menlo Park Public Library</physicalLocation>
+              <physicalAddress>
+                <text>Menlo Park, CA 94025 United States </text>
+              </physicalAddress>
+              <electronicAddress>
+                <text>http://www.worldcat.org/wcpa/oclc/15550774? page=frame&amp;url=%3D%3FUTF-8%3FB%FaHR0cDovL2NhdGFsb2cucGxzaW5mby5vcmcvc2VhcmNoL2kwMTk1MDM4NjMw%3F%3D&amp;title=Menlo+Park+Public+Library&amp;linktype=opac&amp;detail=JRF%3AMenlo+Park+Public+Library%3APublic&amp;app=wcapi&amp;id=OCL-OCLC+Staff+use</text>
+              </electronicAddress>
+              <holdingSimple>
+                <copiesSummary>
+                  <copiesCount>1</copiesCount>
+                </copiesSummary>
+              </holdingSimple>
+            </holding>
+          </holdingExternal>
+        </location>
+      XML
+    end
+
+    it "has a holdingComplex child element" do
+      expect(record.location.holdingExternal.xpath('//h:holding/h:physicalLocation', h: 'info:ofi/fmt:xml:xsd:iso20775').map(&:text)).to eq ['Menlo Park Public Library']
+    end
+  end
+end