katello 4.16.3 → 4.17.0.rc1

data/webpack/ouia_id_check.js

@@ -7,12 +7,6 @@ import {
   Checkbox,
   Chip,
   ChipGroup,
-  ContextSelector,
-  Dropdown,
-  DropdownItem,
-  DropdownSeparator,
-  DropdownToggle,
-  DropdownToggleCheckbox,
   FormSelect,
   Menu,
   Modal,
@@ -20,10 +14,8 @@ import {
   Nav,
   NavExpandable,
   NavItem,
-  OptionsMenu,
   Pagination,
   Radio,
-  Select,
   Switch,
   TabButton,
   TabContent,
@@ -34,10 +26,22 @@ import {
   Toolbar,
 } from '@patternfly/react-core';
 import {
-  Table,
-  TableComposable,
+  ContextSelector,
+  Dropdown,
+  DropdownItem,
+  DropdownSeparator,
+  DropdownToggle,
+  DropdownToggleCheckbox,
+  OptionsMenu,
+  Select,
+} from '@patternfly/react-core/deprecated';
+import {
   Tr,
 } from '@patternfly/react-table';
+import {
+  Table as TableDeprecated,
+  Table,
+} from '@patternfly/react-table/deprecated';
 
 const checkForOuiaIds = () => {
   const ouiaSupportedPFComponents = [
@@ -74,7 +78,7 @@ const checkForOuiaIds = () => {
     Title,
     Toolbar,
     Table,
-    TableComposable,
+    TableDeprecated,
     Tr,
   ];
   beforeEach(() => {

data/webpack/redux/actions/RedHatRepositories/helpers.js

@@ -10,8 +10,6 @@ const repoTypeSearchQueryMap = {
 };
 
 const recommendedRepositoriesRHEL = [
-  'rhel-10-for-x86_64-baseos-rpms',
-  'rhel-10-for-x86_64-baseos-kickstart',
   'rhel-10-for-x86_64-baseos-rpms',
   'rhel-10-for-x86_64-baseos-kickstart',
   'rhel-10-for-x86_64-appstream-rpms',

data/webpack/scenes/ActivationKeys/Details/__tests__/activationKeyDetails.test.js

@@ -36,7 +36,8 @@ test('Makes API call and displays AK details on screen', async (done) => {
   expect(getByText('test description')).toBeInTheDocument();
   expect(getByText('1/4')).toBeInTheDocument();
 
-  assertNockRequest(akScope, done);
+  assertNockRequest(akScope);
+  done();
 });
 
 test('Displays placeholder when description is missing', async (done) => {
@@ -54,7 +55,8 @@ test('Displays placeholder when description is missing', async (done) => {
   await patientlyWaitFor(() => expect(getByRole('heading', { name: 'test' })).toBeInTheDocument());
   expect(getByText('No description provided')).toBeInTheDocument();
 
-  assertNockRequest(akScope, done);
+  assertNockRequest(akScope);
+  done();
 });
 
 test('Delete menu appears when toggle is clicked', async (done) => {
@@ -67,7 +69,8 @@ test('Delete menu appears when toggle is clicked', async (done) => {
   fireEvent.click(deleteToggle);
   await patientlyWaitFor(() => expect(getByText('Delete')).toBeInTheDocument());
 
-  assertNockRequest(akScope, done);
+  assertNockRequest(akScope);
+  done();
 });
 
 test('Edit modal appears when button is clicked', async (done) => {
@@ -79,7 +82,8 @@ test('Edit modal appears when button is clicked', async (done) => {
   fireEvent.click(editButton);
   await patientlyWaitFor(() => expect(getByText('Edit activation key')).toBeInTheDocument());
 
-  assertNockRequest(akScope, done);
+  assertNockRequest(akScope);
+  done();
 });
 
 test('Page displays 0 when usage count is null', async (done) => {
@@ -97,7 +101,8 @@ test('Page displays 0 when usage count is null', async (done) => {
   await patientlyWaitFor(() => expect(getByRole('heading', { name: 'test' })).toBeInTheDocument());
   expect(getByText('0/4')).toBeInTheDocument();
 
-  assertNockRequest(akScope, done);
+  assertNockRequest(akScope);
+  done();
 });
 
 test('Delete modal appears when link is clicked', async (done) => {
@@ -113,5 +118,6 @@ test('Delete modal appears when link is clicked', async (done) => {
   fireEvent.click(deleteLink);
   await patientlyWaitFor(() => expect(getByText('Activation Key will no longer be available for use. This operation cannot be undone.')).toBeInTheDocument());
 
-  assertNockRequest(akScope, done);
+  assertNockRequest(akScope);
+  done();
 });

data/webpack/scenes/ActivationKeys/Details/components/DeleteMenu.js

@@ -2,7 +2,17 @@ import React, {
   useState,
 } from 'react';
 import PropTypes from 'prop-types';
-import { Dropdown, DropdownItem, KebabToggle, DropdownPosition, Split, Icon, Text } from '@patternfly/react-core';
+import {
+  Split,
+  Icon,
+  Text,
+} from '@patternfly/react-core';
+import {
+  Dropdown,
+  DropdownItem,
+  KebabToggle,
+  DropdownPosition,
+} from '@patternfly/react-core/deprecated';
 import { UndoIcon, TrashIcon } from '@patternfly/react-icons';
 import { noop } from 'foremanReact/common/helpers';
 import { translate as __ } from 'foremanReact/common/I18n';
@@ -56,7 +66,7 @@ const DeleteMenu = ({ handleModalToggle, akId }) => {
       ouiaId="dekete-action"
       onSelect={onSelect}
       position={DropdownPosition.right}
-      toggle={<KebabToggle id="toggle-kebab" aria-label="delete-toggle" onToggle={onToggle} />}
+      toggle={<KebabToggle id="toggle-kebab" aria-label="delete-toggle" onToggle={(_event, isOpenValue) => onToggle(isOpenValue)} />}
       isOpen={isOpen}
       isPlain
       dropdownItems={dropdownItems}

data/webpack/scenes/ActivationKeys/Details/components/EditModal.js

@@ -131,7 +131,7 @@ const EditModal = ({ akDetails, akId }) => {
               id="ak-name-input"
               type="text"
               value={nameValue}
-              onChange={handleNameInputChange}
+              onChange={(_event, value) => handleNameInputChange(value)}
             />
           </FormGroup>
           <FormGroup
@@ -150,7 +150,7 @@ const EditModal = ({ akDetails, akId }) => {
                   minusBtnAriaLabel="minus"
                   plusBtnAriaLabel="plus"
                   isDisabled={isUnlimited}
-                  allowEmptyInput
+
                 />
               </StackItem>
               <StackItem>
@@ -172,7 +172,7 @@ const EditModal = ({ akDetails, akId }) => {
               type="text"
               placeholder={__('Description')}
               value={descriptionValue || ''}
-              onChange={handleDescriptionInputChange}
+              onChange={(_event, value) => handleDescriptionInputChange(value)}
             />
           </FormGroup>
         </Form>

data/webpack/scenes/AlternateContentSources/Create/ACSCreateWizard.js

@@ -1,7 +1,9 @@
 import React, { useEffect, useState } from 'react';
 import { useDispatch } from 'react-redux';
 import PropTypes from 'prop-types';
-import { Wizard } from '@patternfly/react-core';
+import {
+  Wizard,
+} from '@patternfly/react-core/deprecated';
 import { translate as __ } from 'foremanReact/common/I18n';
 import ACSCreateContext from './ACSCreateContext';
 import SelectSource from './Steps/SelectSource';

data/webpack/scenes/AlternateContentSources/Create/Steps/ACSCreateFinish.js

@@ -3,7 +3,9 @@ import { useDispatch, useSelector } from 'react-redux';
 import { useHistory } from 'react-router-dom';
 import PropTypes from 'prop-types';
 import useDeepCompareEffect from 'use-deep-compare-effect';
-import { WizardContextConsumer } from '@patternfly/react-core';
+import {
+  WizardContextConsumer,
+} from '@patternfly/react-core/deprecated';
 import { translate as __ } from 'foremanReact/common/I18n';
 import { STATUS } from 'foremanReact/constants';
 import ACSCreateContext from '../ACSCreateContext';

data/webpack/scenes/AlternateContentSources/Create/Steps/ACSCredentials.js

@@ -58,6 +58,7 @@ const ACSCredentials = () => {
             setSslCertName('');
             setSslKeyName('');
           }}
+          style={{ marginTop: '0rem' }}
         />
         }
         {(authentication === 'manual') &&
@@ -76,7 +77,7 @@ const ACSCredentials = () => {
                 name="acs_username_field"
                 aria-label="acs_username_field"
                 value={username}
-                onChange={(value) => { setUsername(value); }}
+                onChange={(_event, value) => { setUsername(value); }}
               />
 
             </FormGroup>
@@ -93,7 +94,7 @@ const ACSCredentials = () => {
                 name="acs_password_field"
                 aria-label="acs_password_field"
                 value={password}
-                onChange={(value) => { setPassword(value); }}
+                onChange={(_event, value) => { setPassword(value); }}
               />
             </FormGroup>
           </>
@@ -110,6 +111,7 @@ const ACSCredentials = () => {
             setUsername('');
             setPassword('');
           }}
+          style={{ marginTop: '0rem' }}
         />
         {(authentication === 'content_credentials') &&
         <>
@@ -122,7 +124,10 @@ const ACSCredentials = () => {
               ouiaId="sslCert-select"
               isRequired
               value={sslCert}
-              onChange={(value) => { setSslCert(value); setSslCertName(getCertName(value)); }}
+              onChange={(_event, value) => {
+                setSslCert(value);
+                setSslCertName(getCertName(value));
+              }}
               aria-label="sslCert_select"
             >
               {
@@ -152,7 +157,7 @@ const ACSCredentials = () => {
               ouiaId="sslKey-select"
               isRequired
               value={sslKey}
-              onChange={(value) => { setSslKey(value); setSslKeyName(getCertName(value)); }}
+              onChange={(_event, value) => { setSslKey(value); setSslKeyName(getCertName(value)); }}
               aria-label="sslKey_select"
             >
               {
@@ -191,6 +196,7 @@ const ACSCredentials = () => {
             setUsername('');
             setPassword('');
           }}
+          style={{ marginTop: '0rem' }}
         />
         <FormGroup label={__('Verify SSL')} fieldId="verify_ssl">
           <Switch
@@ -198,7 +204,7 @@ const ACSCredentials = () => {
             ouiaId="verify-ssl-switch"
             aria-label="verify-ssl-switch"
             isChecked={verifySSL}
-            onChange={checked => setVerifySSL(checked)}
+            onChange={(_event, checked) => setVerifySSL(checked)}
           />
         </FormGroup>
         <FormGroup
@@ -211,7 +217,7 @@ const ACSCredentials = () => {
             isDisabled={!verifySSL}
             isRequired
             value={caCert}
-            onChange={(value) => { setCACert(value); setCACertName(getCertName(value)); }}
+            onChange={(_event, value) => { setCACert(value); setCACertName(getCertName(value)); }}
             aria-label="sslCAcert_select"
           >
             {

data/webpack/scenes/AlternateContentSources/Create/Steps/ACSSmartProxies.js

@@ -58,7 +58,7 @@ const ACSSmartProxies = () => {
           ouiaId="use-http-proxies-switch"
           aria-label="use-http-proxies-switch"
           isChecked={useHttpProxies}
-          onChange={checked => setUseHttpProxies(checked)}
+          onChange={(_event, checked) => setUseHttpProxies(checked)}
         />
       </FormGroup>
     </>

data/webpack/scenes/AlternateContentSources/Create/Steps/AcsUrlPaths.js

@@ -6,6 +6,9 @@ import {
   FormGroup,
   TextInput,
   TextArea,
+  FormHelperText,
+  HelperText,
+  HelperTextItem,
 } from '@patternfly/react-core';
 import ACSCreateContext from '../ACSCreateContext';
 import WizardHeader from '../../../ContentViews/components/WizardHeader';
@@ -41,8 +44,6 @@ const AcsUrlPaths = () => {
         <FormGroup
           label={__('Base URL')}
           fieldId="acs_base_url"
-          helperTextInvalid={helperTextInvalid}
-          validated={urlValidated}
           isRequired
         >
           <TextInput
@@ -55,8 +56,17 @@ const AcsUrlPaths = () => {
             placeholder={baseURLplaceholder}
             value={url}
             validated={urlValidated}
-            onChange={value => setUrl(value)}
+            onChange={(_event, value) => setUrl(value)}
           />
+          {urlValidated === 'error' && (
+            <FormHelperText>
+              <HelperText>
+                <HelperTextItem variant="error">
+                  {helperTextInvalid}
+                </HelperTextItem>
+              </HelperText>
+            </FormHelperText>
+          )}
         </FormGroup>
         {acsType === 'rhui' &&
         <>
@@ -73,19 +83,24 @@ const AcsUrlPaths = () => {
         <FormGroup
           label={__('Subpaths')}
           type="string"
-          fieldId="acs_subpaths"
-          helperTextInvalid={__('Comma-separated list of subpaths. All subpaths must have a slash at the end and none at the front.')}
-          validated={subPathValidated}
         >
           <TextArea
             placeholder="test/repo1/, test/repo2/,"
             value={subpaths}
             validated={subPathValidated}
-            onChange={value => setSubpaths(value)}
+            onChange={(_event, value) => setSubpaths(value)}
             name="acs_subpath_field"
             id="acs_subpath_field"
             aria-label="acs_subpath_field"
           />
+          {subPathValidated === 'error' && (
+            <FormHelperText>
+              <HelperText>
+                <HelperTextItem variant="error">
+                  {__('Comma-separated list of subpaths. All subpaths must have a slash at the end and none at the front.')}
+                </HelperTextItem>
+              </HelperText>
+            </FormHelperText>)}
         </FormGroup>
       </Form>
     </>

data/webpack/scenes/AlternateContentSources/Create/Steps/NameACS.js

@@ -35,7 +35,7 @@ const NameACS = () => {
             name="acs_name_field"
             aria-label="acs_name_field"
             value={name}
-            onChange={(value) => { setName(value); }}
+            onChange={(_event, value) => { setName(value); }}
           />
         </FormGroup>
         <FormGroup
@@ -45,7 +45,7 @@ const NameACS = () => {
         >
           <TextArea
             value={description}
-            onChange={(value) => { setDescription(value); }}
+            onChange={(_event, value) => { setDescription(value); }}
             name="acs_description_field"
             id="acs_description_field"
           />

data/webpack/scenes/AlternateContentSources/Create/Steps/SelectSource.js

@@ -111,7 +111,7 @@ const SelectSource = () => {
             isRequired
             isDisabled={acsType === 'rhui'}
             value={contentType}
-            onChange={(value) => {
+            onChange={(_event, value) => {
               setContentType(value);
             }}
             aria-label="FormSelect Input"

data/webpack/scenes/AlternateContentSources/Create/__tests__/acsCreate.test.js

@@ -215,7 +215,8 @@ test('Can display create wizard and create custom ACS', async (done) => {
   assertNockRequest(contentCredentialScope);
   assertNockRequest(productScope);
   assertNockRequest(smartProxyScope);
-  assertNockRequest(createScope, done);
+  assertNockRequest(createScope);
+  done();
   act(done);
 });
 
@@ -307,7 +308,8 @@ test('Can display create wizard and create RHUI ACS', async (done) => {
   assertNockRequest(contentCredentialScope);
   assertNockRequest(productScope);
   assertNockRequest(smartProxyScope);
-  assertNockRequest(createScope, done);
+  assertNockRequest(createScope);
+  done();
   act(done);
 });
 
@@ -387,6 +389,7 @@ test('Can display create wizard and create simplified ACS', async (done) => {
   assertNockRequest(productScope);
   assertNockRequest(contentCredentialScope);
   assertNockRequest(smartProxyScope);
-  assertNockRequest(createScope, done);
+  assertNockRequest(createScope);
+  done();
   act(done);
 });

data/webpack/scenes/AlternateContentSources/Details/ACSExpandableDetails.js

@@ -103,7 +103,8 @@ const ACSExpandableDetails = ({ expandedId }) => {
                   setShowUrlPaths(false);
                   setShowCredentials(false);
                 }}
-                contentId="showDetails"
+                contentId="showDetails-content"
+                toggleId="showDetails-toggle"
               >
                 <Text ouiaId="expandable-details-text">{__('Details')}</Text>
               </ExpandableSectionToggle>
@@ -114,7 +115,7 @@ const ACSExpandableDetails = ({ expandedId }) => {
                 ouiaId="edit-details-pencil-edit"
                 aria-label="edit-details-pencil-edit"
                 variant="link"
-                isSmall
+                size="sm"
                 icon={<PencilAltIcon />}
                 onClick={() => setEditDetailsModalOpen(true)}
               >{__('Edit')}
@@ -127,7 +128,8 @@ const ACSExpandableDetails = ({ expandedId }) => {
           <ExpandableSection
             isExpanded={showDetails}
             isDetached
-            contentId="showDetails"
+            contentId="showDetails-content"
+            toggleId="showDetails-toggle"
           >
             <TextContent className="margin-0-24 expandable-section-text">
               <TextList component={TextListVariants.dl}>
@@ -183,7 +185,8 @@ const ACSExpandableDetails = ({ expandedId }) => {
                   setShowCredentials(false);
                   setShowProducts(false);
                 }}
-                contentId="showSmartProxies"
+                contentId="showSmartProxies-content"
+                toggleId="showSmartProxies-toggle"
               >
                 <Text ouiaId="expandable-smart-proxies-text">{__('Smart proxies')}</Text>
               </ExpandableSectionToggle>
@@ -194,7 +197,7 @@ const ACSExpandableDetails = ({ expandedId }) => {
                 ouiaId="edit-smart-proxies-pencil-edit"
                 aria-label="edit-smart-proxies-pencil-edit"
                 variant="link"
-                isSmall
+                size="sm"
                 icon={<PencilAltIcon />}
                 onClick={() => setEditSmartProxiesModalOpen(true)}
               >{__('Edit')}
@@ -206,7 +209,8 @@ const ACSExpandableDetails = ({ expandedId }) => {
         <StackItem className="primary-detail-stack-items-border">
           <ExpandableSection
             isDetached
-            contentId="showSmartProxies"
+            contentId="showSmartProxies-content"
+            toggleId="showSmartProxies-toggle"
             isExpanded={showSmartProxies}
           >
             <List className="margin-0-24 expandable-section-text" isPlain isBordered>
@@ -254,7 +258,8 @@ const ACSExpandableDetails = ({ expandedId }) => {
                     setShowCredentials(false);
                   }}
                   isExpanded={showProducts}
-                  contentId="showProducts"
+                  contentId="showProducts-content"
+                  toggleId="showProducts-toggle"
                 >
                   <Text ouiaId="expandable-products-text">{__('Products')}</Text>
                 </ExpandableSectionToggle>
@@ -265,7 +270,7 @@ const ACSExpandableDetails = ({ expandedId }) => {
                   ouiaId="edit-products-pencil-edit"
                   aria-label="edit-products-pencil-edit"
                   variant="link"
-                  isSmall
+                  size="sm"
                   icon={<PencilAltIcon />}
                   onClick={() => setEditProductsModalOpen(true)}
                 >{__('Edit')}
@@ -277,7 +282,8 @@ const ACSExpandableDetails = ({ expandedId }) => {
           <StackItem>
             <ExpandableSection
               isDetached
-              contentId="showProducts"
+              contentId="showProducts-content"
+              toggleId="showProducts-toggle"
               isExpanded={showProducts}
             >
               <List className="margin-0-24 expandable-section-text" isPlain isBordered>
@@ -308,7 +314,8 @@ const ACSExpandableDetails = ({ expandedId }) => {
                     setShowCredentials(false);
                   }}
                   isExpanded={showUrlPaths}
-                  contentId="showUrlPaths"
+                  contentId="showUrlPaths-content"
+                  toggleId="showUrlPaths-toggle"
                 >
                   <Text ouiaId="expandable-url-paths-text">{__('URL and subpaths')}</Text>
                 </ExpandableSectionToggle>
@@ -319,7 +326,7 @@ const ACSExpandableDetails = ({ expandedId }) => {
                   ouiaId="edit-urls-pencil-edit"
                   aria-label="edit-urls-pencil-edit"
                   variant="link"
-                  isSmall
+                  size="sm"
                   icon={<PencilAltIcon />}
                   onClick={() => setEditUrlModalOpen(true)}
                 >{__('Edit')}
@@ -330,7 +337,8 @@ const ACSExpandableDetails = ({ expandedId }) => {
           </StackItem>
           <StackItem className="primary-detail-stack-items-border">
             <ExpandableSection
-              contentId="showUrlPaths"
+              contentId="showUrlPaths-content"
+              toggleId="showUrlPaths-toggle"
               isDetached
               isExpanded={showUrlPaths}
             >
@@ -369,7 +377,8 @@ const ACSExpandableDetails = ({ expandedId }) => {
                     setShowCredentials(expanded);
                   }}
                   isExpanded={showCredentials}
-                  contentId="showCredentials"
+                  contentId="showCredentials-content"
+                  toggleId="showCredentials-toggle"
                 >
                   <Text ouiaId="expandable-credentials-text">{__('Credentials')}</Text>
                 </ExpandableSectionToggle>
@@ -380,7 +389,7 @@ const ACSExpandableDetails = ({ expandedId }) => {
                   ouiaId="edit-credentials-pencil-edit"
                   aria-label="edit-credentials-pencil-edit"
                   variant="link"
-                  isSmall
+                  size="sm"
                   icon={<PencilAltIcon />}
                   onClick={() => setEditCredentialsModalOpen(true)}
                 >{__('Edit')}
@@ -392,7 +401,8 @@ const ACSExpandableDetails = ({ expandedId }) => {
           <StackItem className="primary-detail-stack-items-border">
             <ExpandableSection
               isExpanded={showCredentials}
-              contentId="showCredentials"
+              contentId="showCredentials-content"
+              toggleId="showCredentials-toggle"
               isDetached
             >
               <TextContent className="margin-0-24 expandable-section-text">

data/webpack/scenes/AlternateContentSources/Details/EditModals/ACSEditCredentials.js

@@ -135,7 +135,7 @@ const ACSEditCredentials = ({ onClose, acsId, acsDetails }) => {
             id="verify-ssl-switch"
             aria-label="verify-ssl-switch"
             isChecked={acsVerifySSL}
-            onChange={checked => setAcsVerifySSL(checked)}
+            onChange={(_event, checked) => setAcsVerifySSL(checked)}
           />
         </FormGroup>
         <FormGroup
@@ -148,7 +148,7 @@ const ACSEditCredentials = ({ onClose, acsId, acsDetails }) => {
             isRequired
             isDisabled={!acsVerifySSL}
             value={acsCAcert}
-            onChange={value => setAcsCAcert(value)}
+            onChange={(_event, value) => setAcsCAcert(value)}
             aria-label="sslCAcert_select"
           >
             {
@@ -180,6 +180,7 @@ const ACSEditCredentials = ({ onClose, acsId, acsDetails }) => {
             setAcsSslClientCert('');
             setAcsSslClientKey('');
           }}
+          style={{ marginTop: '0rem' }}
         />
         {authentication === 'manual' &&
         <>
@@ -197,7 +198,7 @@ const ACSEditCredentials = ({ onClose, acsId, acsDetails }) => {
               name="acs_username_field"
               aria-label="acs_username_field"
               value={acsUsername}
-              onChange={(value) => {
+              onChange={(_event, value) => {
                 setAcsUsername(value);
               }}
             />
@@ -216,7 +217,7 @@ const ACSEditCredentials = ({ onClose, acsId, acsDetails }) => {
               name="acs_password_field"
               aria-label="acs_password_field"
               value={acsPassword}
-              onChange={(value) => {
+              onChange={(_event, value) => {
                 setAcsPassword(value);
               }}
             />
@@ -235,6 +236,7 @@ const ACSEditCredentials = ({ onClose, acsId, acsDetails }) => {
             setAcsUsername('');
             setAcsPassword('');
           }}
+          style={{ marginTop: '0rem' }}
         />
         {authentication === 'credentials' &&
         <>
@@ -247,7 +249,7 @@ const ACSEditCredentials = ({ onClose, acsId, acsDetails }) => {
               ouiaId="ssl-client-cert-select"
               isRequired
               value={acsSslClientCert}
-              onChange={value => setAcsSslClientCert(value)}
+              onChange={(_event, value) => setAcsSslClientCert(value)}
               aria-label="ssl_client_cert_select"
             >
               {
@@ -276,7 +278,7 @@ const ACSEditCredentials = ({ onClose, acsId, acsDetails }) => {
               ouiaId="ssl_client_key_select"
               isRequired
               value={acsSslClientKey}
-              onChange={value => setAcsSslClientKey(value)}
+              onChange={(_event, value) => setAcsSslClientKey(value)}
               aria-label="ssl_client_key_select"
             >
               {
@@ -311,6 +313,7 @@ const ACSEditCredentials = ({ onClose, acsId, acsDetails }) => {
             setAcsUsername('');
             setAcsPassword('');
           }}
+          style={{ marginTop: '0rem' }}
         />
         <ActionGroup>
           <Button

data/webpack/scenes/AlternateContentSources/Details/EditModals/ACSEditDetails.js

@@ -50,7 +50,7 @@ const ACSEditDetails = ({ onClose, acsId, acsDetails }) => {
             name="acs_name_field"
             aria-label="acs_name_field"
             value={acsName}
-            onChange={(value) => {
+            onChange={(_event, value) => {
               setACSName(value);
             }}
           />
@@ -62,7 +62,7 @@ const ACSEditDetails = ({ onClose, acsId, acsDetails }) => {
         >
           <TextArea
             value={acsDescription}
-            onChange={(value) => {
+            onChange={(_event, value) => {
               setAcsDescription(value);
             }}
             name="acs_description_field"

data/webpack/scenes/AlternateContentSources/Details/EditModals/ACSEditSmartProxies.js

@@ -113,7 +113,7 @@ const ACSEditSmartProxies = ({ onClose, acsId, acsDetails }) => {
             aria-label="use-http-proxies-switch"
             ouiaId="use-http-proxies-switch"
             isChecked={acsUseHttpProxies}
-            onChange={checked => setAcsUseHttpProxies(checked)}
+            onChange={(_event, checked) => setAcsUseHttpProxies(checked)}
           />
         </FormGroup>
         <ActionGroup>