katello 4.16.3 → 4.17.0.rc1

data/webpack/components/extensions/HostDetails/Tabs/__tests__/moduleStreamsTab.test.js

@@ -62,7 +62,8 @@ test('Can call API for Module streams and show on screen on page load', async (d
     expect(getAllByText(firstModuleStreams.name)[0]).toBeInTheDocument());
   // Assert request was made and completed, see helper function
   assertNockRequest(autocompleteScope);
-  assertNockRequest(scope, done); // Pass jest callback to confirm test is done
+  assertNockRequest(scope);
+  done(); // Pass jest callback to confirm test is done
   act(done);
 });
 
@@ -89,7 +90,8 @@ test('Can handle no Module streams being present', async (done) => {
   await patientlyWaitFor(() => expect(queryByText('This host does not have any Module streams.')).toBeInTheDocument());
   // Assert request was made and completed, see helper function
   assertNockRequest(autocompleteScope);
-  assertNockRequest(scope, done); // Pass jest callback to confirm test is done
+  assertNockRequest(scope);
+  done(); // Pass jest callback to confirm test is done
   act(done);
 });
 
@@ -166,7 +168,8 @@ test('When there are no search results, can display an empty state with a clear
   assertNockRequest(badAutoCompleteScope);
   assertNockRequest(badSearchScope);
   assertNockRequest(scopeWithoutSearch);
-  assertNockRequest(autocompleteScope, done);
+  assertNockRequest(autocompleteScope);
+  done();
 });
 
 test('Can filter results based on status', async (done) => {
@@ -198,7 +201,8 @@ test('Can filter results based on status', async (done) => {
   fireEvent.click(installed);
   assertNockRequest(autocompleteScope);
   assertNockRequest(scope);
-  assertNockRequest(scope2, done);
+  assertNockRequest(scope2);
+  done();
   act(done);
 });
 
@@ -231,7 +235,8 @@ test('Can filter results based on Installation status', async (done) => {
   fireEvent.click(installed);
   assertNockRequest(autocompleteScope);
   assertNockRequest(scope);
-  assertNockRequest(scope2, done);
+  assertNockRequest(scope2);
+  done();
   act(done);
 });
 
@@ -260,7 +265,8 @@ test('Can provide dropdown actions with redirects on Module Streams with customi
   expect(getByText('Enable')).toHaveAttribute('href', '/job_invocations/new?feature=katello_module_stream_action&search=name%20%5E%20(test-host)&inputs%5Baction%5D=enable&inputs%5Bmodule_spec%5D=walrus:2.4');
   expect(getByText('Install')).toHaveAttribute('href', '/job_invocations/new?feature=katello_module_stream_action&search=name%20%5E%20(test-host)&inputs%5Baction%5D=install&inputs%5Bmodule_spec%5D=walrus:2.4');
   assertNockRequest(autocompleteScope);
-  assertNockRequest(scope, done);
+  assertNockRequest(scope);
+  done();
   act(done);
 });
 
@@ -305,6 +311,7 @@ test('Can perform actions on Module Streams', async (done) => {
   fireEvent.click(getByLabelText('confirm-module-action'));
   assertNockRequest(autocompleteScope);
   assertNockRequest(scope);
-  assertNockRequest(jobScope, done);
+  assertNockRequest(jobScope);
+  done();
   act(done);
 });

data/webpack/components/extensions/HostDetails/Tabs/__tests__/packageInstallModal.test.js

@@ -79,7 +79,8 @@ test('Can call API for installable packages and show on screen on page load', as
   await patientlyWaitFor(() => expect(getAllByText(firstPackages.name)[0]).toBeInTheDocument());
   // Assert request was made and completed, see helper function
   assertNockRequest(autocompleteScope);
-  assertNockRequest(scope, done); // Pass jest callback to confirm test is done
+  assertNockRequest(scope);
+  done(); // Pass jest callback to confirm test is done
 });
 
 test('Can handle no installable packages being present', async (done) => {
@@ -111,7 +112,8 @@ test('Can handle no installable packages being present', async (done) => {
   await patientlyWaitFor(() => expect(queryByText('No packages available to install')).toBeInTheDocument());
   // Assert request was made and completed, see helper function
   assertNockRequest(autocompleteScope);
-  assertNockRequest(scope, done); // Pass jest callback to confirm test is done
+  assertNockRequest(scope);
+  done(); // Pass jest callback to confirm test is done
 });
 
 
@@ -148,7 +150,8 @@ test('Can install a package via remote execution', async (done) => {
 
   expect(triggerPackageInstall).toHaveBeenCalled();
   assertNockRequest(autocompleteScope);
-  assertNockRequest(scope, done);
+  assertNockRequest(scope);
+  done();
 });
 
 test('Can install a package via customized remote execution', async (done) => {
@@ -185,7 +188,8 @@ test('Can install a package via customized remote execution', async (done) => {
     `/job_invocations/new?feature=${REX_FEATURES.KATELLO_PACKAGE_INSTALL}&search=name%20%5E%20(test-host)&inputs%5Bpackage%5D=duck,cheetah`,
   );
   assertNockRequest(autocompleteScope);
-  assertNockRequest(scope, done);
+  assertNockRequest(scope);
+  done();
 });
 
 test('Uses package_install_by_search_query template when in select all mode', async (done) => {
@@ -223,6 +227,7 @@ test('Uses package_install_by_search_query template when in select all mode', as
     `/job_invocations/new?feature=${REX_FEATURES.KATELLO_PACKAGE_INSTALL_BY_SEARCH}&search=name%20%5E%20(test-host)&inputs%5BPackage%20search%20query%5D=id%20!%5E%20(32376)`,
   );
   assertNockRequest(autocompleteScope);
-  assertNockRequest(scope, done);
+  assertNockRequest(scope);
+  done();
 });
 

data/webpack/components/extensions/HostDetails/Tabs/__tests__/packagesTab.test.js

@@ -1,5 +1,5 @@
 import React from 'react';
-import { renderWithRedux, patientlyWaitFor, fireEvent } from 'react-testing-lib-wrapper';
+import { renderWithRedux, patientlyWaitFor, fireEvent, act } from 'react-testing-lib-wrapper';
 import * as hooks from 'foremanReact/components/PF4/TableIndexPage/Table/TableHooks';
 import { nockInstance, assertNockRequest, mockForemanAutocomplete } from '../../../../../test-utils/nockWrapper';
 import { foremanApi } from '../../../../../services/api';
@@ -79,7 +79,8 @@ test('Can call API for packages and show on screen on page load', async (done) =
   await patientlyWaitFor(() => expect(getAllByText(firstPackage.name)[0]).toBeInTheDocument());
   // Assert request was made and completed, see helper function
   assertNockRequest(autocompleteScope);
-  assertNockRequest(scope, done); // Pass jest callback to confirm test is done
+  assertNockRequest(scope);
+  act(done); // Pass jest callback to confirm test is done
 });
 
 test('Can handle no packages being present', async (done) => {
@@ -105,7 +106,8 @@ test('Can handle no packages being present', async (done) => {
   await patientlyWaitFor(() => expect(queryByText('This host does not have any packages.')).toBeInTheDocument());
   // Assert request was made and completed, see helper function
   assertNockRequest(autocompleteScope);
-  assertNockRequest(scope, done); // Pass jest callback to confirm test is done
+  assertNockRequest(scope);
+  act(done); // Pass jest callback to confirm test is done
 });
 
 test('Can filter by package status', async (done) => {
@@ -145,7 +147,8 @@ test('Can filter by package status', async (done) => {
 
   assertNockRequest(autocompleteScope);
   assertNockRequest(scope);
-  assertNockRequest(scope2, done); // Pass jest callback to confirm test is done
+  assertNockRequest(scope2);
+  act(done); // Pass jest callback to confirm test is done
 });
 
 test('Can upgrade a package via remote execution', async (done) => {
@@ -191,17 +194,20 @@ test('Can upgrade a package via remote execution', async (done) => {
     expect(getByText('coreutils')).toBeInTheDocument();
   });
 
-  const kebabDropdown = getByLabelText('Actions');
+  const kebabDropdown = getByLabelText('Kebab toggle');
   kebabDropdown.click();
 
+  await patientlyWaitFor(() => expect(getByText('Upgrade via remote execution')).toBeInTheDocument());
   const rexAction = getByText('Upgrade via remote execution');
-  await patientlyWaitFor(() => expect(rexAction).toBeInTheDocument());
-  fireEvent.click(rexAction);
+  await act(async () => {
+    fireEvent.click(rexAction);
+  });
 
   assertNockRequest(autocompleteScope);
   assertNockRequest(scope);
   assertNockRequest(statusScope);
   assertNockRequest(upgradeScope, done);
+  act(done);
 });
 
 test('Can upgrade a package via customized remote execution', async (done) => {
@@ -235,7 +241,7 @@ test('Can upgrade a package via customized remote execution', async (done) => {
     expect(getByText('coreutils')).toBeInTheDocument();
   });
 
-  const kebabDropdown = getByLabelText('Actions');
+  const kebabDropdown = getByLabelText('Kebab toggle');
   kebabDropdown.click();
 
   const rexAction = getByText('Upgrade via customized remote execution');
@@ -247,12 +253,14 @@ test('Can upgrade a package via customized remote execution', async (done) => {
     'href',
     `/job_invocations/new?feature=${feature}&search=name%20%5E%20(${hostname})&inputs%5Bpackage%5D=${packageName}`,
   );
-
-  fireEvent.click(rexAction);
+  await act(async () => {
+    fireEvent.click(rexAction);
+  });
 
   assertNockRequest(autocompleteScope);
   assertNockRequest(scope);
   assertNockRequest(statusScope, done);
+  act(done);
 });
 
 test('Can remove a package via remote execution', async (done) => {
@@ -283,13 +291,14 @@ test('Can remove a package via remote execution', async (done) => {
 
   await patientlyWaitFor(() => expect(getAllByText(firstPackage.name)[0]).toBeInTheDocument());
 
-  const kebabDropdown = getByLabelText('Actions');
-  kebabDropdown.click();
+  const kebabDropdown = getByLabelText('Kebab toggle');
+  fireEvent.click(kebabDropdown);
+  await patientlyWaitFor(() => expect(getByText('Remove')).toBeInTheDocument());
 
   const rexAction = getByText('Remove');
-  await patientlyWaitFor(() => expect(rexAction).toBeInTheDocument());
-  fireEvent.click(rexAction);
-
+  await act(async () => {
+    fireEvent.click(rexAction);
+  });
   assertNockRequest(autocompleteScope);
   assertNockRequest(scope);
   assertNockRequest(removeScope, done);
@@ -336,11 +345,13 @@ test('Can bulk remove a package via remote execution', async (done) => {
 
   const rexAction = getByText('Remove');
   await patientlyWaitFor(() => expect(rexAction).toBeInTheDocument());
-  fireEvent.click(rexAction);
-
+  await act(async () => {
+    fireEvent.click(rexAction);
+  });
   assertNockRequest(autocompleteScope);
   assertNockRequest(scope);
   assertNockRequest(removeScope, done);
+  act(done);
 });
 
 test('Can bulk upgrade via remote execution', async (done) => {
@@ -381,14 +392,16 @@ test('Can bulk upgrade via remote execution', async (done) => {
 
   const upgradeDropdown = getAllByRole('button', { name: 'Select' })[1];
   fireEvent.click(upgradeDropdown);
-
   const rexAction = getByLabelText('bulk_upgrade_rex');
   expect(rexAction).toBeInTheDocument();
-  fireEvent.click(rexAction);
+  await act(async () => {
+    fireEvent.click(rexAction);
+  });
 
   assertNockRequest(autocompleteScope);
   assertNockRequest(scope);
-  assertNockRequest(upgradeScope, done);
+  assertNockRequest(upgradeScope);
+  act(done);
 });
 
 test('Can bulk upgrade via customized remote execution', async (done) => {
@@ -427,7 +440,8 @@ test('Can bulk upgrade via customized remote execution', async (done) => {
   expect(rexAction).toHaveAttribute('href', job);
 
   assertNockRequest(autocompleteScope);
-  assertNockRequest(scope, done);
+  assertNockRequest(scope);
+  act(done);
 });
 
 test('Upgrade is disabled when there are non-upgradable packages selected', async (done) => {
@@ -457,7 +471,8 @@ test('Upgrade is disabled when there are non-upgradable packages selected', asyn
   expect(upgradeDropdown).toHaveAttribute('disabled');
 
   assertNockRequest(autocompleteScope);
-  assertNockRequest(scope, done);
+  assertNockRequest(scope);
+  act(done);
 });
 
 test('Remove is disabled when in select all mode', async (done) => {
@@ -483,7 +498,8 @@ test('Remove is disabled when in select all mode', async (done) => {
   expect(removeButton).toHaveAttribute('aria-disabled', 'true');
 
   assertNockRequest(autocompleteScope);
-  assertNockRequest(scope, done);
+  assertNockRequest(scope);
+  act(done);
 });
 
 test('Sets initial search query from url params', async (done) => {
@@ -504,6 +520,7 @@ test('Sets initial search query from url params', async (done) => {
   expect(queryByText(secondPackage.name)).not.toBeInTheDocument();
 
   assertNockRequest(autocompleteScope);
-  assertNockRequest(scope, done); // Pass jest callback to confirm test is done
+  assertNockRequest(scope);
+  act(done); // Pass jest callback to confirm test is done
 });
 

data/webpack/components/extensions/HostDetails/Tabs/__tests__/repositorySetsTab.test.js

@@ -1,5 +1,5 @@
 import React from 'react';
-import { renderWithRedux, patientlyWaitFor, within, fireEvent } from 'react-testing-lib-wrapper';
+import { renderWithRedux, patientlyWaitFor, within, fireEvent, act } from 'react-testing-lib-wrapper';
 import { nockInstance, assertNockRequest, mockAutocomplete } from '../../../../../test-utils/nockWrapper';
 import katelloApi, { foremanApi } from '../../../../../services/api';
 import { REPOSITORY_SETS_KEY } from '../RepositorySetsTab/RepositorySetsConstants';
@@ -83,7 +83,8 @@ test('Can call API for repository sets and show basic table', async (done) => {
   // Assert that the repository sets are now showing on the screen, but wait for them to appear.
   await patientlyWaitFor(() => expect(getByText(firstRepoSet.contentUrl)).toBeInTheDocument());
   assertNockRequest(autocompleteScope);
-  assertNockRequest(scope, done); // Pass jest callback to confirm test is done
+  assertNockRequest(scope);
+  done(); // Pass jest callback to confirm test is done
 });
 
 test('Can handle no repository sets being present', async (done) => {
@@ -108,7 +109,8 @@ test('Can handle no repository sets being present', async (done) => {
   await patientlyWaitFor(() => expect(queryByText('No repository sets to show.')).toBeInTheDocument());
   // Assert request was made and completed, see helper function
   assertNockRequest(autocompleteScope);
-  assertNockRequest(scope, done); // Pass jest callback to confirm test is done
+  assertNockRequest(scope);
+  done(); // Pass jest callback to confirm test is done
 });
 
 test('Toggle Group shows if it\'s not the default content view or library enviroment', async (done) => {
@@ -127,7 +129,8 @@ test('Toggle Group shows if it\'s not the default content view or library enviro
   await patientlyWaitFor(() => expect(getByText(firstRepoSet.contentUrl)).toBeInTheDocument());
   expect(queryByLabelText('Limit to environment')).toBeInTheDocument();
   assertNockRequest(autocompleteScope);
-  assertNockRequest(scope, done); // Pass jest callback to confirm test is done
+  assertNockRequest(scope);
+  done(); // Pass jest callback to confirm test is done
 });
 
 test('Toggle Group shows if it\'s the default content view but non-library environment', async (done) => {
@@ -151,7 +154,8 @@ test('Toggle Group shows if it\'s the default content view but non-library envir
   await patientlyWaitFor(() => expect(getByText(firstRepoSet.contentUrl)).toBeInTheDocument());
   expect(queryByLabelText('Limit to environment')).toBeInTheDocument();
   assertNockRequest(autocompleteScope);
-  assertNockRequest(scope, done); // Pass jest callback to confirm test is done
+  assertNockRequest(scope);
+  done(); // Pass jest callback to confirm test is done
 });
 
 test('Toggle Group shows if it\'s the library environment but a non-default content view', async (done) => {
@@ -174,7 +178,8 @@ test('Toggle Group shows if it\'s the library environment but a non-default cont
   await patientlyWaitFor(() => expect(getByText(firstRepoSet.contentUrl)).toBeInTheDocument());
   expect(queryByLabelText('Limit to environment')).toBeInTheDocument();
   assertNockRequest(autocompleteScope);
-  assertNockRequest(scope, done); // Pass jest callback to confirm test is done
+  assertNockRequest(scope);
+  done(); // Pass jest callback to confirm test is done
 });
 
 test('Toggle Group does not show if it\'s the library environment and default content view', async (done) => {
@@ -199,7 +204,8 @@ test('Toggle Group does not show if it\'s the library environment and default co
   await patientlyWaitFor(() => expect(getByText(firstRepoSet.contentUrl)).toBeInTheDocument());
   expect(queryByLabelText('Limit to environment')).not.toBeInTheDocument();
   assertNockRequest(autocompleteScope);
-  assertNockRequest(scope, done); // Pass jest callback to confirm test is done
+  assertNockRequest(scope);
+  done(); // Pass jest callback to confirm test is done
 });
 
 test('Can toggle with the Toggle Group ', async (done) => {
@@ -221,7 +227,8 @@ test('Can toggle with the Toggle Group ', async (done) => {
   expect(queryByLabelText('Limit to environment')).toHaveAttribute('aria-pressed', 'true');
   expect(queryByLabelText('No limit')).toHaveAttribute('aria-pressed', 'false');
   assertNockRequest(autocompleteScope);
-  assertNockRequest(scope, done); // Pass jest callback to confirm test is done
+  assertNockRequest(scope);
+  done(); // Pass jest callback to confirm test is done
 });
 
 test('Can override to disabled', async (done) => {
@@ -244,9 +251,10 @@ test('Can override to disabled', async (done) => {
   expect(getAllByText('Enabled')).toHaveLength(2);
   expect(getAllByText('Disabled')).toHaveLength(1);
   // Find the first action menu and click it
-  const actionMenu = getAllByLabelText('Actions')[0].closest('button');
-  fireEvent.click(actionMenu);
-
+  const actionMenu = getAllByLabelText('Kebab toggle')[0].closest('button');
+  await act(async () => {
+    fireEvent.click(actionMenu);
+  });
   const overrideMenuItem = getByText('Override to disabled');
   expect(overrideMenuItem).toBeInTheDocument();
   fireEvent.click(overrideMenuItem);
@@ -259,7 +267,8 @@ test('Can override to disabled', async (done) => {
 
   assertNockRequest(autocompleteScope);
   assertNockRequest(scope);
-  assertNockRequest(contentOverrideScope, done); // Pass jest callback to confirm test is done
+  assertNockRequest(contentOverrideScope);
+  done(); // Pass jest callback to confirm test is done
 });
 
 test('Can override to enabled', async (done) => {
@@ -284,8 +293,10 @@ test('Can override to enabled', async (done) => {
   expect(getAllByText('Enabled')).toHaveLength(2);
   expect(getAllByText('Disabled')).toHaveLength(1);
   // The second item is overridden to disabled; we're going to override to enabled
-  const actionMenu = getAllByLabelText('Actions')[1].closest('button');
-  fireEvent.click(actionMenu);
+  const actionMenu = getAllByLabelText('Kebab toggle')[1].closest('button');
+  await act(async () => {
+    fireEvent.click(actionMenu);
+  });
 
   const overrideMenuItem = getByText('Override to enabled');
   expect(overrideMenuItem).toBeInTheDocument();
@@ -298,7 +309,8 @@ test('Can override to enabled', async (done) => {
 
   assertNockRequest(autocompleteScope);
   assertNockRequest(scope);
-  assertNockRequest(contentOverrideScope, done); // Pass jest callback to confirm test is done
+  assertNockRequest(contentOverrideScope);
+  done(); // Pass jest callback to confirm test is done
 });
 
 test('Can reset to default', async (done) => {
@@ -323,8 +335,10 @@ test('Can reset to default', async (done) => {
   expect(getAllByText('Disabled')).toHaveLength(1);
 
   // The second item is overridden to disabled but would normally be enabled; we're going to reset
-  const actionMenu = getAllByLabelText('Actions')[1].closest('button');
-  fireEvent.click(actionMenu);
+  const actionMenu = getAllByLabelText('Kebab toggle')[1].closest('button');
+  await act(async () => {
+    fireEvent.click(actionMenu);
+  });
 
   const overrideMenuItem = getByText('Reset to default');
   expect(overrideMenuItem).toBeInTheDocument();
@@ -337,7 +351,8 @@ test('Can reset to default', async (done) => {
 
   assertNockRequest(autocompleteScope);
   assertNockRequest(scope);
-  assertNockRequest(contentOverrideScope, done); // Pass jest callback to confirm test is done
+  assertNockRequest(contentOverrideScope);
+  done(); // Pass jest callback to confirm test is done
 });
 
 test('Can override in bulk', async (done) => {
@@ -358,14 +373,17 @@ test('Can override in bulk', async (done) => {
   getByLabelText('Select row 0').click();
   getByLabelText('Select row 1').click();
   const actionMenu = getByLabelText('bulk_actions');
-  actionMenu.click();
+  await act(async () => {
+    fireEvent.click(actionMenu);
+  });
   const resetToDefault = queryByText('Reset to default');
   expect(resetToDefault).toBeInTheDocument();
   resetToDefault.click();
 
   assertNockRequest(autocompleteScope);
   assertNockRequest(scope);
-  assertNockRequest(contentOverrideScope, done); // Pass jest callback to confirm test is done});
+  assertNockRequest(contentOverrideScope);
+  done(); // Pass jest callback to confirm test is done});
 });
 test('Can override in bulk when limited to environment', async (done) => {
   const autocompleteScope = mockAutocomplete(nockInstance, autocompleteUrl);
@@ -391,14 +409,17 @@ test('Can override in bulk when limited to environment', async (done) => {
   await patientlyWaitFor(() => expect(getByText(firstRepoSet.contentUrl)).toBeInTheDocument());
   getByLabelText('Select all').click();
   const actionMenu = getByLabelText('bulk_actions');
-  actionMenu.click();
+  await act(async () => {
+    fireEvent.click(actionMenu);
+  });
   const resetToDefault = queryByText('Reset to default');
   expect(resetToDefault).toBeInTheDocument();
   resetToDefault.click();
 
   assertNockRequest(autocompleteScope);
   assertNockRequest(scope);
-  assertNockRequest(contentOverrideScope, done);
+  assertNockRequest(contentOverrideScope);
+  done();
 });
 
 test('Can filter by status', async (done) => {
@@ -422,7 +443,9 @@ test('Can filter by status', async (done) => {
   const statusContainer = queryByLabelText('select Status container', { ignore: 'th' });
   const statusDropdown = within(statusContainer).queryByText('Status');
   expect(statusDropdown).toBeInTheDocument();
-  fireEvent.click(statusDropdown);
+  await act(async () => {
+    fireEvent.click(statusDropdown);
+  });
   const overridden = getByRole('option', { name: 'select Overridden' });
   fireEvent.click(overridden);
   await patientlyWaitFor(() => {
@@ -430,7 +453,8 @@ test('Can filter by status', async (done) => {
   });
   assertNockRequest(autocompleteScope);
   assertNockRequest(scope);
-  assertNockRequest(scope2, done); // Pass jest callback to confirm test is done
+  assertNockRequest(scope2);
+  done(); // Pass jest callback to confirm test is done
 });
 
 test('Can display restrictions as labels', async (done) => {
@@ -448,5 +472,6 @@ test('Can display restrictions as labels', async (done) => {
   expect(secondRepoSet.archRestricted).not.toBeNull();
   expect(getByText(secondRepoSet.archRestricted)).toBeInTheDocument();
   assertNockRequest(autocompleteScope);
-  assertNockRequest(scope, done); // Pass jest callback to confirm test is done
+  assertNockRequest(scope);
+  done(); // Pass jest callback to confirm test is done
 });