iknow_view_models 3.2.0 → 3.2.1

data/test/unit/view_model/active_record/has_many_through_poly_test.rb

@@ -1,9 +1,11 @@
-require_relative "../../../helpers/arvm_test_utilities.rb"
-require_relative "../../../helpers/arvm_test_models.rb"
+# frozen_string_literal: true
 
-require "minitest/autorun"
+require_relative '../../../helpers/arvm_test_utilities'
+require_relative '../../../helpers/arvm_test_models'
 
-require "view_model/active_record"
+require 'minitest/autorun'
+
+require 'view_model/active_record'
 
 class ViewModel::ActiveRecord::HasManyThroughPolyTest < ActiveSupport::TestCase
   include ARVMTestUtilities
@@ -99,7 +101,7 @@ class ViewModel::ActiveRecord::HasManyThroughPolyTest < ActiveSupport::TestCase
                              parents_tags: [ParentsTag.new(tag: @tag_a1, position: 1.0),
                                             ParentsTag.new(tag: @tag_a2, position: 2.0),
                                             ParentsTag.new(tag: @tag_b1, position: 3.0),
-                                            ParentsTag.new(tag: @tag_b2, position: 4.0)])
+                                            ParentsTag.new(tag: @tag_b2, position: 4.0),])
 
     enable_logging!
   end
@@ -135,7 +137,7 @@ class ViewModel::ActiveRecord::HasManyThroughPolyTest < ActiveSupport::TestCase
   end
 
   def test_preload_dependencies
-    # TODO not part of ARVM; but depends on the particular context from #before_all
+    # TODO: not part of ARVM; but depends on the particular context from #before_all
     # If we refactor out the contexts from their tests, this should go in another test file.
 
     root_updates, _ref_updates = ViewModel::ActiveRecord::UpdateData.parse_hashes([{ '_type' => 'Parent' }])
@@ -145,7 +147,7 @@ class ViewModel::ActiveRecord::HasManyThroughPolyTest < ActiveSupport::TestCase
 
     root_updates, _ref_updates = ViewModel::ActiveRecord::UpdateData.parse_hashes([{ '_type' => 'Parent',
                                                                                   'tags' => [{ '_ref' => 'r1' }] }],
-                                                                               { 'r1' => { '_type' => 'TagB' } })
+                                                                                  { 'r1' => { '_type' => 'TagB' } })
 
     assert_equal(DeepPreloader::Spec.new(
                   'parents_tags' => DeepPreloader::Spec.new(
@@ -154,7 +156,6 @@ class ViewModel::ActiveRecord::HasManyThroughPolyTest < ActiveSupport::TestCase
                  'mentioning tags causes through association loading, excluding shared')
   end
 
-
   def test_serialize
     view, refs = serialize_with_references(ParentView.new(@parent1))
 
@@ -162,7 +163,7 @@ class ViewModel::ActiveRecord::HasManyThroughPolyTest < ActiveSupport::TestCase
     assert_equal([{ 'id' => @tag_a1.id, '_type' => 'TagA', '_version' => 1, 'name' => 'tag A1' },
                   { 'id' => @tag_a2.id, '_type' => 'TagA', '_version' => 1, 'name' => 'tag A2' },
                   { 'id' => @tag_b1.id, '_type' => 'TagB', '_version' => 1, 'name' => 'tag B1' },
-                  { 'id' => @tag_b2.id, '_type' => 'TagB', '_version' => 1, 'name' => 'tag B2' }],
+                  { 'id' => @tag_b2.id, '_type' => 'TagB', '_version' => 1, 'name' => 'tag B2' },],
                  tag_data)
   end
 
@@ -186,7 +187,7 @@ class ViewModel::ActiveRecord::HasManyThroughPolyTest < ActiveSupport::TestCase
   end
 
   def test_reordering_swap_type
-    alter_by_view!(ParentView, @parent1) do |view, refs|
+    alter_by_view!(ParentView, @parent1) do |view, _refs|
       t1, t2, t3, t4 = view['tags']
       view['tags'] = [t3, t2, t1, t4]
     end
@@ -248,16 +249,16 @@ class ViewModel::ActiveRecord::HasManyThroughPolyTest < ActiveSupport::TestCase
     def test_renamed_roundtrip
       context = ParentView.new_serialize_context
       alter_by_view!(ParentView, @parent, serialize_context: context) do |view, refs|
-        assert_equal({refs.keys.first => { 'id'       => @parent.parents_tags.first.tag.id,
+        assert_equal({ refs.keys.first => { 'id' => @parent.parents_tags.first.tag.id,
                                            '_type'    => 'TagA',
                                            '_version' => 1,
-                                           'name'     => 'tag A name' }}, refs)
+                                           'name'     => 'tag A name' } }, refs)
         assert_equal([{ '_ref' => refs.keys.first }],
                      view['something_else'])
 
         refs.clear
-        refs['new'] = {'_type' => 'TagB', 'name' => 'tag B name'}
-        view['something_else'] = [{'_ref' => 'new'}]
+        refs['new'] = { '_type' => 'TagB', 'name' => 'tag B name' }
+        view['something_else'] = [{ '_ref' => 'new' }]
       end
 
       assert_equal('tag B name', @parent.parents_tags.first.tag.name)

data/test/unit/view_model/active_record/has_many_through_test.rb

@@ -1,9 +1,11 @@
-require_relative "../../../helpers/arvm_test_utilities.rb"
-require_relative "../../../helpers/arvm_test_models.rb"
+# frozen_string_literal: true
 
-require "minitest/autorun"
+require_relative '../../../helpers/arvm_test_utilities'
+require_relative '../../../helpers/arvm_test_models'
 
-require "view_model/active_record"
+require 'minitest/autorun'
+
+require 'view_model/active_record'
 
 class ViewModel::ActiveRecord::HasManyThroughTest < ActiveSupport::TestCase
   include ARVMTestUtilities
@@ -78,7 +80,7 @@ class ViewModel::ActiveRecord::HasManyThroughTest < ActiveSupport::TestCase
       define_model do
         belongs_to :parent
         belongs_to :tag
-        # TODO list membership?
+        # TODO: list membership?
       end
 
       no_viewmodel
@@ -100,7 +102,7 @@ class ViewModel::ActiveRecord::HasManyThroughTest < ActiveSupport::TestCase
 
     @parent1 = Parent.create(name: 'p1',
                              parents_tags: [ParentsTag.new(tag: @tag1, position: 1.0),
-                                            ParentsTag.new(tag: @tag2, position: 2.0)])
+                                            ParentsTag.new(tag: @tag2, position: 2.0),])
 
     enable_logging!
   end
@@ -130,7 +132,7 @@ class ViewModel::ActiveRecord::HasManyThroughTest < ActiveSupport::TestCase
   end
 
   def test_preload_dependencies
-    # TODO not part of ARVM; but depends on the particular context from #before_all
+    # TODO: not part of ARVM; but depends on the particular context from #before_all
     # If we refactor out the contexts from their tests, this should go in another test file.
 
     root_updates, _ref_updates = ViewModel::ActiveRecord::UpdateData.parse_hashes([{ '_type' => 'Parent' }])
@@ -153,7 +155,7 @@ class ViewModel::ActiveRecord::HasManyThroughTest < ActiveSupport::TestCase
 
     tag_data = view['tags'].map { |hash| refs[hash['_ref']] }
     assert_equal([{ 'id' => @tag1.id, '_type' => 'Tag', '_version' => 1, 'name' => 'tag1' },
-                  { 'id' => @tag2.id, '_type' => 'Tag', '_version' => 1, 'name' => 'tag2' }],
+                  { 'id' => @tag2.id, '_type' => 'Tag', '_version' => 1, 'name' => 'tag2' },],
                  tag_data)
   end
 
@@ -197,7 +199,7 @@ class ViewModel::ActiveRecord::HasManyThroughTest < ActiveSupport::TestCase
   def test_child_edit_doesnt_editcheck_parent
     # editing child doesn't edit check parent
     pv, d_context = alter_by_view!(ParentView, @parent1) do |view, refs|
-      refs[view['tags'][0]["_ref"]]["name"] = "changed"
+      refs[view['tags'][0]['_ref']]['name'] = 'changed'
     end
 
     nc = pv.tags.detect { |t| t.name == 'changed' }
@@ -259,7 +261,7 @@ class ViewModel::ActiveRecord::HasManyThroughTest < ActiveSupport::TestCase
     fupdate_tags(@parent1) do |tags|
       c1, c2 = tags
       { :fupdate => build_fupdate { append([{ '_ref' => 'new_tag' }]) },
-        :refs    => { 'new_tag' => { '_type' => 'Tag', 'name' => 'new tag' } }
+        :refs    => { 'new_tag' => { '_type' => 'Tag', 'name' => 'new tag' } },
       }
     end
     assert_equal([c1.name, c2.name, 'new tag'],
@@ -272,7 +274,7 @@ class ViewModel::ActiveRecord::HasManyThroughTest < ActiveSupport::TestCase
       c1, c2 = tags
       { :fupdate => build_fupdate { append([{ '_ref' => 'new_tag' }],
                                            before: { '_type' => 'Tag', 'id' => c2.id }) },
-        :refs    => { 'new_tag' => { '_type' => 'Tag', 'name' => 'new tag' } }
+        :refs    => { 'new_tag' => { '_type' => 'Tag', 'name' => 'new tag' } },
       }
     end
     assert_equal([c1.name, 'new tag', c2.name],
@@ -285,7 +287,7 @@ class ViewModel::ActiveRecord::HasManyThroughTest < ActiveSupport::TestCase
       c1, c2 = tags
       { :fupdate => build_fupdate { append([{ '_ref' => 'new_tag' }],
                                            before: { '_type' => 'Tag', 'id' => c1.id }) },
-        :refs    => { 'new_tag' => { '_type' => 'Tag', 'name' => 'new tag' } }
+        :refs    => { 'new_tag' => { '_type' => 'Tag', 'name' => 'new tag' } },
       }
     end
     assert_equal(['new tag', c1.name, c2.name],
@@ -298,21 +300,20 @@ class ViewModel::ActiveRecord::HasManyThroughTest < ActiveSupport::TestCase
       c1, c2 = tags
       { :fupdate => build_fupdate { append([{ '_ref' => 'c2' }],
                                            before: { '_type' => 'Tag', 'id' => c1.id }) },
-        :refs    => { 'c2' => { '_type' => 'Tag', 'id' => c2.id } }
+        :refs    => { 'c2' => { '_type' => 'Tag', 'id' => c2.id } },
       }
     end
     assert_equal([c2.name, c1.name],
                  tags(@parent1).map(&:name))
   end
 
-
   def test_functional_update_append_after_mid
     c1 = c2 = nil
     fupdate_tags(@parent1) do |tags|
       c1, c2 = tags
       { :fupdate => build_fupdate { append([{ '_ref' => 'new_tag' }],
                                            after: { '_type' => 'Tag', 'id' => c1.id }) },
-        :refs    => { 'new_tag' => { '_type' => 'Tag', 'name' => 'new tag' } }
+        :refs    => { 'new_tag' => { '_type' => 'Tag', 'name' => 'new tag' } },
       }
     end
     assert_equal([c1.name, 'new tag', c2.name],
@@ -325,7 +326,7 @@ class ViewModel::ActiveRecord::HasManyThroughTest < ActiveSupport::TestCase
       c1, c2 = tags
       { :fupdate => build_fupdate { append([{ '_ref' => 'new_tag' }],
                                            after: { '_type' => 'Tag', 'id' => c2.id }) },
-        :refs    => { 'new_tag' => { '_type' => 'Tag', 'name' => 'new tag' } }
+        :refs    => { 'new_tag' => { '_type' => 'Tag', 'name' => 'new tag' } },
       }
     end
     assert_equal([c1.name, c2.name, 'new tag'],
@@ -338,7 +339,7 @@ class ViewModel::ActiveRecord::HasManyThroughTest < ActiveSupport::TestCase
       c1, c2 = tags
       { :fupdate => build_fupdate { append([{ '_ref' => 'c1' }],
                                            after: { '_type' => 'Tag', 'id' => c2.id }) },
-        :refs    => { 'c1' => { '_type' => 'Tag', 'id' => c1.id } }
+        :refs    => { 'c1' => { '_type' => 'Tag', 'id' => c1.id } },
       }
     end
     assert_equal([c2.name, c1.name],
@@ -375,7 +376,7 @@ class ViewModel::ActiveRecord::HasManyThroughTest < ActiveSupport::TestCase
         @parent1.parents_tags.where(tag_id: c2.id).destroy_all
         { :fupdate => build_fupdate { append([{ '_ref' => 'new_tag' }],
                                              after: { '_type' => 'Tag', 'id' => c2.id }) },
-          :refs    => { 'new_tag' => { '_type' => 'Tag', 'name' => 'new tag name' } }
+          :refs    => { 'new_tag' => { '_type' => 'Tag', 'name' => 'new tag name' } },
         }
       end
     end
@@ -387,13 +388,12 @@ class ViewModel::ActiveRecord::HasManyThroughTest < ActiveSupport::TestCase
     c1 = c2 = nil
     fupdate_tags(@parent1) do |tags|
       c1, c2 = tags
-      { :fupdate => build_fupdate { update([{ '_ref' => 'c1' }])},
-        :refs    => { 'c1' => { '_type' => 'Tag', 'id' => c1.id, 'name' => 'c1 new name' } }
+      { :fupdate => build_fupdate { update([{ '_ref' => 'c1' }]) },
+        :refs    => { 'c1' => { '_type' => 'Tag', 'id' => c1.id, 'name' => 'c1 new name' } },
       }
     end
     assert_equal(['c1 new name', c2.name],
                  tags(@parent1).map(&:name))
-
   end
 
   def test_functional_update_update_stale
@@ -403,14 +403,13 @@ class ViewModel::ActiveRecord::HasManyThroughTest < ActiveSupport::TestCase
     c2.parents_tags.destroy_all
 
     ex = assert_raises(ViewModel::DeserializationError::AssociatedNotFound) do
-      fupdate_tags(@parent1) do |tags|
-#        @parent1.parents_tags.where(tag_id: c2.id).destroy_all
+      fupdate_tags(@parent1) do |_tags|
         { :fupdate => build_fupdate { update([{ '_ref' => 'c2' }]) },
-          :refs    => { 'c2' => { '_type' => 'Tag', 'id' => c2.id, 'name' => 'c2 new name' } }
+          :refs    => { 'c2' => { '_type' => 'Tag', 'id' => c2.id, 'name' => 'c2 new name' } },
         }
       end
     end
-    assert_equal("tags", ex.association)
+    assert_equal('tags', ex.association)
     assert_equal([ViewModel::Reference.new(TagView, c2.id)], ex.missing_nodes)
   end
 
@@ -442,7 +441,7 @@ class ViewModel::ActiveRecord::HasManyThroughTest < ActiveSupport::TestCase
                                deserialize_context: context)
 
     expected_edit_checks = [pv.to_reference,
-                            *nc.map(&:to_reference)]
+                            *nc.map(&:to_reference),]
 
     assert_contains_exactly(expected_edit_checks,
                             context.valid_edit_refs)
@@ -476,7 +475,7 @@ class ViewModel::ActiveRecord::HasManyThroughTest < ActiveSupport::TestCase
 
     expected_edit_checks = [ViewModel::Reference.new(ParentView, @parent1.id),
                             ViewModel::Reference.new(TagView, @tag1.id),
-                            ViewModel::Reference.new(TagView, new_tag.id)]
+                            ViewModel::Reference.new(TagView, new_tag.id),]
 
     assert_contains_exactly(expected_edit_checks,
                             context.valid_edit_refs)
@@ -518,7 +517,6 @@ class ViewModel::ActiveRecord::HasManyThroughTest < ActiveSupport::TestCase
 
     assert_equal(expected_edit_checks, context.valid_edit_refs.to_set)
 
-
     assert_equal([@tag2, @tag1],
                  tags(@parent1))
 
@@ -536,8 +534,7 @@ class ViewModel::ActiveRecord::HasManyThroughTest < ActiveSupport::TestCase
     # append
     pv.append_associated(:tags,
                          { '_type' => 'Tag', 'id' => @tag1.id },
-                         deserialize_context: (context = ParentView.new_deserialize_context))
-
+                         deserialize_context: ParentView.new_deserialize_context)
 
     assert_equal([@tag2, @tag1],
                  tags(@parent1))
@@ -563,7 +560,7 @@ class ViewModel::ActiveRecord::HasManyThroughTest < ActiveSupport::TestCase
 
     # insert after
     pv.append_associated(:tags,
-                         { '_type' => 'Tag', 'id' =>  @tag3.id },
+                         { '_type' => 'Tag', 'id' => @tag3.id },
                          after: ViewModel::Reference.new(TagView, @tag1.id),
                          deserialize_context: (context = ParentView.new_deserialize_context))
 
@@ -577,8 +574,7 @@ class ViewModel::ActiveRecord::HasManyThroughTest < ActiveSupport::TestCase
     # append
     pv.append_associated(:tags,
                          { '_type' => 'Tag', 'id' => @tag3.id },
-                         deserialize_context: (context = ParentView.new_deserialize_context))
-
+                         deserialize_context: ParentView.new_deserialize_context)
 
     assert_equal([@tag1, @tag2, @tag3],
                  tags(@parent1))
@@ -611,7 +607,6 @@ class ViewModel::ActiveRecord::HasManyThroughTest < ActiveSupport::TestCase
       ViewModel::ActiveRecord::HasManyThroughTest.build_join_table_model(self)
     end
 
-
     def setup
       super
 
@@ -629,16 +624,16 @@ class ViewModel::ActiveRecord::HasManyThroughTest < ActiveSupport::TestCase
     def test_renamed_roundtrip
       context = ParentView.new_serialize_context
       alter_by_view!(ParentView, @parent, serialize_context: context) do |view, refs|
-        assert_equal({refs.keys.first => { 'id'       => @parent.parents_tags.first.tag.id,
+        assert_equal({ refs.keys.first => { 'id' => @parent.parents_tags.first.tag.id,
                                            '_type'    => 'Tag',
                                            '_version' => 1,
-                                           'name'     => 'tag name' }}, refs)
+                                           'name'     => 'tag name' } }, refs)
         assert_equal([{ '_ref' => refs.keys.first }],
                      view['something_else'])
 
         refs.clear
-        refs['new'] = {'_type' => 'Tag', 'name' => 'tag new name'}
-        view['something_else'] = [{'_ref' => 'new'}]
+        refs['new'] = { '_type' => 'Tag', 'name' => 'tag new name' }
+        view['something_else'] = [{ '_ref' => 'new' }]
       end
 
       assert_equal('tag new name', @parent.parents_tags.first.tag.name)

data/test/unit/view_model/active_record/has_one_test.rb

@@ -1,10 +1,12 @@
-require_relative "../../../helpers/arvm_test_utilities.rb"
-require_relative "../../../helpers/arvm_test_models.rb"
-require_relative '../../../helpers/viewmodel_spec_helpers.rb'
+# frozen_string_literal: true
 
-require "minitest/autorun"
+require_relative '../../../helpers/arvm_test_utilities'
+require_relative '../../../helpers/arvm_test_models'
+require_relative '../../../helpers/viewmodel_spec_helpers'
 
-require "view_model/active_record"
+require 'minitest/autorun'
+
+require 'view_model/active_record'
 
 class ViewModel::ActiveRecord::HasOneTest < ActiveSupport::TestCase
   include ARVMTestUtilities
@@ -15,13 +17,13 @@ class ViewModel::ActiveRecord::HasOneTest < ActiveSupport::TestCase
   def setup
     super
 
-    # TODO make a `has_list?` that allows a model to set all children as an array
-    @model1 = model_class.new(name: "p1",
-                          child: child_model_class.new(name: "p1t"))
+    # TODO: make a `has_list?` that allows a model to set all children as an array
+    @model1 = model_class.new(name: 'p1',
+                          child: child_model_class.new(name: 'p1t'))
     @model1.save!
 
-    @model2 = model_class.new(name: "p2",
-                          child: child_model_class.new(name: "p2t"))
+    @model2 = model_class.new(name: 'p2',
+                          child: child_model_class.new(name: 'p2t'))
 
     @model2.save!
 
@@ -38,9 +40,9 @@ class ViewModel::ActiveRecord::HasOneTest < ActiveSupport::TestCase
 
   def test_create_from_view
     view = {
-      "_type"    => "Model",
-      "name"     => "p",
-      "child"   => { "_type" => "Child", "name" => "t" },
+      '_type'    => 'Model',
+      'name'     => 'p',
+      'child' => { '_type' => 'Child', 'name' => 't' },
     }
 
     pv = ModelView.deserialize_from_view(view)
@@ -49,23 +51,22 @@ class ViewModel::ActiveRecord::HasOneTest < ActiveSupport::TestCase
     assert(!p.changed?)
     assert(!p.new_record?)
 
-    assert_equal("p", p.name)
-
+    assert_equal('p', p.name)
 
     assert(p.child.present?)
-    assert_equal("t", p.child.name)
+    assert_equal('t', p.child.name)
   end
 
   def test_serialize_view
     view, _refs = serialize_with_references(ModelView.new(@model1))
-    assert_equal({ "_type"    => "Model",
-                   "_version" => 1,
-                   "id"       => @model1.id,
-                   "name"     => @model1.name,
-                   "child"   => { "_type"    => "Child",
-                                   "_version" => 1,
-                                   "id"       => @model1.child.id,
-                                   "name"     => @model1.child.name } },
+    assert_equal({ '_type'    => 'Model',
+                   '_version' => 1,
+                   'id'       => @model1.id,
+                   'name'     => @model1.name,
+                   'child' => { '_type' => 'Child',
+                                   '_version' => 1,
+                                   'id'       => @model1.child.id,
+                                   'name'     => @model1.child.name } },
                  view)
   end
 
@@ -77,11 +78,11 @@ class ViewModel::ActiveRecord::HasOneTest < ActiveSupport::TestCase
 
     ModelView.deserialize_from_view(
       [update_hash_for(ModelView, @model1) { |p| p['child'] = update_hash_for(ChildView, t2) },
-       update_hash_for(ModelView, @model2) { |p| p['child'] = update_hash_for(ChildView, t1) }],
+       update_hash_for(ModelView, @model2) { |p| p['child'] = update_hash_for(ChildView, t1) },],
       deserialize_context: deserialize_context)
 
     assert_equal(Set.new([ViewModel::Reference.new(ModelView, @model1.id),
-                          ViewModel::Reference.new(ModelView, @model2.id)]),
+                          ViewModel::Reference.new(ModelView, @model2.id),]),
                  deserialize_context.valid_edit_refs.to_set)
 
     @model1.reload
@@ -100,7 +101,7 @@ class ViewModel::ActiveRecord::HasOneTest < ActiveSupport::TestCase
   def test_has_one_create
     @model1.update(child: nil)
 
-    alter_by_view!(ModelView, @model1) do |view, refs|
+    alter_by_view!(ModelView, @model1) do |view, _refs|
       view['child'] = { '_type' => 'Child', 'name' => 't' }
     end
 
@@ -108,8 +109,8 @@ class ViewModel::ActiveRecord::HasOneTest < ActiveSupport::TestCase
   end
 
   def test_has_one_update
-    alter_by_view!(ModelView, @model1) do |view, refs|
-      view['child']['name'] = "hello"
+    alter_by_view!(ModelView, @model1) do |view, _refs|
+      view['child']['name'] = 'hello'
     end
 
     assert_equal('hello', @model1.child.name)
@@ -117,7 +118,7 @@ class ViewModel::ActiveRecord::HasOneTest < ActiveSupport::TestCase
 
   def test_has_one_destroy
     old_child = @model1.child
-    alter_by_view!(ModelView, @model1) do |view, refs|
+    alter_by_view!(ModelView, @model1) do |view, _refs|
       view['child'] = nil
     end
     assert(Child.where(id: old_child.id).blank?)
@@ -127,7 +128,7 @@ class ViewModel::ActiveRecord::HasOneTest < ActiveSupport::TestCase
     old_model1_child = @model1.child
     old_model2_child = @model2.child
 
-    alter_by_view!(ModelView, [@model1, @model2]) do |(p1, p2), refs|
+    alter_by_view!(ModelView, [@model1, @model2]) do |(p1, p2), _refs|
       p2['child'] = p1['child']
       p1['child'] = nil
     end
@@ -179,8 +180,8 @@ class ViewModel::ActiveRecord::HasOneTest < ActiveSupport::TestCase
 
   def test_bad_single_association
     view = {
-      "_type" => "Model",
-      "child" => []
+      '_type' => 'Model',
+      'child' => [],
     }
     ex = assert_raises(ViewModel::DeserializationError::InvalidSyntax) do
       ModelView.deserialize_from_view(view)
@@ -190,7 +191,7 @@ class ViewModel::ActiveRecord::HasOneTest < ActiveSupport::TestCase
 
   describe 'owned reference child' do
     def child_attributes
-      super.merge(viewmodel: ->(v) { root! })
+      super.merge(viewmodel: ->(_v) { root! })
     end
 
     def new_model
@@ -419,7 +420,7 @@ class ViewModel::ActiveRecord::HasOneTest < ActiveSupport::TestCase
     end
 
     def test_renamed_roundtrip
-      alter_by_view!(ModelView, @model) do |view, refs|
+      alter_by_view!(ModelView, @model) do |view, _refs|
         assert_equal({ 'id'       => @model.child.id,
                        '_type'    => 'Child',
                        '_version' => 1,
@@ -428,7 +429,7 @@ class ViewModel::ActiveRecord::HasOneTest < ActiveSupport::TestCase
         view['something_else']['name'] = 'child new name'
       end
 
-      assert_equal('child new name',  @model.child.name)
+      assert_equal('child new name', @model.child.name)
     end
   end