iknow_view_models 3.2.0 → 3.2.1

data/test/unit/view_model/active_record/controller_test.rb

@@ -1,14 +1,14 @@
-# -*- coding: utf-8 -*-
+# frozen_string_literal: true
 
-require "minitest/autorun"
+require 'minitest/autorun'
 require 'minitest/unit'
 require 'minitest/hooks'
 
-require "view_model"
-require "view_model/active_record"
+require 'view_model'
+require 'view_model/active_record'
 
-require_relative "../../../helpers/controller_test_helpers.rb"
-require_relative "../../../helpers/callback_tracer.rb"
+require_relative '../../../helpers/controller_test_helpers'
+require_relative '../../../helpers/callback_tracer'
 
 class ViewModel::ActiveRecord::ControllerTest < ActiveSupport::TestCase
   include ARVMTestUtilities
@@ -88,7 +88,7 @@ class ViewModel::ActiveRecord::ControllerTest < ActiveSupport::TestCase
     super
     @parent = Parent.create(name: 'p',
                             children: [Child.new(name: 'c1', position: 1.0),
-                                       Child.new(name: 'c2', position: 2.0)],
+                                       Child.new(name: 'c2', position: 2.0),],
                             label: Label.new,
                             target: Target.new)
 
@@ -128,7 +128,7 @@ class ViewModel::ActiveRecord::ControllerTest < ActiveSupport::TestCase
   end
 
   def test_index
-    p2      = Parent.create(name: "p2")
+    p2      = Parent.create(name: 'p2')
     p2_view = ParentView.new(p2)
 
     parentcontroller = ParentController.new
@@ -137,7 +137,7 @@ class ViewModel::ActiveRecord::ControllerTest < ActiveSupport::TestCase
     assert_equal(200, parentcontroller.status)
 
     assert_equal(parentcontroller.hash_response,
-                 { "data" => [@parent_view.to_hash, p2_view.to_hash] })
+                 { 'data' => [@parent_view.to_hash, p2_view.to_hash] })
 
     assert_all_hooks_nested_inside_parent_hook(parentcontroller.hook_trace)
   end
@@ -149,7 +149,7 @@ class ViewModel::ActiveRecord::ControllerTest < ActiveSupport::TestCase
         'label'    => { '_type' => 'Label', 'text' => 'l' },
         'target'   => { '_type' => 'Target', 'text' => 't' },
         'children' => [{ '_type' => 'Child', 'name' => 'c1' },
-                       { '_type' => 'Child', 'name' => 'c2' }]
+                       { '_type' => 'Child', 'name' => 'c2' },],
     }
 
     parentcontroller = ParentController.new(data: data)
@@ -240,10 +240,10 @@ class ViewModel::ActiveRecord::ControllerTest < ActiveSupport::TestCase
                      'status' => 404,
                      'detail' => "Couldn't find Parent(s) with id(s)=[9999]",
                      'title' => nil,
-                     'code'   => "DeserializationError.NotFound",
-                     'meta' => { 'nodes' => [{ '_type' => "Parent", 'id' => 9999 }]},
+                     'code' => 'DeserializationError.NotFound',
+                     'meta' => { 'nodes' => [{ '_type' => 'Parent', 'id' => 9999 }] },
                      'exception' => nil,
-                     'causes' => nil }},
+                     'causes' => nil } },
                  parentcontroller.hash_response)
   end
 
@@ -261,13 +261,13 @@ class ViewModel::ActiveRecord::ControllerTest < ActiveSupport::TestCase
                      'status' => 400,
                      'detail' => 'Validation failed: \'age\' must be less than 42',
                      'title' => nil,
-                     'code'   => "DeserializationError.Validation",
-                     'meta' => { 'nodes' => [{ '_type' => "Child", 'id' => nil }],
+                     'code' => 'DeserializationError.Validation',
+                     'meta' => { 'nodes' => [{ '_type' => 'Child', 'id' => nil }],
                                  'attribute' => 'age',
                                  'message' => 'must be less than 42',
-                                 'details' => { 'error' => 'less_than', 'value' => 42, 'count' => 42 }},
+                                 'details' => { 'error' => 'less_than', 'value' => 42, 'count' => 42 } },
                      'exception' => nil,
-                     'causes' => nil }},
+                     'causes' => nil } },
                  parentcontroller.hash_response)
   end
 
@@ -279,9 +279,9 @@ class ViewModel::ActiveRecord::ControllerTest < ActiveSupport::TestCase
     parentcontroller.invoke(:create)
 
     assert_equal(400, parentcontroller.status)
-    assert_match(%r{check constraint}i,
-                 parentcontroller.hash_response["error"]["detail"],
-                 "Database error propagated")
+    assert_match(/check constraint/i,
+                 parentcontroller.hash_response['error']['detail'],
+                 'Database error propagated')
   end
 
   def test_destroy_missing
@@ -294,8 +294,8 @@ class ViewModel::ActiveRecord::ControllerTest < ActiveSupport::TestCase
                      'status' => 404,
                      'detail' => "Couldn't find Parent(s) with id(s)=[9999]",
                      'title' => nil,
-                     'code'   => "DeserializationError.NotFound",
-                     'meta' => { "nodes" => [{"_type" => "Parent", "id" => 9999 }] },
+                     'code' => 'DeserializationError.NotFound',
+                     'meta' => { 'nodes' => [{ '_type' => 'Parent', 'id' => 9999 }] },
                      'exception' => nil,
                      'causes' => nil } },
                  parentcontroller.hash_response)
@@ -342,7 +342,7 @@ class ViewModel::ActiveRecord::ControllerTest < ActiveSupport::TestCase
 
     @parent.reload
 
-    assert_equal(%w{c1 c2 c3}, @parent.children.order(:position).pluck(:name))
+    assert_equal(%w[c1 c2 c3], @parent.children.order(:position).pluck(:name))
     assert_equal({ 'data' => ChildView.new(@parent.children.last).to_hash },
                  childcontroller.hash_response)
 
@@ -351,7 +351,7 @@ class ViewModel::ActiveRecord::ControllerTest < ActiveSupport::TestCase
 
   def test_nested_collection_append_many
     data = [{ '_type' => 'Child', 'name' => 'c3' },
-            { '_type' => 'Child', 'name' => 'c4' }]
+            { '_type' => 'Child', 'name' => 'c4' },]
 
     childcontroller = ChildController.new(parent_id: @parent.id, data: data)
     childcontroller.invoke(:append)
@@ -360,8 +360,8 @@ class ViewModel::ActiveRecord::ControllerTest < ActiveSupport::TestCase
 
     @parent.reload
 
-    assert_equal(%w{c1 c2 c3 c4}, @parent.children.order(:position).pluck(:name))
-    new_children_hashes = @parent.children.last(2).map{ |c| ChildView.new(c).to_hash }
+    assert_equal(%w[c1 c2 c3 c4], @parent.children.order(:position).pluck(:name))
+    new_children_hashes = @parent.children.last(2).map { |c| ChildView.new(c).to_hash }
     assert_equal({ 'data' => new_children_hashes },
                  childcontroller.hash_response)
 
@@ -373,8 +373,8 @@ class ViewModel::ActiveRecord::ControllerTest < ActiveSupport::TestCase
     # Parent.children
     old_children = @parent.children
 
-    data = [{'_type' => 'Child', 'name' => 'newc1'},
-            {'_type' => 'Child', 'name' => 'newc2'}]
+    data = [{ '_type' => 'Child', 'name' => 'newc1' },
+            { '_type' => 'Child', 'name' => 'newc2' },]
 
     childcontroller = ChildController.new(parent_id: @parent.id, data: data)
     childcontroller.invoke(:replace)
@@ -383,14 +383,14 @@ class ViewModel::ActiveRecord::ControllerTest < ActiveSupport::TestCase
 
     @parent.reload
 
-    assert_equal(%w{newc1 newc2}, @parent.children.order(:position).pluck(:name))
+    assert_equal(%w[newc1 newc2], @parent.children.order(:position).pluck(:name))
     assert_predicate(Child.where(id: old_children.map(&:id)), :empty?)
 
     assert_all_hooks_nested_inside_parent_hook(childcontroller.hook_trace)
   end
 
   def test_nested_collection_replace_bad_data
-    data = [{ "name" => "nc" }]
+    data = [{ 'name' => 'nc' }]
     childcontroller = ChildController.new(parent_id: @parent.id, data: data)
 
     childcontroller.invoke(:replace)
@@ -409,7 +409,7 @@ class ViewModel::ActiveRecord::ControllerTest < ActiveSupport::TestCase
 
     @parent.reload
 
-    assert_equal(%w{c2}, @parent.children.order(:position).pluck(:name))
+    assert_equal(%w[c2], @parent.children.order(:position).pluck(:name))
     assert_predicate(Child.where(id: old_child.id), :empty?)
 
     assert_all_hooks_nested_inside_parent_hook(childcontroller.hook_trace)
@@ -441,7 +441,7 @@ class ViewModel::ActiveRecord::ControllerTest < ActiveSupport::TestCase
 
     @parent.reload
 
-    assert_equal(%w{c2}, @parent.children.order(:position).pluck(:name))
+    assert_equal(%w[c2], @parent.children.order(:position).pluck(:name))
     assert_predicate(Child.where(id: old_child.id), :empty?)
   end
 
@@ -464,7 +464,7 @@ class ViewModel::ActiveRecord::ControllerTest < ActiveSupport::TestCase
                  childcontroller.hash_response)
   end
 
-   def test_nested_collection_show
+  def test_nested_collection_show
     old_child = @parent.children.first
 
     childcontroller = ChildController.new(id: old_child.id)
@@ -474,15 +474,14 @@ class ViewModel::ActiveRecord::ControllerTest < ActiveSupport::TestCase
                  childcontroller.hash_response)
 
     assert_equal(200, childcontroller.status)
-   end
-
+  end
 
   ## Single association
 
   def test_nested_singular_replace_from_parent
     old_label = @parent.label
 
-    data = {'_type' => 'Label', 'text' => 'new label'}
+    data = { '_type' => 'Label', 'text' => 'new label' }
     labelcontroller = LabelController.new(parent_id: @parent.id, data: data)
     labelcontroller.invoke(:create_associated)
 
@@ -536,7 +535,7 @@ class ViewModel::ActiveRecord::ControllerTest < ActiveSupport::TestCase
   def test_nested_singular_update_from_parent
     old_label = @parent.label
 
-    data = {'_type' => 'Label', 'id' => old_label.id, 'text' => 'new label'}
+    data = { '_type' => 'Label', 'id' => old_label.id, 'text' => 'new label' }
     labelcontroller = LabelController.new(parent_id: @parent.id, data: data)
     labelcontroller.invoke(:create_associated)
 
@@ -583,7 +582,7 @@ class ViewModel::ActiveRecord::ControllerTest < ActiveSupport::TestCase
   def test_nested_singular_update
     old_label = @parent.label
 
-    data = {'_type' => 'Label', 'id' => old_label.id, 'text' => 'new label'}
+    data = { '_type' => 'Label', 'id' => old_label.id, 'text' => 'new label' }
     labelcontroller = LabelController.new(data: data)
     labelcontroller.invoke(:create)
 

data/test/unit/view_model/active_record/counter_test.rb

@@ -1,9 +1,11 @@
-require_relative "../../../helpers/arvm_test_utilities.rb"
-require_relative "../../../helpers/arvm_test_models.rb"
+# frozen_string_literal: true
 
-require "minitest/autorun"
+require_relative '../../../helpers/arvm_test_utilities'
+require_relative '../../../helpers/arvm_test_models'
 
-require "view_model/active_record"
+require 'minitest/autorun'
+
+require 'view_model/active_record'
 
 class ViewModel::ActiveRecord::CounterTest < ActiveSupport::TestCase
   include ARVMTestUtilities
@@ -40,7 +42,6 @@ class ViewModel::ActiveRecord::CounterTest < ActiveSupport::TestCase
         attribute :name
       end
     end
-
   end
 
   def setup
@@ -50,15 +51,15 @@ class ViewModel::ActiveRecord::CounterTest < ActiveSupport::TestCase
   end
 
   def test_counter_cache_create
-    alter_by_view!(CategoryView, @category1) do |view, refs|
-      view['products'] << {'_type' => 'Product'}
+    alter_by_view!(CategoryView, @category1) do |view, _refs|
+      view['products'] << { '_type' => 'Product' }
     end
     assert_equal(2, @category1.products_count)
   end
 
   def test_counter_cache_move
     @category2 = Category.create(name: 'c2')
-    alter_by_view!(CategoryView, [@category1, @category2]) do |(c1view, c2view), refs|
+    alter_by_view!(CategoryView, [@category1, @category2]) do |(c1view, c2view), _refs|
       c2view['products'] = c1view['products']
       c1view['products'] = []
     end
@@ -67,7 +68,7 @@ class ViewModel::ActiveRecord::CounterTest < ActiveSupport::TestCase
   end
 
   def test_counter_cache_delete
-    alter_by_view!(CategoryView, @category1) do |view, refs|
+    alter_by_view!(CategoryView, @category1) do |view, _refs|
       view['products'] = []
     end
     assert_equal(0, @category1.products_count)

data/test/unit/view_model/active_record/customization_test.rb

@@ -1,11 +1,11 @@
-# coding: utf-8
-require_relative "../../../helpers/arvm_test_utilities.rb"
-require_relative "../../../helpers/arvm_test_models.rb"
+# frozen_string_literal: true
 
-require "minitest/autorun"
+require_relative '../../../helpers/arvm_test_utilities'
+require_relative '../../../helpers/arvm_test_models'
 
-require "view_model/active_record"
+require 'minitest/autorun'
 
+require 'view_model/active_record'
 
 require 'renum'
 
@@ -28,15 +28,16 @@ class ViewModel::ActiveRecord::SpecializeAssociationTest < ActiveSupport::TestCa
         attributes :text
         association :translations
 
-        def self.pre_parse_translations(viewmodel_reference, metadata, hash, translations)
-          raise "type check" unless translations.is_a?(Hash) && translations.all? { |k, v| k.is_a?(String) && v.is_a?(String) }
-          hash["translations"] = translations.map { |lang, text| { "_type" => "Translation", "language" => lang, "translation" => text } }
+        def self.pre_parse_translations(_viewmodel_reference, _metadata, hash, translations)
+          raise 'type check' unless translations.is_a?(Hash) && translations.all? { |k, v| k.is_a?(String) && v.is_a?(String) }
+
+          hash['translations'] = translations.map { |lang, text| { '_type' => 'Translation', 'language' => lang, 'translation' => text } }
         end
 
         def resolve_translations(update_datas, previous_translation_views)
           existing = previous_translation_views.index_by { |x| [x.model.language, x.model.translation] }
           update_datas.map do |update_data|
-            existing.fetch([update_data["language"], update_data["translation"]]) { TranslationView.for_new_model }
+            existing.fetch([update_data['language'], update_data['translation']]) { TranslationView.for_new_model }
           end
         end
 
@@ -71,19 +72,19 @@ class ViewModel::ActiveRecord::SpecializeAssociationTest < ActiveSupport::TestCa
   def setup
     super
 
-    @text1 = Text.create(text: "dog",
-                    translations: [Translation.new(language: "ja", translation: "犬"),
-                                   Translation.new(language: "fr", translation: "chien")])
+    @text1 = Text.create(text: 'dog',
+                    translations: [Translation.new(language: 'ja', translation: '犬'),
+                                   Translation.new(language: 'fr', translation: 'chien'),])
 
     @text1_view = {
-      "id"           => @text1.id,
-      "_type"        => "Text",
-      "_version"     => 1,
-      "text"         => "dog",
-      "translations" => {
-        "ja" => "犬",
-        "fr" => "chien"
-      }
+      'id'           => @text1.id,
+      '_type'        => 'Text',
+      '_version'     => 1,
+      'text'         => 'dog',
+      'translations' => {
+        'ja' => '犬',
+        'fr' => 'chien',
+      },
     }
 
     enable_logging!
@@ -94,7 +95,7 @@ class ViewModel::ActiveRecord::SpecializeAssociationTest < ActiveSupport::TestCa
   end
 
   def test_create
-    create_view = @text1_view.dup.tap {|v| v.delete('id')}
+    create_view = @text1_view.dup.tap { |v| v.delete('id') }
     new_text_view = TextView.deserialize_from_view(create_view)
     new_text_model = new_text_view.model
 
@@ -103,8 +104,8 @@ class ViewModel::ActiveRecord::SpecializeAssociationTest < ActiveSupport::TestCa
     new_translations = new_text_model.translations.map do |x|
       [x['language'], x['translation']]
     end
-    assert_equal([%w(fr chien),
-                  %w(ja 犬)],
+    assert_equal([%w[fr chien],
+                  %w[ja 犬],],
                  new_translations.sort)
   end
 
@@ -163,10 +164,11 @@ class ViewModel::ActiveRecord::FlattenAssociationTest < ActiveSupport::TestCase
       def construct_hash(members)
         case self
         when SectionType::Simple
-          raise "nopes" if members.present?
+          raise 'nopes' if members.present?
+
           nil
         else
-          members.merge("_type" => viewmodel.view_name)
+          members.merge('_type' => viewmodel.view_name)
         end
       end
 
@@ -219,7 +221,7 @@ class ViewModel::ActiveRecord::FlattenAssociationTest < ActiveSupport::TestCase
           section_type = SectionType.with_name(section_type_name)
           raise "Invalid section type: #{section_type_name.inspect}" unless section_type
 
-          user_data["section_data"] = section_type.construct_hash(user_data.slice!(*self._members.keys))
+          user_data['section_data'] = section_type.construct_hash(user_data.slice!(*self._members.keys))
         end
 
         def resolve_section_data(update_data, previous_translation_view)
@@ -242,39 +244,38 @@ class ViewModel::ActiveRecord::FlattenAssociationTest < ActiveSupport::TestCase
         end
       end
     end
-
   end
 
   def setup
     super
 
-    @simplesection = Section.create(name: "simple1")
+    @simplesection = Section.create(name: 'simple1')
     @simplesection_view = {
-      "id"           => @simplesection.id,
-      "_type"        => "Section",
-      "_version"     => 1,
-      "section_type" => "Simple",
-      "name"         => "simple1"
+      'id'           => @simplesection.id,
+      '_type'        => 'Section',
+      '_version'     => 1,
+      'section_type' => 'Simple',
+      'name'         => 'simple1',
     }
 
-    @quizsection = Section.create(name: "quiz1", section_data: QuizSection.new(quiz_name: "qq"))
+    @quizsection = Section.create(name: 'quiz1', section_data: QuizSection.new(quiz_name: 'qq'))
     @quizsection_view = {
-      "id"           => @quizsection.id,
-      "_type"        => "Section",
-      "_version"     => 1,
-      "section_type" => "Quiz",
-      "name"         => "quiz1",
-      "quiz_name"    => "qq"
+      'id'           => @quizsection.id,
+      '_type'        => 'Section',
+      '_version'     => 1,
+      'section_type' => 'Quiz',
+      'name'         => 'quiz1',
+      'quiz_name'    => 'qq',
     }
 
-    @vocabsection = Section.create(name: "vocab1", section_data: VocabSection.new(vocab_word: "dog"))
+    @vocabsection = Section.create(name: 'vocab1', section_data: VocabSection.new(vocab_word: 'dog'))
     @vocabsection_view = {
-      "id"           => @vocabsection.id,
-      "_type"        => "Section",
-      "_version"     => 1,
-      "section_type" => "Vocab",
-      "name"         => "vocab1",
-      "vocab_word"   => "dog"
+      'id'           => @vocabsection.id,
+      '_type'        => 'Section',
+      '_version'     => 1,
+      'section_type' => 'Vocab',
+      'name'         => 'vocab1',
+      'vocab_word'   => 'dog',
     }
 
     enable_logging!
@@ -296,7 +297,7 @@ class ViewModel::ActiveRecord::FlattenAssociationTest < ActiveSupport::TestCase
   end
 
   def test_create
-    assert_section = ->(model, name, &check_section){
+    assert_section = ->(model, name, &check_section) {
       assert(!model.changed?)
       assert(!model.new_record?)
       assert_equal(name, model.name)
@@ -313,18 +314,18 @@ class ViewModel::ActiveRecord::FlattenAssociationTest < ActiveSupport::TestCase
     }
 
     v = SectionView.deserialize_from_view(new_view_like(@simplesection_view))
-    assert_section.call(v.model, "simple1")
+    assert_section.call(v.model, 'simple1')
 
     v = SectionView.deserialize_from_view(new_view_like(@quizsection_view))
-    assert_section.call(v.model, "quiz1") do |m|
+    assert_section.call(v.model, 'quiz1') do |m|
       assert(m.is_a?(QuizSection))
-      assert_equal("qq", m.quiz_name)
+      assert_equal('qq', m.quiz_name)
     end
 
     v = SectionView.deserialize_from_view(new_view_like(@vocabsection_view))
-    assert_section.call(v.model, "vocab1") do |m|
+    assert_section.call(v.model, 'vocab1') do |m|
       assert(m.is_a?(VocabSection))
-      assert_equal("dog", m.vocab_word)
+      assert_equal('dog', m.vocab_word)
     end
   end
 
@@ -363,15 +364,15 @@ class ViewModel::ActiveRecord::FlattenAssociationTest < ActiveSupport::TestCase
     def setup
       super
       sections = [
-        Section.new(name: "simple1"),
-        Section.new(name: "quiz1", section_data: QuizSection.new(quiz_name: "qq")),
-        Section.new(name: "vocab1", section_data: VocabSection.new(vocab_word: "dog")),
+        Section.new(name: 'simple1'),
+        Section.new(name: 'quiz1', section_data: QuizSection.new(quiz_name: 'qq')),
+        Section.new(name: 'vocab1', section_data: VocabSection.new(vocab_word: 'dog')),
       ]
       @exercise1 = Exercise.create(sections: sections)
     end
 
     def test_functional_update
-      alter_by_view!(ExerciseView, @exercise1) do |view, refs|
+      alter_by_view!(ExerciseView, @exercise1) do |view, _refs|
         view['sections'] = {
           '_type'   => '_update',
           'actions' => [{ '_type'  => 'append',
@@ -380,7 +381,7 @@ class ViewModel::ActiveRecord::FlattenAssociationTest < ActiveSupport::TestCase
                                          'name'         => 'vocab_new',
                                          'vocab_word'   => 'cat',
                                        }],
-                        }]
+                        }],
         }
       end
     end