iknow_view_models 3.2.0 → 3.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 8031b0e3cf50931cfdc65ee1c530efc4210566f2951ab5d6187f80d75848ac2a
-  data.tar.gz: bad21c087fff5def9362bd93576e0f9f0aeb8ec8ddc4f5ff6eb6849e879168c7
+  metadata.gz: 2fa0ab7a6ce71bd40dbb00eea4f73c33a1c3f442ccf349626154c6bf2974088e
+  data.tar.gz: 298c6f0483d477bf48f849ad380c9b7bd6eb7d4a55763ba10d1639c2d2181103
 SHA512:
-  metadata.gz: 17edcc7ab94fa8fa3a9b34e209a3d2feebb1c31fc1d3d619c36d3d9f602312e9ff13c1e0bc0974c2df070084b8b3fa7de3a2f7c74c38a3dbd04976ee166854aa
-  data.tar.gz: e176a0df288c029bea2d083c03492b6a5370e78a4c35164eaadf284b66de9120dfe60eda3dc6bca5e2845b71a865f4996fd17124462d06a70156249fd709a066
+  metadata.gz: 54c754abf844d1a4a62124df1476c3870f487b56de1108acabdb0b57acca108581817df170c318cd9d8edd0930314286d498a3d1ba9e8b68ae87a928dbfa73e9
+  data.tar.gz: 905754efd90b6176b5f7271b1cd997df974ac35dde9afdbaa7612e4a5ec722c942b1021fb565e693efac6df30aa67205d39b6adc9ba3fa64d0db401ce99d7915

data/.rubocop.yml

@@ -1,5 +1,18 @@
 AllCops:
   TargetRubyVersion: 2.7
+  Exclude:
+    - Appraisals
+    - Gemfile
+    - Rakefile
+    - 'gemfiles/*'
+    - 'nix/gem/**/*'
 
 inherit_gem:
   rubocop-iknow: rubocop.yml
+
+Metrics/BlockNesting:
+  Enabled: false
+Lint/IneffectiveAccessModifier:
+  Enabled: false
+Lint/UselessAccessModifier:
+  Enabled: false

data/Appraisals

@@ -1,9 +1,9 @@
-appraise "rails-5-2" do
-  gem "activerecord", "~> 5.2.0"
-  gem "activesupport", "~> 5.2.0"
+appraise 'rails-5-2' do
+  gem 'activerecord', '~> 5.2.0'
+  gem 'activesupport', '~> 5.2.0'
 end
 
-appraise "rails-6-0" do
-  gem "activerecord", "~> 6.0.0"
-  gem "activesupport", "~> 6.0.0"
+appraise 'rails-6-0' do
+  gem 'activerecord', '~> 6.0.0'
+  gem 'activesupport', '~> 6.0.0'
 end

data/Rakefile

@@ -1,5 +1,5 @@
-require "bundler/gem_tasks"
-require "rake/testtask"
+require 'bundler/gem_tasks'
+require 'rake/testtask'
 
 Rake::TestTask.new do |t|
   t.libs << 'test'
@@ -8,14 +8,14 @@ Rake::TestTask.new do |t|
   t.verbose = true
 end
 
-desc "Open an IRB console with the test helpers"
+desc 'Open an IRB console with the test helpers'
 task :test_console do
   ruby %{-r bundler/setup -Ilib -e 'load "test/helpers/arvm_test_models.rb"' -r irb -e 'IRB.start(__FILE__)'}
 end
 
-desc "Open a Pry console with the test helpers"
+desc 'Open a Pry console with the test helpers'
 task 'test_console:pry' do
-  ruby %{-r bundler/setup -Ilib  -e 'load "test/helpers/arvm_test_models.rb"' -r pry -e 'Pry.start'}
+  ruby %(-r bundler/setup -Ilib  -e 'load "test/helpers/arvm_test_models.rb"' -r pry -e 'Pry.start')
 end
 
 task :default => :test

data/gemfiles/rails_5_2.gemfile

@@ -1,9 +1,9 @@
 # This file was generated by Appraisal
 
-source "https://rubygems.org"
+source 'https://rubygems.org'
 
-gem "minitest-ci"
-gem "activerecord", "~> 5.2.0"
-gem "activesupport", "~> 5.2.0"
+gem 'minitest-ci'
+gem 'activerecord', '~> 5.2.0'
+gem 'activesupport', '~> 5.2.0'
 
-gemspec path: "../"
+gemspec path: '../'

data/gemfiles/rails_6_0.gemfile

@@ -1,9 +1,9 @@
 # This file was generated by Appraisal
 
-source "https://rubygems.org"
+source 'https://rubygems.org'
 
-gem "minitest-ci"
-gem "activerecord", "~> 6.0.0"
-gem "activesupport", "~> 6.0.0"
+gem 'minitest-ci'
+gem 'activerecord', '~> 6.0.0'
+gem 'activesupport', '~> 6.0.0'
 
-gemspec path: "../"
+gemspec path: '../'

data/iknow_view_models.gemspec

@@ -1,51 +1,52 @@
 # frozen_string_literal: true
-# coding: utf-8
 
-lib = File.expand_path('../lib', __FILE__)
+lib = File.expand_path('lib', __dir__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require 'iknow_view_models/version'
 
 Gem::Specification.new do |spec|
-  spec.name          = "iknow_view_models"
+  spec.name          = 'iknow_view_models'
   spec.version       = IknowViewModels::VERSION
-  spec.authors       = ["iKnow Team"]
-  spec.email         = ["edge@iknow.jp"]
-  spec.summary       = "ViewModels provide a means of encapsulating a collection of related data and specifying its JSON serialization."
-  spec.description   = ""
-  spec.homepage      = "https://github.com/iknow/cerego_view_models"
-  spec.license       = "MIT"
+  spec.authors       = ['iKnow Team']
+  spec.email         = ['edge@iknow.jp']
+  spec.summary       = 'ViewModels provide a means of encapsulating a collection of related data and specifying its JSON serialization.'
+  spec.description   = ''
+  spec.homepage      = 'https://github.com/iknow/cerego_view_models'
+  spec.license       = 'MIT'
 
   spec.files         = `git ls-files -z`.split("\x0")
   spec.executables   = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
-  spec.require_paths = ["lib"]
-
-  spec.add_dependency "activerecord", ">= 5.0"
-  spec.add_dependency "activesupport", ">= 5.0"
-
-  spec.add_dependency "acts_as_manual_list"
-  spec.add_dependency "deep_preloader", ">= 1.0.1"
-  spec.add_dependency "iknow_cache"
-  spec.add_dependency "iknow_params", "~> 2.2.0"
-  spec.add_dependency "safe_values"
-  spec.add_dependency "keyword_builder"
-
-  spec.add_dependency "concurrent-ruby"
-  spec.add_dependency "jbuilder"
-  spec.add_dependency "json_schema"
-  spec.add_dependency "lazily"
-  spec.add_dependency "renum"
-  spec.add_dependency "oj"
-  spec.add_dependency "rgl"
-
-  spec.add_development_dependency "appraisal"
-  spec.add_development_dependency "bundler"
-  spec.add_development_dependency "byebug"
-  spec.add_development_dependency "method_source"
-  spec.add_development_dependency "minitest-hooks"
-  spec.add_development_dependency "pg"
-  spec.add_development_dependency "pry"
-  spec.add_development_dependency "rake"
-  spec.add_development_dependency "rspec-expectations"
-  spec.add_development_dependency "sqlite3"
+  spec.require_paths = ['lib']
+
+  spec.required_ruby_version = 2.6
+
+  spec.add_dependency 'activerecord', '>= 5.0'
+  spec.add_dependency 'activesupport', '>= 5.0'
+
+  spec.add_dependency 'acts_as_manual_list'
+  spec.add_dependency 'deep_preloader', '>= 1.0.1'
+  spec.add_dependency 'iknow_cache'
+  spec.add_dependency 'iknow_params', '~> 2.2.0'
+  spec.add_dependency 'keyword_builder'
+  spec.add_dependency 'safe_values'
+
+  spec.add_dependency 'concurrent-ruby'
+  spec.add_dependency 'jbuilder'
+  spec.add_dependency 'json_schema'
+  spec.add_dependency 'lazily'
+  spec.add_dependency 'oj'
+  spec.add_dependency 'renum'
+  spec.add_dependency 'rgl'
+
+  spec.add_development_dependency 'appraisal'
+  spec.add_development_dependency 'bundler'
+  spec.add_development_dependency 'byebug'
+  spec.add_development_dependency 'method_source'
+  spec.add_development_dependency 'minitest-hooks'
+  spec.add_development_dependency 'pg'
+  spec.add_development_dependency 'pry'
+  spec.add_development_dependency 'rake'
+  spec.add_development_dependency 'rspec-expectations'
+  spec.add_development_dependency 'sqlite3'
 end

data/lib/iknow_view_models.rb

@@ -1,10 +1,12 @@
-require "iknow_view_models/version"
-require "view_model"
-require "view_model/controller"
-require "view_model/active_record"
-require "view_model/active_record/controller"
-require "view_model/active_record/singular_nested_controller"
-require "view_model/active_record/collection_nested_controller"
+# frozen_string_literal: true
+
+require 'iknow_view_models/version'
+require 'view_model'
+require 'view_model/controller'
+require 'view_model/active_record'
+require 'view_model/active_record/controller'
+require 'view_model/active_record/singular_nested_controller'
+require 'view_model/active_record/collection_nested_controller'
 
 module IknowViewModels
 end

data/lib/iknow_view_models/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module IknowViewModels
-  VERSION = '3.2.0'
+  VERSION = '3.2.1'
 end

data/lib/view_model.rb

@@ -6,19 +6,19 @@ require 'jbuilder'
 require 'deep_preloader'
 
 class ViewModel
-  REFERENCE_ATTRIBUTE = "_ref"
-  ID_ATTRIBUTE        = "id"
-  TYPE_ATTRIBUTE      = "_type"
-  VERSION_ATTRIBUTE   = "_version"
-  NEW_ATTRIBUTE       = "_new"
+  REFERENCE_ATTRIBUTE = '_ref'
+  ID_ATTRIBUTE        = 'id'
+  TYPE_ATTRIBUTE      = '_type'
+  VERSION_ATTRIBUTE   = '_version'
+  NEW_ATTRIBUTE       = '_new'
 
   # Migrations leave a metadata attribute _migrated on any views that they
   # alter. This attribute is accessible as metadata when deserializing migrated
   # input, and is included in the output serialization sent to clients.
-  MIGRATED_ATTRIBUTE  = "_migrated"
+  MIGRATED_ATTRIBUTE  = '_migrated'
 
   Metadata = Struct.new(:id, :view_name, :schema_version, :new, :migrated) do
-    alias :new? :new
+    alias_method :new?, :new
   end
 
   class << self
@@ -28,6 +28,7 @@ class ViewModel
     attr_writer   :view_name
 
     def inherited(subclass)
+      super
       subclass.initialize_as_viewmodel
     end
 
@@ -43,6 +44,7 @@ class ViewModel
           # try to auto-detect based on class name
           match = /(.*)View$/.match(self.name)
           raise ArgumentError.new("Could not auto-determine ViewModel name from class name '#{self.name}'") if match.nil?
+
           ViewModel::Registry.default_view_name(match[1])
         end
     end
@@ -77,6 +79,7 @@ class ViewModel
       end
 
       attr_accessor attr
+
       define_method("deserialize_#{attr}") do |value, references: {}, deserialize_context: self.class.new_deserialize_context|
         self.public_send("#{attr}=", value)
       end
@@ -122,7 +125,7 @@ class ViewModel
       hash.delete(ViewModel::REFERENCE_ATTRIBUTE)
     end
 
-    def is_update_hash?(hash)
+    def is_update_hash?(hash) # rubocop:disable Naming/PredicateName
       ViewModel::Schemas.verify_schema!(ViewModel::Schemas::VIEWMODEL_UPDATE, hash)
       hash.has_key?(ViewModel::ID_ATTRIBUTE) &&
         !hash.fetch(ViewModel::ActiveRecord::NEW_ATTRIBUTE, false)
@@ -198,12 +201,12 @@ class ViewModel
         end
 
         member_names.each do |attr|
-          if view_hash.has_key?(attr)
-            viewmodel.public_send("deserialize_#{attr}",
-                                  view_hash[attr],
-                                  references: references,
-                                  deserialize_context: deserialize_context)
-          end
+          next unless view_hash.has_key?(attr)
+
+          viewmodel.public_send("deserialize_#{attr}",
+                                view_hash[attr],
+                                references: references,
+                                deserialize_context: deserialize_context)
         end
 
         deserialize_context.run_callback(ViewModel::Callbacks::Hook::BeforeValidate, viewmodel)

data/lib/view_model/access_control.rb

@@ -13,11 +13,12 @@ require 'view_model/access_control_error'
 class ViewModel::AccessControl
   Result = Struct.new(:permit, :error) do
     def initialize(permit, error: nil)
-      raise ArgumentError.new("Successful AccessControl::Result may not have an error") if permit && error
+      raise ArgumentError.new('Successful AccessControl::Result may not have an error') if permit && error
+
       super(permit, error)
     end
 
-    alias :permit? :permit
+    alias_method :permit?, :permit
 
     # Merge this result with another access control result. Takes a block
     # returning a result, and returns a combined result for both tests. Access
@@ -129,6 +130,7 @@ class ViewModel::AccessControl
     if @initial_editability_store.has_key?(view.object_id)
       raise RuntimeError.new("Access control data already recorded for view #{view.to_reference}")
     end
+
     @initial_editability_store[view.object_id] = initial_editability
   end
 
@@ -136,6 +138,7 @@ class ViewModel::AccessControl
     unless @initial_editability_store.has_key?(view.object_id)
       raise RuntimeError.new("No access control data recorded for view #{view.to_reference}")
     end
+
     @initial_editability_store.delete(view.object_id)
   end
 

data/lib/view_model/access_control/composed.rb

@@ -8,8 +8,9 @@
 class ViewModel::AccessControl::Composed < ViewModel::AccessControl
   ComposedResult = Struct.new(:allow, :veto, :allow_error, :veto_error) do
     def initialize(allow, veto, allow_error, veto_error)
-      raise ArgumentError.new("Non-vetoing result may not have a veto error") if veto_error  && !veto
-      raise ArgumentError.new("Allowing result may not have a allow error")   if allow_error && allow
+      raise ArgumentError.new('Non-vetoing result may not have a veto error') if veto_error  && !veto
+      raise ArgumentError.new('Allowing result may not have a allow error')   if allow_error && allow
+
       super
     end
 
@@ -64,7 +65,7 @@ class ViewModel::AccessControl::Composed < ViewModel::AccessControl
     attr_reader :reasons
 
     def initialize(nodes, reasons)
-      super("Action not permitted because none of the possible conditions were met.", nodes)
+      super('Action not permitted because none of the possible conditions were met.', nodes)
       @reasons = reasons
     end
 
@@ -92,7 +93,7 @@ class ViewModel::AccessControl::Composed < ViewModel::AccessControl
     end
 
     def initialize_as_composed_access_control
-      @included_checkers   = []
+      @included_checkers = []
 
       @edit_valid_ifs      = []
       @edit_valid_unlesses = []
@@ -152,15 +153,16 @@ class ViewModel::AccessControl::Composed < ViewModel::AccessControl
       @included_checkers.each do |ancestor|
         next unless visited.add?(ancestor)
         next if include_ancestor && !include_ancestor.call(ancestor)
+
         ancestor.each_check(check_name) { |x| yield x }
       end
     end
 
     def inspect
-      s = super + "("
-      s += inspect_checks.join(", ")
+      s = super + '('
+      s += inspect_checks.join(', ')
       s += " includes checkers: #{@included_checkers.inspect}" if @included_checkers.present?
-      s += ")"
+      s += ')'
       s
     end
 
@@ -174,7 +176,6 @@ class ViewModel::AccessControl::Composed < ViewModel::AccessControl
       checks << "edit_valid_unless: #{@edit_valid_unlesses.map(&:reason)}" if @edit_valid_unlesses.present?
       checks
     end
-
   end
 
   # final
@@ -199,7 +200,7 @@ class ViewModel::AccessControl::Composed < ViewModel::AccessControl
 
     veto = vetoed_checker.present?
     if veto
-      veto_error = vetoed_checker.error_type.new("Action not permitted because: " +
+      veto_error = vetoed_checker.error_type.new('Action not permitted because: ' +
                                                  vetoed_checker.reason,
                                                  env.view.blame_reference)
     end

data/lib/view_model/access_control/open.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class ViewModel::AccessControl::Open < ViewModel::AccessControl
   def visible_check(_traversal_env)
     ViewModel::AccessControl::Result::PERMIT

data/lib/view_model/access_control/read_only.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class ViewModel::AccessControl::ReadOnly < ViewModel::AccessControl
   def visible_check(_traversal_env)
     ViewModel::AccessControl::Result::PERMIT

data/lib/view_model/access_control/tree.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 ## Defines an access control discipline for a given action against a tree of
 ## viewmodels.
 ##
@@ -78,7 +80,7 @@ class ViewModel::AccessControl::Tree < ViewModel::AccessControl
   def initialize
     super()
     @always_policy_instance = self.class::AlwaysPolicy.new(self)
-    @view_policy_instances  = self.class.view_policies.each_with_object({}) { |(name, policy), h| h[name] = policy.new(self) }
+    @view_policy_instances  = self.class.view_policies.transform_values { |policy| policy.new(self) }
     @root_visibility_store  = {}
     @root_editability_store = {}
   end
@@ -98,27 +100,29 @@ class ViewModel::AccessControl::Tree < ViewModel::AccessControl
 
   def store_descendent_editability(view, descendent_editability)
     if @root_editability_store.has_key?(view.object_id)
-      raise RuntimeError.new("Root access control data already saved for root")
+      raise RuntimeError.new('Root access control data already saved for root')
     end
+
     @root_editability_store[view.object_id] = descendent_editability
   end
 
   def fetch_descendent_editability(view)
     @root_editability_store.fetch(view.object_id) do
-      raise RuntimeError.new("No root access control data recorded for root")
+      raise RuntimeError.new('No root access control data recorded for root')
     end
   end
 
   def store_descendent_visibility(view, descendent_visibility)
     if @root_visibility_store.has_key?(view.object_id)
-      raise RuntimeError.new("Root access control data already saved for root")
+      raise RuntimeError.new('Root access control data already saved for root')
     end
+
     @root_visibility_store[view.object_id] = descendent_visibility
   end
 
   def fetch_descendent_visibility(view)
     @root_visibility_store.fetch(view.object_id) do
-      raise RuntimeError.new("No root access control data recorded for root")
+      raise RuntimeError.new('No root access control data recorded for root')
     end
   end
 
@@ -152,6 +156,7 @@ class ViewModel::AccessControl::Tree < ViewModel::AccessControl
 
       def initialize_as_node
         @root = false
+
         @root_children_editable_ifs      = []
         @root_children_editable_unlesses = []
         @root_children_visible_ifs       = []
@@ -187,7 +192,7 @@ class ViewModel::AccessControl::Tree < ViewModel::AccessControl
       def inspect_checks
         checks = super
         if root?
-          checks << "no root checks"
+          checks << 'no root checks'
         else
           checks << "root_children_visible_if: #{root_children_visible_ifs.map(&:reason)}"            if root_children_visible_ifs.present?
           checks << "root_children_visible_unless: #{root_children_visible_unlesses.map(&:reason)}"   if root_children_visible_unlesses.present?