iknow_view_models 3.2.0 → 3.2.1

data/lib/view_model/active_record/update_operation.rb

@@ -1,4 +1,6 @@
-require "renum"
+# frozen_string_literal: true
+
+require 'renum'
 
 # Partially parsed tree of user-specified update hashes, created during deserialization.
 class ViewModel::ActiveRecord
@@ -14,7 +16,7 @@ class ViewModel::ActiveRecord
                   :update_data,
                   :points_to,  # AssociationData => UpdateOperation (returns single new viewmodel to update fkey)
                   :pointed_to, # AssociationData => UpdateOperation(s) (returns viewmodel(s) with which to update assoc cache)
-                  :reparent_to,  # If node needs to update its pointer to a new parent, ParentData for the parent
+                  :reparent_to, # If node needs to update its pointer to a new parent, ParentData for the parent
                   :reposition_to, # if this node participates in a list under its parent, what should its position be?
                   :released_children # Set of children that have been released
 
@@ -46,11 +48,11 @@ class ViewModel::ActiveRecord
 
     # Evaluate a built update tree, applying and saving changes to the models.
     def run!(deserialize_context:)
-      raise ViewModel::DeserializationError::Internal.new("Internal error: UpdateOperation run before build") unless built?
+      raise ViewModel::DeserializationError::Internal.new('Internal error: UpdateOperation run before build') unless built?
 
       case @run_state
       when RunState::Running
-        raise ViewModel::DeserializationError::Internal.new("Internal error: Cycle found in running UpdateOperation")
+        raise ViewModel::DeserializationError::Internal.new('Internal error: Cycle found in running UpdateOperation')
       when RunState::Run
         return viewmodel
       end
@@ -217,7 +219,7 @@ class ViewModel::ActiveRecord
 
     # Recursively builds UpdateOperations for the associations in our UpdateData
     def build!(update_context)
-      raise ViewModel::DeserializationError::Internal.new("Internal error: UpdateOperation cannot build a deferred update") if viewmodel.nil?
+      raise ViewModel::DeserializationError::Internal.new('Internal error: UpdateOperation cannot build a deferred update') if viewmodel.nil?
       return self if built?
 
       update_data.associations.each do |association_name, association_update_data|
@@ -254,8 +256,8 @@ class ViewModel::ActiveRecord
     def add_update(association_data, update)
       target =
         case association_data.pointer_location
-        when :remote; pointed_to
-        when :local;  points_to
+        when :remote then pointed_to
+        when :local then  points_to
         end
 
       target[association_data] = update
@@ -658,7 +660,7 @@ class ViewModel::ActiveRecord
           other.indirect_viewmodel_reference == self.indirect_viewmodel_reference
       end
 
-      alias :eql? :==
+      alias eql? ==
     end
 
     # Helper class to wrap the previous members of a referenced collection and
@@ -767,6 +769,7 @@ class ViewModel::ActiveRecord
         member.ref_string = ref_string if ref_string
         member
       end
+
       def remove_from_members(removed_members)
         s = removed_members.to_set
         members.reject! { |m| s.include?(m) }
@@ -900,11 +903,12 @@ class ViewModel::ActiveRecord
 
     def clear_association_cache(model, reflection)
       association = model.association(reflection.name)
-      if reflection.collection?
-        association.target = []
-      else
-        association.target = nil
-      end
+      association.target =
+        if reflection.collection?
+          []
+        else
+          nil
+        end
     end
 
     def blame_reference

data/lib/view_model/active_record/visitor.rb

@@ -91,5 +91,4 @@ class ViewModel::ActiveRecord::Visitor
   def reset_state!
     @ignored_associations = Set.new
   end
-
 end

data/lib/view_model/after_transaction_runner.rb

@@ -38,7 +38,6 @@ module ViewModel::AfterTransactionRunner
     end
   end
 
-
   # Override to tie to a specific connection.
   def connection
     ActiveRecord::Base.connection

data/lib/view_model/callbacks.rb

@@ -79,7 +79,7 @@ module ViewModel::Callbacks
             end
           SRC
         else
-          def self.create(callbacks, view, context)
+          def self.create(callbacks, view, context) # rubocop:disable Lint/NestedMethodDefinition
             self.new(callbacks, view, context)
           end
         end
@@ -105,6 +105,7 @@ module ViewModel::Callbacks
     define_singleton_method(:class_callbacks) { base_callbacks }
     define_singleton_method(:all_callbacks) do |&block|
       return to_enum(__method__) unless block
+
       block.call(base_callbacks)
     end
   end
@@ -115,6 +116,7 @@ module ViewModel::Callbacks
       subclass.define_singleton_method(:class_callbacks) { subclass_callbacks }
       subclass.define_singleton_method(:all_callbacks) do |&block|
         return to_enum(__method__) unless block
+
         super(&block)
         block.call(subclass_callbacks)
       end

data/lib/view_model/controller.rb

@@ -88,6 +88,7 @@ module ViewModel::Controller
       if data.blank?
         raise ViewModel::Error.new(status: 400, detail: "No data submitted: #{data.inspect}")
       end
+
       data.map { |el| _extract_param_hash(el) }
     else
       _extract_param_hash(data)
@@ -129,9 +130,18 @@ module ViewModel::Controller
   # untouched. Requires a MultiJson adapter other than ActiveSupport's
   # (modified) JsonGem.
   class CompiledJson
-    def initialize(s);  @s = s; end
-    def to_json(*args); @s;     end
-    def to_s;           @s;     end
+    def initialize(s)
+      @s = s
+    end
+
+    def to_json(*_args)
+      @s
+    end
+
+    def to_s
+      @s
+    end
+
     undef_method :as_json
   end
 

data/lib/view_model/deserialization_error.rb

@@ -15,13 +15,14 @@ class ViewModel
       unless nodes.all? { |n| n.viewmodel_class == first }
         raise ArgumentError.new("All nodes must be of the same type for #{self.class.name}")
       end
+
       first
     end
 
     # A collection of DeserializationErrors
     class Collection < ViewModel::AbstractErrorCollection
-      title "Error(s) occurred during deserialization"
-      code  "DeserializationError.Collection"
+      title 'Error(s) occurred during deserialization'
+      code  'DeserializationError.Collection'
 
       def detail
         "Error(s) occurred during deserialization: #{cause_details}"
@@ -33,7 +34,7 @@ class ViewModel
     class InvalidRequest < DeserializationError
       # Abstract
       status 400
-      title "Invalid request"
+      title 'Invalid request'
     end
 
     # There has been an unexpected internal failure of the ViewModel library.
@@ -145,6 +146,7 @@ class ViewModel
     # association.
     class InvalidAssociationType < InvalidRequest
       attr_reader :association, :target_type
+
       def initialize(association, target_type, node)
         @association = association
         @target_type = target_type
@@ -198,7 +200,7 @@ class ViewModel
       end
 
       def detail
-        errors = missing_nodes.map(&:to_s).join(", ")
+        errors = missing_nodes.map(&:to_s).join(', ')
         "Couldn't find requested member node(s) in association '#{association}': "\
         "#{errors}"
       end
@@ -218,7 +220,7 @@ class ViewModel
       end
 
       def detail
-        "Duplicate views for the same '#{type}' specified: "+ nodes.map(&:to_s).join(", ")
+        "Duplicate views for the same '#{type}' specified: " + nodes.map(&:to_s).join(', ')
       end
 
       def meta
@@ -235,14 +237,14 @@ class ViewModel
       end
 
       def detail
-        "Multiple parents attempted to claim the same owned '#{association_name}' reference: " + nodes.map(&:to_s).join(", ")
+        "Multiple parents attempted to claim the same owned '#{association_name}' reference: " + nodes.map(&:to_s).join(', ')
       end
     end
 
     class ParentNotFound < NotFound
       def detail
-        "Could not resolve release from previous parent for the following owned viewmodel(s): " +
-          nodes.map(&:to_s).join(", ")
+        'Could not resolve release from previous parent for the following owned viewmodel(s): ' +
+          nodes.map(&:to_s).join(', ')
       end
     end
 
@@ -284,7 +286,7 @@ class ViewModel
 
     class ReadOnlyType < DeserializationError
       status 400
-      detail "Deserialization not defined for view type"
+      detail 'Deserialization not defined for view type'
     end
 
     class InvalidAttributeType < InvalidRequest
@@ -326,7 +328,7 @@ class ViewModel
       status 400
 
       def detail
-        errors = nodes.map(&:to_s).join(", ")
+        errors = nodes.map(&:to_s).join(', ')
         "Optimistic lock failure updating nodes: #{errors}"
       end
     end
@@ -408,8 +410,9 @@ class ViewModel
 
         private
 
-        QUOTED_IDENTIFIER   = /\A"(?:[^"]|"")+"/
-        UNQUOTED_IDENTIFIER = /\A(?:\p{Alpha}|_)(?:\p{Alnum}|_)*/
+        QUOTED_IDENTIFIER   = /\A"(?:[^"]|"")+"/.freeze
+        UNQUOTED_IDENTIFIER = /\A(?:\p{Alpha}|_)(?:\p{Alnum}|_)*/.freeze
+
         def parse_identifier(stream)
           if (identifier = stream.slice!(UNQUOTED_IDENTIFIER))
             identifier

data/lib/view_model/error.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Abstract base for renderable errors in ViewModel-based APIs. Errors of this
 # type will be caught by ViewModel controllers and rendered in a standard format
 # by ViewModel::ErrorView, which loosely follows errors in JSON-API.
@@ -6,7 +8,7 @@ class ViewModel::AbstractError < StandardError
     # Brief DSL for quickly defining constant attribute values in subclasses
     [:detail, :status, :title, :code].each do |attribute|
       define_method(attribute) do |x|
-        define_method(attribute){ x }
+        define_method(attribute) { x }
       end
     end
   end
@@ -25,7 +27,7 @@ class ViewModel::AbstractError < StandardError
 
   # Human-readable reason for use displaying this error.
   def detail
-    "ViewModel::AbstractError"
+    'ViewModel::AbstractError'
   end
 
   # HTTP status code most appropriate for this error
@@ -40,7 +42,7 @@ class ViewModel::AbstractError < StandardError
 
   # Unique symbol identifying this error type
   def code
-    "ViewModel.AbstractError"
+    'ViewModel.AbstractError'
   end
 
   # Additional information specific to this error type.
@@ -74,8 +76,6 @@ class ViewModel::AbstractError < StandardError
 
   protected
 
-
-
   def format_references(viewmodel_refs)
     viewmodel_refs.map do |viewmodel_ref|
       format_reference(viewmodel_ref)
@@ -85,7 +85,7 @@ class ViewModel::AbstractError < StandardError
   def format_reference(viewmodel_ref)
     {
       ViewModel::TYPE_ATTRIBUTE => viewmodel_ref.viewmodel_class.view_name,
-      ViewModel::ID_ATTRIBUTE   => viewmodel_ref.model_id
+      ViewModel::ID_ATTRIBUTE   => viewmodel_ref.model_id,
     }
   end
 end
@@ -100,12 +100,13 @@ class ViewModel::AbstractErrorWithBlame < ViewModel::AbstractError
     unless @nodes.all? { |n| n.is_a?(ViewModel::Reference) }
       raise ArgumentError.new("#{self.class.name}: 'blame_nodes' must all be of type ViewModel::Reference")
     end
+
     super()
   end
 
   def meta
     {
-      nodes: format_references(nodes)
+      nodes: format_references(nodes),
     }
   end
 end
@@ -117,8 +118,9 @@ class ViewModel::AbstractErrorCollection < ViewModel::AbstractError
   def initialize(causes)
     @causes = Array.wrap(causes)
     unless @causes.present?
-      raise ArgumentError.new("A collection must have at least one cause")
+      raise ArgumentError.new('A collection must have at least one cause')
     end
+
     super()
   end
 
@@ -151,7 +153,7 @@ class ViewModel::AbstractErrorCollection < ViewModel::AbstractError
   protected
 
   def cause_details
-    causes.map(&:detail).join("; ")
+    causes.map(&:detail).join('; ')
   end
 end
 
@@ -180,7 +182,7 @@ end
 class ViewModel::Error < ViewModel::AbstractError
   attr_reader :detail, :status, :title, :code, :meta
 
-  def initialize(status: 400, detail: "ViewModel Error", title: nil, code: nil, meta: {})
+  def initialize(status: 400, detail: 'ViewModel Error', title: nil, code: nil, meta: {})
     @detail = detail
     @status = status
     @title  = title

data/lib/view_model/error_view.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'view_model/record'
 
 # ViewModel for rendering ViewModel::AbstractErrors
@@ -10,7 +12,7 @@ class ViewModel::ErrorView < ViewModel::Record
     def serialize_view(json, serialize_context: nil)
       json.set! :class, exception.class.name
       json.backtrace exception.backtrace
-      if cause = exception.cause
+      if (cause = exception.cause)
         json.cause do
           json.set! :class, cause.class.name
           json.backtrace cause.backtrace

data/lib/view_model/migration/no_path_error.rb

@@ -9,6 +9,7 @@ class ViewModel::Migration::NoPathError < ViewModel::AbstractError
     @vm_name = viewmodel.view_name
     @from = from
     @to = to
+    super()
   end
 
   def detail

data/lib/view_model/migration/one_way_error.rb

@@ -8,6 +8,7 @@ class ViewModel::Migration::OneWayError < ViewModel::AbstractError
   def initialize(vm_name, direction)
     @vm_name = vm_name
     @direction = direction
+    super()
   end
 
   def detail

data/lib/view_model/migration/unspecified_version_error.rb

@@ -8,6 +8,7 @@ class ViewModel::Migration::UnspecifiedVersionError < ViewModel::AbstractError
   def initialize(vm_name, version)
     @vm_name = vm_name
     @version = version
+    super()
   end
 
   def detail

data/lib/view_model/record.rb

@@ -116,7 +116,7 @@ class ViewModel::Record < ViewModel
       end
     end
 
-    def resolve_viewmodel(metadata, view_hash, deserialize_context:)
+    def resolve_viewmodel(_metadata, _view_hash, deserialize_context:)
       self.for_new_model
     end
 
@@ -181,6 +181,8 @@ class ViewModel::Record < ViewModel
     @changed_attributes            = []
     @changed_nested_children       = false
     @changed_referenced_children   = false
+
+    super()
   end
 
   # VM::Record identity matches the identity of its model. If the model has a
@@ -309,12 +311,10 @@ class ViewModel::Record < ViewModel
       # viewmodel), it's only desired for converting the value to and from wire
       # format, so conversion is deferred to serialization time.
       value = attr_data.map_value(value) do |v|
-        begin
-          attr_data.attribute_serializer.dump(v, json: true)
-        rescue IknowParams::Serializer::DumpError => ex
-          raise ViewModel::SerializationError.new(
-                  "Could not serialize invalid value '#{vm_attr_name}': #{ex.message}")
-        end
+        attr_data.attribute_serializer.dump(v, json: true)
+      rescue IknowParams::Serializer::DumpError => ex
+        raise ViewModel::SerializationError.new(
+                "Could not serialize invalid value '#{vm_attr_name}': #{ex.message}")
       end
     end
 
@@ -342,12 +342,10 @@ class ViewModel::Record < ViewModel
         end
       when attr_data.using_serializer?
         attr_data.map_value(serialized_value) do |sv|
-          begin
-            attr_data.attribute_serializer.load(sv)
-          rescue IknowParams::Serializer::LoadError => ex
-            reason = "could not be deserialized because #{ex.message}"
-            raise ViewModel::DeserializationError::Validation.new(vm_attr_name, reason, {}, blame_reference)
-          end
+          attr_data.attribute_serializer.load(sv)
+        rescue IknowParams::Serializer::LoadError => ex
+          reason = "could not be deserialized because #{ex.message}"
+          raise ViewModel::DeserializationError::Validation.new(vm_attr_name, reason, {}, blame_reference)
         end
       else
         serialized_value

data/lib/view_model/reference.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class ViewModel
   # Key to identify a viewmodel with some kind of inherent ID (e.g. an ViewModel::ActiveRecord)
   class Reference
@@ -22,7 +24,7 @@ class ViewModel
         other.model_id        == model_id
     end
 
-    alias :eql? :==
+    alias eql? ==
 
     def hash
       [viewmodel_class, model_id].hash