hyrax 2.6.0 → 2.9.0

data/spec/views/hyrax/dashboard/collections/_show_subcollection_actions.html.erb_spec.rb

@@ -1,62 +0,0 @@
-RSpec.describe 'hyrax/dashboard/collections/_show_subcollection_actions.html.erb', type: :view do
-  let(:presenter) do
-    double('Hyrax::CollectionPresenter',
-           collection_type_is_nestable?: is_nestable,
-           collection: collection,
-           id: '123',
-           user_can_nest_collection?: can_deposit,
-           user_can_create_new_nest_collection?: can_create)
-  end
-  let(:collection) { double('A Collection') }
-  let(:is_nestable) { true }
-  let(:can_deposit) { true }
-  let(:can_create) { true }
-
-  before do
-    allow(view).to receive(:presenter).and_return(presenter)
-  end
-
-  describe 'when user has permission to create subcollections' do
-    before do
-      render
-    end
-
-    it 'renders a links to nest subcollection options' do
-      expect(rendered).to have_button(I18n.t('hyrax.collection.actions.nest_collections.desc'))
-      expect(rendered).to have_css(".btn[href='#{hyrax.dashboard_create_subcollection_under_path(parent_id: presenter.id)}']")
-    end
-  end
-
-  describe 'when the collection_type is not nestable' do
-    let(:is_nestable) { false }
-
-    it 'does not render a link to add_collections to this collection' do
-      render
-      expect(rendered).not_to have_css(".actions-controls-collections .btn[href='#{hyrax.dashboard_create_subcollection_under_path(parent_id: presenter.id)}']")
-    end
-  end
-
-  describe 'when user has no nesting permissions' do
-    let(:can_deposit) { false }
-
-    describe 'when the collection_type is nestable' do
-      it 'does not render a either nesting option' do
-        render
-        expect(rendered).not_to have_button(I18n.t('hyrax.collection.actions.nest_collections.desc'))
-        expect(rendered).not_to have_css(".actions-controls-collections .btn[href='#{hyrax.dashboard_create_subcollection_under_path(parent_id: presenter.id)}']")
-      end
-    end
-  end
-
-  describe 'when user cannot create new collection' do
-    let(:can_create) { false }
-
-    describe 'when the collection_type is nestable' do
-      it 'does not render a button to create a new collection' do
-        render
-        expect(rendered).to have_button(I18n.t('hyrax.collection.actions.nest_collections.desc'))
-        expect(rendered).not_to have_css(".actions-controls-collections .btn[href='#{hyrax.dashboard_create_subcollection_under_path(parent_id: presenter.id)}']")
-      end
-    end
-  end
-end

data/spec/views/hyrax/dashboard/collections/_sort_and_per_page.html.erb_spec.rb

@@ -1,60 +0,0 @@
-RSpec.describe 'hyrax/dashboard/collections/_sort_and_per_page.html.erb', type: :view do
-  let(:subject) { 'hyrax/dashboard/collections/sort_and_per_page.html.erb' }
-  let(:collection) { instance_double(Collection) }
-
-  before do
-    allow(view).to receive(:show_sort_and_per_page?).and_return(true)
-    allow(view).to receive(:dashboard_collection_path).and_return("collection/path")
-    stub_template('_view_type_group.erb' => "")
-  end
-
-  context "when there are multiple sort fields" do
-    let(:active_sort_fields) do
-      {
-        "sort field value 1" => Blacklight::Configuration::SortField.new(label: "sort field label 1"),
-        "sort field value 2" => Blacklight::Configuration::SortField.new(label: "sort field label 2")
-      }
-    end
-
-    it "renders the sort options without any selected when no sort param given" do
-      render(subject, collection: collection, active_sort_fields: active_sort_fields)
-      expect(rendered).to have_select('sort', options: ["sort field label 1", "sort field label 2"], with_selected: [])
-    end
-
-    it "renders the sort options with the correct option selected when a valid sort param given" do
-      allow(view).to receive(:params).and_return(sort: "sort field value 1")
-      render(subject, collection: collection, active_sort_fields: active_sort_fields)
-      expect(rendered).to have_select('sort', options: ["sort field label 1", "sort field label 2"], with_selected: ["sort field label 1"])
-    end
-
-    it "renders the sort options without any selected when an invalid sort param given" do
-      allow(view).to receive(:params).and_return(sort: "sort field value DNE")
-      render(subject, collection: collection, active_sort_fields: active_sort_fields)
-      expect(rendered).to have_select('sort', options: ["sort field label 1", "sort field label 2"], with_selected: [])
-    end
-  end
-
-  context "when there is only one sort field" do
-    let(:active_sort_fields) do
-      {
-        "sort field value 1" => Blacklight::Configuration::SortField.new(label: "sort field label 1")
-      }
-    end
-
-    it "does not render sort options" do
-      render(subject, collection: collection, active_sort_fields: active_sort_fields)
-      expect(rendered).not_to have_select('sort')
-    end
-  end
-
-  context "when there are no sort fields" do
-    let(:active_sort_fields) do
-      {}
-    end
-
-    it "does not render sort options" do
-      render(subject, collection: collection, active_sort_fields: active_sort_fields)
-      expect(rendered).not_to have_select('sort')
-    end
-  end
-end

data/spec/views/hyrax/dashboard/collections/_subcollection_list.html.erb_spec.rb

@@ -1,75 +0,0 @@
-RSpec.describe 'hyrax/dashboard/collections/_subcollection_list.html.erb', type: :view do
-  let(:user) { create :user }
-  let(:ability) { instance_double("Ability") }
-  let(:collection) { stub_model(Collection, id: '123') }
-  let(:subject) { render('subcollection_list.html.erb', id: collection.id, collection: subcollection) }
-
-  before do
-    allow(view).to receive(:id).and_return(collection.id)
-    allow(view).to receive(:current_ability).and_return(ability)
-    allow(controller).to receive(:can?).with(:edit, collection.id).and_return true
-  end
-
-  context 'when subcollection list is empty' do
-    let(:subcollection) { nil }
-
-    before do
-      assign(:subcollection_docs, subcollection)
-    end
-
-    it "posts a warning message" do
-      render('subcollection_list.html.erb', collection: subcollection)
-      expect(rendered).to have_text("There are no visible subcollections.")
-    end
-  end
-
-  context 'when subcollection list is not empty' do
-    let(:subcollection) { [collection] }
-
-    before do
-      assign(:subcollection_docs, subcollection)
-      assign(:document, collection)
-      allow(collection).to receive(:title_or_label).and_return(collection.title)
-      # make the collection "persisted" so the route returned is valid for show
-      allow(collection).to receive(:persisted?).and_return true
-      stub_template "hyrax/collections/_paginate" => "<div>paginate</div>"
-    end
-
-    context 'when user has edit access to the collection' do
-      before do
-        allow(controller).to receive(:can?).with(:edit, collection.id).and_return true
-      end
-
-      it "includes link to the collection and remove button" do
-        subject
-        expect(rendered).to have_link(collection.title.to_s)
-        expect(subject).to render_template('_modal_remove_sub_collection')
-      end
-
-      it "renders the proper data attributes on list element" do
-        expect(subject).to have_selector(:css, 'li[data-post-url="/dashboard/collections/123/remove_child/123"]')
-        expect(subject).to have_selector(:css, 'li[data-id="123"]')
-      end
-
-      it 'renders pagination' do
-        expect(subject).to render_template("hyrax/collections/_paginate")
-      end
-    end
-
-    context 'when user has no edit access to the collection' do
-      before do
-        allow(controller).to receive(:can?).with(:edit, collection.id).and_return false
-      end
-
-      it "includes link to the collection and no remove button" do
-        subject
-        expect(rendered).to have_link(collection.title.to_s)
-        expect(subject).not_to render_template('_modal_remove_sub_collection')
-      end
-
-      it 'renders pagination' do
-        expect(subject).to render_template("hyrax/collections/_paginate")
-      end
-    end
-  end
-end

data/spec/views/hyrax/dashboard/collections/_work_action_menu.html.erb_spec.rb

@@ -1,18 +0,0 @@
-require 'spec_helper'
-
-RSpec.describe 'hyrax/dashboard/collections/_work_action_menu.html.erb', type: :view do
-  let(:item) { stub_model(GenericWork) }
-  let(:collection) { stub_model(Collection) }
-
-  before do
-    allow(view).to receive(:display_trophy_link)
-    assign(:collection, collection)
-    render 'hyrax/dashboard/collections/work_action_menu', document: item
-  end
-
-  it "generates a form that can remove the item" do
-    expect(rendered).to have_selector("form[action=\"#{hyrax.dashboard_collection_path(collection)}\"]")
-    expect(rendered).to have_selector('input#collection_members[type="hidden"][value="remove"]', visible: false)
-    expect(rendered).to have_selector("input[type='hidden'][name='batch_document_ids[]'][value='#{item.id}']", visible: false)
-  end
-end

data/spec/views/hyrax/dashboard/collections/edit.html.erb_spec.rb

@@ -1,20 +0,0 @@
-RSpec.describe 'hyrax/dashboard/collections/edit.html.erb', type: :view do
-  let(:collection_type) { stub_model(Hyrax::CollectionType) }
-  let(:collection) { stub_model(Collection, id: 'xyz123z4', title: ["Make Collections Great Again"]) }
-  let(:form) { Hyrax::Forms::CollectionForm.new(collection, double, double) }
-
-  before do
-    assign(:collection, collection)
-    assign(:form, form)
-    allow(collection).to receive(:collection_type).and_return(collection_type)
-    stub_template '_form.html.erb' => 'my-edit-form partial'
-    stub_template '_flash_msg.html.erb' => 'flash_msg partial'
-
-    render
-  end
-
-  it 'displays the page' do
-    expect(rendered).to have_content 'my-edit-form partial'
-    expect(rendered).to have_content 'flash_msg partial'
-  end
-end

data/spec/views/hyrax/dashboard/collections/show.html.erb_spec.rb

@@ -1,116 +0,0 @@
-RSpec.describe 'hyrax/dashboard/collections/show.html.erb', type: :view do
-  let(:document) do
-    SolrDocument.new(id: 'xyz123z4',
-                     'title_tesim' => ['Make Collections Great Again'],
-                     'rights_tesim' => ["http://creativecommons.org/licenses/by-sa/3.0/us/"])
-  end
-  let(:ability) { double }
-  let(:collection) { mock_model(Collection) }
-  let(:presenter) { Hyrax::CollectionPresenter.new(document, ability) }
-  let(:collection_type) { double }
-
-  before do
-    user = stub_model(User)
-    allow(document).to receive(:hydra_model).and_return(::Collection)
-    allow(view).to receive(:current_user).and_return(user)
-    allow(view).to receive(:can?).with(:edit, document).and_return(true)
-    allow(view).to receive(:can?).with(:destroy, document).and_return(true)
-    allow(view).to receive(:current_ability).and_return(ability)
-    allow(ability).to receive(:current_user).and_return(user)
-
-    allow(Collection).to receive(:find).with(document.id).and_return(collection)
-
-    allow(presenter).to receive(:total_items).and_return(0)
-    allow(presenter).to receive(:collection_type).and_return(collection_type)
-    allow(presenter).to receive(:subcollection_count).and_return(0)
-    assign(:parent_collection_count, 0)
-    assign(:members_count, 0)
-
-    allow(collection_type).to receive(:nestable?).and_return(true)
-    allow(collection_type).to receive(:title).and_return("User Collection")
-    allow(collection_type).to receive(:badge_color).and_return("#ffa510")
-
-    assign(:presenter, presenter)
-    # Stub route because view specs don't handle engine routes
-    allow(view).to receive(:edit_dashboard_collection_path).and_return("/dashboard/collection/123/edit")
-    allow(view).to receive(:dashboard_collection_path).and_return("/dashboard/collection/123")
-    allow(view).to receive(:collection_path).and_return("/collection/123")
-
-    stub_template '_search_form.html.erb' => 'search form'
-    stub_template 'hyrax/dashboard/collections/_sort_and_per_page.html.erb' => 'sort and per page'
-    stub_template '_document_list.html.erb' => 'document list'
-    # This is tested ./spec/views/hyrax/dashboard/collections/_show_actions.html.erb_spec.rb
-    stub_template '_show_actions.html.erb' => '<div class="stubbed-actions">THE COLLECTION ACTIONS</div>'
-    stub_template '_show_subcollection_actions.html.erb' => '<div class="stubbed-actions">THE SUBCOLLECTION ACTIONS</div>'
-    stub_template '_show_add_items_actions.html.erb' => '<div class="stubbed-actions">THE ADD ITEMS ACTIONS</div>'
-    stub_template '_show_parent_collections.html.erb' => '<div class="stubbed-actions">THE PARENT COLLECTIONS LIST</div>'
-    stub_template '_subcollection_list.html.erb' => '<div class="stubbed-actions">THE SUB-COLLECTIONS LIST</div>'
-    stub_template 'hyrax/collections/_paginate.html.erb' => 'paginate'
-    stub_template 'hyrax/collections/_media_display.html.erb' => '<span class="fa fa-cubes collection-icon-search"></span>'
-    stub_template 'hyrax/my/collections/_modal_add_to_collection.html.erb' => 'modal add as subcollection'
-    stub_template 'hyrax/my/collections/_modal_add_subcollection.html.erb' => 'modal add as parent'
-  end
-
-  it 'draws the page' do
-    render
-    # Making sure that we are verifying that the _show_actions.html.erb is rendering
-    expect(rendered).to have_css('.stubbed-actions', text: 'THE COLLECTION ACTIONS')
-    expect(rendered).to have_css('.stubbed-actions', text: 'THE SUBCOLLECTION ACTIONS')
-    expect(rendered).to have_css('.stubbed-actions', text: 'THE ADD ITEMS ACTIONS')
-    expect(rendered).to match '<span class="fa fa-cubes collection-icon-search"></span>'
-    expect(rendered).not_to have_text('Search Results within this Collection')
-  end
-
-  context 'with a not-nested collection_type' do
-    before do
-      allow(presenter).to receive(:subcollection_count).and_return(0)
-      render
-    end
-    it 'draws the page' do
-      allow(collection_type).to receive(:nestable?).and_return(false)
-      # Making sure that we are verifying that the _show_actions.html.erb is rendering
-      expect(rendered).to have_css('.stubbed-actions', text: 'THE COLLECTION ACTIONS')
-      expect(rendered).to have_css('.stubbed-actions', text: 'THE SUBCOLLECTION ACTIONS')
-      expect(rendered).to have_css('.stubbed-actions', text: 'THE ADD ITEMS ACTIONS')
-      expect(rendered).to match '<span class="fa fa-cubes collection-icon-search"></span>'
-      expect(rendered).not_to have_text('Search Results within this Collection')
-    end
-  end
-
-  context 'when search results exist' do
-    before do
-      # rubocop:disable RSpec/AnyInstance
-      allow_any_instance_of(Hyrax::CollectionsHelper).to receive(:has_collection_search_parameters?).and_return(true)
-      # rubocop:enable RSpec/AnyInstance
-    end
-
-    context 'and only works are in search results' do
-      before do
-        assign(:members_count, 1)
-        render
-      end
-
-      it 'shows results header' do
-        expect(rendered).to have_text('Search Results within this Collection')
-        expect(rendered).to have_css('.stubbed-actions', text: 'THE COLLECTION ACTIONS')
-        expect(rendered).not_to have_css('.stubbed-actions', text: 'THE SUBCOLLECTION ACTIONS')
-        expect(rendered).not_to have_css('.stubbed-actions', text: 'THE ADD ITEMS ACTIONS')
-      end
-    end
-
-    context ' and only subcollections are in search results' do
-      before do
-        allow(presenter).to receive(:subcollection_count).and_return(1)
-        assign(:members_count, 0)
-        render
-      end
-
-      it 'shows results header' do
-        expect(rendered).to have_text('Search Results within this Collection')
-        expect(rendered).to have_css('.stubbed-actions', text: 'THE COLLECTION ACTIONS')
-        expect(rendered).not_to have_css('.stubbed-actions', text: 'THE SUBCOLLECTION ACTIONS')
-        expect(rendered).not_to have_css('.stubbed-actions', text: 'THE ADD ITEMS ACTIONS')
-      end
-    end
-  end
-end

data/spec/views/hyrax/dashboard/profiles/_trophy_edit.html.erb_spec.rb

@@ -1,36 +0,0 @@
-RSpec.describe 'hyrax/dashboard/profiles/_trophy_edit.html.erb', type: :view do
-  let(:user) { stub_model(User, user_key: 'mjg') }
-  let(:page) { Capybara::Node::Simple.new(rendered) }
-
-  before do
-    allow(view).to receive(:signed_in?).and_return(true)
-    allow(view).to receive(:current_user).and_return(user)
-    assign(:user, user)
-  end
-
-  context "when there are no highlighted works" do
-    before do
-      assign(:trophies, [])
-      render 'edit_primary'
-    end
-
-    it "has no trophy" do
-      expect(page).not_to have_css('a#remove_trophy_help')
-      expect(page).not_to have_content('Remove Highlight Designation')
-    end
-  end
-
-  context "when there are highlighted works" do
-    let(:solr_document) { SolrDocument.new(id: 'abc123', has_model_ssim: 'GenericWork', title_tesim: ['Title']) }
-
-    before do
-      assign(:trophies, [Hyrax::TrophyPresenter.new(solr_document)])
-      render 'edit_primary'
-    end
-
-    it "has trophy" do
-      expect(page).to have_css('a#remove_trophy_help')
-      expect(page).to have_selector("#remove_trophy_abc123")
-    end
-  end
-end

data/spec/views/hyrax/dashboard/profiles/edit.html.erb_spec.rb

@@ -1,67 +0,0 @@
-RSpec.describe 'hyrax/dashboard/profiles/edit.html.erb', type: :view do
-  let(:user) { stub_model(User, user_key: 'mjg') }
-
-  before do
-    allow(view).to receive(:signed_in?).and_return(true)
-    allow(view).to receive(:current_user).and_return(user)
-    assign(:user, user)
-    assign(:trophies, [])
-  end
-
-  it "shows an ORCID field" do
-    render
-    expect(rendered).to match(/ORCID Profile/)
-  end
-
-  context 'with Zotero integration enabled' do
-    before do
-      allow(Hyrax.config).to receive(:arkivo_api?) { true }
-    end
-
-    it 'shows a Zotero label' do
-      render
-      expect(rendered).to match(/Zotero Profile/)
-    end
-
-    context 'with a userID already set on the user instance' do
-      before do
-        allow(user).to receive(:zotero_userid) { '12345' }
-        render
-      end
-
-      it 'shows a link to the Zotero profile' do
-        expect(rendered).to have_link("Connected!", href: "https://www.zotero.org/users/12345")
-      end
-    end
-
-    context 'with no existing token' do
-      before { render }
-
-      it 'shows a Zotero OAuth button' do
-        expect(rendered).to have_css('a#zotero')
-      end
-    end
-
-    context 'with an existing token, in the production env' do
-      before do
-        allow(Rails.env).to receive(:production?) { true }
-        render
-      end
-
-      it 'shows a Zotero OAuth button' do
-        expect(rendered).to have_css('a#zotero')
-      end
-    end
-  end
-
-  context 'with Zotero integration disabled' do
-    before do
-      allow(Hyrax.config).to receive(:arkivo_api?) { false }
-    end
-
-    it 'hides a Zotero OAuth button' do
-      render
-      expect(subject).not_to have_css('a#zotero')
-    end
-  end
-end